Re: [Rpm-maint] [rpm-software-management/rpm] Do not hardcode "lib/rpm" as the installation path for default config… (#263)
@pmatilai Okay, splitting things into two places is bad. How about not hardcoding the 'lib' part? Should I open a separate PR for it? -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/263#issuecomment-319639985___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Do not hardcode "lib/rpm" as the installation path for default config… (#263)
Closed #263. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/263#event-1189319031___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Do not hardcode "lib/rpm" as the installation path for default config… (#263)
@Conan-Kudo in Yocto the generated platform macros are not used, as there is a hardcoded list of those platforms, which is not flexible enough for us. So we directly override settings from the default macros file at runtime. However, for some reason _libdir is not overriden in the same way, and is instead configured at build time - so you have a point, I should change that. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/263#issuecomment-319638245___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Do not hardcode "lib/rpm" as the installation path for default config… (#263)
My personal preference is to keep $prefix/lib/rpm hardcoded. We do this in systemd, casync and a lot of other tools. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/263#issuecomment-319636312___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Do not hardcode "lib/rpm" as the installation path for default config… (#263)
@pmatilai We could at least move things to `$(libexecdir)/rpm` and for Fedora have a symlink for the old location to point to the new one. That'd keep things consistent, right? -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/263#issuecomment-319635899___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Do not hardcode "lib/rpm" as the installation path for default config… (#263)
@kanavin The values in macros.in are overridden by the generated platform macros: https://github.com/rpm-software-management/rpm/blob/master/platform.in As far as I know, as long as you aren't purging the platforms, this doesn't matter. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/263#issuecomment-319629413___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Do not hardcode "lib/rpm" as the installation path for default config… (#263)
@Conan-Kudo In Yocto project the libdir can be lib, lib32, lib64, or anything else. You cannot assume anything about it, and when building the software, the value for it is typically passed to ./configure as a command line switch. On the other hand, %_libdir macro hardcodes the value to be /usr/lib, and then that macro is used all over the place in rpm. So I am removing that hardcoding, and setting the macro dynamically at build time from the build environment settings. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/263#issuecomment-319627324___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Do not hardcode "lib/rpm" as the installation path for default config… (#263)
Previously it was set this way:
```
%_lib lib
%_libdir%{_exec_prefix}/%{_lib}
```
So basically 'lib' was hardcoded via %_lib. If you show me how to avoid that in
a different way than my patch, I can do it.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/263#issuecomment-319375522___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Do not hardcode "lib/rpm" as the installation path for default config… (#263)
@kanavin I think the only issue is the change to `%_libdir`. Is that really necessary? It's set up that way so that it can be flexible. I'd rather see this change reverted. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/263#issuecomment-319371588___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Do not hardcode "lib/rpm" as the installation path for default config… (#263)
Conan-Kudo commented on this pull request.
> @@ -942,7 +942,7 @@ package or when debugging this package.\
%_sharedstatedir %{_prefix}/com
%_localstatedir%{_prefix}/var
%_lib lib
-%_libdir %{_exec_prefix}/%{_lib}
+%_libdir @libdir@
I think the reason it's like this is to support the weird multiarch schemes
that some distributions use... 路♂️
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/263#discussion_r128895112___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Do not hardcode "lib/rpm" as the installation path for default config… (#263)
Conan-Kudo commented on this pull request. > @@ -1,10 +1,10 @@ # Internal binaries ## HACK: It probably should be $(libexecdir)/rpm or $(libdir)/rpm -rpmlibexecdir = $(prefix)/lib/rpm +rpmlibexecdir = $(libdir)/rpm This should be `$(libexecdir)` here too. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/263#discussion_r128895076___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Do not hardcode "lib/rpm" as the installation path for default config… (#263)
ignatenkobrain requested changes on this pull request.
> @@ -942,7 +942,7 @@ package or when debugging this package.\
%_sharedstatedir %{_prefix}/com
%_localstatedir%{_prefix}/var
%_lib lib
-%_libdir %{_exec_prefix}/%{_lib}
+%_libdir @libdir@
+1
> @@ -1,10 +1,10 @@
# Internal binaries
## HACK: It probably should be $(libexecdir)/rpm or $(libdir)/rpm
-rpmlibexecdir = $(prefix)/lib/rpm
+rpmlibexecdir = $(libdir)/rpm
+1
> @@ -1005,7 +1005,7 @@ else
usrprefix=$prefix
fi
-RPMCONFIGDIR="`echo ${usrprefix}/lib/rpm`"
+RPMCONFIGDIR="`echo ${libdir}/rpm`"
We probably should really use libexecdir
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/263#pullrequestreview-51621002___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Do not hardcode "lib/rpm" as the installation path for default config… (#263)
Conan-Kudo requested changes on this pull request.
So this can be a problem, because on LSB-compliant 64-bit systems (i.e. most of
them running RPM), `${libdir}` is `/usr/lib64`.
If we wanted to move it anywhere, we'd probably move it to `${libexecdir}`,
since that is static across architectures, and would more or less have the same
effect you're looking for.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/263#pullrequestreview-51180631___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint
[Rpm-maint] [rpm-software-management/rpm] Do not hardcode "lib/rpm" as the installation path for default config… (#263)
…uration and macros. This can be named in various different ways, especially in cross-compilation environments, so let's take it from the build setup. You can view, comment on, or merge this pull request online at: https://github.com/rpm-software-management/rpm/pull/263 -- Commit Summary -- * Do not hardcode "lib/rpm" as the installation path for default configuration and macros. -- File Changes -- M configure.ac (2) M macros.in (2) M rpm.am (4) -- Patch Links -- https://github.com/rpm-software-management/rpm/pull/263.patch https://github.com/rpm-software-management/rpm/pull/263.diff -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/263 ___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
