Re: [Rpm-maint] [rpm-software-management/rpm] Document fork, exec, wait and redirect2null Lua functions as deprecated (PR #2948)

2024-03-14 Thread Florian Festi
Merged #2948 into master.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/2948#event-12119110094
You are receiving this because you are subscribed to this thread.

Message ID: 
___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint


Re: [Rpm-maint] [rpm-software-management/rpm] Document fork, exec, wait and redirect2null Lua functions as deprecated (PR #2948)

2024-03-14 Thread Panu Matilainen
Added note about the removal schedule, and noisy deprecation warnings on every 
use to go.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/2948#issuecomment-1997552547
You are receiving this because you are subscribed to this thread.

Message ID: ___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint


Re: [Rpm-maint] [rpm-software-management/rpm] Document fork, exec, wait and redirect2null Lua functions as deprecated (PR #2948)

2024-03-08 Thread Panu Matilainen
Yup. The reason the warnings are not there yet is that I'm wondering how 
meaningful they are in reality, ie does it reach the right audience or will it 
be only an annoyance to end users who can't do the damnest thing about it. But 
then, nobody will notice a piece of documentation changing.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/2948#issuecomment-1985584346
You are receiving this because you are subscribed to this thread.

Message ID: ___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint


Re: [Rpm-maint] [rpm-software-management/rpm] Document fork, exec, wait and redirect2null Lua functions as deprecated (PR #2948)

2024-03-08 Thread Florian Festi
The changes look good. But we need to add the warning right away before this PR 
closes #2420

-- 
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/2948#issuecomment-1985577133
You are receiving this because you are subscribed to this thread.

Message ID: ___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint


Re: [Rpm-maint] [rpm-software-management/rpm] Document fork, exec, wait and redirect2null Lua functions as deprecated (PR #2948)

2024-03-06 Thread Panu Matilainen
We probably should also issue warnings on execution...

-- 
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/2948#issuecomment-1980752228
You are receiving this because you are subscribed to this thread.

Message ID: ___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint


[Rpm-maint] [rpm-software-management/rpm] Document fork, exec, wait and redirect2null Lua functions as deprecated (PR #2948)

2024-03-06 Thread Panu Matilainen
Rpm scriptlets should have no business dealing with this level of detail in 
process control, rpm.execut() is much saner and safer for scriptlet needs. We 
cant just remove because this is a public API with known users (eg glibc 
in Fedora), but we can at least document these as deprecated.

fork() and exec() are the main problems here, but wait() and 
redirect2null() become meaningless once you take the first two away.

Fixes: #2420
You can view, comment on, or merge this pull request online at:

  https://github.com/rpm-software-management/rpm/pull/2948

-- Commit Summary --

  * Document fork, exec, wait and redirect2null Lua functions as deprecated

-- File Changes --

M docs/manual/lua.md (16)

-- Patch Links --

https://github.com/rpm-software-management/rpm/pull/2948.patch
https://github.com/rpm-software-management/rpm/pull/2948.diff

-- 
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/2948
You are receiving this because you are subscribed to this thread.

Message ID: rpm-software-management/rpm/pull/2...@github.com
___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint