Re: [Rpm-maint] [rpm-software-management/rpm] Eliminating special conditional syntaxes from builtin macros (#1421)

2020-11-04 Thread Panu Matilainen
@pmatilai pushed 2 commits.

5cafe94457911055ca588c638473e35e1af8c0a4  Move the builtins table below the 
referenced functions to lose clutter
d279981ed40692932194a46899a5ca80bc4493c7  Support testing for builtin Lua with 
a macro conditional


-- 
You are receiving this because you are subscribed to this thread.
View it on GitHub:
https://github.com/rpm-software-management/rpm/pull/1421/files/1d487a380361963188fc4d48226442e9f0447470..d279981ed40692932194a46899a5ca80bc4493c7
___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint


Re: [Rpm-maint] [rpm-software-management/rpm] Eliminating special conditional syntaxes from builtin macros (#1421)

2020-11-04 Thread Panu Matilainen
@pmatilai pushed 1 commit.

1d487a380361963188fc4d48226442e9f0447470  Make builtin macros honor generic 
macro conditionals


-- 
You are receiving this because you are subscribed to this thread.
View it on GitHub:
https://github.com/rpm-software-management/rpm/pull/1421/files/7b309705579659f2d1b0b17c67bcb81e4a4c17c8..1d487a380361963188fc4d48226442e9f0447470
___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint


[Rpm-maint] [rpm-software-management/rpm] Eliminating special conditional syntaxes from builtin macros (#1421)

2020-11-04 Thread Panu Matilainen
Some builtin macros have their own special meaning for ! and ? which is 
inconsistent with the general meaning of those. This is confusing, bad and 
conflicts with the goal of making builtins more like normal macros.

This changes %{verbose} to return a simple boolean that can be used in an 
expression, and drops support for undocumented conditional %{?load:...} which 
can be avoided by using newly added boolean %{exists:...} instead. Also drop 
support for undocumented %{!trace} syntax to disable tracing, we can easily add 
some other syntax to support that if necessary. 

With that, builtin macros have no special syntaxes left, eliminate the internal 
arguments.
You can view, comment on, or merge this pull request online at:

  https://github.com/rpm-software-management/rpm/pull/1421

-- Commit Summary --

  * Change builtin %{verbose:...} to return a simple 0/1 boolean
  * Add %{exists:...} builtin macro for testing file existence
  * Drop undocumented special conditional syntax from %{load:...} builtin
  * Drop support for undocumented %{!trace} builtin syntax
  * Lose now unnecessary chkexist and negate arguments to builtin macros

-- File Changes --

M doc/manual/macros.md (4)
M macros.in (2)
M rpmio/macro.c (84)
M tests/rpmmacro.at (45)

-- Patch Links --

https://github.com/rpm-software-management/rpm/pull/1421.patch
https://github.com/rpm-software-management/rpm/pull/1421.diff

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/1421
___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint