Re: [Rpm-maint] [rpm-software-management/rpm] Improve build determinism (replace soft dependencies with strict ones) (Issue #2855)

2024-03-06 Thread Michal Domonkos 
Closed #2855 as completed via #2914.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/issues/2855#event-12025012740
You are receiving this because you are subscribed to this thread.

Message ID: 
___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint

Re: [Rpm-maint] [rpm-software-management/rpm] Improve build determinism (replace soft dependencies with strict ones) (Issue #2855)

2024-02-14 Thread Michal Domonkos 
Oh, sure! This looks useful. Please go ahead and submit a PR, we'll take it 
from there. Thanks!

-- 
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/issues/2855#issuecomment-1943638444
You are receiving this because you are subscribed to this thread.

Message ID: ___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint

[Rpm-maint] [rpm-software-management/rpm] Improve build determinism (replace soft dependencies with strict ones) (Issue #2855)

2024-01-18 Thread Alexander Kanavin 
This is a followup to https://github.com/rpm-software-management/rpm/pull/2852/

There is still a number of soft dependencies in 
https://github.com/rpm-software-management/rpm/blob/master/CMakeLists.txt:

```
find_package(BZip2)
find_package(Iconv)
...
pkg_check_modules(ZSTD IMPORTED_TARGET libzstd>=1.3.8)
pkg_check_modules(LIBELF IMPORTED_TARGET libelf)
pkg_check_modules(LIBDW IMPORTED_TARGET libdw)
pkg_check_modules(LIBLZMA IMPORTED_TARGET liblzma>=5.2.0)
```

Then, the respective build options get enabled depending on whether or not 
these components were found on the build system.

I believe it's better to make them strict (add REQUIRED parameter), and 
(optionally) wrap them in cmake options (like was just done for readline 
support), if there are situations where they should be disabled. I can write 
the patch, but wanted first to confirm what would be preferred.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/issues/2855
You are receiving this because you are subscribed to this thread.

Message ID: ___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint