Re: [Rpm-maint] [rpm-software-management/rpm] Only calculate buildhost and buildtime during an actual build (#935)
Merged #935 into master. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/935#event-2787886682___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Only calculate buildhost and buildtime during an actual build (#935)
Excellent, thanks. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/935#issuecomment-552439476___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Only calculate buildhost and buildtime during an actual build (#935)
bmwiedemann approved this pull request. Tested it. Looks good. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/935#pullrequestreview-314875746___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Only calculate buildhost and buildtime during an actual build (#935)
The test also fixed now, indeed showing that the functionality was broken before. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/935#issuecomment-552420744___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Only calculate buildhost and buildtime during an actual build (#935)
@pmatilai pushed 1 commit. 3d51b1114a39fc90164101e6f8dccb0e0e54ae7d Resurrect our reproducable build test -- You are receiving this because you are subscribed to this thread. View it on GitHub: https://github.com/rpm-software-management/rpm/pull/935/files/c8314f490048a1fe7ace5a797ab11ce0313e3e63..3d51b1114a39fc90164101e6f8dccb0e0e54ae7d ___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Only calculate buildhost and buildtime during an actual build (#935)
To make it clear, this is an alternative to #933 to avoid the duplication added there. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/935#issuecomment-552388302___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
[Rpm-maint] [rpm-software-management/rpm] Only calculate buildhost and buildtime during an actual build (#935)
Commit fa303d5ba6bef5b4a44b884c6dadadc27b594caa moved buildhost and buildtime calculation out of the package generation to early spec initialization, but this broke reproducable builds: if buildtime is to be set from changelog, changelog needs to be parsed first. So either we need to do it twice or we need to do it right, and besides avoiding duplication, conceptually these values are only meaningful during a build and not a parse, so this restores that part of the original code while keeping things thread-safe. Fixes: #932 You can view, comment on, or merge this pull request online at: https://github.com/rpm-software-management/rpm/pull/935 -- Commit Summary -- * Only calculate buildhost and buildtime during an actual build -- File Changes -- M build/build.c (49) M build/spec.c (50) -- Patch Links -- https://github.com/rpm-software-management/rpm/pull/935.patch https://github.com/rpm-software-management/rpm/pull/935.diff -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/935 ___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
