Re: [Rpm-maint] [rpm-software-management/rpm] Override ghost+dir filesizes (#229)
OK. Commit 2cf7096ba534b065feb038306c792784458ac9c7 should be good enough for now, though there might be some corner cases where management tools took the old value into account and now might overcommit. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/229#issuecomment-306538761___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Override ghost+dir filesizes (#229)
Closed #229. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/229#event-1112101274___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Override ghost+dir filesizes (#229)
NAK, there are people actually relying on %ghost sizes being recorded and taken into account on free disk space checking. That said, in MOST cases the %ghost size is simply fubar and we'd be better off not recording it. I could imagine something like %ghost(size=1234K) but even that is breaking backwards compatibility. For directories, simply setting size to zero in packages would probably be the least wrong value - the size of directory is an implementation detail of the installation-time target filesystem and build-time doesn't have a clue. And many of the directories that rpm deals with already exist on the fs, but again the build-time doesn't have a clue. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/229#issuecomment-306451864___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
[Rpm-maint] [rpm-software-management/rpm] Override ghost+dir filesizes (#229)
for directories and ghost files we do not want to
record their size in binary rpms
to make builds more reproducible.
See https://reproducible-builds.org/ for why this matters.
Note: I'm not sure if this is the best/correct way to do this, but at least it
made the packages build bit-identical where they did not before.
To test add to %install section:
```
cd %{buildroot}/some/packaged/dir
for i in $(seq 1 $RANDOM) ; do touch xxx$i ; done
rm xxx*
```
You can view, comment on, or merge this pull request online at:
https://github.com/rpm-software-management/rpm/pull/229
-- Commit Summary --
* Override ghost+dir filesizes
-- File Changes --
M build/files.c (3)
-- Patch Links --
https://github.com/rpm-software-management/rpm/pull/229.patch
https://github.com/rpm-software-management/rpm/pull/229.diff
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/229
___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint
