Re: [Rpm-maint] [rpm-software-management/rpm] Remove unused variable id in find-debuginfo.sh (#825)
Merged #825 into master. -- You are receiving this because you commented. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/825#event-2583287429___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Remove unused variable id in find-debuginfo.sh (#825)
Okay, thanks for the patch + review guys. -- You are receiving this because you commented. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/825#issuecomment-524813925___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Remove unused variable id in find-debuginfo.sh (#825)
Hi, On Mon, Aug 26, 2019 at 02:44:22AM -0700, Tom de Vries wrote: > There's code setting variable id in scripts/find-debuginfo.sh, but there's no > subsequent use. The only use of $id in the script is in do_file, where it is > a local variable. > > The variable setting was introduced in commit 6b3b435fa "Add dwz debuginfo > compression support" in combination with a subsequent make_id_link using the > variable, but the make_id_link was removed in commit bbfe1f86b > "Add build-id links to rpm for all ELF files". > > Remove the unused variable. Thanks for looking through the history. This makes sense, the id variable should have been removed when the only usage of it for make_id_link was removed. Now it just does extra work for nothing. Cheers, Mark ___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Remove unused variable id in find-debuginfo.sh (#825)
Earlier submitted as part of https://github.com/rpm-software-management/rpm/pull/795 -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/825#issuecomment-524796434___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
[Rpm-maint] [rpm-software-management/rpm] Remove unused variable id in find-debuginfo.sh (#825)
There's code setting variable id in scripts/find-debuginfo.sh, but there's no subsequent use. The only use of $id in the script is in do_file, where it is a local variable. The variable setting was introduced in commit 6b3b435fa "Add dwz debuginfo compression support" in combination with a subsequent make_id_link using the variable, but the make_id_link was removed in commit bbfe1f86b "Add build-id links to rpm for all ELF files". Remove the unused variable. You can view, comment on, or merge this pull request online at: https://github.com/rpm-software-management/rpm/pull/825 -- Commit Summary -- * Remove unused variable id in find-debuginfo.sh -- File Changes -- M scripts/find-debuginfo.sh (4) -- Patch Links -- https://github.com/rpm-software-management/rpm/pull/825.patch https://github.com/rpm-software-management/rpm/pull/825.diff -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/825 ___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
