Re: [Rpm-maint] [rpm-software-management/rpm] Set Build Date from changelog again (#933)
Resolved via #935, thanks for bringing this to our attention and the patch though! -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/933#issuecomment-552439767___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Set Build Date from changelog again (#933)
Closed #933. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/933#event-2787888930___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Set Build Date from changelog again (#933)
Thanks. In the meanwhile, I ended up looking at the bigger picture, commit fa303d5ba6bef5b4a44b884c6dadadc27b594caa moved buildhost and buildtime calculation to a wrong place conceptually. So when it's wrong both conceptually and functionally... can you test if #935 works for you? -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/933#issuecomment-552387890___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Set Build Date from changelog again (#933)
Added it. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/933#issuecomment-552354347___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Set Build Date from changelog again (#933)
It's not a big duplication but such things look fishy nevertheless. At the very least that explanation needs to go the the commit message. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/933#issuecomment-552351659___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Set Build Date from changelog again (#933)
> Why do we need this code in two places now? The old one is still needed in case `SOUCE_DATE_EPOCH` is set by the caller of rpmbuild. The new one is now needed for the case where we use the last changelog date via `%source_date_epoch_from_changelog Y` The duplication is rather small, though. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/933#issuecomment-552350993___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Set Build Date from changelog again (#933)
Why do we need this code in two places now? -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/933#issuecomment-552348926___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Set Build Date from changelog again (#933)
Conan-Kudo approved this pull request. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/933#pullrequestreview-314641043___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Set Build Date from changelog again (#933)
@pmatilai I think this qualifies as a regression to fix in 4.15.1. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/933#issuecomment-552233913___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
[Rpm-maint] [rpm-software-management/rpm] Set Build Date from changelog again (#933)
Set Build Date from changelog again
This is needed because fa303d5ba6 had moved the code that used
`getenv("SOURCE_DATE_EPOCH")` to run before we do `setenv` here.
See https://reproducible-builds.org/ for why this is good.
Fixes #932
You can view, comment on, or merge this pull request online at:
https://github.com/rpm-software-management/rpm/pull/933
-- Commit Summary --
* Set Build Date from changelog again
-- File Changes --
M build/build.c (2)
-- Patch Links --
https://github.com/rpm-software-management/rpm/pull/933.patch
https://github.com/rpm-software-management/rpm/pull/933.diff
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/933
___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint
