Re: [Rpm-maint] [rpm-software-management/rpm] WIP/RFE: Hint to users to use ostree/rpm-ostree if we get EROFS (#320)
Just to xref, since this one was closed the current plan is for rpm-ostree to wrap rpm, instead of having rpm wrap rpm-ostree: https://github.com/coreos/rpm-ostree/pull/1789 -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/320#issuecomment-614072259___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] WIP/RFE: Hint to users to use ostree/rpm-ostree if we get EROFS (#320)
NAK for polluting main rpm code with rpm-ostree specifics, and lockfile creation seems like the wrong place to do that anyhow. The place for this kind of material is an rpm plugin which some rpm-ostree component depends on it so its there when needed without bothering others. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/320#issuecomment-328423467___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] WIP/RFE: Hint to users to use ostree/rpm-ostree if we get EROFS (#320)
Closed #320. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/320#event-1242604735___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] WIP/RFE: Hint to users to use ostree/rpm-ostree if we get EROFS (#320)
> @cgwalters: This patch looks very specific to RPM-OSTree. Is there not a > better, more general way to do this? More general to...other image systems that happen to use rpm? Possibly. As far as I'm aware though rpm-ostree is fairly unique in the way it's a hybrid image/package system. I guess the old oVirt Node "classic" model might apply, AFAIK they shipped rpm but had no unlock functionality even. (slapping an overlayfs on /usr is really handy!). But they switched to https://github.com/fabiand/imgbased with everything writable so `yum` works. (But `yum` is totally unaware of the underlying image system) > if ostree permits live update even with -EROFS, then your patch should teach > rpm to do similar live-update, not spew nagware adverts. Well, it's not an advertisement - we don't and will never support librpm doing (persistent¹) writes. This isn't like how `dnf` (used to thankfully) print a message and continue for people who type `yum`. This case is a hard error. So...a path we could pursue instead of this would be having `/usr/bin/rpm` be a symlink → `/usr/bin/rpm-ostree`. There's a lot of advantages to that, but it'd also be obviously a large maintenance overhead of detecting operations we want to intercept (basically writes like `-i`, `-U`, but not `-q`). If consensus favors that I'd be OK with doing that instead. ¹ `rpm -Uvh` etc work fine on top of `ostree admin unlock`, which is intentional and very handy (and in fact how I tested this patch, by building a new rpm of rpm and installing it that way). But the way persistent changes work is totally different. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/320#issuecomment-328296999___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] WIP/RFE: Hint to users to use ostree/rpm-ostree if we get EROFS (#320)
@cgwalters nagware never works. if ostree permits live update even with -EROFS, then your patch should teach rpm to do similar live-update, not spew nagware adverts. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/320#issuecomment-328286650___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] WIP/RFE: Hint to users to use ostree/rpm-ostree if we get EROFS (#320)
@cgwalters: This patch looks very specific to RPM-OSTree. Is there not a better, more general way to do this? -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/320#issuecomment-328280724___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] WIP/RFE: Hint to users to use ostree/rpm-ostree if we get EROFS (#320)
BTW, down the line I'd like to extend this ostree-detection functionality a bit more so that e.g. `rpm -V` understands that timestamps are different, and that's OK. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/320#issuecomment-328109875___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] WIP/RFE: Hint to users to use ostree/rpm-ostree if we get EROFS (#320)
Hi @herrold - I read your comment a few times and I'm confused...isn't that what my patch is doing? BTW, it's easy to try an rpm-ostree based system, see https://getfedora.org/atomic/ and https://pagure.io/workstation-ostree-config for example. One thing I'd note though is that the rpm database is read-only from the point of view of everything *except* rpm-ostree - we support both [package layering](https://www.projectatomic.io/blog/2016/07/hacking-and-extending-atomic-host/) and [live package layering](http://www.projectatomic.io/blog/2017/06/rpm-ostree-v2017.6-released/). But even when doing live changes, the system still appears read-only to everything else due to some underlying ostree magic. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/320#issuecomment-327962015___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] WIP/RFE: Hint to users to use ostree/rpm-ostree if we get EROFS (#320)
As I understand the model for rpm-ostree, it assumes a Read Only, and re-located RPMDB Wouldn't a more general fix than the one seemingly already committed about inability to calculate TS disk size requirements, be a simply attempt to connect with the BDB and get a lockfile? this would indicate reliably and early, that RW transactions as called were not going to happen, and once might exit early, and with more information to a admin -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/320#issuecomment-327928478___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
[Rpm-maint] [rpm-software-management/rpm] WIP/RFE: Hint to users to use ostree/rpm-ostree if we get EROFS (#320)
Down the line, it's likely that for rpm-ostree based systems we'll install an interceptor for `/usr/bin/rpm` to redirect at least things like local package installs. There's a lot of work to do for that, so in the meantime let's help admins out by giving them a helpful error message. You can view, comment on, or merge this pull request online at: https://github.com/rpm-software-management/rpm/pull/320 -- Commit Summary -- * Hint to users to use ostree/rpm-ostree if we get EROFS * lib/transaction: Don't SEGV in sync if a txn was failed -- File Changes -- M lib/rpmlock.c (24) M lib/transaction.c (6) -- Patch Links -- https://github.com/rpm-software-management/rpm/pull/320.patch https://github.com/rpm-software-management/rpm/pull/320.diff -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/320 ___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] WIP/RFE: Hint to users to use ostree/rpm-ostree if we get EROFS (#320)
This PR rolls in https://github.com/rpm-software-management/rpm/pull/319 After: ``` # rpm -e atomic error: This system is managed by rpm-ostree error: can't create transaction lock on /var/lib/rpm/.rpm.lock (Read-only file system) ``` This is still a WIP/RFE - the code here isn't pretty obviously, happy to have feedback about a better way to do it. (Also honestly I'm struggling to convince Emacs to do this mix of tabs/spaces in the rpm codebase) -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/320#issuecomment-327870580___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
