Re: [Rpm-maint] [rpm-software-management/rpm] Zstd compression support (from jbj) (#283)
superseded by #295 -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/283#issuecomment-319600646___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Zstd compression support (from jbj) (#283)
ignatenkobrain requested changes on this pull request. and also, use --author when doing commit instead of stealing work done by others. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/283#pullrequestreview-53105075___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Zstd compression support (from jbj) (#283)
ignatenkobrain commented on this pull request. > +dnl ## NAME: +dnl ##AC_MSG_VERBOSE -- Display a message under --verbose +dnl ## +dnl ## USAGE: +dnl ##AC_MSG_VERBOSE() +dnl ## + +AC_DEFUN([AC_MSG_VERBOSE], [ +if test ".$verbose" = .yes; then +_AS_ECHO([$1]) +fi +]) + +dnl ## +dnl ## NAME: +dnl ##RPM_CHECK_LIB -- Check for third-party libraries and such things as well... personally I think we should just stick to pkgconfig and do not care about anything else. pkgconfig is standard de-facto. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/283#pullrequestreview-53105067___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Zstd compression support (from jbj) (#283)
ignatenkobrain commented on this pull request. > + +dnl ## +dnl ## NAME: +dnl ##AC_MSG_TITLE -- Display a configuration title +dnl ## +dnl ## USAGE: +dnl ##AC_MSG_TITLE(, ) +dnl ## + +AC_DEFUN([AC_MSG_TITLE],[ +_AS_ECHO([Configuring $1, Version $2]) +]) + +dnl ## +dnl ## NAME: +dnl ##AC_MSG_HEADER -- Display a configuration header such things should go to autoconf (or autoconf-archive). -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/283#pullrequestreview-53105045___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Zstd compression support (from jbj) (#283)
ignatenkobrain commented on this pull request. > @@ -0,0 +1,537 @@ +dnl ## +dnl ## acinclude.m4 -- manually provided local Autoconf macros +dnl ## + +dnl ## +dnl ## NAME: +dnl ##AC_MSG_TITLE -- Display a configuration title such things should go to autoconf (or autoconf-archive). -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/283#pullrequestreview-53105041___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Zstd compression support (from jbj) (#283)
The code in rpm_check_lib.m4 and acinclude.m4 look pretty much the same. I kinda doubt we want or even need the code twice. PLease remove the file that is not needed. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/283#issuecomment-318373435___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
[Rpm-maint] [rpm-software-management/rpm] Zstd compression support (from jbj) (#283)
Here's #256 turned into a PR, it depends on #282 You can view, comment on, or merge this pull request online at: https://github.com/rpm-software-management/rpm/pull/283 -- Commit Summary -- * add RPM_CHECK_LIB m4 macro * add zstd compression support -- File Changes -- M build/pack.c (6) M build/parsePrep.c (3) M configure.ac (15) M lib/rpmds.c (5) A m4/acinclude.m4 (537) A m4/rpm_check_lib.m4 (494) M macros.in (1) M rpmio/macro.c (3) M rpmio/rpmfileutil.c (3) M rpmio/rpmfileutil.h (3) M rpmio/rpmio.c (251) M scripts/rpm2cpio.sh (1) -- Patch Links -- https://github.com/rpm-software-management/rpm/pull/283.patch https://github.com/rpm-software-management/rpm/pull/283.diff -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/283 ___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
