Re: [Rpm-maint] [rpm-software-management/rpm] configure.ac: reference zlib when checking libmagic (#118)

[Panu Matilainen]

Like others have pointed out, this is not a feasible approach. Private 
dependencies of other projects are just that: private, and we have no business 
(or interest) guessing what they might be for any given project. As already 
pointed out, the constructive path forward is to to get libmagic to provide a 
pkg-config file which allows libmagic to control its private dependencies, then 
we can discuss changing rpm to use the .pc file when available.

NAK.



-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/118#issuecomment-271255563___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint

Re: [Rpm-maint] [rpm-software-management/rpm] configure.ac: reference zlib when checking libmagic (#118)

[Panu Matilainen]

Closed #118.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/118#event-915750694___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint

Re: [Rpm-maint] [rpm-software-management/rpm] configure.ac: reference zlib when checking libmagic (#118)

[ニール・ゴンパ]

The correct change is to get the file/libmagic project to ship a file for 
pkg-config to use and stop relying on creaky manual tests.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/118#issuecomment-271089313___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint

Re: [Rpm-maint] [rpm-software-management/rpm] configure.ac: reference zlib when checking libmagic (#118)

[Dmitry V. Levin]

Are you going to submit patches like this to every project that uses -lmagic?
Are you going to list every library libmagic might happen to be linked with?

No, -lmagic users should not care about the list of libraries libmagic is 
linked with, sorry.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/118#issuecomment-271054404___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint

[Rpm-maint] [rpm-software-management/rpm] configure.ac: reference zlib when checking libmagic (#118)

[jdknight-rockwellcollins]

When attempting to check for `magic_open` in libmagic (aka file),
linking can fail as libmagic and zlib may have been statically built:

configure:20636: .../arm-linux-gcc -std=gnu99 -o conftest ... conftest.c 
-lmagic  -lpthread  >&5
conftest.c:42:1: warning: function declaration isn't a prototype 
[-Wstrict-prototypes]
...
.../sysroot/usr/lib/libmagic.a(compress.o): In function `uncompresszlib':
compress.c:(.text+0x190): undefined reference to `inflateInit_'
compress.c:(.text+0x1a8): undefined reference to `inflateInit2_'
compress.c:(.text+0x1bc): undefined reference to `inflate'
compress.c:(.text+0x1d4): undefined reference to `inflateEnd'
compress.c:(.text+0x1fc): undefined reference to `zError'
collect2: error: ld returned 1 exit status
...
configure:20645: result: no
configure:20654: error: missing required library 'libmagic'

The following adds the rpm-dependent zlib library to ensure the check
for `magic_open` can find the dependent decompression methods.

Signed-off-by: James Knight 
You can view, comment on, or merge this pull request online at:

  https://github.com/rpm-software-management/rpm/pull/118

-- Commit Summary --

  * configure.ac: reference zlib when checking libmagic

-- File Changes --

M configure.ac (2)

-- Patch Links --

https://github.com/rpm-software-management/rpm/pull/118.patch
https://github.com/rpm-software-management/rpm/pull/118.diff

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/118
___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint