Re: [Rpm-maint] [rpm-software-management/rpm] debugedit: Do not 'edit_dwarf2' when just extracting build-id (#1435)
> You last patch looks good. As per that, merging. FWIW, this appeared to have failed CI but that was due to some unrelated daily docker quota thing, manually rerunning cleared the status. Thanks for the patch! -- You are receiving this because you commented. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/1435#issuecomment-732137347___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] debugedit: Do not 'edit_dwarf2' when just extracting build-id (#1435)
Merged #1435 into master. -- You are receiving this because you commented. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/1435#event-4027446524___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] debugedit: Do not 'edit_dwarf2' when just extracting build-id (#1435)
On Sun, 2020-11-15 at 12:18 -0800, Vitalio wrote: > > Yes, but you also have to check base_dir && dest_dir aren't set. > > I will rework. You last patch looks good. Thanks, Mark ___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] debugedit: Do not 'edit_dwarf2' when just extracting build-id (#1435)
@vt-alt pushed 1 commit. 3e2cf02947c2048df90cf9161bfa8a7df60d4061 debugedit: Do not 'edit_dwarf2' when just extracting build-id -- You are receiving this because you are subscribed to this thread. View it on GitHub: https://github.com/rpm-software-management/rpm/pull/1435/files/d47fece7584778f4f02152782d43fe0ea5da5296..3e2cf02947c2048df90cf9161bfa8a7df60d4061 ___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] debugedit: Do not 'edit_dwarf2' when just extracting build-id (#1435)
On Sun, Nov 15, 2020 at 07:11:02AM -0800, Vitalio wrote: > No need to call edit_dwarf2() if debugedit is invoked just to extract > build-id (with `-i -n). Yes, but you also have to check base_dir && dest_dir aren't set. > Otherwise, we will get `DWARF version 0 > unhandled warning for compressed .debug files: > > /usr/lib/rpm/debugedit: ./usr/lib/debug/...e.ko.debug: DWARF version 0 > unhandled > > Context: We have kernel modules elfcompressed in ALT. In general debugedit doesn't handle compressed ELF sections at the moment. You could do as Fedora does and run eu-elfcompress -t none on the file first to make sure it doesn't contain any compressed ELF sections. Cheers, Mark ___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
[Rpm-maint] [rpm-software-management/rpm] debugedit: Do not 'edit_dwarf2' when just extracting build-id (#1435)
No need to call edit_dwarf2() if debugedit is invoked just to extract build-id (with `-i -n). Otherwise, we will get `DWARF version 0 unhandled warning for compressed .debug files: /usr/lib/rpm/debugedit: ./usr/lib/debug/...e.ko.debug: DWARF version 0 unhandled Context: We have kernel modules elfcompressed in ALT. @ldv-alt You can view, comment on, or merge this pull request online at: https://github.com/rpm-software-management/rpm/pull/1435 -- Commit Summary -- * debugedit: Do not edit_dwarf2 when just extracting build-id -- File Changes -- M tools/debugedit.c (3) -- Patch Links -- https://github.com/rpm-software-management/rpm/pull/1435.patch https://github.com/rpm-software-management/rpm/pull/1435.diff -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/1435 ___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
