Re: [Rpm-maint] [rpm-software-management/rpm] lib/transaction: Don't SEGV in sync if a txn was failed (#319)
Closed #319. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/319#event-1242722957___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] lib/transaction: Don't SEGV in sync if a txn was failed (#319)
Fixed differently (cause instead of symptom) in commits 9e65d6ee9ab851db5b5d4f0b390330abb6d38029 and 7481f0ff15e4d639301fffbbe402a0d27ed02b93: number of transaction elements was the wrong condition for syncing, sync should only be done if transaction actually ran. The second commit ensures syncing doesn't depend on diskspace problem filter (but forgot to mention that particular reason in the commit message, doh) Anyway, thanks for pointing this out. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/319#issuecomment-328445845___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] lib/transaction: Don't SEGV in sync if a txn was failed (#319)
Right, it shouldn't crash. But disabled disk-space checking silently disabling sync is wrong too. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/319#issuecomment-328060578___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
[Rpm-maint] [rpm-software-management/rpm] lib/transaction: Don't SEGV in sync if a txn was failed (#319)
I was actually testing a change to better handle `rpm -e atomic` on Fedora Atomic Host, wondering why my patch was crashing, but in fact it was the recently added sync code in master. You can view, comment on, or merge this pull request online at: https://github.com/rpm-software-management/rpm/pull/319 -- Commit Summary -- * lib/transaction: Don't SEGV in sync if a txn was failed -- File Changes -- M lib/transaction.c (6) -- Patch Links -- https://github.com/rpm-software-management/rpm/pull/319.patch https://github.com/rpm-software-management/rpm/pull/319.diff -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/319 ___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
