Re: [Rpm-maint] [rpm-software-management/rpm] rpm --delsign changes the arch element of the lead (#1326)
Closed #1326 as completed via #2396. -- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/issues/1326#event-8685024394 You are receiving this because you are subscribed to this thread. Message ID: ___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] rpm --delsign changes the arch element of the lead (#1326)
I mean, rpm can consider copying lead instead of regenerating lead which seems can be worked fine. The other way, I think we can add documentation to explain it, because few people pay attention to lead and lead has no actual effect, so it is OK not to modify it. Is there any other good way？@pmatilai -- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/issues/1326#issuecomment-1333014142 You are receiving this because you are subscribed to this thread. Message ID: ___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] rpm --delsign changes the arch element of the lead (#1326)
I don't understand this. Do you want me to use something different than rpmsign? Because rpmsign used to copy the lead, but commit 3255273ae0fabd03c9738249a29c9c1e15f28f64 changed it to regenerate the lead instead of copying over. -- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/issues/1326#issuecomment-1332083324 You are receiving this because you are subscribed to this thread. Message ID: ___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] rpm --delsign changes the arch element of the lead (#1326)
> See the comment in rpmLeadFromHeader (as I wrote): > > ``` > /* FIXME: should grab these from header instead (RhBug:717898) */ > rpmGetArchInfo(NULL, ); > rpmGetOsInfo(NULL, ); > ``` > > So you'll get the arch from the host where you created or deleted a > signature, and not the arch from the host that built the package. Thanks for the reply, I know what you mean, this does seem to be a problem. But why not consider copying the lead data word for word when creating or deleting signatures? Is there any other problem? -- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/issues/1326#issuecomment-1332068202 You are receiving this because you are subscribed to this thread. Message ID: ___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] rpm --delsign changes the arch element of the lead (#1326)
> copies over the lead data verbatim when creating or deleting signatures Thanks for the reply, I know what you mean, this does seem to be a problem. But why not consider copying the lead data word for word when creating or deleting signatures? Is there any other problem? -- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/issues/1326#issuecomment-1332067706 You are receiving this because you are subscribed to this thread. Message ID: ___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] rpm --delsign changes the arch element of the lead (#1326)
See the comment in rpmLeadFromHeader (as I wrote): ``` /* FIXME: should grab these from header instead (RhBug:717898) */ rpmGetArchInfo(NULL, ); rpmGetOsInfo(NULL, ); ``` So you'll get the arch from the host where you created or deleted a signature, and not the arch from the host that built the package. -- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/issues/1326#issuecomment-1332049610 You are receiving this because you are subscribed to this thread. Message ID: ___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] rpm --delsign changes the arch element of the lead (#1326)
The arch element does not exist because the name in rpmlead_s is obtained from `headerGetAsString(h, RPMTAG_NEVR)` in rpmLeadFromHeader and arch element is not saved. In addition, 3255273ae0fabd03c9738249a29c9c1e15f28f6 seems fine, and I don't quite understand how the arch element is changed. -- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/issues/1326#issuecomment-1332040369 You are receiving this because you are subscribed to this thread. Message ID: ___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] rpm --delsign changes the arch element of the lead (#1326)
I don't care much about the lead contents as such (and neither should anybody else), but changing it does seem wrong. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/issues/1326#issuecomment-676031756___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
[Rpm-maint] [rpm-software-management/rpm] rpm --delsign changes the arch element of the lead (#1326)
Judging from commit 3255273ae0fabd03c9738249a29c9c1e15f28f64 which broke this you may not care about this. Opening this issue anyway for documentation purposes: rpm no longer copies over the lead data verbatim when creating or deleting signatures, but recreates it from the header. This does not seem to work for the arch element, which is set to the architecture of the host where rpm --delsign is called. Oh, I just saw that rpmLeadFromHeader() has a FIXME comment about that that references RhBug:717898 -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/issues/1326___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
