Re: [Rpm-maint] [rpm-software-management/rpm] Add support for sorting caret ('^') higher than base version (#597)
@ignatenkobrain pushed 2 commits. 26410a6 build: make haveRichDep aware of other fields allowed to have them 998c1b8 build: check rich dependencies for special characters -- You are receiving this because you are subscribed to this thread. View it on GitHub: https://github.com/rpm-software-management/rpm/pull/597/files/2ecd69fc4e2aea8548a7ca9fceb898c088edf4a6..998c1b8034ef20da34b0536224aeec4d89d7a4db ___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Add support for sorting caret ('^') higher than base version (#597)
Hmm, I just noticed that haveTildeDep/haveCharInDep does not work for rich dependencies... -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/597#issuecomment-440262522___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Add support for sorting caret ('^') higher than base version (#597)
@mlschroe Well, when we're referring to hg/git/svn snapshot dates, that's considered as part of upstream versioning. This is done in openSUSE and we want to move to that in Fedora to simplify automation of package (re)builds and things like that. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/597#issuecomment-439946360___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Add support for sorting caret ('^') higher than base version (#597)
@mlschroe, would you mind implementing this in libsolv? Or should I do so? -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/597#issuecomment-439944759___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Add support for sorting caret ('^') higher than base version (#597)
I don't mind having this, '^' should not break existing EVR uses. I'm a bit uncertain about the use case, wouldn't you put the '20160101' from the example in the release? 'Version' usually comes from upstream and 'Release' comes from the packager. But, as said, I'm not opposed ;-) -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/597#issuecomment-439944064___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Add support for sorting caret ('^') higher than base version (#597)
keszybz commented on this pull request. Nice! > @@ -45,6 +45,20 @@ int rpmvercmp(const char * a, const char * b) continue; } + /* +* Handle caret separator. Concept is same as tilde, except if one of +* strings ends (base version), another considered as higher version. "... Concept is the same as tilde, except that if one of the strings ends (base version), the other is considered as higher version." (just grammar) -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/597#pullrequestreview-176082463___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Add support for sorting caret ('^') higher than base version (#597)
Conan-Kudo approved this pull request. The changes look good, but here's a suggestion for the function name change. > @@ -228,12 +228,12 @@ static rpmRC processScriptFiles(rpmSpec spec, Package > pkg) return rc; } -static int haveTildeDep(Package pkg) +static int haveCharInDep(Package pkg, char c) A better name might be `haveModifierInDep`? -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/597#pullrequestreview-175803201___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Add support for sorting caret ('^') higher than base version (#597)
Conan-Kudo approved this pull request. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/597#pullrequestreview-175803053___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Add support for sorting caret ('^') higher than base version (#597)
@ffesti @ignatenkobrain Let's have a clearer name for the function, please? Char does not mean carat to me. :) EDIT: I'm dumb. This is a generalization of the tilde function. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/597#issuecomment-439395136___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Add support for sorting caret ('^') higher than base version (#597)
@ffesti @ignatenkobrain Let's have a clearer name for the function, please? `Char` does not mean `carat` to me. :) -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/597#issuecomment-439394962___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Add support for sorting caret ('^') higher than base version (#597)
Sounds good to me. ^ is a nice character for this. haveCharInDep() is not a great name for the function, but meh... -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/597#issuecomment-439352547___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Add support for sorting caret ('^') higher than base version (#597)
Like noted in #88, I'm not opposed. Symmetry usually makes sense, and if there's a way to force sorting one way then why not the other? Especially since there clearly is a technical case for it too. @mlschroe , thoughts? -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/597#issuecomment-439343438___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Add support for sorting caret ('^') higher than base version (#597)
pmatilai commented on this pull request. > (void) rpmlibNeedsFeature(pkg, "TildeInVersions", "4.10.0-1"); +/* check if the package has a dependency with a '^' */ +if (haveCharInDep(pkg, '^')) + (void) rpmlibNeedsFeature(pkg, "CaretInVersions", "4.14.0-1"); The version in rpmlib() doesn't matter (consider backports) as long as we provide the same thing, technically it could just as well be 1.2.3. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/597#discussion_r234147639___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Add support for sorting caret ('^') higher than base version (#597)
ignatenkobrain commented on this pull request. > (void) rpmlibNeedsFeature(pkg, "TildeInVersions", "4.10.0-1"); +/* check if the package has a dependency with a '^' */ +if (haveCharInDep(pkg, '^')) + (void) rpmlibNeedsFeature(pkg, "CaretInVersions", "4.14.0-1"); not sure if you would like me to change this to `4.15.0` -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/597#pullrequestreview-175708022___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Add support for sorting caret ('^') higher than base version (#597)
@pmatilai @hroncok @jasontibbitts @Conan-Kudo -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/597#issuecomment-439326683___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
