Re: [Rpm-maint] [rpm-software-management/rpm] Extend %changelog to accept filename. (#393)
Closed #393 as completed. -- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/issues/393#event-10966512266 You are receiving this because you are subscribed to this thread. Message ID: ___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Extend %changelog to accept filename. (#393)
I see %changelog -f as something that would create more issues than it solves, but like said above, we too would very much like to see better integration with external changelogs. Let's continue the external changelog discussion in a dedicated topic: https://github.com/rpm-software-management/rpm/discussions/2768 -- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/issues/393#issuecomment-1812406092 You are receiving this because you are subscribed to this thread. Message ID: ___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Extend %changelog to accept filename. (#393)
The real issue is that %changelog carried in *.rpm is mostly useless bloat these days, not how to integrate with other VCS systems, or ChangeLog files. Setup a reliable persistent display of package spec changes, and %changelog will wither away like the human appendix ;-) -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/issues/393#issuecomment-366390327___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Extend %changelog to accept filename. (#393)
The reluctancy is to add features that end up entirely unused. Oh, and features which don't really fit rpm design principles to begin with. Personally, I'd *love* to see Fedora get rid of the changelogs maintained in specs and happy to help with it from my behalf, but until somebody actually commits to driving such a project ... it's just a whole lot of talk, recurring year after year after year. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/issues/393#issuecomment-365242453___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Extend %changelog to accept filename. (#393)
Of course some distributions found their way despite RPM upstream being reluctant to support this or similar feature. The #69 just proves that. I did not mentioned Fedora anywhere and I don't think that #69 was proposed by Fedora people. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/issues/393#issuecomment-365238932___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Extend %changelog to accept filename. (#393)
https://github.com/rpm-software-management/rpm/pull/69 is related and has some relevant discussion of the caveats etc. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/issues/393#issuecomment-365225168___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Extend %changelog to accept filename. (#393)
Yeah there are any number of ways to do it. Multiple distros are doing it via other tooling sitting on top of rpm, that's an entirely valid route and already proven route. Other options include having rpm execute some hook to pull data from an outside source into the spec (and yes putting that modified version of the spec into an src.rpm because that's what really was packaged). Etc. Lets just say that my motivation for implementing something special primarily for Fedora (because everybody else is already doing it one way or the other) is not sky-high because a) others clearly manage without rpm modifications b) Fedora is pathetically bad at implementing new rpm features anyway. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/issues/393#issuecomment-365216634___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Extend %changelog to accept filename. (#393)
Well, one big advantage from the %include/%changelog way would be the possible opt-in. If you want to automate "slapping the changelog itself at the tail of the spec", then it means you have to actually change the build infrastructure to do it. TBH the biggest issue I see currently is that the SRPM changelog duplicates the .spec changelog. And these two might be possibly different. This should not happen. If I am thinking about the workflow how to obtain the log from SCM and get it into SRPM, I think that the "rpmbuild -bs" could call some macro to update the changelog. But at that moment, you probably don't want to modify the .spec file which as about to be packaged into SRPM. Modifying some changelog file would be more acceptable IMO. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/issues/393#issuecomment-365207843___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Extend %changelog to accept filename. (#393)
Splitting spec into multiple pieces (whether %include or otherwise) tends to have all sorts of downsides, especially because it breaks long-standing expectations of specs being standalone entities. I'm not actually opposed to adding %changelog -f but I'm also not convinved it's be best way to deal with pulling changelogs from scm, because then you'd still need the silly one-liners in each spec. Yes you can automate that, but then you might just as well automate slapping the changelog itself at the tail of the spec, so that the spec ending up in src.rpm's remains standalone and by looking at the srpm you don't actually know the changelog came from outside. Which is probably what you'd want if you were to rebuild a distro package locally. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/issues/393#issuecomment-365181602___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Extend %changelog to accept filename. (#393)
Actually, if ```%include``` automatically included the referenced file into SRPM, that would be helpful as well. I realize, that the path could be arbitrary, but if there was restriction, that could work ... -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/issues/393#issuecomment-364985530___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint