Re: [Rpm-maint] [rpm-software-management/rpm] Move internal OpenPGP parser into a subdirectory (PR #2704)

2023-10-12 Thread Panu Matilainen
Merged #2704 into master.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/2704#event-10628393339
You are receiving this because you are subscribed to this thread.

Message ID: 
___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint


Re: [Rpm-maint] [rpm-software-management/rpm] Move internal OpenPGP parser into a subdirectory (PR #2704)

2023-10-12 Thread Panu Matilainen
Tweaked a little bit to make the legacy status more prominent in the naming.
Just another small step towards sawing this unwanted limb off :smile: 

-- 
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/2704#issuecomment-1759145173
You are receiving this because you are subscribed to this thread.

Message ID: ___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint


Re: [Rpm-maint] [rpm-software-management/rpm] Move internal OpenPGP parser into a subdirectory (PR #2704)

2023-10-12 Thread Panu Matilainen
@pmatilai pushed 0 commits.


-- 
View it on GitHub:
https://github.com/rpm-software-management/rpm/pull/2704/files/77c71398d93ede2bb636aca9f9038f78a52a54b7..c289eba9defacf550768c3cc5e64f17d72c7e6bc
You are receiving this because you are subscribed to this thread.

Message ID: 
___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint


Re: [Rpm-maint] [rpm-software-management/rpm] Move internal OpenPGP parser into a subdirectory (PR #2704)

2023-10-12 Thread Panu Matilainen
@pmatilai pushed 3 commits.

c289eba9defacf550768c3cc5e64f17d72c7e6bc  Move internal OpenPGP parser into a 
subdirectory
9b24d952dda0d8a42a7b325937a94d4d92b56dec  Refactor internal PGP parser 
pgpValStr() uses to use the public API
77c71398d93ede2bb636aca9f9038f78a52a54b7  Bury pgpValStr() inside rpmpgp.c now 
that we can

-- 
View it on GitHub:
https://github.com/rpm-software-management/rpm/pull/2704/files/9aa8abb10ab12ccb9cf93327533a9f1cf00e97b2..77c71398d93ede2bb636aca9f9038f78a52a54b7
You are receiving this because you are subscribed to this thread.

Message ID: 
___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint


Re: [Rpm-maint] [rpm-software-management/rpm] Move internal OpenPGP parser into a subdirectory (PR #2704)

2023-10-12 Thread Panu Matilainen
@pmatilai pushed 1 commit.

9aa8abb10ab12ccb9cf93327533a9f1cf00e97b2  Move internal OpenPGP parser into a 
subdirectory

-- 
View it on GitHub:
https://github.com/rpm-software-management/rpm/pull/2704/files/43d8557c30c1cc5d4618128bee5c0079205ced31..9aa8abb10ab12ccb9cf93327533a9f1cf00e97b2
You are receiving this because you are subscribed to this thread.

Message ID: 
___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint


Re: [Rpm-maint] [rpm-software-management/rpm] Move internal OpenPGP parser into a subdirectory (PR #2704)

2023-10-06 Thread Panu Matilainen
Having more modules does indeed complicate things, but then we're already in a 
situation where we need to coordinate any API additions between rpm and 
rpm-sequoia. It just hasn't really come up yet because ATM we're just bumping 
the required rpm-sequoia version as we go, but at some point we'll probably 
need to allow for more freedom (for older versions and such).

I basically see this as another step on our way to drop support for the 
internal parser entirely, I have a hard time seeing the development on it 
"taking off" due to the split. And if I'm proven wrong on that, then I guess it 
shouldn't have trouble keeping up with the new APIs either.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/2704#issuecomment-1750249919
You are receiving this because you are subscribed to this thread.

Message ID: ___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint


Re: [Rpm-maint] [rpm-software-management/rpm] Move internal OpenPGP parser into a subdirectory (PR #2704)

2023-10-06 Thread Neal H. Walfield
If we add new functions to the API, as suggested recently [in this 
issue](https://github.com/rpm-software-management/rpm/issues/2689), then the 
internal implementation will need to be updated. This will require a versioning 
scheme for the API, I think, which would complicate maintenance. Alternatively, 
we say we don't support the internal API at all. What do you think?

-- 
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/2704#issuecomment-1750216855
You are receiving this because you are subscribed to this thread.

Message ID: ___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint


Re: [Rpm-maint] [rpm-software-management/rpm] Move internal OpenPGP parser into a subdirectory (PR #2704)

2023-10-06 Thread Panu Matilainen
To elaborate, the idea here is to split the new rpmpgp subdirectory into a 
separate repository that can be pulled into the build for the "internal pgp" 
support, but to eliminate it from the rpm repo and release tarballs. This 
resolves #2414 as far as I'm concerned.

@mlschroe , you indicated interest in maintaining the parser in #2414 - do you 
still think that way, and does this split look like you could work with? 
@nwalfield - just fyi.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/2704#issuecomment-1750204682
You are receiving this because you are subscribed to this thread.

Message ID: ___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint