Re: [Rpm-maint] [rpm-software-management/rpm] Run rpath check in parallel (#1714)
Merged #1714 into master. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/1714#event-4920601556___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Run rpath check in parallel (#1714)
Ok, there were still some issues with quoting. Should work now and produce proper messages. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/1714#issuecomment-865305016___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Run rpath check in parallel (#1714)
@ffesti pushed 1 commit. 56ed63e63f18a9af1c1a1d3340dfcccd5b855e13 check-rpaths: Look for RPATH and RUNPATH in one go -- You are receiving this because you are subscribed to this thread. View it on GitHub: https://github.com/rpm-software-management/rpm/pull/1714/files/a2bd159f17a11f92dadcde2a118cca59fbec8296..56ed63e63f18a9af1c1a1d3340dfcccd5b855e13 ___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Run rpath check in parallel (#1714)
Updated the comment. It seems the optimizations do indeed work from my local testing. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/1714#issuecomment-865035801___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Run rpath check in parallel (#1714)
kernel result on koji with the current version on rawhide: ``` real13m51.517s user8m53.216s sys 7m34.105s ``` kernel results locally with the patch: ``` real1m10.202s user8m19.161s sys 5m6.297s ``` For completion I'll also try it locally without the patch. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/1714#issuecomment-865004411___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Run rpath check in parallel (#1714)
> Yeah, I figured this would help, but it took your message for me to see how > to do that in an clean and easy way. > > Can someone test the changes, please. May be even with one of the long > running builds like kernel. I'm doing some local initial testing. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/1714#issuecomment-864995725___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Run rpath check in parallel (#1714)
@fweimer-rh commented on this pull request.
> @@ -105,6 +104,7 @@ function check_rpath() {
allow_ORIGIN=1
for j; do
+ lower=$(echo $j | grep -o "$2" | awk '{print tolower($0)}')
I think you can use the `,,` expansion operator here:
```
$ bash -c 'echo ${0,,*}' FOO
foo
```
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/1714#pullrequestreview-688327063___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Run rpath check in parallel (#1714)
Yeah, I figured this would help, but it took your message for me to see how to do that in an clean and easy way. Can someone test the changes, please. May be even with one of the long running builds like kernel. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/1714#issuecomment-864964581___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Run rpath check in parallel (#1714)
@ffesti pushed 1 commit. a2bd159f17a11f92dadcde2a118cca59fbec8296 check-rpaths: Look for RPATH and RUNPATH in one go -- You are receiving this because you are subscribed to this thread. View it on GitHub: https://github.com/rpm-software-management/rpm/pull/1714/files/98006bef1a2212095d1c69f289aeff239c08b1e3..a2bd159f17a11f92dadcde2a118cca59fbec8296 ___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Run rpath check in parallel (#1714)
Proposed also from the mailing list to speedup things: -check_rpath $i "RPATH" -check_rpath $i "RUNPATH" +check_rpath $i "RPATH|RUNPATH" -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/1714#issuecomment-864943994___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
