Re: [Rpm-maint] [rpm-software-management/rpm] Support optionally creating backup files with %autopatch or %autosetup (#110)

[Panu Matilainen]

Closed #110.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/110#event-927535419___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint

Re: [Rpm-maint] [rpm-software-management/rpm] Support optionally creating backup files with %autopatch or %autosetup (#110)

[Panu Matilainen]

Implemented as of commit 1d7b45e484883f3a340f40610b060cc100f62caa and 
34c4609df37c2462dcd884e7952259b66ebd3098 as a separate "gendiff" backend. See 
commit messages & PR#109 comments for further rationale.

Credits in the commit message already but again, thanks for input and 
inspiration on this.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/110#issuecomment-273488962___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint

Re: [Rpm-maint] [rpm-software-management/rpm] Support optionally creating backup files with %autopatch or %autosetup (#110)

[Vít Ondruch]

I am not user of %auto{patch,setup} but I hate the backup files around. I 
really don't see any reason for their existence. And I saw quite some packages 
shipping them accidentally ... 

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/110#issuecomment-271899559___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint

Re: [Rpm-maint] [rpm-software-management/rpm] Support optionally creating backup files with %autopatch or %autosetup (#110)

[Panu Matilainen]

pmatilai requested changes on this pull request.



I'm actually in favor of enabling backups by default. However this patch 
clearly hasn't been tested, nor reviewed, at all. It refers to a non-existent 
patches_num variable so any attempt to use %autosetup with this patch ends up 
in:

`error: lua script failed: [string ""]:4: attempt to index a nil value 
(global 'patches_num')`




-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/110#pullrequestreview-16144876___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint

Re: [Rpm-maint] [rpm-software-management/rpm] Support optionally creating backup files with %autopatch or %autosetup (#110)

[Panu Matilainen]

I dont see any *real* reasons against backups by default here. The default 
should be the most useful one, and the way I see it for those living with 
gendiff for one reason or another backups are a must. In my experience the only 
reason NOT to create backups is stupid (often perl) projects which don't know 
what files they own and as a consequence install those backups as well. 

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/110#issuecomment-271873980___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint

Re: [Rpm-maint] [rpm-software-management/rpm] Support optionally creating backup files with %autopatch or %autosetup (#110)

[ニール・ゴンパ]

@pmatilai I'm tempted to not modify the default backend because of reasons 
mentioned by @soig and @ignatenkobrain in #109. But let me see what I can do 
about introducing an alternative backend that creates patch backups.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/110#issuecomment-271872239___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint

Re: [Rpm-maint] [rpm-software-management/rpm] Support optionally creating backup files with %autopatch or %autosetup (#110)

[Panu Matilainen]

Yup. Or actually the other way around: have the default "patch" version create 
backups because that's more in line with the other backends, and add another 
backend like patch_nobackup (gosh I hate that name) for the no-backup case.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/110#issuecomment-271871761___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint

Re: [Rpm-maint] [rpm-software-management/rpm] Support optionally creating backup files with %autopatch or %autosetup (#110)

[ニール・ゴンパ]

@pmatilai so you'd want instead a `-S patchbackup` backend instead of using 
`-B` at `%autosetup`/`%autopatch`?

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/110#issuecomment-271871045___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint

Re: [Rpm-maint] [rpm-software-management/rpm] Support optionally creating backup files with %autopatch or %autosetup (#110)

[Panu Matilainen]

So actually I think this is best handled by having two separate backends 
(similar to git and git_am) where one creates backups and the other one 
doesn't. That way there's no need to introduce new option that is specific to 
one backend only.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/110#issuecomment-271870713___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint

Re: [Rpm-maint] [rpm-software-management/rpm] Support optionally creating backup files with %autopatch or %autosetup (#110)

[Panu Matilainen]

My issue with this is that it adds an option that is by definition only 
relevant to a single "backend" of %autosetup, and the most uninteresting one at 
that. I'm all for supporting backups for plain patch, doing them was actually 
always part of the plan only never implemented. 

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/110#issuecomment-271865352___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint

Re: [Rpm-maint] [rpm-software-management/rpm] Support optionally creating backup files with %autopatch or %autosetup (#110)

[soig]

%autosetup + SCM is quite a lot better IMHO...

Also, Mageia as the primary (only?) rpm.org  user and %apply_patch
user is switching away from %apply_patch towards %auto(setup|patch)
and all packagers are happy with no backup at all or using SCM so I
don't know why "The legacy Mandriva %apply_patches macro generated
backup files" is brough up

My 2 cents

On 18 December 2016 at 14:19, Igor Gnatenko  wrote:
>
> @ignatenkobrain approved this pull request.
>
> LGTM
>
> —
> You are receiving this because you are subscribed to this thread.
> Reply to this email directly, view it on GitHub, or mute the thread.


-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/110#issuecomment-267831649___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint

Re: [Rpm-maint] [rpm-software-management/rpm] Support optionally creating backup files with %autopatch or %autosetup (#110)

[Igor Gnatenko]

ignatenkobrain approved this pull request.

LGTM



-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/110#pullrequestreview-13464069___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint