Re: [Rpm-maint] [rpm-software-management/rpm] brp-strip fails with Guile objects on Fedora 35 (#1765)
> These changes do both to be on the save side. > > On the longer term the question is if the Guile object really should not be > stripped. `eu-strip` should be able to strip those, too. Not sure if we want > to switch over to that in general. Guile is often used as a REPL, so I am not sure if this is a good idea. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/issues/1765#issuecomment-929055972___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] brp-strip fails with Guile objects on Fedora 35 (#1765)
Closed #1765 via ee5d150aea19ebd10569cd805917acc583719e49. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/issues/1765#event-5372346762___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] brp-strip fails with Guile objects on Fedora 35 (#1765)
These changes do both to be on the save side. On the longer term the question is if the Guile object really should not be stripped. `eu-strip` should be able to strip those, too. Not sure if we want to switch over to that in general. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/issues/1765#issuecomment-925663351___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] brp-strip fails with Guile objects on Fedora 35 (#1765)
> ``` > $ file /sbin/ldconfig > /sbin/ldconfig: ELF 64-bit LSB pie executable, x86-64, version 1 (GNU/Linux), > static-pie linked, BuildID[sha1]=e524d23506ba0c75de1d253087146164328b13b8, > for GNU/Linux 3.2.0, stripped > $ file /bin/file > /bin/file: ELF 64-bit LSB pie executable, x86-64, version 1 (SYSV), > dynamically linked, interpreter /lib64/ld-linux-x86-64.so.2, > BuildID[sha1]=a32704f3e43df7519c65f06adf61d4d9bdc549bf, for GNU/Linux 3.2.0, > stripped > $ file /bin/gcc > /bin/gcc: ELF 64-bit LSB executable, x86-64, version 1 (SYSV), dynamically > linked, interpreter /lib64/ld-linux-x86-64.so.2, > BuildID[sha1]=e3a77ec7634d2b4b939b7fb62d7bcdd3860f17bf, for GNU/Linux 3.2.0, > stripped > $ file /usr/lib64/guile/2.2/ccache/ice-9/readline.go > /usr/lib64/guile/2.2/ccache/ice-9/readline.go: ELF 64-bit LSB shared object, > no machine, version 1 (embedded), dynamically linked, with debug_info, not > stripped > ``` > > Is the string `no machine` good enough for detecting Guile objects? Not sure. I would prefer just skipping `*.go` files entirely. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/issues/1765#issuecomment-922366738___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] brp-strip fails with Guile objects on Fedora 35 (#1765)
``` $ file /sbin/ldconfig /sbin/ldconfig: ELF 64-bit LSB pie executable, x86-64, version 1 (GNU/Linux), static-pie linked, BuildID[sha1]=e524d23506ba0c75de1d253087146164328b13b8, for GNU/Linux 3.2.0, stripped $ file /bin/file /bin/file: ELF 64-bit LSB pie executable, x86-64, version 1 (SYSV), dynamically linked, interpreter /lib64/ld-linux-x86-64.so.2, BuildID[sha1]=a32704f3e43df7519c65f06adf61d4d9bdc549bf, for GNU/Linux 3.2.0, stripped $ file /bin/gcc /bin/gcc: ELF 64-bit LSB executable, x86-64, version 1 (SYSV), dynamically linked, interpreter /lib64/ld-linux-x86-64.so.2, BuildID[sha1]=e3a77ec7634d2b4b939b7fb62d7bcdd3860f17bf, for GNU/Linux 3.2.0, stripped $ file /usr/lib64/guile/2.2/ccache/ice-9/readline.go /usr/lib64/guile/2.2/ccache/ice-9/readline.go: ELF 64-bit LSB shared object, no machine, version 1 (embedded), dynamically linked, with debug_info, not stripped ``` Is the string `no machine` good enough for detecting Guile objects? -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/issues/1765#issuecomment-922303860___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] brp-strip fails with Guile objects on Fedora 35 (#1765)
If there is a way to tell the guile files from normal ELF files by the `file` output that'd be even better. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/issues/1765#issuecomment-920626328___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] brp-strip fails with Guile objects on Fedora 35 (#1765)
Go files are not an issue here. Rpmbuild (`brp-strip`) classifies the files using the `file` utility and passes everything that is `ELF.*, not stripped` to the `strip` utility. One could argue this is an issue in the `strip` utility - or `file`. But as a workaround we can exclude `*.go` files from this procedure. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/issues/1765#issuecomment-920622860___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] brp-strip fails with Guile objects on Fedora 35 (#1765)
Seems like `*.go` files should never be stripped. `*.go` can also be Go source code, and that can’t be stripped either. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/issues/1765#issuecomment-907579133___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
