Re: [Rpm-maint] [rpm-software-management/rpm] elfdeps: Add full multiarch deps support (#1038)
Okay, I think this has sat here long enough. We basically already came to a decision to add multiarch support to rpm v6 format in 2019 (see #2197) but the details left open. I'm not merging it as I don't think this is exactly how it's going to be, so I'm closing this now, lets move the discussion to the ticket instead. Thanks Neal for the initiative and the patch, this probably will serve as a basis regardless (so I've grabbed a copy of this patch, but please don't delete the branch anyway). -- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/1038#issuecomment-1318241526 You are receiving this because you are subscribed to this thread. Message ID: ___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] elfdeps: Add full multiarch deps support (#1038)
Closed #1038. -- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/1038#event-7831237853 You are receiving this because you are subscribed to this thread. Message ID: ___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] elfdeps: Add full multiarch deps support (#1038)
@pmatilai Personally, I'd also like a solution to an annoying case that I have on macOS where I have binaries with multiple architectures in them. What you're saying here could probably be expanded to handle that too, I suppose, since it essentially turns architectures into qualifiers for files/dependencies, and we support having multiple qualifiers per dependency already. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/1038#issuecomment-828831503___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] elfdeps: Add full multiarch deps support (#1038)
Been thinking about this on and off. I'm totally convinced that we should record the dependency architecture, rather than the existing super dumb ()64bit() marker thing. I'm just far less convinced that the architecture should be embedded in each and every dependency string we store. If we store the extracted dependency strings as-is, and associate the arch via a separate indexed arch table there are several benefits available: - The dependency strings are identical across architectures, making data compress better and making comparisons and queries saner, dependency on zlib is always "libz.so.1" and not some associated mumble - As the extracted dependency architectures are stored as an array of their own, we gain a kind of an automatic RPMTAG_ARCH replacement that is an array consisting of all the architectures this package depends on/provides something for. A "normal" package would of course only have one arch in there, but it might open up interesting possibilities to handle this generally. - Constructing dep(marker) style strings out of these arrays is easy if needed for eg repodata (in the short term) -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/1038#issuecomment-689471380___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] elfdeps: Add full multiarch deps support (#1038)
@Conan-Kudo , I didn't say this looks bad or anything like that. It's just that we're talking about a change with massive, long-standing effects. With such a thing, we really need to know where we are going and where we want to be in 10 years rather than just "this change doesn't look half bad so why not". -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/1038#issuecomment-599419151___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] elfdeps: Add full multiarch deps support (#1038)
For the package overall, it may be best to just use the Provides/Requires mechanism with multiple things being generated, e.g. Requires: cpu(arm) Requires: cpu(neon) Requires: cpu(thumb) or Requires: cpu(x86_64) Requires: cpu(mmx) Requires: cpu(sse) Requires: cpu(sse2) where cpu(*) features would be automatically Provide:d by rpm looking at the likes of /proc/cpuinfo, and could be manually provided by stuff like qemu-binfmt* packages. Of course it gets a lot trickier when we're dealing with the per-file libc.so.6()(64bit) bits, not sure we want something huge like Provides: libc.so.6(x86_64)(mmx)(sse)(sse2)(ssse3)(sse4)(sse4_1)(sse4_2)(avx)(avx2) and obviously something requiring that wouldn't necessarily know that libc.so.6(x86_64) or libc.so.6(x86_64)(mmx) would be sufficient to fulfill the dependency. But obviously the nice thing about it would be that tools like dnf could automatically pick between libc.so.6(x86_64)(mmx)(sse)(sse2)(ssse3)(sse4)(sse4_1)(sse4_2)(avx)(avx2), libc.so.6(x86_64)(mmx)(sse)(sse2) and libc.so.6(x86_64) if multiple options are provided. Of course going down further that route, it may also be necessary to provide information about CPU timings to allow picking between e.g. an Intel optimized and an AMD optimized build even if both will work on either type (-march=generic -mtune=whatever). But something like libc.so.6(x86_64)(mmx)(sse)(sse2)(ssse3)(sse4)(sse4_1)(sse4_2)(avx)(avx2)(tune:amd) can get pretty long... -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/1038#issuecomment-597692182___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] elfdeps: Add full multiarch deps support (#1038)
I think I did okay in this PR avoiding many freak cases, though I definitely see your point about the broader architecture handling. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/1038#issuecomment-597671507___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] elfdeps: Add full multiarch deps support (#1038)
> For example, while the arch marker generation seems pretty obvious in > general, starting something new with hardcoding ARM stuff gives me the > willies. I want ARM to stop being the freak case that always being worked > around, and have the design flexible enough to cover it. I'm not looking forward to RISC-V potentially adding another set of freak cases either... :cry: Thankfully, we've so far managed to avoid it, but... -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/1038#issuecomment-597670693___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] elfdeps: Add full multiarch deps support (#1038)
This needs to be looked at together as a whole with any arch handling changes we are about to do, so we don't end up doing something now that we'll bitterly regret in six months time. So we need to build up the big picture first. For example, while the arch marker generation seems pretty obvious in general, starting something new with hardcoding ARM stuff gives me the willies. I want ARM to stop being the freak case that always being worked around, and have the design flexible enough to cover it. We cannot foresee all such cases that might come up in the future so maybe the arch marker thing should allow for "arbitrary" multiple tokens that can be reliably parsed, in addition to the main arch name. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/1038#issuecomment-597662261___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] elfdeps: Add full multiarch deps support (#1038)
Oh, another use case for some new architecture detection and handling library. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/1038#issuecomment-597633944___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] elfdeps: Add full multiarch deps support (#1038)
Meh. I am still not a big fan of this solution, but we can still change the defaults later on. It indeed seems unlikely someone won't ship the compat Provides anytime soon. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/1038#issuecomment-597632478___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] elfdeps: Add full multiarch deps support (#1038)
Incidentally, that's why I'm always populating biarch Provides. We're going to be stuck with them for a _long_ time due to RHEL and SLE and proprietary software. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/1038#issuecomment-597590860___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] elfdeps: Add full multiarch deps support (#1038)
@ffesti If someone is trying to build a cross-distro package, accounting for legacy from a newer-ish system (think Google Chrome or Bluejeans/Zoom Linux RPMs being built on a specific host and shipped for everybody), being able to flip behaviors makes sense. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/1038#issuecomment-597582303___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] elfdeps: Add full multiarch deps support (#1038)
Otherwise this looks pretty reasonable. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/1038#issuecomment-589081451___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] elfdeps: Add full multiarch deps support (#1038)
Not a fan of the %__multiarch_deps macro tbh. First it does not allow to completely switch to the new multiarch-deps whihc is something distributions probably want to do at some point. So it does not remove the need to eventually patch the .attr file. The other question is whether there should be a macro at all. This invites package(r)s to fiddle with it when they probably shouldn't. Are there any use cases other that switching the distribution policy? -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/1038#issuecomment-589079635___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] elfdeps: Add full multiarch deps support (#1038)
@Conan-Kudo pushed 1 commit. 17a2747565834832809d2ae53b739c9d94b9bca2 elfdeps: Add full multiarch deps support -- You are receiving this because you are subscribed to this thread. View it on GitHub: https://github.com/rpm-software-management/rpm/pull/1038/files/7532c16153a793d516989f7b0cec622e85c10b33..17a2747565834832809d2ae53b739c9d94b9bca2 ___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] elfdeps: Add full multiarch deps support (#1038)
@mlschroe This should be good to look at again. :) -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/1038#issuecomment-581442623___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] elfdeps: Add full multiarch deps support (#1038)
Conan-Kudo commented on this pull request. > + break; +case EM_MIPS: + elf_machine = "mips"; + break; +case EM_PPC: +case EM_PPC64: + elf_machine = "ppc"; + break; +case EM_S390: + elf_machine = "s390"; + break; +case EM_ARM: + if ((ehdr->e_flags | EF_ARM_ABI_FLOAT_HARD) == EF_ARM_ABI_FLOAT_HARD) + elf_machine = "armhfp"; + if ((ehdr->e_flags | EF_ARM_ABI_FLOAT_SOFT) == EF_ARM_ABI_FLOAT_SOFT) + elf_machine = "armsfp"; Fixed. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/1038#discussion_r374112255___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] elfdeps: Add full multiarch deps support (#1038)
@Conan-Kudo pushed 1 commit. 7532c16153a793d516989f7b0cec622e85c10b33 elfdeps: Add full multiarch deps support -- You are receiving this because you are subscribed to this thread. View it on GitHub: https://github.com/rpm-software-management/rpm/pull/1038/files/f7ce837d5b6ed7663ce5774c6507fde6731436fe..7532c16153a793d516989f7b0cec622e85c10b33 ___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] elfdeps: Add full multiarch deps support (#1038)
Conan-Kudo commented on this pull request. > + break; +case EM_MIPS: + elf_machine = "mips"; + break; +case EM_PPC: +case EM_PPC64: + elf_machine = "ppc"; + break; +case EM_S390: + elf_machine = "s390"; + break; +case EM_ARM: + if ((ehdr->e_flags | EF_ARM_ABI_FLOAT_HARD) == EF_ARM_ABI_FLOAT_HARD) + elf_machine = "armhfp"; + if ((ehdr->e_flags | EF_ARM_ABI_FLOAT_SOFT) == EF_ARM_ABI_FLOAT_SOFT) + elf_machine = "armsfp"; Erk, nope, that's no bueno: ``` tools/elfdeps.c:130:47: error: bitwise comparison always evaluates to false [-Werror=tautological-compare] 130 | if ((ehdr->e_flags & ~EF_ARM_ABI_FLOAT_HARD) == EF_ARM_ABI_FLOAT_HARD) | ^~ tools/elfdeps.c:132:47: error: bitwise comparison always evaluates to false [-Werror=tautological-compare] 132 | if ((ehdr->e_flags & ~EF_ARM_ABI_FLOAT_SOFT) == EF_ARM_ABI_FLOAT_SOFT) | ^~ ``` -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/1038#discussion_r374110704___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] elfdeps: Add full multiarch deps support (#1038)
mlschroe commented on this pull request. > + break; +case EM_MIPS: + elf_machine = "mips"; + break; +case EM_PPC: +case EM_PPC64: + elf_machine = "ppc"; + break; +case EM_S390: + elf_machine = "s390"; + break; +case EM_ARM: + if ((ehdr->e_flags | EF_ARM_ABI_FLOAT_HARD) == EF_ARM_ABI_FLOAT_HARD) + elf_machine = "armhfp"; + if ((ehdr->e_flags | EF_ARM_ABI_FLOAT_SOFT) == EF_ARM_ABI_FLOAT_SOFT) + elf_machine = "armsfp"; Oops, did I write `& ~EF_ARM_ABI_FLOAT_HARD`? I meant `& EF_ARM_ABI_FLOAT_HARD`, of course. Sorry. Good thing that this triggers a gcc warning... -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/1038#discussion_r37405___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] elfdeps: Add full multiarch deps support (#1038)
@mlschroe I've added a default to enable biarch when neither option is set. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/1038#issuecomment-581414160___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] elfdeps: Add full multiarch deps support (#1038)
Conan-Kudo commented on this pull request. > + break; +case EM_MIPS: + elf_machine = "mips"; + break; +case EM_PPC: +case EM_PPC64: + elf_machine = "ppc"; + break; +case EM_S390: + elf_machine = "s390"; + break; +case EM_ARM: + if ((ehdr->e_flags | EF_ARM_ABI_FLOAT_HARD) == EF_ARM_ABI_FLOAT_HARD) + elf_machine = "armhfp"; + if ((ehdr->e_flags | EF_ARM_ABI_FLOAT_SOFT) == EF_ARM_ABI_FLOAT_SOFT) + elf_machine = "armsfp"; Oops, fixed! -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/1038#discussion_r374101218___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] elfdeps: Add full multiarch deps support (#1038)
@Conan-Kudo pushed 1 commit. f7ce837d5b6ed7663ce5774c6507fde6731436fe elfdeps: Add full multiarch deps support -- You are receiving this because you are subscribed to this thread. View it on GitHub: https://github.com/rpm-software-management/rpm/pull/1038/files/b79056006456be9a923b2dc17c789f35fce2b3a8..f7ce837d5b6ed7663ce5774c6507fde6731436fe ___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] elfdeps: Add full multiarch deps support (#1038)
@Conan-Kudo pushed 1 commit. b79056006456be9a923b2dc17c789f35fce2b3a8 elfdeps: Add full multiarch deps support -- You are receiving this because you are subscribed to this thread. View it on GitHub: https://github.com/rpm-software-management/rpm/pull/1038/files/5af676e833c61b294e3595bd50286aac07c3cb57..b79056006456be9a923b2dc17c789f35fce2b3a8 ___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] elfdeps: Add full multiarch deps support (#1038)
I don't like that it doesn't output anything if neither `--biarch-deps` not `--multiarch-deps` is provided. I think it would be better to either change the option to `--no-biarch-deps` or at least default to biarch if neither option is given. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/1038#issuecomment-581331102___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] elfdeps: Add full multiarch deps support (#1038)
@mikhailnov what is e2k? -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/1038#issuecomment-581179157___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] elfdeps: Add full multiarch deps support (#1038)
It would be nice to add e2k here -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/1038#issuecomment-581179105___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] elfdeps: Add full multiarch deps support (#1038)
@Conan-Kudo pushed 1 commit. 5af676e833c61b294e3595bd50286aac07c3cb57 elfdeps: Add full multiarch deps support -- You are receiving this because you are subscribed to this thread. View it on GitHub: https://github.com/rpm-software-management/rpm/pull/1038/files/7ac477c99bbfc2c1a3f26b483b474e33f5297852..5af676e833c61b294e3595bd50286aac07c3cb57 ___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] elfdeps: Add full multiarch deps support (#1038)
@Conan-Kudo pushed 1 commit. 7ac477c99bbfc2c1a3f26b483b474e33f5297852 elfdeps: Add full multiarch deps support -- You are receiving this because you are subscribed to this thread. View it on GitHub: https://github.com/rpm-software-management/rpm/pull/1038/files/566a8d2717495125f422496be1e10adfc5cca76d..7ac477c99bbfc2c1a3f26b483b474e33f5297852 ___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] elfdeps: Add full multiarch deps support (#1038)
@Conan-Kudo pushed 1 commit. fb305121ad7228b56f7b86ede47b021b99a573c9 elfdeps: Add full multiarch deps support -- You are receiving this because you are subscribed to this thread. View it on GitHub: https://github.com/rpm-software-management/rpm/pull/1038/files/c78b58bd252ba07f1ea3f941e09a750d95103e7d..fb305121ad7228b56f7b86ede47b021b99a573c9 ___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] elfdeps: Add full multiarch deps support (#1038)
@Conan-Kudo pushed 1 commit. df1293617f4b70f371aae69aaa058de0ab2bae16 elfdeps: Add full multiarch deps support -- You are receiving this because you are subscribed to this thread. View it on GitHub: https://github.com/rpm-software-management/rpm/pull/1038/files/76b977034ee578a9f223f322335ebd1e9fefb067..df1293617f4b70f371aae69aaa058de0ab2bae16 ___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] elfdeps: Add full multiarch deps support (#1038)
@pmatilai @ffesti I *finally* revised #360. Phew! -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/1038#issuecomment-581094273___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
