[Bug 4041] Review request: mendeleydesktop - rpm of Mendeley

[RPM Fusion Bugzilla]

https://bugzilla.rpmfusion.org/show_bug.cgi?id=4041

--- Comment #3 from Mark Harfouche  2016-04-26 
01:36:14 CEST ---
1. Wow, OK I understand what you did. You basically went through every binary
that was inside mendeleydesktop and tried to find where it was from. You then
went on and tried to find the license yourself.

2. Same as above.

3. I would think about it, but I would rather just help you maintain your spec
file.

I think I would suggest that you add
rm  -rf share/icons/hicolor/48x48
rm  -rf share/icons/hicolor/64x64

in your spec file somewhere.
Their icons are lower resoluation have white instead of alpha, making them look
rather bad. I just let gnome scale down the icons until they fix it, which they
probably never will.

-- 
Configure bugmail: https://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
You are the assignee for the bug.

[Bug 4041] Review request: mendeleydesktop - rpm of Mendeley

[RPM Fusion Bugzilla]

https://bugzilla.rpmfusion.org/show_bug.cgi?id=4041

--- Comment #2 from Mark Harfouche  2016-04-26 
01:18:39 CEST ---
I removed my package from COPR.

Thank you for your notes.

I did get permission to redistribute, at least through their forum. Do we need
a more official email? 
I included pdf printouts here:
https://github.com/hmaarrfk/mendeley-rpm/blob/master/Mendeley%20Permission%20To%20Redistribute%20-%20generic.pdf
https://github.com/hmaarrfk/mendeley-rpm/blob/master/Mendeley%20Permission%20To%20Redistribute.pdf

I think you meant sections 2.x.x and not 4.x.x
Section 2.3.2 does mention copy/vary/modify, but I feel like 2.1.2 allows us to
do so.

1. Do you mean in a separate "Provides" section? It seems the RPM tools do that
automatically. Am I missing something?
2. Where did you get "LGPLv2+ and Mendeley and MIT and CC-BY-SA and (CPAL or
AGPLv3) and BSD"
3. Honestly, I never used LibreOffice. I guess you've done an awesome job at
that.

-- 
Configure bugmail: https://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
You are the assignee for the bug.

[Bug 4041] Review request: mendeleydesktop - rpm of Mendeley

[RPM Fusion Bugzilla]

https://bugzilla.rpmfusion.org/show_bug.cgi?id=4041

Dominik 'Rathann' Mierzejewski  changed:

   What|Removed |Added

 CC||domi...@greysector.net

--- Comment #1 from Dominik 'Rathann' Mierzejewski  
2016-04-26 00:53:20 CEST ---
Nice to see your attempt here, Mark. However, I think that the ToS
(https://www.mendeley.com/terms/) prevent us from distributing modified
versions (sections 4.1.2 and 4.3.* are relevant here). Do you have written
permission from the authors? Coincidentally, I noticed you're using Fedora's
copr service to distribute your RPMs. Please stop doing so immediately. You
cannot use copr to distribute software not permissible in Fedora.

Having said that, I think your package could use some improvements. Please
compare mine:
https://rathann.fedorapeople.org/review/mendeleydesktop/

A couple of highlights:
1. please enumerate the bundled code
2. include all the licenses (of the bundled code, as well) in the License:
field
3. package the Libre/OpenOffice extension

-- 
Configure bugmail: https://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
You are the assignee for the bug.

[Bug 4041] Review request: mendeleydesktop - rpm of Mendeley

[RPM Fusion Bugzilla]

https://bugzilla.rpmfusion.org/show_bug.cgi?id=4041

Mark Harfouche  changed:

   What|Removed |Added

 Blocks||30

-- 
Configure bugmail: https://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
You are the assignee for the bug.

[Bug 30] Tracker : Sponsorship Request

[RPM Fusion Bugzilla]

https://bugzilla.rpmfusion.org/show_bug.cgi?id=30

Mark Harfouche  changed:

   What|Removed |Added

 Depends on||4041

-- 
Configure bugmail: https://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.

[Bug 4041] Review request: mendeleydesktop - rpm of Mendeley

[RPM Fusion Bugzilla]

https://bugzilla.rpmfusion.org/show_bug.cgi?id=4041

Mark Harfouche  changed:

   What|Removed |Added

URL||https://github.com/hmaarrfk
   ||/mendeley-rpm
 Blocks||2

-- 
Configure bugmail: https://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
You are the assignee for the bug.

[Bug 4041] New: Review request: mendeleydesktop - rpm of Mendeley

[RPM Fusion Bugzilla]

https://bugzilla.rpmfusion.org/show_bug.cgi?id=4041

 Bug #: 4041
   Summary: Review request: mendeleydesktop - rpm of Mendeley
Classification: Unclassified
   Product: Package Reviews
   Version: Current
  Platform: All
OS/Version: GNU/Linux
Status: NEW
  Severity: normal
  Priority: P5
 Component: Review Request
AssignedTo: rpmfusion-package-rev...@rpmfusion.org
ReportedBy: mark.harfou...@gmail.com
CC: rpmfusion-package-rev...@rpmfusion.org


This is a repackaged version of what is available
on the Mendeley website and attempts to make use
of system libraries instead of the ones packaged
with Mendeley.



srpm:
http://markharfouche.com/~makerpm/mendeleydesktop-1.16.1-2.fc23.src.rpm


Source rpmlint:
$ rpmlint /home/makerpm/rpmbuild/SRPMS/mendeleydesktop-1.16.1-2.fc23.src.rpm
mendeleydesktop.src: W: invalid-license Proprietary
1 packages and 0 specfiles checked; 0 errors, 1 warnings.


Binary rpmlint:


$ rpmlint
/var/lib/mock/fedora-23-x86_64/result/mendeleydesktop-1.16.1-2.fc23.x86_64.rpm 
mendeleydesktop.x86_64: W: invalid-license Proprietary
mendeleydesktop.x86_64: E: invalid-soname /usr/lib64/libPDFNetC.so
libPDFNetC.so
mendeleydesktop.x86_64: W: shared-lib-calls-exit /usr/lib64/libPDFNetC.so
exit@GLIBC_2.2.5
mendeleydesktop.x86_64: W: shared-lib-calls-exit
/usr/lib64/libMendeley.so.1.16.1 exit@GLIBC_2.2.5
mendeleydesktop.x86_64: W: no-manual-page-for-binary mendeleydesktop
1 packages and 0 specfiles checked; 1 errors, 4 warnings.

Justification for errors:
W: invalid-license: Proprietary license is why I need RPMFusion
E: invalid-soname can't change that. The source is a binary.
W: shared-lib-calls-exit: I don't know what this means. I don't think I can
change it
W: no-manual-page-for-binary: I don't think this is necessary. Also, this was a
binary software.

$ rpmlint
/var/lib/mock/fedora-23-x86_64/result/mendeleydesktop-devel-1.16.1-2.fc23.x86_64.rpm
 
mendeleydesktop-devel.x86_64: W: invalid-license Proprietary
mendeleydesktop-devel.x86_64: W: only-non-binary-in-usr-lib
mendeleydesktop-devel.x86_64: W: no-documentation
1 packages and 0 specfiles checked; 0 errors, 3 warnings.

W: only-non-binary-in-usr-lib <- I don't know what this means
W: no-documentation <- this is a devel package


My first RPMFusion package. I am seeking a sponsor.

-- 
Configure bugmail: https://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
You are the assignee for the bug.

[Bug 3576] Review request: obs-studio - Open Broadcaster Software Studio

[RPM Fusion Bugzilla]

https://bugzilla.rpmfusion.org/show_bug.cgi?id=3576

--- Comment #24 from Momcilo Medic  2016-04-25 
20:21:38 CEST ---
Upstream released OBS-studio 0.14.1

Installation RPM:
https://fedorauser.fedorapeople.org/0.14.1-0.1/obs-studio-0.14.1-0.1.fc23.x86_64.rpm

Updated .src.rpm and .spec files:
https://fedorauser.fedorapeople.org/0.14.1-0.1/obs-studio-0.14.1-0.1.fc23.src.rpm
https://fedorauser.fedorapeople.org/0.14.1-0.1/obs-studio.spec


rpmlint outputs:

$ rpmlint SRPMS/obs-studio-0.14.1-0.1.fc23.src.rpm 
1 packages and 0 specfiles checked; 0 errors, 0 warnings.

$ rpmlint RPMS/x86_64/obs-studio-0.14.1-0.1.fc23.x86_64.rpm 
obs-studio.x86_64: E: arch-dependent-file-in-usr-share
/usr/share/obs/obs-plugins/obs-ffmpeg/ffmpeg-mux
obs-studio.x86_64: W: shared-lib-calls-exit /usr/lib64/libobs.so.0
exit@GLIBC_2.2.5
obs-studio.x86_64: W: no-manual-page-for-binary obs
1 packages and 0 specfiles checked; 1 errors, 2 warnings.

$ rpmlint RPMS/x86_64/obs-studio-devel-0.14.1-0.1.fc23.x86_64.rpm 
obs-studio-devel.x86_64: W: only-non-binary-in-usr-lib
obs-studio-devel.x86_64: W: no-documentation
1 packages and 0 specfiles checked; 0 errors, 2 warnings.

$ rpmlint RPMS/x86_64/obs-studio-debuginfo-0.14.1-0.1.fc23.x86_64.rpm 
1 packages and 0 specfiles checked; 0 errors, 0 warnings.

-- 
Configure bugmail: https://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
You are the assignee for the bug.

[Bug 3774] Review request: freshplayerplugin - PPAPI-host NPAPI-plugin adapter

[RPM Fusion Bugzilla]

https://bugzilla.rpmfusion.org/show_bug.cgi?id=3774

--- Comment #33 from Mauricio Teixeira  2016-04-25 
19:32:07 CEST ---
I've been waiting for someone to approve my CVS access, so I can move forward
with publishing.

-- 
Configure bugmail: https://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
You are the assignee for the bug.

[Bug 4013] Review request: devedeng - A program to create video DVDs and CDs (VCD, sVCD or CVD)

[RPM Fusion Bugzilla]

https://bugzilla.rpmfusion.org/show_bug.cgi?id=4013

--- Comment #1 from Andrea Musuruane  2016-04-25 11:05:42 
CEST ---
Spec file:
https://dl.dropboxusercontent.com/u/12575912/reviews/devedeng.spec

Source RPM:
https://dl.dropboxusercontent.com/u/12575912/reviews/devedeng-4.7.0-1.fc23.src.rpm

Changelog:
- Updated to new upstream release

-- 
Configure bugmail: https://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
You are the assignee for the bug.