[Bug 3090] Review request: cmplayer - a Qt-based multimedia player utilizing the MPV video back-end.

[RPM Fusion Bugzilla]

http://bugzilla.rpmfusion.org/show_bug.cgi?id=3090

--- Comment #16 from Ben Reedy  ---
The libchardet package is now in the official Fedora repositories, so that's
one blocker gone.

However, I'll hold off submitting a request for Bomi for now, as upstream has
been silent since October 2015 with only a few small commits in the past month.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.

[Bug 4224] Review Request: siril - Astronomical image (pre-)processing program

[RPM Fusion Bugzilla]

http://bugzilla.rpmfusion.org/show_bug.cgi?id=4224

--- Comment #12 from Cyril Richard  ---
@Nicolas: 
> @Cyril, please create an account in fas.rpmfusion.org

Done. My login is lock.

Can we easily removed Siril 0.8 from official repository to go further ?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.

[Bug 3887] Review request: display-dhammapada - Displays a verse from the Dhammapada

[RPM Fusion Bugzilla]

http://bugzilla.rpmfusion.org/show_bug.cgi?id=3887

Nicolas Chauvet  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 Blocks|2   |3
   Assignee|rpmfusion-package-review@rp |kwiz...@gmail.com
   |mfusion.org |

--- Comment #1 from Nicolas Chauvet  ---
While public domain is probably correct for the original content, your software
to display it is licensed as GPLv3(+ ?), this should appear in the license
field of the RPM with (idealy) a correct license file added to the upstream
project.

* Please fix the indent of the description (avoid space in the beginning of new
lines and at the top. And use the full allowed 80 characters.

* Drop unneeded %define _hardened_build 1 (this is the default nowadays)

* Use %make_build and %make_install macros

* Drop uneeded defattr

* Verify that all your directories are owned by the package.

* Use wildcard for manpages compression extension.

* There are spurious spaces in the beginning of some sections, please remove
and keep 2 spaces at the end of earch section.

So to me this should be provided in the free section, do you agree ?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.

[Bug 2750] Review request: cdemu suite - virtual CD drive for linux

[RPM Fusion Bugzilla]

http://bugzilla.rpmfusion.org/show_bug.cgi?id=2750
Bug 2750 depends on bug 2756, which changed state.

Bug 2756 Summary: Review request: cdemu-client - Simple command-line client for 
controlling CDEmu daemon
http://bugzilla.rpmfusion.org/show_bug.cgi?id=2756

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |EXPIRED

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.

[Bug 30] Tracker : Sponsorship Request

[RPM Fusion Bugzilla]

http://bugzilla.rpmfusion.org/show_bug.cgi?id=30

Nicolas Chauvet  changed:

   What|Removed |Added

 Depends on|2756|

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 2755] Review request: cdemu-common - A set of common files shared between CDEmu clients

[RPM Fusion Bugzilla]

http://bugzilla.rpmfusion.org/show_bug.cgi?id=2755

Nicolas Chauvet  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Blocks|2, 30   |
 Resolution|--- |EXPIRED

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.

[Bug 2750] Review request: cdemu suite - virtual CD drive for linux

[RPM Fusion Bugzilla]

http://bugzilla.rpmfusion.org/show_bug.cgi?id=2750

Nicolas Chauvet  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |EXPIRED

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.

[Bug 2756] Review request: cdemu-client - Simple command-line client for controlling CDEmu daemon

[RPM Fusion Bugzilla]

http://bugzilla.rpmfusion.org/show_bug.cgi?id=2756

Nicolas Chauvet  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Blocks|2, 30   |
 Resolution|--- |EXPIRED

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.

[Bug 2750] Review request: cdemu suite - virtual CD drive for linux

[RPM Fusion Bugzilla]

http://bugzilla.rpmfusion.org/show_bug.cgi?id=2750
Bug 2750 depends on bug 2755, which changed state.

Bug 2755 Summary: Review request: cdemu-common - A set of common files shared 
between CDEmu clients
http://bugzilla.rpmfusion.org/show_bug.cgi?id=2755

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |EXPIRED

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.

[Bug 2756] Review request: cdemu-client - Simple command-line client for controlling CDEmu daemon

[RPM Fusion Bugzilla]

http://bugzilla.rpmfusion.org/show_bug.cgi?id=2756
Bug 2756 depends on bug 2755, which changed state.

Bug 2755 Summary: Review request: cdemu-common - A set of common files shared 
between CDEmu clients
http://bugzilla.rpmfusion.org/show_bug.cgi?id=2755

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |EXPIRED

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.

[Bug 30] Tracker : Sponsorship Request

[RPM Fusion Bugzilla]

http://bugzilla.rpmfusion.org/show_bug.cgi?id=30

Nicolas Chauvet  changed:

   What|Removed |Added

 Depends on|2755|

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 3007] Review request: gtkradiant-data - Data files for the video games level editor

[RPM Fusion Bugzilla]

http://bugzilla.rpmfusion.org/show_bug.cgi?id=3007

--- Comment #4 from Nicolas Chauvet  ---
Are you sure gtkradiant will crash this package isn't here or is it just easier
?
Because that gtkradiant alone seems to be good for fedora.

Also I wonder if you can use game-data-packager for this content instead ?
(I have no idea of how it work).

If needed I can sponsor you in rpmfusion.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.

[Bug 1319] Review request:BLCR - Berkeley Lab Checkpoint/Restart for Linux

[RPM Fusion Bugzilla]

http://bugzilla.rpmfusion.org/show_bug.cgi?id=1319

Nicolas Chauvet  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |EXPIRED

--- Comment #11 from Nicolas Chauvet  ---
Not sure if that's the same implementation but criu is enabled in fedora.
There is also dmtcp... Anyway feel free to re-open if needed.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.

[Bug 30] Tracker : Sponsorship Request

[RPM Fusion Bugzilla]

http://bugzilla.rpmfusion.org/show_bug.cgi?id=30
Bug 30 depends on bug 3090, which changed state.

Bug 3090 Summary: Review request: cmplayer - a Qt-based multimedia player 
utilizing the MPV video back-end.
http://bugzilla.rpmfusion.org/show_bug.cgi?id=3090

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |EXPIRED

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 3090] Review request: cmplayer - a Qt-based multimedia player utilizing the MPV video back-end.

[RPM Fusion Bugzilla]

http://bugzilla.rpmfusion.org/show_bug.cgi?id=3090

Nicolas Chauvet  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |EXPIRED

--- Comment #15 from Nicolas Chauvet  ---
seems like upstream has changed to bomi.
Please resubmit if needed (if needed we'll grant a bundling exception, it
shoudn't hold a review that much).

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.

[Bug 30] Tracker : Sponsorship Request

[RPM Fusion Bugzilla]

http://bugzilla.rpmfusion.org/show_bug.cgi?id=30
Bug 30 depends on bug 3083, which changed state.

Bug 3083 Summary: Review Request: MiroVideoConverter3 - Simple multimedia 
converter
http://bugzilla.rpmfusion.org/show_bug.cgi?id=3083

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |EXPIRED

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 3083] Review Request: MiroVideoConverter3 - Simple multimedia converter

[RPM Fusion Bugzilla]

http://bugzilla.rpmfusion.org/show_bug.cgi?id=3083

Nicolas Chauvet  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |EXPIRED

--- Comment #1 from Nicolas Chauvet  ---
Is it review still current ? Spec file url gives 404.
Please re-open once a new spec file is uploaded.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.

[Bug 2960] Review Request: Curlew - multimedia converter

[RPM Fusion Bugzilla]

http://bugzilla.rpmfusion.org/show_bug.cgi?id=2960

Nicolas Chauvet  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |EXPIRED

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.

[Bug 30] Tracker : Sponsorship Request

[RPM Fusion Bugzilla]

http://bugzilla.rpmfusion.org/show_bug.cgi?id=30
Bug 30 depends on bug 2960, which changed state.

Bug 2960 Summary: Review Request: Curlew - multimedia converter
http://bugzilla.rpmfusion.org/show_bug.cgi?id=2960

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |EXPIRED

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 2754] Review request: cdemu-daemon - Device daemon for CDEmu, a virtual CD-ROM device emulator

[RPM Fusion Bugzilla]

http://bugzilla.rpmfusion.org/show_bug.cgi?id=2754

Nicolas Chauvet  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |EXPIRED

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.

[Bug 30] Tracker : Sponsorship Request

[RPM Fusion Bugzilla]

http://bugzilla.rpmfusion.org/show_bug.cgi?id=30
Bug 30 depends on bug 2754, which changed state.

Bug 2754 Summary: Review request: cdemu-daemon - Device daemon for CDEmu, a 
virtual CD-ROM device emulator
http://bugzilla.rpmfusion.org/show_bug.cgi?id=2754

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |EXPIRED

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 2750] Review request: cdemu suite - virtual CD drive for linux

[RPM Fusion Bugzilla]

http://bugzilla.rpmfusion.org/show_bug.cgi?id=2750
Bug 2750 depends on bug 2754, which changed state.

Bug 2754 Summary: Review request: cdemu-daemon - Device daemon for CDEmu, a 
virtual CD-ROM device emulator
http://bugzilla.rpmfusion.org/show_bug.cgi?id=2754

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |EXPIRED

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.

[Bug 2756] Review request: cdemu-client - Simple command-line client for controlling CDEmu daemon

[RPM Fusion Bugzilla]

http://bugzilla.rpmfusion.org/show_bug.cgi?id=2756
Bug 2756 depends on bug 2754, which changed state.

Bug 2754 Summary: Review request: cdemu-daemon - Device daemon for CDEmu, a 
virtual CD-ROM device emulator
http://bugzilla.rpmfusion.org/show_bug.cgi?id=2754

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |EXPIRED

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.

[Bug 30] Tracker : Sponsorship Request

[RPM Fusion Bugzilla]

http://bugzilla.rpmfusion.org/show_bug.cgi?id=30
Bug 30 depends on bug 2237, which changed state.

Bug 2237 Summary: Review request: Homer - live conferencing and more
http://bugzilla.rpmfusion.org/show_bug.cgi?id=2237

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |EXPIRED

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 2237] Review request: Homer - live conferencing and more

[RPM Fusion Bugzilla]

http://bugzilla.rpmfusion.org/show_bug.cgi?id=2237

Nicolas Chauvet  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |EXPIRED

--- Comment #31 from Nicolas Chauvet  ---
Please re-open if the submitter is still here.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.

[Bug 3601] Review request: spread - High performance messaging service

[RPM Fusion Bugzilla]

http://bugzilla.rpmfusion.org/show_bug.cgi?id=3601

--- Comment #10 from Nicolas Chauvet  ---
Package CVS request
==
Package Name: spread
Short Description: High performance messaging service
Owners: holcapek
Branches: el6 el7 f23 f24 f25 devel
InitialCC: 
--
License tag: nonfree

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug 3601] Review request: spread - High performance messaging service

[RPM Fusion Bugzilla]

http://bugzilla.rpmfusion.org/show_bug.cgi?id=3601

Nicolas Chauvet  changed:

   What|Removed |Added

 Blocks||33

--- Comment #9 from Nicolas Chauvet  ---
Please block #33 so I get a chance to proceed cvsrequest:
http://rpmfusion.org/Contributors#Your_package_gets_approved

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug 3208] (zfs-kmod) Review request: zfs-kmod - Kernel modules for ZFS File System Support for Linux

[RPM Fusion Bugzilla]

http://bugzilla.rpmfusion.org/show_bug.cgi?id=3208
Bug 3208 depends on bug 1991, which changed state.

Bug 1991 Summary: Review request: zfs - ZFS File System Support for Linux
http://bugzilla.rpmfusion.org/show_bug.cgi?id=1991

   What|Removed |Added

 Status|ASSIGNED|RESOLVED
 Resolution|--- |EXPIRED

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.

[Bug 1991] Review request: zfs - ZFS File System Support for Linux

[RPM Fusion Bugzilla]

http://bugzilla.rpmfusion.org/show_bug.cgi?id=1991

Nicolas Chauvet  changed:

   What|Removed |Added

 Status|ASSIGNED|RESOLVED
 Blocks|3   |
 Resolution|--- |EXPIRED

--- Comment #22 from Nicolas Chauvet  ---
404 on last review URL, please re-open if needed.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug 2809] Review request: copy-agent - Copy.com sync agent

[RPM Fusion Bugzilla]

http://bugzilla.rpmfusion.org/show_bug.cgi?id=2809

Nicolas Chauvet  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |EXPIRED

--- Comment #6 from Nicolas Chauvet  ---
No news, please re-open if needed.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.

[Bug 30] Tracker : Sponsorship Request

[RPM Fusion Bugzilla]

http://bugzilla.rpmfusion.org/show_bug.cgi?id=30

Nicolas Chauvet  changed:

   What|Removed |Added

 Depends on|2819|

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 2819] Review Request: OpenCaster - Free digital TV software

[RPM Fusion Bugzilla]

http://bugzilla.rpmfusion.org/show_bug.cgi?id=2819

Nicolas Chauvet  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Blocks|2, 30   |
 Resolution|--- |EXPIRED

--- Comment #13 from Nicolas Chauvet  ---
If this review still current ? spec file cannot be found
Please re-open if needed.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.

[Bug 3111] Review Request: ppsspp - playstation portable emulator

[RPM Fusion Bugzilla]

http://bugzilla.rpmfusion.org/show_bug.cgi?id=3111

Nicolas Chauvet  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Blocks|2, 30   |
 Resolution|--- |EXPIRED

--- Comment #2 from Nicolas Chauvet  ---
No news, closing review, please re-open if needed.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.

[Bug 30] Tracker : Sponsorship Request

[RPM Fusion Bugzilla]

http://bugzilla.rpmfusion.org/show_bug.cgi?id=30

Nicolas Chauvet  changed:

   What|Removed |Added

 Depends on|3111|

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 1992] Review Request: winetricks - Package manager for Win32 DLLs and applications on POSIX

[RPM Fusion Bugzilla]

http://bugzilla.rpmfusion.org/show_bug.cgi?id=1992

Nicolas Chauvet  changed:

   What|Removed |Added

 Status|ASSIGNED|RESOLVED
 Resolution|--- |UPSTREAM

--- Comment #46 from Nicolas Chauvet  ---
imported in fedora

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug 2736] Review Request: fdk-aac - Fraunhofer FDK AAC Codec Library

[RPM Fusion Bugzilla]

http://bugzilla.rpmfusion.org/show_bug.cgi?id=2736

Nicolas Chauvet  changed:

   What|Removed |Added

 Depends on||33

--- Comment #30 from Nicolas Chauvet  ---
New Package CVS Request
===
Package Name: fdk-aac
Short Description: Fraunhofer FDK AAC Codec Library
Owners: kwizart,cjatherton
Branches: el6 el7 f23 f24 f25 devel
InitialCC: kwizart

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug 2736] Review Request: fdk-aac - Fraunhofer FDK AAC Codec Library

[RPM Fusion Bugzilla]

http://bugzilla.rpmfusion.org/show_bug.cgi?id=2736

Sérgio Basto  changed:

   What|Removed |Added

 Blocks|3   |4

--- Comment #29 from Sérgio Basto  ---
Package approved

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug 4224] Review Request: siril - Astronomical image (pre-)processing program

[RPM Fusion Bugzilla]

http://bugzilla.rpmfusion.org/show_bug.cgi?id=4224

--- Comment #11 from Andrea Musuruane  ---
(In reply to Nicolas Chauvet from comment #10)
> @Andrea
> Can you go ahead with the review ? I will sponsor Cyril in fas once reviewed
> and the fedora package retired.

@Nicolas
Siril is still in Fedora proper:
http://pkgs.fedoraproject.org/cgit/rpms/siril.git/tree/

Right now it is not possible to review this package - it won't be approved
because it conflicts with the Fedora package.

Either siril is retired in Fedora or a siril-freeworld package that uses ffms2
(still to be reviewed in #4225) is submitted.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.

[Bug 3576] Review request: obs-studio - Open Broadcaster Software Studio

[RPM Fusion Bugzilla]

http://bugzilla.rpmfusion.org/show_bug.cgi?id=3576

Nicolas Chauvet  changed:

   What|Removed |Added

 Status|ASSIGNED|RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug 2109] Request for sponsor: Kazam Video recorder

[RPM Fusion Bugzilla]

http://bugzilla.rpmfusion.org/show_bug.cgi?id=2109

Nicolas Chauvet  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |EXPIRED

--- Comment #2 from Nicolas Chauvet  ---
spec file isn't available anymore, please re-open if relevant.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.

[Bug 718] Review Request: gns3 - Graphical network simulator

[RPM Fusion Bugzilla]

http://bugzilla.rpmfusion.org/show_bug.cgi?id=718

Nicolas Chauvet  changed:

   What|Removed |Added

 Depends on|472 |

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.

[Bug 472] Review request: dynamips - IOS Emulator/Hypervisor

[RPM Fusion Bugzilla]

http://bugzilla.rpmfusion.org/show_bug.cgi?id=472

Nicolas Chauvet  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Blocks|2, 718  |
 Resolution|--- |EXPIRED

--- Comment #14 from Nicolas Chauvet  ---
GNS3 is a fedora 25 feature, but I don't know if dynamips could be added given
the new policy about emulator there. Please re-open if still relevant for RPM
Fusion.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.

[Bug 3151] Review request: Notion - A tabbed, tiling window manager forked from Ion3

[RPM Fusion Bugzilla]

http://bugzilla.rpmfusion.org/show_bug.cgi?id=3151

Nicolas Chauvet  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |EXPIRED

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.

[Bug 30] Tracker : Sponsorship Request

[RPM Fusion Bugzilla]

http://bugzilla.rpmfusion.org/show_bug.cgi?id=30

Nicolas Chauvet  changed:

   What|Removed |Added

 Depends on|2842|

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 2842] Review request: openssl-freeworld - Utilities from the general purpose cryptography library with TLS implementation

[RPM Fusion Bugzilla]

http://bugzilla.rpmfusion.org/show_bug.cgi?id=2842

Nicolas Chauvet  changed:

   What|Removed |Added

 Status|REOPENED|RESOLVED
 Blocks|2, 30   |
 Resolution|--- |EXPIRED

--- Comment #8 from Nicolas Chauvet  ---
Is this review still relevant ? Spec file is not available anymore.
Please re-add the blockers if relevant.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.

[Bug 3151] Review request: Notion - A tabbed, tiling window manager forked from Ion3

[RPM Fusion Bugzilla]

http://bugzilla.rpmfusion.org/show_bug.cgi?id=3151

Nicolas Chauvet  changed:

   What|Removed |Added

 Blocks|2, 30   |

--- Comment #3 from Nicolas Chauvet  ---
Is this review still relevant ? the spec file isn't available anymore.
Please re-add the blockers if needed.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.

[Bug 30] Tracker : Sponsorship Request

[RPM Fusion Bugzilla]

http://bugzilla.rpmfusion.org/show_bug.cgi?id=30

Nicolas Chauvet  changed:

   What|Removed |Added

 Depends on|3151|

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 2736] Review Request: fdk-aac - Fraunhofer FDK AAC Codec Library

[RPM Fusion Bugzilla]

http://bugzilla.rpmfusion.org/show_bug.cgi?id=2736

--- Comment #28 from Nicolas Chauvet  ---
(In reply to Sérgio Basto from comment #26)
> fedora-review --other-bz https://bugzilla.rpmfusion.org -b 2736 -m
> fedora-rawhide-x86_64-rpmfusion_nonfree
> 
> no issues , just not sure is documentation aacDecoder.pdf and aacEncoder.pdf
> should be in devel package , at least in -doc sub package ... 
Theses files are developers documentation of the library, the packaging
guideline doesn't mandate from which size a sub-package should be made, but
since it's already in a -devel I think it's fine to have them in -devel. (it's
less than 1Mo) 

> fdk-aac.spec looks good , source field could be more simple :
> https://github.com/mstorsjo/%{name}/archive/%{commit0}/%{name}-
> %{shortcommit0}.tar.gz
Fixed this one locally along with using Source0 instead of Source:

Thx for the review.

-- 
You are receiving this mail because:
You are on the CC list for the bug.