[Bug 3953] Review request: dwarffortress - A single-player procedurally generated fantasy game

[RPM Fusion Bugzilla]

https://bugzilla.rpmfusion.org/show_bug.cgi?id=3953

--- Comment #7 from Ben Rosser  ---
I've cleaned up the spec, removing the commented out blocks. I also put all the
BRs on their own lines and cleaned out some redundant ones.

I also changed the ExclusiveArch tag to i686 instead of using the macro (I only
used the macro to begin with because the guidelines still use the macro--
https://fedoraproject.org/wiki/Packaging:Guidelines#Runtime_Dependencies).

There are also a couple of other fixes that I'd pushed to my personal
repository (https://www.acm.jhu.edu/~bjr/fedora/dwarffortress/) that hadn't
wound up here, so the spec release is now at .5. 

I suppose I probably should write an AppData file for DF as well, since it
provides a graphical application. I'll get that done over the next few days.

Is the license tag acceptable? Or should it say something like "Custom"
instead?

Source URL:
https://www.acm.jhu.edu/~bjr/fedora/dwarffortress/rpmfusion/dwarffortress.spec
SRPM URL:
https://www.acm.jhu.edu/~bjr/fedora/dwarffortress/rpmfusion/dwarffortress-0.43.05-5.fc26.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.___
rpmfusion-developers mailing list -- rpmfusion-developers@lists.rpmfusion.org
To unsubscribe send an email to rpmfusion-developers-le...@lists.rpmfusion.org

[Bug 4041] Review request: mendeleydesktop - rpm of Mendeley

[RPM Fusion Bugzilla]

https://bugzilla.rpmfusion.org/show_bug.cgi?id=4041

--- Comment #15 from Mark Harfouche  ---
Hi Nicolas
Thanks for replying.

(In reply to Nicolas Chauvet from comment #14)
> > This is my first RPM Fusion Package. I am seeking a sponsor.
> Rathann can sponsor you.
Thanks 
> You will likely need this for a proprietary software.
> %globaldebug_package %{nil}
> %global__strip /bin/true
https://github.com/hmaarrfk/mendeley-rpm/blob/master/mendeleydesktop.spec#L49

> Fedora default to i686 nowadays (-march), so if this binary is really built
> for i486, it could lead to issue. Anyone tested it there ? If it doesn't
> work one could also drop 32bit support.
Hoenstly, I don't own a 32bit computer anymore. I think it is i486 because the
source for the binary has i486 in there.
It downloads as mendeleydesktop-1.17.10-linux-i486.tar.bz2

Also, adding the lines for i486 seems like work I wouldn't have done if the
default compilation worked.

If you want, I could install a VM and test it, but I have a feeling we have all
of 0 requests for a 32bit version.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.___
rpmfusion-developers mailing list -- rpmfusion-developers@lists.rpmfusion.org
To unsubscribe send an email to rpmfusion-developers-le...@lists.rpmfusion.org

[Bug 3805] Review request: cannonball - An Enhanced OutRun Engine

[RPM Fusion Bugzilla]

https://bugzilla.rpmfusion.org/show_bug.cgi?id=3805

--- Comment #3 from Nicolas Chauvet  ---
(In reply to Andrea Musuruane from comment #2)
> (In reply to Nicolas Chauvet from comment #1)
> > This review is 404, is it still current ? Please re-open if so.
> 
> Links probably broken due to Dropbox. I'll update them next week.
Thx.
Btw, please try to exchange review and don't let review hang that long.
Time is a scarce resource but still.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.___
rpmfusion-developers mailing list -- rpmfusion-developers@lists.rpmfusion.org
To unsubscribe send an email to rpmfusion-developers-le...@lists.rpmfusion.org

[Bug 4224] Review Request: siril - Astronomical image (pre-)processing program

[RPM Fusion Bugzilla]

https://bugzilla.rpmfusion.org/show_bug.cgi?id=4224

Nicolas Chauvet  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |MOVED

--- Comment #19 from Nicolas Chauvet  ---
Since siril 0.9.6 is in fedora updates, I guess that this review can be closed.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.___
rpmfusion-developers mailing list -- rpmfusion-developers@lists.rpmfusion.org
To unsubscribe send an email to rpmfusion-developers-le...@lists.rpmfusion.org

[Bug 30] Tracker : Sponsorship Request

[RPM Fusion Bugzilla]

https://bugzilla.rpmfusion.org/show_bug.cgi?id=30
Bug 30 depends on bug 4224, which changed state.

Bug 4224 Summary: Review Request: siril - Astronomical image (pre-)processing 
program
https://bugzilla.rpmfusion.org/show_bug.cgi?id=4224

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |MOVED

-- 
You are receiving this mail because:
You are the assignee for the bug.___
rpmfusion-developers mailing list -- rpmfusion-developers@lists.rpmfusion.org
To unsubscribe send an email to rpmfusion-developers-le...@lists.rpmfusion.org

[Bug 4105] Review request: sdcc-nonfree - Small Device C Compiler - nonfree files

[RPM Fusion Bugzilla]

https://bugzilla.rpmfusion.org/show_bug.cgi?id=4105

--- Comment #2 from Nicolas Chauvet  ---
You usually need to use this for pre-built binaries

%globaldebug_package %{nil}
%global__strip /bin/true

This should allow to remove lot of hack in this spec file.
Please update and seek a reviewer, please don't let the review hang.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.___
rpmfusion-developers mailing list -- rpmfusion-developers@lists.rpmfusion.org
To unsubscribe send an email to rpmfusion-developers-le...@lists.rpmfusion.org

[Bug 4027] fs-uae - Amiga emulator with on-screen GUI and online play support

[RPM Fusion Bugzilla]

https://bugzilla.rpmfusion.org/show_bug.cgi?id=4027

--- Comment #8 from Andrea Musuruane  ---
(In reply to Nicolas Chauvet from comment #7)
> review url produce a 404, please re-open if still relevant.

Links probably broken due to Dropbox. I'll update them next week.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.___
rpmfusion-developers mailing list -- rpmfusion-developers@lists.rpmfusion.org
To unsubscribe send an email to rpmfusion-developers-le...@lists.rpmfusion.org

[Bug 3805] Review request: cannonball - An Enhanced OutRun Engine

[RPM Fusion Bugzilla]

https://bugzilla.rpmfusion.org/show_bug.cgi?id=3805

--- Comment #2 from Andrea Musuruane  ---
(In reply to Nicolas Chauvet from comment #1)
> This review is 404, is it still current ? Please re-open if so.

Links probably broken due to Dropbox. I'll update them next week.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.___
rpmfusion-developers mailing list -- rpmfusion-developers@lists.rpmfusion.org
To unsubscribe send an email to rpmfusion-developers-le...@lists.rpmfusion.org

[Bug 4041] Review request: mendeleydesktop - rpm of Mendeley

[RPM Fusion Bugzilla]

https://bugzilla.rpmfusion.org/show_bug.cgi?id=4041

--- Comment #14 from Nicolas Chauvet  ---
(In reply to Mark Harfouche from comment #13)
> Reviving this bug because I think I addressed the previous issues. Thanks
> Dominik.
...
> This is my first RPM Fusion Package. I am seeking a sponsor.
Rathann can sponsor you.

You will likely need this for a proprietary software.
%globaldebug_package %{nil}
%global__strip /bin/true

Fedora default to i686 nowadays (-march), so if this binary is really built for
i486, it could lead to issue. Anyone tested it there ? If it doesn't work one
could also drop 32bit support.

I would prefer to use i686 even , as nobody knowns how dnf repo would handle
such i486 package which was not anywhere common to use on fedora land. (we used
i386, i586 or i686 for x86 32bit).
Anyway it's a minor issue as soon as it works.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.___
rpmfusion-developers mailing list -- rpmfusion-developers@lists.rpmfusion.org
To unsubscribe send an email to rpmfusion-developers-le...@lists.rpmfusion.org

[Bug 4029] fs-uae-arcade - Fullscreen game browser for FS-UAE

[RPM Fusion Bugzilla]

https://bugzilla.rpmfusion.org/show_bug.cgi?id=4029
Bug 4029 depends on bug 4027, which changed state.

Bug 4027 Summary: fs-uae - Amiga emulator with on-screen GUI and online play 
support
https://bugzilla.rpmfusion.org/show_bug.cgi?id=4027

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |EXPIRED

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.___
rpmfusion-developers mailing list -- rpmfusion-developers@lists.rpmfusion.org
To unsubscribe send an email to rpmfusion-developers-le...@lists.rpmfusion.org

[Bug 4028] fs-uae-launcher - Graphical configuration frontend and launcher for FS-UAE

[RPM Fusion Bugzilla]

https://bugzilla.rpmfusion.org/show_bug.cgi?id=4028
Bug 4028 depends on bug 4027, which changed state.

Bug 4027 Summary: fs-uae - Amiga emulator with on-screen GUI and online play 
support
https://bugzilla.rpmfusion.org/show_bug.cgi?id=4027

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |EXPIRED

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.___
rpmfusion-developers mailing list -- rpmfusion-developers@lists.rpmfusion.org
To unsubscribe send an email to rpmfusion-developers-le...@lists.rpmfusion.org

[Bug 4027] fs-uae - Amiga emulator with on-screen GUI and online play support

[RPM Fusion Bugzilla]

https://bugzilla.rpmfusion.org/show_bug.cgi?id=4027

Nicolas Chauvet  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |EXPIRED

--- Comment #7 from Nicolas Chauvet  ---
review url produce a 404, please re-open if still relevant.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.___
rpmfusion-developers mailing list -- rpmfusion-developers@lists.rpmfusion.org
To unsubscribe send an email to rpmfusion-developers-le...@lists.rpmfusion.org

[Bug 3954] Review request: nordlicht - Create colorful barcodes from video files

[RPM Fusion Bugzilla]

https://bugzilla.rpmfusion.org/show_bug.cgi?id=3954

--- Comment #2 from Nicolas Chauvet  ---
There is at least a 0.4.5 release, can you update and try to get a reviewer ?
(review exchange, etc)
Please don't let the review queue in such a pending state.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.___
rpmfusion-developers mailing list -- rpmfusion-developers@lists.rpmfusion.org
To unsubscribe send an email to rpmfusion-developers-le...@lists.rpmfusion.org

[Bug 3953] Review request: dwarffortress - A single-player procedurally generated fantasy game

[RPM Fusion Bugzilla]

https://bugzilla.rpmfusion.org/show_bug.cgi?id=3953

Nicolas Chauvet  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
   Assignee|rpmfusion-package-review@rp |kwiz...@gmail.com
   |mfusion.org |
  Flags||fedora-review?

--- Comment #6 from Nicolas Chauvet  ---
You should use:
%globaldebug_package %{nil}
%global__strip /bin/true
To avoid packaging issues with pre-built applications.

Use: ExclusiveArch:  x86_64 i686

It's usually better to use one BR per line for better readability with patches
when one or another is removed.

There are lot of comment in the spec files, please clean them.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.___
rpmfusion-developers mailing list -- rpmfusion-developers@lists.rpmfusion.org
To unsubscribe send an email to rpmfusion-developers-le...@lists.rpmfusion.org

[Bug 3805] Review request: cannonball - An Enhanced OutRun Engine

[RPM Fusion Bugzilla]

https://bugzilla.rpmfusion.org/show_bug.cgi?id=3805

Nicolas Chauvet  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Blocks|2   |
 Resolution|--- |EXPIRED

--- Comment #1 from Nicolas Chauvet  ---
This review is 404, is it still current ? Please re-open if so.


Referenced Bugs:

https://bugzilla.rpmfusion.org/show_bug.cgi?id=2
[Bug 2] Tracker: New packages awaiting review
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.___
rpmfusion-developers mailing list -- rpmfusion-developers@lists.rpmfusion.org
To unsubscribe send an email to rpmfusion-developers-le...@lists.rpmfusion.org

[Bug 3741] Review request: kodi-pvr-argustv - Kodi's ARGUS TV client addon

[RPM Fusion Bugzilla]

https://bugzilla.rpmfusion.org/show_bug.cgi?id=3741

--- Comment #3 from Nicolas Chauvet  ---
@Mohamed, are theses remaining kodi plugin still relevant ?
I'm about to mass review them if needed...
(no need to update, unless for closing if not relevant anymore).

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.___
rpmfusion-developers mailing list -- rpmfusion-developers@lists.rpmfusion.org
To unsubscribe send an email to rpmfusion-developers-le...@lists.rpmfusion.org

[Bug 3600] Review request: ubuntu-fonts - The font family used in Ubuntu Linux

[RPM Fusion Bugzilla]

https://bugzilla.rpmfusion.org/show_bug.cgi?id=3600

Nicolas Chauvet  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Blocks|2   |
 Resolution|--- |EXPIRED

--- Comment #2 from Nicolas Chauvet  ---
review expired, link are 404 as of today.


Referenced Bugs:

https://bugzilla.rpmfusion.org/show_bug.cgi?id=2
[Bug 2] Tracker: New packages awaiting review
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.___
rpmfusion-developers mailing list -- rpmfusion-developers@lists.rpmfusion.org
To unsubscribe send an email to rpmfusion-developers-le...@lists.rpmfusion.org

[Bug 4614] Review Request: libva - Video Acceleration (VA) API for Linux

[RPM Fusion Bugzilla]

https://bugzilla.rpmfusion.org/show_bug.cgi?id=4614

Nicolas Chauvet  changed:

   What|Removed |Added

 Blocks||2


Referenced Bugs:

https://bugzilla.rpmfusion.org/show_bug.cgi?id=2
[Bug 2] Tracker: New packages awaiting review
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.___
rpmfusion-developers mailing list -- rpmfusion-developers@lists.rpmfusion.org
To unsubscribe send an email to rpmfusion-developers-le...@lists.rpmfusion.org

[Bug 4614] Review Request: libva - Video Acceleration (VA) API for Linux

[RPM Fusion Bugzilla]

https://bugzilla.rpmfusion.org/show_bug.cgi?id=4614

Nicolas Chauvet  changed:

   What|Removed |Added

  Group|Package Reviews |
 CC list accessible|1   |0
   Reporter|1   |0
 accessible||

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.___
rpmfusion-developers mailing list -- rpmfusion-developers@lists.rpmfusion.org
To unsubscribe send an email to rpmfusion-developers-le...@lists.rpmfusion.org

[Bug 4614] New: Review Request: libva - Video Acceleration (VA) API for Linux

[RPM Fusion Bugzilla]

https://bugzilla.rpmfusion.org/show_bug.cgi?id=4614

Bug ID: 4614
   Summary: Review Request: libva - Video Acceleration (VA) API
for Linux
   Product: Package Reviews
   Version: Current
  Hardware: x86_64
OS: GNU/Linux
Status: NEW
  Severity: enhancement
  Priority: P1
 Component: Review Request
  Assignee: rpmfusion-package-rev...@rpmfusion.org
  Reporter: kwiz...@gmail.com
CC: rpmfusion-package-rev...@rpmfusion.org
 Group: Package Reviews

SRPM: http://dl.kwizart.net/review/libva-1.2.1-1.el7.src.rpm
SPEC: http://dl.kwizart.net/review/libva.spec
Summary: Video Acceleration (VA) API for Linux

This is the package to build only for epel7 i686 as the package is provided in
fedora/epel

EPEL doesn't build i686 packages, this will allow to make the
libva-intel-driver available in both flavor...

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.___
rpmfusion-developers mailing list -- rpmfusion-developers@lists.rpmfusion.org
To unsubscribe send an email to rpmfusion-developers-le...@lists.rpmfusion.org

[Bug 4612] Review Request: libtgvoip - VoIP library for Telegram clients

[RPM Fusion Bugzilla]

https://bugzilla.rpmfusion.org/show_bug.cgi?id=4612

--- Comment #14 from Vitaly Zaitsev  ---
> At this step, it seems easier to keep webrtc-audio-processing bundled.

Yes, I think that this is a best choice.

-- 
You are receiving this mail because:
You are on the CC list for the bug.___
rpmfusion-developers mailing list -- rpmfusion-developers@lists.rpmfusion.org
To unsubscribe send an email to rpmfusion-developers-le...@lists.rpmfusion.org

Re: [buildsys-build-rpmfusion/el6] rebuild for kernel 2.6.32-696.el6

[Nicolas Chauvet]

2017-08-03 16:08 GMT+02:00 Sérgio Basto :
> Hello,
>
> Have anyone built akmods on el6 ? just curiosity
Sure:
https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2017-1aba440e63
___
rpmfusion-developers mailing list -- rpmfusion-developers@lists.rpmfusion.org
To unsubscribe send an email to rpmfusion-developers-le...@lists.rpmfusion.org

Re: patches from Hans de Goede for rpmfusion virtualbox-guest-additions (package has broken opengl-passthru support)

[Nicolas Chauvet]

2017-08-03 16:15 GMT+02:00 Sérgio Basto :
> Hello,
> I got patches made by Hans (and sent by him) to apply on VBox package ,
> I though that I should ask before apply it . Anyone see any problem on
> try Hans patches on virtualbox-guest-additions  ?

Can you try to default to make change using public discussion ?
Please use bugzilla.rpmfusion.org

Thx

-- 
-

Nicolas (kwizart)
___
rpmfusion-developers mailing list -- rpmfusion-developers@lists.rpmfusion.org
To unsubscribe send an email to rpmfusion-developers-le...@lists.rpmfusion.org

patches from Hans de Goede for rpmfusion virtualbox-guest-additions (package has broken opengl-passthru support)

[Sérgio Basto]

Hello, 
I got patches made by Hans (and sent by him) to apply on VBox package ,
I though that I should ask before apply it . Anyone see any problem on
try Hans patches on virtualbox-guest-additions  ? 

Thanks and best regards, 
-- 
Sérgio M. B.
___
rpmfusion-developers mailing list -- rpmfusion-developers@lists.rpmfusion.org
To unsubscribe send an email to rpmfusion-developers-le...@lists.rpmfusion.org

Re: [buildsys-build-rpmfusion/el6] rebuild for kernel 2.6.32-696.el6

[Sérgio Basto]

Hello, 

Have anyone built akmods on el6 ? just curiosity 

Best regards, 

On Thu, 2017-08-03 at 15:57 +0200, Nicolas Chauvet wrote:
> commit fd974c08e12cd647ab155abec5415a5659879b67
> Author: Nicolas Chauvet 
> Date:   Thu Aug 3 15:57:31 2017 +0200
> 
> rebuild for kernel 2.6.32-696.el6
> 
>  buildsys-build-rpmfusion-kerneldevpkgs-current | 8 
>  buildsys-build-rpmfusion.spec  | 5 -
>  2 files changed, 8 insertions(+), 5 deletions(-)
> ---
> diff --git a/buildsys-build-rpmfusion-kerneldevpkgs-current
> b/buildsys-build-rpmfusion-kerneldevpkgs-current
> index ef6667a..a2e9c51 100644
> --- a/buildsys-build-rpmfusion-kerneldevpkgs-current
> +++ b/buildsys-build-rpmfusion-kerneldevpkgs-current
> @@ -1,4 +1,4 @@
> -2.6.32-642.el6
> -2.6.32-642.el6smp
> -2.6.32-642.el6PAE
> -2.6.32-642.el6lpae
> +2.6.32-696.el6
> +2.6.32-696.el6smp
> +2.6.32-696.el6PAE
> +2.6.32-696.el6lpae
> diff --git a/buildsys-build-rpmfusion.spec b/buildsys-build-
> rpmfusion.spec
> index 22c392f..ec122ef 100644
> --- a/buildsys-build-rpmfusion.spec
> +++ b/buildsys-build-rpmfusion.spec
> @@ -3,7 +3,7 @@
>  Name:   buildsys-build-%{repo}
>  Epoch:  11
>  Version:18
> -Release:1
> +Release:2
>  Summary:Tools and files used by the %{repo} buildsys 
>  
>  Group:  Development/Tools
> @@ -86,6 +86,9 @@ rm -rf $RPM_BUILD_ROOT
>  
>  
>  %changelog
> +* Thu Aug 03 2017 Nicolas Chauvet  - 11:18-2
> +- rebuild for kernel 2.6.32-696.el6
> +
>  * Thu Aug 03 2017 Nicolas Chauvet  - 11:18-1
>  - rebuild for kernel 2.6.32-642.el6
>  
> ___
> rpmfusion-commits mailing list -- rpmfusion-commits@lists.rpmfusion.o
> rg
> To unsubscribe send an email to rpmfusion-commits-leave@lists.rpmfusi
> on.org
-- 
Sérgio M. B.
___
rpmfusion-developers mailing list -- rpmfusion-developers@lists.rpmfusion.org
To unsubscribe send an email to rpmfusion-developers-le...@lists.rpmfusion.org

[Bug 4612] Review Request: libtgvoip - VoIP library for Telegram clients

[RPM Fusion Bugzilla]

https://bugzilla.rpmfusion.org/show_bug.cgi?id=4612

--- Comment #13 from Nicolas Chauvet  ---
(In reply to Vitaly Zaitsev from comment #12)
...
> > If I would be accurate, you should also unbundle webrtc-audio-processing by 
> > making a webrtc-audio-processing-freeworld package.
> I can unbundle it, but first someone need to add
> webrtc-audio-processing-freeworld with full set of required algorithms.
Well, you could make it. But it would be complicated given freeworld packages
up to now are packages that can be installed on their own (like
freetype-freeworld) and that are not installed as a mandatory dependency from
another software.

In others word, there would be a need to verify that
webrtc-audio-processing-freeworld would not produce unexpected behavior with
packages in fedora using the patent free webrtc-audio-processing from fedora.

Another way would be to build this package with a rpath on a directory where
the webrtc-audio-processing-freeworld would reside (outside of the linker
search path).

At this step, it seems easier to keep webrtc-audio-processing bundled.

Anyway, I don't have strong opinion on this, you just need not to break others
software.

-- 
You are receiving this mail because:
You are on the CC list for the bug.___
rpmfusion-developers mailing list -- rpmfusion-developers@lists.rpmfusion.org
To unsubscribe send an email to rpmfusion-developers-le...@lists.rpmfusion.org

[Bug 4612] Review Request: libtgvoip - VoIP library for Telegram clients

[RPM Fusion Bugzilla]

https://bugzilla.rpmfusion.org/show_bug.cgi?id=4612

--- Comment #12 from Vitaly Zaitsev  ---
> Can you (reviewee, reviewer, anyone) please state why unbundling a library 
> that is only useful to telegram even make sense ? what's the reasoning behind 
> ?

libtgvoip is required for Telegram Desktop voice calls.

Full webrtc-audio-processing (with aec) is required for libtgvoip to add echo
cancellation and noice reduction. It cannot be built without it.

Now libtgvoip is included into Telegram Desktop package. I want to separate it
for two reasons:
1. don't build it with Telegram to decrease build time and don't waste build
infra resources;
2. Telegram forks and alternate clients can use this library instead of
bundling their own.

> If I would be accurate, you should also unbundle webrtc-audio-processing by 
> making a webrtc-audio-processing-freeworld package.

I can unbundle it, but first someone need to add
webrtc-audio-processing-freeworld with full set of required algorithms.

-- 
You are receiving this mail because:
You are on the CC list for the bug.___
rpmfusion-developers mailing list -- rpmfusion-developers@lists.rpmfusion.org
To unsubscribe send an email to rpmfusion-developers-le...@lists.rpmfusion.org

[Bug 4612] Review Request: libtgvoip - VoIP library for Telegram clients

[RPM Fusion Bugzilla]

https://bugzilla.rpmfusion.org/show_bug.cgi?id=4612

--- Comment #11 from Nicolas Chauvet  ---
(In reply to Vasiliy Glazov from comment #9)
> (In reply to leigh scott from comment #8)
> > I removed the + flag as I see no review!
> 
> May be you can repair fedora-review?

It's your duty to produce a public review, tooling should not replace your own
responsibility.

Can you (reviewee, reviewer, anyone) please state why unbundling a library that
is only useful to telegram even make sense ? what's the reasoning behind ?

If I would be accurate, you should also unbundle webrtc-audio-processing by
making a webrtc-audio-processing-freeworld package. Seems like you are making
halt of the job here, so I really fail to understand what's the reasoning
behind.

I'm not very pleased to such pointless changes because I see packagers wasted
time that would better be employed by doing other reviews...

-- 
You are receiving this mail because:
You are on the CC list for the bug.___
rpmfusion-developers mailing list -- rpmfusion-developers@lists.rpmfusion.org
To unsubscribe send an email to rpmfusion-developers-le...@lists.rpmfusion.org

[Bug 4612] Review Request: libtgvoip - VoIP library for Telegram clients

[RPM Fusion Bugzilla]

https://bugzilla.rpmfusion.org/show_bug.cgi?id=4612

--- Comment #10 from Vitaly Zaitsev  ---
Spec URL: https://github.com/xvitaly/tgbuild/raw/master/libtgvoip.spec
SRPM URL:
http://koji.russianfedora.pro/kojifiles/work/tasks/4692/54692/libtgvoip-1.0-2.20170801gitbfd5cfe.fc27.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.___
rpmfusion-developers mailing list -- rpmfusion-developers@lists.rpmfusion.org
To unsubscribe send an email to rpmfusion-developers-le...@lists.rpmfusion.org

[Bug 4612] Review Request: libtgvoip - VoIP library for Telegram clients

[RPM Fusion Bugzilla]

https://bugzilla.rpmfusion.org/show_bug.cgi?id=4612

--- Comment #9 from Vasiliy Glazov  ---
(In reply to leigh scott from comment #8)
> I removed the + flag as I see no review!

May be you can repair fedora-review?

-- 
You are receiving this mail because:
You are on the CC list for the bug.___
rpmfusion-developers mailing list -- rpmfusion-developers@lists.rpmfusion.org
To unsubscribe send an email to rpmfusion-developers-le...@lists.rpmfusion.org

[Bug 4612] Review Request: libtgvoip - VoIP library for Telegram clients

[RPM Fusion Bugzilla]

https://bugzilla.rpmfusion.org/show_bug.cgi?id=4612

--- Comment #8 from leigh scott  ---
I removed the + flag as I see no review!

-- 
You are receiving this mail because:
You are on the CC list for the bug.___
rpmfusion-developers mailing list -- rpmfusion-developers@lists.rpmfusion.org
To unsubscribe send an email to rpmfusion-developers-le...@lists.rpmfusion.org

[Bug 4612] Review Request: libtgvoip - VoIP library for Telegram clients

[RPM Fusion Bugzilla]

https://bugzilla.rpmfusion.org/show_bug.cgi?id=4612

leigh scott  changed:

   What|Removed |Added

  Flags|fedora-review?  |fedora-review-

-- 
You are receiving this mail because:
You are on the CC list for the bug.___
rpmfusion-developers mailing list -- rpmfusion-developers@lists.rpmfusion.org
To unsubscribe send an email to rpmfusion-developers-le...@lists.rpmfusion.org

[Bug 4612] Review Request: libtgvoip - VoIP library for Telegram clients

[RPM Fusion Bugzilla]

https://bugzilla.rpmfusion.org/show_bug.cgi?id=4612

leigh scott  changed:

   What|Removed |Added

  Flags|fedora-review+  |fedora-review?

-- 
You are receiving this mail because:
You are on the CC list for the bug.___
rpmfusion-developers mailing list -- rpmfusion-developers@lists.rpmfusion.org
To unsubscribe send an email to rpmfusion-developers-le...@lists.rpmfusion.org

[Bug 4612] Review Request: libtgvoip - VoIP library for Telegram clients

[RPM Fusion Bugzilla]

https://bugzilla.rpmfusion.org/show_bug.cgi?id=4612

Vasiliy Glazov  changed:

   What|Removed |Added

  Flags||fedora-review+

-- 
You are receiving this mail because:
You are on the CC list for the bug.___
rpmfusion-developers mailing list -- rpmfusion-developers@lists.rpmfusion.org
To unsubscribe send an email to rpmfusion-developers-le...@lists.rpmfusion.org