[Bug 4670] Review request: shotcut - A free, open source, cross-platform video editor

[RPM Fusion Bugzilla]

https://bugzilla.rpmfusion.org/show_bug.cgi?id=4670

--- Comment #2 from mgans...@online.de  ---
you are welcome.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.___
rpmfusion-developers mailing list -- rpmfusion-developers@lists.rpmfusion.org
To unsubscribe send an email to rpmfusion-developers-le...@lists.rpmfusion.org

[Bug 4670] Review request: shotcut - A free, open source, cross-platform video editor

[RPM Fusion Bugzilla]

https://bugzilla.rpmfusion.org/show_bug.cgi?id=4670

Dan Horák  changed:

   What|Removed |Added

 CC||d...@danny.cz

--- Comment #1 from Dan Horák  ---
I'm going to do the review unless someone else will be faster. It will allow me
to drop my own shotcut WIP package :-)

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.___
rpmfusion-developers mailing list -- rpmfusion-developers@lists.rpmfusion.org
To unsubscribe send an email to rpmfusion-developers-le...@lists.rpmfusion.org

[Bug 4669] Review request: comskip - A free commercial detector

[RPM Fusion Bugzilla]

https://bugzilla.rpmfusion.org/show_bug.cgi?id=4669

--- Comment #3 from Matt Prahl  ---
Thanks for the review. I've addressed your comments in the latest spec file.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.___
rpmfusion-developers mailing list -- rpmfusion-developers@lists.rpmfusion.org
To unsubscribe send an email to rpmfusion-developers-le...@lists.rpmfusion.org

[Bug 4670] Review request: shotcut - A free, open source, cross-platform video editor

[RPM Fusion Bugzilla]

https://bugzilla.rpmfusion.org/show_bug.cgi?id=4670

mgans...@online.de  changed:

   What|Removed |Added

 Blocks||2


Referenced Bugs:

https://bugzilla.rpmfusion.org/show_bug.cgi?id=2
[Bug 2] Tracker: New packages awaiting review
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.___
rpmfusion-developers mailing list -- rpmfusion-developers@lists.rpmfusion.org
To unsubscribe send an email to rpmfusion-developers-le...@lists.rpmfusion.org

[Bug 4670] New: Review request: shotcut - A free, open source, cross-platform video editor

[RPM Fusion Bugzilla]

https://bugzilla.rpmfusion.org/show_bug.cgi?id=4670

Bug ID: 4670
   Summary: Review request: shotcut - A free, open source,
cross-platform video editor
   Product: Package Reviews
   Version: Current
  Hardware: x86_64
OS: GNU/Linux
Status: NEW
  Severity: enhancement
  Priority: P1
 Component: Review Request
  Assignee: rpmfusion-package-rev...@rpmfusion.org
  Reporter: mgans...@online.de
CC: rpmfusion-package-rev...@rpmfusion.org
 namespace: free

Spec URL: https://martinkg.fedorapeople.org/Review/SPECS/shotcut.spec
SRPM URL:
https://martinkg.fedorapeople.org/Review/SRPMS/shotcut-17.09-1.fc26.src.rpm

Description:
Shotcut is a free and open-source cross-platform video editing application for
Windows, OS X, and Linux.

Shotcut supports many video, audio, and image formats via FFmpeg and screen,
webcam, and audio capture. It uses a timeline for non-linear video editing of
multiple tracks that may be composed of various file formats. Scrubbing and
transport control are assisted by OpenGL GPU-based processing and a number of
video and audio filters are available.

Fedora Account System Username: martinkg

This package is not eligible to be included in Fedora, because it depends on
x264


rpmlint -i -v shotcut.spec
/home/martin/rpmbuild/SRPMS/shotcut-17.09-1.fc26.src.rpm
/home/martin/rpmbuild/RPMS/x86_64/shotcut-17.09-1.fc26.x86_64.rpm
/home/martin/rpmbuild/RPMS/noarch/shotcut-langpack-de-17.09-1.fc26.noarch.rpm
shotcut.spec: I: checking
shotcut.spec:59: E: buildarch-instead-of-exclusivearch-tag noarch \
Use ExclusiveArch instead of BuildArch (or BuildArchitectures) to restrict
build on some specific architectures. Only use BuildArch with noarch

shotcut.spec:110: W: rpm-buildroot-usage %build PREFIX=%{buildroot}%{_prefix}
$RPM_BUILD_ROOT should not be touched during %build or %prep stage, as it may
break short circuit builds.

shotcut.spec: I: checking-url
https://github.com/mltframework/shotcut/archive/v17.09.tar.gz#/shotcut-17.09.tar.gz
(timeout 10 seconds)
shotcut.src: I: checking
shotcut.src: W: spelling-error %description -l en_US timeline -> time line,
time-line, timeliness
The value of this tag appears to be misspelled. Please double-check.

shotcut.src: I: checking-url http://www.shotcut.org/ (timeout 10 seconds)
shotcut.src:59: E: buildarch-instead-of-exclusivearch-tag noarch \
Use ExclusiveArch instead of BuildArch (or BuildArchitectures) to restrict
build on some specific architectures. Only use BuildArch with noarch

shotcut.src:110: W: rpm-buildroot-usage %build PREFIX=%{buildroot}%{_prefix}
$RPM_BUILD_ROOT should not be touched during %build or %prep stage, as it may
break short circuit builds.

shotcut.src: I: checking-url
https://github.com/mltframework/shotcut/archive/v17.09.tar.gz#/shotcut-17.09.tar.gz
(timeout 10 seconds)
shotcut.x86_64: I: checking
shotcut.x86_64: I: checking-url http://www.shotcut.org/ (timeout 10 seconds)
shotcut.x86_64: W: no-manual-page-for-binary shotcut
Each executable in standard binary directories should have a man page.

shotcut-langpack-de.noarch: I: checking
shotcut-langpack-de.noarch: I: checking-url http://www.shotcut.org/ (timeout 10
seconds)
shotcut-langpack-de.noarch: W: no-documentation
The package contains no documentation (README, doc, etc). You have to include
documentation files.

3 packages and 1 specfiles checked; 2 errors, 5 warnings.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.___
rpmfusion-developers mailing list -- rpmfusion-developers@lists.rpmfusion.org
To unsubscribe send an email to rpmfusion-developers-le...@lists.rpmfusion.org

[Bug 4669] Review request: comskip - A free commercial detector

[RPM Fusion Bugzilla]

https://bugzilla.rpmfusion.org/show_bug.cgi?id=4669

--- Comment #2 from Andrea Musuruane  ---

(In reply to Matt Prahl from comment #0)
> Spec file: https://mprahl.fedorapeople.org/comskip.spec
> SRPM: https://mprahl.fedorapeople.org/comskip-0.82.002-1.fc26.src.rpm
> Description: Comskip is a free commercial detector

Why don't you generate a debug package?
https://fedoraproject.org/wiki/Packaging:Guidelines#Debuginfo_packages

# The maintainer stopped doing git tags, so we need a specific commit hash to
download from
Source0:   
https://github.com/erikkaashoek/Comskip/archive/b8c32737fffad1ff6b02a37441b84c6fadc21e2b.tar.gz

Please read about how to correctly create tarballs from github:
https://fedoraproject.org/wiki/Packaging:SourceURL#Git_Hosting_Services

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.___
rpmfusion-developers mailing list -- rpmfusion-developers@lists.rpmfusion.org
To unsubscribe send an email to rpmfusion-developers-le...@lists.rpmfusion.org

[Bug 30] Tracker : Sponsorship Request

[RPM Fusion Bugzilla]

https://bugzilla.rpmfusion.org/show_bug.cgi?id=30

Andrea Musuruane  changed:

   What|Removed |Added

 Depends on|4669|


Referenced Bugs:

https://bugzilla.rpmfusion.org/show_bug.cgi?id=4669
[Bug 4669] Review request: comskip - A free commercial detector
-- 
You are receiving this mail because:
You are the assignee for the bug.___
rpmfusion-developers mailing list -- rpmfusion-developers@lists.rpmfusion.org
To unsubscribe send an email to rpmfusion-developers-le...@lists.rpmfusion.org

[Bug 4669] Review request: comskip - A free commercial detector

[RPM Fusion Bugzilla]

https://bugzilla.rpmfusion.org/show_bug.cgi?id=4669

Andrea Musuruane  changed:

   What|Removed |Added

 CC||musur...@gmail.com
 Blocks|30  |

--- Comment #1 from Andrea Musuruane  ---
(In reply to Matt Prahl from comment #0)
> Hello,
> This is my first RPMFusion package. I am a sponsored Fedora packager, but
> not an RPMFusion packager.

Hi,
Fedora packagers don't need to be sponsored in RPM Fusion. Removing
NEEDSPONSORS.


Referenced Bugs:

https://bugzilla.rpmfusion.org/show_bug.cgi?id=30
[Bug 30] Tracker : Sponsorship Request
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.___
rpmfusion-developers mailing list -- rpmfusion-developers@lists.rpmfusion.org
To unsubscribe send an email to rpmfusion-developers-le...@lists.rpmfusion.org