[Bug 4852] Review request: gmediarender - Resource efficient UPnP/DLNA renderer

[RPM Fusion Bugzilla]

https://bugzilla.rpmfusion.org/show_bug.cgi?id=4852

Zamir SUN  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |MOVED

--- Comment #5 from Zamir SUN  ---
Approved in Fedora. So closing this.
https://bugzilla.redhat.com/show_bug.cgi?id=1564835

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.___
rpmfusion-developers mailing list -- rpmfusion-developers@lists.rpmfusion.org
To unsubscribe send an email to rpmfusion-developers-le...@lists.rpmfusion.org

[Bug 4826] Update build requirements and options for Mixxx 2.1

[RPM Fusion Bugzilla]

https://bugzilla.rpmfusion.org/show_bug.cgi?id=4826

--- Comment #14 from Uwe Klotz  ---
I have fixed the open issues in the .spec file and updated both master and f28
branch to 2.1.0-rc1. Build tasks have succeeded.

-- 
You are receiving this mail because:
You are on the CC list for the bug.___
rpmfusion-developers mailing list -- rpmfusion-developers@lists.rpmfusion.org
To unsubscribe send an email to rpmfusion-developers-le...@lists.rpmfusion.org

[Bug 3954] Review request: nordlicht - Create colorful barcodes from video files

[RPM Fusion Bugzilla]

https://bugzilla.rpmfusion.org/show_bug.cgi?id=3954

--- Comment #4 from Nicolas Chauvet  ---
Please drop Groups
Use arched Requires on libs
Verify that last release will build on f28+ ffmpeg 3.5git.

-- 
You are receiving this mail because:
You are on the CC list for the bug.___
rpmfusion-developers mailing list -- rpmfusion-developers@lists.rpmfusion.org
To unsubscribe send an email to rpmfusion-developers-le...@lists.rpmfusion.org

[Bug 3036] Review request: RBDOOM-3-BFG - Robert Beckebans' Doom 3 BFG engine

[RPM Fusion Bugzilla]

https://bugzilla.rpmfusion.org/show_bug.cgi?id=3036

--- Comment #12 from Nicolas Chauvet  ---
@Simone
Are you still interested in this package, or can we close ?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.___
rpmfusion-developers mailing list -- rpmfusion-developers@lists.rpmfusion.org
To unsubscribe send an email to rpmfusion-developers-le...@lists.rpmfusion.org

[Bug 4700] Review request: bitwig-studio - A dynamic software for creation and performance of musical ideas

[RPM Fusion Bugzilla]

https://bugzilla.rpmfusion.org/show_bug.cgi?id=4700

Nicolas Chauvet  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |EXPIRED

--- Comment #6 from Nicolas Chauvet  ---
Closing because no answear. Please re-open if you think you can address the
comments.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.___
rpmfusion-developers mailing list -- rpmfusion-developers@lists.rpmfusion.org
To unsubscribe send an email to rpmfusion-developers-le...@lists.rpmfusion.org

[Bug 4041] Review request: mendeleydesktop - rpm of Mendeley

[RPM Fusion Bugzilla]

https://bugzilla.rpmfusion.org/show_bug.cgi?id=4041

--- Comment #21 from Nicolas Chauvet  ---
(In reply to Mark Harfouche from comment #19)
> Sorry, the lastest version is untested. Don't have access to Fedora at the
> moment.
Please try to update the review as soon as possible.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.___
rpmfusion-developers mailing list -- rpmfusion-developers@lists.rpmfusion.org
To unsubscribe send an email to rpmfusion-developers-le...@lists.rpmfusion.org

[Bug 4806] Review Request: vdr-vaapidevice - A VA-API output device plugin for VDR

[RPM Fusion Bugzilla]

https://bugzilla.rpmfusion.org/show_bug.cgi?id=4806

Nicolas Chauvet  changed:

   What|Removed |Added

  Flags||fedora-review?

-- 
You are receiving this mail because:
You are on the CC list for the bug.___
rpmfusion-developers mailing list -- rpmfusion-developers@lists.rpmfusion.org
To unsubscribe send an email to rpmfusion-developers-le...@lists.rpmfusion.org

[Bug 4806] Review Request: vdr-vaapidevice - A VA-API output device plugin for VDR

[RPM Fusion Bugzilla]

https://bugzilla.rpmfusion.org/show_bug.cgi?id=4806

Nicolas Chauvet  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 Blocks|2   |
   Assignee|zebo...@gmail.com   |kwiz...@gmail.com
  Flags|fedora-review?  |

--- Comment #15 from Nicolas Chauvet  ---
@Robert-André 
I'm taking over if you don't mind, as I've already started the review, and you
were very active for others already (thanks a lot for that!).

@Martin,
I don't think there are much issue left, but still:
- Obsoletes have to use < version, and you need to use a Provides higher than
the obsoleted package.
So the plan is to retire the other package, right ?
- Can you use the %{url} macro in Source0
- With f28+, I've added hardware activation on the libva-intel-driver package.
So it should be suggested when using appdata. (it's also included by default in
the mediacenter spin).
Please consider to drop this dependency, as hardware activation is way better
than any Suggests when the hardware is not relevant. (mesa vaapi backend exists
for nouveau and radeon).
Instead, I would suggest to use a boolean dependency from a vdr base package
such as:
Requires: (vdr-vaapidevice if libva-intel-driver)

- I still don't get why you enforce Xorg. Are you really sure that Wayland does
not work in this case ? Also Xorg should be installed by default even in case
Wayland is used by default, so it shouldn't fix anything. Better to drop the
dependency IMO.


I also note that there is indeed a dependency on ffmpeg-libs, so this package
is not relevant for fedora at this step.


Referenced Bugs:

https://bugzilla.rpmfusion.org/show_bug.cgi?id=2
[Bug 2] Tracker: New packages awaiting review
-- 
You are receiving this mail because:
You are on the CC list for the bug.___
rpmfusion-developers mailing list -- rpmfusion-developers@lists.rpmfusion.org
To unsubscribe send an email to rpmfusion-developers-le...@lists.rpmfusion.org

[Bug 3900] Review Request: tivolibre - Java app and library for decoding TiVo files to standard MPEG files

[RPM Fusion Bugzilla]

https://bugzilla.rpmfusion.org/show_bug.cgi?id=3900

Nicolas Chauvet  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |EXPIRED

--- Comment #7 from Nicolas Chauvet  ---
Please re-open if the review is still active (or create a new review if anyone
wants to take over).

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.___
rpmfusion-developers mailing list -- rpmfusion-developers@lists.rpmfusion.org
To unsubscribe send an email to rpmfusion-developers-le...@lists.rpmfusion.org

[Bug 2997] Review Request: spinroot - Formal verification of multi-threaded software applications

[RPM Fusion Bugzilla]

https://bugzilla.rpmfusion.org/show_bug.cgi?id=2997

Nicolas Chauvet  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |EXPIRED

--- Comment #6 from Nicolas Chauvet  ---
Please re-open when ready.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.___
rpmfusion-developers mailing list -- rpmfusion-developers@lists.rpmfusion.org
To unsubscribe send an email to rpmfusion-developers-le...@lists.rpmfusion.org

[Bug 4835] Review Request: b43-firmware - Firmware for Broadcom wireless devices

[RPM Fusion Bugzilla]

https://bugzilla.rpmfusion.org/show_bug.cgi?id=4835

Nicolas Chauvet  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED

-- 
You are receiving this mail because:
You are on the CC list for the bug.___
rpmfusion-developers mailing list -- rpmfusion-developers@lists.rpmfusion.org
To unsubscribe send an email to rpmfusion-developers-le...@lists.rpmfusion.org

[Bug 3430] Review request: qtads - Multimedia interpreter for Tads games

[RPM Fusion Bugzilla]

https://bugzilla.rpmfusion.org/show_bug.cgi?id=3430

--- Comment #8 from Nicolas Chauvet  ---
FYI, I've verified that the fas account was created and you are in the packager
group. But you haven't "signed" the new CLA, so you might need to check it in
the admin.rpmfusion.org/accounts before to import the package.

If not done by this month I will close the review and remove the ACL.
Please proceed with the import.

-- 
You are receiving this mail because:
You are on the CC list for the bug.___
rpmfusion-developers mailing list -- rpmfusion-developers@lists.rpmfusion.org
To unsubscribe send an email to rpmfusion-developers-le...@lists.rpmfusion.org

[Bug 4860] Review Request: openhantek - Oscilloscope GUI

[RPM Fusion Bugzilla]

https://bugzilla.rpmfusion.org/show_bug.cgi?id=4860

Vitaly Zaitsev  changed:

   What|Removed |Added

  Flags||fedora-review+

--- Comment #2 from Vitaly Zaitsev  ---
1. Add into License tag Apache (v2.0), GPLv2 and information about nonfree
firmwares.

2. Fix directories without known owners: /usr/lib/udev, /usr/lib/udev/rules.d
by adding udev into requirements.

I think this can be fixed during package import. Package approved.

-- 
You are receiving this mail because:
You are on the CC list for the bug.___
rpmfusion-developers mailing list -- rpmfusion-developers@lists.rpmfusion.org
To unsubscribe send an email to rpmfusion-developers-le...@lists.rpmfusion.org

[Bug 4860] Review Request: openhantek - Oscilloscope GUI

[RPM Fusion Bugzilla]

https://bugzilla.rpmfusion.org/show_bug.cgi?id=4860

Vitaly Zaitsev  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||vit...@easycoding.org
   Assignee|rpmfusion-package-review@rp |vit...@easycoding.org
   |mfusion.org |

--- Comment #1 from Vitaly Zaitsev  ---
Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed

= MUST items =

C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.

Generic:
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[x]: License field in the package spec file matches the actual license.
 Note: Checking patched sources after %prep for licenses. Licenses
 found: "Apache (v2.0)", "GPL (v2 or later) (with incorrect FSF
 address)", "GPL (v2 or later)", "GPL (v3 or later)", "Unknown or
 generated". 214 files have unknown license. Detailed output of
 licensecheck in /home/vitaly/1558362-openhantek/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: Package must own all directories that it creates.
 Note: Directories without known owners: /usr/lib/udev,
 /usr/lib/udev/rules.d
[x]: Package does not own files or directories owned by other packages.
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[x]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
 names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[x]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[x]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Large documentation must go in a -doc subpackage. Large could be size
 (~1MB) or number of files.
 Note: Documentation size is 10240 bytes in 1 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
 one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
 Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
 license(s) in its own file, then that file, containing the text of the
 license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
 beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package contains desktop file if it is a GUI application.
[x]: Package installs a %{name}.desktop using desktop-file-install or
 desktop-file-validate if there is such a file.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
 work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
 provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
 %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

= SHOULD items =

Generic:
[x]: If the source package does not include license text(s) as a separate
 file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Fully versioned dependency in subpackages if applicable.
 Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in
 openhantek-debuginfo , openhantek-debugsource
[x]: Package functions as described.
[x]: 

[Bug 4860] New: Review Request: openhantek - Oscilloscope GUI

[RPM Fusion Bugzilla]

https://bugzilla.rpmfusion.org/show_bug.cgi?id=4860

Bug ID: 4860
   Summary: Review Request: openhantek - Oscilloscope GUI
   Product: Package Reviews
   Version: Current
  Hardware: x86_64
OS: GNU/Linux
Status: NEW
  Severity: enhancement
  Priority: P1
 Component: Review Request
  Assignee: rpmfusion-package-rev...@rpmfusion.org
  Reporter: vasc...@gmail.com
CC: rpmfusion-package-rev...@rpmfusion.org
 namespace: free

Spec URL:
https://raw.githubusercontent.com/RussianFedora/openhantek/master/openhantek.spec
SRPM URL:
http://koji.rpmfusion.org/kojifiles/work/tasks/8059/218059/openhantek-0-1.20180320git0eff8d4.fc29.src.rpm

Description:
OpenHantek is a free software for Hantek and compatible
(Voltcraft/Darkwire/Protek/Acetech) USB digital signal oscilloscopes.

Homepage http://openhantek.org

Not in fedora because contain copyrighted blob firmware.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.___
rpmfusion-developers mailing list -- rpmfusion-developers@lists.rpmfusion.org
To unsubscribe send an email to rpmfusion-developers-le...@lists.rpmfusion.org

[Bug 4835] Review Request: b43-firmware - Firmware for Broadcom wireless devices

[RPM Fusion Bugzilla]

https://bugzilla.rpmfusion.org/show_bug.cgi?id=4835

leigh scott  changed:

   What|Removed |Added

 CC||leigh123li...@gmail.com
  Flags||fedora-review+

--- Comment #1 from leigh scott  ---
Spec file looks good.

Approved

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.___
rpmfusion-developers mailing list -- rpmfusion-developers@lists.rpmfusion.org
To unsubscribe send an email to rpmfusion-developers-le...@lists.rpmfusion.org

[Bug 4835] Review Request: b43-firmware - Firmware for Broadcom wireless devices

[RPM Fusion Bugzilla]

https://bugzilla.rpmfusion.org/show_bug.cgi?id=4835

leigh scott  changed:

   What|Removed |Added

   Assignee|rpmfusion-package-review@rp |leigh123li...@gmail.com
   |mfusion.org |

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.___
rpmfusion-developers mailing list -- rpmfusion-developers@lists.rpmfusion.org
To unsubscribe send an email to rpmfusion-developers-le...@lists.rpmfusion.org