[Bug 4041] Review request: mendeleydesktop - rpm of Mendeley
https://bugzilla.rpmfusion.org/show_bug.cgi?id=4041
--- Comment #36 from Luya Tshimbalanga ---
> I'd suggest something like:
> %prep
> %ifarch i686
> %setup -q -n mendeleydesktop-%{version}-linux-i486
> %else
> %setup -q -b 1 -T -n mendeleydesktop-%{version}-linux-%{_target_cpu}
> %endif
I realized I could replace "mendeleydesktop" by %{name}. I will do it once
approved.
--
You are receiving this mail because:
You are on the CC list for the bug.___
rpmfusion-developers mailing list -- rpmfusion-developers@lists.rpmfusion.org
To unsubscribe send an email to rpmfusion-developers-le...@lists.rpmfusion.org
[Bug 4041] Review request: mendeleydesktop - rpm of Mendeley
https://bugzilla.rpmfusion.org/show_bug.cgi?id=4041
--- Comment #35 from Luya Tshimbalanga ---
(In reply to Dominik 'Rathann' Mierzejewski from comment #33)
> Actually you can't even do that. Making the Source: conditional is wrong and
> leads to non-reproducible SRPMs (i.e. if you rpmbuild -bs on x86_64 you'll
> only get the x86_64 tarball which won't work on i686). You have to include
> all tarballs in the SRPM unconditionally.
>
> I'd suggest something like:
> %prep
> %ifarch i686
> %setup -q -n mendeleydesktop-%{version}-linux-i486
> %else
> %setup -q -b 1 -T -n mendeleydesktop-%{version}-linux-%{_target_cpu}
> %endif
>
Done. I removed the no longer needed "-b 1 -T" parameters.
> > Now the executable mendeleydesktop resulted:
> > mendeleydesktop
> > Can't find Mendeley Desktop binary. Expected:
> > /usr/bin/../../opt/mendeleydesktop/bin/mendeleydesktop
> > Unable to start Mendeley Desktop, the software may not be installed
> > correctly.
>
> Hm. Works for me:
> https://gitlab.com/greysector/mendeleydesktop/blob/master/mendeleydesktop.
> spec .
>
> I can see you're including the python launcher:
> install -Dpm755 bin/%{name} %{buildroot}%{_bindir}/%{name}
> install -Dpm755 lib/mendeleydesktop/libexec/%{name}.%{_target_cpu}
> %{buildroot}%{_libexecdir}/%{name}
>
> I used to do that in my package as well, but as of 1.16.1 I dropped the
> launcher, moved the binary to %{_bindir} and it works.
Using that method allow the application to start after installing it.
> Why do you have this?
> Requires: qt5-qtstyleplugins
A remain from previous work. Removed.
> Also,
> # Needed to resolve shebang issue
> BuildRequires: python3-devel
> BuildRequires: /usr/bin/pathfix.py
>
> python3-devel includes /usr/bin/pathfix.py (use %{_bindir}, by the way), so
> it's redundant.
Removed that redundancy.
> Thanks for writing the appdata files.
You are very welcome.
Here is the updated files
SPECS:
https://raw.githubusercontent.com/luyatshimbalanga/mendeley-rpm/master/mendeleydesktop.spec
SRPMS:
https://github.com/luyatshimbalanga/mendeley-rpm/releases/download/1.19.3/mendeleydesktop-1.19.3-2.fc29.src.rpm
--
You are receiving this mail because:
You are on the CC list for the bug.___
rpmfusion-developers mailing list -- rpmfusion-developers@lists.rpmfusion.org
To unsubscribe send an email to rpmfusion-developers-le...@lists.rpmfusion.org
Kodi 18.1 update
Hi all, I was attempting to push the Kodi 18.1 update, but the aarch64 build failed with a strange error. It looks like gcc or annobin didn't fully install. Is it a disk space issue? http://koji.rpmfusion.org/koji/taskinfo?taskID=296321 Thanks, Michael ___ rpmfusion-developers mailing list -- rpmfusion-developers@lists.rpmfusion.org To unsubscribe send an email to rpmfusion-developers-le...@lists.rpmfusion.org
[Bug 5155] Review request: pulseaudio-module-bluetooth-aptx - Bluetooth support for the PulseAudio sound server, supports extra codecs
https://bugzilla.rpmfusion.org/show_bug.cgi?id=5155 leigh scott changed: What|Removed |Added Blocks|30 | Referenced Bugs: https://bugzilla.rpmfusion.org/show_bug.cgi?id=30 [Bug 30] Tracker : Sponsorship Request -- You are receiving this mail because: You are on the CC list for the bug. You are the assignee for the bug.___ rpmfusion-developers mailing list -- rpmfusion-developers@lists.rpmfusion.org To unsubscribe send an email to rpmfusion-developers-le...@lists.rpmfusion.org
[Bug 30] Tracker : Sponsorship Request
https://bugzilla.rpmfusion.org/show_bug.cgi?id=30 leigh scott changed: What|Removed |Added Depends on|5155| Referenced Bugs: https://bugzilla.rpmfusion.org/show_bug.cgi?id=5155 [Bug 5155] Review request: pulseaudio-module-bluetooth-aptx - Bluetooth support for the PulseAudio sound server, supports extra codecs -- You are receiving this mail because: You are the assignee for the bug.___ rpmfusion-developers mailing list -- rpmfusion-developers@lists.rpmfusion.org To unsubscribe send an email to rpmfusion-developers-le...@lists.rpmfusion.org
Re: Introduction + looking for a sponsor
Thanks! I have updated the package (plus now I'm a Fedora packager): https://bugzilla.rpmfusion.org/show_bug.cgi?id=5155#c3 Best regards, Greg Gergely Gombos ezt írta (időpont: 2019. jan. 30., Sze, 9:21): > Hi Nicolas, > > Thanks for the quick response! > > First I'm going to submit 'libldac' to Fedora since the Bluetooth > package wouldn't build without it. > > So you're saying that I will have to rename the package to > 'pulseaudio-module-bluetooth-freeworld' or > 'pulseaudio-module-bluetooth-nonfree' depending on its dependencies? > > I'm going to ask upstream why fdk-aac is needed. > > Best regards, > > Greg > > 2019. 01. 30. 5:06 keltezéssel, Nicolas Chauvet írta: > > Le mer. 30 janv. 2019 à 05:04, Gergely Gombos a > écrit : > >> Hi RPMFusion devs, > >> > >> My name is Gergely Gombos. I've been using Fedora for about 1.5 years > and I'm a software developer. I like the FOSS philosophy and using a lot of > open-source software in the Javascript world, I'd like to make my > contribution, too. > >> > >> I'm looking for a sponsor, and my first RPM package is > "pulseaudio-module-bluetooth-aptx" and its dependency "libldac". > >> > >> The original project - yet to be merged into upstream Pulseaudio - > provides awesome audio quality for Bluetooth headsets via aptX, AAC and > LDAC codecs. This is something that is hard to set up even on Windows! And > this package works seamlessly on Linux. > >> > >> Originally this was in a COPR repo, with >100 downloads, but it got > deleted due to legal reasons (ffmpeg build dependency). So I hope it will > find a new home here since Fedora users are waiting for it. > >> > >> I've spent quite a lot of time figuring out how RPM packaging works and > get this working and (hopefully) conforming to the guidelines - I > appreciate your review and help. > > Thx for your interest in the project and welcome. > > > > As stated by Leigh, there is a need to verify that libldac is patent > > clear according to RedHat Legal or not, then we will introduce in RPM > > Fusion free if needed. > > > > Another point is that we have a policy not to replace any > > fedora/redhat package. So we you cannot rename the library so it can > > install along, then the other way is to conflicts with the fedora > > package. End-users will have to remove the fedora package and install > > ours. > > > > Also you seems to provide a binary package using a source archive > > which name is already in the fedora repo. We used to have a -freeworld > > suffix to handle such case when the package is relevant to the free > > section and -nonfree suffix when it's relevant to the nonfree section. > > Please try to adapt as appropriate. > > ___ > > rpmfusion-developers mailing list -- > rpmfusion-developers@lists.rpmfusion.org > > To unsubscribe send an email to > rpmfusion-developers-le...@lists.rpmfusion.org > ___ rpmfusion-developers mailing list -- rpmfusion-developers@lists.rpmfusion.org To unsubscribe send an email to rpmfusion-developers-le...@lists.rpmfusion.org
[Bug 5155] Review request: pulseaudio-module-bluetooth-aptx - Bluetooth support for the PulseAudio sound server, supports extra codecs
https://bugzilla.rpmfusion.org/show_bug.cgi?id=5155 --- Comment #3 from Gergely Gombos --- Hi all! Great news. The dependency of this package, libldac has been approved in Fedora. (It's in rawhide plus you can test & give some karma in Bodhi for F29: https://bodhi.fedoraproject.org/updates/FEDORA-2019-90c880c7cc) I have been sponsored as a Fedora packager. Do I need separate sponsorship here? If not, I'll remove NEEDSPONSORS blocking. I have updated this package. According to Nicolas' email, I renamed to pulseaudio-module-bluetooth-nonfree, which now conflicts with (and provides) pulseaudio-module-bluetooth. Currently it depends on fdk-aac so it's nonfree, and looks like it's going to stay this way for a while. But still it could be a great addition to RPMFusion. It will still need a review here... My questions: - Can I always provide just the latest version (Rawhide) of the module, as long as I apply the same patches? - For maximum cpmpatibility, can I just keep most of the upstream (read: Fedora's PA) specfile as long as I only install the Bluetooth module? Fortunately PA has not been updated in Fedora for the last half year or so. SPEC: https://pagure.io/pulseaudio-module-bluetooth-aptx/raw/master/f/pulseaudio-module-bluetooth-nonfree.spec SRPM: https://pagure.io/pulseaudio-module-bluetooth-aptx/raw/master/f/pulseaudio-module-bluetooth-nonfree-12.2-1.fc30.src.rpm RPM (local build F29): https://pagure.io/pulseaudio-module-bluetooth-aptx/raw/master/f/pulseaudio-module-bluetooth-nonfree-12.2-1.fc30.x86_64.rpm Rpmlint: pulseaudio-module-bluetooth-nonfree.x86_64: W: no-documentation pulseaudio-module-bluetooth-nonfree.x86_64: W: empty-%post 2 packages and 1 specfiles checked; 0 errors, 2 warnings. -- You are receiving this mail because: You are on the CC list for the bug. You are the assignee for the bug.___ rpmfusion-developers mailing list -- rpmfusion-developers@lists.rpmfusion.org To unsubscribe send an email to rpmfusion-developers-le...@lists.rpmfusion.org
[Bug 4041] Review request: mendeleydesktop - rpm of Mendeley
https://bugzilla.rpmfusion.org/show_bug.cgi?id=4041
--- Comment #34 from Dominik 'Rathann' Mierzejewski ---
Requires: %{name}%{?_isa} = %{version}-%{release}
Strict arched dependency is not actually necessary. The plugin communicates
with mendeleydesktop over HTTP on localhost TCP socket, so you can mix i686 and
x86_64 versions. You can leave it though.
--
You are receiving this mail because:
You are on the CC list for the bug.___
rpmfusion-developers mailing list -- rpmfusion-developers@lists.rpmfusion.org
To unsubscribe send an email to rpmfusion-developers-le...@lists.rpmfusion.org
[Bug 4041] Review request: mendeleydesktop - rpm of Mendeley
https://bugzilla.rpmfusion.org/show_bug.cgi?id=4041
--- Comment #33 from Dominik 'Rathann' Mierzejewski ---
(In reply to Luya Tshimbalanga from comment #32)
> (In reply to Dominik 'Rathann' Mierzejewski from comment #30)
[...]
> > 2. The application is available for i686 as well:
> > https://www.mendeley.com/download-desktop/
> > ->mendeleydesktop-1.19.3-1.fc29.src.rpm
> > https://desktop-download.mendeley.com/download/linux/mendeleydesktop-1.19.3-
> > linux-i486.tar.bz2
>
> Is there a better method to use a single tarball for both x86 and x86_64
> other than conditional statemetn? Suggestion welcome
Actually you can't even do that. Making the Source: conditional is wrong and
leads to non-reproducible SRPMs (i.e. if you rpmbuild -bs on x86_64 you'll only
get the x86_64 tarball which won't work on i686). You have to include all
tarballs in the SRPM unconditionally.
I'd suggest something like:
%prep
%ifarch i686
%setup -q -n mendeleydesktop-%{version}-linux-i486
%else
%setup -q -b 1 -T -n mendeleydesktop-%{version}-linux-%{_target_cpu}
%endif
> > 3. You're missing ExcludeArch: i686 x86_64
>
> Do you mean ExclusiveArch?
Yes.
> > 4. Why do you think you need this?
> >
> > # seems like the executable is looking for this variable
> > # so I had to set it.
> > cat > bin/%{name} < > #!/bin/sh
> > export MENDELEY_BUNDLED_QT_PLUGIN_PATH=%{_libdir}/qt5/plugins
> > %{_libexecdir}/%{name} "$@"
> > EOF
> > chmod +x bin/%{name}
> >
> > -> Is something not working without the above? In my testing, this is not
> > required and you can install the binary directly in %{_bindir}:
> > install -Dpm755 lib/mendeleydesktop/libexec/%{name}.%{_target_cpu}
> > %{buildroot}%{_bindir}/%{name}
>
> Now the executable mendeleydesktop resulted:
> mendeleydesktop
> Can't find Mendeley Desktop binary. Expected:
> /usr/bin/../../opt/mendeleydesktop/bin/mendeleydesktop
> Unable to start Mendeley Desktop, the software may not be installed
> correctly.
Hm. Works for me:
https://gitlab.com/greysector/mendeleydesktop/blob/master/mendeleydesktop.spec
.
I can see you're including the python launcher:
install -Dpm755 bin/%{name} %{buildroot}%{_bindir}/%{name}
install -Dpm755 lib/mendeleydesktop/libexec/%{name}.%{_target_cpu}
%{buildroot}%{_libexecdir}/%{name}
I used to do that in my package as well, but as of 1.16.1 I dropped the
launcher, moved the binary to %{_bindir} and it works.
Why do you have this?
Requires: qt5-qtstyleplugins
Also,
# Needed to resolve shebang issue
BuildRequires: python3-devel
BuildRequires: /usr/bin/pathfix.py
python3-devel includes /usr/bin/pathfix.py (use %{_bindir}, by the way), so
it's redundant.
Thanks for writing the appdata files.
--
You are receiving this mail because:
You are on the CC list for the bug.___
rpmfusion-developers mailing list -- rpmfusion-developers@lists.rpmfusion.org
To unsubscribe send an email to rpmfusion-developers-le...@lists.rpmfusion.org
