[Bug 15] Review Request: bsnes - SNES emulator focused on accuracy
http://bugzilla.rpmfusion.org/show_bug.cgi?id=15 --- Comment #55 from Julian Sikorski beleg...@gmail.com 2009-10-25 11:49:34 --- One last thing to do: owners.list in free and nonfree need to be updated. -- Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug.
[Bug 15] Review Request: bsnes - SNES emulator focused on accuracy
http://bugzilla.rpmfusion.org/show_bug.cgi?id=15 --- Comment #56 from Xavier Lamien lxt...@gmail.com 2009-10-25 13:07:56 --- Done. -- Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug.
[Bug 15] Review Request: bsnes - SNES emulator focused on accuracy
http://bugzilla.rpmfusion.org/show_bug.cgi?id=15 Julian Sikorski beleg...@gmail.com changed: What|Removed |Added Status|REOPENED|RESOLVED Resolution||FIXED -- Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug.
[Bug 15] Review Request: bsnes - SNES emulator focused on accuracy
http://bugzilla.rpmfusion.org/show_bug.cgi?id=15 Thorsten Leemhuis fed...@leemhuis.info changed: What|Removed |Added Blocks|33 | -- Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug.
[Bug 15] Review Request: bsnes - SNES emulator focused on accuracy
http://bugzilla.rpmfusion.org/show_bug.cgi?id=15 --- Comment #53 from Julian Sikorski beleg...@gmail.com 2009-10-05 10:56:04 --- I'm still getting access denied when trying to update the free cvs. -- Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug.
[Bug 15] Review Request: bsnes - SNES emulator focused on accuracy
http://bugzilla.rpmfusion.org/show_bug.cgi?id=15 --- Comment #54 from Xavier Lamien lxt...@gmail.com 2009-10-05 12:19:24 --- Acls updated. -- Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug.
[Bug 15] Review Request: bsnes - SNES emulator focused on accuracy
http://bugzilla.rpmfusion.org/show_bug.cgi?id=15 --- Comment #51 from Thorsten Leemhuis fed...@leemhuis.info 2009-10-04 14:16:44 --- (In reply to comment #50) Package Change Request == Package Name: bsnes -- New license tag: free @Xavier, can you handle that on the CVS side please? @Julian, please remind me to remove the old packages from the nonfree repos once the new ones settled properly in free; tia -- Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug.
[Bug 15] Review Request: bsnes - SNES emulator focused on accuracy
http://bugzilla.rpmfusion.org/show_bug.cgi?id=15 Julian Sikorski beleg...@gmail.com changed: What|Removed |Added Blocks||33 Status|RESOLVED|REOPENED Resolution|FIXED | --- Comment #50 from Julian Sikorski beleg...@gmail.com 2009-09-29 13:20:56 --- Package Change Request == Package Name: bsnes -- New license tag: free As of 0.051, bsnes is now GPLv2, so please move it to the free repo. -- Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug.
[Bug 15] Review Request: bsnes - SNES emulator focused on accuracy
http://bugzilla.rpmfusion.org/show_bug.cgi?id=15 Thorsten Leemhuis fed...@leemhuis.info changed: What|Removed |Added Blocks||4 -- Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug.
[Bug 15] Review Request: bsnes - SNES emulator focused on accuracy
http://bugzilla.rpmfusion.org/show_bug.cgi?id=15 Julian Sikorski [EMAIL PROTECTED] changed: What|Removed |Added Blocks|4 | Status|NEW |RESOLVED Resolution||FIXED --- Comment #49 from Julian Sikorski [EMAIL PROTECTED] 2008-12-05 00:40:45 --- Imported and built. -- Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug.
[Bug 15] Review Request: bsnes - SNES emulator focused on accuracy
http://bugzilla.rpmfusion.org/show_bug.cgi?id=15 Xavier Lamien [EMAIL PROTECTED] changed: What|Removed |Added CC||[EMAIL PROTECTED] Blocks|33 | --- Comment #48 from Xavier Lamien [EMAIL PROTECTED] 2008-12-03 21:39:57 --- cvs done. -- Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug.
[Bug 15] Review Request: bsnes - SNES emulator focused on accuracy
http://bugzilla.rpmfusion.org/show_bug.cgi?id=15
David Timms [EMAIL PROTECTED] changed:
What|Removed |Added
Blocks|2 |3
--- Comment #45 from David Timms [EMAIL PROTECTED] 2008-12-02 13:34:52 ---
(In reply to comment #44)
[ x ] source URL is incorrect:
think it should be: ...%{name}_v0.%{vernumber}...
upstream calls it 037a but compresses source to v0.037a
I'm not sure what you mean here, that's how the upstream tarball is called
Oops, I pasted the source url into web browser, then subsituted name and
version (instead of vernumber), and hence thought the source0 URL was incorrect
because I received a 404.
In fact that SourceURL is correct, as you noted. Ignore that ;)
(I'm aware it uncompresses to a folder of slightly different name. Besides,
if the Source0 URL would be incorrect, the package won't build, would it?
What an awful grammar. Should be: “Besides, if the Source0 URL were
incorrect, the package wouldn't build, would it?”
Yes, the package will still build.
Unless I'm mistaken, the process when we are constructing SRPMs is to manually
download the mentioned source0 into our ~/rpmbuild/SOURCES folder. Then we run
rpmbuild which reads the .spec and archives that ~/rpmbuild/SOURCES/source0
file into a .src.rpm. Neither rpmbuild -bs or -ba actually retrieve the
mentioned sources direct from the internet.
That is why we get reviewers to compare md5sums between upstream download URLs,
and the source included in the .src.rpm to check the source is clean. When the
package is imported into cvs, the packager imports the approved .src.rpm. This
extracts the main source, and uploads it to the cvs-lookaside cache. The build
system uses this source straight out of the .src.rpm the packager created (so
we best be sure the source is not tainted).
=
(In reply to comment #42)
(In reply to comment #41)
Spec URL: http://belegdol.republika.pl/rpmstuff/bsnes.spec
SRPM URL: http://belegdol.republika.pl/rpmstuff/bsnes-0.037a-4.fc10.src.rpm
...
Julian: I think we are really close here, just a few items above {x and ?} to
either fix or provide reasoning for. Reading back over the review, it seems
you have completed pretty well all requests reviewers have made, beside the
make it use all system libaries. If there are other reviewers who believe
further work should be done on the use system libraries item, can you
please speak up now ?
Noting replies on rpmfusion-devel:
- packager should at least trace (e.g. in comments) which
system libraries are not used and why.
- If there are strong reasons not to this should be documented case by case
with comments in the spec file
- enough of a diversion from the standard snes_ntsc library to warrant an
exception
- my own reading of the code the modified video processing filter algorithm
calls back into bsnes specific c++ colortable code, that isn't available when
the library is built stand alone
With some small notes included in the spec to the fact
- the application is built with modified private copy of the snes_ntsc filter,
- Exclusive arch reason being that libco is only available on these platforms,
I (David Timms) approve this package bsnes.
--
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
[Bug 15] Review Request: bsnes - SNES emulator focused on accuracy
http://bugzilla.rpmfusion.org/show_bug.cgi?id=15 Julian Sikorski [EMAIL PROTECTED] changed: What|Removed |Added Blocks|3 |4, 33 --- Comment #47 from Julian Sikorski [EMAIL PROTECTED] 2008-12-02 15:02:25 --- Package CVS request == Package Name: bsnes Short Description: SNES emulator focused on accuracy Owners: [EMAIL PROTECTED] Branches: F-10 F-9 InitialCC: -- License tag: nonfree -- Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug.
[Bug 15] Review Request: bsnes - SNES emulator focused on accuracy
http://bugzilla.rpmfusion.org/show_bug.cgi?id=15
--- Comment #43 from Julian Sikorski [EMAIL PROTECTED] 2008-11-30 15:47:11
---
(In reply to comment #42)
(In reply to comment #41)
Spec URL: http://belegdol.republika.pl/rpmstuff/bsnes.spec
SRPM URL: http://belegdol.republika.pl/rpmstuff/bsnes-0.037a-4.fc10.src.rpm
Changes:
- Fixed README.Fedora permissions
- Added information concerning pulseaudio issues
Done as requested.
Full review:
[ OK] rpmlint is clean:
$ rpmlint /home/davidt/rpmbuild/SRPMS/bsnes-0.037a-4.fc9.src.rpm
/home/davidt/rpmbuild/RPMS/i386/bsnes-0.037a-4.fc9.i386.rpm
/home/davidt/rpmbuild/RPMS/i386/bsnes-debuginfo-0.037a-4.fc9.i386.rpm
3 packages and 0 specfiles checked; 0 errors, 0 warnings.
[ OK] name meets guidelines
[ OK] spec filename is correct
[ OK] meets package quidelines
[ OK] license is non-free = rpmfusion not fedora
[ OK] license field matches upstream redistributable, no mods.
[ OK] license text file is included
[ OK] spec file is legible, easy to understand
[ x ] source URL is incorrect:
think it should be: ...%{name}_v0.%{vernumber}...
upstream calls it 037a but compresses source to v0.037a
I'm not sure what you mean here, that's how the upstream tarball is called (I'm
aware it uncompresses to a folder of slightly different name. Besides, if the
Source0 URL would be incorrect, the package won't build, would it?
[ OK] upstream md5sum matches .src.rpm
$ md5sum bsnes_v037a.tar.bz2
9fa2fbae8a09a747f9b4a44123bde0bb bsnes_v037a.tar.bz2
$ md5sum bsnes-0.037a-4.fc10.src/bsnes_v037a.tar.bz2
9fa2fbae8a09a747f9b4a44123bde0bb bsnes-0.037a-4.fc10.src/bsnes_v037a.tar.bz2
[ OK] rpmbuild binary rpms built.
[ x ] ExcludeArch not used in favour of ExclusiveArch: i386 x86_64
is there no possibility of this working on ppc etc. If so, I believe a
comment
above this field to briefly indicate why it's x86 only, could be
application
uses x86 CPU machine code, so needs an x86 CPU {if that is the reason}.
[Not sure if we want to make a bugzilla/block tracker bug - depends on the
reason why no ppc/other architectures]
OK, I'll add an explanation then. The reason is that libco only supports these
two architectures.
[ OK] BuiildRequires are specified.
[ ? ] No localization is provided in the main source. I am not sure what work
would be required to use the available individual locale.cfg files
automatically. It seems you would simply copy a single one of them into the
bin
dir as locale.cfg, and bsnes would only use that translation ?
AFAIK, bsnes can use only one locale.cfg at a time, so packaging several at
once seems impossible.
[ NA] no shared libraries are compiled or installed
[ OK] No relocatable (Prefix: is not used)
[ OK] owns directories it creates, disowns other dirs.
[ OK] no duplicates in the %files stanza
[ OK] permissions defattr included, other files have their perms fixed in
%prep
[ OK] %clean matches required content
[ OK] code versus content: this is a hardware emulator, no roms included.
[ OK] doc is small - no separate -doc package
[ OK] no %doc files are not required at runtime
[ NA] no header files, no static libraries, no pkgconfig, no libaries,
no -devel, no libtool archives.
[ OK] gui app and has legit .desktop file, installed by desktop-file-install,
and BRs: desktop-file-utils
[ OK] source filenames appear to be valid utf-8
[ OK] package functions as described.
[ ? ] an icon provided at /usr/share/icons/, yet the GTK+ icon cache update
scriptlet isn't used - why not ? why was it removed when it was previously
included ?
It was removed because the icon was installed to datadir/pixmaps at the time
upstream was not installing it at all. I pointed out to byuu that datadir/icons
is a place for themed icons and bsnes one should go to datadir/pixmaps, but
that was left without response. Also, packaging guidelines are only saying
about subdirs of datadir/icons.
[ ? ] (In reply to comment #8)
It seems that bsnes is using its own versions of system libraries. This
should
be avoided.
my opinion on use of included rather than system library for snes_ntsc is
it would be a lot of effort, and the included version calculates the
values
differently, so we would need to decide if those changes could get pushed
upstream. Also given byuu's opinion on the zlib that you worked on
already,
it would be unlikely to be included upstream.
Julian: I think we are really close here, just a few items above {x and ?} to
either fix or provide reasoning for. Reading back over the review, it seems
you
have completed pretty well all requests reviewers have made, beside the make
it use all system libaries. If there are other reviewers who believe further
work should be done on the use system libraries item, can you please speak
up
now ?
--
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
--- You are
[Bug 15] Review Request: bsnes - SNES emulator focused on accuracy
http://bugzilla.rpmfusion.org/show_bug.cgi?id=15
--- Comment #44 from Julian Sikorski [EMAIL PROTECTED] 2008-11-30 15:48:47
---
(In reply to comment #43)
(In reply to comment #42)
(In reply to comment #41)
Spec URL: http://belegdol.republika.pl/rpmstuff/bsnes.spec
SRPM URL:
http://belegdol.republika.pl/rpmstuff/bsnes-0.037a-4.fc10.src.rpm
Changes:
- Fixed README.Fedora permissions
- Added information concerning pulseaudio issues
Done as requested.
Full review:
[ OK] rpmlint is clean:
$ rpmlint /home/davidt/rpmbuild/SRPMS/bsnes-0.037a-4.fc9.src.rpm
/home/davidt/rpmbuild/RPMS/i386/bsnes-0.037a-4.fc9.i386.rpm
/home/davidt/rpmbuild/RPMS/i386/bsnes-debuginfo-0.037a-4.fc9.i386.rpm
3 packages and 0 specfiles checked; 0 errors, 0 warnings.
[ OK] name meets guidelines
[ OK] spec filename is correct
[ OK] meets package quidelines
[ OK] license is non-free = rpmfusion not fedora
[ OK] license field matches upstream redistributable, no mods.
[ OK] license text file is included
[ OK] spec file is legible, easy to understand
[ x ] source URL is incorrect:
think it should be: ...%{name}_v0.%{vernumber}...
upstream calls it 037a but compresses source to v0.037a
I'm not sure what you mean here, that's how the upstream tarball is called
(I'm
aware it uncompresses to a folder of slightly different name. Besides, if the
Source0 URL would be incorrect, the package won't build, would it?
What an awful grammar. Should be: “Besides, if the Source0 URL were
incorrect, the package wouldn't build, would it?”
[ OK] upstream md5sum matches .src.rpm
$ md5sum bsnes_v037a.tar.bz2
9fa2fbae8a09a747f9b4a44123bde0bb bsnes_v037a.tar.bz2
$ md5sum bsnes-0.037a-4.fc10.src/bsnes_v037a.tar.bz2
9fa2fbae8a09a747f9b4a44123bde0bb
bsnes-0.037a-4.fc10.src/bsnes_v037a.tar.bz2
[ OK] rpmbuild binary rpms built.
[ x ] ExcludeArch not used in favour of ExclusiveArch: i386 x86_64
is there no possibility of this working on ppc etc. If so, I believe a
comment
above this field to briefly indicate why it's x86 only, could be
application
uses x86 CPU machine code, so needs an x86 CPU {if that is the reason}.
[Not sure if we want to make a bugzilla/block tracker bug - depends on the
reason why no ppc/other architectures]
OK, I'll add an explanation then. The reason is that libco only supports these
two architectures.
[ OK] BuiildRequires are specified.
[ ? ] No localization is provided in the main source. I am not sure what
work
would be required to use the available individual locale.cfg files
automatically. It seems you would simply copy a single one of them into the
bin
dir as locale.cfg, and bsnes would only use that translation ?
AFAIK, bsnes can use only one locale.cfg at a time, so packaging several at
once seems impossible.
[ NA] no shared libraries are compiled or installed
[ OK] No relocatable (Prefix: is not used)
[ OK] owns directories it creates, disowns other dirs.
[ OK] no duplicates in the %files stanza
[ OK] permissions defattr included, other files have their perms fixed in
%prep
[ OK] %clean matches required content
[ OK] code versus content: this is a hardware emulator, no roms included.
[ OK] doc is small - no separate -doc package
[ OK] no %doc files are not required at runtime
[ NA] no header files, no static libraries, no pkgconfig, no libaries,
no -devel, no libtool archives.
[ OK] gui app and has legit .desktop file, installed by
desktop-file-install,
and BRs: desktop-file-utils
[ OK] source filenames appear to be valid utf-8
[ OK] package functions as described.
[ ? ] an icon provided at /usr/share/icons/, yet the GTK+ icon cache update
scriptlet isn't used - why not ? why was it removed when it was previously
included ?
It was removed because the icon was installed to datadir/pixmaps at the time
upstream was not installing it at all. I pointed out to byuu that
datadir/icons
is a place for themed icons and bsnes one should go to datadir/pixmaps, but
that was left without response. Also, packaging guidelines are only saying
about subdirs of datadir/icons.
[ ? ] (In reply to comment #8)
It seems that bsnes is using its own versions of system libraries. This
should
be avoided.
my opinion on use of included rather than system library for snes_ntsc
is
it would be a lot of effort, and the included version calculates the
values
differently, so we would need to decide if those changes could get
pushed
upstream. Also given byuu's opinion on the zlib that you worked on
already,
it would be unlikely to be included upstream.
Julian: I think we are really close here, just a few items above {x and ?}
to
either fix or provide reasoning for. Reading back over the review, it seems
you
have completed pretty well all requests reviewers have made, beside
[Bug 15] Review Request: bsnes - SNES emulator focused on accuracy
http://bugzilla.rpmfusion.org/show_bug.cgi?id=15 --- Comment #32 from David Timms [EMAIL PROTECTED] 2008-11-29 13:40:49 --- Created an attachment (id=44) -- (http://bugzilla.rpmfusion.org/attachment.cgi?id=44) gnome crash debug log (In reply to comment #31) Could you try setting selinux in permissive mode and retest? # setenforce 0 sestatus shows permissive now Similar result. Also tested by build and install with F10 i386 arch. Next bt is from that run. -- Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug.
[Bug 15] Review Request: bsnes - SNES emulator focused on accuracy
http://bugzilla.rpmfusion.org/show_bug.cgi?id=15 --- Comment #33 from David Timms [EMAIL PROTECTED] 2008-11-29 13:43:18 --- Created an attachment (id=45) -- (http://bugzilla.rpmfusion.org/attachment.cgi?id=45) gdb bt Might be helpful ;-) -- Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug.
[Bug 15] Review Request: bsnes - SNES emulator focused on accuracy
http://bugzilla.rpmfusion.org/show_bug.cgi?id=15 --- Comment #34 from Julian Sikorski [EMAIL PROTECTED] 2008-11-29 14:01:24 --- Another guess: which audio driver are you using (Settings Config Drivers)? There are some serious issues with bsnes and pulseaudio, so far I have concluded that you can only make OpenAL work through PA, others will fail. I wasn't getting crashes, but CPU usage was going sky high. -- Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug.
[Bug 15] Review Request: bsnes - SNES emulator focused on accuracy
http://bugzilla.rpmfusion.org/show_bug.cgi?id=15 --- Comment #37 from Julian Sikorski [EMAIL PROTECTED] 2008-11-29 18:34:34 --- Confirmed on an i386 build. -- Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug.
[Bug 15] Review Request: bsnes - SNES emulator focused on accuracy
http://bugzilla.rpmfusion.org/show_bug.cgi?id=15 --- Comment #39 from Julian Sikorski [EMAIL PROTECTED] 2008-11-29 22:03:14 --- Erm, make that http://belegdol.republika.pl/rpmstuff/bsnes-0.037a-3.fc10.src.rpm -- Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug.
[Bug 15] Review Request: bsnes - SNES emulator focused on accuracy
http://bugzilla.rpmfusion.org/show_bug.cgi?id=15
--- Comment #40 from David Timms [EMAIL PROTECTED] 2008-11-30 02:11:41 ---
(In reply to comment #38)
http://belegdol.republika.pl/rpmstuff/bsnes-0.037a-3.fc10.src.rpm
Changes:
- Keep -fomit-frame-pointer
- $(strip) can stay
- Re-added system zlib patch
Build completes on i386, good work ;)
new rpmlint warning:
$ rpmlint /home/davidt/rpmbuild/SRPMS/bsnes-0.037a-3.fc9.src.rpm
/home/davidt/rpmbuild/RPMS/i386/bsnes-0.037a-3.fc9.i386.rpm
/home/davidt/rpmbuild/RPMS/i386/bsnes-debuginfo-0.037a-3.fc9.i386.rpm
bsnes.i386: W: spurious-executable-perm
/usr/share/doc/bsnes-0.037a/README.Fedora
3 packages and 0 specfiles checked; 0 errors, 1 warnings.
because of:
$ ls -l /usr/share/doc/bsnes-0.037a/
total 24
-rw-r--r-- 1 root root 3783 2008-11-30 09:22 license.txt
-rwxr-xr-x 1 root root 1324 2008-11-30 09:22 README.Fedora
-rw-r--r-- 1 root root 3409 2008-11-30 09:22 readme.txt
run time: loads and runs various roms, OK. [f9 i386 + f10 i386]
audio: [tested on f10 i386]
alsa - no progress in drawing visuals {cpu=100%}
openal - audio is OK
oss - audio is OK
libao - no progress in drawing visuals, need to kill emu.{cpu=100%}
none - runs OK.
I wonder what it would take to default the audio to openal or oss ?
If no can do, an item in README.fedora indicating using one of the above would
be useful.
With these latest changes, runs fine with selinux enforcing.
=
On my notebook PC, it is difficult to use the emulator because the cursor key
mapping seems to be problematic. Configuration Settings|Input: {defaults} what
it shows when I assign key, and press the cursor keys:
Up: {up} print_screen
Down: {down} rsuper
Left: {left} ralt
right: {right} not detected, had to use right shift.
I'm not sure what the cause of this is; however I had the same issue when
running a winxp guest in vmware server on the notebook once I upgraded to F10
preview and also with F10 release. There was a vmware keyboard mapping config
that sets the keymap back to operating normally within the vmware guest. The
names inserted by bsnes into the assignments is the same function that these
keys were triggering in vmware. Note that in the raw OS, the keymapping was
correct. It might be to do with the X input changes ?
--
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
[Bug 15] Review Request: bsnes - SNES emulator focused on accuracy
http://bugzilla.rpmfusion.org/show_bug.cgi?id=15 --- Comment #30 from David Timms [EMAIL PROTECTED] 2008-11-29 07:05:39 --- Created an attachment (id=43) -- (http://bugzilla.rpmfusion.org/attachment.cgi?id=43) gdb trace re: -2 src: debuginfo seems to be OK now. rpmlint is quiet. however, both direct and in gdb the emulator crashes moments after trying to load a rom: Could not find the frame base for IA__g_spawn_command_line_sync. Cannot access memory at address 0xa0080afb Could not find the frame base for IA__g_spawn_command_line_sync. Cannot access memory at address 0xa0080afb = or in gdb, see attachment. My machine: amd athlon xp 2600+, fedora 9+rpmfusion up2date this morning. I think apps shouldn't segfault, and should do essentially what they are described to do, so we probably need to get this crash sorted first. -- Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug.
[Bug 15] Review Request: bsnes - SNES emulator focused on accuracy
http://bugzilla.rpmfusion.org/show_bug.cgi?id=15 David Timms [EMAIL PROTECTED] changed: What|Removed |Added CC||[EMAIL PROTECTED] AssignedTo|rpmfusion-package- |[EMAIL PROTECTED] |[EMAIL PROTECTED]| --- Comment #24 from David Timms [EMAIL PROTECTED] 2008-11-27 13:36:48 --- (In reply to comment #22) http://belegdol.republika.pl/rpmstuff/bsnes-0.037a-1.fc9.src.rpm OK, yum-builddep on the src, and rpmbuild -ba completes now. $ rpmlint bsnes-0.037a-1.fc9.src.rpm bsnes-0.037a-1.fc9.i386.rpm bsnes-debuginfo-0.037a-1.fc9.i386.rpm bsnes-debuginfo.i386: E: empty-debuginfo-package 3 packages and 0 specfiles checked; 1 errors, 0 warnings. This seems to be confirmed by: $ ls -l bs* -rw-r--r-- 1 davidt davidt 402678 2008-11-23 10:59 bsnes-0.036-1.fc9.i386.rpm -rw-r--r-- 1 davidt davidt 409098 2008-11-27 23:23 bsnes-0.037a-1.fc9.i386.rpm -rw-r--r-- 1 davidt davidt 3824 2008-11-23 10:59 bsnes-debuginfo-0.036-1.fc9.i386.rpm -rw-r--r-- 1 davidt davidt 4085 2008-11-27 23:23 bsnes-debuginfo-0.037a-1.fc9.i386.rpm I hadn't noticed earlier; see the 036 had the same characteristic small dbg. # rpm -Uvh bsnes-debuginfo... $ gdb bsnes GNU gdb Fedora (6.8-23.fc9) Copyright (C) 2008 Free Software Foundation, Inc. License GPLv3+: GNU GPL version 3 or later http://gnu.org/licenses/gpl.html This is free software: you are free to change and redistribute it. There is NO WARRANTY, to the extent permitted by law. Type show copying and show warranty for details. This GDB was configured as i386-redhat-linux-gnu... (no debugging symbols found) There is a fedoraproject page on trying to track that down, does the same occur for your dbg rpms ? -- Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug.
[Bug 15] Review Request: bsnes - SNES emulator focused on accuracy
http://bugzilla.rpmfusion.org/show_bug.cgi?id=15 --- Comment #27 from David Timms [EMAIL PROTECTED] 2008-11-27 14:09:15 --- (In reply to comment #25) Which page? Seems my build also gives a small debuginfo package. https://fedoraproject.org/wiki/Packaging/Debuginfo (In reply to comment #26) This is present in the makefile. Any ideas what to do with that line? build: $(objects) $(strip $(cpp) $(call mkbin,../bsnes) $(objects) $(link)) maybe try: build: $(objects) $(cpp) $(call mkbin,../bsnes) $(objects) $(link) but I haven't come across this style before ;-) -- Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug.
[Bug 15] Review Request: bsnes - SNES emulator focused on accuracy
http://bugzilla.rpmfusion.org/show_bug.cgi?id=15 --- Comment #28 from Julian Sikorski [EMAIL PROTECTED] 2008-11-27 14:34:48 --- I figured it out, upstream permission pending. -- Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug.
[Bug 15] Review Request: bsnes - SNES emulator focused on accuracy
http://bugzilla.rpmfusion.org/show_bug.cgi?id=15 --- Comment #23 from David Timms [EMAIL PROTECTED] 2008-11-27 12:59:29 --- Created an attachment (id=36) -- (http://bugzilla.rpmfusion.org/attachment.cgi?id=36) diffs between snes_ntsc original and bsnes code. (In reply to comment #21) Julian: I'm going to take a look at using the external snes_ntsc library. OK. After being stumped at the shear number of differences between the library and the included copy, I realized that the files must have been saved on windows etc gaining CR. So the actual diffs are minimal: - change the bpp from 16 to 32 - set the output type to BRG15 - modify the actual video processing algorithm In light of this and the fact that the library is actually very small, I can't see much to be gained by making mods to use the system library, unless we were able to find out whether other snes emulators would also benefit from the above changes. -- Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug.
[Bug 15] Review Request: bsnes - SNES emulator focused on accuracy
http://bugzilla.rpmfusion.org/show_bug.cgi?id=15 Thorsten Leemhuis [EMAIL PROTECTED] changed: What|Removed |Added CC||[EMAIL PROTECTED], ||[EMAIL PROTECTED], ||rpmfusion-package- ||[EMAIL PROTECTED], ||[EMAIL PROTECTED], ||[EMAIL PROTECTED], ||[EMAIL PROTECTED], ||[EMAIL PROTECTED], ||[EMAIL PROTECTED], ||[EMAIL PROTECTED] ||, [EMAIL PROTECTED] CC||[EMAIL PROTECTED] ||internet.fr, ||[EMAIL PROTECTED], ||[EMAIL PROTECTED], ||[EMAIL PROTECTED], ||[EMAIL PROTECTED], cr- ||[EMAIL PROTECTED], ||[EMAIL PROTECTED], ||[EMAIL PROTECTED], ||[EMAIL PROTECTED], ||[EMAIL PROTECTED] ||rg, [EMAIL PROTECTED] CC||[EMAIL PROTECTED], ||[EMAIL PROTECTED] ||, [EMAIL PROTECTED], ||[EMAIL PROTECTED], ||[EMAIL PROTECTED], ||[EMAIL PROTECTED] -- Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug.
[Bug 15] Review Request: bsnes - SNES emulator focused on accuracy
http://bugzilla.rpmfusion.org/show_bug.cgi?id=15 --- Comment #29 from Julian Sikorski [EMAIL PROTECTED] 2008-11-27 15:22:46 --- New release: Spec URL: http://belegdol.republika.pl/rpmstuff/bsnes.spec SRPM URL: http://belegdol.republika.pl/rpmstuff/bsnes-0.037a-2.fc10.src.rpm Changes: - Patched the Makefile not to strip the binaries -- Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug.
[Bug 15] Review Request: bsnes - SNES emulator focused on accuracy
http://bugzilla.rpmfusion.org/show_bug.cgi?id=15
--- Comment #22 from Julian Sikorski [EMAIL PROTECTED] 2008-11-23 16:37:48
---
New release:
Spec URL: http://belegdol.republika.pl/rpmstuff/bsnes.spec
SRPM URL:
http://belegdol.republika.pl/rpmstuff/bsnes-0.037a-1.fc9.src.rpm
Changes:
- Updated to 0.037a
- Dropped system zlib patch since bsnes uses zlib modified to support non-ansi
filenames
- Added libXtst-devel to BuildRequires
- s/%%{ix86}/i386 to work around plague problem
I have removed the zlib patch for now, since the internal zlib that bsnes uses
was patched to support non-ansi filenames. I'm not sure if this is necessary
for Linux, but I'd rather be on the safe side. Have asked byuu for explanation.
--
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
[Bug 15] Review Request: bsnes - SNES emulator focused on accuracy
http://bugzilla.rpmfusion.org/show_bug.cgi?id=15 --- Comment #21 from David Timms [EMAIL PROTECTED] 2008-11-23 01:10:11 --- Created an attachment (id=34) -- (http://bugzilla.rpmfusion.org/attachment.cgi?id=34) build failure f9 i386 with bsnes-0.036-1.fc9.src.rpm Julian: I'm going to take a look at using the external snes_ntsc library. Meanwhile I get a build failure; this seems to be a missing BR: libXtst-devel Also, I notice byuu released a bsnes v0.037 source (Linux, Windows), that was followed up with a patch to fix the linux source: bsnes v0.037a source (Linux, Windows). -- Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug.
[Bug 15] Review Request: bsnes - SNES emulator focused on accuracy
http://bugzilla.rpmfusion.org/show_bug.cgi?id=15 --- Comment #19 from Julian Sikorski [EMAIL PROTECTED] 2008-06-03 14:13:20 --- New release: Spec URL: http://www.belegdol.republika.pl/rpmstuff/bsnes.spec SRPM URL: http://www.belegdol.republika.pl/rpmstuff/bsnes-0.032a-1.fc9.src.rpm Changes: - Updated to 0.032a -- Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug.
[Bug 15] Review Request: bsnes - SNES emulator focused on accuracy
http://bugzilla.rpmfusion.org/show_bug.cgi?id=15 --- Comment #15 from Julian Sikorski [EMAIL PROTECTED] 2008-02-15 11:39:38 --- New release: Spec URL: http://www.belegdol.republika.pl/rpmstuff/bsnes.spec SRPM URL: http://www.belegdol.republika.pl/rpmstuff/bsnes-0.028.01-2.fc8.src.rpm Changes: - Patched to fix CPU usage when idle - Patched to use system zlib - Dropped hicolor-icon-theme from Requires Since byuu refused to merge the patch, I decided to simplify it as much as possible. I got his approval to have it in the package, though. -- Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug.
[Bug 15] Review Request: bsnes - SNES emulator focused on accuracy
http://bugzilla.rpmfusion.org/show_bug.cgi?id=15 --- Comment #14 from David Juran [EMAIL PROTECTED] 2008-02-14 19:04:53 --- D'Oh, forgot to mention that you instead of doing make enable_gzip=true you should set system_gzip=true -- Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug.
[Bug 15] Review Request: bsnes - SNES emulator focused on accuracy
http://bugzilla.rpmfusion.org/show_bug.cgi?id=15 --- Comment #9 from Julian Sikorski [EMAIL PROTECTED] 2007-11-30 20:05:42 --- I know it should be avoided. Keep in mind, though, that when I asked byuu for use of system zlib, he responded that it is required for Windows port. Also, due to license restrictions, every single patch has to be approved by byuu. He's been very cooperative so far, so I believe that if someone writes the proper patches, byuu will be happy to approve them. -- Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug.
[Bug 15] Review Request: bsnes - SNES emulator focused on accuracy
http://bugzilla.rpmfusion.org/show_bug.cgi?id=15 Matthias Saou [EMAIL PROTECTED] changed: What|Removed |Added AssignedTo|[EMAIL PROTECTED] |rpmfusion-package- ||[EMAIL PROTECTED] -- Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug.
