[Bug 269] Review Request: snowballz - a fun RTS game featuring snowball fights with penguins
http://bugzilla.rpmfusion.org/show_bug.cgi?id=269 --- Comment #20 from David Timms dti...@iinet.net.au 2009-02-09 21:46:58 --- (In reply to comment #19) SPEC: http://oget.fedorapeople.org/review/snowballz.spec SRPM: http://oget.fedorapeople.org/review/snowballz-1.0-0.5.beta1.20081222hg.fc10.src.rpm Since that is 404, comments refer to: http://oget.fedorapeople.org/review/snowballz-1.0-0.5.beta1.20090110hg.fc10.src.rpm I added some info about call for developers in the description field of the SPEC file. Currently we have Beta1 in the Name key of the desktop file that will shine on the window title when one launches the game. Also the RPM file produced is: snowballz-1.0-0.5.beta1.20090110hg.fc10.noarch I think these give enough hint to the user that this application is not at a final state. Do you think we should add more information? No, that should be obvious enough if someone is using PK install. [OK] runs as advertised: I see that pyglet is now in updates, and a newer pyglet is in updates-testing. With the updates one, snowballz won't start, as I saw a few comments ago (with GL -devel packages installed). With the newer pyglet snowballz runs OK. Again, no crashes in my brief testing. [OK] matches upstream source: since the source archive date changed since my earlier checkout, the archive was re-extracted, and diff -ur'd: diff -ur snowballz/ snowballz-1.0-0.5.beta1.20090110hg.fc10.src/snowballz\ \(2\)/ Only in snowballz/data: TSCu_Comic.ttf - as Fedora font requirements require fonts to be in external packages, the font was removed. = This package, snowballz-1.0-0.5.beta1.20090110hg.fc10.src.rpm is APPROVED by dtimms. -- Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug.
[Bug 269] Review Request: snowballz - a fun RTS game featuring snowball fights with penguins
http://bugzilla.rpmfusion.org/show_bug.cgi?id=269 --- Comment #19 from Orcan Ogetbil oget.fed...@gmail.com 2009-02-04 20:11:14 --- Thanks. I updated the files: SPEC: http://oget.fedorapeople.org/review/snowballz.spec SRPM: http://oget.fedorapeople.org/review/snowballz-1.0-0.5.beta1.20081222hg.fc10.src.rpm Changelog: -Updated description (In reply to comment #18) The upstream site does mention the call for developers to help with certain tasks. I think it would be good to have at least an F1 help, or maybe an extended package description that provides this info. Is the packaging useful for devels wanting to work on the upstream project ? - the binary rpm works in it's current state, so is useful to make it easy for people to decide whether they might be interested to work on the project. - the .src.rpm could be described as an easy way for developers to get started on snowballz, without the extra learning curve of hg. - we need to make sure that it is clear in the packaging that the above is the case; I we don't want to disappoint potential users, rather pull at their how can I help strings ... I added some info about call for developers in the description field of the SPEC file. Currently we have Beta1 in the Name key of the desktop file that will shine on the window title when one launches the game. Also the RPM file produced is: snowballz-1.0-0.5.beta1.20090110hg.fc10.noarch I think these give enough hint to the user that this application is not at a final state. Do you think we should add more information? I also get segfaults sometimes with this 1.0 version. Did you experience segfaults? No segfaults seen by me with my limited testing. Perhaps their is a special part of the game where the issue occurs, or with just one of the maps ? It happens to me in the beginning. About 50% of the time the game doesn't launch, stopping with a segfault, giving no information about the problem. I don't know how I could debug this. It might be yet another pyglet issue (I also tried the latest svn snapshot of pyglet, and that didn't prevent the segfaults). Maybe something is messed up in my computer. -- Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug.
[Bug 269] Review Request: snowballz - a fun RTS game featuring snowball fights with penguins
http://bugzilla.rpmfusion.org/show_bug.cgi?id=269 --- Comment #15 from David Timms dti...@iinet.net.au 2009-02-03 09:53:11 --- Created an attachment (id=90) -- (http://bugzilla.rpmfusion.org/attachment.cgi?id=90) diff on the original to attached lib.py (In reply to comment #13) I am attaching a lib.py file. Can you replace this one with the lib.py that resides in /usr/lib/python2.5/site-packages/pyglet/ and try to run snowballz with and without mesa-libGL*-devel installed? I put the attached one in place of the one already in the pyglet directory. Once I have done this, snowballz runs with both with or without: mesa-libGL-devel mesa-libGLU-devel Hope that helps, or the diff from original might be useful. -- Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug.
[Bug 269] Review Request: snowballz - a fun RTS game featuring snowball fights with penguins
http://bugzilla.rpmfusion.org/show_bug.cgi?id=269 --- Comment #16 from Orcan Ogetbil oget.fed...@gmail.com 2009-02-03 18:24:39 --- Thank you. I tagged and built pyglet with a new patch. What do you think of the game? It looks promising to me, but it is certainly not very playable. Also, I don't see any updates on the project (not even in their hg) in the last 5 months. It looks like it might be abandoned. I'm not sure if I should revert back to the 0.9.5 version. That one looks more playable. I also get segfaults sometimes with this 1.0 version. Did you experience segfaults? -- Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug.
[Bug 269] Review Request: snowballz - a fun RTS game featuring snowball fights with penguins
http://bugzilla.rpmfusion.org/show_bug.cgi?id=269 --- Comment #17 from Orcan Ogetbil oget.fed...@gmail.com 2009-02-03 20:37:19 --- nope, snowballz-0.9.5.1 is incompatible with the current python-rabbyt we have in Fedora. We'll have to stick with this 1.0 version. -- Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug.
[Bug 269] Review Request: snowballz - a fun RTS game featuring snowball fights with penguins
http://bugzilla.rpmfusion.org/show_bug.cgi?id=269 --- Comment #18 from David Timms dti...@iinet.net.au 2009-02-03 22:28:10 --- (In reply to comment #16) What do you think of the game? It looks promising to me Agreed, it is obvious that a lot of work was required for the developers to get this far. However, with some insight from a person I knew who get into mod development for a commercial game, it takes serious amount of hours to build stuff like this from scratch; that person eventually decided to work on the game full time, so that she could make the progress she wanted. , but it is certainly not very playable. I would agree, I definitely never really made a dent in the opposing teams army. In the manual, various operating keys are mentioned, but I wasn't able to get any of them to work (eg page up/down, ,. tab etc). I am not normally into these type of games in any case. Also, I don't see any updates on the project (not even in their hg) in the last 5 months. It looks like it might be abandoned. I'm not sure if I should revert back to the 0.9.5 version. The upstream site does mention the call for developers to help with certain tasks. I think it would be good to have at least an F1 help, or maybe an extended package description that provides this info. Is the packaging useful for devels wanting to work on the upstream project ? - the binary rpm works in it's current state, so is useful to make it easy for people to decide whether they might be interested to work on the project. - the .src.rpm could be described as an easy way for developers to get started on snowballz, without the extra learning curve of hg. - we need to make sure that it is clear in the packaging that the above is the case; I we don't want to disappoint potential users, rather pull at their how can I help strings ... I also get segfaults sometimes with this 1.0 version. Did you experience segfaults? No segfaults seen by me with my limited testing. Perhaps their is a special part of the game where the issue occurs, or with just one of the maps ? Possible the package version should include alpha or developer demo, so that it is clear that it is really a call to arms. Regarding the package itself, previous issues regarding: - names in the desktop file - wrapper script - license clarification - install path - use of eggs have been taken care of. As far as I can see, it is just waiting on the updated pyglet to become available in the repo, and perhaps more explicitly mentioning the development state of the game, perhaps in the .desktop comment, and in the package summary. I'm guessing the other semi-reviewers were happy with the rest of the packaging, since I am ready to approve it ;-) -- Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug.
[Bug 269] Review Request: snowballz - a fun RTS game featuring snowball fights with penguins
http://bugzilla.rpmfusion.org/show_bug.cgi?id=269
--- Comment #10 from David Timms dti...@iinet.net.au 2009-02-02 22:08:35 ---
(In reply to comment #9)
OK I did it that way:
SPEC: http://oget.fedorapeople.org/review/snowballz.spec
SRPM:
http://oget.fedorapeople.org/review/snowballz-1.0-0.4.beta1.20090110hg.fc10.src.rpm
Hi, I hadn't noticed that pyglet and python-rabbyt are available in the testing
repo, with those installed:
[OK] rpmbuild succeeds
[OK] rpmlint: 4x warnings about zero length files
- you have already explained that they seem to be required for normal
operation
[! ] package works as described / expected
- when run from the desktop icon, nothing visible is shown.
- when run from a user account:
=
snowballz
Traceback (most recent call last):
File snowballz.py, line 2, in module
from lib.scene_handler import SceneHandler
File /usr/share/snowballz/lib/scene_handler.py, line 4, in module
from pyglet.window import Window
File /usr/lib/python2.5/site-packages/pyglet/window/__init__.py, line 1682,
in module
gl._create_shadow_window()
File /usr/lib/python2.5/site-packages/pyglet/gl/__init__.py, line 491, in
_create_shadow_window
_shadow_window = Window(width=1, height=1, visible=False)
File /usr/lib/python2.5/site-packages/pyglet/window/xlib/__init__.py, line
474, in __init__
super(XlibWindow, self).__init__(*args, **kwargs)
File /usr/lib/python2.5/site-packages/pyglet/window/__init__.py, line 641,
in __init__
raise NoSuchConfigException('No standard config is available.')
pyglet.window.NoSuchConfigException: No standard config is available.
=
Is that what you have found ?
Is it that the user is expected to build some configs for pyglet ?
Or this snapshot has issues ?
--
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
[Bug 269] Review Request: snowballz - a fun RTS game featuring snowball fights with penguins
http://bugzilla.rpmfusion.org/show_bug.cgi?id=269
--- Comment #11 from Orcan Ogetbil oget.fed...@gmail.com 2009-02-02 22:21:51
---
(In reply to comment #10)
raise NoSuchConfigException('No standard config is available.')
pyglet.window.NoSuchConfigException: No standard config is available.
=
Is that what you have found ?
Is it that the user is expected to build some configs for pyglet ?
Or this snapshot has issues ?
Oh shoot... It works on my system. It looks like the patch I made for pyglet
isn't good enough.
Just to make sure, can you post your pyglet version, type of your graphics card
and its driver version?
Also, can you try removing mesa-libGLU-devel and mesa-libGL-devel from your
system and try running snowballz again. Let's make sure that we are talking
about the same problem.
--
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
[Bug 269] Review Request: snowballz - a fun RTS game featuring snowball fights with penguins
http://bugzilla.rpmfusion.org/show_bug.cgi?id=269 --- Comment #13 from Orcan Ogetbil oget.fed...@gmail.com 2009-02-03 02:09:44 --- David, I need a favor. Since the snowballz works with the current version of pyglet (with mesa-libGL*-devel installed) on my computer I can't really diagnose the problem. I am attaching a lib.py file. Can you replace this one with the lib.py that resides in /usr/lib/python2.5/site-packages/pyglet/ and try to run snowballz with and without mesa-libGL*-devel installed? -- Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug.
[Bug 269] Review Request: snowballz - a fun RTS game featuring snowball fights with penguins
http://bugzilla.rpmfusion.org/show_bug.cgi?id=269 Bug 269 depends on bug 208, which changed state. Bug 208 Summary: pyglet - A cross-platform windowing and multimedia library for Python http://bugzilla.rpmfusion.org/show_bug.cgi?id=208 What|Old Value |New Value Status|ASSIGNED|RESOLVED Resolution||FIXED -- Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug.
[Bug 269] Review Request: snowballz - a fun RTS game featuring snowball fights with penguins
http://bugzilla.rpmfusion.org/show_bug.cgi?id=269 Conrad Meyer kon...@tylerc.org changed: What|Removed |Added CC||kon...@tylerc.org --- Comment #8 from Conrad Meyer kon...@tylerc.org 2009-01-11 23:22:44 --- You could hardcode %_datadir in the .desktop file, then sed the line in your spec. -- Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug.
[Bug 269] Review Request: snowballz - a fun RTS game featuring snowball fights with penguins
http://bugzilla.rpmfusion.org/show_bug.cgi?id=269
--- Comment #3 from Orcan Ogetbil oget.fed...@gmail.com 2009-01-10 16:03:26
---
(In reply to comment #1)
[...]
Are these zero length files required for snowballz to work ?
Afaict yes. Removing them makes the game misbehave. I wonder why this didn't
show up when I ran rpmlint the first time.
- is it normal to stick games in ../games/%{name} ? (Well I see fortune and
torcs are, and frozen-bubble isn't so I guess I answered that.)
I think it's OK. This is the first game I ever packaged though. I'm open to
suggestions.
[! ] Summary:A fun RTS game featuring snowball fights with penguins
- It might be worth expanding RTS into what it means (for those that don't
know),
[!] desktop files has been created. It uses a beta trailer in the title,
which is useful to inform players that there could be problems in the game.
The groups meet freedesktop standard, as required.
- GenericName=RTS Game
Maybe: Graphical Real Time Strategy Game
done
- Comment=Command your army of penguins
Maybe: A game where you command an army of penguins
Isn't it obvious that it is a game? Also, we already used the word game in
the Generic Name section. What's your opinion?
[! ] license GPLv2+ and MIT: the only licensing I can see is in:
snowui/__init__.py
but it isn't a well known license. Why did you select these as the license ?
It is MIT, Modern Style with sublicense (see
https://fedoraproject.org/wiki/Licensing/MIT)
I should remove the GPLv2+ since I removed that font (which is GPLv2+).
Done.
[??] in setup, ttf fonts are removed. Would it be better to remove them
(TSCu_Comic.ttf) in the snapshot creation process, so that they don't make it
into the .src.rpm ?
This might make it more difficult once there are release source archives.
Is the reason to remove it because it's license is unclear ? A comment to
describe why would help readers.
Do you need to (somehow) replace the font with font already in Fedora ?
Inclusion of fonts in non-font packages is forbidden in Fedora now. I worked on
packaging this font separately. After some consultations to the fonts guys in
Fedora and Debian, we figured that this font is incomplete and has a wrong
table, and hence we shouldn't package it in Fedora as is. I worked on it
further. I corrected the table and added more characters. Here's the project
I've been working on:
http://serafettin.sourceforge.net/
I will package this for Fedora at some point.
The font is not used in the program. I believe it is because the game is in the
production stage. It may be used later when the stable version comes up. Then
we can replace it with some other font from Fedora.
I'm removing the font during the snapshot creation process now.
[??] no scriptlets
why would you build the wrapper script during setup, rather than
separately
storing the script in cvs ?
Would it be better to be able to keep the creation time from cvs ?
I guess you're right. Changed.
[! ] waiting on Requires: pyglet to be able to install built package and test
functionality.
Needs work, and or brief spec file comments for some choices youhave made, in
my opinion, and waiting on other reviews.
Let me know about the Comment in the .desktop file. Here are the latest files:
SPEC: http://oget.fedorapeople.org/review/snowballz.spec
SRPM:
http://oget.fedorapeople.org/review/snowballz-1.0-0.2.beta1.20090110hg.fc10.src.rpm
Thanks again, for the review.
--
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
[Bug 269] Review Request: snowballz - a fun RTS game featuring snowball fights with penguins
http://bugzilla.rpmfusion.org/show_bug.cgi?id=269
--- Comment #4 from Andrea Musuruane musur...@gmail.com 2009-01-10 18:28:58
---
(In reply to comment #3)
- is it normal to stick games in ../games/%{name} ? (Well I see fortune
and
torcs are, and frozen-bubble isn't so I guess I answered that.)
I think it's OK. This is the first game I ever packaged though. I'm open to
suggestions.
It is not OK. You must follow the Fedora Games Packaging guidelines:
https://fedoraproject.org/wiki/SIGs/Games/Packaging
Data files (maps, pixmaps, sounds) go in %{_datadir}/%{name} , not
%{_datadir}/games/%{name} . Binaries go in %{_bindir} and not /usr/games.
According to the FHS, the use of /usr/share/games and /usr/games is optional,
and we recommend not using either for consistency, so that games are packaged
like all other applications.
--
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
[Bug 269] Review Request: snowballz - a fun RTS game featuring snowball fights with penguins
http://bugzilla.rpmfusion.org/show_bug.cgi?id=269 --- Comment #5 from Kevin Kofler kevin.kof...@chello.at 2009-01-10 18:51:53 --- /usr/games is obsolete in Fedora, I think the games still using it should be fixed. Isn't it obvious that it is a game? Also, we already used the word game in the Generic Name section. In practice, GNOME only shows Comment, KDE only shows GenericName, so information should be repeated between those, as users will only see one or the other. GenericName should be just a short noun phrase (Real-time Strategy Game is about the longest which makes sense), Comment can be longer because GNOME shows it as a tooltip. And yes, I think KDE should be ultimately fixed to display Comment as a tooltip and GNOME to display the GenericName. I'll see what I can do on the KDE side. -- Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug.
[Bug 269] Review Request: snowballz - a fun RTS game featuring snowball fights with penguins
http://bugzilla.rpmfusion.org/show_bug.cgi?id=269
--- Comment #6 from Andrea Musuruane musur...@gmail.com 2009-01-10 19:02:17
---
I have some questions.
%{__python} setup.py install --skip-build --root %{buildroot} --install-lib
%{_datadir}/games/%{name}
Shouldn't install-lib be %{python_sitelib} as defined in the Python Packaging
Guidelines?
http://fedoraproject.org/wiki/Packaging/Python
# Install the files omitted by the setuptools script
cp -a data *.py %{buildroot}/%{_datadir}/games/%{name}
Why *.py files are installed under %{_datadir}? Isn't this be forbidden?
--
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
[Bug 269] Review Request: snowballz - a fun RTS game featuring snowball fights with penguins
http://bugzilla.rpmfusion.org/show_bug.cgi?id=269 --- Comment #2 from Orcan Ogetbil oget.fed...@gmail.com 2009-01-06 23:22:46 --- Thanks for the review. I will go over the issues asap. -- Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug.
[Bug 269] Review Request: snowballz - a fun RTS game featuring snowball fights with penguins
http://bugzilla.rpmfusion.org/show_bug.cgi?id=269
David Timms dti...@iinet.net.au changed:
What|Removed |Added
CC||dti...@iinet.net.au
Blocks|2 |3
AssignedTo|rpmfusion-package- |dti...@iinet.net.au
|rev...@rpmfusion.org|
--- Comment #1 from David Timms dti...@iinet.net.au 2009-01-05 13:17:16 ---
Review for snowballz:
=
OK no problemo
NA not applicable
?? can't say/don't understand.
! needs work.
=
[OK] rpmlint .src.rpm :
1 packages and 0 specfiles checked; 0 errors, 0 warnings.
[! ] rpmlint
/home/davidt/rpmbuild/RPMS/noarch/snowballz-1.0-0.1.beta1.20081222hg.fc10.noarch.rpm
:
snowballz.noarch: E: zero-length
/usr/share/games/snowballz/data/maps/crystalcrises/dynamic_objects.txt
snowballz.noarch: E: zero-length
/usr/share/games/snowballz/data/maps/world1/dynamic_objects.txt
snowballz.noarch: E: zero-length
/usr/share/games/snowballz/data/maps/td1/dynamic_objects.txt
snowballz.noarch: E: zero-length
/usr/share/games/snowballz/data/maps/crystalcrises/script_areas.txt
1 packages and 0 specfiles checked; 4 errors, 0 warnings.
Are these zero length files required for snowballz to work ?
[OK] included source is pulled from hg so direct md5sum compare isn't possible.
Since package includes a snowballz-snapshot script, this was used to retrieve
1.0beta1 from the mercurial repo, which created a source archive with today's
date. While these two archives differ slightly in size, I think that is to be
expected because the file dates within the archive are stored - and this
probably leads to different compression levels.
The freshly retrieved archive was extracted, and the included source rpm
archive also extracted. diff -ur between the two extracted trees shows no
differences.
[OK] package name is ok, it's the only user in a web search.
[OK] spec named %name.spec as required
[OK] source tarball contains no prebuilt binaries/libraries.
[OK] files placed into FHS locations - meets fedora python standard
[OK] changelog in standard format
[OK] correctly omits Packager, vendor, copyright, prereq
, includes license tag.
[OK] summary is 80 chars, no ending period
[OK] source0 is a direct archive made with the snapshot script that retrieves
it from mercurial repo.
[OK] buildroot set at second most preferred location:
[OK] %install correctly erases buildroot before build
[OK] mock build succeeds.
[OK] rpmdiff between default build and mock build shows only time
{T} differences for folders and the pre-compiled .py[co] files
[OK] description is column limited to 80 chars.
[OK] man 6 is included.
[OK] charset is ascii
[OK] debuginfo not expected in noarch application.
[OK] no static libraries, rpath, self copies of already packaged libaries
etc, since pure python project.
[OK] no config, initscripts,
[OK] variable style is used consistently
[NA] not multilingual
[OK] timestamps are kept
[NA] make is python based, so smp_flags not required.
[OK] build requires python.
[OK] no conditional dependencies
[OK] is program code and game data (graphics, sounds)
[NA] no provides to consider
[OK] dirs/files owned by the package
[OK] not a web app, shouldn't conflict with other packages.
[NA] python sitelib applies only to python libraries
[OK] eggs are built from source into binary rpm.
- dont know much about this, but the folder is created with various info
files inside it, so looks OK.
[OK] no files in %{_bindir} and %{_sbindir}.
[OK] %install setup.py install --skip-build. as guided for python packages.
[OK] %files:
- is it normal to stick games in ../games/%{name} ? (Well I see fortune and
torcs are, and frozen-bubble isn't so I guess I answered that.)
- the icon, manual, and desktop entry are specifically noted, while the
../games/snowballz/ folder is defined, so this looks good to me.
[NA] there are no unit tests, that I can see.
--- issues:
[! ] Summary:A fun RTS game featuring snowball fights with penguins
- It might be worth expanding RTS into what it means (for those that don't
know),
[!] desktop files has been created. It uses a beta trailer in the title,
which is useful to inform players that there could be problems in the game.
The groups meet freedesktop standard, as required.
- GenericName=RTS Game
Maybe: Graphical Real Time Strategy Game
- Comment=Command your army of penguins
Maybe: A game where you command an army of penguins
[! ] license GPLv2+ and MIT: the only licensing I can see is in:
snowui/__init__.py
but it isn't a well known license. Why did you select these as the license ?
[??] in setup, ttf fonts are removed. Would it be better to remove them
(TSCu_Comic.ttf) in the snapshot creation process, so that they don't make it
into the .src.rpm ?
This might make it more difficult once there are release source
