[Bug 300] Review request: pgadmin3 - Graphical client for PostgreSQL
http://bugzilla.rpmfusion.org/show_bug.cgi?id=300 Robert Scheck changed: What|Removed |Added Status|ASSIGNED|RESOLVED Resolution||FIXED --- Comment #19 from Robert Scheck 2009-01-08 21:52:30 --- 2355 (pgadmin3): Build on target fedora-development-rpmfusion_nonfree succeeded. 2356 (pgadmin3): Build on target fedora-10-rpmfusion_nonfree succeeded. 2357 (pgadmin3): Build on target fedora-9-rpmfusion_nonfree succeeded. Thank you all for making it a quick review. Packages have been pushed to testing, so closing now. -- Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug.
[Bug 300] Review request: pgadmin3 - Graphical client for PostgreSQL
http://bugzilla.rpmfusion.org/show_bug.cgi?id=300 Thorsten Leemhuis changed: What|Removed |Added Blocks|33 | --- Comment #18 from Thorsten Leemhuis 2009-01-07 07:11:24 --- (In reply to comment #17) > Package CVS request > == > Package Name: pgadmin3 > Short Description: Graphical client for PostgreSQL Done -- Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug.
[Bug 300] Review request: pgadmin3 - Graphical client for PostgreSQL
http://bugzilla.rpmfusion.org/show_bug.cgi?id=300 Robert Scheck changed: What|Removed |Added Blocks||33 --- Comment #17 from Robert Scheck 2009-01-06 23:33:13 --- If there should be further things, please bring them up. As usually the CVS request also needs time, I'm just starting it now: Package CVS request == Package Name: pgadmin3 Short Description: Graphical client for PostgreSQL Owners: robert Branches: F-9 F-10 InitialCC: -- License tag: nonfree I'm not sure how RPM Fusion handles InitialCC, but as owner I think, I shouldn't listed there as well, right? If I'm wrong, please auto- correct during CVS action - thank you. -- Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug.
[Bug 300] Review request: pgadmin3 - Graphical client for PostgreSQL
http://bugzilla.rpmfusion.org/show_bug.cgi?id=300 Manuel Wolfshant changed: What|Removed |Added Blocks|3 |4 -- Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug.
[Bug 300] Review request: pgadmin3 - Graphical client for PostgreSQL
http://bugzilla.rpmfusion.org/show_bug.cgi?id=300 --- Comment #16 from Manuel Wolfshant 2009-01-06 23:20:18 --- I would add the "Additional Category" "Database" but yes, the command from comment #15 would be fine from my point of view. Assuming Dan has nothing else to suggest I'd say that we can consider this package as APPROVED. -- Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug.
[Bug 300] Review request: pgadmin3 - Graphical client for PostgreSQL
http://bugzilla.rpmfusion.org/show_bug.cgi?id=300 --- Comment #15 from Robert Scheck 2009-01-06 23:04:46 --- So the following would be approvable for you? --- snipp --- desktop-file-install --dir $RPM_BUILD_ROOT%{_datadir}/applications \ %if 0%{?rhel} --vendor="" \ %endif --add-category Development \ pkg/%{name}.desktop --- snapp --- -- Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug.
[Bug 300] Review request: pgadmin3 - Graphical client for PostgreSQL
http://bugzilla.rpmfusion.org/show_bug.cgi?id=300 --- Comment #14 from Manuel Wolfshant 2009-01-06 22:51:13 --- Superb, rpmlint is clean now (modulo the ignorable license warning). However a couple of things related to the desktop file still need fixing: * the Categories tag should not contain X-Fedora any more * the Categories tag should not contain Application any more (see http://standards.freedesktop.org/menu-spec/latest/apa.html) And the --vendor Fedora is no longer needed. In order to maintain compatibility with EPEL, my current specs use: desktop-file-install \ %if 0%{?rhel} --vendor="" \ %endif -- Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug.
[Bug 300] Review request: pgadmin3 - Graphical client for PostgreSQL
http://bugzilla.rpmfusion.org/show_bug.cgi?id=300 --- Comment #13 from Robert Scheck 2009-01-05 22:35:13 --- The following updated package should address all issues mentioned above and more as well; rpmlint is silent for me when ignoring the license message. Spec URL: http://labs.linuxnetz.de/bugzilla/pgadmin3.spec SRPM URL: http://labs.linuxnetz.de/bugzilla/pgadmin3-1.8.4-5.src.rpm -- Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug.
[Bug 300] Review request: pgadmin3 - Graphical client for PostgreSQL
http://bugzilla.rpmfusion.org/show_bug.cgi?id=300 --- Comment #12 from Rex Dieter 2009-01-05 18:31:01 --- imo, yes, rpmfusions's definition of free is the same as fedora's, sans patents. -- Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug.
[Bug 300] Review request: pgadmin3 - Graphical client for PostgreSQL
http://bugzilla.rpmfusion.org/show_bug.cgi?id=300 --- Comment #11 from Robert Scheck 2009-01-05 18:16:01 --- In Fedora it is not because of Artistic 1.0. So that makes it "nonfree" for RPM Fusion? -- Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug.
[Bug 300] Review request: pgadmin3 - Graphical client for PostgreSQL
http://bugzilla.rpmfusion.org/show_bug.cgi?id=300 --- Comment #10 from Rex Dieter 2009-01-05 18:09:23 --- nonfree, isn't that why it's not in fedora? -- Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug.
[Bug 300] Review request: pgadmin3 - Graphical client for PostgreSQL
http://bugzilla.rpmfusion.org/show_bug.cgi?id=300 --- Comment #9 from Robert Scheck 2009-01-05 18:06:32 --- BTW, is pgadmin3 for RPM Fusion "free" or "nonfree"? -- Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug.
[Bug 300] Review request: pgadmin3 - Graphical client for PostgreSQL
http://bugzilla.rpmfusion.org/show_bug.cgi?id=300 --- Comment #8 from Dan Horák 2009-01-05 17:42:42 --- (In reply to comment #7) > (In reply to comment #6) > > Then there is some non-standard behaviour in pgadmin ... wxGTK apps are > > using > > %{_localedir}. I will try to check that. > > Okay, I've to correct my self, some fallback seems to work without patching > it. You add additional paths where to look for i18n, but the system one should always work. > But I still need /usr/share/pgadmin3/i18n/pgadmin3.lng there. > should be OK > Any suggestions to where put the *.sql file from /usr/share/pgadmin3? Or just > let > it there as it is? %{datadir}/%{name} is perfect location > > Can I remove the branding directory? Seems to be useless anyway. > IMHO yes -- Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug.
[Bug 300] Review request: pgadmin3 - Graphical client for PostgreSQL
http://bugzilla.rpmfusion.org/show_bug.cgi?id=300 --- Comment #7 from Robert Scheck 2009-01-05 16:35:09 --- (In reply to comment #6) > Then there is some non-standard behaviour in pgadmin ... wxGTK apps are using > %{_localedir}. I will try to check that. Okay, I've to correct my self, some fallback seems to work without patching it. But I still need /usr/share/pgadmin3/i18n/pgadmin3.lng there. Any suggestions to where put the *.sql file from /usr/share/pgadmin3? Or just let it there as it is? Can I remove the branding directory? Seems to be useless anyway. -- Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug.
[Bug 300] Review request: pgadmin3 - Graphical client for PostgreSQL
http://bugzilla.rpmfusion.org/show_bug.cgi?id=300 --- Comment #6 from Dan Horák 2009-01-05 16:32:51 --- (In reply to comment #5) > (In reply to comment #4) > > You should remove the wxstd.mo files, they are distributed in the main wxGTK > > package and then install pgadmin3.mo into %{_localedir} > > I don't think, that this is clever, because the files seem to be expected on a > special path. > Then there is some non-standard behaviour in pgadmin ... wxGTK apps are using %{_localedir}. I will try to check that. -- Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug.
[Bug 300] Review request: pgadmin3 - Graphical client for PostgreSQL
http://bugzilla.rpmfusion.org/show_bug.cgi?id=300 --- Comment #5 from Robert Scheck 2009-01-05 16:18:13 --- (In reply to comment #4) > You should remove the wxstd.mo files, they are distributed in the main wxGTK > package and then install pgadmin3.mo into %{_localedir} I don't think, that this is clever, because the files seem to be expected on a special path. -- Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug.
[Bug 300] Review request: pgadmin3 - Graphical client for PostgreSQL
http://bugzilla.rpmfusion.org/show_bug.cgi?id=300 Dan Horák changed: What|Removed |Added CC||d...@danny.cz --- Comment #4 from Dan Horák 2009-01-05 11:52:49 --- (In reply to comment #3) > Manuel, I've hunted down to the following now. But how to solve i18n issues? > The files can't be simply moved to %{_localedir}, because wxstd.mo overlaps. > And pgadmin3 then needs to be patched as well. Suggestions? You should remove the wxstd.mo files, they are distributed in the main wxGTK package and then install pgadmin3.mo into %{_localedir} -- Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug.
[Bug 300] Review request: pgadmin3 - Graphical client for PostgreSQL
http://bugzilla.rpmfusion.org/show_bug.cgi?id=300 --- Comment #3 from Robert Scheck 2009-01-05 11:39:43 --- Manuel, I've hunted down to the following now. But how to solve i18n issues? The files can't be simply moved to %{_localedir}, because wxstd.mo overlaps. And pgadmin3 then needs to be patched as well. Suggestions? pgadmin3.x86_64: W: file-not-in-%lang /usr/share/pgadmin3/i18n/af_ZA/pgadmin3.mo pgadmin3.x86_64: W: file-not-in-%lang /usr/share/pgadmin3/i18n/af_ZA/wxstd.mo pgadmin3.x86_64: W: file-not-in-%lang /usr/share/pgadmin3/i18n/bg_BG/pgadmin3.mo pgadmin3.x86_64: W: file-not-in-%lang /usr/share/pgadmin3/i18n/bg_BG/wxstd.mo pgadmin3.x86_64: W: file-not-in-%lang /usr/share/pgadmin3/i18n/ca_ES/pgadmin3.mo pgadmin3.x86_64: W: file-not-in-%lang /usr/share/pgadmin3/i18n/ca_ES/wxstd.mo pgadmin3.x86_64: W: file-not-in-%lang /usr/share/pgadmin3/i18n/de_DE/pgadmin3.mo pgadmin3.x86_64: W: file-not-in-%lang /usr/share/pgadmin3/i18n/de_DE/wxstd.mo pgadmin3.x86_64: W: file-not-in-%lang /usr/share/pgadmin3/i18n/es_ES/pgadmin3.mo pgadmin3.x86_64: W: file-not-in-%lang /usr/share/pgadmin3/i18n/es_ES/wxstd.mo pgadmin3.x86_64: W: file-not-in-%lang /usr/share/pgadmin3/i18n/fi_FI/pgadmin3.mo pgadmin3.x86_64: W: file-not-in-%lang /usr/share/pgadmin3/i18n/fi_FI/wxstd.mo pgadmin3.x86_64: W: file-not-in-%lang /usr/share/pgadmin3/i18n/fr_FR/pgadmin3.mo pgadmin3.x86_64: W: file-not-in-%lang /usr/share/pgadmin3/i18n/fr_FR/wxstd.mo pgadmin3.x86_64: W: file-not-in-%lang /usr/share/pgadmin3/i18n/gl_ES/pgadmin3.mo pgadmin3.x86_64: W: file-not-in-%lang /usr/share/pgadmin3/i18n/gl_ES/wxstd.mo pgadmin3.x86_64: W: file-not-in-%lang /usr/share/pgadmin3/i18n/it_IT/pgadmin3.mo pgadmin3.x86_64: W: file-not-in-%lang /usr/share/pgadmin3/i18n/it_IT/wxstd.mo pgadmin3.x86_64: W: file-not-in-%lang /usr/share/pgadmin3/i18n/ja_JP/pgadmin3.mo pgadmin3.x86_64: W: file-not-in-%lang /usr/share/pgadmin3/i18n/ja_JP/wxstd.mo pgadmin3.x86_64: W: file-not-in-%lang /usr/share/pgadmin3/i18n/ko_KR/pgadmin3.mo pgadmin3.x86_64: W: file-not-in-%lang /usr/share/pgadmin3/i18n/ko_KR/wxstd.mo pgadmin3.x86_64: W: file-not-in-%lang /usr/share/pgadmin3/i18n/nl_NL/pgadmin3.mo pgadmin3.x86_64: W: file-not-in-%lang /usr/share/pgadmin3/i18n/nl_NL/wxstd.mo pgadmin3.x86_64: W: file-not-in-%lang /usr/share/pgadmin3/i18n/pl_PL/pgadmin3.mo pgadmin3.x86_64: W: file-not-in-%lang /usr/share/pgadmin3/i18n/pl_PL/wxstd.mo pgadmin3.x86_64: W: file-not-in-%lang /usr/share/pgadmin3/i18n/pt_BR/pgadmin3.mo pgadmin3.x86_64: W: file-not-in-%lang /usr/share/pgadmin3/i18n/pt_BR/wxstd.mo pgadmin3.x86_64: W: file-not-in-%lang /usr/share/pgadmin3/i18n/pt_PT/pgadmin3.mo pgadmin3.x86_64: W: file-not-in-%lang /usr/share/pgadmin3/i18n/pt_PT/wxstd.mo pgadmin3.x86_64: W: file-not-in-%lang /usr/share/pgadmin3/i18n/ru_RU/pgadmin3.mo pgadmin3.x86_64: W: file-not-in-%lang /usr/share/pgadmin3/i18n/ru_RU/wxstd.mo pgadmin3.x86_64: W: file-not-in-%lang /usr/share/pgadmin3/i18n/sr_YU/pgadmin3.mo pgadmin3.x86_64: W: file-not-in-%lang /usr/share/pgadmin3/i18n/sr_YU/wxstd.mo pgadmin3.x86_64: W: file-not-in-%lang /usr/share/pgadmin3/i18n/wxstd.mo pgadmin3.x86_64: W: file-not-in-%lang /usr/share/pgadmin3/i18n/zh_CN/pgadmin3.mo pgadmin3.x86_64: W: file-not-in-%lang /usr/share/pgadmin3/i18n/zh_CN/wxstd.mo pgadmin3.x86_64: W: file-not-in-%lang /usr/share/pgadmin3/i18n/zh_TW/pgadmin3.mo pgadmin3.x86_64: W: file-not-in-%lang /usr/share/pgadmin3/i18n/zh_TW/wxstd.mo -- Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug.
[Bug 300] Review request: pgadmin3 - Graphical client for PostgreSQL
http://bugzilla.rpmfusion.org/show_bug.cgi?id=300 Manuel Wolfshant changed: What|Removed |Added Status|NEW |ASSIGNED --- Comment #2 from Manuel Wolfshant 2009-01-05 01:59:14 --- The package built fine in koji (for a strange reason I cannot build locally either for F10 or for rawhide) but rpmlint is not happy (I have ignored the warning about the license): pgadmin3-docs.x86_64: W: wrong-file-end-of-line-encoding /usr/share/doc/pgadmin3-docs-1.8.4/Docs.vcproj pgadmin3-docs.x86_64: W: wrong-file-end-of-line-encoding /usr/share/doc/pgadmin3-docs-1.8.4/builddocs.bat pgadmin3-docs.x86_64: W: wrong-file-end-of-line-encoding /usr/share/doc/pgadmin3-docs-1.8.4/fr_FR/tips.txt pgadmin3-docs.x86_64: W: wrong-file-end-of-line-encoding /usr/share/doc/pgadmin3-docs-1.8.4/sl_SI/tips.txt pgadmin3-docs.x86_64: W: wrong-file-end-of-line-encoding /usr/share/doc/pgadmin3-docs-1.8.4/es_ES/tips.txt pgadmin3-docs.x86_64: W: wrong-file-end-of-line-encoding /usr/share/doc/pgadmin3-docs-1.8.4/de_DE/tips.txt pgadmin3.x86_64: E: world-writable /usr/share/pgadmin3/docs/en_US/pgadmin3.hhp.cached 0666 pgadmin3.x86_64: W: wrong-file-end-of-line-encoding /usr/share/doc/pgadmin3-1.8.4/CHANGELOG pgadmin3.x86_64: W: file-not-utf8 /usr/share/doc/pgadmin3-1.8.4/CHANGELOG pgadmin3.x86_64: W: file-not-in-%lang /usr/share/pgadmin3/i18n/af_ZA/pgadmin3.mo pgadmin3.x86_64: W: file-not-in-%lang /usr/share/pgadmin3/i18n/af_ZA/wxstd.mo pgadmin3.x86_64: W: file-not-in-%lang /usr/share/pgadmin3/i18n/bg_BG/pgadmin3.mo pgadmin3.x86_64: W: file-not-in-%lang /usr/share/pgadmin3/i18n/bg_BG/wxstd.mo pgadmin3.x86_64: W: file-not-in-%lang /usr/share/pgadmin3/i18n/ca_ES/pgadmin3.mo pgadmin3.x86_64: W: file-not-in-%lang /usr/share/pgadmin3/i18n/ca_ES/wxstd.mo pgadmin3.x86_64: W: file-not-in-%lang /usr/share/pgadmin3/i18n/de_DE/pgadmin3.mo pgadmin3.x86_64: W: file-not-in-%lang /usr/share/pgadmin3/i18n/de_DE/wxstd.mo pgadmin3.x86_64: W: file-not-in-%lang /usr/share/pgadmin3/i18n/es_ES/pgadmin3.mo pgadmin3.x86_64: W: file-not-in-%lang /usr/share/pgadmin3/i18n/es_ES/wxstd.mo pgadmin3.x86_64: W: file-not-in-%lang /usr/share/pgadmin3/i18n/fi_FI/pgadmin3.mo pgadmin3.x86_64: W: file-not-in-%lang /usr/share/pgadmin3/i18n/fi_FI/wxstd.mo pgadmin3.x86_64: W: file-not-in-%lang /usr/share/pgadmin3/i18n/fr_FR/pgadmin3.mo pgadmin3.x86_64: W: file-not-in-%lang /usr/share/pgadmin3/i18n/fr_FR/wxstd.mo pgadmin3.x86_64: W: file-not-in-%lang /usr/share/pgadmin3/i18n/gl_ES/pgadmin3.mo pgadmin3.x86_64: W: file-not-in-%lang /usr/share/pgadmin3/i18n/gl_ES/wxstd.mo pgadmin3.x86_64: W: file-not-in-%lang /usr/share/pgadmin3/i18n/it_IT/pgadmin3.mo pgadmin3.x86_64: W: file-not-in-%lang /usr/share/pgadmin3/i18n/it_IT/wxstd.mo pgadmin3.x86_64: W: file-not-in-%lang /usr/share/pgadmin3/i18n/ja_JP/pgadmin3.mo pgadmin3.x86_64: W: file-not-in-%lang /usr/share/pgadmin3/i18n/ja_JP/wxstd.mo pgadmin3.x86_64: W: file-not-in-%lang /usr/share/pgadmin3/i18n/ko_KR/pgadmin3.mo pgadmin3.x86_64: W: file-not-in-%lang /usr/share/pgadmin3/i18n/ko_KR/wxstd.mo pgadmin3.x86_64: W: file-not-in-%lang /usr/share/pgadmin3/i18n/nl_NL/pgadmin3.mo pgadmin3.x86_64: W: file-not-in-%lang /usr/share/pgadmin3/i18n/nl_NL/wxstd.mo pgadmin3.x86_64: W: file-not-in-%lang /usr/share/pgadmin3/i18n/pl_PL/pgadmin3.mo pgadmin3.x86_64: W: file-not-in-%lang /usr/share/pgadmin3/i18n/pl_PL/wxstd.mo pgadmin3.x86_64: W: file-not-in-%lang /usr/share/pgadmin3/i18n/pt_BR/pgadmin3.mo pgadmin3.x86_64: W: file-not-in-%lang /usr/share/pgadmin3/i18n/pt_BR/wxstd.mo pgadmin3.x86_64: W: file-not-in-%lang /usr/share/pgadmin3/i18n/pt_PT/pgadmin3.mo pgadmin3.x86_64: W: file-not-in-%lang /usr/share/pgadmin3/i18n/pt_PT/wxstd.mo pgadmin3.x86_64: W: file-not-in-%lang /usr/share/pgadmin3/i18n/ru_RU/pgadmin3.mo pgadmin3.x86_64: W: file-not-in-%lang /usr/share/pgadmin3/i18n/ru_RU/wxstd.mo pgadmin3.x86_64: W: file-not-in-%lang /usr/share/pgadmin3/i18n/sr_YU/pgadmin3.mo pgadmin3.x86_64: W: file-not-in-%lang /usr/share/pgadmin3/i18n/sr_YU/wxstd.mo pgadmin3.x86_64: W: file-not-in-%lang /usr/share/pgadmin3/i18n/wxstd.mo pgadmin3.x86_64: W: file-not-in-%lang /usr/share/pgadmin3/i18n/zh_CN/pgadmin3.mo pgadmin3.x86_64: W: file-not-in-%lang /usr/share/pgadmin3/i18n/zh_CN/wxstd.mo pgadmin3.x86_64: W: file-not-in-%lang /usr/share/pgadmin3/i18n/zh_TW/pgadmin3.mo pgadmin3.x86_64: W: file-not-in-%lang /usr/share/pgadmin3/i18n/zh_TW/wxstd.mo -- Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug.
[Bug 300] Review request: pgadmin3 - Graphical client for PostgreSQL
http://bugzilla.rpmfusion.org/show_bug.cgi?id=300 Manuel Wolfshant changed: What|Removed |Added CC||wo...@fedoraproject.org Blocks|2 |3 AssignedTo|rpmfusion-package- |wo...@fedoraproject.org |rev...@rpmfusion.org| --- Comment #1 from Manuel Wolfshant 2009-01-04 23:55:11 --- I've already started working on the review -- Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. You are the assignee for the bug.