[Bug 4293] Review request: tilem - Emulator and debugger for Texas Instruments Z80-based graphing calculators

[RPM Fusion Bugzilla]

https://bugzilla.rpmfusion.org/show_bug.cgi?id=4293

leigh scott  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 CC||leigh123li...@gmail.com
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are on the CC list for the bug.___
rpmfusion-developers mailing list -- rpmfusion-developers@lists.rpmfusion.org
To unsubscribe send an email to rpmfusion-developers-le...@lists.rpmfusion.org

[Bug 4293] Review request: tilem - Emulator and debugger for Texas Instruments Z80-based graphing calculators

[RPM Fusion Bugzilla]

https://bugzilla.rpmfusion.org/show_bug.cgi?id=4293

Andrew Bauer  changed:

   What|Removed |Added

 Blocks|3   |

--- Comment #22 from Andrew Bauer  ---
https://rpmfusion.org/Contributors#Your_package_gets_approved

Looks like I forgot to remove the RF_REVIEW flag. I've done that now (I think).
So it looks like you can hop over to pkdb and request the new package now.


Referenced Bugs:

https://bugzilla.rpmfusion.org/show_bug.cgi?id=3
[Bug 3] Tracker: Packages under review.
-- 
You are receiving this mail because:
You are on the CC list for the bug.___
rpmfusion-developers mailing list -- rpmfusion-developers@lists.rpmfusion.org
To unsubscribe send an email to rpmfusion-developers-le...@lists.rpmfusion.org

[Bug 4293] Review request: tilem - Emulator and debugger for Texas Instruments Z80-based graphing calculators

[RPM Fusion Bugzilla]

https://bugzilla.rpmfusion.org/show_bug.cgi?id=4293

--- Comment #21 from Ben Rosser  ---
Quick question, does the ticket need to be put from RF_REVIEW into RF_ACCEPT?

(I can do this, but I'm not sure if I should as the submitter).

-- 
You are receiving this mail because:
You are on the CC list for the bug.___
rpmfusion-developers mailing list -- rpmfusion-developers@lists.rpmfusion.org
To unsubscribe send an email to rpmfusion-developers-le...@lists.rpmfusion.org

[Bug 4293] Review request: tilem - Emulator and debugger for Texas Instruments Z80-based graphing calculators

[RPM Fusion Bugzilla]

https://bugzilla.rpmfusion.org/show_bug.cgi?id=4293

--- Comment #20 from Nicolas Chauvet  ---
(In reply to Ben Rosser from comment #19)
> Awesome, thanks for finishing the review!
> 
> When I asked about BR: coreutils I was told it was "up to the packager's
> discretion", so yeah, sadly there isn't a firm guideline here.
coreutils is part of the default group of packages populated for a build.
as seen in "koji show-groups f26-build"
So you can avoid listing it in BR. Only gcc is an exception because it would
avoid a dependency on gcc for noarch build.

-- 
You are receiving this mail because:
You are on the CC list for the bug.___
rpmfusion-developers mailing list -- rpmfusion-developers@lists.rpmfusion.org
To unsubscribe send an email to rpmfusion-developers-le...@lists.rpmfusion.org

[Bug 4293] Review request: tilem - Emulator and debugger for Texas Instruments Z80-based graphing calculators

[RPM Fusion Bugzilla]

https://bugzilla.rpmfusion.org/show_bug.cgi?id=4293

--- Comment #19 from Ben Rosser  ---
Awesome, thanks for finishing the review!

When I asked about BR: coreutils I was told it was "up to the packager's
discretion", so yeah, sadly there isn't a firm guideline here.

-- 
You are receiving this mail because:
You are on the CC list for the bug.___
rpmfusion-developers mailing list -- rpmfusion-developers@lists.rpmfusion.org
To unsubscribe send an email to rpmfusion-developers-le...@lists.rpmfusion.org

[Bug 4293] Review request: tilem - Emulator and debugger for Texas Instruments Z80-based graphing calculators

[RPM Fusion Bugzilla]

https://bugzilla.rpmfusion.org/show_bug.cgi?id=4293

Andrew Bauer  changed:

   What|Removed |Added

  Flags|fedora-review?  |fedora-review+

--- Comment #18 from Andrew Bauer  ---
Understood about not using macros for system commands. I had not seen that line
citing system commands as the exception. I will be sure to update my own
packages.

It would seem Fedora is not being consistent with their requirement to
buildrequire coreutils. For example  Petr Pisar required it for this (my)
Fedora package review here: https://bugzilla.redhat.com/show_bug.cgi?id=1409866

In any case, I don't see this as a reason to hold up your package review any
longer. Package approved.

-- 
You are receiving this mail because:
You are on the CC list for the bug.___
rpmfusion-developers mailing list -- rpmfusion-developers@lists.rpmfusion.org
To unsubscribe send an email to rpmfusion-developers-le...@lists.rpmfusion.org

[Bug 4293] Review request: tilem - Emulator and debugger for Texas Instruments Z80-based graphing calculators

[RPM Fusion Bugzilla]

https://bugzilla.rpmfusion.org/show_bug.cgi?id=4293

--- Comment #17 from Ben Rosser  ---
> 2) rpmlint incorrect-fsf-address errors.

tilem is definitely quiet upstream. I have filed a bug on their issue tracker
about this though: https://sourceforge.net/p/tilem/bugs/11/. My apologies for
not noticing this before; I missed it because the warning only appears in the
debuginfo package. My bad!

> 1) mv, mkdir, & cp are part of coreutils, so we should buildrequres coreutils

Coreutils is one of those packages that it is safe to assume is always
installed. I just asked about this in #fedora-devel to confirm that this is
still the case (as I know this policy has changed in the last few years). As
was pointed out by nirik, rpm itself depends on coreutils so it must always be
installed on a builder: check "rpm -q rpm --requires". :)

https://fedoraproject.org/wiki/Packaging:Guidelines#Build-Time_Dependencies_.28BuildRequires.29
also says that the tools to run "simple shell scripts" should be assumed to be
available, although that's kind of a vague guideline.

Anyway, I don't think it hurts to BR coreutils-- I can add it if you think it's
best. But I do not believe it should be necessary.

> 2) mv ,mkdir, & cp should be referred to by their macro names: %{__mv}, 
> %{__mkidr}, and %{__cp}. Touch does not have a macro.

As Andrea pointed out, this is something that shouldn't be done according to
https://fedoraproject.org/wiki/Packaging:Guidelines#Macros, unless there is a
reason to assume that the location of the coreutils binaries should be
configurable.

-- 
You are receiving this mail because:
You are on the CC list for the bug.___
rpmfusion-developers mailing list -- rpmfusion-developers@lists.rpmfusion.org
To unsubscribe send an email to rpmfusion-developers-le...@lists.rpmfusion.org

[Bug 4293] Review request: tilem - Emulator and debugger for Texas Instruments Z80-based graphing calculators

[RPM Fusion Bugzilla]

https://bugzilla.rpmfusion.org/show_bug.cgi?id=4293

--- Comment #16 from Andrea Musuruane  ---
Macro forms of system executables SHOULD NOT be used except when there is a
need to allow the location of those executables to be configurable.
https://fedoraproject.org/wiki/Packaging:Guidelines#Macros

-- 
You are receiving this mail because:
You are on the CC list for the bug.___
rpmfusion-developers mailing list -- rpmfusion-developers@lists.rpmfusion.org
To unsubscribe send an email to rpmfusion-developers-le...@lists.rpmfusion.org

[Bug 4293] Review request: tilem - Emulator and debugger for Texas Instruments Z80-based graphing calculators

[RPM Fusion Bugzilla]

https://bugzilla.rpmfusion.org/show_bug.cgi?id=4293

Andrew Bauer  changed:

   What|Removed |Added

 CC||zonexpertconsulting@outlook
   ||.com
   Assignee|rpmfusion-package-review@rp |zonexpertconsulting@outlook
   |mfusion.org |.com

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.___
rpmfusion-developers mailing list -- rpmfusion-developers@lists.rpmfusion.org
To unsubscribe send an email to rpmfusion-developers-le...@lists.rpmfusion.org

[Bug 4293] Review request: tilem - Emulator and debugger for Texas Instruments Z80-based graphing calculators

[RPM Fusion Bugzilla]

https://bugzilla.rpmfusion.org/show_bug.cgi?id=4293

Ben Rosser  changed:

   What|Removed |Added

 Status|ASSIGNED|NEW
   Assignee|anto.tra...@gmail.com   |rpmfusion-package-review@rp
   ||mfusion.org

--- Comment #14 from Ben Rosser  ---
This still seems to be stalled, so resetting the reviewer as per Fedora
"stalled review guidelines". 

https://fedoraproject.org/wiki/Policy_for_stalled_package_reviews

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.___
rpmfusion-developers mailing list -- rpmfusion-developers@lists.rpmfusion.org
To unsubscribe send an email to rpmfusion-developers-le...@lists.rpmfusion.org

[Bug 4293] Review request: tilem - Emulator and debugger for Texas Instruments Z80-based graphing calculators

[RPM Fusion Bugzilla]

https://bugzilla.rpmfusion.org/show_bug.cgi?id=4293

--- Comment #13 from Nicolas Chauvet  ---
(In reply to Ben Rosser from comment #12)
> Sorry to nag, but it'd be really nice to get tilem into RPM Fusion before
> Fedora 26.
> 
> Was there anything else blocking here?

As In fedora, you can probably swap review.

-- 
You are receiving this mail because:
You are on the CC list for the bug.___
rpmfusion-developers mailing list -- rpmfusion-developers@lists.rpmfusion.org
To unsubscribe send an email to rpmfusion-developers-le...@lists.rpmfusion.org

[Bug 4293] Review request: tilem - Emulator and debugger for Texas Instruments Z80-based graphing calculators

[RPM Fusion Bugzilla]

https://bugzilla.rpmfusion.org/show_bug.cgi?id=4293

--- Comment #12 from Ben Rosser  ---
Sorry to nag, but it'd be really nice to get tilem into RPM Fusion before
Fedora 26.

Was there anything else blocking here?

-- 
You are receiving this mail because:
You are on the CC list for the bug.___
rpmfusion-developers mailing list -- rpmfusion-developers@lists.rpmfusion.org
To unsubscribe send an email to rpmfusion-developers-le...@lists.rpmfusion.org

[Bug 4293] Review request: tilem - Emulator and debugger for Texas Instruments Z80-based graphing calculators

[RPM Fusion Bugzilla]

https://bugzilla.rpmfusion.org/show_bug.cgi?id=4293

--- Comment #11 from Ben Rosser  ---
Okay, thanks for the clarification-- rebuilt 2.0-4 without the BR on
hicolor-icon-theme.

Spec URL: https://www.acm.jhu.edu/~bjr/fedora/rpmfusion/tilem/tilem.spec
SRPM URL:
https://www.acm.jhu.edu/~bjr/fedora/rpmfusion/tilem/tilem-2.0-4.fc25.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.___
rpmfusion-developers mailing list -- rpmfusion-developers@lists.rpmfusion.org
To unsubscribe send an email to rpmfusion-developers-le...@lists.rpmfusion.org

[Bug 4293] Review request: tilem - Emulator and debugger for Texas Instruments Z80-based graphing calculators

[RPM Fusion Bugzilla]

https://bugzilla.rpmfusion.org/show_bug.cgi?id=4293

Andrea Musuruane  changed:

   What|Removed |Added

 CC||musur...@gmail.com

--- Comment #10 from Andrea Musuruane  ---
I don't think it is correct to BR hicolor-icon-theme. It is correct to require
it.

A longer discussion on the topic is here:
https://pagure.io/packaging-committee/issue/632

-- 
You are receiving this mail because:
You are on the CC list for the bug.___
rpmfusion-developers mailing list -- rpmfusion-developers@lists.rpmfusion.org
To unsubscribe send an email to rpmfusion-developers-le...@lists.rpmfusion.org

[Bug 4293] Review request: tilem - Emulator and debugger for Texas Instruments Z80-based graphing calculators

[RPM Fusion Bugzilla]

https://bugzilla.rpmfusion.org/show_bug.cgi?id=4293

--- Comment #9 from Ben Rosser  ---
Spec URL: https://www.acm.jhu.edu/~bjr/fedora/rpmfusion/tilem/tilem.spec

SRPM URL:
https://www.acm.jhu.edu/~bjr/fedora/rpmfusion/tilem/tilem-2.0-4.fc25.src.rpm

- Change license tag to GPLv3+
- Add desktop-database scriplets for Fedora < 25.
- Add BuildRequires and Requires on hicolor-icon-theme, to be safe.
- Renamed tilem2 desktop file to tilem.desktop, and validated it in install
section.

-- 
You are receiving this mail because:
You are on the CC list for the bug.___
rpmfusion-developers mailing list -- rpmfusion-developers@lists.rpmfusion.org
To unsubscribe send an email to rpmfusion-developers-le...@lists.rpmfusion.org

[Bug 4293] Review request: tilem - Emulator and debugger for Texas Instruments Z80-based graphing calculators

[RPM Fusion Bugzilla]

https://bugzilla.rpmfusion.org/show_bug.cgi?id=4293

--- Comment #8 from Vasiliy Glazov  ---
If hicolor-icon-theme not added to BR then tilem will own whole directory.

-- 
You are receiving this mail because:
You are on the CC list for the bug.___
rpmfusion-developers mailing list -- rpmfusion-developers@lists.rpmfusion.org
To unsubscribe send an email to rpmfusion-developers-le...@lists.rpmfusion.org

[Bug 4293] Review request: tilem - Emulator and debugger for Texas Instruments Z80-based graphing calculators

[RPM Fusion Bugzilla]

https://bugzilla.rpmfusion.org/show_bug.cgi?id=4293

--- Comment #7 from Antonio Trande  ---
(In reply to Vasiliy Glazov from comment #6)
> BuildRequires: - because this package should not be owner of
> /usr/share/icons directory.

In fact, 'tilem' must own '%{_datadir}/icons/hicolor/*/apps/tilem.png' files
only because '%{_datadir}/icons/hicolor/*/apps' are owned by
'hicolor-icon-theme'.

-- 
You are receiving this mail because:
You are on the CC list for the bug.___
rpmfusion-developers mailing list -- rpmfusion-developers@lists.rpmfusion.org
To unsubscribe send an email to rpmfusion-developers-le...@lists.rpmfusion.org

[Bug 4293] Review request: tilem - Emulator and debugger for Texas Instruments Z80-based graphing calculators

[RPM Fusion Bugzilla]

https://bugzilla.rpmfusion.org/show_bug.cgi?id=4293

Vasiliy Glazov  changed:

   What|Removed |Added

 CC||vasc...@gmail.com

--- Comment #4 from Vasiliy Glazov  ---
Please add
BuildRequires:  hicolor-icon-theme

-- 
You are receiving this mail because:
You are on the CC list for the bug.___
rpmfusion-developers mailing list -- rpmfusion-developers@lists.rpmfusion.org
To unsubscribe send an email to rpmfusion-developers-le...@lists.rpmfusion.org

[Bug 4293] Review request: tilem - Emulator and debugger for Texas Instruments Z80-based graphing calculators

[RPM Fusion Bugzilla]

https://bugzilla.rpmfusion.org/show_bug.cgi?id=4293

Antonio Trande  changed:

   What|Removed |Added

 Blocks|2   |3

--- Comment #3 from Antonio Trande  ---
Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed


Issues:
===
- Package installs a %{name}.desktop using desktop-file-install or desktop-
  file-validate if there is such a file.

  Please, validate the .desktop file with 'desktop-file-validate' command.

- update-desktop-database is invoked in %post and %postun if package
  contains desktop file(s) with a MimeType: entry.
  Note: desktop file(s) with MimeType entry in tilem
  See: http://fedoraproject.org/wiki/Packaging:ScriptletSnippets#desktop-
  database

  'update-desktop-database' must be invoked on Fedora < 25 only.
 
https://fedoraproject.org/wiki/Packaging:Scriptlets?rd=Packaging:ScriptletSnippets#desktop-database

- Source archive provides other files released under GPLv2+ and GPLv3+
  licenses. Main license of 'tilem' is GPLv3, but GPLv3+ includes all three
  licenses.
  I guess, License tag can be GPLv3+

- .desktop and .appdata.xml files must be named with the same name of package;
so,

  tilem.desktop, tilem.appdata.xml


= MUST items =

C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: Header files in -devel subpackage, if present.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.

Generic:
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[!]: License field in the package spec file matches the actual license.
 Note: Checking patched sources after %prep for licenses. Licenses
 found: "GPL (v3 or later)", "Unknown or generated", "MIT/X11 (BSD
 like)", "zlib/libpng", "GPL (v2 or later) (with incorrect FSF
 address)", "LGPL (v2.1 or later)". 64 files have unknown license.
 Detailed output of licensecheck in
 /home/sagitter/tilem/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
 names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[!]: gtk-update-icon-cache is invoked in %postun and %posttrans if package
 contains icons.
 Note: icons in tilem
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
 (~1MB) or number of files.
 Note: Documentation size is 40960 bytes in 5 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
 one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
 Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
 license(s) in its own file, then that file, containing the text of the
 license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any
 that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
 beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package contains desktop file if it is a GUI application.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
 work.
[x]: Package is 

[Bug 4293] Review request: tilem - Emulator and debugger for Texas Instruments Z80-based graphing calculators

[RPM Fusion Bugzilla]

https://bugzilla.rpmfusion.org/show_bug.cgi?id=4293

Antonio Trande  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||anto.tra...@gmail.com
   Assignee|rpmfusion-package-review@rp |anto.tra...@gmail.com
   |mfusion.org |
  Flags||fedora-review?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.___
rpmfusion-developers mailing list -- rpmfusion-developers@lists.rpmfusion.org
To unsubscribe send an email to rpmfusion-developers-le...@lists.rpmfusion.org

[Bug 4293] Review request: tilem - Emulator and debugger for Texas Instruments Z80-based graphing calculators

[RPM Fusion Bugzilla]

https://bugzilla.rpmfusion.org/show_bug.cgi?id=4293

--- Comment #2 from Ben Rosser  ---
Spec URL: https://www.acm.jhu.edu/~bjr/fedora/rpmfusion/tilem/tilem.spec

SRPM URL:
https://www.acm.jhu.edu/~bjr/fedora/rpmfusion/tilem/tilem-2.0-3.fc25.src.rpm

I just wrote an appdata file for tilem
(https://www.acm.jhu.edu/~bjr/fedora/rpmfusion/tilem/tilem.appdata.xml) and
updated the package with it.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.___
rpmfusion-developers mailing list -- rpmfusion-developers@lists.rpmfusion.org
To unsubscribe send an email to rpmfusion-developers-le...@lists.rpmfusion.org

[Bug 4293] Review request: tilem - Emulator and debugger for Texas Instruments Z80-based graphing calculators

[RPM Fusion Bugzilla]

http://bugzilla.rpmfusion.org/show_bug.cgi?id=4293

leigh scott  changed:

   What|Removed |Added

 CC||leigh123li...@gmail.com
Summary|tilem - Emulator and|Review request: tilem -
   |debugger for Texas  |Emulator and debugger for
   |Instruments Z80-based   |Texas Instruments Z80-based
   |graphing calculators|graphing calculators

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.