[Bug 4393] Review Request: zoneminder - A camera monitoring and analysis tool

[RPM Fusion Bugzilla]

https://bugzilla.rpmfusion.org/show_bug.cgi?id=4393

Andrew Bauer  changed:

   What|Removed |Added

 Status|ASSIGNED|RESOLVED
 Resolution|--- |FIXED

--- Comment #51 from Andrew Bauer  ---
Thanks for the update.

f26 now builds:
http://koji.rpmfusion.org/koji/taskinfo?taskID=148433

and so does rawhide:
http://koji.rpmfusion.org/koji/taskinfo?taskID=148444

We are all good now.

-- 
You are receiving this mail because:
You are on the CC list for the bug.___
rpmfusion-developers mailing list -- rpmfusion-developers@lists.rpmfusion.org
To unsubscribe send an email to rpmfusion-developers-le...@lists.rpmfusion.org

[Bug 4393] Review Request: zoneminder - A camera monitoring and analysis tool

[RPM Fusion Bugzilla]

https://bugzilla.rpmfusion.org/show_bug.cgi?id=4393

--- Comment #50 from Nicolas Chauvet  ---
(In reply to Andrew Bauer from comment #49)
> Pardon my newness to rpmfusion. After seeing the note stating bohdi is not
> running yet, I did an "rfpkg update" from the command line, similar to what
No need to publish the packages here. I usually try to push packages twice a
week. First push it goes into testing, then into stable.
If anything, please report an infra bug or say on the mailing list.

You can resubmit the f26-free job as I've tagged the newer vlc in override
in-between...

-- 
You are receiving this mail because:
You are on the CC list for the bug.___
rpmfusion-developers mailing list -- rpmfusion-developers@lists.rpmfusion.org
To unsubscribe send an email to rpmfusion-developers-le...@lists.rpmfusion.org

[Bug 4393] Review Request: zoneminder - A camera monitoring and analysis tool

[RPM Fusion Bugzilla]

https://bugzilla.rpmfusion.org/show_bug.cgi?id=4393

--- Comment #49 from Andrew Bauer  ---
Pardon my newness to rpmfusion. After seeing the note stating bohdi is not
running yet, I did an "rfpkg update" from the command line, similar to what I
would do to push a new package into testing with Fedora. Since that process did
not accept my login credentials, I went back to the rpmfusion contributer
documentation. 

If I understand correctly, it seems I should post my successful builds here in
the bug report, and presumably someone else will add them to rpmfusion testing.

So heads up, here is the build for el7:
http://koji.rpmfusion.org/koji/taskinfo?taskID=148328

And here is the build for f25:
http://koji.rpmfusion.org/koji/taskinfo?taskID=148357

Building ZoneMinder on rawhide & f26, however, is failing due to an unresolved
dep with live555. 

>Error: nothing provides live555(x86-64) = 2017.04.26 needed by 
>vlc-core-3.0.0-0.29.git20170622.fc26.x86_64

Which came from the following log:
http://koji.rpmfusion.org/kojifiles/work/tasks/8351/148351/mock_output.log

Everything looks in order, if I manually browse the rpmfusion repo so I'm not
sure why that dep is failing. I'm going to just wait a couple days and try
again. Maybe it will clear up on its own.

-- 
You are receiving this mail because:
You are on the CC list for the bug.___
rpmfusion-developers mailing list -- rpmfusion-developers@lists.rpmfusion.org
To unsubscribe send an email to rpmfusion-developers-le...@lists.rpmfusion.org

[Bug 4393] Review Request: zoneminder - A camera monitoring and analysis tool

[RPM Fusion Bugzilla]

https://bugzilla.rpmfusion.org/show_bug.cgi?id=4393

leigh scott  changed:

   What|Removed |Added

 CC||leigh123li...@gmail.com

--- Comment #48 from leigh scott  ---
Package processed, checkout using this command

rfpkg co free/zoneminder

-- 
You are receiving this mail because:
You are on the CC list for the bug.___
rpmfusion-developers mailing list -- rpmfusion-developers@lists.rpmfusion.org
To unsubscribe send an email to rpmfusion-developers-le...@lists.rpmfusion.org

[Bug 4393] Review Request: zoneminder - A camera monitoring and analysis tool

[RPM Fusion Bugzilla]

https://bugzilla.rpmfusion.org/show_bug.cgi?id=4393

--- Comment #46 from Nicolas Chauvet  ---
(In reply to Antonio Trande from comment #45)
@Antonio can you push the "fedora-review" flag to "+" in this review.
This is the new way to approve package (same as Fedora IIRC).

-- 
You are receiving this mail because:
You are on the CC list for the bug.___
rpmfusion-developers mailing list -- rpmfusion-developers@lists.rpmfusion.org
To unsubscribe send an email to rpmfusion-developers-le...@lists.rpmfusion.org

[Bug 4393] Review Request: zoneminder - A camera monitoring and analysis tool

[RPM Fusion Bugzilla]

https://bugzilla.rpmfusion.org/show_bug.cgi?id=4393

--- Comment #44 from Antonio Trande  ---
$ mock --no-clean  -r fedora-rawhide-x86_64-rpmfusion_free --shell 'rpmlint
zoneminder-debuginfo'
INFO: mock.py version 1.4.2 starting (python version = 3.6.1)...
zoneminder-debuginfo.x86_64: E: useless-provides debuginfo(build-id)
1 packages and 0 specfiles checked; 1 errors, 0 warnings.
Finish: shell

-- 
You are receiving this mail because:
You are on the CC list for the bug.___
rpmfusion-developers mailing list -- rpmfusion-developers@lists.rpmfusion.org
To unsubscribe send an email to rpmfusion-developers-le...@lists.rpmfusion.org

[Bug 4393] Review Request: zoneminder - A camera monitoring and analysis tool

[RPM Fusion Bugzilla]

https://bugzilla.rpmfusion.org/show_bug.cgi?id=4393

Antonio Trande  changed:

   What|Removed |Added

 Blocks|3   |4

--- Comment #43 from Antonio Trande  ---
Package approved.

Rawhide scratch build: http://koji.rpmfusion.org/koji/taskinfo?taskID=146830
Epel7 scratch build: http://koji.rpmfusion.org/koji/taskinfo?taskID=146956

Review:

= MUST items =

Generic:
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[-]: If (and only if) the source package includes the text of the
 license(s) in its own file, then that file, containing the text of the
 license(s) for the package is included in %license.
[x]: License field in the package spec file matches the actual license.
[x]: License file installed when any subpackage combination is installed.
[x]: Package must own all directories that it creates.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
 names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[x]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
 (~1MB) or number of files.
 Note: Documentation size is 20480 bytes in 2 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
 one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
 Note: There are rpmlint messages (see attachment).
[x]: Package requires other packages for directories it uses.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any
 that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
 beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
 work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
 provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
 %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

Python:
[x]: Python eggs must not download any dependencies during the build
 process.
[x]: A package which is used by another package via an egg interface should
 provide egg info.
[!]: Package meets the Packaging Guidelines::Python
[x]: Package contains BR: python2-devel or python3-devel
[x]: Binary eggs must be removed in %prep

= SHOULD items =

Generic:
[-]: If the source package does not include license text(s) as a separate
 file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[-]: Fully versioned dependency in subpackages if applicable.
[ ]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[-]: Description and summary sections in the package spec file contains
 translations for supported Non-English languages, if available.
[x]: Package should compile and build into binary rpms on all supported
 architectures.
[-]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed
 files.
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
 $RPM_BUILD_ROOT)
[x]: No file requires outside of 

[Bug 4393] Review Request: zoneminder - A camera monitoring and analysis tool

[RPM Fusion Bugzilla]

https://bugzilla.rpmfusion.org/show_bug.cgi?id=4393

--- Comment #41 from Antonio Trande  ---
(In reply to Andrew Bauer from comment #40)
> 
> F26 SRPM:
> http://zmrepo.zoneminder.com/f/testing/26/x86_64/zoneminder-1.30.4-3.fc26.
> x86_64.rpm
> 


SRPM??

-- 
You are receiving this mail because:
You are on the CC list for the bug.___
rpmfusion-developers mailing list -- rpmfusion-developers@lists.rpmfusion.org
To unsubscribe send an email to rpmfusion-developers-le...@lists.rpmfusion.org

[Bug 4393] Review Request: zoneminder - A camera monitoring and analysis tool

[RPM Fusion Bugzilla]

https://bugzilla.rpmfusion.org/show_bug.cgi?id=4393

--- Comment #38 from Andrew Bauer  ---
ZoneMinder uses the CakePHP project as the framework for ZoneMinder's API.
We've also added the Crud project as a plugin to the CakePHP framework. Crud is
configured as a git submodule in the ZoneMinder project.

All of the issues you have mentioned are under the
/usr/share/zoneminder/www/api folder and are either part of the CakePHP source
code, or they are part of the Crud plugin found here
/usr/share/zoneminder/www/api/app/Plugin/Crud/. 

> - 'htaccess-file'

There are five .htaccess files in the zoneminder api/cakephp folder structure.
I had previously considered migrating these to the central zoneminder apache
config file, but the amount of work to benefit ratio seemed small. I'll look
into it.

> - wrong-script-interpreter
I'll use find/sed to fix this from the specfile.

> - non-executable-script (.php files)
This is not causing the ZoneMinder API to malfunction, and I'm not even sure
the files in question are even used. Perhaps I can just delete them.
Will look into this. I wonder though, if I set the executable flag, will
rpmlint then complain about executable scripts outside the bin folder?

>- hidden-file-or-dir
All but one of the hidden files are caused by multiple copes of the file
.editorconfig. I'm already deleting several other hidden files from the
specfile. I'll add .editorconfig to the list since it is not needed during
runtime.

One hidden file .semver contains the version of the Crud plugin. While deleting
that file won't cause any runtime issues, it would be nice to keep it around
for reference.

>- W: pem-certificate
If I move cacert.pem to /etc/pki/zoneminder/, can I then symlink it back to the
spot CakePHP expects the file to be in?


Do you know of any other packages which use CakePHP? It would be interesting to
see exactly how other packages have managed through these rpmlint issues. I
just hate reinventing the wheel.

-- 
You are receiving this mail because:
You are on the CC list for the bug.___
rpmfusion-developers mailing list -- rpmfusion-developers@lists.rpmfusion.org
To unsubscribe send an email to rpmfusion-developers-le...@lists.rpmfusion.org

[Bug 4393] Review Request: zoneminder - A camera monitoring and analysis tool

[RPM Fusion Bugzilla]

https://bugzilla.rpmfusion.org/show_bug.cgi?id=4393

--- Comment #36 from Andrew Bauer  ---
After upgrading my workstation F25 -> F26, I observed that rpmlint -v
zoneminder takes an unusually long time to complete. 

If I wait 1-2 minutes, it eventually completes with the following output:
https://gist.github.com/knnniggett/a7376eec50285476d323949cd61e1e33

Can you try again and just wait a while to see if it completes?

-- 
You are receiving this mail because:
You are on the CC list for the bug.___
rpmfusion-developers mailing list -- rpmfusion-developers@lists.rpmfusion.org
To unsubscribe send an email to rpmfusion-developers-le...@lists.rpmfusion.org

[Bug 4393] Review Request: zoneminder - A camera monitoring and analysis tool

[RPM Fusion Bugzilla]

https://bugzilla.rpmfusion.org/show_bug.cgi?id=4393

--- Comment #35 from Andrew Bauer  ---
(In reply to Antonio Trande from comment #34)
> - There something wrong after installing zoneminder: 'rpmlint' does not
> finish its checks:
> 
> $ rpmlint -v zoneminder
> zoneminder.x86_64: I: checking
> zoneminder.x86_64: E: explicit-lib-dependency libjpeg-turbo
> zoneminder.x86_64: I: checking-url http://www.zoneminder.com/ (timeout 10
> seconds)
> zoneminder.x86_64: E: non-readable /etc/zm/zm.conf 640
> ...
> ...
> 
> - /etc/zm/zm.conf is not readable.
> 
> - 

The zm.conf file contains sensitive information, so it is by design this config
file can only be read by root and the web account user. 

However, I would not expect this to cause rpmlint to not finish. I can't
duplicate this on my end, and I'm running rpmlint as a normal user. 

While rpmlint does product a lot of output, which we can certainly talk about,
it fully completes for me. This was on F25. I can upgrade to F26 and try again.
I'm not sure what else to try.

> >
> # Create and load zoneminder selinux policy module
> echo -e "\nCreating and installing a ZoneMinder SELinux policy module.
> Please wait.\n"
> %{_bindir}/checkmodule -M -m -o
> %{_docdir}/%{name}-%{version}/local_zoneminder.mod
> %{_docdir}/%{name}-%{version}/local_zoneminder.te > /dev/null 2>&1 || :
> %{_bindir}/semodule_package -o
> %{_docdir}/%{name}-%{version}/local_zoneminder.pp -m
> %{_docdir}/%{name}-%{version}/local_zoneminder.mod > /dev/null 2>&1 || :
> %{_sbindir}/semodule -i %{_docdir}/%{name}-%{version}/local_zoneminder.pp >
> /dev/null 2>&1 || :
> >
> 
> I dont know if adding custom SELinux module by RPMs is permitted on Fedora.
> Have you ever ask about that in the devel mailing list?

The custom selinux module is only built for el6, and I have recently decided
that I no longer intend to build zoneminder for el6 in rpmfusion. There are
several reasons why I made this decision, but for the sake of staying on topic
I won't list them here.

el7 & fedora distros do not contain this custom module nor the source files the
module is built from.

For the near future, I intend to continue to maintain zoneminder on el6 in my
own repo, zmrepo. Consequently, I'd like to keep this bit of code in the spec
file for now. I hope this is acceptable. I can add additional comments to the
specfile to state this intention if that would be an acceptable compromise.

-- 
You are receiving this mail because:
You are on the CC list for the bug.___
rpmfusion-developers mailing list -- rpmfusion-developers@lists.rpmfusion.org
To unsubscribe send an email to rpmfusion-developers-le...@lists.rpmfusion.org

[Bug 4393] Review Request: zoneminder - A camera monitoring and analysis tool

[RPM Fusion Bugzilla]

https://bugzilla.rpmfusion.org/show_bug.cgi?id=4393

--- Comment #34 from Antonio Trande  ---
- There something wrong after installing zoneminder: 'rpmlint' does not finish
its checks:

$ rpmlint -v zoneminder
zoneminder.x86_64: I: checking
zoneminder.x86_64: E: explicit-lib-dependency libjpeg-turbo
zoneminder.x86_64: I: checking-url http://www.zoneminder.com/ (timeout 10
seconds)
zoneminder.x86_64: E: non-readable /etc/zm/zm.conf 640
...
...

- /etc/zm/zm.conf is not readable.

- 
>
# Create and load zoneminder selinux policy module
echo -e "\nCreating and installing a ZoneMinder SELinux policy module. Please
wait.\n"
%{_bindir}/checkmodule -M -m -o
%{_docdir}/%{name}-%{version}/local_zoneminder.mod
%{_docdir}/%{name}-%{version}/local_zoneminder.te > /dev/null 2>&1 || :
%{_bindir}/semodule_package -o
%{_docdir}/%{name}-%{version}/local_zoneminder.pp -m
%{_docdir}/%{name}-%{version}/local_zoneminder.mod > /dev/null 2>&1 || :
%{_sbindir}/semodule -i %{_docdir}/%{name}-%{version}/local_zoneminder.pp >
/dev/null 2>&1 || :
>

I dont know if adding custom SELinux module by RPMs is permitted on Fedora.
Have you ever ask about that in the devel mailing list?

-- 
You are receiving this mail because:
You are on the CC list for the bug.___
rpmfusion-developers mailing list -- rpmfusion-developers@lists.rpmfusion.org
To unsubscribe send an email to rpmfusion-developers-le...@lists.rpmfusion.org

[Bug 4393] Review Request: zoneminder - A camera monitoring and analysis tool

[RPM Fusion Bugzilla]

https://bugzilla.rpmfusion.org/show_bug.cgi?id=4393

--- Comment #33 from Andrew Bauer  ---
Understood. Thanks for the heads up.

perl-Net-SFTP-Foreign is experiencing dependency issues in rawhide due to some
per-math package not building on latest perl.

-- 
You are receiving this mail because:
You are on the CC list for the bug.___
rpmfusion-developers mailing list -- rpmfusion-developers@lists.rpmfusion.org
To unsubscribe send an email to rpmfusion-developers-le...@lists.rpmfusion.org

[Bug 4393] Review Request: zoneminder - A camera monitoring and analysis tool

[RPM Fusion Bugzilla]

https://bugzilla.rpmfusion.org/show_bug.cgi?id=4393

--- Comment #32 from Antonio Trande  ---
I can't build on rawhide yet, because of some broken dependencies among
packages.
I will review this package as soon as possible.

-- 
You are receiving this mail because:
You are on the CC list for the bug.___
rpmfusion-developers mailing list -- rpmfusion-developers@lists.rpmfusion.org
To unsubscribe send an email to rpmfusion-developers-le...@lists.rpmfusion.org

[Bug 4393] Review Request: zoneminder - A camera monitoring and analysis tool

[RPM Fusion Bugzilla]

https://bugzilla.rpmfusion.org/show_bug.cgi?id=4393

--- Comment #31 from Andrew Bauer  ---
Thanks for the feedback. It turns out I needed to make some additional changes
as well.

I can mock build the following on f27.

srpm: 
https://zmrepo.zoneminder.com/f/testing/27/SRPMS/zoneminder-1.30.4-2.fc27.src.rpm

specfile:
https://gist.githubusercontent.com/knnniggett/8f148fc1dd5b9f8e4ae604d0de60ca09/raw/c6ae7200da2281cf1458a2655cf81b84fc389f2f/zoneminder.spec

patch0:
https://gist.githubusercontent.com/knnniggett/8f148fc1dd5b9f8e4ae604d0de60ca09/raw/c6ae7200da2281cf1458a2655cf81b84fc389f2f/zoneminder-ftbsf27.patch

patch1:
https://gist.githubusercontent.com/knnniggett/8f148fc1dd5b9f8e4ae604d0de60ca09/raw/c6ae7200da2281cf1458a2655cf81b84fc389f2f/zoneminder-distropatternmatch.patch

Patches are based on merged upstream changes from the current master branch.

-- 
You are receiving this mail because:
You are on the CC list for the bug.___
rpmfusion-developers mailing list -- rpmfusion-developers@lists.rpmfusion.org
To unsubscribe send an email to rpmfusion-developers-le...@lists.rpmfusion.org

[Bug 4393] Review Request: zoneminder - A camera monitoring and analysis tool

[RPM Fusion Bugzilla]

https://bugzilla.rpmfusion.org/show_bug.cgi?id=4393

--- Comment #30 from Michael Cronenworth  ---
(In reply to Andrew Bauer from comment #29)
> Right, you guys are building against F27 now, which I have not tested yet.
> This does build against f24, f25, el6, & el7, but I image you will want this
> to build against rawhide. I need to spend some time to figure out how to
> resolve this build failure:
> 
[snip]
> /builddir/build/BUILD/ZoneMinder-1.30.4/src/zm_comms.h:98:20: error:
> '::readv' has not been declared
>  int nBytes = ::readv( mRd, iov, iovcnt );

They have the required include for readv()/writev() in a #if defined(BSD)
block. You can ask upstream to fix it and in the mean time patch it so #include
 is available for all systems.

-- 
You are receiving this mail because:
You are on the CC list for the bug.___
rpmfusion-developers mailing list -- rpmfusion-developers@lists.rpmfusion.org
To unsubscribe send an email to rpmfusion-developers-le...@lists.rpmfusion.org

[Bug 4393] Review Request: zoneminder - A camera monitoring and analysis tool

[RPM Fusion Bugzilla]

https://bugzilla.rpmfusion.org/show_bug.cgi?id=4393

--- Comment #29 from Andrew Bauer  ---
Right, you guys are building against F27 now, which I have not tested yet.
This does build against f24, f25, el6, & el7, but I image you will want this to
build against rawhide. I need to spend some time to figure out how to resolve
this build failure:

make[2]: Leaving directory '/builddir/build/BUILD/ZoneMinder-1.30.4'
In file included from
/builddir/build/BUILD/ZoneMinder-1.30.4/src/zm_comms.cpp:20:0:
/builddir/build/BUILD/ZoneMinder-1.30.4/src/zm_comms.h: In member function
'virtual int CommsBase::readV(const iovec*, int)':
/builddir/build/BUILD/ZoneMinder-1.30.4/src/zm_comms.h:98:20: error: '::readv'
has not been declared
 int nBytes = ::readv( mRd, iov, iovcnt );
^
/builddir/build/BUILD/ZoneMinder-1.30.4/src/zm_comms.h:98:20: note: suggested
alternative: 'read'
 int nBytes = ::readv( mRd, iov, iovcnt );
^
read
/builddir/build/BUILD/ZoneMinder-1.30.4/src/zm_comms.h: In member function
'virtual int CommsBase::writeV(const iovec*, int)':
/builddir/build/BUILD/ZoneMinder-1.30.4/src/zm_comms.h:105:24: error:
'::writev' has not been declared
 ssize_t nBytes = ::writev( mWd, iov, iovcnt );
^~
/builddir/build/BUILD/ZoneMinder-1.30.4/src/zm_comms.h:105:24: note: suggested
alternative: 'write'
 ssize_t nBytes = ::writev( mWd, iov, iovcnt );
^~
write
/builddir/build/BUILD/ZoneMinder-1.30.4/src/zm_comms.cpp: In member function
'virtual int CommsBase::readV(int, ...)':
/builddir/build/BUILD/ZoneMinder-1.30.4/src/zm_comms.cpp:59:18: error:
'::readv' has not been declared
   int nBytes = ::readv( mRd, iov, iovcnt );
  ^
/builddir/build/BUILD/ZoneMinder-1.30.4/src/zm_comms.cpp:59:18: note: suggested
alternative: 'read'
   int nBytes = ::readv( mRd, iov, iovcnt );
  ^
  read
/builddir/build/BUILD/ZoneMinder-1.30.4/src/zm_comms.cpp: In member function
'virtual int CommsBase::writeV(int, ...)':
/builddir/build/BUILD/ZoneMinder-1.30.4/src/zm_comms.cpp:79:22: error:
'::writev' has not been declared
   ssize_t nBytes = ::writev( mWd, iov, iovcnt );
  ^~
/builddir/build/BUILD/ZoneMinder-1.30.4/src/zm_comms.cpp:79:22: note: suggested
alternative: 'write'
   ssize_t nBytes = ::writev( mWd, iov, iovcnt );
  ^~
  write
make[2]: *** [src/CMakeFiles/zm.dir/build.make:138:
src/CMakeFiles/zm.dir/zm_comms.cpp.o] Error 1

-- 
You are receiving this mail because:
You are on the CC list for the bug.___
rpmfusion-developers mailing list -- rpmfusion-developers@lists.rpmfusion.org
To unsubscribe send an email to rpmfusion-developers-le...@lists.rpmfusion.org

[Bug 4393] Review Request: zoneminder - A camera monitoring and analysis tool

[RPM Fusion Bugzilla]

https://bugzilla.rpmfusion.org/show_bug.cgi?id=4393

--- Comment #28 from Antonio Trande  ---
(In reply to Andrew Bauer from comment #27)
> Thank you Antonio for reviewing this.
> 
> The latest release, 1.30.4, srpm & specfile are here:
> https://raw.githubusercontent.com/ZoneMinder/ZoneMinder/1.30.4/distros/
> redhat/zoneminder.spec
> 
> https://zmrepo.zoneminder.com/f/25/SRPMS/zoneminder-1.30.4-1.fc25.src.rpm
> 
> However, the rpm specfile, as it exists today, has already been changed. The
> latest specfile can be found in one of our development snapshots:
> 
> https://zmrepo.zoneminder.com/f/testing/25/SRPMS/zoneminder-1.31.0-1.131.
> 20170612gitg4ba9205b.fc25.src.rpm
> 
> https://raw.githubusercontent.com/ZoneMinder/ZoneMinder/
> 4ba9205ba94062f6576b6353a9a54408983f0edb/distros/redhat/zoneminder.spec
> 
> 
> Let me know if you need anything else.

This package does not build:

make[1]: Entering directory '/builddir/build/BUILD/ZoneMinder-1.30.4'
[ 10%] Built target zmonvifproxy
make[1]: Leaving directory '/builddir/build/BUILD/ZoneMinder-1.30.4'
RPM build errors:
make[3]: warning: jobserver unavailable: using -j1.  Add '+' to parent make
rule.
make: *** [Makefile:133: all] Error 2

http://koji.rpmfusion.org/koji/getfile?taskID=132107=DEFAULT=build.log=-4000

-- 
You are receiving this mail because:
You are on the CC list for the bug.___
rpmfusion-developers mailing list -- rpmfusion-developers@lists.rpmfusion.org
To unsubscribe send an email to rpmfusion-developers-le...@lists.rpmfusion.org

[Bug 4393] Review Request: zoneminder - A camera monitoring and analysis tool

[RPM Fusion Bugzilla]

https://bugzilla.rpmfusion.org/show_bug.cgi?id=4393

--- Comment #27 from Andrew Bauer  ---
Thank you Antonio for reviewing this.

The latest release, 1.30.4, srpm & specfile are here:
https://raw.githubusercontent.com/ZoneMinder/ZoneMinder/1.30.4/distros/redhat/zoneminder.spec

https://zmrepo.zoneminder.com/f/25/SRPMS/zoneminder-1.30.4-1.fc25.src.rpm

However, the rpm specfile, as it exists today, has already been changed. The
latest specfile can be found in one of our development snapshots:

https://zmrepo.zoneminder.com/f/testing/25/SRPMS/zoneminder-1.31.0-1.131.20170612gitg4ba9205b.fc25.src.rpm

https://raw.githubusercontent.com/ZoneMinder/ZoneMinder/4ba9205ba94062f6576b6353a9a54408983f0edb/distros/redhat/zoneminder.spec


Let me know if you need anything else.

-- 
You are receiving this mail because:
You are on the CC list for the bug.___
rpmfusion-developers mailing list -- rpmfusion-developers@lists.rpmfusion.org
To unsubscribe send an email to rpmfusion-developers-le...@lists.rpmfusion.org

[Bug 4393] Review Request: zoneminder - A camera monitoring and analysis tool

[RPM Fusion Bugzilla]

https://bugzilla.rpmfusion.org/show_bug.cgi?id=4393

Antonio Trande  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 Blocks|2, 30   |3
   Assignee|rpmfusion-package-review@rp |anto.tra...@gmail.com
   |mfusion.org |

--- Comment #26 from Antonio Trande  ---
Andrew is a Fedora packager, he does not need a sponsor.

@Andrew,

update to latest version, please.
I will review this package.


Referenced Bugs:

https://bugzilla.rpmfusion.org/show_bug.cgi?id=2
[Bug 2] Tracker: New packages awaiting review
https://bugzilla.rpmfusion.org/show_bug.cgi?id=3
[Bug 3] Tracker: Packages under review.
https://bugzilla.rpmfusion.org/show_bug.cgi?id=30
[Bug 30] Tracker : Sponsorship Request
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.___
rpmfusion-developers mailing list -- rpmfusion-developers@lists.rpmfusion.org
To unsubscribe send an email to rpmfusion-developers-le...@lists.rpmfusion.org

[Bug 4393] Review Request: zoneminder - A camera monitoring and analysis tool

[RPM Fusion Bugzilla]

https://bugzilla.rpmfusion.org/show_bug.cgi?id=4393

--- Comment #25 from Andrew Bauer  ---
Greetings Xavier,
Thank you for the prodding me. Following up here has been in the back of mind
for a couple weeks now. 

With the help of Damian, all of ZoneMinder's dependencies are now in the Fedora
& EPEL repos. This has been a great learning experience.

Just to be sure we are set, I did a mock build against el6, el7, f24, and f25
this morning, using the appropriate rpmfusion mock config, and they all built
successfully.

This is the spec file to use to build our latest 1.30.2 release:
https://raw.githubusercontent.com/ZoneMinder/ZoneMinder/1.30.2/distros/redhat/zoneminder.spec

However, this is not the most recent. I've already made changes, which will
appear in the upcoming 1.30.3 release "soon". You can see the progress of that
specfile in our master branch here:
https://raw.githubusercontent.com/ZoneMinder/ZoneMinder/master/distros/redhat/zoneminder.spec


In the grand scheme of things, I'm trying to manage a single zoneminder spec
file for three related, but different, purposes:
- rpmfusion
- an upstream build system for nightly builds
- experimental nginx support

This is the underlying reason why one might see content in the spec file that,
today, might not apply to rpmfusion.

During the process, I have indeed become part of the Fedora packaging group, so
if I understand correctly that means I don't need an rpmfusion sponsor, but
don't I still need someone to add my FAS account to the rpmfusion packaging
group? My fas account name is Kni.

In any case, feel free to continue the review process when your time allows.
Due to the complicated nature of the zoneminder specfile, I'm sure there might
be additional questions or concerns.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.___
rpmfusion-developers mailing list -- rpmfusion-developers@lists.rpmfusion.org
To unsubscribe send an email to rpmfusion-developers-le...@lists.rpmfusion.org

[Bug 4393] Review Request: zoneminder - A camera monitoring and analysis tool

[RPM Fusion Bugzilla]

https://bugzilla.rpmfusion.org/show_bug.cgi?id=4393

--- Comment #24 from Xavier Bachelot  ---
The review was on hold because of missing dependencies in Fedora.

Andrew, are all the dependencies available now ? And is the specfile up to date
?
I can take care of the review next week if both answers are yes.
Oh, and also, do you still need a sponsor ? I guess no, because you should
already be sponsored in Fedora. Either way, it doesn't matter that much, I can
sponsor you if needed.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.___
rpmfusion-developers mailing list -- rpmfusion-developers@lists.rpmfusion.org
To unsubscribe send an email to rpmfusion-developers-le...@lists.rpmfusion.org

[Bug 4393] Review Request: zoneminder - A camera monitoring and analysis tool

[RPM Fusion Bugzilla]

https://bugzilla.rpmfusion.org/show_bug.cgi?id=4393

--- Comment #23 from Nicolas Chauvet  ---
Is there any spec file update for this review ?
Anyone can step in as a reviewer ?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.___
rpmfusion-developers mailing list -- rpmfusion-developers@lists.rpmfusion.org
To unsubscribe send an email to rpmfusion-developers-le...@lists.rpmfusion.org

[Bug 4393] Review Request: zoneminder - A camera monitoring and analysis tool

[RPM Fusion Bugzilla]

https://bugzilla.rpmfusion.org/show_bug.cgi?id=4393

--- Comment #22 from Andrew Bauer  ---
This is just a ping to let everyone know I am still making progress on this,
even though it doesn't show in this particular bug report.

I have been making slow, but steady progress on ZoneMinder's dependencies over
on the Fedora packaging side. Some packages have made it to stable, but several
more are still in the pipe.

Most of my progress can be seen from my list of open redhat bugs:
https://bugzilla.redhat.com/buglist.cgi?bug_status=NEW_status=VERIFIED_status=ASSIGNED_status=MODIFIED_status=ON_DEV_status=ON_QA_status=RELEASE_PENDING_status=POST=zonexpertconsulting%40outlook.com_to1=1=1=1=exact_id=7000579

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.___
rpmfusion-developers mailing list -- rpmfusion-developers@lists.rpmfusion.org
To unsubscribe send an email to rpmfusion-developers-le...@lists.rpmfusion.org

[Bug 4393] Review Request: zoneminder - A camera monitoring and analysis tool

[RPM Fusion Bugzilla]

https://bugzilla.rpmfusion.org/show_bug.cgi?id=4393

--- Comment #21 from Andrew Bauer  ---
I've made further progress on this.

(In reply to Xavier Bachelot from comment #19)
> A couple more comments on the spec...
> 
> - Which supported distro/releases don't have %make_build ?
>   Thus, is this really needed :
> """
> # In some cases older distros do not have this macro defined
> %{!?make_build: %global make_build %{__make} %{?_smp_mflags} }
> """

A stock CentOS 6 does not have this macro defined in the rpm macro file.
Instead, one must install the "epel-rpm-macros" package which defines
%make_build. This won't affect the rpmfusion build system, and there is only a
small chance an end user might run into if/when building locally. i.e. me.
In any case, I've gone ahead and removed the line in question from the spec
file as I don't think it is worth adding epel-rpm-macros as a centos6-only
buildrequires.


> - I believe the with_php_mysqlnd and with_php_mysql can be replaced by a
> simple "Requires: php-mysqli" which is a virtual provides for the proper
> package depending on the distro/release.
> 

There does not appear to be php-mysqli package in fedora or rhel. dnf/yum
install/whatprovides returns no package found. 

> - Isn't "%global _hardened_build 1" the default anyway ?
>   

This became the default beginning with F23, but it is not the default in EL7.
I've gone ahead and removed it from the specfile. I'm not sure this had any
effect on EL7 anyway since the macro definition is commented out in the rpm
macro file on EL7.

> - Source: should be a full URL. I realize that 1.30.1 was not released nor
> even tagged, I assume that's the reason, but this needs to be fixed. You
> might also want to use the more common Source0 rather than Source.
> 

Completed.

> - Multiple (Build)Requires: on one line are not very legible.
> 

Completed.

> - The added Requires: are most probably already auto-detected at build time.
> Only add the ones that are not autodetected, if any.
> 

After building zoneminder with the current list of Requires and then again
without any of them, I did a comparison. I was able to remove a few unnecessary
Requires. The Requires still showing in the specfile are not auto-detected and
definitely are needed for zoneminder to function correctly. Some packages are
easy to explain why rpm could not autodetect them while others, like the perl
modules, I can't explain at all why rpm did not pick them up. We can go through
them one by one, if you really want to.

> - Unless I'm missing something
> """
> %dir %{_libexecdir}/zoneminder
> %{_libexecdir}/zoneminder/cgi-bin
> %dir %{_datadir}/zoneminder
> %{_datadir}/zoneminder/db
> %{_datadir}/zoneminder/www
> """
>   can be written as
> """
> %{_libexecdir}/zoneminder/
> %{_datadir}/zoneminder/
> """

Completed.

> - Use macros in the paths for 
> %dir %attr(755,%{zmuid_final},%{zmgid_final}) /var/log/zoneminder
> %dir %attr(755,%{zmuid_final},%{zmgid_final}) /var/spool/zoneminder-upload
> %dir %attr(755,%{zmuid_final},%{zmgid_final}) %ghost /var/run/zoneminder
> 

Completed.

> - No need to use %attr(644,root,root) or %attr(755,root,root), this is the
> default (unless the install script don't do the right thing).
> 
> 

I still need to verify this. In the past there have been issues with
permissions on certain files not being set correctly, which is why they are
being forced in the specfile. We have since switched to building with cmake,
rather than make, and I have not verified what still needs to be forced and
what does not.


location of latest specfile:
https://github.com/ZoneMinder/ZoneMinder/blob/master/distros/redhat/zoneminder.spec

same thing, just raw text:
https://raw.githubusercontent.com/ZoneMinder/ZoneMinder/master/distros/redhat/zoneminder.spec

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.___
rpmfusion-developers mailing list -- rpmfusion-developers@lists.rpmfusion.org
To unsubscribe send an email to rpmfusion-developers-le...@lists.rpmfusion.org

[Bug 4393] Review Request: zoneminder - A camera monitoring and analysis tool

[RPM Fusion Bugzilla]

https://bugzilla.rpmfusion.org/show_bug.cgi?id=4393

--- Comment #20 from Andrew Bauer  ---
I can absolutely knock those those changes out, but what follows are some
questions to help get it right in one pass.

(In reply to Xavier Bachelot from comment #19)
> - Would it be possible to have one sub-package for httpd and another for
> nginx ? 

Building a zoneminder-nginx package is brand new, has only been tested on my
raspberry pi, and I am not yet aware of a demand for this, although I suspect
there will be a demand once others get wind of it. What I'm getting at is I
don't see nginx support as something we need to implement initially. Are you
okay with leaving these unused bits in the specfile for now or would you rather
I finish this work sooner rather than later?

A sub-package build has definitely been on my mind for some time now, for a
number of reasons. An installed ZoneMinder package runs under the name of the
web account user, so as you might expect, during the build, file/folder
permissions, config file entries, and database entries are set to that account
name. What I have not yet taken the time to do is determine an elegant,
non-hackish, way to crank out a zoneminder-apache and zoneminder-nginx package
in a single pass. If this description sounds like another package you are
already aware of, then by all means let me know. I'll take a look at that spec
file to see if there is anything I can borrow.


> - Isn't "%global _hardened_build 1" the default anyway ?
>   

I added this a couple years ago at the request of a Fedora packager. At the
time, it was definitely not set, as I had to make a change upstream to get zm
to build successfully with this on. Maybe it is today? I can ping the guy who
requested this and see if he can shed some light.

> - Source: should be a full URL. I realize that 1.30.1 was not released nor
> even tagged, I assume that's the reason, but this needs to be fixed. You
> might also want to use the more common Source0 rather than Source.
> 

I can certainly set that to a full url, but just to confirm, since zoneminder
uses a git submodule, would this be what you had in mind?
https://fedoraproject.org/wiki/Packaging:SourceURL?rd=Packaging/SourceURL#Git_Submodules

Which basically means set the submodule up as Source1, unpack it, and then move
it into submodule target folder.


All the rest of the changes seem like merely coding style changes, and I'll
knock them out as time permits.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.___
rpmfusion-developers mailing list -- rpmfusion-developers@lists.rpmfusion.org
To unsubscribe send an email to rpmfusion-developers-le...@lists.rpmfusion.org

[Bug 4393] Review Request: zoneminder - A camera monitoring and analysis tool

[RPM Fusion Bugzilla]

https://bugzilla.rpmfusion.org/show_bug.cgi?id=4393

--- Comment #19 from Xavier Bachelot  ---
A couple more comments on the spec...

- Which supported distro/releases don't have %make_build ?
  Thus, is this really needed :
"""
# In some cases older distros do not have this macro defined
%{!?make_build: %global make_build %{__make} %{?_smp_mflags} }
"""

- Would it be possible to have one sub-package for httpd and another for nginx
? 

- I believe the with_php_mysqlnd and with_php_mysql can be replaced by a simple
"Requires: php-mysqli" which is a virtual provides for the proper package
depending on the distro/release.

- Isn't "%global _hardened_build 1" the default anyway ?

- Source: should be a full URL. I realize that 1.30.1 was not released nor even
tagged, I assume that's the reason, but this needs to be fixed. You might also
want to use the more common Source0 rather than Source.

- Multiple (Build)Requires: on one line are not very legible.

- The added Requires: are most probably already auto-detected at build time.
Only add the ones that are not autodetected, if any.

- Unless I'm missing something
"""
%dir %{_libexecdir}/zoneminder
%{_libexecdir}/zoneminder/cgi-bin
%dir %{_datadir}/zoneminder
%{_datadir}/zoneminder/db
%{_datadir}/zoneminder/www
"""
  can be written as
"""
%{_libexecdir}/zoneminder/
%{_datadir}/zoneminder/
"""
  The directories and files below will be owned too. Also notice the ending /,
this is often used to make it more obvious this is a directory.

- Same for 
  """
%dir %attr(755,%{zmuid_final},%{zmgid_final}) %{_sharedstatedir}/zoneminder
%dir %attr(755,%{zmuid_final},%{zmgid_final})
%{_sharedstatedir}/zoneminder/events
%dir %attr(755,%{zmuid_final},%{zmgid_final})
%{_sharedstatedir}/zoneminder/images
%dir %attr(755,%{zmuid_final},%{zmgid_final})
%{_sharedstatedir}/zoneminder/sock
%dir %attr(755,%{zmuid_final},%{zmgid_final})
%{_sharedstatedir}/zoneminder/swap
%dir %attr(755,%{zmuid_final},%{zmgid_final})
%{_sharedstatedir}/zoneminder/temp
  """

- Use macros in the paths for 
%dir %attr(755,%{zmuid_final},%{zmgid_final}) /var/log/zoneminder
%dir %attr(755,%{zmuid_final},%{zmgid_final}) /var/spool/zoneminder-upload
%dir %attr(755,%{zmuid_final},%{zmgid_final}) %ghost /var/run/zoneminder

- No need to use %attr(644,root,root) or %attr(755,root,root), this is the
default (unless the install script don't do the right thing).


Short on time now, maybe more comments later...

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.___
rpmfusion-developers mailing list -- rpmfusion-developers@lists.rpmfusion.org
To unsubscribe send an email to rpmfusion-developers-le...@lists.rpmfusion.org

[Bug 4393] Review Request: zoneminder - A camera monitoring and analysis tool

[RPM Fusion Bugzilla]

https://bugzilla.rpmfusion.org/show_bug.cgi?id=4393

--- Comment #18 from Xavier Bachelot  ---
No worries, keep on learning, you are on the right track :-)

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.___
rpmfusion-developers mailing list -- rpmfusion-developers@lists.rpmfusion.org
To unsubscribe send an email to rpmfusion-developers-le...@lists.rpmfusion.org

[Bug 4393] Review Request: zoneminder - A camera monitoring and analysis tool

[RPM Fusion Bugzilla]

https://bugzilla.rpmfusion.org/show_bug.cgi?id=4393

--- Comment #17 from Andrew Bauer  ---
You bet. These are my first two Fedora package requests:

perl-X10: https://bugzilla.redhat.com/show_bug.cgi?id=1409869

perl-Astro-SunTime: https://bugzilla.redhat.com/show_bug.cgi?id=1409866

I was sponsored as a Fedora packager two days ago and am still in a learning
curve.

As one can see from these reports I've got some work to do, which I will
resolve soon. My goal is to go through the experience of these two review
processes before proceeding with any additional new package requests. brain =
full.

However, if anyone is interested, the next step will be to get perl-SOAP-WSDL
and its dependencies perl-Class-Std-Fast and perl-IO-Socket-Multicast
submitted.

SRPMS are here:
https://zmrepo.zoneminder.com/f/25/SRPMS/perl-SOAP-WSDL-3.003-3.fc25.src.rpm
https://zmrepo.zoneminder.com/f/25/SRPMS/perl-IO-Socket-Multicast-1.12-1.fc25.src.rpm
https://zmrepo.zoneminder.com/f/25/SRPMS/perl-Class-Std-Fast-0.0.8-3.fc25.src.rpm

Unfortunately, the situation is more complicated with EPEL 6 & 7. There are
several more packages these distros require, which are not yet in all the right
repos. I've started the process with some of the these by contacting the
respective package maintainers. Feedback has been well received, and I even
wound up becoming the new owner of perl-sys-mmap.

I can provide a specific list of packages needed for EPEL 6 & 7, or we can just
focus on ZoneMinder on Fedora for now. Let me know how you wish to proceed.

With all that said, if anyone wants to install zoneminder today, then you can
get any missing dependencies from zmrepo.zoneminder.com. 

I get it, if this all sounds like I've got the cart before the horse, and I
understand completely that we really can't host zoneminder in rpmfusion until
all the dependency issues are ironed out.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.___
rpmfusion-developers mailing list -- rpmfusion-developers@lists.rpmfusion.org
To unsubscribe send an email to rpmfusion-developers-le...@lists.rpmfusion.org

[Bug 4393] Review Request: zoneminder - A camera monitoring and analysis tool

[RPM Fusion Bugzilla]

https://bugzilla.rpmfusion.org/show_bug.cgi?id=4393

--- Comment #16 from Xavier Bachelot  ---
Answering myself :
perl-X10   : https://bugzilla.redhat.com/show_bug.cgi?id=1409869
perl-Astro-SunTime : https://bugzilla.redhat.com/show_bug.cgi?id=1409866

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.___
rpmfusion-developers mailing list -- rpmfusion-developers@lists.rpmfusion.org
To unsubscribe send an email to rpmfusion-developers-le...@lists.rpmfusion.org

[Bug 4393] Review Request: zoneminder - A camera monitoring and analysis tool

[RPM Fusion Bugzilla]

https://bugzilla.rpmfusion.org/show_bug.cgi?id=4393

--- Comment #15 from Xavier Bachelot  ---
Can you please provide links to the review requests for the missing perl
modules ? perl-Astro-Suntime at least, others if any.

Error: nothing provides perl(Astro::SunTime) needed by
zoneminder-1.30.1-2.fc25.x86_64

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.___
rpmfusion-developers mailing list -- rpmfusion-developers@lists.rpmfusion.org
To unsubscribe send an email to rpmfusion-developers-le...@lists.rpmfusion.org

[Bug 4393] Review Request: zoneminder - A camera monitoring and analysis tool

[RPM Fusion Bugzilla]

https://bugzilla.rpmfusion.org/show_bug.cgi?id=4393

--- Comment #14 from Andrew Bauer  ---
A new SRPM and specfile is ready for peer review:

srpm:
https://zmrepo.zoneminder.com/f/testing/25/SRPMS/zoneminder-1.30.1-2.fc25.src.rpm

spec:
https://raw.githubusercontent.com/ZoneMinder/ZoneMinder/master/distros/redhat/zoneminder.spec

Here is a summary of what has changed:

specfile changes
- %setup -> %autosetup
- make -> %make_build
- export DESTDIR, make install -> %make_install
- remove %defattr from %files
- removed %global zmuid & %global zmgid
- moved COPYING to %license
- Add BuildRequires perl-generators

systemd service file & tmpfiles.d changes
- remove quotes from PIDFile reference
- add RuntimeDirectory=zoneminder & RuntimeDirectoryMode=0755
- add Group=apache
- remove runtime folder from tmpfiles.d

After installing the package on a fresh vm running F25, I verified the
following has been corrected:

- The systemd service file now auto-creates the runtime folder if it does not
exist, and zoneminder starts properly

- Perl dependencies are now being properly discovered

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.___
rpmfusion-developers mailing list -- rpmfusion-developers@lists.rpmfusion.org
To unsubscribe send an email to rpmfusion-developers-le...@lists.rpmfusion.org

[Bug 4393] Review Request: zoneminder - A camera monitoring and analysis tool

[RPM Fusion Bugzilla]

https://bugzilla.rpmfusion.org/show_bug.cgi?id=4393

--- Comment #13 from Andrew Bauer  ---
Excellent feedback. Seems we are getting some momentum.

I am part of the upstream development team and will push the changes concerning
runtimedirectory.

I'm falling behind with everything stated here, but it seems Xavier solved all
the issues I've been having on f25 with package dependencies. perl-generators
was the missing element. I don't understand why Fedora's own packages don't
have this buildrequires in their spec files, but I'll let that remain a mystery
for now.

I think I've got enough feedback to generate a new spec file and srpm. I'll get
a new one out this week which incorporates everything stated thus far.

@Damian - Thank you for the offer to submit X10 and AstroSunTime to Fedora.
However, the spec files are, for lack of a better description, terrible. Last
night I rewrote the spec files and have them hosted in my copr repo:
https://copr.fedorainfracloud.org/coprs/kni/zoneminder_deps/

However, as you noticed, they too are missing perl-generators, and I need to
rebuild them. I should be able to get these updated today. I'll see if I can
get these submitted to Fedora. I've got a sponsor, and since these are
relatively simple, I thought it would make a good first time experience.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.___
rpmfusion-developers mailing list -- rpmfusion-developers@lists.rpmfusion.org
To unsubscribe send an email to rpmfusion-developers-le...@lists.rpmfusion.org

[Bug 4393] Review Request: zoneminder - A camera monitoring and analysis tool

[RPM Fusion Bugzilla]

https://bugzilla.rpmfusion.org/show_bug.cgi?id=4393

--- Comment #12 from Damian Wrobel  ---
(In reply to Andrew Bauer from comment #9)
> (In reply to Damian Wrobel from comment #8)
> > 
> > 2) Missing directory for pid file:
> > Creating /var/run/zoneminer directory accessible for httpd daemon solved it.
> > 
> 
> ZoneMinder uses tmpfiles.d to create the runtime folder. It should have
> happened automatically during package installation. Perhaps the command to
> force tmpfiles.d to update immediately w/o reboot went missing from %post. I
> can look.
> 

It practise it doesn't work without /var/run/zoneminder directory:

a) remove existing directory (the one that I had to manually create):

# systemctl stop zoneminder
# mv /var/run/zoneminder /var/run/zoneminder.orig
# systemctl start zoneminer
Job for zoneminder.service failed because the control process exited with error
code.
See "systemctl status zoneminder.service" and "journalctl -xe" for details.
# journalctl -b | grep zmpkg | tail -n 1
Jan 02 18:53:39 dw zmpkg[11411]: FAT [Can't create missing temporary directory
'/var/run/zoneminder': Permission denied]

b) restore missing directory:

# mv /var/run/zoneminder.orig /var/run/zoneminder
# systemctl start zoneminer
# journalctl -b | grep zmpkg  | tail -n 3
Jan 02 18:57:46 dw zmpkg[12604]: INF [Sanity checking States table...]
Jan 02 18:57:46 dw zmpkg[12604]: INF [Command: start]
Jan 02 18:57:50 dw zmpkg[12604]: INF [Single server configuration detected.
Starting up services.]


>Is your entire build output available for viewing anywhere?
Unfortunately I don't have it. I've just used:

$ dnf builddeb to get list of dependencies + created on my own the two missing
perl packages (those ones from zmrepo seemed to be broken - they also misses
perl-generators):

-
https://dwrobel.fedorapeople.org/projects/rpmbuild/SRPMS/perl-Astro-SunTime-0.01-1.fc25.src.rpm
-
https://dwrobel.fedorapeople.org/projects/rpmbuild/SRPMS/perl-X10-0.03-1.fc25.src.rpm

I'll try to submit them for fedora, if time permits.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.___
rpmfusion-developers mailing list -- rpmfusion-developers@lists.rpmfusion.org
To unsubscribe send an email to rpmfusion-developers-le...@lists.rpmfusion.org

[Bug 4393] Review Request: zoneminder - A camera monitoring and analysis tool

[RPM Fusion Bugzilla]

https://bugzilla.rpmfusion.org/show_bug.cgi?id=4393

Tomasz Torcz  changed:

   What|Removed |Added

 CC||zdzi...@irc.pl

--- Comment #11 from Tomasz Torcz  ---
> ZoneMinder uses tmpfiles.d to create the runtime folder. It should have 
> happened
> automatically during package installation. Perhaps the command to force
> tmpfiles.d to update immediately w/o reboot went missing from %post. I can 
> look.

This looks like a job for RuntimeDirectory= in unit file. Can you talk with
upstream to include it in unit file and drop the tmpfiles line?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.___
rpmfusion-developers mailing list -- rpmfusion-developers@lists.rpmfusion.org
To unsubscribe send an email to rpmfusion-developers-le...@lists.rpmfusion.org

[Bug 4393] Review Request: zoneminder - A camera monitoring and analysis tool

[RPM Fusion Bugzilla]

https://bugzilla.rpmfusion.org/show_bug.cgi?id=4393

Xavier Bachelot  changed:

   What|Removed |Added

 CC||xav...@bachelot.org

--- Comment #10 from Xavier Bachelot  ---
(In reply to Andrew Bauer from comment #9)
> I can manually add these to Requires if I have to, but I think there is
> something else going on here.
> 
> These Requires should be picked up automatically during the build process
> and should look like this:
> https://gist.github.com/knnniggett/4811c111a692f585d6b40a4e5f29e564
> 
> However, I've noticed that only on F25, my builds both locally and on copr
> are not getting their requires & provides set properly. Don't know what the
> problem is yet, but it does not seem to be isolated to zoneminder. Perhaps
> there is some change in F25 that I am not yet aware of.

Missing BuildRequires on perl-generators ?
https://fedoraproject.org/wiki/Packaging:Perl

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.___
rpmfusion-developers mailing list -- rpmfusion-developers@lists.rpmfusion.org
To unsubscribe send an email to rpmfusion-developers-le...@lists.rpmfusion.org

[Bug 4393] Review Request: zoneminder - A camera monitoring and analysis tool

[RPM Fusion Bugzilla]

https://bugzilla.rpmfusion.org/show_bug.cgi?id=4393

--- Comment #9 from Andrew Bauer  ---
(In reply to Damian Wrobel from comment #8)
> Please find a few additional comments from an attempt to run version:
> 1.30.1-1 on a new F25:
> 
> 1) /usr/lib/systemd/system/zoneminder.service:14] Not an absolute path,
> ignoring: "/var/run/zoneminder/zm.pid"
> 
> The following change helped:
> 
> -PIDFile="/var/run/zoneminder/zm.pid"
> +PIDFile=/var/run/zoneminder/zm.pid
> 

Thank you. Change has been committed upstream:
https://github.com/ZoneMinder/ZoneMinder/commit/c594ad8be7943f2dac3b331116d827e82252ac9b

> 
> 2) Missing directory for pid file:
> Creating /var/run/zoneminer directory accessible for httpd daemon solved it.
> 

ZoneMinder uses tmpfiles.d to create the runtime folder. It should have
happened automatically during package installation. Perhaps the command to
force tmpfiles.d to update immediately w/o reboot went missing from %post. I
can look.

https://github.com/ZoneMinder/ZoneMinder/blob/master/distros/redhat/systemd/zoneminder.tmpfiles.in


> 
> 3) ERR ['zmtelemetry.pl' exited abnormally, exit status 9]
> 
> I had to install the following missing packages mentioned here[1] to make it
> working:
> perl-IO-Socket-SSL
> perl-Sys-CPU
> perl-Sys-MemInfo
> 
> [1] https://forums.zoneminder.com/viewtopic.php?t=24389#p93112

That forum thread was from an Ubuntu user so missing packages can be expected
when building against master, since the deb packaging process does not have the
auto-requires ability rpm does.

Is your entire build output available for viewing anywhere?
Can you try this on F24?

I can manually add these to Requires if I have to, but I think there is
something else going on here.

These Requires should be picked up automatically during the build process and
should look like this:
https://gist.github.com/knnniggett/4811c111a692f585d6b40a4e5f29e564

However, I've noticed that only on F25, my builds both locally and on copr are
not getting their requires & provides set properly. Don't know what the problem
is yet, but it does not seem to be isolated to zoneminder. Perhaps there is
some change in F25 that I am not yet aware of.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.___
rpmfusion-developers mailing list -- rpmfusion-developers@lists.rpmfusion.org
To unsubscribe send an email to rpmfusion-developers-le...@lists.rpmfusion.org

[Bug 4393] Review Request: zoneminder - A camera monitoring and analysis tool

[RPM Fusion Bugzilla]

https://bugzilla.rpmfusion.org/show_bug.cgi?id=4393

Damian Wrobel  changed:

   What|Removed |Added

 CC||dwro...@ertelnet.rybnik.pl

--- Comment #8 from Damian Wrobel  ---
Please find a few additional comments from an attempt to run version: 1.30.1-1
on a new F25:

1) /usr/lib/systemd/system/zoneminder.service:14] Not an absolute path,
ignoring: "/var/run/zoneminder/zm.pid"

The following change helped:

-PIDFile="/var/run/zoneminder/zm.pid"
+PIDFile=/var/run/zoneminder/zm.pid


2) Missing directory for pid file:
Creating /var/run/zoneminer directory accessible for httpd daemon solved it.


3) ERR ['zmtelemetry.pl' exited abnormally, exit status 9]

I had to install the following missing packages mentioned here[1] to make it
working:
perl-IO-Socket-SSL
perl-Sys-CPU
perl-Sys-MemInfo

[1] https://forums.zoneminder.com/viewtopic.php?t=24389#p93112

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.___
rpmfusion-developers mailing list -- rpmfusion-developers@lists.rpmfusion.org
To unsubscribe send an email to rpmfusion-developers-le...@lists.rpmfusion.org

[Bug 4393] Review Request: zoneminder - A camera monitoring and analysis tool

[RPM Fusion Bugzilla]

https://bugzilla.rpmfusion.org/show_bug.cgi?id=4393

--- Comment #7 from Andrew Bauer  ---
(In reply to Vasiliy Glazov from comment #4)
> CentOS/RHEL 6 must have %make_build macro. You not need to define it
> manually.

I took a harder look at where %make_build might get defined on CentOS6. It does
not ship with the stock rpm package like newer redhat distros. Instead, the
macro definition is part of the epel-rpm-macros package. There we go. Mystery
solved.

(In reply to Vasiliy Glazov from comment #5)
> Next suggestions:
> 1. %global zmuid $(id -un)
> %global zmgid $(id -gn)
> Not used and can be removed.
> 
> 2. If COPYING - is a license text it must be not in %doc, but
> %license COPYING

Good catch. These changes have been applied.


(In reply to Vasiliy Glazov from comment #6)
> And it is realy require vlc-devel?

There are currently no Requires for vlc-devel in the spec file, but there are
BuildRequires for vlc-devel and ffmpeg-devel. ZoneMinder searches for the
header files of these libraries, and, it if finds them, it links against them.
Currently, if it does not find them, it excludes the code that makes ffmpeg
and/or vlc api calls. In the future, zoneminder's dependence on ffmpeg will
likely become required instead of optional. As a side note, today, zoneminder
can be built w/o ffmpeg support, but that makes zoneminder incompatible with
nearly all modern ip cameras (i.e. virtually useless). This happens to be the
driving force behind why Fedora understandably does not intend to host
zoneminder any longer.


(In reply to Dominik 'Rathann' Mierzejewski from comment #3)
> (In reply to Vasiliy Glazov from comment #1)
> [...]
> > 5. In %files section use %{_bindir}/* instead of one string for each file.
> 
> Sorry, but I don't agree with using wildcards unless there are many files
> there. You won't notice any new files there easily unless you run rpmdiff on
> the final package or check manually. You don't have to save every single
> byte of the spec file. It's better to be a little verbose and a lot more
> legible.

Since zoneminder has 19 executables, I tend to agree with this. I think showing
each executable under %files adds value.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.___
rpmfusion-developers mailing list -- rpmfusion-developers@lists.rpmfusion.org
To unsubscribe send an email to rpmfusion-developers-le...@lists.rpmfusion.org

[Bug 4393] Review Request: zoneminder - A camera monitoring and analysis tool

[RPM Fusion Bugzilla]

https://bugzilla.rpmfusion.org/show_bug.cgi?id=4393

--- Comment #6 from Vasiliy Glazov  ---
And it is realy require vlc-devel?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.___
rpmfusion-developers mailing list -- rpmfusion-developers@lists.rpmfusion.org
To unsubscribe send an email to rpmfusion-developers-le...@lists.rpmfusion.org

[Bug 4393] Review Request: zoneminder - A camera monitoring and analysis tool

[RPM Fusion Bugzilla]

https://bugzilla.rpmfusion.org/show_bug.cgi?id=4393

--- Comment #5 from Vasiliy Glazov  ---
Next suggestions:
1. %global zmuid $(id -un)
%global zmgid $(id -gn)
Not used and can be removed.

2. If COPYING - is a license text it must be not in %doc, but
%license COPYING

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.___
rpmfusion-developers mailing list -- rpmfusion-developers@lists.rpmfusion.org
To unsubscribe send an email to rpmfusion-developers-le...@lists.rpmfusion.org

[Bug 4393] Review Request: zoneminder - A camera monitoring and analysis tool

[RPM Fusion Bugzilla]

https://bugzilla.rpmfusion.org/show_bug.cgi?id=4393

--- Comment #4 from Vasiliy Glazov  ---
(In reply to Andrew Bauer from comment #2)
> I noticed that my centos 6 environment did not have the %make_build macro so
> I defined it at the top of the specfile should it not exist at build time.


CentOS/RHEL 6 must have %make_build macro. You not need to define it manually.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.___
rpmfusion-developers mailing list -- rpmfusion-developers@lists.rpmfusion.org
To unsubscribe send an email to rpmfusion-developers-le...@lists.rpmfusion.org

[Bug 4393] Review Request: zoneminder - A camera monitoring and analysis tool

[RPM Fusion Bugzilla]

https://bugzilla.rpmfusion.org/show_bug.cgi?id=4393

Dominik 'Rathann' Mierzejewski  changed:

   What|Removed |Added

 CC||domi...@greysector.net

--- Comment #3 from Dominik 'Rathann' Mierzejewski  ---
(In reply to Vasiliy Glazov from comment #1)
[...]
> 5. In %files section use %{_bindir}/* instead of one string for each file.

Sorry, but I don't agree with using wildcards unless there are many files
there. You won't notice any new files there easily unless you run rpmdiff on
the final package or check manually. You don't have to save every single byte
of the spec file. It's better to be a little verbose and a lot more legible.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.___
rpmfusion-developers mailing list -- rpmfusion-developers@lists.rpmfusion.org
To unsubscribe send an email to rpmfusion-developers-le...@lists.rpmfusion.org

[Bug 4393] Review Request: zoneminder - A camera monitoring and analysis tool

[RPM Fusion Bugzilla]

https://bugzilla.rpmfusion.org/show_bug.cgi?id=4393

--- Comment #2 from Andrew Bauer  ---
Thank you for the feedback. I have made all five suggested changes.

I noticed that my centos 6 environment did not have the %make_build macro so I
defined it at the top of the specfile should it not exist at build time.

The latest specfile can be found here:
https://gist.github.com/knnniggett/cf2e4e2169ed8d4147b6367d6a60a843

Unless otherwise requested, I will wait for additional feedback before
uploading a new RPM/SRPM.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.___
rpmfusion-developers mailing list -- rpmfusion-developers@lists.rpmfusion.org
To unsubscribe send an email to rpmfusion-developers-le...@lists.rpmfusion.org

[Bug 4393] Review Request: zoneminder - A camera monitoring and analysis tool

[RPM Fusion Bugzilla]

https://bugzilla.rpmfusion.org/show_bug.cgi?id=4393

Vasiliy Glazov  changed:

   What|Removed |Added

 CC||vasc...@gmail.com

--- Comment #1 from Vasiliy Glazov  ---
1. You should change %setup -q to %autosetup

2. make %{?_smp_mflags} to %make_build

3. export DESTDIR=%{buildroot}
make install
to %make_install

4. Remove 
%defattr(-,root,root,-)

5. In %files section use %{_bindir}/* instead of one string for each file.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.___
rpmfusion-developers mailing list -- rpmfusion-developers@lists.rpmfusion.org
To unsubscribe send an email to rpmfusion-developers-le...@lists.rpmfusion.org