[Bug 4532] Review request: kodi-inputstream-adaptive - Adaptive file addon for Kodi's InputStream interface

[RPM Fusion Bugzilla]

https://bugzilla.rpmfusion.org/show_bug.cgi?id=4532

Nicolas Chauvet  changed:

   What|Removed |Added

 Status|ASSIGNED|RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are on the CC list for the bug.___
rpmfusion-developers mailing list -- rpmfusion-developers@lists.rpmfusion.org
To unsubscribe send an email to rpmfusion-developers-le...@lists.rpmfusion.org

[Bug 4532] Review request: kodi-inputstream-adaptive - Adaptive file addon for Kodi's InputStream interface

[RPM Fusion Bugzilla]

https://bugzilla.rpmfusion.org/show_bug.cgi?id=4532

--- Comment #36 from Nicolas Chauvet  ---
(In reply to Dominic Robinson from comment #35)
...
> Is that all I need to do? I note they are not listed here, as suggested by
> the documentation:
I try to push packages 2/3 times a week.
First time the package goes into testing, the second time into stable.
If there is anything broken, please warn.

-- 
You are receiving this mail because:
You are on the CC list for the bug.___
rpmfusion-developers mailing list -- rpmfusion-developers@lists.rpmfusion.org
To unsubscribe send an email to rpmfusion-developers-le...@lists.rpmfusion.org

[Bug 4532] Review request: kodi-inputstream-adaptive - Adaptive file addon for Kodi's InputStream interface

[RPM Fusion Bugzilla]

https://bugzilla.rpmfusion.org/show_bug.cgi?id=4532

--- Comment #35 from Dominic Robinson  
---
Ok thanks - working now.

So I've pushed to all branches, requested builds for those branches and those
builds have succeeded:

http://koji.rpmfusion.org/koji/packageinfo?packageID=508

Is that all I need to do? I note they are not listed here, as suggested by the
documentation:
http://koji.rpmfusion.org/mash/

-- 
You are receiving this mail because:
You are on the CC list for the bug.___
rpmfusion-developers mailing list -- rpmfusion-developers@lists.rpmfusion.org
To unsubscribe send an email to rpmfusion-developers-le...@lists.rpmfusion.org

[Bug 4532] Review request: kodi-inputstream-adaptive - Adaptive file addon for Kodi's InputStream interface

[RPM Fusion Bugzilla]

https://bugzilla.rpmfusion.org/show_bug.cgi?id=4532

Nicolas Chauvet  changed:

   What|Removed |Added

  Flags|needinfo-   |

--- Comment #34 from Nicolas Chauvet  ---
Okay, this time it was the Fas sync script that didn't worked.
fixed.

-- 
You are receiving this mail because:
You are on the CC list for the bug.___
rpmfusion-developers mailing list -- rpmfusion-developers@lists.rpmfusion.org
To unsubscribe send an email to rpmfusion-developers-le...@lists.rpmfusion.org

[Bug 4532] Review request: kodi-inputstream-adaptive - Adaptive file addon for Kodi's InputStream interface

[RPM Fusion Bugzilla]

https://bugzilla.rpmfusion.org/show_bug.cgi?id=4532

--- Comment #33 from Dominic Robinson  
---
Sadly still not liking it:

debug1: Offering RSA public key: /home/dcrdev/.ssh/id_rsa
debug3: send_pubkey_test
debug3: send packet: type 50
debug2: we sent a publickey packet, wait for reply
debug3: receive packet: type 51
debug1: Authentications that can continue: publickey
debug1: Trying private key: /home/dcrdev/.ssh/id_dsa
debug3: no such identity: /home/dcrdev/.ssh/id_dsa: No such file or directory
debug1: Trying private key: /home/dcrdev/.ssh/id_ecdsa
debug3: no such identity: /home/dcrdev/.ssh/id_ecdsa: No such file or directory
debug1: Trying private key: /home/dcrdev/.ssh/id_ed25519
debug3: no such identity: /home/dcrdev/.ssh/id_ed25519: No such file or
directory
debug2: we did not send a packet, disable method
debug1: No more authentication methods to try.
Permission denied (publickey).

-- 
You are receiving this mail because:
You are on the CC list for the bug.___
rpmfusion-developers mailing list -- rpmfusion-developers@lists.rpmfusion.org
To unsubscribe send an email to rpmfusion-developers-le...@lists.rpmfusion.org

[Bug 4532] Review request: kodi-inputstream-adaptive - Adaptive file addon for Kodi's InputStream interface

[RPM Fusion Bugzilla]

https://bugzilla.rpmfusion.org/show_bug.cgi?id=4532

--- Comment #32 from Nicolas Chauvet  ---
(In reply to Dominic Robinson from comment #31)
> It doesn't look like the git server has my public key key authorised? Does
> this take a while?
Fixed by forcing genacls.sh script

-- 
You are receiving this mail because:
You are on the CC list for the bug.___
rpmfusion-developers mailing list -- rpmfusion-developers@lists.rpmfusion.org
To unsubscribe send an email to rpmfusion-developers-le...@lists.rpmfusion.org

[Bug 4532] Review request: kodi-inputstream-adaptive - Adaptive file addon for Kodi's InputStream interface

[RPM Fusion Bugzilla]

https://bugzilla.rpmfusion.org/show_bug.cgi?id=4532

--- Comment #31 from Dominic Robinson  
---
It doesn't look like the git server has my public key key authorised? Does this
take a while?

debug1: Host 'pkgs.rpmfusion.org' is known and matches the RSA host key.
debug1: Found key in /home/dcrdev/.ssh/known_hosts:1
debug3: send packet: type 21
debug2: set_newkeys: mode 1
debug1: rekey after 4294967296 blocks
debug1: SSH2_MSG_NEWKEYS sent
debug1: expecting SSH2_MSG_NEWKEYS
debug3: receive packet: type 21
debug1: SSH2_MSG_NEWKEYS received
debug2: set_newkeys: mode 0
debug1: rekey after 4294967296 blocks
debug2: key: /home/dcrdev/.ssh/id_rsa (0x55e5989f52b0), agent
debug2: key: /home/dcrdev/.ssh/id_dsa ((nil))
debug2: key: /home/dcrdev/.ssh/id_ecdsa ((nil))
debug2: key: /home/dcrdev/.ssh/id_ed25519 ((nil))
debug3: send packet: type 5
debug3: receive packet: type 6
debug2: service_accept: ssh-userauth
debug1: SSH2_MSG_SERVICE_ACCEPT received
debug3: send packet: type 50
debug3: receive packet: type 51
debug1: Authentications that can continue: publickey
debug3: start over, passed a different list publickey
debug3: preferred
gssapi-keyex,gssapi-with-mic,publickey,keyboard-interactive,password
debug3: authmethod_lookup publickey
debug3: remaining preferred: keyboard-interactive,password
debug3: authmethod_is_enabled publickey
debug1: Next authentication method: publickey
debug1: Offering RSA public key: /home/dcrdev/.ssh/id_rsa
debug3: send_pubkey_test
debug3: send packet: type 50
debug2: we sent a publickey packet, wait for reply
debug3: receive packet: type 51
debug1: Authentications that can continue: publickey
debug1: Trying private key: /home/dcrdev/.ssh/id_dsa
debug3: no such identity: /home/dcrdev/.ssh/id_dsa: No such file or directory
debug1: Trying private key: /home/dcrdev/.ssh/id_ecdsa
debug3: no such identity: /home/dcrdev/.ssh/id_ecdsa: No such file or directory
debug1: Trying private key: /home/dcrdev/.ssh/id_ed25519
debug3: no such identity: /home/dcrdev/.ssh/id_ed25519: No such file or
directory
debug2: we did not send a packet, disable method
debug1: No more authentication methods to try.
Permission denied (publickey).

-- 
You are receiving this mail because:
You are on the CC list for the bug.___
rpmfusion-developers mailing list -- rpmfusion-developers@lists.rpmfusion.org
To unsubscribe send an email to rpmfusion-developers-le...@lists.rpmfusion.org

[Bug 4532] Review request: kodi-inputstream-adaptive - Adaptive file addon for Kodi's InputStream interface

[RPM Fusion Bugzilla]

https://bugzilla.rpmfusion.org/show_bug.cgi?id=4532

Dominic Robinson  changed:

   What|Removed |Added

 Blocks|3   |
  Flags|needinfo?(development-K9Rvg |needinfo-
   |hem1omxw...@dcrdev.com) |


Referenced Bugs:

https://bugzilla.rpmfusion.org/show_bug.cgi?id=3
[Bug 3] Tracker: Packages under review.
-- 
You are receiving this mail because:
You are on the CC list for the bug.___
rpmfusion-developers mailing list -- rpmfusion-developers@lists.rpmfusion.org
To unsubscribe send an email to rpmfusion-developers-le...@lists.rpmfusion.org

[Bug 4532] Review request: kodi-inputstream-adaptive - Adaptive file addon for Kodi's InputStream interface

[RPM Fusion Bugzilla]

https://bugzilla.rpmfusion.org/show_bug.cgi?id=4532

--- Comment #30 from Nicolas Chauvet  ---
okay, so this package is formally APPROVED.

I will give the ownership to you.

-- 
You are receiving this mail because:
You are on the CC list for the bug.___
rpmfusion-developers mailing list -- rpmfusion-developers@lists.rpmfusion.org
To unsubscribe send an email to rpmfusion-developers-le...@lists.rpmfusion.org

[Bug 4532] Review request: kodi-inputstream-adaptive - Adaptive file addon for Kodi's InputStream interface

[RPM Fusion Bugzilla]

https://bugzilla.rpmfusion.org/show_bug.cgi?id=4532

--- Comment #29 from Dominic Robinson  
---
(In reply to Nicolas Chauvet from comment #28)
> (In reply to Dominic Robinson from comment #26)
> > Also bit confused - is this package approved, I note the fedora-review +
> > flag and also the repository having been created here:
> Yep, seems like this package was mass imported along the other ones from
> Mohamed.
> I will transfer the ownership to you once this package got formally approved
> can you remind your RPM Fusion FAS account name ?

Yes it's "dcrdev" .

(In reply to Nicolas Chauvet from comment #27)
> (In reply to Dominic Robinson from comment #25)
> > I hadn't planned on changing it -
> > 
> > I mean might be a problem if I reuse this spec for other addons, but I don't
> > see an issue in the context of this addon and makes things neater.
> 
> Well, this is not the case from a RPM Fusion rel-eng perspective.
> If ever the aname is changed, which might happen if the package get fixed ,
> the package name will be automatically changed. This is not possible with
> the infra where koji expect the spec file to be named according to the git
> module name.
> As a consequence, the build will fails, but it may requires additional steps
> to cure this issue.
> 
> For example, upstream may consider to change inputstream.adaptive to
> inputstream_adaptive. So the point of using a variable in this case doesn't
> hold.

OK makes sense - I'll hardcode it to "kodi-inputstream-adaptive" . I'll kick
off a build this evening, as I don't have access to my build system right now.

-- 
You are receiving this mail because:
You are on the CC list for the bug.___
rpmfusion-developers mailing list -- rpmfusion-developers@lists.rpmfusion.org
To unsubscribe send an email to rpmfusion-developers-le...@lists.rpmfusion.org

[Bug 4532] Review request: kodi-inputstream-adaptive - Adaptive file addon for Kodi's InputStream interface

[RPM Fusion Bugzilla]

https://bugzilla.rpmfusion.org/show_bug.cgi?id=4532

--- Comment #28 from Nicolas Chauvet  ---
(In reply to Dominic Robinson from comment #26)
> Also bit confused - is this package approved, I note the fedora-review +
> flag and also the repository having been created here:
Yep, seems like this package was mass imported along the other ones from
Mohamed.
I will transfer the ownership to you once this package got formally approved
can you remind your RPM Fusion FAS account name ?

-- 
You are receiving this mail because:
You are on the CC list for the bug.___
rpmfusion-developers mailing list -- rpmfusion-developers@lists.rpmfusion.org
To unsubscribe send an email to rpmfusion-developers-le...@lists.rpmfusion.org

[Bug 4532] Review request: kodi-inputstream-adaptive - Adaptive file addon for Kodi's InputStream interface

[RPM Fusion Bugzilla]

https://bugzilla.rpmfusion.org/show_bug.cgi?id=4532

--- Comment #27 from Nicolas Chauvet  ---
(In reply to Dominic Robinson from comment #25)
> I hadn't planned on changing it -
> 
> I mean might be a problem if I reuse this spec for other addons, but I don't
> see an issue in the context of this addon and makes things neater.

Well, this is not the case from a RPM Fusion rel-eng perspective.
If ever the aname is changed, which might happen if the package get fixed , the
package name will be automatically changed. This is not possible with the infra
where koji expect the spec file to be named according to the git module name.
As a consequence, the build will fails, but it may requires additional steps to
cure this issue.

For example, upstream may consider to change inputstream.adaptive to
inputstream_adaptive. So the point of using a variable in this case doesn't
hold.

-- 
You are receiving this mail because:
You are on the CC list for the bug.___
rpmfusion-developers mailing list -- rpmfusion-developers@lists.rpmfusion.org
To unsubscribe send an email to rpmfusion-developers-le...@lists.rpmfusion.org

[Bug 4532] Review request: kodi-inputstream-adaptive - Adaptive file addon for Kodi's InputStream interface

[RPM Fusion Bugzilla]

https://bugzilla.rpmfusion.org/show_bug.cgi?id=4532

--- Comment #26 from Dominic Robinson  
---
Also bit confused - is this package approved, I note the fedora-review + flag
and also the repository having been created here:
https://admin.rpmfusion.org/pkgdb/package/free/kodi-inputstream-adaptive/ .

Wasn't I suppose to be the one who requests the package, as it stands I'm not
the maintainer of that repository?

-- 
You are receiving this mail because:
You are on the CC list for the bug.___
rpmfusion-developers mailing list -- rpmfusion-developers@lists.rpmfusion.org
To unsubscribe send an email to rpmfusion-developers-le...@lists.rpmfusion.org

[Bug 4532] Review request: kodi-inputstream-adaptive - Adaptive file addon for Kodi's InputStream interface

[RPM Fusion Bugzilla]

https://bugzilla.rpmfusion.org/show_bug.cgi?id=4532

--- Comment #25 from Dominic Robinson  
---
I hadn't planned on changing it -

I mean might be a problem if I reuse this spec for other addons, but I don't
see an issue in the context of this addon and makes things neater.

-- 
You are receiving this mail because:
You are on the CC list for the bug.___
rpmfusion-developers mailing list -- rpmfusion-developers@lists.rpmfusion.org
To unsubscribe send an email to rpmfusion-developers-le...@lists.rpmfusion.org

[Bug 4532] Review request: kodi-inputstream-adaptive - Adaptive file addon for Kodi's InputStream interface

[RPM Fusion Bugzilla]

https://bugzilla.rpmfusion.org/show_bug.cgi?id=4532

Nicolas Chauvet  changed:

   What|Removed |Added

  Flags|fedora-review?  |fedora-review+

--- Comment #24 from Nicolas Chauvet  ---
(In reply to Dominic Robinson from comment #23)
> I don't see any problem with that per say , but I know for a fact that this
> can only be built against kodi >= 17; for future versions sure.
> 
> So to clear up my limited understanding of koji, how would this work
> exactly? If a koji_version macro were to be defined in the kodi-devel
> package, how would that get passed to this package?
Sorry, I meant a %kodi_version macro. 

It would be defined in the kodi-devel package (
echo %kodi_version %{version} > %{buildroot}%{rpmmacrodir}/macros.kodi
)

Then when plugins would build, they would have:
Requires: kodi >= %{kodi_version}


Anyway, it seems a minor issue and not particular to this plugins. this can be
fixed and coordinated later. 

Do you plan to fix the name with modified macro ? This looks really scary.

-- 
You are receiving this mail because:
You are on the CC list for the bug.___
rpmfusion-developers mailing list -- rpmfusion-developers@lists.rpmfusion.org
To unsubscribe send an email to rpmfusion-developers-le...@lists.rpmfusion.org

[Bug 4532] Review request: kodi-inputstream-adaptive - Adaptive file addon for Kodi's InputStream interface

[RPM Fusion Bugzilla]

https://bugzilla.rpmfusion.org/show_bug.cgi?id=4532

--- Comment #23 from Dominic Robinson  
---
I don't see any problem with that per say , but I know for a fact that this can
only be built against kodi >= 17; for future versions sure.

So to clear up my limited understanding of koji, how would this work exactly?
If a koji_version macro were to be defined in the kodi-devel package, how would
that get passed to this package?

Is it a case of:
- Dependent packages are being built in a single chroot a la mock chain.
- Therefore once koji_version is set, it is exported before all subsequent
builds within that chroot.

-- 
You are receiving this mail because:
You are on the CC list for the bug.___
rpmfusion-developers mailing list -- rpmfusion-developers@lists.rpmfusion.org
To unsubscribe send an email to rpmfusion-developers-le...@lists.rpmfusion.org

[Bug 4532] Review request: kodi-inputstream-adaptive - Adaptive file addon for Kodi's InputStream interface

[RPM Fusion Bugzilla]

https://bugzilla.rpmfusion.org/show_bug.cgi?id=4532

Nicolas Chauvet  changed:

   What|Removed |Added

  Flags||needinfo?(development-K9Rvg
   ||hem1omxw...@dcrdev.com)

--- Comment #22 from Nicolas Chauvet  ---
Ping ?

-- 
You are receiving this mail because:
You are on the CC list for the bug.___
rpmfusion-developers mailing list -- rpmfusion-developers@lists.rpmfusion.org
To unsubscribe send an email to rpmfusion-developers-le...@lists.rpmfusion.org

[Bug 4532] Review request: kodi-inputstream-adaptive - Adaptive file addon for Kodi's InputStream interface

[RPM Fusion Bugzilla]

https://bugzilla.rpmfusion.org/show_bug.cgi?id=4532

Nicolas Chauvet  changed:

   What|Removed |Added

  namespace||free
   Assignee|pikachu.2...@gmail.com  |kwiz...@gmail.com
  Flags||fedora-review?

--- Comment #21 from Nicolas Chauvet  ---
(In reply to Mohamed El Morabity from comment #19)
> Sorry for the late answer. A lot of work at my job unfortunately.
> 
> Your package seems quite good now. Some notes:
> 
> - Fix BR condition on kodi-devel, which should match the one on kodi in
> Requires:
> BuildRequires:  kodi-devel >= %{kodi_version}
It would means the project itslef requires at least this kodi version whereas
it might be possible to build for several kodi version (say 16 and 17 or
later).
What would be needed instead if to enforce a build to be at least >= than the
version of kodi it was built against.
So it means it would be easier if koji_version RPM macro would be defined in
the kodi-devel package so dependent package could use it.

Reviewing the package.

-- 
You are receiving this mail because:
You are on the CC list for the bug.___
rpmfusion-developers mailing list -- rpmfusion-developers@lists.rpmfusion.org
To unsubscribe send an email to rpmfusion-developers-le...@lists.rpmfusion.org

[Bug 4532] Review request: kodi-inputstream-adaptive - Adaptive file addon for Kodi's InputStream interface

[RPM Fusion Bugzilla]

https://bugzilla.rpmfusion.org/show_bug.cgi?id=4532

Nicolas Chauvet  changed:

   What|Removed |Added

Summary|"Review request:|Review request:
   |kodi-inputstream.adaptive - |kodi-inputstream-adaptive -
   |Adaptive file addon for |Adaptive file addon for
   |Kodi's InputStream  |Kodi's InputStream
   |interface   |interface

-- 
You are receiving this mail because:
You are on the CC list for the bug.___
rpmfusion-developers mailing list -- rpmfusion-developers@lists.rpmfusion.org
To unsubscribe send an email to rpmfusion-developers-le...@lists.rpmfusion.org