Re: ffmpeg-4.x compat package
--- Begin Message ---
Leigh Scott wrote:
> This should make it possible to build chrome with ffmpeg.
>
>
https://pkgs.rpmfusion.org/cgit/free/ffmpeg.git/commit/?id=afe251ab706f9a81a446ffb28dac43d8091f3a31
This patch on its own is not going to work for the current qt5-qtwebengine,
the QtWebEngine/Chromium code needs to be modified too to build with FFmpeg
5, because:
1. this patch does not address the "error: invalid conversion from 'const
AVCodec*' to 'AVCodec*'" and "error: cannot convert 'int*' to 'size_t*' {aka
'long unsigned int*'} […] initializing argument 3 of 'uint8_t*
av_packet_get_side_data(const AVPacket*, AVPacketSideDataType, size_t*)'"
that I am also getting, and
2. the patch adds an accessor function for first_dts, whereas QtWebEngine
wants to use the member variable directly.
I guess the latest Chromium has support for FFmpeg 5, but I would have to
backport it to the version (Chromium 87) used in Qt5WebEngine.
Kevin Kofler
___
rpmfusion-developers mailing list -- rpmfusion-developers@lists.rpmfusion.org
To unsubscribe send an email to rpmfusion-developers-le...@lists.rpmfusion.org
--- End Message ---
Re: ffmpeg-4.x compat package
I stripped some bits from the compat package, smb, vmaf, vulkan and more, does that affect compatibility? On 11/02/2022 09:22, Nicolas Chauvet wrote: Le mer. 9 févr. 2022 à 16:10, Kevin Kofler via rpmfusion-developers a écrit : Nicolas Chauvet wrote: There is a consensus to have a compat-ffmpeg4 package starting with ffmpeg 4.3.x (rather than 4.4.x for compatibility reason with one or another package preferring that version), then later go to ffmpeg-4.4.x when possible. Don't we have everything in RPM Fusion building against 4.4 already? Why go backwards? I had a second thought about this comment. While I'm not very sure about which package required the 4.3 ffmpeg, I understand that using 4.4 will at least ease the transition to compat-ffmpeg4 from normal ffmpeg package because the version (and ABI) will be same. So packages that won't build with normal ffmpeg will not requires a rebuild in order not to break with ffmpeg older ABI. Maybe we need to revisit this particular point and rise compat- directly to ffmpeg 4.4.1... Thanks for rising this concern. ___ rpmfusion-developers mailing list -- rpmfusion-developers@lists.rpmfusion.org To unsubscribe send an email to rpmfusion-developers-le...@lists.rpmfusion.org ___ rpmfusion-developers mailing list -- rpmfusion-developers@lists.rpmfusion.org To unsubscribe send an email to rpmfusion-developers-le...@lists.rpmfusion.org
Re: ffmpeg-4.x compat package
Le mer. 9 févr. 2022 à 16:10, Kevin Kofler via rpmfusion-developers a écrit : > > Nicolas Chauvet wrote: > > There is a consensus to have a compat-ffmpeg4 package starting with > > ffmpeg 4.3.x (rather than 4.4.x for compatibility reason with one or > > another package preferring that version), then later go to > > ffmpeg-4.4.x when possible. > > Don't we have everything in RPM Fusion building against 4.4 already? Why go > backwards? I had a second thought about this comment. While I'm not very sure about which package required the 4.3 ffmpeg, I understand that using 4.4 will at least ease the transition to compat-ffmpeg4 from normal ffmpeg package because the version (and ABI) will be same. So packages that won't build with normal ffmpeg will not requires a rebuild in order not to break with ffmpeg older ABI. Maybe we need to revisit this particular point and rise compat- directly to ffmpeg 4.4.1... Thanks for rising this concern. ___ rpmfusion-developers mailing list -- rpmfusion-developers@lists.rpmfusion.org To unsubscribe send an email to rpmfusion-developers-le...@lists.rpmfusion.org
Re: ffmpeg-4.x compat package
On 09/02/2022 15:09, Kevin Kofler via rpmfusion-developers wrote: This should make it possible to build chrome with ffmpeg. https://pkgs.rpmfusion.org/cgit/free/ffmpeg.git/commit/?id=afe251ab706f9a81a446ffb28dac43d8091f3a31 ___ rpmfusion-developers mailing list -- rpmfusion-developers@lists.rpmfusion.org To unsubscribe send an email to rpmfusion-developers-le...@lists.rpmfusion.org
Re: ffmpeg-4.x compat package
Le mer. 9 févr. 2022 à 16:10, Kevin Kofler via rpmfusion-developers a écrit : > > Nicolas Chauvet wrote: > > There is a consensus to have a compat-ffmpeg4 package starting with > > ffmpeg 4.3.x (rather than 4.4.x for compatibility reason with one or > > another package preferring that version), then later go to > > ffmpeg-4.4.x when possible. > > Don't we have everything in RPM Fusion building against 4.4 already? Why go > backwards? > > qt5-qtwebengine-freeworld should build fine both with 4.3 and with 4.4. Not > with 5.0 though. > > I could also switch qt5-qtwebengine-freeworld to bundled FFmpeg though. > Shall I do this for now, until the compat package is ready? Or is bundled > even entirely preferred over using the compat package? Well, the problem when it comes to ffmpeg and libraries is that you can easily pick the "wrong" ffmpeg. Say we have an obs-studio built with ffmpeg-5 and let's assume it also uses qt5-qtwebengine-freeworld that can only use the ffmpeg-4.4. Then we will build a process that can only crash with symbol miss-matches. Bundling ffmpeg might help to avoid this kind of error with the hope it doesn't need to last after f36 GA. ___ rpmfusion-developers mailing list -- rpmfusion-developers@lists.rpmfusion.org To unsubscribe send an email to rpmfusion-developers-le...@lists.rpmfusion.org
Re: ffmpeg-4.x compat package
--- Begin Message --- Nicolas Chauvet wrote: > There is a consensus to have a compat-ffmpeg4 package starting with > ffmpeg 4.3.x (rather than 4.4.x for compatibility reason with one or > another package preferring that version), then later go to > ffmpeg-4.4.x when possible. Don't we have everything in RPM Fusion building against 4.4 already? Why go backwards? qt5-qtwebengine-freeworld should build fine both with 4.3 and with 4.4. Not with 5.0 though. I could also switch qt5-qtwebengine-freeworld to bundled FFmpeg though. Shall I do this for now, until the compat package is ready? Or is bundled even entirely preferred over using the compat package? Kevin Kofler ___ rpmfusion-developers mailing list -- rpmfusion-developers@lists.rpmfusion.org To unsubscribe send an email to rpmfusion-developers-le...@lists.rpmfusion.org --- End Message ---
Re: ffmpeg-4.x compat package
Le mer. 9 févr. 2022 à 12:02, Hans de Goede a écrit : > > Hi All, > > I was wondering if there are any plans to provide a ffmpeg-4.x compat > package given that 5.0 has seen a signficant API break? There is a consensus to have a compat-ffmpeg4 package starting with ffmpeg 4.3.x (rather than 4.4.x for compatibility reason with one or another package preferring that version), then later go to ffmpeg-4.4.x when possible. I prefer using a compat- keyword (despite the fedora guideline) because it further denotes that this is not a fully allowed alternative at one packager choice discretion, but it's an incentive to move to the non-compat normal package. Also a reminder that when it comes to BuildRequires, it might be better to use the plain ffmpeg-devel (or compat-) than the pkgconfig(libavcodec) version (or else). That's because the right package will be ambiguus. Now the remaining question is who to volunteer to make the compat-ffmpeg4 package and review ? Thanks ___ rpmfusion-developers mailing list -- rpmfusion-developers@lists.rpmfusion.org To unsubscribe send an email to rpmfusion-developers-le...@lists.rpmfusion.org
