[Bug 13071] [PATCH] Allow --partial-dir with --inplace
https://bugzilla.samba.org/show_bug.cgi?id=13071 --- Comment #8 from Ben RUBSON --- Wayne, I then just tested your patch, and it works as expected. One thing perhaps, just to be sure. I used an absolute partial-dir path during my tests. It is not deleted after the partial file has been completed and moved to its destination place. Is it intended ? Perhaps you assume that this absolute partial-dir could contain other partial files, or even non rsync-related files ? I'm OK with this behavior, IMO more secure :) Your patch then re-creates the behavior I was looking for / proposed through my patch. Mine was intended to make this feature "compatible" with older clients, which made it a little bit more complex... Yours is more simple, which is better, perfect then, many thanks for having looked into this ! To go further, some reflexions. Let's imagine we use --link-dest and --partial-dir, with this current patch. File2, size 100MB, is sending, while comparing to a nice basis File1 (let's imagine almost perfect matching) found in one of the link-dest directories. Transfer aborts. Partial File2, 10MB, is moved into partial-dir. Transfer restarts, and File2 is sent again, this time comparing to the partial File2 (yes this is what we want here, perfect). But then, perhaps we could have been faster comparing again to File1 instead ? :) Hard choice, and there's no way to know... I tried to address this in the following patch : https://bugzilla.samba.org/show_bug.cgi?id=13083 In this situation, the patch takes both files as basis files, which then can speed-up the transfer. Of course it depends on files' size, checksum speed, remaining data to send etc... The main avantage is in the situation above, where there's a lot of remaining data to send. Thank you again ! Ben -- You are receiving this mail because: You are the QA Contact for the bug. -- Please use reply-all for most replies to avoid omitting the mailing list. To unsubscribe or change options: https://lists.samba.org/mailman/listinfo/rsync Before posting, read: http://www.catb.org/~esr/faqs/smart-questions.html
[Bug 13071] [PATCH] Allow --partial-dir with --inplace
https://bugzilla.samba.org/show_bug.cgi?id=13071 --- Comment #7 from Ben RUBSON --- Wayne, thank you very much for your detailed answer and for your patch proposal. Let me go through this and come back to you shortly. -- You are receiving this mail because: You are the QA Contact for the bug. -- Please use reply-all for most replies to avoid omitting the mailing list. To unsubscribe or change options: https://lists.samba.org/mailman/listinfo/rsync Before posting, read: http://www.catb.org/~esr/faqs/smart-questions.html
Re: commit b936741 breaks compilation on macos
This has now been fixed by 1c7785a. On Sat, 25 Apr 2020 at 23:53, Filipe Maia wrote: > Hi, > > On systems with HAVE_SETATTRLIST, commit b936741 breaks compilation. > This is because do_setattrlist_times hasn't been converted to STRUCT_STAT > *stp. > Here's a small patch to do it. > > Cheers, > Filipe > > PS: I've been playing with IO_BUFFER_SIZE, MAX_MAP_SIZE and WRITE_SIZE. > Any plans to make it configurable at runtime? It seems to make a big > difference for large files on a fast link (about 5x in my case) > -- Please use reply-all for most replies to avoid omitting the mailing list. To unsubscribe or change options: https://lists.samba.org/mailman/listinfo/rsync Before posting, read: http://www.catb.org/~esr/faqs/smart-questions.html
Re: Enabling easier contributions to rsync
I kind of like that rsync isn't mutating into crap at the rate everything else is. -- bkw On Sun, Apr 26, 2020, 2:38 PM Filipe Maia via rsync wrote: > Hi, > > Are there plans to soon move to github or some other place where people > can easily contribute to rsync, making the software discussion more lively > and productive? > I've seen several useful patches being submitted (e.g. faster checksums) > which many others could really use... > > Cheers, > Filipe > -- > Please use reply-all for most replies to avoid omitting the mailing list. > To unsubscribe or change options: > https://lists.samba.org/mailman/listinfo/rsync > Before posting, read: http://www.catb.org/~esr/faqs/smart-questions.html > -- Please use reply-all for most replies to avoid omitting the mailing list. To unsubscribe or change options: https://lists.samba.org/mailman/listinfo/rsync Before posting, read: http://www.catb.org/~esr/faqs/smart-questions.html
