[Bug 13433] out_of_memory in receive_sums on large files

2020-06-24 Thread just subscribed for rsync-qa from bugzilla via rsync
https://bugzilla.samba.org/show_bug.cgi?id=13433

--- Comment #5 from MulticoreNOP  ---
might be related to bug #12769

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
-- 
Please use reply-all for most replies to avoid omitting the mailing list.
To unsubscribe or change options: https://lists.samba.org/mailman/listinfo/rsync
Before posting, read: http://www.catb.org/~esr/faqs/smart-questions.html


[Bug 12769] error allocating core memory buffers (code 22) depending on source file system

2020-06-24 Thread just subscribed for rsync-qa from bugzilla via rsync
https://bugzilla.samba.org/show_bug.cgi?id=12769

--- Comment #11 from MulticoreNOP  ---
I want to add that the original implementation also leads to the following
error:


ERROR: out of memory in flist_expand [sender]
rsync error: error allocating core memory buffers (code 22) at util2.c(106)
[sender=3.1.2]

For me it hit that message for an
rsync --delete-before -H --moreStuff..
at around the 117 million files mark.

The patch fixed that problem for me.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
-- 
Please use reply-all for most replies to avoid omitting the mailing list.
To unsubscribe or change options: https://lists.samba.org/mailman/listinfo/rsync
Before posting, read: http://www.catb.org/~esr/faqs/smart-questions.html


[Bug 12769] error allocating core memory buffers (code 22) depending on source file system

2020-06-24 Thread just subscribed for rsync-qa from bugzilla via rsync
https://bugzilla.samba.org/show_bug.cgi?id=12769

--- Comment #10 from MulticoreNOP  ---
(In reply to Simon Matter from comment #7)
#define MALLOC_MAX 0x1

is greater than uint32-MAX, therefore will overflow and result in an
unpredictable and unfriendly manner.

#define MALLOC_MAX 0xD09DC300
(~3,5GiB) leaves some space to detect a "just too big for this implementation"
and will fail gracefully.

Yet, the real culprit here is the use of "unsigned int" as opposed to size_t.

I therefore propose the attached patch that removes MALLOC_MAX in its entirety
and should allow arrays as big as available virtual memory can support.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
-- 
Please use reply-all for most replies to avoid omitting the mailing list.
To unsubscribe or change options: https://lists.samba.org/mailman/listinfo/rsync
Before posting, read: http://www.catb.org/~esr/faqs/smart-questions.html


[Bug 12769] error allocating core memory buffers (code 22) depending on source file system

2020-06-24 Thread just subscribed for rsync-qa from bugzilla via rsync
https://bugzilla.samba.org/show_bug.cgi?id=12769

MulticoreNOP  changed:

   What|Removed |Added

 CC||multicore...@mailbox.org

--- Comment #9 from MulticoreNOP  ---
Created attachment 16074
  --> https://bugzilla.samba.org/attachment.cgi?id=16074&action=edit
remove MALLOC_MAX from util2.c

change data types from "unsigned int" to "size_t" as it should be and remove
arbitrary size limit.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
-- 
Please use reply-all for most replies to avoid omitting the mailing list.
To unsubscribe or change options: https://lists.samba.org/mailman/listinfo/rsync
Before posting, read: http://www.catb.org/~esr/faqs/smart-questions.html