Re: Premature optimization in f_name_cmp()?
On Sun, 13 Mar 2005, Wayne Davison wrote: On Mon, Mar 14, 2005 at 10:40:00AM +1100, Andrew Bartlett wrote: Is there a way to make this only look at the 'right' part of sorted- flist, given it's sorted, and is this really needed at all? Yeah, that code is really pretty silly. I neglected to test my assumption about how often it would get triggered, and it is actually getting run much more often than expected. Could this be the reason why my rsync 2.6.4pre2 seems to be doing nothing for a long time after it has said how much files it considers ? Would a current CVS checkout have a fix for this so I can verify this ? Is CVS in proper shape currently ? -- dag wieers, [EMAIL PROTECTED], http://dag.wieers.com/ -- [all I want is a warm bed and a kind word and unlimited power] -- To unsubscribe or change options: https://lists.samba.org/mailman/listinfo/rsync Before posting, read: http://www.catb.org/~esr/faqs/smart-questions.html
Re: Premature optimization in f_name_cmp()?
On Mon, Mar 14, 2005 at 06:24:15PM +0100, Dag Wieers wrote: Could this be the reason why my rsync 2.6.4pre2 seems to be doing nothing for a long time after it has said how much files it considers ? Seems like a likely reason. Would a current CVS checkout have a fix for this so I can verify this ? Is CVS in proper shape currently ? Yes, the CVS version (as well as the latest nightly tar file) is in good shape and has this fix. I'm considering releasing what's there as 2.6.4pre3, so if you'd care to try this out, that would be a nice pre- release test for this latest version. ..wayne.. -- To unsubscribe or change options: https://lists.samba.org/mailman/listinfo/rsync Before posting, read: http://www.catb.org/~esr/faqs/smart-questions.html
Re: Premature optimization in f_name_cmp()?
On Mon, Mar 14, 2005 at 10:15:18PM +0100, Dag Wieers wrote: But there seems to be something wrong with the --fuzzy option Yes -- it's a bug in the change I just checked into generator.c to deal with the dirname-pointers change. I've just checked in a fix (and also a test case for the --fuzzy option into the test suite so that I'll catch such a bug sooner). Thanks, ..wayne.. -- To unsubscribe or change options: https://lists.samba.org/mailman/listinfo/rsync Before posting, read: http://www.catb.org/~esr/faqs/smart-questions.html
Re: Premature optimization in f_name_cmp()?
On Mon, 14 Mar 2005, Wayne Davison wrote: On Mon, Mar 14, 2005 at 10:15:18PM +0100, Dag Wieers wrote: But there seems to be something wrong with the --fuzzy option Yes -- it's a bug in the change I just checked into generator.c to deal with the dirname-pointers change. I've just checked in a fix (and also a test case for the --fuzzy option into the test suite so that I'll catch such a bug sooner). Great, thanks a lot once again. I'll check with the tomorrow's nightly build an report back if I find something unusual. I'm checking if rsync with the --fuzzy patch would be a solution together with rsyncable RPM packages to reduce total bandwidth for people mirroring/updating Fedora. There has been a lot of fuss to have patch RPMs introduced, but the gain does not compare with the overall complexity imo. And the --fuzzy patch could be an adequate solution to this, if I understand the concept. BTW it might be useful to have the CVS manual page also included with the online documentation so people can check out new options before they decide to try a development release. (I noticed the current one offered is a bit dated already). Kind regards! -- dag wieers, [EMAIL PROTECTED], http://dag.wieers.com/ -- [all I want is a warm bed and a kind word and unlimited power] -- To unsubscribe or change options: https://lists.samba.org/mailman/listinfo/rsync Before posting, read: http://www.catb.org/~esr/faqs/smart-questions.html
Re: Premature optimization in f_name_cmp()?
On Mon, 14 Mar 2005, Wayne Davison wrote: On Mon, Mar 14, 2005 at 10:15:18PM +0100, Dag Wieers wrote: And the --fuzzy option was my main reason to try out the newer rsync. One other caveat -- the CVS version of rsync has a protocol change in it that makes it incompatible with 2.6.4 pre1/pre2 for certain options: --fuzzy, --compare-dest, --link-dest, --copy-dest, --hard-link, the combination of --inplace --backup, or (only if a partial-file is found by the generator) --partial-dir and --delayed-updates. I recommend just updating all your pre1 or pre2 versions of 2.6.4 to the CVS version at the same time (if you have any). I'm doing that (so to not invalidate my test). It is still --delay-updates, or did the option change name (again) ? Another note: if you want --fuzzy to help you with compressed files that have differing contents, you should use the --rsyncable option to gzip to compress the files. I understood that. RPM 4.4.1-something now creates rsyncable compressed files. I hope Red Hat will finally also ship a zlib that can do rsyncable files (and someone fixes the python zlib bindings as well!) and maybe retrofit the RPM to older releases. (hope) -- dag wieers, [EMAIL PROTECTED], http://dag.wieers.com/ -- [all I want is a warm bed and a kind word and unlimited power] -- To unsubscribe or change options: https://lists.samba.org/mailman/listinfo/rsync Before posting, read: http://www.catb.org/~esr/faqs/smart-questions.html
Re: Premature optimization in f_name_cmp()?
On Mon, 14 Mar 2005, Wayne Davison wrote: On Mon, Mar 14, 2005 at 06:24:15PM +0100, Dag Wieers wrote: Would a current CVS checkout have a fix for this so I can verify this ? Is CVS in proper shape currently ? Yes, the CVS version (as well as the latest nightly tar file) is in good shape and has this fix. I'm considering releasing what's there as 2.6.4pre3, so if you'd care to try this out, that would be a nice pre- release test for this latest version. I can confirm that the odd behaviour is fixed with the latest nigthly build. But there seems to be something wrong with the --fuzzy option still: Starting remote synchronisation. [EMAIL PROTECTED]'s password: building file list ... 241923 files to consider rsync: connection unexpectedly closed (8 bytes received so far) [sender] rsync error: error in rsync protocol data stream (code 12) at io.c(420) And the --fuzzy option was my main reason to try out the newer rsync. I thought I'd seen previous mails with the exact same message (and 8 bytes :)) but can't find them now. This is perfectly reproducable. Thanks in advance, -- dag wieers, [EMAIL PROTECTED], http://dag.wieers.com/ -- [all I want is a warm bed and a kind word and unlimited power] -- To unsubscribe or change options: https://lists.samba.org/mailman/listinfo/rsync Before posting, read: http://www.catb.org/~esr/faqs/smart-questions.html
Re: Premature optimization in f_name_cmp()?
On Mon, Mar 14, 2005 at 10:40:00AM +1100, Andrew Bartlett wrote: Is there a way to make this only look at the 'right' part of sorted- flist, given it's sorted, and is this really needed at all? Yeah, that code is really pretty silly. I neglected to test my assumption about how often it would get triggered, and it is actually getting run much more often than expected. I'm just removing that bit of code for the next release (and tweaking some code in generator for the --fuzzy option handling so that it doesn't depend on the dirnames having identical string pointers). Thanks for the detective work! ..wayne.. -- To unsubscribe or change options: https://lists.samba.org/mailman/listinfo/rsync Before posting, read: http://www.catb.org/~esr/faqs/smart-questions.html
