Re: rsync 2.5.4 -v output (minor knit)
Dave,
Awesome! Nice clean output now with single -v. I guess I need to make
sure the perl File::Rsync module is up-todate with 2.5.4 ;)
Thanks again to all the developers, Now that rsync exists I can't live
without it. I use it all day long for all kinds of transfers, not to
mention it is an integral part of our corporate DNS process and our DRP
solution for off-site backup of critical servers.
-Lee
---begin quoted text---
From: Dave Dykstra [EMAIL PROTECTED]
Subject: Re: rsync 2.5.4 -v output (minor knit)
Date: Thu, 14 Mar 2002 15:27:49 -0600
Ah, yes. Here's a fix. I submitted it to rsync CVS.
- Dave
--- flist.c.O Thu Mar 14 15:26:24 2002
+++ flist.c Thu Mar 14 15:18:52 2002
@@ -988,8 +988,9 @@
send_file_entry(NULL, f, 0);
}
- if (show_filelist_p())
+ if (show_filelist_p() f != -1) {
finish_filelist_progress(flist);
+ }
clean_flist(flist, 0);
---end quoted text---
--
Lee Eakin - [EMAIL PROTECTED]
SPOON! --The Tick There is no spoon. --Neo, The Matrix
--
To unsubscribe or change options: http://lists.samba.org/mailman/listinfo/rsync
Before posting, read: http://www.tuxedo.org/~esr/faqs/smart-questions.html
Re: rsync 2.5.4 -v output (minor knit)
Dave, I tried a simple case but could not reproduce it, but it is reliable from my script. I'll work out a test case today by ripping apart my script and send along. -Lee ---begin quoted text--- Delivered-To: [EMAIL PROTECTED] From: Dave Dykstra [EMAIL PROTECTED] To: [EMAIL PROTECTED] Subject: Re: rsync 2.5.4 -v output (minor knit) Mail-Followup-To: Dave Dykstra [EMAIL PROTECTED], [EMAIL PROTECTED] User-Agent: Mutt/1.3.27i X-BeenThere: [EMAIL PROTECTED] X-Mailman-Version: 2.0.8 Date: Thu, 14 Mar 2002 12:37:54 -0600 On Wed, Mar 13, 2002 at 03:44:36PM -0600, Lee Eakin wrote: I noticed a difference in verbose output that appears to be unintentional. it first prints 'receiving file list ...', then builds the list and prints 'done\n'. I haven't figured out the exact conditions yet, but with multiple remote sources (remote shell expands) it sometimes prints the 'done\n' message multiple times. I have a script I use to sync up my dot-files with multiple files and excludes that prints the 'done\n' line 16 times. Is there a simple fix? People parsing the output of -v may want to be aware of this. I first saw it in 2.5.3. -Lee I have not seen this, and I would appreciate a simple set of steps to reproduce it. I touched that code recently so I guess I should fix it. I tried rsync -av 'host:`echo dir1/*`' dir2 and that didn't do it. - Dave Dykstra -- To unsubscribe or change options: http://lists.samba.org/mailman/listinfo/rsync Before posting, read: http://www.tuxedo.org/~esr/faqs/smart-questions.html ---end quoted text--- -- Lee Eakin - [EMAIL PROTECTED] - Internet/Naming Services, Texas Instruments HELO. My $name is sendmail.cf. You filled my spooldir. Prepare to VRFY. -- To unsubscribe or change options: http://lists.samba.org/mailman/listinfo/rsync Before posting, read: http://www.tuxedo.org/~esr/faqs/smart-questions.html
Re: rsync 2.5.4 -v output (minor knit)
Dave, I found the test case, it simply involves more than one directory and --delete: rsync -av --delete remhost:'bin lib' . With this command I get 3 done messages: receiving file list ... done done done wrote 16 bytes read 7386 bytes 2960.80 bytes/sec total size is 4169245 speedup is 563.26 Without the --delete option I only get a single 'done' after the '...'. Hope that narrows it down enough to make it easy to find, -Lee ---begin quoted text--- From: Dave Dykstra [EMAIL PROTECTED] To: [EMAIL PROTECTED] Subject: Re: rsync 2.5.4 -v output (minor knit) Date: Thu, 14 Mar 2002 12:37:54 -0600 On Wed, Mar 13, 2002 at 03:44:36PM -0600, Lee Eakin wrote: I noticed a difference in verbose output that appears to be unintentional. it first prints 'receiving file list ...', then builds the list and prints 'done\n'. I haven't figured out the exact conditions yet, but with multiple remote sources (remote shell expands) it sometimes prints the 'done\n' message multiple times. I have a script I use to sync up my dot-files with multiple files and excludes that prints the 'done\n' line 16 times. I have not seen this, and I would appreciate a simple set of steps to reproduce it. I touched that code recently so I guess I should fix it. I tried rsync -av 'host:`echo dir1/*`' dir2 and that didn't do it. - Dave Dykstra ---end quoted text--- -- Lee Eakin - [EMAIL PROTECTED] Allen's Distinction: The lion and the calf shall lie down together, but the calf won't get much sleep. -- To unsubscribe or change options: http://lists.samba.org/mailman/listinfo/rsync Before posting, read: http://www.tuxedo.org/~esr/faqs/smart-questions.html
Re: rsync 2.5.4 -v output (minor knit)
On 14 Mar 2002, Dave Dykstra [EMAIL PROTECTED] wrote: I have not seen this, and I would appreciate a simple set of steps to reproduce it. I touched that code recently so I guess I should fix it. I tried rsync -av 'host:`echo dir1/*`' dir2 and that didn't do it. Since we seem to have agreed that the -v output should stay exactly as it is to support scripts, I'd like to have a regression test which checks that: copy a few files using -v, and diff the output. If we have stronger tests, then we can be more confident in making performance or functionality improvements without breaking existing systems. (I'm sure this is preaching to the choir for most of you.) -- Martin -- To unsubscribe or change options: http://lists.samba.org/mailman/listinfo/rsync Before posting, read: http://www.tuxedo.org/~esr/faqs/smart-questions.html
Re: rsync 2.5.4 -v output (minor knit)
On Wed, Mar 13, 2002 at 03:44:36PM -0600, Lee Eakin wrote: I noticed a difference in verbose output that appears to be unintentional. it first prints 'receiving file list ...', then builds the list and prints 'done\n'. I haven't figured out the exact conditions yet, but with multiple remote sources (remote shell expands) it sometimes prints the 'done\n' message multiple times. I have a script I use to sync up my dot-files with multiple files and excludes that prints the 'done\n' line 16 times. Is there a simple fix? People parsing the output of -v may want to be aware of this. I first saw it in 2.5.3. -Lee I have not seen this, and I would appreciate a simple set of steps to reproduce it. I touched that code recently so I guess I should fix it. I tried rsync -av 'host:`echo dir1/*`' dir2 and that didn't do it. - Dave Dykstra -- To unsubscribe or change options: http://lists.samba.org/mailman/listinfo/rsync Before posting, read: http://www.tuxedo.org/~esr/faqs/smart-questions.html
Re: rsync 2.5.4 -v output (minor knit)
On Thu, Mar 14, 2002 at 02:21:44PM -0600, Lee Eakin wrote:
Dave, I found the test case, it simply involves more than one directory and
--delete:
rsync -av --delete remhost:'bin lib' .
With this command I get 3 done messages:
receiving file list ... done
done
done
wrote 16 bytes read 7386 bytes 2960.80 bytes/sec
total size is 4169245 speedup is 563.26
Without the --delete option I only get a single 'done' after the '...'.
Hope that narrows it down enough to make it easy to find,
-Lee
Ah, yes. Here's a fix. I submitted it to rsync CVS.
- Dave
--- flist.c.O Thu Mar 14 15:26:24 2002
+++ flist.c Thu Mar 14 15:18:52 2002
-988,8 +988,9
send_file_entry(NULL, f, 0);
}
- if (show_filelist_p())
+ if (show_filelist_p() f != -1) {
finish_filelist_progress(flist);
+ }
clean_flist(flist, 0);
--
To unsubscribe or change options: http://lists.samba.org/mailman/listinfo/rsync
Before posting, read: http://www.tuxedo.org/~esr/faqs/smart-questions.html
rsync 2.5.4 -v output (minor knit)
I noticed a difference in verbose output that appears to be unintentional. it first prints 'receiving file list ...', then builds the list and prints 'done\n'. I haven't figured out the exact conditions yet, but with multiple remote sources (remote shell expands) it sometimes prints the 'done\n' message multiple times. I have a script I use to sync up my dot-files with multiple files and excludes that prints the 'done\n' line 16 times. Is there a simple fix? People parsing the output of -v may want to be aware of this. I first saw it in 2.5.3. -Lee -- Law of Selective Gravity: An object will fall so as to do the most damage. -- To unsubscribe or change options: http://lists.samba.org/mailman/listinfo/rsync Before posting, read: http://www.tuxedo.org/~esr/faqs/smart-questions.html
