[Bug 14319] New: -M--fake-super --chmod changes the permissions stored in the xattr
https://bugzilla.samba.org/show_bug.cgi?id=14319 Bug ID: 14319 Summary: -M--fake-super --chmod changes the permissions stored in the xattr Product: rsync Version: 3.1.3 Hardware: All OS: All Status: NEW Severity: normal Priority: P5 Component: core Assignee: wa...@opencoder.net Reporter: ji...@gmx.net QA Contact: rsync...@samba.org I want to save the original permissions in the xattr, in order to have a proper backup, but set a custom mode of g+rX to the files. It seems there is no way to separate the permissions stored in the xattr to the real permissions. Rsync will always store the same in both places. I have tried different combinations of --fake-super --perms --chmod with no success. I brought up the issue here: https://www.mail-archive.com/rsync@lists.samba.org/msg32714.html -- You are receiving this mail because: You are the QA Contact for the bug. -- Please use reply-all for most replies to avoid omitting the mailing list. To unsubscribe or change options: https://lists.samba.org/mailman/listinfo/rsync Before posting, read: http://www.catb.org/~esr/faqs/smart-questions.html
[Bug 7112] --fake-super should use default permissions for real files
https://bugzilla.samba.org/show_bug.cgi?id=7112 --- Comment #1 from Dimitrios Apostolou --- I agree. I am running rsync with --perms, but I want --fake-super to store the original permissions in the xattr, and not change the real mode of the destination file. What is more, I am trying to force the real mode of the file by adding --chmod, in order to make it group readable, but this affects the mode stored in the xattr! There is no way to separate the two modes, the one in the xattr and the real-mode. They are always set to the same value AFAICT. Opened related bug #14319: -M--fake-super --chmod changes the permissions stored in the xattr. -- You are receiving this mail because: You are the QA Contact for the bug. -- Please use reply-all for most replies to avoid omitting the mailing list. To unsubscribe or change options: https://lists.samba.org/mailman/listinfo/rsync Before posting, read: http://www.catb.org/~esr/faqs/smart-questions.html
Would you expect --perms -M--fake-super to set the file mode to the original one?
rsync --perms -M--fake-super src dst For me, this command means that rsync should save the original perms in the xattr, and leave the real file mode to the umask default. Currently it also modifies the real file mode, and there is no way to store something different in the xattr. According to an old bug report that I found, more people would like --fake-super to be a complete attribute emulation layer. https://bugzilla.samba.org/show_bug.cgi?id=7112 Do you agree? I'm in the process of implementing this as a bug fix to rsync, and would like to know if everybody agrees with this behaviour. The patch would also modify the man page to document it under --perms. Regards, Dimitris -- Please use reply-all for most replies to avoid omitting the mailing list. To unsubscribe or change options: https://lists.samba.org/mailman/listinfo/rsync Before posting, read: http://www.catb.org/~esr/faqs/smart-questions.html
Re: Would you expect --perms -M--fake-super to set the file mode to the original one?
Permissions don't require super. Any place where permissions can't be stored certainly can't handle xattrs either. So, I wouldn't expect --fake-super to affect --perms at all. On 3/12/20 12:46 PM, Dimitrios Apostolou via rsync wrote: > rsync --perms -M--fake-super src dst > > For me, this command means that rsync should save the original perms in the > xattr, and leave the real file mode to the umask default. Currently it also > modifies the real file mode, and there is no way to store something > different > in the xattr. > > According to an old bug report that I found, more people would like > --fake-super to be a complete attribute emulation layer. > > https://bugzilla.samba.org/show_bug.cgi?id=7112 > > Do you agree? I'm in the process of implementing this as a bug fix to > rsync, > and would like to know if everybody agrees with this behaviour. The patch > would also modify the man page to document it under --perms. > > > Regards, > Dimitris > > -- ~*-,._.,-*~'`^`'~*-,._.,-*~'`^`'~*-,._.,-*~'`^`'~*-,._.,-*~'`^`'~*-,._., Kevin Korb Phone:(407) 252-6853 Systems Administrator Internet: FutureQuest, Inc. ke...@futurequest.net (work) Orlando, Floridak...@sanitarium.net (personal) Web page: https://sanitarium.net/ PGP public key available on web site. ~*-,._.,-*~'`^`'~*-,._.,-*~'`^`'~*-,._.,-*~'`^`'~*-,._.,-*~'`^`'~*-,._., signature.asc Description: OpenPGP digital signature -- Please use reply-all for most replies to avoid omitting the mailing list. To unsubscribe or change options: https://lists.samba.org/mailman/listinfo/rsync Before posting, read: http://www.catb.org/~esr/faqs/smart-questions.html
Re: Would you expect --perms -M--fake-super to set the file mode to the original one?
Thank you for the feedback, I'm glad to see that different people see the issue differently. As a followup question, what would you expect this to do: rsync --perms --chmod g+rX -M--fake-super src dst I would expect it to store the original permissions in the xattr, while modifying the real file mode according to the chmod. On Thursday, March 12, 2020 6:06:34 PM CET, Kevin Korb via rsync wrote: Permissions don't require super. Any place where permissions can't be stored certainly can't handle xattrs either. So, I wouldn't expect --fake-super to affect --perms at all. On 3/12/20 12:46 PM, Dimitrios Apostolou via rsync wrote: rsync --perms -M--fake-super src dst For me, this command means that rsync should save the original perms in the xattr, and leave the real file mode to the umask default. Currently it also modifies the real file mode, and there is no way to store something different ... -- Please use reply-all for most replies to avoid omitting the mailing list. To unsubscribe or change options: https://lists.samba.org/mailman/listinfo/rsync Before posting, read: http://www.catb.org/~esr/faqs/smart-questions.html
Re: Would you expect --perms -M--fake-super to set the file mode to the original one?
I would expect that the sending rsync would only send the perms provided modified by the --chmod. I wouldn't expect the receiver to even know the other permissions. On 3/12/20 1:23 PM, Dimitrios Apostolou via rsync wrote: > Thank you for the feedback, I'm glad to see that different people see > the issue > differently. As a followup question, what would you expect this to do: > > rsync --perms --chmod g+rX -M--fake-super src dst > > I would expect it to store the original permissions in the xattr, while > modifying the real file mode according to the chmod. > > On Thursday, March 12, 2020 6:06:34 PM CET, Kevin Korb via rsync wrote: >> Permissions don't require super. Any place where permissions can't be >> stored certainly can't handle xattrs either. So, I wouldn't expect >> --fake-super to affect --perms at all. >> >> On 3/12/20 12:46 PM, Dimitrios Apostolou via rsync wrote: >>> rsync --perms -M--fake-super src dst >>> >>> For me, this command means that rsync should save the original perms >>> in the >>> xattr, and leave the real file mode to the umask default. Currently >>> it also >>> modifies the real file mode, and there is no way to store something >>> different ... >> > > -- ~*-,._.,-*~'`^`'~*-,._.,-*~'`^`'~*-,._.,-*~'`^`'~*-,._.,-*~'`^`'~*-,._., Kevin Korb Phone:(407) 252-6853 Systems Administrator Internet: FutureQuest, Inc. ke...@futurequest.net (work) Orlando, Floridak...@sanitarium.net (personal) Web page: https://sanitarium.net/ PGP public key available on web site. ~*-,._.,-*~'`^`'~*-,._.,-*~'`^`'~*-,._.,-*~'`^`'~*-,._.,-*~'`^`'~*-,._., signature.asc Description: OpenPGP digital signature -- Please use reply-all for most replies to avoid omitting the mailing list. To unsubscribe or change options: https://lists.samba.org/mailman/listinfo/rsync Before posting, read: http://www.catb.org/~esr/faqs/smart-questions.html
