[rtc-linux] Re: [PATCH v2] x86: i8259: export legacy_pic symbol

2017-04-14 Thread Alexandre Belloni 
On 08/04/2017 at 23:03:27 +0200, Hans de Goede wrote:
> The classic PC rtc-coms driver has a workaround for broken ACPI device
> nodes for it which lack an irq resource. This workaround used to
> unconditionally hardcode the irq to 8 in these cases.
> 
> This was causing irq conflict problems on systems without a legacy-pic
> so a recent patch added an if (nr_legacy_irqs()) guard to the
> workaround to avoid this irq conflict.
> 
> nr_legacy_irqs() uses the legacy_pic symbol under the hood causing
> an undefined symbol error if the rtc-cmos code is build as a module.
> 
> This commit exports the legacy_pic symbol to fix this.
> 
> Cc: rtc-linux@googlegroups.com
> Cc: alexandre.bell...@free-electrons.com
> Signed-off-by: Hans de Goede 
> ---
> Changes in v2:
> -Use EXPORT_SYMBOL_GPL instead of EXPORT_SYMBOL
> ---
>  arch/x86/kernel/i8259.c | 1 +
>  1 file changed, 1 insertion(+)
> 
Applied, thanks.

-- 
Alexandre Belloni, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

-- 
You received this message because you are subscribed to "rtc-linux".
Membership options at http://groups.google.com/group/rtc-linux .
Please read http://groups.google.com/group/rtc-linux/web/checklist
before submitting a driver.
--- 
You received this message because you are subscribed to the Google Groups 
"rtc-linux" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to rtc-linux+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

[rtc-linux] Re: [PATCH v2] x86: i8259: export legacy_pic symbol

2017-04-14 Thread Thomas Gleixner 
On Fri, 14 Apr 2017, Ingo Molnar wrote:

> 
> * Alexandre Belloni  wrote:
> 
> > Hi,
> > 
> > On 08/04/2017 at 23:03:27 +0200, Hans de Goede wrote:
> > > The classic PC rtc-coms driver has a workaround for broken ACPI device
> > > nodes for it which lack an irq resource. This workaround used to
> > > unconditionally hardcode the irq to 8 in these cases.
> > > 
> > > This was causing irq conflict problems on systems without a legacy-pic
> > > so a recent patch added an if (nr_legacy_irqs()) guard to the
> > > workaround to avoid this irq conflict.
> > > 
> > > nr_legacy_irqs() uses the legacy_pic symbol under the hood causing
> > > an undefined symbol error if the rtc-cmos code is build as a module.
> > > 
> > 
> > This is kind of a pressing issue as this makes linux-next fail to build
> > for certain configurations.
> > 
> > I can carry it in my tree with your ack or let you apply it for 4.12.
> > What would you prefer?
> 
> Unless Thomas objects it looks good to me and feel free to carry it in your 
> tree:
> 
> Acked-by: Ingo Molnar 

Acked-by: Thomas Gleixner 

-- 
You received this message because you are subscribed to "rtc-linux".
Membership options at http://groups.google.com/group/rtc-linux .
Please read http://groups.google.com/group/rtc-linux/web/checklist
before submitting a driver.
--- 
You received this message because you are subscribed to the Google Groups 
"rtc-linux" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to rtc-linux+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

[rtc-linux] Re: [PATCH v2] x86: i8259: export legacy_pic symbol

2017-04-14 Thread Ingo Molnar 

* Alexandre Belloni  wrote:

> Hi,
> 
> On 08/04/2017 at 23:03:27 +0200, Hans de Goede wrote:
> > The classic PC rtc-coms driver has a workaround for broken ACPI device
> > nodes for it which lack an irq resource. This workaround used to
> > unconditionally hardcode the irq to 8 in these cases.
> > 
> > This was causing irq conflict problems on systems without a legacy-pic
> > so a recent patch added an if (nr_legacy_irqs()) guard to the
> > workaround to avoid this irq conflict.
> > 
> > nr_legacy_irqs() uses the legacy_pic symbol under the hood causing
> > an undefined symbol error if the rtc-cmos code is build as a module.
> > 
> 
> This is kind of a pressing issue as this makes linux-next fail to build
> for certain configurations.
> 
> I can carry it in my tree with your ack or let you apply it for 4.12.
> What would you prefer?

Unless Thomas objects it looks good to me and feel free to carry it in your 
tree:

Acked-by: Ingo Molnar 

Thanks,

Ingo

-- 
You received this message because you are subscribed to "rtc-linux".
Membership options at http://groups.google.com/group/rtc-linux .
Please read http://groups.google.com/group/rtc-linux/web/checklist
before submitting a driver.
--- 
You received this message because you are subscribed to the Google Groups 
"rtc-linux" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to rtc-linux+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.