Re: [sage-devel] How to review a ticket?

2021-01-19 Thread 'Jonathan Kliem' via sage-devel 
Ah. Reading your message closely, I think I see the problem. What you 
are trying to do, is not possible.


If you want to give some comments about the code, you need to leave a 
comment on the corresponding trac ticket.


You can parse code in comments using curly brackets:

{{{
def foo(a, b):
    return a + b
}}}

One can also see the diff file nicely:

{{{#!diff
--- a/src/doc/en/reference/homology/index.rst 

+++ b/src/doc/en/reference/homology/index.rst 


@@ -35,6 +35,7 @@ cell complexes.
sage/homology/algebraic_topological_model
sage/homology/homology_morphism
sage/homology/matrix_utils
+ sage/homology/finite_topological_spaces
sage/interfaces/chomp
}}}

It is also common to propose changes via a proposed diff:
(in this case propose to give a more descriptive name to a function.

{{{#!diff
- def foo(a, b):
+ def add(a, b):
 return a + b
}}}

Then it is rather easy to figure out for the author, what you are 
refering to.


The styling is mostly markdown, I guess. I learnt most things by 
pressing reply to a comment. Then, I can see the source code of what 
they wrote.


I hope that helps,

Jonathan


On 19.01.21 17:01, Siddharth Bhat wrote:
Strange, I am logged in. Even so, I don't seem to be able to see the 
edit options? What exactly ought I edit?


Thanks a lot,
~Siddharth

On Tue, Jan 19, 2021 at 9:26 PM 'jonatha...@googlemail.com 
' via sage-devel 
mailto:sage-devel@googlegroups.com>> wrote:


You need to login somehow.

You have previously logged in with your github account `gh-bollu`.
This works as well. After you log in, the edit options will appear.

Of course you can also create a sage account, which also lets you
edit https://wiki.sagemath.org/ and maybe you prefer not to link
your activities with your github account.

Anyway, for reviewing tickets etc, both options work. However,
most people decide on one account, so that people don't get confused.

Thierry (sage-googlesucks@xxx) schrieb am Dienstag, 19. Januar
2021 um 16:46:52 UTC+1:

Hi,

you could ask for a trac acount as explained in the developer
guide:


https://doc.sagemath.org/html/en/developer/trac.html#obtaining-an-account


Ciao,
Thierry


On Tue, Jan 19, 2021 at 06:55:33AM -0800, Siddharth Bhat wrote:
> Hey all,
>
> I'm trying to learn how to review Trac tickets,and am
unfortunately failing
> at it.
>
> I want to leave some comments on this file:
>

https://git.sagemath.org/sage.git/diff/src/sage/homology/finite_topological_spaces.py?id=fc4c726665c7bf25c83a7fae6f04420e19086d69

>
> which corresponds to this trac ticket:
> https://trac.sagemath.org/ticket/30400#no3
>
> but I can't find anything in the interface that lets me do
so. I see that
> the others have posted comments, such as this:
>
> https://trac.sagemath.org/ticket/30400#comment:15
>
> How do I post such a comment?
>
> Best,
> ~Siddharth
>
> --
> You received this message because you are subscribed to the
Google Groups "sage-devel" group.
> To unsubscribe from this group and stop receiving emails
from it, send an email to sage-devel+...@googlegroups.com.
> To view this discussion on the web visit

https://groups.google.com/d/msgid/sage-devel/65051530-b717-44eb-bd6d-10b1793f9141n%40googlegroups.com.


-- 
You received this message because you are subscribed to the Google

Groups "sage-devel" group.
To unsubscribe from this group and stop receiving emails from it,
send an email to sage-devel+unsubscr...@googlegroups.com
.
To view this discussion on the web visit

https://groups.google.com/d/msgid/sage-devel/3d49e559-447c-4d8d-89bc-fb97b95577bcn%40googlegroups.com

.



--
https://bollu.github.io/
--
You received this message because you are subscribed to a topic in the 
Google Groups "sage-devel" group.
To unsubscribe from this topic, visit 
https://groups.google.com/d/topic/sage-devel/hOwMXPMx99k/unsubscribe.
To unsubscribe from this group and all its topics, send an email to 
sage-devel+unsubscr...@googlegroups.com 
.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/sage-devel/CAPipc%3D1rMWjWt6nWJNcF9poy%3D%2BFqthpj2CsAjx4G%3DYNQ55t%2B0w%40mail.gmail.com

Re: [sage-devel] How to review a ticket?

2021-01-19 Thread Siddharth Bhat 
Strange, I am logged in. Even so, I don't seem to be able to see the edit
options? What exactly ought I edit?

Thanks a lot,
~Siddharth

On Tue, Jan 19, 2021 at 9:26 PM 'jonatha...@googlemail.com' via sage-devel <
sage-devel@googlegroups.com> wrote:

> You need to login somehow.
>
> You have previously logged in with your github account `gh-bollu`. This
> works as well. After you log in, the edit options will appear.
>
> Of course you can also create a sage account, which also lets you edit
> https://wiki.sagemath.org/ and maybe you prefer not to link your
> activities with your github account.
>
> Anyway, for reviewing tickets etc, both options work. However, most people
> decide on one account, so that people don't get confused.
>
> Thierry (sage-googlesucks@xxx) schrieb am Dienstag, 19. Januar 2021 um
> 16:46:52 UTC+1:
>
>> Hi,
>>
>> you could ask for a trac acount as explained in the developer guide:
>>
>> https://doc.sagemath.org/html/en/developer/trac.html#obtaining-an-account
>>
>> Ciao,
>> Thierry
>>
>>
>> On Tue, Jan 19, 2021 at 06:55:33AM -0800, Siddharth Bhat wrote:
>> > Hey all,
>> >
>> > I'm trying to learn how to review Trac tickets,and am unfortunately
>> failing
>> > at it.
>> >
>> > I want to leave some comments on this file:
>> >
>> https://git.sagemath.org/sage.git/diff/src/sage/homology/finite_topological_spaces.py?id=fc4c726665c7bf25c83a7fae6f04420e19086d69
>> >
>> > which corresponds to this trac ticket:
>> > https://trac.sagemath.org/ticket/30400#no3
>> >
>> > but I can't find anything in the interface that lets me do so. I see
>> that
>> > the others have posted comments, such as this:
>> >
>> > https://trac.sagemath.org/ticket/30400#comment:15
>> >
>> > How do I post such a comment?
>> >
>> > Best,
>> > ~Siddharth
>> >
>> > --
>> > You received this message because you are subscribed to the Google
>> Groups "sage-devel" group.
>> > To unsubscribe from this group and stop receiving emails from it, send
>> an email to sage-devel+...@googlegroups.com.
>> > To view this discussion on the web visit
>> https://groups.google.com/d/msgid/sage-devel/65051530-b717-44eb-bd6d-10b1793f9141n%40googlegroups.com.
>>
>>
>> --
> You received this message because you are subscribed to the Google Groups
> "sage-devel" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to sage-devel+unsubscr...@googlegroups.com.
> To view this discussion on the web visit
> https://groups.google.com/d/msgid/sage-devel/3d49e559-447c-4d8d-89bc-fb97b95577bcn%40googlegroups.com
> 
> .
>


-- 
https://bollu.github.io/

-- 
You received this message because you are subscribed to the Google Groups 
"sage-devel" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to sage-devel+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/sage-devel/CAPipc%3D1rMWjWt6nWJNcF9poy%3D%2BFqthpj2CsAjx4G%3DYNQ55t%2B0w%40mail.gmail.com.

Re: [sage-devel] How to review a ticket?

2021-01-19 Thread 'jonatha...@googlemail.com' via sage-devel 
You need to login somehow.

You have previously logged in with your github account `gh-bollu`. This 
works as well. After you log in, the edit options will appear.

Of course you can also create a sage account, which also lets you edit 
https://wiki.sagemath.org/ and maybe you prefer not to link your activities 
with your github account.

Anyway, for reviewing tickets etc, both options work. However, most people 
decide on one account, so that people don't get confused.

Thierry (sage-googlesucks@xxx) schrieb am Dienstag, 19. Januar 2021 um 
16:46:52 UTC+1:

> Hi,
>
> you could ask for a trac acount as explained in the developer guide:
>
> https://doc.sagemath.org/html/en/developer/trac.html#obtaining-an-account
>
> Ciao,
> Thierry
>
>
> On Tue, Jan 19, 2021 at 06:55:33AM -0800, Siddharth Bhat wrote:
> > Hey all,
> > 
> > I'm trying to learn how to review Trac tickets,and am unfortunately 
> failing 
> > at it. 
> > 
> > I want to leave some comments on this file: 
> > 
> https://git.sagemath.org/sage.git/diff/src/sage/homology/finite_topological_spaces.py?id=fc4c726665c7bf25c83a7fae6f04420e19086d69
> > 
> > which corresponds to this trac ticket:
> > https://trac.sagemath.org/ticket/30400#no3
> > 
> > but I can't find anything in the interface that lets me do so. I see 
> that 
> > the others have posted comments, such as this:
> > 
> > https://trac.sagemath.org/ticket/30400#comment:15
> > 
> > How do I post such a comment? 
> > 
> > Best,
> > ~Siddharth
> > 
> > -- 
> > You received this message because you are subscribed to the Google 
> Groups "sage-devel" group.
> > To unsubscribe from this group and stop receiving emails from it, send 
> an email to sage-devel+...@googlegroups.com.
> > To view this discussion on the web visit 
> https://groups.google.com/d/msgid/sage-devel/65051530-b717-44eb-bd6d-10b1793f9141n%40googlegroups.com
> .
>
>

-- 
You received this message because you are subscribed to the Google Groups 
"sage-devel" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to sage-devel+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/sage-devel/3d49e559-447c-4d8d-89bc-fb97b95577bcn%40googlegroups.com.

Re: [sage-devel] How to review a ticket?

2021-01-19 Thread Thierry 
Hi,

you could ask for a trac acount as explained in the developer guide:

https://doc.sagemath.org/html/en/developer/trac.html#obtaining-an-account

Ciao,
Thierry


On Tue, Jan 19, 2021 at 06:55:33AM -0800, Siddharth Bhat wrote:
> Hey all,
> 
> I'm trying to learn how to review Trac tickets,and am unfortunately failing 
> at it. 
> 
> I want to leave some comments on this file: 
> https://git.sagemath.org/sage.git/diff/src/sage/homology/finite_topological_spaces.py?id=fc4c726665c7bf25c83a7fae6f04420e19086d69
> 
> which corresponds to this trac ticket:
> https://trac.sagemath.org/ticket/30400#no3
> 
> but I can't find anything in the interface that lets me do so. I see that 
> the others have posted comments, such as this:
> 
> https://trac.sagemath.org/ticket/30400#comment:15
> 
> How do I post such a comment? 
> 
> Best,
> ~Siddharth
> 
> -- 
> You received this message because you are subscribed to the Google Groups 
> "sage-devel" group.
> To unsubscribe from this group and stop receiving emails from it, send an 
> email to sage-devel+unsubscr...@googlegroups.com.
> To view this discussion on the web visit 
> https://groups.google.com/d/msgid/sage-devel/65051530-b717-44eb-bd6d-10b1793f9141n%40googlegroups.com.

-- 
You received this message because you are subscribed to the Google Groups 
"sage-devel" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to sage-devel+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/sage-devel/20210119154646.hq4p2sxmn7ormjx5%40metelu.net.

[sage-devel] How to review a ticket?

2021-01-19 Thread Siddharth Bhat 
Hey all,

I'm trying to learn how to review Trac tickets,and am unfortunately failing 
at it. 

I want to leave some comments on this file: 
https://git.sagemath.org/sage.git/diff/src/sage/homology/finite_topological_spaces.py?id=fc4c726665c7bf25c83a7fae6f04420e19086d69

which corresponds to this trac ticket:
https://trac.sagemath.org/ticket/30400#no3

but I can't find anything in the interface that lets me do so. I see that 
the others have posted comments, such as this:

https://trac.sagemath.org/ticket/30400#comment:15

How do I post such a comment? 

Best,
~Siddharth

-- 
You received this message because you are subscribed to the Google Groups 
"sage-devel" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to sage-devel+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/sage-devel/65051530-b717-44eb-bd6d-10b1793f9141n%40googlegroups.com.