Re: [sage-devel] When the reviewer modifies some parts of the patch...?

2018-08-06 Thread Friedrich Wiemer
Thanks for the quick answer and also the answer on the ticket Jeroen.

Am Montag, 6. August 2018 10:09:41 UTC+2 schrieb Jeroen Demeyer:
>
> On 2018-08-06 10:06, Friedrich Wiemer wrote: 
> > is it ok, if I (as the original author), review this 
> > small change? 
>
> Yes. 
>

-- 
You received this message because you are subscribed to the Google Groups 
"sage-devel" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to sage-devel+unsubscr...@googlegroups.com.
To post to this group, send email to sage-devel@googlegroups.com.
Visit this group at https://groups.google.com/group/sage-devel.
For more options, visit https://groups.google.com/d/optout.


Re: [sage-devel] When the reviewer modifies some parts of the patch...?

2018-08-06 Thread Jeroen Demeyer

On 2018-08-06 10:06, Friedrich Wiemer wrote:

is it ok, if I (as the original author), review this
small change?


Yes.

--
You received this message because you are subscribed to the Google Groups 
"sage-devel" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to sage-devel+unsubscr...@googlegroups.com.
To post to this group, send email to sage-devel@googlegroups.com.
Visit this group at https://groups.google.com/group/sage-devel.
For more options, visit https://groups.google.com/d/optout.


[sage-devel] When the reviewer modifies some parts of the patch...?

2018-08-06 Thread Friedrich Wiemer
In #25765 we have the situation that the reviewer changed some part of the 
patch and the question now is, how to review this? Do we need a third 
reviewer, or is it ok, if I (as the original author), review this small 
change?

-- 
You received this message because you are subscribed to the Google Groups 
"sage-devel" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to sage-devel+unsubscr...@googlegroups.com.
To post to this group, send email to sage-devel@googlegroups.com.
Visit this group at https://groups.google.com/group/sage-devel.
For more options, visit https://groups.google.com/d/optout.