RE: [Samba] Nmbd is using the wrong ip address as source

2008-10-05 Thread Teodor Iacob 
Does anybody have a suggestion for another list or forum to address
this issue?


 -Original Message-
 From: Teodor Iacob 
 Sent: 4 octombrie 2008 09:14
 To: [EMAIL PROTECTED]; samba@lists.samba.org
 Subject: RE: [Samba] Nmbd is using the wrong ip address as source
 
  
 
  -Original Message-
  From: [EMAIL PROTECTED]
  [mailto:[EMAIL PROTECTED] On Behalf Of 
  [EMAIL PROTECTED]
  Sent: Saturday, October 04, 2008 4:41 AM
  To: samba@lists.samba.org
  Subject: Re: [Samba] Nmbd is using the wrong ip address as source
  
  Teodor Iacob wrote:
   Hello,
   
   I have a linux box with the following S/W versions:
   CentOS release 5.2 (Final)
   Linux ns.hostname.ro 2.6.18-92.1.13.el5 #1 SMP Wed Sep 24
  19:32:05 EDT 2008 x86_64 x86_64 x86_64 GNU/Linux
   Version 3.0.28-1.el5_2.1
   
   My server has 2 IP interfaces, eth0: with the public ip
  address and br0: for the private subnet.
   Br0 being a bridge ip interface between eth1 and tap0 ( for
  openvpn ).
   
   Now my problem is that the nmbd is doing the netbios
  broadcasts using the eth0 ip address instead
   of the br0 one. I'm only interested in enabling samba on
  the local network (br0). I have checked
   this by using tcpdump on another linux machine in the
  network and saw the broadcasts with the source
   address the eth0 ip. Nmbd claims to win the master browsing
  election, but in reality the windows machines
   ignore the election packets and another machine becomes
  master and the browsing list is messed up..
   The smbd works just fine, connecting to the shares manually
  works correctly.
   
   How can I make nmbd to use the correct ip address? ( btw, I
  removed the bridge config just for testing
   and only enabled ip on the eth1 and the same problem.. ). I
  saw that in the previous version there was
   a parameter -I to force the source address..
   
   For reference this is my smb.conf:
   [global]
   workgroup = HOSTNAME
   netbios name = HNS
   interfaces = 10.10.10.1 127.0.0.1
  
  ... why not just say interfaces = br0 so that it binds to your 
  private interface (which I presume owns 10.10.10.1)?  You 
 don't need 
  to have Samba listen on the loopback address if you can 
 talk to it on 
  another local address.
 
 I mentioned also br0 in my quest of trying all possibilities 
 I could think of.. No change.
 But bind is only for listening, my problem is when nmbd it 
 sends packets by itself to make the election. I told you smbd 
 works fine and I can see from netstat -an at the LISTEN part 
 that it was only bound to the 10.10.10.1:139 and 10.10.10.1:445
 
 
  
   hosts allow = 127.0.0., 10.10.10.
   bind interfaces only = yes
  [snip]
   remote announce = 10.10.10.255/HOSTNAME
   socket address = 10.10.10.1
  
  Don
  --
  To unsubscribe from this list go to the following URL and read the
  instructions:  https://lists.samba.org/mailman/listinfo/samba
  
 
 

__ Information from ESET NOD32 Antivirus, version of virus signature 
database 3495 (20081004) __

The message was checked by ESET NOD32 Antivirus.

http://www.eset.com
 

-- 
To unsubscribe from this list go to the following URL and read the
instructions:  https://lists.samba.org/mailman/listinfo/samba

Re: [Samba] Re: smbclient kerberos issue

2008-10-05 Thread Ryan Bair 
It wasn't so much that the records weren't in the keytab as much as
the fact that the SPNs just weren't being created. Even when I added
additional principals, I was only getting the shortname version.

In my initial test environment, I wasn't able to replicate the
problem. I ended up cloning the problem system to my test environment
and I was able to reproduce the error.

It seems like it was a problem avahi which mistakenly made its way
into my nsswitch.conf. After removing mdns4_minimal and mdns4, I
rejoined to the domain and everything works great. I'm a bit confused
as to how this caused the problem, but I'm very happy to have it
fixed!

Thanks

On Sat, Oct 4, 2008 at 2:45 PM, Gerald (Jerry) Carter [EMAIL PROTECTED] wrote:
 -BEGIN PGP SIGNED MESSAGE-
 Hash: SHA1

 Ryan Bair wrote:
 This seems to be related to this entry on the list in 2004-2005. As
 far as I see, the issue was never fixed. This is a pretty big issue if
 it is indeed the same bug as it effectively stops *nix clients from
 using Kerberos authentication.

 http://lists.samba.org/archive/samba-technical/2005-April/040338.html

 I will try to work around using setspn -A host/fqdn computer. Will
 net ads keytab create pull all the SPNs available for the client or
 is it set only do load the default ones?

 We don't add cifs/... entries to the system keytab anymore.
 If I understand you correctly, you are using smbclient to connect
 from one Unix box to a Samba server.  Correct?  If so, smbd
 validates the service ticket using the machine trust account
 password stored in secrets.tdb so the keytab entries don't
 generally come into play.

 The keytab is provided to support non-Samba kerberized applications
 such as sshd.



 cheers, jerry
 - --
 =
 Samba--- http://www.samba.org
 Likewise Software  -  http://www.likewisesoftware.com
 What man is a man who does not make the world better?  --Balian
 -BEGIN PGP SIGNATURE-
 Version: GnuPG v1.4.6 (GNU/Linux)
 Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

 iD8DBQFI57nTIR7qMdg1EfYRAuKPAJ9Z9bP0QJchsYJ6laQJODFAgu2vQwCg3F1+
 LjrMmz7trKtLBdsEOvzK8ww=
 =jy1l
 -END PGP SIGNATURE-

-- 
To unsubscribe from this list go to the following URL and read the
instructions:  https://lists.samba.org/mailman/listinfo/samba

Re: [Samba] Compiling 3.2.4 --with-krb5=/usr/lib/krb5, not working

2008-10-05 Thread Scott Lovenberg 

Jake Carroll wrote:

Scott,

Thanks for the link. I had a poke around, substituting my paths et al 
with the instructions here, and, unfortunately, it still just doesn't 
seem to see my krb libraries. I am wondering if there is something 
generically _wrong_ with Solaris/Sun shipped Krb that samba doesn't like?


Any other ideas?

Thanks for the input!

*/JC/*
On Oct 5, 2008, at 11:13 AM, Scott Lovenberg wrote:


Jake Carroll wrote:

Hi all,

I'm currently attempting to compile Samba 3.2.4 for Solaris 10 x86. 
I require krb5 support and I realised that it would not look in the 
correct default location, under Solaris 10.


Example, from ./configure --help:

  --with-krb5=base-dirLocate Kerberos 5 support (default=/usr)

In vanilla Solaris 10 x86, Kerberos libraries are stored in 
/usr/lib/krb5. I thought it best to attempt to specifically, rather, 
explicitly state the base dir like so, because using the default is 
not working:


./configure --with-aio-support --with-krb5=/usr/lib/krb5

I felt that this would give the linker/compiler the best chance of 
finding what it needed. Apparently, this is not the case. When I 
look in the config.log:


configure:55103: checking for Active Directory and krb5 support
KRB5CONFIG=''
KRB5_LIBS=''
WINBIND_KRB5_LOCATOR=''

So then, if we do a make

# less config.h | grep -i krb
/* Whether the krb5_address struct has a addrtype property */
/* #undef HAVE_ADDRTYPE_IN_KRB5_ADDRESS */
/* Whether the krb5_address struct has a addr_type property */
/* #undef HAVE_ADDR_TYPE_IN_KRB5_ADDRESS */
/* Whether the krb5_checksum struct has a checksum property */
/* #undef HAVE_CHECKSUM_IN_KRB5_CHECKSUM */


...all left untouched.

Any thoughts? The libraries are definitely and obviously there:

[EMAIL PROTECTED]:/usr/lib/krb5] $ ls -als
total 3338
   2 drwxr-xr-x   4 root bin 1024 May  3 10:15 .
  64 drwxr-xr-x 122 root bin32256 Aug 16 20:57 ..
   2 -r--r--r--   1 root bin  700 Jan 22  2005 
HelpIndex.html
   2 drwxr-xr-x   2 root bin  512 May  3 10:15 
ListResourceBundle

   2 -r--r--r--   1 root bin  412 Jan 22  2005 README.db2
   4 -r--r--r--   1 root bin 1962 Jan 22  2005 
SunLogo.4c.gif

   2 drwxr-xr-x   2 root bin  512 May  3 10:15 amd64
   2 lrwxrwxrwx   1 root root   8 May  3 10:15 db2.so - 
db2.so.1

 144 -rwxr-xr-x   1 root bin73088 Mar 19  2008 db2.so.1
 416 -r--r--r--   1 root bin   204145 Mar 12  2008 gkadmin.jar
 122 -r-x--   1 root bin62100 Mar 19  2008 kadmind
   2 lrwxrwxrwx   1 root root  10 May  3 10:15 kldap.so 
- kldap.so.1

  80 -rwxr-xr-x   1 root bin40684 Mar 19  2008 kldap.so.1
  38 -r-xr-xr-x   1 root bin18488 Mar 19  2008 kprop
   2 -r-xr-xr-x   1 root bin  300 Jan 22  2005 kprop_script
  70 -r-xr-xr-x   1 root bin35136 Mar 19  2008 kpropd
snip.


Thanks all.


JC


Erm, sorry for the double post.  Here's a reference for crle with samba.
Here's a recipe for Samba+Active Directory on Solaris 9 
http://lists.samba.org/archive/samba-technical/2006-May/046971.html
Sorry, I'm tapped for good ideas.  I'm trying to duplicate this on a 
VM... and remembering why I stopped using OpenSolaris :)  I just have to 
keep it stable for long enough to update.  So far, Solaris is winning by 
restarting the window manager every fifteen minutes or so.


The only other thing I could think of is manually entering the path in 
the configuration variable and trying to compile.  I'm not sure that it 
would help at all, but it can't hurt to give it a shot.

--
To unsubscribe from this list go to the following URL and read the
instructions:  https://lists.samba.org/mailman/listinfo/samba

[Samba] Performance tweaking from Ubuntu to a Macbook vs. Windows through DLink DIR-655

2008-10-05 Thread Roy Abou Assaly 

Hi Everyone,

I've been happy with my setup the last 2 years, and I just bought a new
router - D-Link DIR-655.

I was connecting wireless and wired and noticed the following before
tweaking:

Wired 100 Mbps
==
Macbook to Ubuntu: 56 Mbps
Windows to Ubuntu: 72 Mbps

Wireless N (Connected at 130 Mbps ... Apple's fault)
== ==
Macbook to Ubuntu: 20 Mbps
Macbook to Windows: 44 Mbps

That's a significant change.

So I changed the following line in Samba's smb.conf file:

socket options = TCP_NODELAY SO_KEEPALIVE IPTOS_LOWDELAY SO_RCVBUF=8192
SO_SNDBUF=8192

to

socket options = TCP_NODELAY SO_KEEPALIVE IPTOS_LOWDELAY SO_RCVBUF=65536
SO_SNDBUF=65536

After this, I noticed the following:

Wireless:
=

Macbook to Ubuntu: 44 Mbps, with peaks up to 48 Mbps.

That's nearly double the performance!! Wireless is basically what I was
unhappy about.

Does anybody have any SO_SNDBUF and SO_RCVBUF values that they care to share
that they have used in order to improve network performance? Btw, removing
those values gives close to the same result.

Oh, and all the above were using Samba shares. Just for kicks, I tested the
following over SFTP using FileZilla:

Macbook to Ubuntu: 60 Mbps  MY GOAL!

I'm hoping to achieve the above speed with the necessary tweaks. So I need
another 16 Mbps to squeeze out! Please note that I did all the above tests
using files larger than 1 GB to get a sustainable speed. I also did tests
using 1MB files and performance was similar.

Thanks guys! Any help is appreciated.
-- 
View this message in context: 
http://www.nabble.com/Performance-tweaking-from-Ubuntu-to-a-Macbook-vs.-Windows-through-DLink-DIR-655-tp19826605p19826605.html
Sent from the Samba - General mailing list archive at Nabble.com.

-- 
To unsubscribe from this list go to the following URL and read the
instructions:  https://lists.samba.org/mailman/listinfo/samba

Re: [Samba] Revisiting Samba's interaction with LDAP's ppolicy overlay

2008-10-05 Thread Ryan Steele 

Alexandre Biancalana wrote:

On 10/2/08, Ryan Steele [EMAIL PROTECTED] wrote:
  

Volker Lendecke wrote:



On Mon, Sep 29, 2008 at 10:14:01AM -0400, Adam Tauno Williams wrote:


  

This is, AFAIK, the only solution currently.  We do the
same thing.  It stinks.




As I said in the former mail thread: Patches are welcome. If
you really want it done quickly, some companies on
http://samba.org/samba/support also offer development
services.

Volker


  

 Unfortunately, I suspect that many of the folks who probably want this done
are system administrators, not software developers.  As a systems
administrator, I do have the ability to write code, but all I really use in
my day-to-day life is Perl and Bash, maybe dabbling in some Python or Ruby.
As Samba is written primarily in C, I probably wouldn't write very good
patches for it - I find that my proficiency lies in the languages I actually
use now, not the ones I used during undergrad in college.  And while I'd
love just dump money in to the project (or have an employer do it), that's
just not always a reality (especially not the amounts needed to fund
development efforts).

 All that being said, I'd be curious to know where this lies in the current
development pipeline (if at all).  Again, I (and I believe the community)
think this would be very beneficial to Samba as a use and marketing tool,
and deserves some consideration.  I'm happy to do what I can - testing,
tracking down bugs (even if I can't submit working patches), and money when
I have it.  But mostly I rely on good developers to develop, so that I can
focus on my role in the chain - testing it and implementing it in real-world
situations, and promoting it by installing it in all applicable
environments.

 However, it can't be overstated how much I appreciate the work that has
been done up to this point on Samba - it's a fantastic piece of software.
Keep up the good work!



Do we have any paper explaining the work that have to be done ? Or
early patches (proof of concept) that could be used as starting point
for this ?
  

I don't think there are either of those (officially).  The thread I
started back in April (which starts here:
http://lists.samba.org/archive/samba/2008-April/139711.html) has all the
technical details on exactly what happens currently, and suggestions
about how it could be fixed.  But, I can try and sum up the general idea
of what's wrong (as best I can remember, forgive me if I'm a little off
in some aspects - it's been several months since I've dealt with it),
and how it could be fixed.

Take the case where a Windows user has logged in to the Samba domain,
and attempts to change their password by hitting ctrl+alt+delete.  The
user provides their old password, and the new password, and sends both
to Samba.  Samba then checks to see what it's passdb backend is, which
in this case would be ldapsam:ldap://server, and as a result sends the
old and new password to LDAP.  If LDAP is using the ppolicy overlay, it
checks to see if the new password meets all the criteria defined in the
ppolicy.  Take the ppolicy entry I described in that thread:

56 cn=Password Policy,ou=Policies,dc=example,dc=com
cn: Password Policy
pwdAttribute: userPassword
pwdMaxAge: 3888000
pwdMinAge: 3468000
pwdMinLength: 6
pwdExpireWarning: 432000
pwdFailureCountInterval: 0
pwdMustChange: FALSE
pwdAllowUserChange: TRUE
pwdLockout: TRUE
pwdCheckQuality: 1
pwdGraceAuthNLimit: 0
pwdInHistory: 6
pwdMaxFailure: 2
pwdLockoutDuration: 60
objectClass: device
objectClass: pwdPolicy
objectClass: pwdPolicyChecker
objectClass: top
pwdCheckModule: check_password.so
pwdSafeModify: FALSE


This is an entry that is visible to ANYBODY who queries LDAP.  It uses
the above attributes to check if the password is sufficient - e.g.:

  Is it long enough (pwdMinLength - minimum six characters)?
  Is it one of the last 6 passwords (pwdInHistory)?
  Is it strong enough (pwdCheckModule - it uses check_password.so to
check the strength the check_password.so was a shared object created
by compiling a small C program I wrote that checked to see if the
password had at least 3 out of 4 of the following: one uppercase letter,
one lowercase letter, a number, and a punctuation mark.  The
pwdCheckModule has to be of the form described here:
http://linux.die.net/man/5/slapo-ppolicy)

If the user provided a password that only had numbers in it, it would
fail the pwdCheckModule check because it only met 1 of those 4 strength
criteria, and LDAP returns 0x13 (NT_STATUS_PASSWORD_RESTRICTION) and the
following message to Samba:

[2008/04/08 05:35:26, 10] lib/smbldap.c:smbldap_extended_operation(1472)
 Extended operation failed with error: Constraint violation (Password
fails quality checking policy)
[2008/04/08 05:35:26, 0] passdb/pdb_ldap.c:ldapsam_modify_entry(1644)
 ldapsam_modify_entry: LDAP Password could not be changed for user
tester: Constraint violation
   Password fails quality checking policy


But, instead

RE: [Samba] Nmbd is using the wrong ip address as source

2008-10-05 Thread Frank Gruman 
On Sun, 2008-10-05 at 18:35 +0300, Teodor Iacob wrote:

 Does anybody have a suggestion for another list or forum to address
 this issue?
 
 
  -Original Message-
  From: Teodor Iacob 
  Sent: 4 octombrie 2008 09:14
  To: [EMAIL PROTECTED]; samba@lists.samba.org
  Subject: RE: [Samba] Nmbd is using the wrong ip address as source
  
   
  
   -Original Message-
   From: [EMAIL PROTECTED]
   [mailto:[EMAIL PROTECTED] On Behalf Of 
   [EMAIL PROTECTED]
   Sent: Saturday, October 04, 2008 4:41 AM
   To: samba@lists.samba.org
   Subject: Re: [Samba] Nmbd is using the wrong ip address as source
   
   Teodor Iacob wrote:
Hello,

I have a linux box with the following S/W versions:
CentOS release 5.2 (Final)
Linux ns.hostname.ro 2.6.18-92.1.13.el5 #1 SMP Wed Sep 24
   19:32:05 EDT 2008 x86_64 x86_64 x86_64 GNU/Linux
Version 3.0.28-1.el5_2.1

My server has 2 IP interfaces, eth0: with the public ip
   address and br0: for the private subnet.
Br0 being a bridge ip interface between eth1 and tap0 ( for
   openvpn ).

Now my problem is that the nmbd is doing the netbios
   broadcasts using the eth0 ip address instead
of the br0 one. I'm only interested in enabling samba on
   the local network (br0). I have checked
this by using tcpdump on another linux machine in the
   network and saw the broadcasts with the source
address the eth0 ip. Nmbd claims to win the master browsing
   election, but in reality the windows machines
ignore the election packets and another machine becomes
   master and the browsing list is messed up..
The smbd works just fine, connecting to the shares manually
   works correctly.

How can I make nmbd to use the correct ip address? ( btw, I
   removed the bridge config just for testing
and only enabled ip on the eth1 and the same problem.. ). I
   saw that in the previous version there was
a parameter -I to force the source address..

For reference this is my smb.conf:
[global]
workgroup = HOSTNAME
netbios name = HNS
interfaces = 10.10.10.1 127.0.0.1
   
   ... why not just say interfaces = br0 so that it binds to your 
   private interface (which I presume owns 10.10.10.1)?  You 
  don't need 
   to have Samba listen on the loopback address if you can 
  talk to it on 
   another local address.
  
  I mentioned also br0 in my quest of trying all possibilities 
  I could think of.. No change.
  But bind is only for listening, my problem is when nmbd it 
  sends packets by itself to make the election. I told you smbd 
  works fine and I can see from netstat -an at the LISTEN part 
  that it was only bound to the 10.10.10.1:139 and 10.10.10.1:445
  
  
   
hosts allow = 127.0.0., 10.10.10.
bind interfaces only = yes
   [snip]
remote announce = 10.10.10.255/HOSTNAME
socket address = 10.10.10.1
   
   Don


First of all, thank you for your patience on volunteer attempts to help
you resolve your issue (considering it is still the weekend in much of
the world).

Now, can you include a portion of the tcpdump you viewed from the other
machine (particularly the part where the wrong address is appearing).
Also, I am assuming you have restarted both smbd and nmbd after each
configuration change.

To verify that your samba settings are being read properly, try to run
netstat -nap |grep [sn]mbd to see which ports are open on your local
machine.  Also, try running nmblookup -B 10.10.10.255 server to ensure
that nmbd is responding to name server queries on the broadcast address.

I Googled a moment, and came up with much of the above from her -
http://samba.org/~tpot/articles/multiple-interfaces.html

Let us know how it goes.

Regards,
Frank
-- 
To unsubscribe from this list go to the following URL and read the
instructions:  https://lists.samba.org/mailman/listinfo/samba

Re: [Samba] Lost most data on Windows XP machine switching to domain

2008-10-05 Thread Jesse Stone 
Thank you for all the responses.  Thinking back on how I did it, I bet it
was a permissions issue which prevented the files from migrating to the
Samba server but that still shouldn't have caused them to be deleted.  The
files were complete gone.  I checked both the old non-domain directory and
the newly created domain directory.  I was able to recover 98% of the data
using a special recovery program my IT department provided me.

The option I had to use to find the files using the recovery software was
not Accidently Deleted but Disk was formatted which makes me think
whatever process distroyed the files did it in a way where they did not go
into the recycle bin but completely distroyed.

-Jesse

On Sat, Oct 4, 2008 at 6:02 PM, Scott Lovenberg
[EMAIL PROTECTED]wrote:

  Jesse Stone wrote:

 I'm wondering if anyone has run across that and MUCH more importantly, if
 the data can be recovered somehow.

 I'll put as much details as I can at the bottom but here's the gist of the
 problem:

 I added my wives computer (which contains 8 years worth of pictures) to
 the
 domain.  When I logged into the new domain account it was empty and my
 wives
 domain users had no access so I did the following:

 1) Logged out of the domain account and back into the machine account
 2) Added the domain user to the administrative group
 3) MOVED (yes, I'm an idiot) everything from my wive's standard profile to
 the domain profile
 4) Logged back in with the domain account

 Here's what happens:
 a few random things where in the new domain.  For example, 1 bookmark (out
 of about 50) was in my wive's favorites folder.  The My Pictures folder
 contained Sample Pictures only.

 My guess is that 1 of 2 things happened:

 1) Samba didn't expect there to be data yet so started out with a fresh
 new
 profile.  This doesn't explain how some (less than 1% of her data) is
 available

 2)  My wive is connecting to the domain via wireless.  Somehow, mid-copy
 the
 wireless shut off and the data never made it to the roaming profile.

 Please someone give me good news like just do this and the data will be
 recovered!

 OK, here's the details (which will show my lack of understanding):

 I followed the following article when setting up Samba:
 http://www.howtoforge.com/samba_setup_ubuntu_5.10_p4

 The only changes I made are that I commented out the following lines
 (believing this would STOP roaming profiles.  I did not actually want
 roaming profiles and was only planning on setting the My Documents
 folder
 to use server storage.

 #logon drive = H:--  May use later for roaming profiles
 #logon path = \\%N\profile\%U--  May use later for roaming profiles

 (Note, the only thing this did is stop the drive letter from being set.
  The
 profile directly was still created, only under the /home/%user%/
 directory
 instead of /home/samba/profiles/)

 Here's the entire smb.conf I am using:
 [global]
 workgroup = domaintest
 netbios name = server3200
 server string = File Server
 passdb backend = tdbsam
 security = user
 username map = /etc/samba/smbusers
 name resolve order = wins bcast hosts
 domain logons = yes
 preferred master = yes
 wins support = yes
 # Set CUPS for printing
 printcap name = CUPS
 printing = CUPS
 # Default logon
 #logon drive = H:
 #logon script = scripts/logon.bat
 #logon path = \\%N\profile\%U
 # Useradd scripts
 add user script = /usr/sbin/useradd -m %u
 delete user script = /usr/sbin/userdel -r %u
 add group script = /usr/sbin/groupadd %g
 delete group script = /usr/sbin/groupdel %g
 add user to group script = /usr/sbin/usermod -G %g %u
 add machine script = /usr/sbin/useradd -s /bin/false/ -d /var/lib/nobody
 %u
 idmap uid = 15000-2
 idmap gid = 15000-2
 # sync smb passwords with linux passwords
 passwd program = /usr/bin/passwd %u
 passwd chat = *Enter\snew\sUNIX\spassword:* %n\n
 *Retype\snew\sUNIX\spassword:* %n\n .
 passwd chat debug = yes
 unix password sync = yes
 # set the loglevel
 log level = 3
 [homes]
 comment = Home
 valid users = %S
 read only = no
 browsable = no
 [printers]
 comment = All Printers
 path = /var/spool/samba
 printable = yes
 guest ok = yes
 browsable = no
 [netlogon]
 comment = Network Logon Service
 path = /home/samba/netlogon
 admin users = Administrator
 valid users = %U
 read only = no
 [profile]
 comment = User profiles
 path = /home/samba/profiles
 valid users = %U
 create mode = 0600
 directory mode = 0700
 writable = yes
 browsable = no

 Please understand that my wife may well divorce me if I can't recover this
 stuff.

 -Jesse


 I'm a little mixed up about about the steps that you took... Am I
 interpreting this correctly:
 1.)  You signed on with your wifes domain account, then logged out
 2.)  You then logged in as a local admin and added her domain account to
 the Domain Administrators group
 3.)  Before logging out of the local admin account, you moved all of her
 files to the default domain profile (in the netlogon share) (with
 permissions 0600 as per

[Samba] Cannot get shares to show up

2008-10-05 Thread Jesse Stone 
I apologize if this is a really silly question but I've been messing with
this for awhile now and cannot see any typos that would prevent these shares
from showing up.

I'm trying two things I've never done before so I want to make sure to point
them out:

1)  I am using groups in the valid users section
2)  I am using preexec and postexec on each share

Example:

[Media]
comment = Media(Non-kid)!
path = /mnt/media1
read only = yes
browsable = no
valid users = @mediausers
preexec = /bin/mount /mnt/media1
postexec = /bin/umount /mnt/media1

I've done nothing with the /mnt/media1 folder so I expect my next issue will
be permissiones related but I would expect the shares to at least show up
for all users within the @mediausers group.

I'm using preexec ect from the cd-rom example contained within the default
smb.conf file.

-Jesse
-- 
To unsubscribe from this list go to the following URL and read the
instructions:  https://lists.samba.org/mailman/listinfo/samba

Re: [Samba] Cannot get shares to show up

2008-10-05 Thread Ryan Bair 
Sorry, meant to reply all on that.

On Sun, Oct 5, 2008 at 10:22 PM, Ryan Bair [EMAIL PROTECTED] wrote:
 By showing up I assume you mean showing up in the listing of shares
 for the computer?

 The browsable = no would be your problem. It makes the share not
 browsable. :-)

 --Ryan

 On Sun, Oct 5, 2008 at 6:50 PM, Jesse Stone [EMAIL PROTECTED] wrote:
 I apologize if this is a really silly question but I've been messing with
 this for awhile now and cannot see any typos that would prevent these shares
 from showing up.

 I'm trying two things I've never done before so I want to make sure to point
 them out:

 1)  I am using groups in the valid users section
 2)  I am using preexec and postexec on each share

 Example:

 [Media]
 comment = Media(Non-kid)!
 path = /mnt/media1
 read only = yes
 browsable = no
 valid users = @mediausers
 preexec = /bin/mount /mnt/media1
 postexec = /bin/umount /mnt/media1

 I've done nothing with the /mnt/media1 folder so I expect my next issue will
 be permissiones related but I would expect the shares to at least show up
 for all users within the @mediausers group.

 I'm using preexec ect from the cd-rom example contained within the default
 smb.conf file.

 -Jesse
 --
 To unsubscribe from this list go to the following URL and read the
 instructions:  https://lists.samba.org/mailman/listinfo/samba


-- 
To unsubscribe from this list go to the following URL and read the
instructions:  https://lists.samba.org/mailman/listinfo/samba

svn commit: samba-web r1244 - in trunk/devel: .

2008-10-05 Thread vlendec 
Author: vlendec
Date: 2008-10-05 08:24:09 + (Sun, 05 Oct 2008)
New Revision: 1244

WebSVN: 
http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=revroot=samba-webrev=1244

Log:
Fix a typo
Modified:
   trunk/devel/index.html


Changeset:
Modified: trunk/devel/index.html
===
--- trunk/devel/index.html  2008-10-02 11:14:53 UTC (rev 1243)
+++ trunk/devel/index.html  2008-10-05 08:24:09 UTC (rev 1244)
@@ -14,7 +14,7 @@
 
 pOn 4 April 2004, the Samba Team converted from CVS to Subversion for
 maintaining the Samba source code, and on 10 January 2008 we completed the
-switch to Git for all development barnches.
+switch to Git for all development branches.
 With the transition to Git we also recovered in the main tree the CVS history.
 All older code is in the original Subversion and CVS trees; this would include
 3.0.x and 2.2.x versions of Samba, which are no longer in active development.

[SCM] Samba Shared Repository - branch master updated - 6ee4e81ad13fba417a4e50b5c162a799e44adf27

2008-10-05 Thread Volker Lendecke 
The branch, master has been updated
   via  6ee4e81ad13fba417a4e50b5c162a799e44adf27 (commit)
  from  de5edb1d0c0d60b337d2cbb7151db47d31bfa8d4 (commit)

http://gitweb.samba.org/?p=samba.git;a=shortlog;h=master


- Log -
commit 6ee4e81ad13fba417a4e50b5c162a799e44adf27
Author: Volker Lendecke [EMAIL PROTECTED]
Date:   Sun Oct 5 10:55:30 2008 +0200

Fix an uninitialized variable warning

Not sure if we can ever not get domain and dns_domain, but gcc complained

---

Summary of changes:
 source3/libsmb/dsgetdcname.c |2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)


Changeset truncated at 500 lines:

diff --git a/source3/libsmb/dsgetdcname.c b/source3/libsmb/dsgetdcname.c
index 18010aa..08ab8ca 100644
--- a/source3/libsmb/dsgetdcname.c
+++ b/source3/libsmb/dsgetdcname.c
@@ -228,6 +228,8 @@ static NTSTATUS store_cldap_reply(TALLOC_CTX *mem_ctx,
}
}
 
+   status = NT_STATUS_OK;
+
  done:
data_blob_free(blob);
 


-- 
Samba Shared Repository

[SCM] Samba Shared Repository - branch master updated - 01ecd766c86ad49c7d8b9095bef76b5dcc71d757

2008-10-05 Thread Volker Lendecke 
The branch, master has been updated
   via  01ecd766c86ad49c7d8b9095bef76b5dcc71d757 (commit)
  from  6ee4e81ad13fba417a4e50b5c162a799e44adf27 (commit)

http://gitweb.samba.org/?p=samba.git;a=shortlog;h=master


- Log -
commit 01ecd766c86ad49c7d8b9095bef76b5dcc71d757
Author: Volker Lendecke [EMAIL PROTECTED]
Date:   Sun Oct 5 13:12:31 2008 +0200

OS/X does not have rl_done in readline.h

---

Summary of changes:
 source3/lib/readline.c |8 
 1 files changed, 8 insertions(+), 0 deletions(-)


Changeset truncated at 500 lines:

diff --git a/source3/lib/readline.c b/source3/lib/readline.c
index fd57799..cafb5a9 100644
--- a/source3/lib/readline.c
+++ b/source3/lib/readline.c
@@ -47,6 +47,14 @@
 
 static bool smb_rl_done;
 
+#if HAVE_LIBREADLINE
+/*
+ * MacOS/X does not have rl_done in readline.h, but
+ * readline.so has it
+ */
+extern int rl_done;
+#endif
+
 void smb_readline_done(void)
 {
smb_rl_done = true;


-- 
Samba Shared Repository

[SCM] Samba Shared Repository - branch master updated - 8670235f2a2b9ef4b6863c185bd2ab57acd7e57a

2008-10-05 Thread Volker Lendecke 
The branch, master has been updated
   via  8670235f2a2b9ef4b6863c185bd2ab57acd7e57a (commit)
  from  01ecd766c86ad49c7d8b9095bef76b5dcc71d757 (commit)

http://gitweb.samba.org/?p=samba.git;a=shortlog;h=master


- Log -
commit 8670235f2a2b9ef4b6863c185bd2ab57acd7e57a
Author: Volker Lendecke [EMAIL PROTECTED]
Date:   Sun Oct 5 13:58:09 2008 +0200

Fix some missing error handlings

---

Summary of changes:
 source3/lib/netapi/file.c  |3 ++-
 source3/lib/netapi/getdc.c |4 
 source3/lib/netapi/share.c |3 ++-
 3 files changed, 8 insertions(+), 2 deletions(-)


Changeset truncated at 500 lines:

diff --git a/source3/lib/netapi/file.c b/source3/lib/netapi/file.c
index 036af32..0d66be0 100644
--- a/source3/lib/netapi/file.c
+++ b/source3/lib/netapi/file.c
@@ -47,7 +47,8 @@ WERROR NetFileClose_r(struct libnetapi_ctx *ctx,
r-in.server_name,
r-in.fileid,
werr);
-   if (!W_ERROR_IS_OK(werr)) {
+   if (!NT_STATUS_IS_OK(status)) {
+   werr = ntstatus_to_werror(status);
goto done;
}
 
diff --git a/source3/lib/netapi/getdc.c b/source3/lib/netapi/getdc.c
index 07a6544..76c0d0b 100644
--- a/source3/lib/netapi/getdc.c
+++ b/source3/lib/netapi/getdc.c
@@ -58,6 +58,10 @@ WERROR NetGetDCName_r(struct libnetapi_ctx *ctx,
   r-in.domain_name,
   (const char **)r-out.buffer,
   werr);
+
+   if (!NT_STATUS_IS_OK(status)) {
+   werr = ntstatus_to_werror(status);
+   }
  done:
 
return werr;
diff --git a/source3/lib/netapi/share.c b/source3/lib/netapi/share.c
index 1d0e181..e6aed36 100644
--- a/source3/lib/netapi/share.c
+++ b/source3/lib/netapi/share.c
@@ -271,7 +271,8 @@ WERROR NetShareDel_r(struct libnetapi_ctx *ctx,
   r-in.net_name,
   r-in.reserved,
   werr);
-   if (!W_ERROR_IS_OK(werr)) {
+   if (!NT_STATUS_IS_OK(status)) {
+   werr = ntstatus_to_werror(status);
goto done;
}
 


-- 
Samba Shared Repository

[SCM] Samba Shared Repository - branch master updated - 9bb6bae4ef5c02cb2b6c325e228fc4f4d4366167

2008-10-05 Thread Volker Lendecke 
The branch, master has been updated
   via  9bb6bae4ef5c02cb2b6c325e228fc4f4d4366167 (commit)
  from  8670235f2a2b9ef4b6863c185bd2ab57acd7e57a (commit)

http://gitweb.samba.org/?p=samba.git;a=shortlog;h=master


- Log -
commit 9bb6bae4ef5c02cb2b6c325e228fc4f4d4366167
Author: Volker Lendecke [EMAIL PROTECTED]
Date:   Sun Oct 5 15:48:55 2008 +0200

Remove an unused variable

---

Summary of changes:
 source3/utils/net_dns.c |1 -
 1 files changed, 0 insertions(+), 1 deletions(-)


Changeset truncated at 500 lines:

diff --git a/source3/utils/net_dns.c b/source3/utils/net_dns.c
index 46f38d4..4e617a1 100644
--- a/source3/utils/net_dns.c
+++ b/source3/utils/net_dns.c
@@ -145,7 +145,6 @@ error:
 int get_my_ip_address( struct sockaddr_storage **pp_ss )
 
 {
-   struct iface_struct nics[MAX_INTERFACES];
int i, n;
struct sockaddr_storage *list = NULL;
int count = 0;


-- 
Samba Shared Repository

[SCM] Samba GTK+ frontends branch, master, updated. a2fd9364f49e164a77335e7fb5603a5608d92b85

2008-10-05 Thread Jelmer Vernooij 
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project Samba GTK+ frontends.

The branch, master has been updated
   via  a2fd9364f49e164a77335e7fb5603a5608d92b85 (commit)
  from  cea840c53b457c52cfc787aa661b2d5cf7482c2f (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -
commit a2fd9364f49e164a77335e7fb5603a5608d92b85
Author: Jelmer Vernooij [EMAIL PROTECTED]
Date:   Sun Oct 5 15:57:44 2008 +0200

Remove deprecated Encoding properties.

---

Summary of changes:
 meta/gepdump.desktop   |1 -
 meta/gregedit.desktop  |1 -
 meta/gwcrontab.desktop |1 -
 meta/gwsam.desktop |1 -
 meta/gwsvcctl.desktop  |1 -
 5 files changed, 0 insertions(+), 5 deletions(-)


hooks/post-receive
--
Samba GTK+ frontends

[SCM] Samba GTK+ frontends branch, master, updated. ae065f6ccdb812143d2925e9814e285fa38effa5

2008-10-05 Thread Jelmer Vernooij 
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project Samba GTK+ frontends.

The branch, master has been updated
   via  ae065f6ccdb812143d2925e9814e285fa38effa5 (commit)
  from  a2fd9364f49e164a77335e7fb5603a5608d92b85 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -
commit ae065f6ccdb812143d2925e9814e285fa38effa5
Author: Jelmer Vernooij [EMAIL PROTECTED]
Date:   Sun Oct 5 16:02:39 2008 +0200

Add manpage for gtkldb.

---

Summary of changes:
 .gitignore   |1 +
 Makefile |2 +-
 man/gtkldb.1.xml |   59 ++
 3 files changed, 61 insertions(+), 1 deletions(-)
 create mode 100644 man/gtkldb.1.xml


hooks/post-receive
--
Samba GTK+ frontends

[SCM] Samba Shared Repository - branch master updated - 9542b2fe60482382459d387294fb92c182f35d64

2008-10-05 Thread Volker Lendecke 
The branch, master has been updated
   via  9542b2fe60482382459d387294fb92c182f35d64 (commit)
  from  9bb6bae4ef5c02cb2b6c325e228fc4f4d4366167 (commit)

http://gitweb.samba.org/?p=samba.git;a=shortlog;h=master


- Log -
commit 9542b2fe60482382459d387294fb92c182f35d64
Author: Volker Lendecke [EMAIL PROTECTED]
Date:   Sun Oct 5 16:09:18 2008 +0200

Re-enable build of smb_samba3.c after the rename smbd-samba

---

Summary of changes:
 source4/smb_server/config.mk |2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)


Changeset truncated at 500 lines:

diff --git a/source4/smb_server/config.mk b/source4/smb_server/config.mk
index 8ed03b1..6a1a50f 100644
--- a/source4/smb_server/config.mk
+++ b/source4/smb_server/config.mk
@@ -13,7 +13,7 @@ $(eval $(call 
proto_header_template,$(smb_serversrcdir)/service_smb_proto.h,$(SE
 #
 [MODULE::SERVICE_SAMBA3_SMB]
 INIT_FUNCTION = server_service_samba3_smb_init
-SUBSYSTEM = smbd
+SUBSYSTEM = samba
 
 SERVICE_SAMBA3_SMB_OBJ_FILES = $(smb_serversrcdir)/smb_samba3.o
 


-- 
Samba Shared Repository

[SCM] Samba GTK+ frontends branch, python, created. e4afbb6d21788eb338dc306144067cd7b927db1c

2008-10-05 Thread Jelmer Vernooij 
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project Samba GTK+ frontends.

The branch, python has been created
at  e4afbb6d21788eb338dc306144067cd7b927db1c (commit)

- Log -
commit e4afbb6d21788eb338dc306144067cd7b927db1c
Author: Jelmer Vernooij [EMAIL PROTECTED]
Date:   Sun Oct 5 18:34:40 2008 +0200

Make run.

commit f7cb58060138010fc5049f4bc26efd98e3946937
Author: Jelmer Vernooij [EMAIL PROTECTED]
Date:   Sun Oct 5 18:17:01 2008 +0200

Build python bindings.

commit 517fa8fbb87b6aeab7f593b1375d6439bf22c49a
Author: Jelmer Vernooij [EMAIL PROTECTED]
Date:   Sun Oct 5 17:15:55 2008 +0200

Initial work converting gregedit to python.

commit d46fade751daeae5be3e57a109c7a2fd51929b33
Author: Jelmer Vernooij [EMAIL PROTECTED]
Date:   Sun Oct 5 16:54:53 2008 +0200

Change gepdump to a script in the build system.

commit 561ae8fd15e35af87bd1d6b84d64aa2321a8bd69
Author: Jelmer Vernooij [EMAIL PROTECTED]
Date:   Sun Oct 5 16:50:21 2008 +0200

Convert gepdump to Python (incomplete)

---


hooks/post-receive
--
Samba GTK+ frontends

[SCM] Samba Shared Repository - branch master updated - 1a228b442e9382167872fb863529001ac71d7567

2008-10-05 Thread Volker Lendecke 
The branch, master has been updated
   via  1a228b442e9382167872fb863529001ac71d7567 (commit)
  from  9542b2fe60482382459d387294fb92c182f35d64 (commit)

http://gitweb.samba.org/?p=samba.git;a=shortlog;h=master


- Log -
commit 1a228b442e9382167872fb863529001ac71d7567
Author: Volker Lendecke [EMAIL PROTECTED]
Date:   Sun Oct 5 20:47:00 2008 +0200

smbd3 is unhappy if stderr is not open

---

Summary of changes:
 source4/smb_server/smb_samba3.c |3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)


Changeset truncated at 500 lines:

diff --git a/source4/smb_server/smb_samba3.c b/source4/smb_server/smb_samba3.c
index 7b32298..259d290 100644
--- a/source4/smb_server/smb_samba3.c
+++ b/source4/smb_server/smb_samba3.c
@@ -52,7 +52,8 @@ static void samba3_smb_accept(struct stream_connection *conn)
close(1);
dup2(fd, 0);
dup2(fd, 1);
-   for (i=2;i256;i++) {
+   dup2(fd, 2);
+   for (i=3;i256;i++) {
close(i);
}
 


-- 
Samba Shared Repository

[SCM] Samba Shared Repository - branch master updated - 41ee314438fe15d3bdd6a86ad5acf953c255011c

2008-10-05 Thread Volker Lendecke 
The branch, master has been updated
   via  41ee314438fe15d3bdd6a86ad5acf953c255011c (commit)
  from  1a228b442e9382167872fb863529001ac71d7567 (commit)

http://gitweb.samba.org/?p=samba.git;a=shortlog;h=master


- Log -
commit 41ee314438fe15d3bdd6a86ad5acf953c255011c
Author: Volker Lendecke [EMAIL PROTECTED]
Date:   Sun Oct 5 16:14:27 2008 +0200

Fix some nonempty blank lines

---

Summary of changes:
 source3/libsmb/cliquota.c |   50 ++--
 1 files changed, 25 insertions(+), 25 deletions(-)


Changeset truncated at 500 lines:

diff --git a/source3/libsmb/cliquota.c b/source3/libsmb/cliquota.c
index f369d28..dcdfec2 100644
--- a/source3/libsmb/cliquota.c
+++ b/source3/libsmb/cliquota.c
@@ -2,17 +2,17 @@
Unix SMB/CIFS implementation.
client quota functions
Copyright (C) Stefan (metze) Metzmacher 2003
-   
+
This program is free software; you can redistribute it and/or modify
it under the terms of the GNU General Public License as published by
the Free Software Foundation; either version 3 of the License, or
(at your option) any later version.
-   
+
This program is distributed in the hope that it will be useful,
but WITHOUT ANY WARRANTY; without even the implied warranty of
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
GNU General Public License for more details.
-   
+
You should have received a copy of the GNU General Public License
along with this program.  If not, see http://www.gnu.org/licenses/.
 */
@@ -25,7 +25,7 @@ bool cli_get_quota_handle(struct cli_state *cli, int 
*quota_fnum)
 0x0016, DESIRED_ACCESS_PIPE,
 0x, FILE_SHARE_READ|FILE_SHARE_WRITE,
 FILE_OPEN, 0x, 0x03);
-
+
if (*quota_fnum == (-1)) {
return False;
}
@@ -37,7 +37,7 @@ void free_ntquota_list(SMB_NTQUOTA_LIST **qt_list)
 {
if (!qt_list)
return;
-   
+
if ((*qt_list)-mem_ctx)
talloc_destroy((*qt_list)-mem_ctx);
 
@@ -60,7 +60,7 @@ static bool parse_user_quota_record(const char *rdata, 
unsigned int rdata_count,
if (rdata_count  40) {
return False;
}
-   
+
/* offset to next quota record.
 * 4 bytes IVAL(rdata,0)
 * unused here...
@@ -116,7 +116,7 @@ static bool parse_user_quota_record(const char *rdata, 
unsigned int rdata_count,
return False;
}
 #endif /* LARGE_SMB_OFF_T */
-   
+
sid_parse(rdata+40,sid_len,qt.sid);
 
qt.qtype = SMB_USER_QUOTA_TYPE;
@@ -149,13 +149,13 @@ bool cli_get_user_quota(struct cli_state *cli, int 
quota_fnum, SMB_NTQUOTA_STRUC
SIVAL(params, 4,0x0024);
SIVAL(params, 8,0x);
SIVAL(params,12,0x0024);
-   
+
sid_len = ndr_size_dom_sid(pqt-sid, 0);
data_len = sid_len+8;
SIVAL(data, 0, 0x);
SIVAL(data, 4, sid_len);
sid_linearize(data+8, sid_len, pqt-sid);
-   
+
if (!cli_send_nt_trans(cli, 
   NT_TRANSACT_GET_USER_QUOTA, 
   0, 
@@ -204,7 +204,7 @@ bool cli_set_user_quota(struct cli_state *cli, int 
quota_fnum, SMB_NTQUOTA_STRUC
unsigned int rparam_count=0, rdata_count=0;
unsigned int sid_len;   
memset(data,'\0',112);
-   
+
if (!cli||!pqt) {
smb_panic(cli_set_user_quota() called with NULL Pointer!);
}
@@ -221,7 +221,7 @@ bool cli_set_user_quota(struct cli_state *cli, int 
quota_fnum, SMB_NTQUOTA_STRUC
SBIG_UINT(data,24,pqt-softlim);
SBIG_UINT(data,32,pqt-hardlim);
sid_linearize(data+40, sid_len, pqt-sid);
-   
+
if (!cli_send_nt_trans(cli, 
   NT_TRANSACT_SET_USER_QUOTA, 
   0, 
@@ -278,7 +278,7 @@ bool cli_list_user_quota(struct cli_state *cli, int 
quota_fnum, SMB_NTQUOTA_LIST
SIVAL(params, 4,0x);
SIVAL(params, 8,0x);
SIVAL(params,12,0x);
-   
+
if (!cli_send_nt_trans(cli, 
   NT_TRANSACT_GET_USER_QUOTA, 
   0, 
@@ -353,7 +353,7 @@ bool cli_list_user_quota(struct cli_state *cli, int 
quota_fnum, SMB_NTQUOTA_LIST
DEBUG(1,(Failed to send 
NT_TRANSACT_GET_USER_QUOTA\n));
goto cleanup;
}
-   
+
SAFE_FREE(rparam);
SAFE_FREE(rdata);
if (!cli_receive_nt_trans(cli,
@@ -369,7 +369,7 @@ bool cli_list_user_quota(struct cli_state *cli, int 
quota_fnum, SMB_NTQUOTA_LIST
} else {
ret = True;
}
-

[SCM] Samba Shared Repository - branch v3-3-test updated - release-3-2-0pre2-4222-ga7ba58e

2008-10-05 Thread Jeremy Allison 
The branch, v3-3-test has been updated
   via  a7ba58ebede769e944005adaecbeda237ba9b5e0 (commit)
   via  3a848570996c7df8c3230e0b3a9369b41658a650 (commit)
   via  02e303b3f08656e9bf1d59dc452c7f48f2cb0dea (commit)
   via  50b86766442f27748d8d16223c8cd68fd162eabc (commit)
  from  09d76244a1e3eeeb1396a707e78325320e4e4f9e (commit)

http://gitweb.samba.org/?p=samba.git;a=shortlog;h=v3-3-test


- Log -
commit a7ba58ebede769e944005adaecbeda237ba9b5e0
Author: Volker Lendecke [EMAIL PROTECTED]
Date:   Sun Oct 5 14:35:09 2008 -0700

Remove an unused variable

commit 3a848570996c7df8c3230e0b3a9369b41658a650
Author: Volker Lendecke [EMAIL PROTECTED]
Date:   Sun Oct 5 14:33:48 2008 -0700

Fix some missing error handlings

commit 02e303b3f08656e9bf1d59dc452c7f48f2cb0dea
Author: Volker Lendecke [EMAIL PROTECTED]
Date:   Sun Oct 5 14:30:01 2008 -0700

OS/X does not have rl_done in readline.h

commit 50b86766442f27748d8d16223c8cd68fd162eabc
Author: Volker Lendecke [EMAIL PROTECTED]
Date:   Sun Oct 5 14:28:02 2008 -0700

Fix an uninitialized variable warning

Not sure if we can ever not get domain and dns_domain, but gcc complained

---

Summary of changes:
 source/lib/netapi/file.c|3 ++-
 source/lib/netapi/getdc.c   |5 +
 source/lib/netapi/share.c   |3 ++-
 source/lib/readline.c   |8 
 source/libsmb/dsgetdcname.c |2 ++
 source/utils/net_dns.c  |1 -
 6 files changed, 19 insertions(+), 3 deletions(-)


Changeset truncated at 500 lines:

diff --git a/source/lib/netapi/file.c b/source/lib/netapi/file.c
index 036af32..0d66be0 100644
--- a/source/lib/netapi/file.c
+++ b/source/lib/netapi/file.c
@@ -47,7 +47,8 @@ WERROR NetFileClose_r(struct libnetapi_ctx *ctx,
r-in.server_name,
r-in.fileid,
werr);
-   if (!W_ERROR_IS_OK(werr)) {
+   if (!NT_STATUS_IS_OK(status)) {
+   werr = ntstatus_to_werror(status);
goto done;
}
 
diff --git a/source/lib/netapi/getdc.c b/source/lib/netapi/getdc.c
index 07a6544..4069046 100644
--- a/source/lib/netapi/getdc.c
+++ b/source/lib/netapi/getdc.c
@@ -58,6 +58,11 @@ WERROR NetGetDCName_r(struct libnetapi_ctx *ctx,
   r-in.domain_name,
   (const char **)r-out.buffer,
   werr);
+
+   if (!NT_STATUS_IS_OK(status)) {
+   werr = ntstatus_to_werror(status);
+   }
+
  done:
 
return werr;
diff --git a/source/lib/netapi/share.c b/source/lib/netapi/share.c
index 1d0e181..e6aed36 100644
--- a/source/lib/netapi/share.c
+++ b/source/lib/netapi/share.c
@@ -271,7 +271,8 @@ WERROR NetShareDel_r(struct libnetapi_ctx *ctx,
   r-in.net_name,
   r-in.reserved,
   werr);
-   if (!W_ERROR_IS_OK(werr)) {
+   if (!NT_STATUS_IS_OK(status)) {
+   werr = ntstatus_to_werror(status);
goto done;
}
 
diff --git a/source/lib/readline.c b/source/lib/readline.c
index fd57799..cafb5a9 100644
--- a/source/lib/readline.c
+++ b/source/lib/readline.c
@@ -47,6 +47,14 @@
 
 static bool smb_rl_done;
 
+#if HAVE_LIBREADLINE
+/*
+ * MacOS/X does not have rl_done in readline.h, but
+ * readline.so has it
+ */
+extern int rl_done;
+#endif
+
 void smb_readline_done(void)
 {
smb_rl_done = true;
diff --git a/source/libsmb/dsgetdcname.c b/source/libsmb/dsgetdcname.c
index 2a445cb..0714aa7 100644
--- a/source/libsmb/dsgetdcname.c
+++ b/source/libsmb/dsgetdcname.c
@@ -356,6 +356,8 @@ static NTSTATUS store_cldap_reply(TALLOC_CTX *mem_ctx,
}
}
 
+   status = NT_STATUS_OK;
+
  done:
data_blob_free(blob);
 
diff --git a/source/utils/net_dns.c b/source/utils/net_dns.c
index 46f38d4..4e617a1 100644
--- a/source/utils/net_dns.c
+++ b/source/utils/net_dns.c
@@ -145,7 +145,6 @@ error:
 int get_my_ip_address( struct sockaddr_storage **pp_ss )
 
 {
-   struct iface_struct nics[MAX_INTERFACES];
int i, n;
struct sockaddr_storage *list = NULL;
int count = 0;


-- 
Samba Shared Repository

[SCM] Samba Shared Repository - branch v3-2-test updated - release-3-2-0pre2-3075-g41aed9f

2008-10-05 Thread Jeremy Allison 
The branch, v3-2-test has been updated
   via  41aed9f2f3c6d53e1b8b6d72467bc5d5a0689dce (commit)
   via  1709a099c82e9b06771b3aa562c5488a71f10c62 (commit)
   via  af055bb8d89a14ed572f76b5f8fe492e0ed98e12 (commit)
   via  e56b0b947a5c357c4e84b330c38d7a7f569be201 (commit)
  from  52365077e74e80959a42aa82cf9a6c959e2fcda5 (commit)

http://gitweb.samba.org/?p=samba.git;a=shortlog;h=v3-2-test


- Log -
commit 41aed9f2f3c6d53e1b8b6d72467bc5d5a0689dce
Author: Volker Lendecke [EMAIL PROTECTED]
Date:   Sun Oct 5 14:34:58 2008 -0700

Remove an unused variable

commit 1709a099c82e9b06771b3aa562c5488a71f10c62
Author: Volker Lendecke [EMAIL PROTECTED]
Date:   Sun Oct 5 14:34:01 2008 -0700

Fix some missing error handlings

commit af055bb8d89a14ed572f76b5f8fe492e0ed98e12
Author: Volker Lendecke [EMAIL PROTECTED]
Date:   Sun Oct 5 14:29:50 2008 -0700

OS/X does not have rl_done in readline.h

commit e56b0b947a5c357c4e84b330c38d7a7f569be201
Author: Volker Lendecke [EMAIL PROTECTED]
Date:   Sun Oct 5 14:28:33 2008 -0700

Fix an uninitialized variable warning

Not sure if we can ever not get domain and dns_domain, but gcc complained

---

Summary of changes:
 source/lib/netapi/getdc.c   |5 +
 source/lib/readline.c   |8 
 source/libsmb/dsgetdcname.c |2 ++
 source/utils/net_dns.c  |1 -
 4 files changed, 15 insertions(+), 1 deletions(-)


Changeset truncated at 500 lines:

diff --git a/source/lib/netapi/getdc.c b/source/lib/netapi/getdc.c
index c1d021b..e03660c 100644
--- a/source/lib/netapi/getdc.c
+++ b/source/lib/netapi/getdc.c
@@ -60,6 +60,11 @@ WERROR NetGetDCName_r(struct libnetapi_ctx *ctx,
   r-in.domain_name,
   (const char **)r-out.buffer,
   werr);
+
+   if (!NT_STATUS_IS_OK(status)) {
+   werr = ntstatus_to_werror(status);
+   }
+
  done:
 
return werr;
diff --git a/source/lib/readline.c b/source/lib/readline.c
index fd57799..cf7809b 100644
--- a/source/lib/readline.c
+++ b/source/lib/readline.c
@@ -47,6 +47,14 @@
 
 static bool smb_rl_done;
 
+#if HAVE_LIBREADLINE
+/*
+ *  * MacOS/X does not have rl_done in readline.h, but
+ *   * readline.so has it
+ **/
+extern int rl_done;
+#endif
+
 void smb_readline_done(void)
 {
smb_rl_done = true;
diff --git a/source/libsmb/dsgetdcname.c b/source/libsmb/dsgetdcname.c
index 8d75593..2b8f76a 100644
--- a/source/libsmb/dsgetdcname.c
+++ b/source/libsmb/dsgetdcname.c
@@ -356,6 +356,8 @@ static NTSTATUS store_cldap_reply(TALLOC_CTX *mem_ctx,
}
}
 
+   status = NT_STATUS_OK;
+
  done:
data_blob_free(blob);
 
diff --git a/source/utils/net_dns.c b/source/utils/net_dns.c
index 46f38d4..4e617a1 100644
--- a/source/utils/net_dns.c
+++ b/source/utils/net_dns.c
@@ -145,7 +145,6 @@ error:
 int get_my_ip_address( struct sockaddr_storage **pp_ss )
 
 {
-   struct iface_struct nics[MAX_INTERFACES];
int i, n;
struct sockaddr_storage *list = NULL;
int count = 0;


-- 
Samba Shared Repository

[SCM] Samba Shared Repository - branch v3-3-test updated - release-3-2-0pre2-4223-gb3735cf

2008-10-05 Thread Jeremy Allison 
The branch, v3-3-test has been updated
   via  b3735cfc098e27a2af29a4671bc4e40b47314585 (commit)
  from  a7ba58ebede769e944005adaecbeda237ba9b5e0 (commit)

http://gitweb.samba.org/?p=samba.git;a=shortlog;h=v3-3-test


- Log -
commit b3735cfc098e27a2af29a4671bc4e40b47314585
Author: Volker Lendecke [EMAIL PROTECTED]
Date:   Sun Oct 5 14:36:34 2008 -0700

Fix some nonempty blank lines

---

Summary of changes:
 source/libsmb/cliquota.c |   50 +++---
 1 files changed, 25 insertions(+), 25 deletions(-)


Changeset truncated at 500 lines:

diff --git a/source/libsmb/cliquota.c b/source/libsmb/cliquota.c
index f369d28..dcdfec2 100644
--- a/source/libsmb/cliquota.c
+++ b/source/libsmb/cliquota.c
@@ -2,17 +2,17 @@
Unix SMB/CIFS implementation.
client quota functions
Copyright (C) Stefan (metze) Metzmacher 2003
-   
+
This program is free software; you can redistribute it and/or modify
it under the terms of the GNU General Public License as published by
the Free Software Foundation; either version 3 of the License, or
(at your option) any later version.
-   
+
This program is distributed in the hope that it will be useful,
but WITHOUT ANY WARRANTY; without even the implied warranty of
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
GNU General Public License for more details.
-   
+
You should have received a copy of the GNU General Public License
along with this program.  If not, see http://www.gnu.org/licenses/.
 */
@@ -25,7 +25,7 @@ bool cli_get_quota_handle(struct cli_state *cli, int 
*quota_fnum)
 0x0016, DESIRED_ACCESS_PIPE,
 0x, FILE_SHARE_READ|FILE_SHARE_WRITE,
 FILE_OPEN, 0x, 0x03);
-
+
if (*quota_fnum == (-1)) {
return False;
}
@@ -37,7 +37,7 @@ void free_ntquota_list(SMB_NTQUOTA_LIST **qt_list)
 {
if (!qt_list)
return;
-   
+
if ((*qt_list)-mem_ctx)
talloc_destroy((*qt_list)-mem_ctx);
 
@@ -60,7 +60,7 @@ static bool parse_user_quota_record(const char *rdata, 
unsigned int rdata_count,
if (rdata_count  40) {
return False;
}
-   
+
/* offset to next quota record.
 * 4 bytes IVAL(rdata,0)
 * unused here...
@@ -116,7 +116,7 @@ static bool parse_user_quota_record(const char *rdata, 
unsigned int rdata_count,
return False;
}
 #endif /* LARGE_SMB_OFF_T */
-   
+
sid_parse(rdata+40,sid_len,qt.sid);
 
qt.qtype = SMB_USER_QUOTA_TYPE;
@@ -149,13 +149,13 @@ bool cli_get_user_quota(struct cli_state *cli, int 
quota_fnum, SMB_NTQUOTA_STRUC
SIVAL(params, 4,0x0024);
SIVAL(params, 8,0x);
SIVAL(params,12,0x0024);
-   
+
sid_len = ndr_size_dom_sid(pqt-sid, 0);
data_len = sid_len+8;
SIVAL(data, 0, 0x);
SIVAL(data, 4, sid_len);
sid_linearize(data+8, sid_len, pqt-sid);
-   
+
if (!cli_send_nt_trans(cli, 
   NT_TRANSACT_GET_USER_QUOTA, 
   0, 
@@ -204,7 +204,7 @@ bool cli_set_user_quota(struct cli_state *cli, int 
quota_fnum, SMB_NTQUOTA_STRUC
unsigned int rparam_count=0, rdata_count=0;
unsigned int sid_len;   
memset(data,'\0',112);
-   
+
if (!cli||!pqt) {
smb_panic(cli_set_user_quota() called with NULL Pointer!);
}
@@ -221,7 +221,7 @@ bool cli_set_user_quota(struct cli_state *cli, int 
quota_fnum, SMB_NTQUOTA_STRUC
SBIG_UINT(data,24,pqt-softlim);
SBIG_UINT(data,32,pqt-hardlim);
sid_linearize(data+40, sid_len, pqt-sid);
-   
+
if (!cli_send_nt_trans(cli, 
   NT_TRANSACT_SET_USER_QUOTA, 
   0, 
@@ -278,7 +278,7 @@ bool cli_list_user_quota(struct cli_state *cli, int 
quota_fnum, SMB_NTQUOTA_LIST
SIVAL(params, 4,0x);
SIVAL(params, 8,0x);
SIVAL(params,12,0x);
-   
+
if (!cli_send_nt_trans(cli, 
   NT_TRANSACT_GET_USER_QUOTA, 
   0, 
@@ -353,7 +353,7 @@ bool cli_list_user_quota(struct cli_state *cli, int 
quota_fnum, SMB_NTQUOTA_LIST
DEBUG(1,(Failed to send 
NT_TRANSACT_GET_USER_QUOTA\n));
goto cleanup;
}
-   
+
SAFE_FREE(rparam);
SAFE_FREE(rdata);
if (!cli_receive_nt_trans(cli,
@@ -369,7 +369,7 @@ bool cli_list_user_quota(struct cli_state *cli, int 
quota_fnum, SMB_NTQUOTA_LIST
} else {
ret = True;
}

[SCM] Samba GTK+ frontends branch, python, updated. fa0cae09be6572777d470e015a8187719b9b5b22

2008-10-05 Thread Jelmer Vernooij 
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project Samba GTK+ frontends.

The branch, python has been updated
   via  fa0cae09be6572777d470e015a8187719b9b5b22 (commit)
   via  1e710ff25bff5d9329e72dbbb8279b6ef0e71f50 (commit)
   via  744697422580d44775e646d9e02466076c366931 (commit)
   via  b337522691ad6a23a6f1cf5df8839ba8d58bd793 (commit)
  from  e4afbb6d21788eb338dc306144067cd7b927db1c (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -
commit fa0cae09be6572777d470e015a8187719b9b5b22
Author: Jelmer Vernooij [EMAIL PROTECTED]
Date:   Mon Oct 6 00:45:05 2008 +0200

Ignore generated file.

commit 1e710ff25bff5d9329e72dbbb8279b6ef0e71f50
Author: Jelmer Vernooij [EMAIL PROTECTED]
Date:   Mon Oct 6 00:32:16 2008 +0200

Add Python bindings for some more methods.

commit 744697422580d44775e646d9e02466076c366931
Author: Jelmer Vernooij [EMAIL PROTECTED]
Date:   Sun Oct 5 23:08:45 2008 +0200

Use pygtk script for generating python bindings.

commit b337522691ad6a23a6f1cf5df8839ba8d58bd793
Author: Jelmer Vernooij [EMAIL PROTECTED]
Date:   Sun Oct 5 22:07:52 2008 +0200

Search for pygtk.

---

Summary of changes:
 .gitignore   |1 +
 Makefile |   15 +-
 Makefile.settings.in |3 +
 common/gtk-smb.c |   12 -
 common/gtk-smb.h |   10 ++--
 common/select.c  |2 +-
 configure.ac |1 +
 gepdump  |2 +-
 pysambagtk.c |  121 +-
 python/module.c  |   18 +++
 python/sambagtk.defs |   34 +
 python/sambagtk.override |   14 +
 12 files changed, 198 insertions(+), 35 deletions(-)
 create mode 100644 python/module.c
 create mode 100644 python/sambagtk.defs
 create mode 100644 python/sambagtk.override


hooks/post-receive
--
Samba GTK+ frontends

Build status as of Mon Oct 6 00:00:02 2008

2008-10-05 Thread build 
URL: http://build.samba.org/

--- /home/build/master/cache/broken_results.txt.old 2008-10-05 
00:00:55.0 +
+++ /home/build/master/cache/broken_results.txt 2008-10-06 00:00:40.0 
+
@@ -1,4 +1,4 @@
-Build status as of Sun Oct  5 00:00:01 2008
+Build status as of Mon Oct  6 00:00:02 2008
 
 Build counts:
 Tree Total  Broken Panic 
@@ -7,17 +7,17 @@
 ctdb 0  0  0 
 distcc   1  0  0 
 ldb  33 32 0 
-libreplace   31 12 0 
+libreplace   30 12 0 
 lorikeet-heimdal 29 20 0 
 pidl 19 19 0 
-ppp  14 0  0 
-rsync32 11 0 
+ppp  13 0  0 
+rsync33 11 0 
 samba-docs   0  0  0 
 samba-gtk7  7  0 
-samba_3_X_devel 28 14 0 
-samba_3_X_test 29 18 0 
-samba_4_0_test 31 28 1 
-smb-build31 7  0 
+samba_3_X_devel 28 16 0 
+samba_3_X_test 28 16 0 
+samba_4_0_test 31 28 2 
+smb-build30 7  0 
 talloc   32 29 0 
 tdb  32 12 0

[SCM] Samba GTK+ frontends branch, python, updated. 4c416095c22d23e66fd519d807ef4c813ed850ad

2008-10-05 Thread Jelmer Vernooij 
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project Samba GTK+ frontends.

The branch, python has been updated
   via  4c416095c22d23e66fd519d807ef4c813ed850ad (commit)
  from  fa0cae09be6572777d470e015a8187719b9b5b22 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -
commit 4c416095c22d23e66fd519d807ef4c813ed850ad
Author: Jelmer Vernooij [EMAIL PROTECTED]
Date:   Mon Oct 6 02:10:30 2008 +0200

More work converting gregedit to python.

---

Summary of changes:
 gepdump  |3 +-
 gregedit |  568 +-
 2 files changed, 231 insertions(+), 340 deletions(-)


hooks/post-receive
--
Samba GTK+ frontends

[SCM] Samba GTK+ frontends branch, python, updated. 40f6ec1b554c75313dd1a474dbef7a6d02ab74b2

2008-10-05 Thread Jelmer Vernooij 
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project Samba GTK+ frontends.

The branch, python has been updated
   via  40f6ec1b554c75313dd1a474dbef7a6d02ab74b2 (commit)
  from  4c416095c22d23e66fd519d807ef4c813ed850ad (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -
commit 40f6ec1b554c75313dd1a474dbef7a6d02ab74b2
Author: Jelmer Vernooij [EMAIL PROTECTED]
Date:   Mon Oct 6 02:21:30 2008 +0200

Add constructor for RpcConnectDialog

---

Summary of changes:
 python/sambagtk.defs |9 +
 1 files changed, 9 insertions(+), 0 deletions(-)


hooks/post-receive
--
Samba GTK+ frontends