[Samba] Cups + Samba + Vista?

2008-11-23 Thread Adam McCarthy
I have followed the various guides online for setting up Cups and
Samba, to where you can just right click a print and choice connect
and the printer just works but then it does not work with Vista. It
seems to print out tons of junk.

Is there a way to make Vista work with Cups + Samba?
-- 
To unsubscribe from this list go to the following URL and read the
instructions:  https://lists.samba.org/mailman/listinfo/samba


[Samba] how 2003 domain can force samba to use ADS mode

2008-11-23 Thread pablo
I've inherited someone else's 2003 domain.  Upon trying to join a new
samba server to the domain using 'security = domain' mode, I realized
the 2003 DC's were not having it.

I setup a krb.conf file, added my 'realm = ' line to smb.conf, and
changed 'security = domain' to 'security = ads'.  I was then able to
join the 2003 domain using 'net ads join ...'.

My question is where  how is the 2003 domain forcing the use of
kerberos authentication to join a domain?  I've looked thru all the
GPO's and googled this, but am still at a loss.

I mainly want to know now for educational purposes.  It's not urgent, as
samba is working fine in ADS mode.  But this will drive me nuts until I
figure out how it's doing this.

TIA for your help.

-- 
Pablo
-- 
To unsubscribe from this list go to the following URL and read the
instructions:  https://lists.samba.org/mailman/listinfo/samba


Re: [Samba] how 2003 domain can force samba to use ADS mode

2008-11-23 Thread Norberto Bensa

Quoting [EMAIL PROTECTED]:


My question is where  how is the 2003 domain forcing the use of
kerberos authentication to join a domain?


Maybe your AD is running in native mode






This message was sent using IMP, the Internet Messaging Program.


--
To unsubscribe from this list go to the following URL and read the
instructions:  https://lists.samba.org/mailman/listinfo/samba


[Samba] Problem with Samba

2008-11-23 Thread Ross, Brian
Yes, another newbie asking for help.  Please bear with me.  I don't doubt my 
problem has a simple solution but it has me stumped.

I have a solaris server which carries some confidential financial information 
on it.  I have been asked to install samba on it to share out a particular 
directory.  They obviously want to restrict access to this information.  We run 
a Windows 2003 domain as well.  My problem is that I cannot get my samba server 
to ask for user authentication (or rather, I can, if I slightly change the 
smb.conf file but then it asks for Guest rather than the user designated).   
My smb.conf file is:

___
[global]
workgroup = CALM
server string = calm-kens-27
security = DOMAIN
password server = 192.147.114.4, 192.147.114.17
username map = /etc/samba/smbusers
log file = /var/log/samba
max log size = 200
; min protocol = NT1
; preferred master = No
; local master = No
; domain master = No
; browse list = No
; enhanced browsing = No
dns proxy = No
wins server = 192.147.114.4
; ldap ssl = no
hosts allow = 
localhost,calm-kens-27,192.147.114.,192.147.114.54,10.20.201.59,10.20.200.119,10.20.201.88,10.20.201.175
hosts deny = All
;hosts allow = all
encrypt passwords = yes
browseable = no
;smb passwd file = /etc/samba/smbpasswd



[CBA]
path = /u02/prod/clmfinpr/clmfinprappl/calm/11.5.0/secure
comment = DEC read only share
read only = Yes
guest ok = no
;force user = finance
;force group = sw_user
hide dot files = No
inherit permissions = Yes
___

On another not unrelated problem, I am unable to get SWAT to work.   I keep 
getting the message:

This document contains no data, Try again later or contact the domain's 
administrator

Any idea about how to get it working (this I suspect will help me to cure my 
configuration problem).

Cheers

Brian 


___

Brian Ross
 
  



This email, together with any attachments, is intended for the
addressee only. It may contain confidential or privileged information.
If you are not the intended recipient of this email, please notify
the sender, delete the email and attachments from your system and
destroy any copies you may have taken of the email and its attachments.
Duplication or further distribution by hardcopy, by electronic means
or verbally is not permitted without permission.
--
To unsubscribe from this list go to the following URL and read the
instructions:  https://lists.samba.org/mailman/listinfo/samba


[Samba] Joining ADS: unodocumented error

2008-11-23 Thread Alessandro Baretta

Hi everyone,

I am trying to set up a file server on Linux for Windows XP boxes in a 
Windows Server 2003 environment. I followed an excellent tutorial on 
Samba and ADS, which I recommend to all newbies like myself: 
http://www.enterprisenetworkingplanet.com/netos/article.php/3487081. 
Kerberos authentication seems to succeed, and apparently there is 
nothing wrong with my smb.conf file, yet when I try to add the server to 
the ADS I get the following error message: Failed to join domain: 
Invalid configuration and configuration modification was not requested. 
This error seems to be undocumented: I have found nothing either on 
Google or on the samba.org site.


Here's a transcript of a shell session showing this error.


samba:~# kinit
Password for [EMAIL PROTECTED]: --- Authentication succeeds
samba:~# testparm
Load smb config files from /etc/samba/smb.conf
Processing section [homes]
Processing section [fileserver]
Processing section [printers]
Processing section [print$]
Loaded services file OK.
Server role: ROLE_DOMAIN_MEMBER
Press enter to see a dump of your service definitions

[global]
   workgroup = ARM.PRIV
   realm = ARM.PRIV
   server string = File server avanzato
   security = ADS
   log level = 3
   syslog = 0
   log file = /var/log/samba/log.%m
   max log size = 1000
   panic action = /usr/share/samba/panic-action %d
   idmap uid = 1-2
   idmap gid = 1-2

[homes]
   comment = Home Directories
   valid users = %S
   create mask = 0700
   directory mask = 0700
   browseable = No

[fileserver]
   comment = Cartelle condivise
   path = /var/samba
   read only = No
   create mask = 0700

[printers]
   comment = All Printers
   path = /var/spool/samba
   create mask = 0700
   printable = Yes
   browseable = No

[print$]
   comment = Printer Drivers
   path = /var/lib/samba/printers
samba:~# net ads join -U administrator
Enter administrator's password:
Failed to join domain: Invalid configuration and configuration 
modification was not requested
  
^^


If I mistype the password I get a different error message:
samba:~# net ads join -U administrator%wrongpassword
Failed to join domain: failed to lookup DC info for domain 'ARM.PRIV' 
over rpc: Logon failure



Can anyone help me?

--
Alessandro Baretta

World Family of Radio Maria
http://www.radiomaria.org/

tel. +39 0332 228 150
fax. +39 0332 222 411
cel. +39 335 830 3189
skype alex.baretta
ekiga [EMAIL PROTECTED]

--
To unsubscribe from this list go to the following URL and read the
instructions:  https://lists.samba.org/mailman/listinfo/samba


Re: [Samba] how 2003 domain can force samba to use ADS mode

2008-11-23 Thread pablo
On Mon, Nov 24, 2008 at 12:35:22AM -0200, Norberto Bensa wrote:
 Quoting [EMAIL PROTECTED]:

 My question is where  how is the 2003 domain forcing the use of
 kerberos authentication to join a domain?

 Maybe your AD is running in native mode

It is.  It's running in Native mode at a functionality level of Windows
2000.  However, I setup a fresh 2003 server  domain in a virtual
machine, also in native mode just like my current domain, and am able to
join the domain with a samba machine using 'net rpc join' and NTLM
authentication.
-- 
To unsubscribe from this list go to the following URL and read the
instructions:  https://lists.samba.org/mailman/listinfo/samba


Re: [Samba] Joining ADS: unodocumented error

2008-11-23 Thread pablo
On Mon, Nov 24, 2008 at 03:47:52AM +0100, Alessandro Baretta wrote:
 Hi everyone,

 I am trying to set up a file server on Linux for Windows XP boxes in a  
 Windows Server 2003 environment. I followed an excellent tutorial on  
 Samba and ADS, which I recommend to all newbies like myself:  
 http://www.enterprisenetworkingplanet.com/netos/article.php/3487081.  
 Kerberos authentication seems to succeed, and apparently there is  
 nothing wrong with my smb.conf file, yet when I try to add the server to  
 the ADS I get the following error message: Failed to join domain:  
 Invalid configuration and configuration modification was not requested.  
 This error seems to be undocumented: I have found nothing either on  
 Google or on the samba.org site.

 Here's a transcript of a shell session showing this error.


 samba:~# kinit
 Password for [EMAIL PROTECTED]: --- Authentication succeeds
 samba:~# testparm
 Load smb config files from /etc/samba/smb.conf
 Processing section [homes]
 Processing section [fileserver]
 Processing section [printers]
 Processing section [print$]
 Loaded services file OK.
 Server role: ROLE_DOMAIN_MEMBER
 Press enter to see a dump of your service definitions

 [global]
workgroup = ARM.PRIV
realm = ARM.PRIV
server string = File server avanzato
security = ADS
log level = 3
syslog = 0
log file = /var/log/samba/log.%m
max log size = 1000
panic action = /usr/share/samba/panic-action %d
idmap uid = 1-2
idmap gid = 1-2

 [homes]
comment = Home Directories
valid users = %S
create mask = 0700
directory mask = 0700
browseable = No

 [fileserver]
comment = Cartelle condivise
path = /var/samba
read only = No
create mask = 0700

 [printers]
comment = All Printers
path = /var/spool/samba
create mask = 0700
printable = Yes
browseable = No

 [print$]
comment = Printer Drivers
path = /var/lib/samba/printers
 samba:~# net ads join -U administrator
 Enter administrator's password:
 Failed to join domain: Invalid configuration and configuration  
 modification was not requested

 ^^

 If I mistype the password I get a different error message:
 samba:~# net ads join -U administrator%wrongpassword
 Failed to join domain: failed to lookup DC info for domain 'ARM.PRIV'  
 over rpc: Logon failure


 Can anyone help me?

 -- 
 Alessandro Baretta


A couple of things to try.
1. Try the 'net join' command by getting rid of the space after the -U
and type the username in caps, as follows:
net ads join -UADMINISTRATOR
* Mine failed to join with a similar error as yours, then without
* changing any configuration, I did what I suggested above and the join
* succeeded.
2. If that didn't work, try changing 'workgroup = ARM.PRIV' to 'workgroup = 
ARM' in smb.conf.
Then try joining again via 'net ads join ...'.



-- 
To unsubscribe from this list go to the following URL and read the
instructions:  https://lists.samba.org/mailman/listinfo/samba


Re: [Samba] Joining ADS: unodocumented error

2008-11-23 Thread pablo
On Mon, Nov 24, 2008 at 03:47:52AM +0100, Alessandro Baretta wrote:
 Hi everyone,

 I am trying to set up a file server on Linux for Windows XP boxes in a  
 Windows Server 2003 environment. I followed an excellent tutorial on  
 Samba and ADS, which I recommend to all newbies like myself:  
 http://www.enterprisenetworkingplanet.com/netos/article.php/3487081.  
 Kerberos authentication seems to succeed, and apparently there is  
 nothing wrong with my smb.conf file, yet when I try to add the server to  
 the ADS I get the following error message: Failed to join domain:  
 Invalid configuration and configuration modification was not requested.  
 This error seems to be undocumented: I have found nothing either on  
 Google or on the samba.org site.

 Here's a transcript of a shell session showing this error.


 samba:~# kinit
 Password for [EMAIL PROTECTED]: --- Authentication succeeds
 samba:~# testparm
 Load smb config files from /etc/samba/smb.conf
 Processing section [homes]
 Processing section [fileserver]
 Processing section [printers]
 Processing section [print$]
 Loaded services file OK.
 Server role: ROLE_DOMAIN_MEMBER
 Press enter to see a dump of your service definitions

 [global]
workgroup = ARM.PRIV
realm = ARM.PRIV
server string = File server avanzato
security = ADS
log level = 3
syslog = 0
log file = /var/log/samba/log.%m
max log size = 1000
panic action = /usr/share/samba/panic-action %d
idmap uid = 1-2
idmap gid = 1-2

 [homes]
comment = Home Directories
valid users = %S
create mask = 0700
directory mask = 0700
browseable = No

 [fileserver]
comment = Cartelle condivise
path = /var/samba
read only = No
create mask = 0700

 [printers]
comment = All Printers
path = /var/spool/samba
create mask = 0700
printable = Yes
browseable = No

 [print$]
comment = Printer Drivers
path = /var/lib/samba/printers
 samba:~# net ads join -U administrator
 Enter administrator's password:
 Failed to join domain: Invalid configuration and configuration  
 modification was not requested

 ^^

 If I mistype the password I get a different error message:
 samba:~# net ads join -U administrator%wrongpassword
 Failed to join domain: failed to lookup DC info for domain 'ARM.PRIV'  
 over rpc: Logon failure


 Can anyone help me?

 -- 
 Alessandro Baretta

 World Family of Radio Maria
 http://www.radiomaria.org/

 tel. +39 0332 228 150
 fax. +39 0332 222 411
 cel. +39 335 830 3189
 skype alex.baretta
 ekiga [EMAIL PROTECTED]

 -- 
 To unsubscribe from this list go to the following URL and read the
 instructions:  https://lists.samba.org/mailman/listinfo/samba

Alessandro,

I was able to reproduce your problem on my virtual machines. By that I
mean that in trying to join a 2003 domain in ADS mode, I get the exact
same error as you.

I was able to solve it as explained below.  Keep in mind that the same
error may be caused by different problems.  

My test domain name is 'DOMAIN', and my realm is 'DOMAIN.COM'.  

Setting either of the of 2 following lines caused the error indicated:
workgroup   = DOMAIN.COM
or
realm   = DOMAIN

Setting as follows, I joined the domain no problem.
workgroup   = DOMAIN
realm   = DOMAIN.COM

So it appears the domain name is the leftmost portion of the REALM, and
the REALM must be the entire name.  Anything else will fail.

So try changing your workgroup line setting it as follows:
workgroup = ARM

I believe you will then be able to join sambe to the 2003 domain.

Give it a shot and let me know.

--
Pablo

-- 
To unsubscribe from this list go to the following URL and read the
instructions:  https://lists.samba.org/mailman/listinfo/samba


[SCM] Samba Shared Repository - branch master updated - 34fc529d95c3e45e7c4b81246864b3de5ca73fd8

2008-11-23 Thread Volker Lendecke
The branch, master has been updated
   via  34fc529d95c3e45e7c4b81246864b3de5ca73fd8 (commit)
   via  3080fd66243f8f0c4b34be845a7dfd922242b685 (commit)
  from  09bc3a2f9c3847aafdb2e6cc2651baba62f2489e (commit)

http://gitweb.samba.org/?p=samba.git;a=shortlog;h=master


- Log -
commit 34fc529d95c3e45e7c4b81246864b3de5ca73fd8
Author: Volker Lendecke [EMAIL PROTECTED]
Date:   Sun Nov 23 12:13:48 2008 +0100

fix the build

commit 3080fd66243f8f0c4b34be845a7dfd922242b685
Author: Stefan Metzmacher [EMAIL PROTECTED]
Date:   Sun Nov 23 11:24:29 2008 +0100

RPC sessions on np connections need the real session key transferred

---

Summary of changes:
 source4/rpc_server/dcerpc_server.c |4 ++--
 source4/rpc_server/service_rpc.c   |5 +
 source4/utils/net/net_machinepw.c  |2 +-
 3 files changed, 8 insertions(+), 3 deletions(-)


Changeset truncated at 500 lines:

diff --git a/source4/rpc_server/dcerpc_server.c 
b/source4/rpc_server/dcerpc_server.c
index 6f3f679..6e888e5 100644
--- a/source4/rpc_server/dcerpc_server.c
+++ b/source4/rpc_server/dcerpc_server.c
@@ -251,8 +251,8 @@ _PUBLIC_ NTSTATUS dcesrv_interface_register(struct 
dcesrv_context *dce_ctx,
return NT_STATUS_OK;
 }
 
-static NTSTATUS dcesrv_inherited_session_key(struct dcesrv_connection *p,
- DATA_BLOB *session_key)
+NTSTATUS dcesrv_inherited_session_key(struct dcesrv_connection *p,
+ DATA_BLOB *session_key)
 {
if (p-auth_state.session_info-session_key.length) {
*session_key = p-auth_state.session_info-session_key;
diff --git a/source4/rpc_server/service_rpc.c b/source4/rpc_server/service_rpc.c
index e526b17..bb4d6bd 100644
--- a/source4/rpc_server/service_rpc.c
+++ b/source4/rpc_server/service_rpc.c
@@ -27,6 +27,7 @@
 #include auth/gensec/gensec.h
 #include ../lib/util/dlinklist.h
 #include rpc_server/dcerpc_server.h
+#include rpc_server/dcerpc_server_proto.h
 #include lib/events/events.h
 #include smbd/service_task.h
 #include smbd/service_stream.h
@@ -139,6 +140,10 @@ static void dcesrv_sock_accept(struct stream_connection 
*srv_conn)
dcesrv_conn-transport.get_my_addr  = 
dcesrv_sock_get_my_addr;
dcesrv_conn-transport.get_peer_addr= 
dcesrv_sock_get_peer_addr;
 
+   if (dcesrv_sock-endpoint-ep_description-transport == NCACN_NP) {
+   dcesrv_conn-auth_state.session_key = 
dcesrv_inherited_session_key;
+   }
+
srv_conn-private = dcesrv_conn;
 
irpc_add_name(srv_conn-msg_ctx, rpc_server);
diff --git a/source4/utils/net/net_machinepw.c 
b/source4/utils/net/net_machinepw.c
index 8c2fac9..710d889 100644
--- a/source4/utils/net/net_machinepw.c
+++ b/source4/utils/net/net_machinepw.c
@@ -25,6 +25,7 @@
 #include param/secrets.h
 #include param/param.h
 #include lib/events/events.h
+#include lib/util/util_ldb.h
 
 int net_machinepw_usage(struct net_context *ctx, int argc, const char **argv)
 {
@@ -38,7 +39,6 @@ int net_machinepw(struct net_context *ctx, int argc, const 
char **argv)
TALLOC_CTX *mem_ctx;
struct event_context *ev;
struct ldb_message **msgs;
-   int res;
int num_records;
const char *attrs[] = { secret, NULL };
const char *secret;


-- 
Samba Shared Repository


[SCM] Samba Shared Repository - branch master updated - 9c3173142d3c9e0157a76ed32987cfb910d49a93

2008-11-23 Thread Volker Lendecke
The branch, master has been updated
   via  9c3173142d3c9e0157a76ed32987cfb910d49a93 (commit)
  from  34fc529d95c3e45e7c4b81246864b3de5ca73fd8 (commit)

http://gitweb.samba.org/?p=samba.git;a=shortlog;h=master


- Log -
commit 9c3173142d3c9e0157a76ed32987cfb910d49a93
Author: Volker Lendecke [EMAIL PROTECTED]
Date:   Sun Nov 23 19:37:36 2008 +0100

Fix an uninitialized variable warning

Andreas Schneider, please check!

---

Summary of changes:
 source3/nsswitch/pam_winbind.c |2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)


Changeset truncated at 500 lines:

diff --git a/source3/nsswitch/pam_winbind.c b/source3/nsswitch/pam_winbind.c
index 1daa05e..be22ff3 100644
--- a/source3/nsswitch/pam_winbind.c
+++ b/source3/nsswitch/pam_winbind.c
@@ -2316,7 +2316,7 @@ static int _pam_delete_cred(pam_handle_t *pamh, int flags,
struct wbcLogoffUserParams logoff;
struct wbcAuthErrorInfo *error = NULL;
const char *user;
-   wbcErr wbc_status;
+   wbcErr wbc_status = WBC_ERR_SUCCESS;
 
retval = _pam_winbind_init_context(pamh, flags, argc, argv, ctx);
if (retval) {


-- 
Samba Shared Repository


[SCM] Samba Shared Repository - branch master updated - 526c609d5f4d892e534fa3db42d5e2cf103b08f3

2008-11-23 Thread Kai Blin
The branch, master has been updated
   via  526c609d5f4d892e534fa3db42d5e2cf103b08f3 (commit)
   via  671d68d573e1b39ab816989b6d5bf41da3f56e78 (commit)
  from  9c3173142d3c9e0157a76ed32987cfb910d49a93 (commit)

http://gitweb.samba.org/?p=samba.git;a=shortlog;h=master


- Log -
commit 526c609d5f4d892e534fa3db42d5e2cf103b08f3
Author: Kai Blin [EMAIL PROTECTED]
Date:   Sun Nov 23 22:20:58 2008 +0100

s3-rpcclient: Fix a compile warning.

commit 671d68d573e1b39ab816989b6d5bf41da3f56e78
Author: Kai Blin [EMAIL PROTECTED]
Date:   Mon Nov 17 16:38:02 2008 +0100

ctags: Ignore source3/includes/proto.h for tags.

---

Summary of changes:
 source3/Makefile.in|2 +-
 source3/rpc_client/init_netlogon.c |2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)


Changeset truncated at 500 lines:

diff --git a/source3/Makefile.in b/source3/Makefile.in
index 60ea4e2..37c48d4 100644
--- a/source3/Makefile.in
+++ b/source3/Makefile.in
@@ -2791,7 +2791,7 @@ etags::
etags --append `find $(srcdir)/../source4/dsdb -name *.[ch]`
 
 ctags::
-   ctags `find $(srcdir)/.. -name *.[ch]`
+   ctags `find $(srcdir)/.. -name *.[ch] | grep -v include/proto\.h`
 
 realclean:: clean
-rm -f config.log bin/.dummy script/findsmb script/gen-8bit-gap.sh
diff --git a/source3/rpc_client/init_netlogon.c 
b/source3/rpc_client/init_netlogon.c
index 4318a94..b2ad1a5 100644
--- a/source3/rpc_client/init_netlogon.c
+++ b/source3/rpc_client/init_netlogon.c
@@ -206,7 +206,7 @@ NTSTATUS serverinfo_to_SamInfo3(struct 
auth_serversupplied_info *server_info,
 
if (pipe_session_key  pipe_session_key_len != 16) {
DEBUG(0,(serverinfo_to_SamInfo3: invalid 
-pipe_session_key_len[%u] != 16\n,
+pipe_session_key_len[%d] != 16\n,
 pipe_session_key_len));
return NT_STATUS_INTERNAL_ERROR;
}


-- 
Samba Shared Repository


[SCM] Samba Shared Repository - branch master updated - ed27d91068ca45a2f2924cb2d53c3fdf856c5c47

2008-11-23 Thread Volker Lendecke
The branch, master has been updated
   via  ed27d91068ca45a2f2924cb2d53c3fdf856c5c47 (commit)
  from  526c609d5f4d892e534fa3db42d5e2cf103b08f3 (commit)

http://gitweb.samba.org/?p=samba.git;a=shortlog;h=master


- Log -
commit ed27d91068ca45a2f2924cb2d53c3fdf856c5c47
Author: Volker Lendecke [EMAIL PROTECTED]
Date:   Sun Nov 23 22:21:26 2008 +0100

Add auth_serversupplied_info to create_conn_struct

srvsvc needs it, as will printing

---

Summary of changes:
 source3/include/proto.h|3 ++-
 source3/rpc_server/srv_srvsvc_nt.c |   10 --
 source3/smbd/msdfs.c   |   19 +++
 3 files changed, 21 insertions(+), 11 deletions(-)


Changeset truncated at 500 lines:

diff --git a/source3/include/proto.h b/source3/include/proto.h
index 2cf1a96..a024d68 100644
--- a/source3/include/proto.h
+++ b/source3/include/proto.h
@@ -7957,7 +7957,8 @@ NTSTATUS create_conn_struct(TALLOC_CTX *ctx,
connection_struct **pconn,
int snum,
const char *path,
-   char **poldcwd);
+   struct auth_serversupplied_info *server_info,
+   char **poldcwd);
 
 /* The following definitions come from smbd/negprot.c  */
 
diff --git a/source3/rpc_server/srv_srvsvc_nt.c 
b/source3/rpc_server/srv_srvsvc_nt.c
index 9d9e9af..274deab 100644
--- a/source3/rpc_server/srv_srvsvc_nt.c
+++ b/source3/rpc_server/srv_srvsvc_nt.c
@@ -2050,7 +2050,8 @@ WERROR _srvsvc_NetGetFileSecurity(pipes_struct *p,
}
 
nt_status = create_conn_struct(talloc_tos(), conn, snum,
-  lp_pathname(snum), oldcwd);
+  lp_pathname(snum), p-server_info,
+  oldcwd);
if (!NT_STATUS_IS_OK(nt_status)) {
DEBUG(10, (create_conn_struct failed: %s\n,
   nt_errstr(nt_status)));
@@ -2058,8 +2059,6 @@ WERROR _srvsvc_NetGetFileSecurity(pipes_struct *p,
goto error_exit;
}
 
-   conn-server_info = p-server_info;
-
nt_status = create_file(
conn,   /* conn */
NULL,   /* req */
@@ -2165,7 +2164,8 @@ WERROR _srvsvc_NetSetFileSecurity(pipes_struct *p,
}
 
nt_status = create_conn_struct(talloc_tos(), conn, snum,
-  lp_pathname(snum), oldcwd);
+  lp_pathname(snum), p-server_info,
+  oldcwd);
if (!NT_STATUS_IS_OK(nt_status)) {
DEBUG(10, (create_conn_struct failed: %s\n,
   nt_errstr(nt_status)));
@@ -2173,8 +2173,6 @@ WERROR _srvsvc_NetSetFileSecurity(pipes_struct *p,
goto error_exit;
}
 
-   conn-server_info = p-server_info;
-
nt_status = create_file(
conn,   /* conn */
NULL,   /* req */
diff --git a/source3/smbd/msdfs.c b/source3/smbd/msdfs.c
index 1504b19..d46be64 100644
--- a/source3/smbd/msdfs.c
+++ b/source3/smbd/msdfs.c
@@ -219,6 +219,7 @@ NTSTATUS create_conn_struct(TALLOC_CTX *ctx,
connection_struct **pconn,
int snum,
const char *path,
+   struct auth_serversupplied_info *server_info,
char **poldcwd)
 {
connection_struct *conn;
@@ -254,6 +255,15 @@ NTSTATUS create_conn_struct(TALLOC_CTX *ctx,
 
conn-params-service = snum;
 
+   if (server_info != NULL) {
+   conn-server_info = copy_serverinfo(conn, server_info);
+   if (conn-server_info == NULL) {
+   DEBUG(0, (copy_serverinfo failed\n));
+   TALLOC_FREE(conn);
+   return NT_STATUS_NO_MEMORY;
+   }
+   }
+
set_conn_connectpath(conn, connpath);
 
if (!smbd_vfs_init(conn)) {
@@ -881,7 +891,7 @@ NTSTATUS get_referred_path(TALLOC_CTX *ctx,
}
 
status = create_conn_struct(ctx, conn, snum, lp_pathname(snum),
-   oldpath);
+   NULL, oldpath);
if (!NT_STATUS_IS_OK(status)) {
TALLOC_FREE(pdp);
return status;
@@ -1321,7 +1331,7 @@ static bool junction_to_local_path(const struct 
junction_map *jucn,
return False;
}
status = create_conn_struct(talloc_tos(), conn_out, snum,
-   lp_pathname(snum), oldpath);
+

[SCM] Samba Shared Repository - branch v3-3-test updated - release-3-2-0pre2-4513-g66d8109

2008-11-23 Thread Kai Blin
The branch, v3-3-test has been updated
   via  66d8109119d4a840584bda42b4bb98d2c7ee2417 (commit)
  from  5572b01ae515405ca0da3d2913fe30294caa3516 (commit)

http://gitweb.samba.org/?p=samba.git;a=shortlog;h=v3-3-test


- Log -
commit 66d8109119d4a840584bda42b4bb98d2c7ee2417
Author: Kai Blin [EMAIL PROTECTED]
Date:   Sun Nov 23 22:31:12 2008 +0100

tags: Ignore include/proto.h from tag generation

---

Summary of changes:
 source/Makefile.in |4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)


Changeset truncated at 500 lines:

diff --git a/source/Makefile.in b/source/Makefile.in
index a25efb5..5e1aed4 100644
--- a/source/Makefile.in
+++ b/source/Makefile.in
@@ -2703,10 +2703,10 @@ proto::
 .PHONY: proto
 
 etags:
-   etags `find $(srcdir) -name *.[ch] | grep -v /.svn/`
+   etags `find $(srcdir) -name *.[ch] | grep -v include/proto\.h`
 
 ctags:
-   ctags `find $(srcdir) -name *.[ch] | grep -v /.svn/`
+   ctags `find $(srcdir) -name *.[ch] | grep -v include/proto\.h`
 
 realclean:: clean
-rm -f config.log bin/.dummy script/findsmb script/gen-8bit-gap.sh


-- 
Samba Shared Repository


[SCM] Samba Shared Repository - branch master updated - b416135f6b00ea23ba8ded9d425ed7226980b36d

2008-11-23 Thread Michael Adam
The branch, master has been updated
   via  b416135f6b00ea23ba8ded9d425ed7226980b36d (commit)
  from  ed27d91068ca45a2f2924cb2d53c3fdf856c5c47 (commit)

http://gitweb.samba.org/?p=samba.git;a=shortlog;h=master


- Log -
commit b416135f6b00ea23ba8ded9d425ed7226980b36d
Author: Michael Adam [EMAIL PROTECTED]
Date:   Sun Nov 23 10:43:10 2008 +0100

libcli/nbt: fix some extrasemi compile warnings.

Michael

---

Summary of changes:
 libcli/nbt/libnbt.h |6 +++---
 1 files changed, 3 insertions(+), 3 deletions(-)


Changeset truncated at 500 lines:

diff --git a/libcli/nbt/libnbt.h b/libcli/nbt/libnbt.h
index e03352d..7d8ca49 100644
--- a/libcli/nbt/libnbt.h
+++ b/libcli/nbt/libnbt.h
@@ -331,9 +331,9 @@ NTSTATUS nbt_name_reply_send(struct nbt_name_socket 
*nbtsock,
 struct nbt_name_packet *request);
 
 
-NDR_SCALAR_PROTO(wrepl_nbt_name, const struct nbt_name *);
-NDR_SCALAR_PROTO(nbt_string, const char *);
-NDR_BUFFER_PROTO(nbt_name, struct nbt_name);
+NDR_SCALAR_PROTO(wrepl_nbt_name, const struct nbt_name *)
+NDR_SCALAR_PROTO(nbt_string, const char *)
+NDR_BUFFER_PROTO(nbt_name, struct nbt_name)
 NTSTATUS nbt_rcode_to_ntstatus(uint8_t rcode);
 
 struct composite_context;


-- 
Samba Shared Repository


[SCM] Samba Shared Repository - branch master updated - a36415a5651c598e1dd28e163995e266dad51130

2008-11-23 Thread Kai Blin
The branch, master has been updated
   via  a36415a5651c598e1dd28e163995e266dad51130 (commit)
  from  b416135f6b00ea23ba8ded9d425ed7226980b36d (commit)

http://gitweb.samba.org/?p=samba.git;a=shortlog;h=master


- Log -
commit a36415a5651c598e1dd28e163995e266dad51130
Author: Kai Blin [EMAIL PROTECTED]
Date:   Sun Nov 23 23:54:27 2008 +0100

s3-rpcclient; Really fix compile warning.

Screwed up in 526c609d, now the real fix.

---

Summary of changes:
 source3/rpc_client/init_netlogon.c |2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)


Changeset truncated at 500 lines:

diff --git a/source3/rpc_client/init_netlogon.c 
b/source3/rpc_client/init_netlogon.c
index b2ad1a5..6f7a541 100644
--- a/source3/rpc_client/init_netlogon.c
+++ b/source3/rpc_client/init_netlogon.c
@@ -206,7 +206,7 @@ NTSTATUS serverinfo_to_SamInfo3(struct 
auth_serversupplied_info *server_info,
 
if (pipe_session_key  pipe_session_key_len != 16) {
DEBUG(0,(serverinfo_to_SamInfo3: invalid 
-pipe_session_key_len[%d] != 16\n,
+pipe_session_key_len[%zu] != 16\n,
 pipe_session_key_len));
return NT_STATUS_INTERNAL_ERROR;
}


-- 
Samba Shared Repository


Build status as of Mon Nov 24 00:00:01 2008

2008-11-23 Thread build
URL: http://build.samba.org/

--- /home/build/master/cache/broken_results.txt.old 2008-11-23 
00:01:02.0 +
+++ /home/build/master/cache/broken_results.txt 2008-11-24 00:00:26.0 
+
@@ -1,4 +1,4 @@
-Build status as of Sun Nov 23 00:00:01 2008
+Build status as of Mon Nov 24 00:00:01 2008
 
 Build counts:
 Tree Total  Broken Panic 
@@ -8,15 +8,15 @@
 distcc   1  0  0 
 ldb  32 32 0 
 libreplace   31 13 0 
-lorikeet-heimdal 29 20 0 
+lorikeet-heimdal 28 20 0 
 pidl 19 2  0 
 ppp  13 13 0 
 rsync32 13 0 
 samba-docs   0  0  0 
 samba-gtk5  5  0 
-samba_3_X_devel 28 19 1 
+samba_3_X_devel 28 18 0 
 samba_3_X_test 28 15 0 
-samba_4_0_test 30 29 1 
+samba_4_0_test 31 28 1 
 smb-build30 7  0 
 talloc   32 32 0 
 tdb  32 12 0 


[SCM] Samba Shared Repository - branch master updated - 798b9e1ad6bbdcf873285d0e1c5008e566744162

2008-11-23 Thread Steven Danneman
The branch, master has been updated
   via  798b9e1ad6bbdcf873285d0e1c5008e566744162 (commit)
  from  a36415a5651c598e1dd28e163995e266dad51130 (commit)

http://gitweb.samba.org/?p=samba.git;a=shortlog;h=master


- Log -
commit 798b9e1ad6bbdcf873285d0e1c5008e566744162
Author: Steven Danneman [EMAIL PROTECTED]
Date:   Sun Nov 23 18:20:19 2008 -0800

Fix to allow setting of NULL DACL/SACL

This is a modification of Jeremy's 7522ef15aca2429ef57c75d8297dd8121e79c9da
commit.

If no DACL/SACL is present in the packet, the SEC_INFO field should still be
passed down as is to the VFS layer to signal the creation of a NULL 
DACL/SACL.

As seen in metze RAW-ACL test_nttrans_create_null_dacl(), a NULL DACL is set
regardless of the SEC_DESC_DACL_PRESENT bit being set.

---

Summary of changes:
 source3/smbd/nttrans.c |   13 ++---
 1 files changed, 2 insertions(+), 11 deletions(-)


Changeset truncated at 500 lines:

diff --git a/source3/smbd/nttrans.c b/source3/smbd/nttrans.c
index 52c16e2..8a18c87 100644
--- a/source3/smbd/nttrans.c
+++ b/source3/smbd/nttrans.c
@@ -721,21 +721,12 @@ static NTSTATUS set_sd(files_struct *fsp, uint8 *data, 
uint32 sd_len,
return status;
}
 
-   if (psd-owner_sid==0) {
+   if (psd-owner_sid == NULL) {
security_info_sent = ~OWNER_SECURITY_INFORMATION;
}
-   if (psd-group_sid==0) {
+   if (psd-group_sid == NULL) {
security_info_sent = ~GROUP_SECURITY_INFORMATION;
}
-   if (psd-sacl==0) {
-   security_info_sent = ~SACL_SECURITY_INFORMATION;
-   }
-   if (security_info_sent  DACL_SECURITY_INFORMATION) {
-   psd-type |= SEC_DESC_DACL_PRESENT;
-   }
-   if (psd-dacl==0) {
-   security_info_sent = ~DACL_SECURITY_INFORMATION;
-   }
 
/* Convert all the generic bits. */
security_acl_map_generic(psd-dacl, file_generic_mapping);


-- 
Samba Shared Repository