Re: [Samba] Samba + LDAP + IIS = massive memory usage
On Fri, May 01, 2009 at 11:52:13PM +0100, Martin Edwards wrote: (Sorry, I meant to send this to the list first time around) Thanks very much for that. On a thread using 1.2GB pool-usage reports: full talloc report on 'null_context' (total 5898052 bytes in 39825 blocks) There are thousands of lib/charcnv.c:601 entries but all using only 1 block each. Can you post the whole output somewhere? Which exact Samba version was this (needed for the line number)? You wrote that it happens with many versions. And, this obviously does not account for 1.2GB, so there must be something else. Volker pgpJSlylMaGF4.pgp Description: PGP signature -- To unsubscribe from this list go to the following URL and read the instructions: https://lists.samba.org/mailman/options/samba
Re: [Samba] Re: Samba does not change UNIX password after OpenLDAP server upgraded
2009/04/30 23:38:42, 2] passdb/pdb_ldap.c:ldapsam_modify_entry(1590)
ldap password change requested, but LDAP server does not support it --
ignoring
1st, are the ldap libraries samba is compiled with the same as the ldap
server?
2nd, possibly change
password-hash {CRYPT}
to
password-hash {SSHA}
im not sure if password-crypt-salt-format $1$%.2s is needed with {SSHA}
John Du wrote:
David Markey wrote:
John Du wrote:
David Markey wrote:
John Du wrote:
David Markey wrote:
I would imagine that you'll need to re-jig your ACLs in slapd.conf,
Please supply logs.
Thank you very much.
I can use /opt/IDEALX/sbin/smbldap-passwd to change both the Windows
and UNIX password. If the problem is ACL related, wouldn't I have the
same problem with this tool?
When samba changes passwords, does the process run as root or as the
user making the passwords change?
If you're using smbldap-passwd and unix password sync, it's done as
root. ldap passwd sync is done as the LDAP dn that you've configured in
smb.conf. It's much preferable to use ldap passwd sync.
I did not make myself clear. When I say I can use smbldap-passwd to
change password, I mean I can run the tool from the command line as
root. If I use smbldap-passwd and unix passwd sync in smb.conf, I
get a you do not have permission to change password message when
attempting to change password.
So at this time I am still using ldap passwd sync in smb.conf and that
is when it only changes the Windows password.
Does the userPassword attribute require different ACL than
sambaNTPassword? Also the dn I put in smb.conf is the root DN of the
LDAP database.
That is strange, LDAP password updates are done via EXOP, have you
defined a password hash in slapd.conf?
Re: smbldap-passwd, you need to have a proper passwd chat in smb.conf,
Let us see some logs, smb.conf and maybe slapd.conf and perhaps slapd logs.
My thanks to David and all who have responded to my questions. I have
identified where and what the problem is but I am not sure it is a
Samba problem or OpenLDAP problem.
I am trying to give you a clear picture.
1. unix passwd sync works perfectly.
I replaced ldap passwd sync = Yes with:
unix password sync = Yes
passwd program = /opt/IDEALX/sbin/smbldap-passwd -u %u
passwd chat = Changing UNIX password for*\nNew password* %n\n
*Retype new password* %n\n
No changes on the OpenLDAP side. Users can change their Windows and
LDAP password correctly all the time.
2. ldap passwd sync = Yes does not change the LDAP password but it
changes the Windows password OK.
2.1 OpenLDAP with some ACLs defined.
When the OpenLDAP server has some ACLs defined, the samba server
logs the following:
2009/04/30 23:38:42, 2] passdb/pdb_ldap.c:ldapsam_modify_entry(1590)
ldap password change requested, but LDAP server does not support it
-- ignoring
The LDAP password is not changed.
2.2 When no ACLs are defined in slapd.conf.
[2009/04/30 23:43:03, 10]
lib/smbldap.c:smbldap_extended_operation(1525)
Extended operation failed with error: 80 (Internal (implementation
specific) error) (password hash failed)
[2009/04/30 23:43:03, 0] passdb/pdb_ldap.c:ldapsam_modify_entry(1651)
ldapsam_modify_entry: LDAP Password could not be changed for user
johndu: Internal (implementation specific) error
password hash failed
Hash is defined in slapd.conf as follows:
password-hash {CRYPT}
password-crypt-salt-format $1$%.2s
The Windows user will get a the user name or old password is
incorrect message in this case.
The LDAP root DN is used all the time everywhere.
I can mail the complete log files to you if they can help you to
determine the cause of the problem. There seems to be some
compatibility issues between the LDAP server and the Samba server.
Logically I think if the IDEALX tool works the samba server's internal
LDAP functions should work as well.
Let me know if you any further information from me.
Wish you all to have a good weekend!
John
Thanks!
Thanks again.
John Du wrote:
John Du wrote:
Hi,
I have been running Samba with OpenLDAP for a few years. We
recently
upgrade the OpenLDAP server from 2.2.13 to 2.4.11.
When users change their passwords now, only the Windows password is
changed the UNIX password is not changed anymore. Samba server does
not log any errors The samba configuration file did not change
when
the LDAP server was upgraded.
I do have ldap passwd sync =Yes in smb.conf and it used to work
fine.
Has anyone seen this?
If I use
unix password sync = Yes
passwd program = /opt/IDEALX/sbin/smbldap-passwd -u %u
passwd chat = Changing password for*\nNew password* %n\n *Retype
new password* %n\n
instead of
Re: [Samba] PDC: Linux Client can't join the domain.
But why with windows machine it works fine..no errors? Adam Williams wrote: sounds like a problem with the smbldap-useradd tool. I've never used it because on centos and fedora i got perl errors when running them. so I just create the ldap accounts manually by loading an .ldif file. -- To unsubscribe from this list go to the following URL and read the instructions: https://lists.samba.org/mailman/options/samba
Re: [Samba] Re: Samba does not change UNIX password after OpenLDAP server upgraded
Am Samstag, 2. Mai 2009 05:31 schrieb John Du:
David Markey wrote:
...
My thanks to David and all who have responded to my questions. I
have identified where and what the problem is but I am not sure it is
a Samba problem or OpenLDAP problem.
I am trying to give you a clear picture.
1. unix passwd sync works perfectly.
I replaced ldap passwd sync = Yes with:
unix password sync = Yes
passwd program = /opt/IDEALX/sbin/smbldap-passwd -u %u
passwd chat = Changing UNIX password for*\nNew password* %n\n
*Retype new password* %n\n
No changes on the OpenLDAP side. Users can change their Windows and
LDAP password correctly all the time.
2. ldap passwd sync = Yes does not change the LDAP password but it
changes the Windows password OK.
2.1 OpenLDAP with some ACLs defined.
When the OpenLDAP server has some ACLs defined, the samba server
logs the following:
2009/04/30 23:38:42, 2]
passdb/pdb_ldap.c:ldapsam_modify_entry(1590) ldap password change
requested, but LDAP server does not support it -- ignoring
The LDAP password is not changed.
2.2 When no ACLs are defined in slapd.conf.
[2009/04/30 23:43:03, 10]
lib/smbldap.c:smbldap_extended_operation(1525) Extended operation
failed with error: 80 (Internal (implementation specific) error)
(password hash failed)
[2009/04/30 23:43:03, 0]
passdb/pdb_ldap.c:ldapsam_modify_entry(1651) ldapsam_modify_entry:
LDAP Password could not be changed for user johndu: Internal
(implementation specific) error
password hash failed
Hash is defined in slapd.conf as follows:
password-hash {CRYPT}
password-crypt-salt-format $1$%.2s
# if crypt, then with MD5
password-crypt-salt-format '$1$%.8s'
The Windows user will get a the user name or old password is
incorrect message in this case.
The LDAP root DN is used all the time everywhere.
I can mail the complete log files to you if they can help you to
determine the cause of the problem. There seems to be some
compatibility issues between the LDAP server and the Samba server.
Logically I think if the IDEALX tool works the samba server's
internal LDAP functions should work as well.
Let me know if you any further information from me.
Wish you all to have a good weekend!
John
--
Gruss
Harry Jede
--
To unsubscribe from this list go to the following URL and read the
instructions: https://lists.samba.org/mailman/options/samba
Re: [Samba] ctrl-alt-del to change password
I have a PDC running without issue, but was curious about this. I was not sure if it was able to update both the smb and linux passwords. It works for me with LDAP without any special setting, John Hi, John Can you post your smb.conf settings related to ldap? I will do that on Modnay if I remember. No access to the work network from home. John -- To unsubscribe from this list go to the following URL and read the instructions: https://lists.samba.org/mailman/options/samba
Re: [Samba] ctrl-alt-del to change password
John Drescher ??: Can samba be configured to allow users to use ctrl-alt-del to change their password? If so, any special config needed? I have a PDC running without issue, but was curious about this. I was not sure if it was able to update both the smb and linux passwords. It works for me with LDAP without any special setting, John Hi, John Can you post your smb.conf settings related to ldap? Allen -- To unsubscribe from this list go to the following URL and read the instructions: https://lists.samba.org/mailman/options/samba
Re: [Samba] PDC: Linux Client can't join the domain.
Ok. I've deleted the last ldap db, and renewed. I'm trying to add manually the machine trust account. This is an ldif from slapcat: dn: uid=debian$,ou=Computers,dc=DOMINIO objectClass: top objectClass: account objectClass: posixAccount objectClass: sambaSamAccount cn: debian$ uid: debian$ uidNumber: 1001 gidNumber: 515 homeDirectory: /dev/null loginShell: /bin/false description: Computer gecos: Computer sambaSID: S-1-5-21-1849485170-1217343015-651458238-1001 displayName: DEBIAN$ sambaAcctFlags: [W ] sambaNTPassword: E5A8B99BEBA13E2AC86E4477CD0588DA sambaPwdLastSet: 1241268555 # smbpasswd debian\$ /*for the password, I've inserted the root domain password*/ After added the entry on ldap, I must add other for this user? if not, it still give me: [2009/05/02 15:12:29, 0] rpc_server/srv_netlog_nt.c:_netr_ServerAuthenticate2(520) _netr_ServerAuthenticate2: netlogon_creds_server_check failed. Rejecting auth request from client DEBIAN machine account DEBIAN$ [2009/05/02 15:12:29, 0] rpc_server/srv_netlog_nt.c:_netr_ServerAuthenticate2(520) _netr_ServerAuthenticate2: netlogon_creds_server_check failed. Rejecting auth request from client DEBIAN machine account DEBIAN$ and login on client Linux does not still work. Another issue is that sometimes smbldap-tools add machine account correctly...other not... -- To unsubscribe from this list go to the following URL and read the instructions: https://lists.samba.org/mailman/options/samba
[Samba] Cannot read files with smbfs
Hallo, I have a weird problem with a Linux client trying to access a Samba share available on a Linux server (an Asus WL500gp router running OpenWrt Kamikaze 8.09). Though I can navigate through the shared directory tree, all files have rwxrwSrwx permissions, and I get a setgid executable, regular file, no read permission error when I try to read them. Note that I have no problem accessing and reading files of this share from an Xbox client running XBMC. The problem happens only on a Linux client. This is the output of uname -a: (I am running Kubuntu Jaunty) Linux localhost 2.6.30-020630rc2-generic #020630rc2 SMP Wed Apr 15 13:20:18 UTC 2009 x86_64 GNU/Linux And this is the smb.conf: [global] syslog = 0 syslog only = yes workgroup = WORKGROUP server string = WL500GP preferred master = yes domain master = yes security = share encrypt passwords = yes guest account = nobody local master = yes name resolve order = lmhosts hosts bcast [myshare] path = /mnt/sda1/myshare browseable = yes writeable = yes read only = no valid users = user1 user2 user3 read list = user3 write list = user1 user2 force user = user2 Any ideas on what the problem could be? Thank you very much! Jean -- To unsubscribe from this list go to the following URL and read the instructions: https://lists.samba.org/mailman/options/samba
[Samba] working file server, but logs filling with NT_STATUS_ACCESS_DENIED
Hi, I wonder if anyone can help with this. I have a Samba server (Samba 3.3.3 running under FreeBSD 7.1-RELEASE), with 3 Windows workstations all running XP Professional and 3 laptops (1 XP home,1 XP professional, 1 Vista). There is no Windows domain invloved, just a workgroup. Everything works absolutely fine, except that my logs are filling up with errors similar to this: [2009/05/02 18:40:10, 0] smbd/service.c:make_connection_snum(740) create_connection_server_info failed: NT_STATUS_ACCESS_DENIED I cannot trace this to any particlaur activity by any user - in fact many of these errors occur at a similar time at around 3am every night, when there is certainly no user activity. Obviously to troubleshoot this properly you will need logs etc. I have copied my smb.conf below, but to save me posting all sorts of irrelevant stuff, perhaps a first step would be to let me know what else is needed in order to look into this further. Or perhaps there is something obvious I have done wrong already! I can find literally only 2 Google hits for the exact string create_connection_server_info failed: NT_STATUS_ACCESS_DENIED, neither of which are relevant to my situation. Any help would therefore be very gratefully received! Thanks ==smb.conf=== [global] workgroup = CHADLINGTON server string = Samba Server map to guest = Bad User passdb backend = tdbsam log level = 3 log file = /var/log/samba/log.%m max log size = 50 smb ports = 139 dns proxy = No hosts allow = 192.168.1., 127.0.0.1 hosts deny = ALL [homes] comment = Home Directories read only = No browseable = No [printers] comment = All Printers path = /var/spool/samba printable = Yes browseable = No [music] comment = shared music path = /home/music write list = @samba-clients guest ok = Yes = -- To unsubscribe from this list go to the following URL and read the instructions: https://lists.samba.org/mailman/options/samba
[SCM] Samba Shared Repository - branch master updated - release-4-0-0alpha7-1409-g79f3367
The branch, master has been updated
via 79f33674c660f2ebbf75843b06049f036eceeeca (commit)
from aebb1b8d7c1faef0ee36d9989d2c76607c8c5dd5 (commit)
http://gitweb.samba.org/?p=samba.git;a=shortlog;h=master
- Log -
commit 79f33674c660f2ebbf75843b06049f036eceeeca
Author: Volker Lendecke v...@samba.org
Date: Sat May 2 12:40:29 2009 +0200
Fix a malloc/talloc mixup
---
Summary of changes:
source3/lib/charcnv.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
Changeset truncated at 500 lines:
diff --git a/source3/lib/charcnv.c b/source3/lib/charcnv.c
index b945668..1f2fa63 100644
--- a/source3/lib/charcnv.c
+++ b/source3/lib/charcnv.c
@@ -759,7 +759,7 @@ size_t unix_strupper(const char *src, size_t srclen, char
*dest, size_t destlen)
}
if (!strupper_w(buffer) (dest == src)) {
- free(buffer);
+ TALLOC_FREE(buffer);
return srclen;
}
--
Samba Shared Repository
[SCM] Samba Shared Repository - branch master updated - release-4-0-0alpha7-1411-g4b3e89c
The branch, master has been updated
via 4b3e89c2e7f5e36edd436fccefb852a616ef2110 (commit)
via 60d77096cb5d4ebfb756963deb0c25b1f046a61a (commit)
from 79f33674c660f2ebbf75843b06049f036eceeeca (commit)
http://gitweb.samba.org/?p=samba.git;a=shortlog;h=master
- Log -
commit 4b3e89c2e7f5e36edd436fccefb852a616ef2110
Author: Volker Lendecke v...@samba.org
Date: Sat May 2 13:12:57 2009 +0200
Fix Coverity 911: FORWARD_NULL. Metze, please check!
commit 60d77096cb5d4ebfb756963deb0c25b1f046a61a
Author: Volker Lendecke v...@samba.org
Date: Sat May 2 12:53:30 2009 +0200
Attempt to fix the merged build on OpenSuSE 10.2
Python.h 2.5 on that platform does not #include the necessary headers
to see uintptr_t.
---
Summary of changes:
m4/check_python.m4|1 +
source4/smbd/service_stream.c |3 ++-
2 files changed, 3 insertions(+), 1 deletions(-)
Changeset truncated at 500 lines:
diff --git a/m4/check_python.m4 b/m4/check_python.m4
index 9453766..42eef19 100644
--- a/m4/check_python.m4
+++ b/m4/check_python.m4
@@ -17,6 +17,7 @@ AC_DEFUN([TRY_LINK_PYTHON],
CFLAGS=$CFLAGS $2
AC_TRY_LINK([
+#undef HAVE_UINTPTR_T
/* we have our own configure tests */
#include Python.h
],[
diff --git a/source4/smbd/service_stream.c b/source4/smbd/service_stream.c
index e09ac1d..4d36d78 100644
--- a/source4/smbd/service_stream.c
+++ b/source4/smbd/service_stream.c
@@ -328,7 +328,8 @@ NTSTATUS stream_setup_socket(struct tevent_context
*event_context,
if (!NT_STATUS_IS_OK(status)) {
DEBUG(0,(Failed to listen on %s:%u - %s\n,
- sock_addr, *port, nt_errstr(status)));
+sock_addr, port ? (unsigned int)(*port) : 0,
+nt_errstr(status)));
talloc_free(stream_socket);
return status;
}
--
Samba Shared Repository
[SCM] Samba Shared Repository - branch master updated - release-4-0-0alpha7-1412-gcacfd6e
The branch, master has been updated via cacfd6ee01382c7d52a7cdefa30c87bfe347af23 (commit) from 4b3e89c2e7f5e36edd436fccefb852a616ef2110 (commit) http://gitweb.samba.org/?p=samba.git;a=shortlog;h=master - Log - commit cacfd6ee01382c7d52a7cdefa30c87bfe347af23 Author: Volker Lendecke v...@samba.org Date: Sat May 2 17:14:36 2009 +0200 Explicitly link in pthreads for lib/pthreadpool if required No idea why it works on my Linux without -lpthread ... :-) --- Summary of changes: source3/configure.in |3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) Changeset truncated at 500 lines: diff --git a/source3/configure.in b/source3/configure.in index fc925ee..0796ff2 100644 --- a/source3/configure.in +++ b/source3/configure.in @@ -6059,6 +6059,9 @@ AC_ARG_ENABLE(pthreadpool, [AS_HELP_STRING([--enable-pthreadpool], [Enable pthreads pool helper support (default=auto)])]) if test x$enable_pthreadpool != xno -a x$samba_cv_HAVE_PTHREAD = xyes; then +AC_TRY_LINK([#include pthread.h], +[pthread_create(NULL, NULL, NULL, NULL)], + ,LIBS=$LIBS -lpthread) AC_DEFINE(WITH_PTHREADPOOL, 1, [Whether to include pthreadpool helpers]) AC_SUBST(PTHREADPOOL_OBJ, lib/pthreadpool.o) fi -- Samba Shared Repository
[SCM] Samba Shared Repository - branch master updated - release-4-0-0alpha7-1413-ge2052f1
The branch, master has been updated
via e2052f128f4269692aede0a082351fd0dbea8cce (commit)
from cacfd6ee01382c7d52a7cdefa30c87bfe347af23 (commit)
http://gitweb.samba.org/?p=samba.git;a=shortlog;h=master
- Log -
commit e2052f128f4269692aede0a082351fd0dbea8cce
Author: Volker Lendecke v...@samba.org
Date: Sat May 2 19:11:52 2009 +0200
Attempt to fix the build on SerNet-sles8
That compiler does not like #if embedded into the macro NT_STATUS_IS_OK.
---
Summary of changes:
source3/torture/torture.c |9 ++---
1 files changed, 6 insertions(+), 3 deletions(-)
Changeset truncated at 500 lines:
diff --git a/source3/torture/torture.c b/source3/torture/torture.c
index 50bfa61..1f8ef7e 100644
--- a/source3/torture/torture.c
+++ b/source3/torture/torture.c
@@ -3492,6 +3492,7 @@ static bool run_rename(int dummy)
const char *fname1 = \\test1.txt;
bool correct = True;
uint16_t fnum1;
+ NTSTATUS status;
printf(starting rename test\n);
@@ -3521,12 +3522,14 @@ static bool run_rename(int dummy)
cli_unlink(cli1, fname, aSYSTEM | aHIDDEN);
cli_unlink(cli1, fname1, aSYSTEM | aHIDDEN);
- if (!NT_STATUS_IS_OK(cli_ntcreate(cli1, fname, 0, GENERIC_READ_ACCESS,
FILE_ATTRIBUTE_NORMAL,
+ status = cli_ntcreate(cli1, fname, 0, GENERIC_READ_ACCESS,
FILE_ATTRIBUTE_NORMAL,
#if 0
- FILE_SHARE_DELETE|FILE_SHARE_NONE,
FILE_OVERWRITE_IF, 0, 0, fnum1))) {
+ FILE_SHARE_DELETE|FILE_SHARE_NONE,
#else
- FILE_SHARE_DELETE|FILE_SHARE_READ,
FILE_OVERWRITE_IF, 0, 0, fnum1))) {
+ FILE_SHARE_DELETE|FILE_SHARE_READ,
#endif
+ FILE_OVERWRITE_IF, 0, 0, fnum1);
+ if (!NT_STATUS_IS_OK(status)) {
printf(Second open failed - %s\n, cli_errstr(cli1));
return False;
}
--
Samba Shared Repository
[SCM] Samba Shared Repository - branch master updated - release-4-0-0alpha7-1414-geea114a
The branch, master has been updated
via eea114a8562f71f4aadec76a767a46d7874b8972 (commit)
from e2052f128f4269692aede0a082351fd0dbea8cce (commit)
http://gitweb.samba.org/?p=samba.git;a=shortlog;h=master
- Log -
commit eea114a8562f71f4aadec76a767a46d7874b8972
Author: Volker Lendecke v...@samba.org
Date: Sat May 2 19:17:23 2009 +0200
Fix a warning on host gwen
cc: ../librpc/ndr/ndr_basic.c, line 572: warning 604: Pointers are not
assignment-compatible.
Apparently in_addr.s_addr is not compatible to uint32_t, maybe a 32-bit
signed
int.
---
Summary of changes:
librpc/ndr/ndr_basic.c |5 +++--
1 files changed, 3 insertions(+), 2 deletions(-)
Changeset truncated at 500 lines:
diff --git a/librpc/ndr/ndr_basic.c b/librpc/ndr/ndr_basic.c
index 97f7505..825f303 100644
--- a/librpc/ndr/ndr_basic.c
+++ b/librpc/ndr/ndr_basic.c
@@ -568,9 +568,10 @@ _PUBLIC_ enum ndr_err_code ndr_pull_time_t(struct ndr_pull
*ndr, int ndr_flags,
*/
_PUBLIC_ enum ndr_err_code ndr_pull_ipv4address(struct ndr_pull *ndr, int
ndr_flags, const char **address)
{
+ uint32_t s_addr;
struct in_addr in;
- NDR_CHECK(ndr_pull_uint32(ndr, ndr_flags, in.s_addr));
- in.s_addr = htonl(in.s_addr);
+ NDR_CHECK(ndr_pull_uint32(ndr, ndr_flags, s_addr));
+ in.s_addr = htonl(s_addr);
*address = talloc_strdup(ndr-current_mem_ctx, inet_ntoa(in));
NDR_ERR_HAVE_NO_MEMORY(*address);
return NDR_ERR_SUCCESS;
--
Samba Shared Repository
[SCM] Samba Shared Repository - branch master updated - release-4-0-0alpha7-1415-g8f3a9b3
The branch, master has been updated
via 8f3a9b3c0f32573508424b5480ca077450322ebd (commit)
from eea114a8562f71f4aadec76a767a46d7874b8972 (commit)
http://gitweb.samba.org/?p=samba.git;a=shortlog;h=master
- Log -
commit 8f3a9b3c0f32573508424b5480ca077450322ebd
Author: Volker Lendecke v...@samba.org
Date: Sat May 2 23:34:45 2009 +0200
Of course, s_addr is a #define somewhere else (Solaris...)
---
Summary of changes:
librpc/ndr/ndr_basic.c |6 +++---
1 files changed, 3 insertions(+), 3 deletions(-)
Changeset truncated at 500 lines:
diff --git a/librpc/ndr/ndr_basic.c b/librpc/ndr/ndr_basic.c
index 825f303..b6cc44c 100644
--- a/librpc/ndr/ndr_basic.c
+++ b/librpc/ndr/ndr_basic.c
@@ -568,10 +568,10 @@ _PUBLIC_ enum ndr_err_code ndr_pull_time_t(struct
ndr_pull *ndr, int ndr_flags,
*/
_PUBLIC_ enum ndr_err_code ndr_pull_ipv4address(struct ndr_pull *ndr, int
ndr_flags, const char **address)
{
- uint32_t s_addr;
+ uint32_t addr;
struct in_addr in;
- NDR_CHECK(ndr_pull_uint32(ndr, ndr_flags, s_addr));
- in.s_addr = htonl(s_addr);
+ NDR_CHECK(ndr_pull_uint32(ndr, ndr_flags, addr));
+ in.s_addr = htonl(addr);
*address = talloc_strdup(ndr-current_mem_ctx, inet_ntoa(in));
NDR_ERR_HAVE_NO_MEMORY(*address);
return NDR_ERR_SUCCESS;
--
Samba Shared Repository
Build status as of Sun May 3 00:00:02 2009
URL: http://build.samba.org/ --- /home/build/master/cache/broken_results.txt.old 2009-05-02 00:00:33.0 + +++ /home/build/master/cache/broken_results.txt 2009-05-03 00:01:41.0 + @@ -1,4 +1,4 @@ -Build status as of Sat May 2 00:00:02 2009 +Build status as of Sun May 3 00:00:02 2009 Build counts: Tree Total Broken Panic @@ -9,14 +9,14 @@ libreplace 31 11 0 lorikeet 0 0 0 pidl 21 3 0 -ppp 14 0 0 +ppp 12 0 0 rsync31 10 0 samba-docs 0 0 0 samba-web0 0 0 samba_3_current 29 17 0 -samba_3_master 30 30 0 -samba_3_next 30 28 0 -samba_4_0_test 30 30 1 +samba_3_master 30 28 0 +samba_3_next 30 29 0 +samba_4_0_test 31 30 3 talloc 31 31 0 tdb 29 11 0
