[Samba] Windows 7, http://www.samba.org/samba/ftp/Binary_Packages/SuSE/STABLE/11.2/
Hello, I have the typical problem with Windows 7. I loaded the repository from the binaries and installed it. I changed the registry on the client but still can not login. I am a little bit confused about the version numbers. In the repository the version of samba is: samba-3.2.7-11.4.1 - A SMB/CIFS File, Print, and Authentication Server Wed Sep 30 14:00:00 2009 jmcdono...@suse.de - Fix potential denial of service; CVE-2009-2906; (bnc#543115). The version of smbclient is samba-client-3.4.3-10.1 - Samba Client Utilities Wed Dec 9 13:00:00 2009 lmue...@suse.de - Store the smbfs service state if enabled and restore it for cifs while upgrade on post-11.2 systems. So, samba tells me all the time version 3.2.7-11.4.1 ! Are the versions in the binary are correct? The log.smbd has the following message, when I try do login with the client GUSTAV to the samba server DAGOBERT. smbd version 3.2.7-11.4.1-2210-SUSE-CODE11 started. Copyright Andrew Tridgell and the Samba Team 1992-2009 [2009/12/30 12:00:52, 0] rpc_server/srv_netlog_nt.c:_netr_ServerAuthenticate2(520) _netr_ServerAuthenticate2: netlogon_creds_server_check failed. Rejecting auth request from client GUSTAV machine account GUSTAV$ [2009/12/30 12:01:05, 0] lib/util_sock.c:read_socket_with_timeout(939) [2009/12/30 12:01:05, 0] lib/util_sock.c:get_peer_addr_internal(1607) getpeername failed. Error was Transport endpoint is not connected read_socket_with_timeout: client 0.0.0.0 read error = Connection reset by peer. Could some one help? Best regards Hartje Stendel -- Ing.Büro CheckTec Dipl.-Ing. Hartje Stendel Wilhelmstraße 87 D-38100 Braunschweig Tel. 0531 / 12 33 96 - 0 Fax. 0531 / 12 33 96 - 9 www.check-tec.de Ust-Id.: 151917334 -- To unsubscribe from this list go to the following URL and read the instructions: https://lists.samba.org/mailman/options/samba
[Samba] Matlab not working when run of a samba 3.4.x share
Matlab when installed on a samba 3.4.x share is not working. (it works with 3.3.x and earlier versions) The application stops with a java related message. (matlab -nojvm works) the detailed log messages and Google led me to bug 6837. Even if this bug is said to be Windows 7 related, the patch for it fixes the matlab problem in 3.4.x (which is present in XP and probably affects other java applications) This message is for the record as the problem is to be fixed in 3.4.4 -- Jean-Jacques Moulis Tel: (013) 281684 ISYFax: (013) 139282 Linköping UniversityE-mail: j...@isy.liu.se 581 83 Linköping -- To unsubscribe from this list go to the following URL and read the instructions: https://lists.samba.org/mailman/options/samba
Re: [Samba] Windows 7, http://www.samba.org/samba/ftp/Binary_Packages/SuSE/STABLE/11.2/
Sernet has excelent Samba binary packages. You might be interested in using them: http://ftp.sernet.de/pub/samba/ or ftp://ftp.sernet.de/pub/samba/ Look for the specific packages for your distro. -- To unsubscribe from this list go to the following URL and read the instructions: https://lists.samba.org/mailman/options/samba
[Samba] Users from trusted domains get Your Password expires today in 3.4.3
Hello everyone! We've got a Samba domain that trusts another Samba domain and a Windows Server 2008 domain. We recently upgraded both Samba DCs from 3.0.x to 3.4.3 After that, whenever a user logs on a workstation in the trusting domain with an account from one of the trusted domains, he gets this message: Your Password expires today. Do you want to change it? Of course, the password isn't expiring, and no such message appears when users login on a workstation, joined into their domain. Since both trusted domains, that otherwise have nothing in common, are affected, I'm currently looking into the trusting domain. Here's the global section of smb.conf on the DC: [global] workgroup = UCCD server string = interfaces = 127.0.0.1, 172.16.0.9 passdb backend = ldapsam:ldap://ldap2.ru.acad.bg/; username map = /etc/samba/smbusers lanman auth = Yes log level = 2 syslog = 0 log file = /var/log/samba/%m.log max log size = 500 load printers = No printcap name = /dev/null disable spoolss = Yes add machine script = /usr/sbin/smbldap-useradd -w %u logon script = etc\welcome.vbs logon path = \\orac\%U\Profile logon drive = M: domain logons = Yes domain master = Yes wins server = 172.16.0.6, 172.16.0.10 ldap admin dn = * ldap group suffix = ou=groups ldap machine suffix = ou=machines ldap passwd sync = yes ldap suffix = dc=ru,dc=acad,dc=bg ldap user suffix = ou=people utmp = Yes idmap uid = 1-25000 idmap gid = 1-25000 hosts allow = * oplocks = No level2 oplocks = No Ideas anyone? Regards, Deyan -- Deyan Stoykov, dstoy...@ru.acad.bg University of Rousse, BG-7017 -- To unsubscribe from this list go to the following URL and read the instructions: https://lists.samba.org/mailman/options/samba
Re: [Samba] Matlab not working when run of a samba 3.4.x share
On Wed, Dec 30, 2009 at 12:54:16PM +0100, Jean-Jacques Moulis wrote: Matlab when installed on a samba 3.4.x share is not working. (it works with 3.3.x and earlier versions) The application stops with a java related message. (matlab -nojvm works) the detailed log messages and Google led me to bug 6837. Even if this bug is said to be Windows 7 related, the patch for it fixes the matlab problem in 3.4.x (which is present in XP and probably affects other java applications) This message is for the record as the problem is to be fixed in 3.4.4 Thanks for letting us know and testing the patch. Jeremy. -- To unsubscribe from this list go to the following URL and read the instructions: https://lists.samba.org/mailman/options/samba
[Samba] web client for samba
Is there any way to access to samba server via web, I mean that the users windows can access to samba server via web. -- To unsubscribe from this list go to the following URL and read the instructions: https://lists.samba.org/mailman/options/samba
Re: [Samba] web client for samba
jcflores wrote: Is there any way to access to samba server via web, I mean that the users windows can access to samba server via web. You can access the server using SWAT, which listens on port 901. If you want to access file shares via the Internet, that's a different issue. Try Googling SMB over IP. If you want a web interface to file shares, that's not a Samba issue. -- To unsubscribe from this list go to the following URL and read the instructions: https://lists.samba.org/mailman/options/samba
Re: [Samba] web client for samba
jcflores wrote: Is there any way to access to samba server via web, I mean that the users windows can access to samba server via web. smbwebclient - works really nicely! http://freshmeat.net/projects/smbwebclient/ Drop the script in somewhere that the web server will run it. Install smbclient on the web server. At the top of the script you'll see where you have to point it at your file server. There are 2 other changes you'll need to make to get it to run... For smbclient = 3.2 Within smbwebclient.php need to change $cmdline = $this-cfgSmbClient.' '.$smbcmd.' '.$options.' -N '; to $cmdline = $this-cfgSmbClient.' '.$smbcmd.' '.$options; as the -N option now does something different!! ...and $cmdline .= ($dumpFile) ? '2/dev/null' : '21'; to $cmdline .= ($dumpFile) ? ' 2/dev/null' : ' 21'; -- Steve Rippl Technology Director Woodland Public Schools 360 225 9451 x326 -- To unsubscribe from this list go to the following URL and read the instructions: https://lists.samba.org/mailman/options/samba
Re: [Samba] web client for samba
Thanks Gary, that's what i'm looking for. If you know a page or link to describe howto implement it, please let me know. -- To unsubscribe from this list go to the following URL and read the instructions: https://lists.samba.org/mailman/options/samba
Re: [Samba] web client for samba
Davenport, a WebDAV-SMB gateway could be also of interest to you: http://davenport.sourceforge.net/ -sd 2009/12/30 jcflores jcflo...@cablenet.com.pe: Thanks Gary, that's what i'm looking for. If you know a page or link to describe howto implement it, please let me know. -- To unsubscribe from this list go to the following URL and read the instructions: https://lists.samba.org/mailman/options/samba -- To unsubscribe from this list go to the following URL and read the instructions: https://lists.samba.org/mailman/options/samba
[Samba] Samba4 A11 Provision Fails on 389-DS - Fedora 12
Following the instructions here ( http://wiki.samba.org/index.php/Samba4/LDAP_Backend/Fedora_DS_1.2.3), I got to the DS provisioning step and encountered an error trying to provision the 389-DS (v1.2.3 B2009.280.1622). The source was checked out around 12/30/2009 ~16:00 GMT following the instructions provided in the 'howto'. I have made sure that system.domain-test.local is listed in the hosts file for 127.0.0.1 so it responds if you try to ping system.domain-test.local. This is on a completely fresh install of Fedora 12 x86_64 (latest updates installed) with just the software development group installed, nothing else besides what's listed in the howto. I didn't notice any failures in the compile, only WARNS. Any ideas as to what failed here and how to fix it? I'm setting up a local test bed in a cluster of ESXi 4u1 servers with a private network for performance testing. The DS is indeed running after this is run as you get a: File bin/python/samba/provisionbackend.py, line 183, in init raise ProvisioningError(Warning: Another slapd Instance seems already running on this host, listening to + self.ldapi_uri + . Please shut it down before you continue. ) If you attempt to run the script again. If you stop the DS and try again, the same error occurs as listed below: [r...@system source4]# setup/provision --host-name=System --root=root --domain=DOMAIN-TEST --realm=DOMAIN-TEST.LOCAL --server-role=domain controller --ldap-backend-type=fedora-ds --slapd-path=/usr/sbin/ns-slapd --setup-ds-path=/usr/sbin/setup-ds.pl Administrator password will be set randomly! Converted 58 records with 0 failures Warning: using root as the server user id. You are strongly encouraged to use a non-root user. Your new DS instance 'samba4' was successfully created. Exiting . . . Log file is '/tmp/setupP3h9pd.log' importing data ... [30/Dec/2009:15:12:43 -0600] - Information: Non-Secure Port Disabled [30/Dec/2009:15:12:43 -0600] - Backend Instance: sambaData [30/Dec/2009:15:12:43 -0600] - dblayer_instance_start: pagesize: 4096, pages: 2049500, procpages: 47759 [30/Dec/2009:15:12:43 -0600] - cache autosizing: import cache: 204800k [30/Dec/2009:15:12:43 -0600] - li_import_cache_autosize: 50, import_pages: 51200, pagesize: 4096 [30/Dec/2009:15:12:43 -0600] - WARNING: Import is running with nsslapd-db-private-import-mem on; No other process is allowed to access the database [30/Dec/2009:15:12:43 -0600] - dblayer_instance_start: pagesize: 4096, pages: 2049500, procpages: 47759 [30/Dec/2009:15:12:43 -0600] - cache autosizing: import cache: 204800k [30/Dec/2009:15:12:43 -0600] - li_import_cache_autosize: 50, import_pages: 51200, pagesize: 4096 [30/Dec/2009:15:12:43 -0600] - import sambaData: Beginning import job... [30/Dec/2009:15:12:43 -0600] - import sambaData: Index buffering enabled with bucket size 100 [30/Dec/2009:15:12:43 -0600] - import sambaData: Processing file /usr/local/samba/private/ldap/fedorads-samba.ldif [30/Dec/2009:15:12:43 -0600] - import sambaData: Finished scanning file /usr/local/samba/private/ldap/fedorads-samba.ldif (4 entries) [30/Dec/2009:15:12:44 -0600] - import sambaData: Workers finished; cleaning up... [30/Dec/2009:15:12:44 -0600] - import sambaData: Workers cleaned up. [30/Dec/2009:15:12:44 -0600] - import sambaData: Cleaning up producer thread... [30/Dec/2009:15:12:44 -0600] - import sambaData: Indexing complete. Post-processing... [30/Dec/2009:15:12:44 -0600] - import sambaData: Flushing caches... [30/Dec/2009:15:12:44 -0600] - import sambaData: Closing files... [30/Dec/2009:15:12:44 -0600] - All database threads now stopped [30/Dec/2009:15:12:44 -0600] - import sambaData: Import complete. Processed 4 entries in 1 seconds. (4.00 entries/sec) Failed to bind - LDAP client internal error: NT_STATUS_UNEXPECTED_NETWORK_ERROR Failed to connect to 'ldapi://%2Fusr%2Flocal%2Fsamba%2Fprivate%2Fldap%2Fldapi' [30/Dec/2009:15:12:44 -0600] - Information: Non-Secure Port Disabled [30/Dec/2009:15:12:44 -0600] - 389-Directory/1.2.3 B2009.280.1622 starting up [30/Dec/2009:15:12:44 -0600] - I'm resizing my cache now...cache was 209715200 and is now 800 Failed to bind - LDAP client internal error: NT_STATUS_UNEXPECTED_NETWORK_ERROR Failed to connect to 'ldapi://%2Fusr%2Flocal%2Fsamba%2Fprivate%2Fldap%2Fldapi' [30/Dec/2009:15:12:45 -0600] - Listening on /usr/local/samba/private/ldap/ldapi for LDAPI requests Setting up secrets.ldb Setting up the registry Setting up the privileges database Setting up idmap db Setting up SAM db Setting up sam.ldb partitions and settings Setting up sam.ldb rootDSE Pre-loading the Samba 4 and AD schema Adding DomainDN: DC=domain-test,DC=local pdc_fsmo_init: no domain object present: (skip loading of domain details) Traceback (most recent call last): File setup/provision, line 222, in module nosync=opts.nosync,ldap_dryrun_mode=opts.ldap_dryrun_mode) File bin/python/samba/provision.py, line 1235, in provision dom_for_fun_level=dom_for_fun_level) File
Re: [Samba] Users from trusted domains get Your Password expires today in 3.4.3
2009/12/30 Deyan Stoykov dstoy...@ru.acad.bg: Ideas anyone? ldap acl? (hint: shadowlastchange) -- To unsubscribe from this list go to the following URL and read the instructions: https://lists.samba.org/mailman/options/samba
Re: [Samba] Users from trusted domains get Your Password expires today in 3.4.3
2009/12/30 Zoolook nbe...@gmail.com: 2009/12/30 Deyan Stoykov dstoy...@ru.acad.bg: Ideas anyone? ldap acl? (hint: shadowlastchange) please discard. I had a problem with ldap acl last week and I thought you got the same;I didn't read it was a domain trust issue. -- To unsubscribe from this list go to the following URL and read the instructions: https://lists.samba.org/mailman/options/samba
Re: [Samba] samba 3.3 for opensuse 10.2
Hi Peter, On Mon, Dec 28, 2009 at 07:09:40PM +0100, peter grotz wrote: JM On Mon, Dec 28, 2009 at 5:54 AM, peter grotz peter.gr...@grotz.org wrote: I need the rpm-files of samba 3.3 or later for opensuse 10.2. The repo isn´t available any more, so can anybody help me here? JM You need 3.3 or _later_ ? It shipped with 3.4.2, so that would be JM later. Or do you specifically need 3.3? no, you´re wrong! It´s shipped wigth 3.0.23! I hav here opensuse 10.2 and it´s really 3.0.23!! you can find a lot of Samba versions for opensuse 10.2 e.g. on http://ftp.sernet.de/pub/samba/. Hope that helps. Cheers, Karolin -- SerNet GmbH, Bahnhofsallee 1b, 37081 Göttingen phone: +49-551-37-0, fax: +49-551-37-9 AG Göttingen, HRB 2816, GF: Dr. Johannes Loxen http://www.SerNet.DE, mailto: Info @ SerNet.DE pgpFjClC07qzQ.pgp Description: PGP signature -- To unsubscribe from this list go to the following URL and read the instructions: https://lists.samba.org/mailman/options/samba
[Samba] gidNumber of the Domain Admins group with LDAP
Hello, What shoul be the gidNumber of the domain admins group : 0, 512 ou somewhat else ? Looking in log files it seems that samba looks for a gidNumber of 0 but smbldap-populate fill it with 512 ? Any idea ? TIA -- Afin de contribuer au respect de l'environnement, merci de n'imprimer ce courriel qu'en cas de nécessité absolue ... -- To unsubscribe from this list go to the following URL and read the instructions: https://lists.samba.org/mailman/options/samba
[Samba] is_myname(mystation) returns 0
Dear All ... I keep trying to set a samba box as PDC without LDAP No success yet ... I got this msg in my /var/log/samba/log.nmbd --- is_myname(mystation) returns 0 Note mystation is the computer name I use as client station what is causing that msg ? Sincerely -bino- -- To unsubscribe from this list go to the following URL and read the instructions: https://lists.samba.org/mailman/options/samba
[SCM] Samba Shared Repository - branch v3-4-test updated
The branch, v3-4-test has been updated
via bbdc2c0... Fix bug 6837 - Too many open files when trying to
access large number of files
from 29b9236... WHATSNEW: Update changes.
http://gitweb.samba.org/?p=samba.git;a=shortlog;h=v3-4-test
- Log -
commit bbdc2c017ca5abb35897ab61717b806133e0af0b
Author: Jeremy Allison j...@samba.org
Date: Thu Dec 17 16:59:56 2009 -0800
Fix bug 6837 - Too many open files when trying to access large number of
files
Win7 needs the Windows server open file handle number of 16384 handles.
Jeremy.
---
Summary of changes:
source3/include/local.h | 24 +---
source3/param/loadparm.c | 16
source3/smbd/files.c |2 --
3 files changed, 37 insertions(+), 5 deletions(-)
Changeset truncated at 500 lines:
diff --git a/source3/include/local.h b/source3/include/local.h
index 45767ad..a88b17b 100644
--- a/source3/include/local.h
+++ b/source3/include/local.h
@@ -56,7 +56,25 @@
#define SYSLOG_FACILITY LOG_DAEMON
#endif
-/*
+/*
+ * Fudgefactor required for open tdb's, etc.
+ */
+
+#ifndef MAX_OPEN_FUDGEFACTOR
+#define MAX_OPEN_FUDGEFACTOR 20
+#endif
+
+/*
+ * Minimum number of open files needed for Windows7 to
+ * work correctly. A little conservative but better that
+ * than run out of fd's.
+ */
+
+#ifndef MIN_OPEN_FILES_WINDOWS
+#define MIN_OPEN_FILES_WINDOWS 16384
+#endif
+
+/*
* Default number of maximum open files per smbd. This is
* also limited by the maximum available file descriptors
* per process and can also be set in smb.conf as max open files
@@ -64,9 +82,9 @@
*/
#ifndef MAX_OPEN_FILES
-#define MAX_OPEN_FILES 1
+#define MAX_OPEN_FILES (MIN_OPEN_FILES_WINDOWS + MAX_OPEN_FUDGEFACTOR)
#endif
-
+
#define WORDMAX 0x
/* the maximum password length before we declare a likely attack */
diff --git a/source3/param/loadparm.c b/source3/param/loadparm.c
index cd27fe4..ccf642d 100644
--- a/source3/param/loadparm.c
+++ b/source3/param/loadparm.c
@@ -4692,6 +4692,22 @@ static int max_open_files(void)
#endif
#endif
+ if (sysctl_max MIN_OPEN_FILES_WINDOWS) {
+ DEBUG(2,(max_open_files: sysctl_max (%d) below
+ minimum Windows limit (%d)\n,
+ sysctl_max,
+ MIN_OPEN_FILES_WINDOWS));
+ sysctl_max = MIN_OPEN_FILES_WINDOWS;
+ }
+
+ if (rlimit_max MIN_OPEN_FILES_WINDOWS) {
+ DEBUG(2,(rlimit_max: rlimit_max (%d) below
+ minimum Windows limit (%d)\n,
+ rlimit_max,
+ MIN_OPEN_FILES_WINDOWS));
+ rlimit_max = MIN_OPEN_FILES_WINDOWS;
+ }
+
return MIN(sysctl_max, rlimit_max);
}
diff --git a/source3/smbd/files.c b/source3/smbd/files.c
index 6f82686..03d2f58 100644
--- a/source3/smbd/files.c
+++ b/source3/smbd/files.c
@@ -155,8 +155,6 @@ void file_close_pid(uint16 smbpid, int vuid)
Initialise file structures.
/
-#define MAX_OPEN_FUDGEFACTOR 20
-
void file_init(void)
{
int request_max_open_files = lp_max_open_files();
--
Samba Shared Repository
[SCM] Samba Shared Repository - branch v3-4-test updated
The branch, v3-4-test has been updated via 958367d... WHATSNEW: Update changes. from bbdc2c0... Fix bug 6837 - Too many open files when trying to access large number of files http://gitweb.samba.org/?p=samba.git;a=shortlog;h=v3-4-test - Log - commit 958367d09384731ad3330e396869b12770b11231 Author: Karolin Seeger ksee...@samba.org Date: Wed Dec 30 10:01:29 2009 +0100 WHATSNEW: Update changes. Karolin --- Summary of changes: WHATSNEW.txt |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) Changeset truncated at 500 lines: diff --git a/WHATSNEW.txt b/WHATSNEW.txt index 195c5e2..129cd3f 100644 --- a/WHATSNEW.txt +++ b/WHATSNEW.txt @@ -31,6 +31,8 @@ o Michael Adam ob...@samba.org o Jeremy Allison j...@samba.org * BUG 6828: Fix infinite timeout when byte lock held outside of samba. +* BUG 6837: Fix Too many open files message when trying to access a large + number of files with Windows 7. * BUG 6841: Fix map acl inherit = yes. * BUG 6867: Fix listing of directories with a lot of files. * BUG 6875: Fix DOS attributes on OS/2 clients. -- Samba Shared Repository
[SCM] Samba Shared Repository - branch master updated
The branch, master has been updated via 1aed373... s4:lib/registry/util.c - Reintroduce FIXMEs from b0dd364... net: Add some German translation http://gitweb.samba.org/?p=samba.git;a=shortlog;h=master - Log - commit 1aed373b119b98bf767ab02ea14940d017ad3868 Author: Matthias Dieter Wallnöfer mwallnoe...@yahoo.de Date: Wed Dec 30 12:39:55 2009 +0100 s4:lib/registry/util.c - Reintroduce FIXMEs Jelmer suggested to put them in again. --- Summary of changes: source4/lib/registry/util.c |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) Changeset truncated at 500 lines: diff --git a/source4/lib/registry/util.c b/source4/lib/registry/util.c index f9ea2a1..5d451df 100644 --- a/source4/lib/registry/util.c +++ b/source4/lib/registry/util.c @@ -89,6 +89,7 @@ _PUBLIC_ char *reg_val_data_string(TALLOC_CTX *mem_ctx, /* FIXME: We don't support this yet */ break; default: + /* FIXME */ /* Other datatypes aren't supported - return NULL */ break; } @@ -156,6 +157,7 @@ _PUBLIC_ bool reg_string_to_val(TALLOC_CTX *mem_ctx, /* FIXME: We don't support this yet */ return false; default: + /* FIXME */ /* Other datatypes aren't supported - return no success */ return false; } -- Samba Shared Repository
[SCM] Samba Shared Repository - branch master updated
The branch, master has been updated
via 3a271a8... Prevent NULL dereference if group has no members
from 1aed373... s4:lib/registry/util.c - Reintroduce FIXMEs
http://gitweb.samba.org/?p=samba.git;a=shortlog;h=master
- Log -
commit 3a271a89b5e6d23089f9391f0cfd42f6631c925a
Author: Jim McDonough j...@samba.org
Date: Wed Dec 30 15:04:55 2009 -0500
Prevent NULL dereference if group has no members
---
Summary of changes:
source3/winbindd/winbindd_rpc.c |8
1 files changed, 4 insertions(+), 4 deletions(-)
Changeset truncated at 500 lines:
diff --git a/source3/winbindd/winbindd_rpc.c b/source3/winbindd/winbindd_rpc.c
index ffe488a..e700376 100644
--- a/source3/winbindd/winbindd_rpc.c
+++ b/source3/winbindd/winbindd_rpc.c
@@ -787,16 +787,16 @@ static NTSTATUS lookup_groupmem(struct winbindd_domain
*domain,
if (!NT_STATUS_IS_OK(result))
return result;
- *num_names = rids-count;
- rid_mem = rids-rids;
-
- if (!*num_names) {
+ if (!rids || !rids-count) {
names = NULL;
name_types = NULL;
sid_mem = NULL;
return NT_STATUS_OK;
}
+ *num_names = rids-count;
+ rid_mem = rids-rids;
+
/* Step #2: Convert list of rids into list of usernames. Do this
in bunches of ~1000 to avoid crashing NT4. It looks like there
is a buffer overflow or something like that lurking around
--
Samba Shared Repository
[SCM] Samba Shared Repository - branch v3-5-test updated
The branch, v3-5-test has been updated
via 8c3dd08... Prevent NULL dereference if group has no members
from 86def5d... WHATSNEW: Update changes.
http://gitweb.samba.org/?p=samba.git;a=shortlog;h=v3-5-test
- Log -
commit 8c3dd08f6a361a24799f5ec958668e477b8127d0
Author: Jim McDonough j...@samba.org
Date: Wed Dec 30 15:04:55 2009 -0500
Prevent NULL dereference if group has no members
---
Summary of changes:
source3/winbindd/winbindd_rpc.c |8
1 files changed, 4 insertions(+), 4 deletions(-)
Changeset truncated at 500 lines:
diff --git a/source3/winbindd/winbindd_rpc.c b/source3/winbindd/winbindd_rpc.c
index e7a1f86..8797aeb 100644
--- a/source3/winbindd/winbindd_rpc.c
+++ b/source3/winbindd/winbindd_rpc.c
@@ -782,16 +782,16 @@ static NTSTATUS lookup_groupmem(struct winbindd_domain
*domain,
if (!NT_STATUS_IS_OK(result))
return result;
- *num_names = rids-count;
- rid_mem = rids-rids;
-
- if (!*num_names) {
+ if (!rids || !rids-count) {
names = NULL;
name_types = NULL;
sid_mem = NULL;
return NT_STATUS_OK;
}
+ *num_names = rids-count;
+ rid_mem = rids-rids;
+
/* Step #2: Convert list of rids into list of usernames. Do this
in bunches of ~1000 to avoid crashing NT4. It looks like there
is a buffer overflow or something like that lurking around
--
Samba Shared Repository
[SCM] Samba Shared Repository - branch master updated
The branch, master has been updated via de94857... s4-net: fixed finddcs to use empty SID instead of NULL sid (NDR error) via 9d6411d... s4-testpasswords: fixed CONFIG and quoting via 3239872... s4-net: fixed pwsettings command via dbd7a62... py/security: Add test for dom_sid.split. via 66f81d1... samba: Fix whitespace, remove pointless 'pass' statement. via ea5af6e... pyldb: Add dom_sid.split in favor of less powerful dom_sid_to_rid(). via 7effe2d... net: Support 'super' commands implemented in Python. via 9e5ef91... net: Move 'newuser' to 'net newuser' via 73594c2... net: Fix tests and documentation of setexpiry. via 345b25d... net: Move setexpiry to 'net setexpiry' via b531696... net: Move 'setpassword' to 'net setpassword'. via 552e656... net: Allow Python commands to return None instead of 0. via 797977a... blackbox.passwords: Use convenience variable for net. via 18d2213... Fix commands in password tests. via 31cc963... net: Allow python subcommands to provide commands that are not recognized by net itself. from 3a271a8... Prevent NULL dereference if group has no members http://gitweb.samba.org/?p=samba.git;a=shortlog;h=master - Log - commit de9485784867a7a68207e42fe2a021de01e54904 Author: Andrew Tridgell tri...@samba.org Date: Thu Dec 31 16:53:14 2009 +1100 s4-net: fixed finddcs to use empty SID instead of NULL sid (NDR error) commit 9d6411d9dd2ef4bca247d41708bb6b0d0d14389a Author: Andrew Tridgell tri...@samba.org Date: Thu Dec 31 16:52:49 2009 +1100 s4-testpasswords: fixed CONFIG and quoting Need to pass correct config file to tests commit 3239872bbcd81a690663f29c8fa20811d66f9dea Author: Andrew Tridgell tri...@samba.org Date: Thu Dec 31 16:52:15 2009 +1100 s4-net: fixed pwsettings command Don't override user settings with current settings commit dbd7a62baa56eb2ce082fdcf24e2d8621a4f54ea Author: Jelmer Vernooij jel...@samba.org Date: Wed Dec 30 21:59:50 2009 +0100 py/security: Add test for dom_sid.split. Signed-off-by: Andrew Tridgell tri...@samba.org commit 66f81d18ce08cfb1ed6c347a753b436d3de8ced7 Author: Jelmer Vernooij jel...@samba.org Date: Wed Dec 30 21:48:42 2009 +0100 samba: Fix whitespace, remove pointless 'pass' statement. Signed-off-by: Andrew Tridgell tri...@samba.org commit ea5af6e30ca91df3325581f67daab96d688d58fc Author: Jelmer Vernooij jel...@samba.org Date: Wed Dec 30 21:46:32 2009 +0100 pyldb: Add dom_sid.split in favor of less powerful dom_sid_to_rid(). Signed-off-by: Andrew Tridgell tri...@samba.org commit 7effe2d2e30191c067ae1290224d388d96701b53 Author: Jelmer Vernooij jel...@samba.org Date: Wed Dec 30 21:06:21 2009 +0100 net: Support 'super' commands implemented in Python. Signed-off-by: Andrew Tridgell tri...@samba.org commit 9e5ef916d41ee5f27616d18e431a9943310d3db6 Author: Jelmer Vernooij jel...@samba.org Date: Wed Dec 30 20:40:11 2009 +0100 net: Move 'newuser' to 'net newuser' Signed-off-by: Andrew Tridgell tri...@samba.org commit 73594c248f35a6ebbe391cc46b717aff14d393be Author: Jelmer Vernooij jel...@samba.org Date: Wed Dec 30 20:10:34 2009 +0100 net: Fix tests and documentation of setexpiry. Signed-off-by: Andrew Tridgell tri...@samba.org commit 345b25d059db27f96b00143f7617919233a78ba4 Author: Jelmer Vernooij jel...@samba.org Date: Wed Dec 30 20:00:12 2009 +0100 net: Move setexpiry to 'net setexpiry' Signed-off-by: Andrew Tridgell tri...@samba.org commit b531696a5b878beef9d0177eeb4939160d1a602e Author: Jelmer Vernooij jel...@samba.org Date: Wed Dec 30 19:53:05 2009 +0100 net: Move 'setpassword' to 'net setpassword'. Signed-off-by: Andrew Tridgell tri...@samba.org commit 552e65679df23f488ecee2c0d8555f5e0dad9166 Author: Jelmer Vernooij jel...@samba.org Date: Wed Dec 30 18:01:24 2009 +0100 net: Allow Python commands to return None instead of 0. Signed-off-by: Andrew Tridgell tri...@samba.org commit 797977ac53466cb3096d1457e8df087eb7ad7598 Author: Jelmer Vernooij jel...@samba.org Date: Wed Dec 30 17:58:30 2009 +0100 blackbox.passwords: Use convenience variable for net. Signed-off-by: Andrew Tridgell tri...@samba.org commit 18d221342bf87d4ef4b90d1308b957daea1faddd Author: Jelmer Vernooij jel...@samba.org Date: Wed Dec 30 14:55:49 2009 +0100 Fix commands in password tests. Signed-off-by: Andrew Tridgell tri...@samba.org commit 31cc963ba0adc043032ad2113b44a5d599fa07d5 Author: Jelmer Vernooij jel...@samba.org Date: Wed Dec 30 14:55:07 2009 +0100 net: Allow python subcommands to provide commands that are not recognized by net itself. Signed-off-by: Andrew Tridgell tri...@samba.org
Build status as of Thu Dec 31 07:00:02 2009
URL: http://build.samba.org/ --- /home/build/master/cache/broken_results.txt.old 2009-12-30 00:00:03.0 -0700 +++ /home/build/master/cache/broken_results.txt 2009-12-31 00:00:03.0 -0700 @@ -1,22 +1,22 @@ -Build status as of Wed Dec 30 07:00:03 2009 +Build status as of Thu Dec 31 07:00:02 2009 Build counts: Tree Total Broken Panic build_farm 0 0 0 -ccache 1 1 0 +ccache 2 1 0 distcc 0 0 0 -ldb 2 2 0 +ldb 16 16 0 libreplace 1 1 0 lorikeet 0 0 0 pidl 1 1 0 ppp 0 0 0 -rsync16 8 0 +rsync30 12 0 samba-docs 0 0 0 samba-web0 0 0 -samba_3_current 14 14 0 -samba_3_master 24 24 4 -samba_3_next 15 15 1 -samba_4_0_test 26 26 1 +samba_3_current 15 14 0 +samba_3_master 28 28 4 +samba_3_next 28 27 2 +samba_4_0_test 30 30 1 talloc 1 1 0 -tdb 1 1 0 +tdb 2 2 0
