date:20100419

[Samba] error in 3.5.2 compilation

2010-04-19 Thread vishesh kumar

Dear all
I compiled and installed samba 3.5.2 on centos 5.4. Everything installed
successfully but starting smbd shows following error
./sbin/smbd: error while loading shared libraries: libwbclient.so.0: cannot
open shared object file: No such file or directory

Am i doing anything wrong?

Thanks  Regards
 Vishesh kumar

-- 
http://linuxinterviews.blogspot.com
-- 
To unsubscribe from this list go to the following URL and read the
instructions:  https://lists.samba.org/mailman/options/samba

Re: [Samba] Point'n'print support of various printer drivers

2010-04-19 Thread Roel van Meer


Ryan Suarez writes:

We're using Point'n'print with different versions of samba (3.3.x, 
3.4.x, 3.5.x) and in most cases it works really well. However, there 
are some printer drivers with which we just cannot get printing to 
work properly: in these cases not all driver features (like color, 
duplex or multiple copies) are available.


I was wondering if this is a known inherent problem with some printer 
drivers, or if this is caused by samba not supporting specific methods 
or other requirements that these drivers would have.


[...]


Great question +1.  All our lexmark drivers work like a charm.


Thanks. Yes, luckily a lot of drivers work perfectly. But with some people, 
the things that don't work are much more important than the things that do 
work.


Xerox drivers are a PITA.  I'm referring to vendor specific drivers, 
since Windows does not have a bundle for the newest Xerox models we 
have.  I was also considering filing bug reports for these.


There is a bug for a xerox driver currently on the table: 
https://bugzilla.samba.org/show_bug.cgi?id=6296


Regards,

roel
--
To unsubscribe from this list go to the following URL and read the
instructions:  https://lists.samba.org/mailman/options/samba

Re: [Samba] Point'n'print support of various printer drivers

2010-04-19 Thread Roel van Meer


ray klassen writes:

The problem is always when a printer driver makes a call to a windows dll 
on the server which the linux server can't respond to. Wish the driver 
developers would brain up...


So you're saying those drivers just cannot work, right?

Is there a list somewhere of drivers that are known (not) to work with samba 
point'n'print?


Regards,

roel




From: Ryan Suarez ryan.sua...@sheridanc.on.ca
To: Roel van Meer ro...@bokxing.nl; samba@lists.samba.org
Sent: Fri, 16 April, 2010 12:03:34
Subject: Re: [Samba] Point'n'print support of various printer drivers

Roel van Meer wrote:

We're using Point'n'print with different versions of samba (3.3.x, 3.4.x,
3.5.x) and in most cases it works really well. However, there are some
printer drivers with which we just cannot get printing to work properly:
in these cases not all driver features (like color, duplex or multiple
copies) are available.

I was wondering if this is a known inherent problem with some printer drivers, 
or if this is caused by samba not supporting specific methods or other 
requirements that these drivers would have.

The reason I'm asking is that I would like to know whether or not it's
useful filing bugs for these issues. I already have test setups and I'm
willing and able to spend time helping debug these issues, but if this is
one of those things that'll just never work it's not really useful
bothering anyone with it.

Examples of drivers that we can't get to work properly are the Brother 
HL4040-CN and various drivers from HP (the bundled Windows drivers for HP 
printers usually work fine.)

Great question +1.  All our lexmark drivers work like a charm.

Xerox drivers are a PITA.  I'm referring to vendor specific drivers, since 
Windows does not have a bundle for the newest Xerox models we have.  I was also 
considering filing bug reports for these.
-- To unsubscribe from this list go to the following URL and read the
instructions:  https://lists.samba.org/mailman/options/samba



  
--

To unsubscribe from this list go to the following URL and read the
instructions:  https://lists.samba.org/mailman/options/samba

--
To unsubscribe from this list go to the following URL and read the
instructions:  https://lists.samba.org/mailman/options/samba

Re: [Samba] krb5 library issues when Compiling 3.5.2 and 3.4.7 on AIX 5.3

2010-04-19 Thread Craig Green

HI,

I have altered my build script so that the variables are exported.
I now get past the issue of configure falling over but the make now fails.
The data and issues I have listed here refer to samba 3.5.0.
I will be running a configure and make for 3.4.7 overnight to see if I get the 
same issues.

The configure runs to completion and here is the tail end of the output.

#define HAVE_ZLIB_H 1
#define HAVE_ZLIBVERSION 1
#define HAVE_LIBZ 1

configure: exit 0

Here is the tail end of the output from the make.

(ld): lib /usr/lib/libxdsm.a
(ld): i bin/libtalloc.a
(ld): i bin/libtdb.a
(ld): lib /opt/pware/lib/libwbclient.so
(ld): lib /opt/pware/lib/libz.so
(ld): i /opt/freeware/lib/gcc/powerpc-ibm-aix5.3.0.0/4.2.4/libgcc.a
(ld): i /opt/freeware/lib/gcc/powerpc-ibm-aix5.3.0.0/4.2.4/libgcc_eh.a
(ld): lib /usr/lib/libc.a
(ld): lib /usr/lib/librtl.a
LIBRARY: Shared object libldap.so: 463 symbols imported.
LIBRARY: Shared object liblber.so: 134 symbols imported.
LIBRARY: Shared object libgssapi_krb5.so: 73 symbols imported.
LIBRARY: Shared object libkrb5.so: 746 symbols imported.
LIBRARY: Shared object libk5crypto.so: 158 symbols imported.
LIBRARY: Shared object libcom_err.so: 9 symbols imported.
LIBRARY: Shared object libpthreads.a[shr_comm.o]: 177 symbols imported.
LIBRARY: Shared object libpthreads.a[shr_xpg5.o]: 162 symbols imported.
LIBRARY: Shared object libpam.a[shr.o]: 23 symbols imported.
LIBRARY: Shared object libiconv.a[libiconv.so.2]: 13 symbols imported.
LIBRARY: Shared object librt.a[posix_aio.o]: 7 symbols imported.
LIBRARY: Shared object libpopt.a[libpopt.so.0]: 30 symbols imported.
LIBRARY: Shared object libxdsm.a[shr.o]: 75 symbols imported.
LIBRARY: Shared object libwbclient.so: 108 symbols imported.
LIBRARY: Shared object libz.so: 72 symbols imported.
LIBRARY: Shared object libc.a[shr.o]: 2875 symbols imported.
LIBRARY: Shared object libc.a[meth.o]: 2 symbols imported.
LIBRARY: Shared object libc.a[posix_aio.o]: 20 symbols imported.
LIBRARY: Shared object libc.a[aio.o]: 18 symbols imported.
LIBRARY: Shared object libc.a[pse.o]: 5 symbols imported.
LIBRARY: Shared object libc.a[dl.o]: 4 symbols imported.
LIBRARY: Shared object libc.a[pty.o]: 1 symbols imported.
LIBRARY: Shared object librtl.a[shr.o]: 1 symbols imported.
LIBRARY: Shared object librtl.a[lazy42.o]: 3 symbols imported.
FILELIST: Number of previously inserted files processed: 561
(ld): initfini _GLOBAL__FI_smbd _GLOBAL__FD_smbd
(ld): resolve
ld: 0711-228 WARNING: Duplicate symbols were found while resolving symbols.
The following duplicates were found:
 SymbolSource-File(Object) OR Import-File{Shared-object}
 - -
 __start   crt0main.s(/lib/crt0.o)
** Duplicate **{/opt/pware/lib/libwbclient.so}
 .__start  crt0main.s(/lib/crt0.o)
** Duplicate **{/opt/pware/lib/libwbclient.so}
 __C_runtime_pstartup  crt0main.s(/lib/crt0.o)
** Duplicate **{/opt/pware/lib/libwbclient.so}
 p_xargc   crt0main.s(/lib/crt0.o)
** Duplicate **{/opt/pware/lib/libwbclient.so}
 p_xargv   crt0main.s(/lib/crt0.o)
** Duplicate **{/opt/pware/lib/libwbclient.so}
 .__threads_init   
../../../../../../../src/bos/usr/ccs/lib/libc/__threads_init.c(/lib/crt0.o)
** Duplicate **{/opt/pware/lib/libwbclient.so}
 __threads_init
../../../../../../../src/bos/usr/ccs/lib/libc/__threads_init.c(/lib/crt0.o)
** Duplicate **{/opt/pware/lib/libwbclient.so}
 _malloc_user_defined_name 
../../../../../../../src/bos/usr/ccs/lib/libc/__threads_init.c(/lib/crt0.o)
** Duplicate **{/opt/pware/lib/libwbclient.so}
 __pth_init_routine
../../../../../../../../src/bos/usr/ccs/lib/libpthreads/init.c(/usr/lib/libpthreads.a[init.o])
** Duplicate **
../../../../../../../src/bos/usr/ccs/lib/libc/__threads_init.c(/lib/crt0.o)
** Duplicate **{/opt/pware/lib/libwbclient.so}
 _bsd_init_routine 
../../../../../../../src/bos/usr/ccs/lib/libc/__threads_init.c(/lib/crt0.o)
** Duplicate **{/opt/pware/lib/libwbclient.so}
 _xti_tli_init_routine 
../../../../../../../src/bos/usr/ccs/lib/libc/__threads_init.c(/lib/crt0.o)
** Duplicate **{/opt/pware/lib/libwbclient.so}
 _nsl_init_routine 
../../../../../../../src/bos/usr/ccs/lib/libc/__threads_init.c(/lib/crt0.o)
** Duplicate **{/opt/pware/lib/libwbclient.so}
 __dce_compat_init_routine 
../../../../../../../src/bos/usr/ccs/lib/libc/__threads_init.c(/lib/crt0.o)
** Duplicate **{/opt/pware/lib/libwbclient.so}
 p_xrcfg   crt0main.s(/lib/crt0.o)
** Duplicate **{/opt/pware/lib/libwbclient.so}
 p_xrc crt0main.s(/lib/crt0.o)
** Duplicate **{/opt/pware/lib/libwbclient.so}
 _GLOBAL__F___divdi3_7DED82B0 {/opt/pware/lib/libwbclient.so}

Re: [Samba] error in 3.5.2 compilation

2010-04-19 Thread Miguel Medalha




 I compiled and installed samba 3.5.2 on centos 5.4. Everything installed
successfully but starting smbd shows following error
./sbin/smbd: error while loading shared libraries: libwbclient.so.0: cannot
open shared object file: No such file or directory
   


Do you have some particular reason not to use one of the precompiled 
packages from Sernet?

There are specific packages for CentOS 5.x here:

ftp://ftp.sernet.de/pub/samba/3.5/centos/5/

--
To unsubscribe from this list go to the following URL and read the
instructions:  https://lists.samba.org/mailman/options/samba

Re: [Samba] Encryption

2010-04-19 Thread Nico Kadel-Garcia

On Sun, Apr 18, 2010 at 9:00 PM, Jeremy Allison j...@samba.org wrote:
 On Sun, Apr 18, 2010 at 09:20:54AM -0400, Nico Kadel-Garcia wrote:

 Samba is a very helpful implementation of CIFS, and I congratulate its
 authors. But CIFS was *not* built for data security. Encrypting such
 traffic would be an amazing performance hit on the server side. If you
 need secure data transfer, and do not need the kind of live sharing
 that CIFS or UNIX protocols like NFS provide, I'd urge you to use
 git for SSH based access to a central repository with local editing
 and full source control features. It's still a performance hit over
 direct file sharing, but it works well for interrupted connections to
 the primary document source, and I really like it for laptop or remote
 data center operation.

 Ahem. We *do* implement encryption on the CIFS stream in
 the Samba server. Works well with smbclient -e option.
 All it needs is for the kernel client to implement it.

 It's not such a bad hit on the server side of things :-).

 Jeremy.


Thank you, yes, I saw those notes from Volker and simo. This is what I
get for working professionally with old releases. I also noticed that
it relies on Samba 3.2 or later on both ends, and so isn't compatible
with Windows servers or clients or older clients. Now if I can just
shoot all the old versions in use out there. ;'-)
-- 
To unsubscribe from this list go to the following URL and read the
instructions:  https://lists.samba.org/mailman/options/samba

Re: [Samba] Encryption

2010-04-19 Thread Andrew Malton


Thanks for helpful comments and suggestions.

In our situation we can't use smbclient -e because the data sources  
are not Samba/Linux, they're running various versions of Windows.
But also, what we're doing is not file access but event log access.   
We aren't using CIFS but calling into ndr subroutines.  As I said, we  
are using Samba code, not just being Samba users.


The behaviour is this.  When connecting and retrieving event logs  
(using dcerpc_eventlog_ReadEventLogW and friends) the traffic is  
encrypted when talking to e.g. Windows 2000 (I think actually  
anything before Win2003 SP 2)  but unencrypted when talking e.g. to  
Server 2008.   We are, of course, never talking to Samba servers as  
such.


Authorization seems to be encrypted in both cases, that isn't the issue.

(We are on Samba 4 for some purposes.  In Samba 4, there's a torture  
test covering the event log API that exhibits the same behaviour we  
have seen by our client.)


A Malton


--
Dr. Andrew Malton
e•sentire Critical Security Solutions
260 Holiday Inn Drive Building A Suite 29
Cambridge
Canada N3C 4E8

AIM:ajmal...@mac.com
tel: +1 519 651 2299 x 119







--
To unsubscribe from this list go to the following URL and read the
instructions:  https://lists.samba.org/mailman/options/samba

[Samba] Samba4 segfault

2010-04-19 Thread Marcel Ritter

Hi,

during my tests to use Samba4 as a kdc for kerberized NFS,
I found a bug in the KDC code, when generating a principal
without pac (e.g. with msktutil and option --no-pac), that
causes Samba4 to crash:

Running the following command on one of the client machines

  msktutil -c --upn nfs/testa.linex.org  -h testa.linex.org
--computer-name testa-service-nfs  --server s4-dc1.linex.org --no-pac

results in this gdb backtrace on the samba4 dc (s4-dc1.linex.org):

  Program received signal SIGSEGV, Segmentation fault. 
  0x005e82e6 in samba_make_krb5_pac ()
  Current language:  auto; currently asm
  (gdb) bt  
  #0  0x005e82e6 in samba_make_krb5_pac ()
  #1  0x004ce243 in samba_wdc_get_pac ()
  #2  0x0059290b in _kdc_pac_generate ()
  #3  0x00588055 in _kdc_as_rep ()
  #4  0x005922ec in kdc_as_req ()
  #5  0x0059258e in krb5_kdc_process_krb5_request ()
  #6  0x005fc1dc in kdc_process ()
  #7  0x005fc4bb in kdc_tcp_call_loop ()
  ...

Looking at the code, the error is quite easy to find: 

source4/kdc/wdc-samba4.c: krb5_error_code samba_wdc_get_pac()
   calls 

1.) source4/kdc/pac-glue.c: samba_kdc_get_pac_blob()

  /* The user account may be set not to want the PAC */
  ...
 *_pac_blob = NULL;

and then calls

2. source4/kdc/pac-glue.c: samba_make_krb5_pac()
   which tries to use uninitalized pac_blob and segfaults


A simple patch is attached that solved the problem for me.

Bye,
   Marcel 
-- 
To unsubscribe from this list go to the following URL and read the
instructions:  https://lists.samba.org/mailman/options/samba

Re: [Samba] Encryption

2010-04-19 Thread Jeremy Allison

On Mon, Apr 19, 2010 at 09:57:53AM -0400, Andrew Malton wrote:
 Thanks for helpful comments and suggestions.
 
 In our situation we can't use smbclient -e because the data sources
 are not Samba/Linux, they're running various versions of Windows.
 But also, what we're doing is not file access but event log access.
 We aren't using CIFS but calling into ndr subroutines.  As I said,
 we are using Samba code, not just being Samba users.
 
 The behaviour is this.  When connecting and retrieving event logs
 (using dcerpc_eventlog_ReadEventLogW and friends) the traffic is
 encrypted when talking to e.g. Windows 2000 (I think actually
 anything before Win2003 SP 2)  but unencrypted when talking e.g. to
 Server 2008.   We are, of course, never talking to Samba servers as
 such.
 
 Authorization seems to be encrypted in both cases, that isn't the issue.

This is RPC encryption, not SMB transport encryption. This can
be negotiated on the traffic being carried within the SMB
transport.

Jeremy.
-- 
To unsubscribe from this list go to the following URL and read the
instructions:  https://lists.samba.org/mailman/options/samba

Re: [Samba] Point'n'print support of various printer drivers

2010-04-19 Thread ray klassen

There are some I've never gotten to work. There's a crash (unhandled exception 
or something like that) right in the middle of configuring the driver that 
looked very much to me that it was a call back to the server. Certain 
Konica-Minolta drivers do this. Any other wisdom out there on this subject 
would be appreciated. I don't know of a list. 

I may try again, now that my server's up to the latest greatest 3.x...




From: Roel van Meer ro...@bokxing.nl
To: ray klassen julius_ahenobar...@yahoo.co.uk
Cc: samba@lists.samba.org
Sent: Mon, 19 April, 2010 0:17:48
Subject: Re: [Samba] Point'n'print support of various printer drivers

ray klassen writes:

 The problem is always when a printer driver makes a call to a windows dll on 
 the server which the linux server can't respond to. Wish the driver 
 developers would brain up...

So you're saying those drivers just cannot work, right?

Is there a list somewhere of drivers that are known (not) to work with samba 
point'n'print?

Regards,

roel


 
 From: Ryan Suarez ryan.sua...@sheridanc.on.ca
 To: Roel van Meer ro...@bokxing.nl; samba@lists.samba.org
 Sent: Fri, 16 April, 2010 12:03:34
 Subject: Re: [Samba] Point'n'print support of various printer drivers
 
 Roel van Meer wrote:
 We're using Point'n'print with different versions of samba (3.3.x, 3.4.x,
 3.5.x) and in most cases it works really well. However, there are some
 printer drivers with which we just cannot get printing to work properly:
 in these cases not all driver features (like color, duplex or multiple
 copies) are available.
 
 I was wondering if this is a known inherent problem with some printer 
 drivers, or if this is caused by samba not supporting specific methods or 
 other requirements that these drivers would have.
 
 The reason I'm asking is that I would like to know whether or not it's
 useful filing bugs for these issues. I already have test setups and I'm
 willing and able to spend time helping debug these issues, but if this is
 one of those things that'll just never work it's not really useful
 bothering anyone with it.
 
 Examples of drivers that we can't get to work properly are the Brother 
 HL4040-CN and various drivers from HP (the bundled Windows drivers for HP 
 printers usually work fine.)
 Great question +1.  All our lexmark drivers work like a charm.
 
 Xerox drivers are a PITA.  I'm referring to vendor specific drivers, since 
 Windows does not have a bundle for the newest Xerox models we have.  I was 
 also considering filing bug reports for these.
 -- To unsubscribe from this list go to the following URL and read the
 instructions:  https://lists.samba.org/mailman/options/samba
 
 
 
   -- To unsubscribe from this list go to the following URL and read the
 instructions:  https://lists.samba.org/mailman/options/samba



  
-- 
To unsubscribe from this list go to the following URL and read the
instructions:  https://lists.samba.org/mailman/options/samba

[Samba] Windows 7 can't see my Samba server

2010-04-19 Thread Steve Blackwell

It's really weird how many times thing break in threes. This time is
was my wife's laptop, my router and a phone.

Anyway...

My network has a router and 2 computers; my F11 box with the samba
server on it called steve and my wife's laptop now running Windows 7
called Kellie-PC.

My old router was a Linksys WRT54G that I had flashed with DD-WRT. I
was using DHCP and DNS masquerading in the router. The new router is a
CISCO E3000 which isn't supported yet by DD-WRT so no local DNS but
I'm still using DHCP. For my test I added Kellie-PC to /etc/hosts and
check the IP address before I run the test.

steve can ping Kellie-PC by name and Kellie-PC can ping steve by IP
address.

I have one samba user, Kellie, defined.

Following the samba checklist
(http://samba.org/samba/docs/man/Samba-HOWTO-Collection/diagnosis.html)
and running these commands in a terminal window on steve as user steve:

$ smbclient -L steve -U Kellie
Enter Kellie's password: 
Domain=[WORKGROUP] OS=[Unix] Server=[Samba 3.4.7-0.50.fc11]

Sharename   Type  Comment
-     ---
homes   Disk  Home Directories
Kellie  Disk  Kellies Documents and Settings folder
on the Winblows side of Steves computer 
IPC$IPC   IPC Service (Steve's Samba Server
Version 3.4.7-0.50.fc11) 
DESKJET_600 Printer   Steve's printer 
-2600-SeriesPrinter   Lexmark  2600 Series
Domain=[WORKGROUP] OS=[Unix] Server=[Samba 3.4.7-0.50.fc11]

Server   Comment
----
COPPERFISH   E3000
STEVESteve's Samba Server Version
3.4.7-0.50.fc11

WorkgroupMaster
----
WORKGROUPCOPPERFISH

$ nmblookup -B steve __SAMBA__
querying __SAMBA__ on 127.0.0.1
192.168.1.120 __SAMBA__00

$ nmblookup -B Kellie-PC '*'
querying * on 192.168.1.122
name_query failed to find name *

I suspect that this is some kind of permissions problem on the Win7 box
but the fact that the E3000 router is showing up as the workgroup
master also looks suspect.
I have tried adding the registry key LmCompatabilityMode = 1 to the
Win7 machine but no luck.

Any help or pointers to some readable Win7 docs would be appreciated.
This used to work OK under Vista.

Thanks,
Steve.
-- 
To unsubscribe from this list go to the following URL and read the
instructions:  https://lists.samba.org/mailman/options/samba

Re: [Samba] Windows 7 can't see my Samba server

2010-04-19 Thread Steve Blackwell

On Mon, 19 Apr 2010 12:17:36 -0400
Steve Blackwell zep...@cfl.rr.com wrote:

 It's really weird how many times thing break in threes. This time is
 was my wife's laptop, my router and a phone.
 
 Anyway...
 
 My network has a router and 2 computers; my F11 box with the samba
 server on it called steve and my wife's laptop now running Windows 7
 called Kellie-PC.
 
 My old router was a Linksys WRT54G that I had flashed with DD-WRT. I
 was using DHCP and DNS masquerading in the router. The new router is a
 CISCO E3000 which isn't supported yet by DD-WRT so no local DNS but
 I'm still using DHCP. For my test I added Kellie-PC to /etc/hosts and
 check the IP address before I run the test.
 
 steve can ping Kellie-PC by name and Kellie-PC can ping steve by IP
 address.
 
 I have one samba user, Kellie, defined.
 
 Following the samba checklist
 (http://samba.org/samba/docs/man/Samba-HOWTO-Collection/diagnosis.html)
 and running these commands in a terminal window on steve as user
 steve:
 
 $ smbclient -L steve -U Kellie
 Enter Kellie's password: 
 Domain=[WORKGROUP] OS=[Unix] Server=[Samba 3.4.7-0.50.fc11]
 
   Sharename   Type  Comment
   -     ---
   homes   Disk  Home Directories
   Kellie  Disk  Kellies Documents and Settings
 folder on the Winblows side of Steves computer 
 IPC$IPC   IPC Service (Steve's Samba Server
 Version 3.4.7-0.50.fc11) 
 DESKJET_600 Printer   Steve's printer 
 -2600-SeriesPrinter   Lexmark  2600 Series
 Domain=[WORKGROUP] OS=[Unix] Server=[Samba 3.4.7-0.50.fc11]
 
   Server   Comment
   ----
   COPPERFISH   E3000
   STEVESteve's Samba Server Version
 3.4.7-0.50.fc11
 
   WorkgroupMaster
   ----
   WORKGROUPCOPPERFISH
 
 $ nmblookup -B steve __SAMBA__
 querying __SAMBA__ on 127.0.0.1
 192.168.1.120 __SAMBA__00
 
 $ nmblookup -B Kellie-PC '*'
 querying * on 192.168.1.122
 name_query failed to find name *
 
 I suspect that this is some kind of permissions problem on the Win7
 box but the fact that the E3000 router is showing up as the workgroup
 master also looks suspect.
 I have tried adding the registry key LmCompatabilityMode = 1 to the
 Win7 machine but no luck.
 
 Any help or pointers to some readable Win7 docs would be appreciated.
 This used to work OK under Vista.
 
 Thanks,
 Steve.

Oops,

The last two I got wrong. They should be
$ nmblookup -B steve __SAMBA__ -U Kellie
querying __SAMBA__ on 0.0.0.0
192.168.1.120 __SAMBA__00

and 
$ nmblookup -B Kellie-PC '*' -U Kellie
querying * on 0.0.0.0
192.168.1.120 *00

So they both give me the IP address of my samba server instead of the
second one giving me the IP address of Kellie-PC
-- 
To unsubscribe from this list go to the following URL and read the
instructions:  https://lists.samba.org/mailman/options/samba

Re: [Samba] Samba Secondary Groups

2010-04-19 Thread grant little

I had that problem with samba 3.4.X on ubuntu 9.10,  the only way I could
get it to work was to use 777 folder permissions as you describe. The fix
for me was to go to samba 3.5.X which fixed that and several other problems
like not being able to login to samba from OS X.
 Tried the same on a CENTOS 5.4 install as well and it works for SAMBA
3.0.33 with 770 folder permissions. Maybe a samba upgrade might fix what
ails you but be careful what you upgrade to...


On Sun, Apr 18, 2010 at 10:19 PM, David van Laatum da...@vanlaatum.id.auwrote:

 This has been bugging me for years but never got around to spending a lot
 of time on it until I now want/need to use it for work stuff.

 Problem is simple I get access denied when trying to create a file in a
 directory that is not owned by me or my primary group that doesn't have
 world writable permissions. Ive also had similar issues with NFS mounts
 where I can't move/create/delete files via
 nfs but works fine if I do it on the local machine even though I am the
 same user in the same groups. All relevant info I can think of follows let
 me know if anything else is needed. Spent all morning looking for an answer
 but only found hints of similar but not
 applicable problems.

 [14:14:36 r...@adl-nas-01 filestore]# smbd -V
 Version 3.2.5
 [14:28:42 r...@adl-nas-01 filestore]# uname -a
 Linux adl-nas-01 2.6.26-2-amd64 #1 SMP Tue Mar 9 22:29:32 UTC 2010 x86_64
 GNU/Linux
 [14:28:42 r...@adl-nas-01 filestore]# cat /etc/debian_version
 5.0.4

 [global]
   security = ads
   workgroup = VALEX
   server string = File Store
   realm = VALEX.LOCAL
   password server = ldap.valex.local
   wins server = 172.16.0.150
   dns proxy = no
   log file = /var/log/samba/log.%m
   max log size = 100
   log level = 3
   syslog = 1
   panic action = /usr/share/samba/panic-action %d
   encrypt passwords = yes
   printing = bsd
   printcap name = /etc/printcap
   idmap backend = ad
   passdb backend = tdbsam
   idmap uid = 100-9
   idmap gid = 100-90
   winbind cache time = 300
   winbind nss info = rfc2307
   winbind enum groups = yes
   winbind enum users = yes
   winbind use default domain = yes
   winbind separator = /
   winbind nested groups = yes
   template homedir = /home/%U/homedir
   template shell = /bin/bash
   debug uid = yes

 [Accounts]
  comment = Accounts Stuff
  path = /filestore/accounts
  guest ok = no
  browseable = yes
 ;  valid users = @VALEX/vxAccounts @VALEX/vxSystems
  create mask = 0660
  directory mask = 0770
  fstype = EXT3
 ;  force group = +...@valex/vxAccounts

 [14:32:58 r...@adl-nas-01 filestore]# id dvanlaatum
 uid=10440(dvanlaatum) gid=2(vxsystems)
 groups=2(vxsystems),20002(domain admins),20003(domain
 users),20001(vxallusers),5006(BUILTIN/administrators),5007(BUILTIN/users)

 [14:35:02 r...@adl-nas-01 filestore]# ls -ald /filestore/accounts/
 drwxrwxr-x 3 root vxallusers 4096 2010-04-19 11:32 /filestore/accounts/

 [14:37:54 da...@l00018 ~]# smbclient -U dvanlaatum //adl-nas-01/Accounts
 Password:
 Domain=[VALEX] OS=[Unix] Server=[Samba 3.2.5]
 smb: \ mkdir test
 NT_STATUS_MEDIA_WRITE_PROTECTED making remote directory \test
 --
 To unsubscribe from this list go to the following URL and read the
 instructions:  https://lists.samba.org/mailman/options/samba

-- 
To unsubscribe from this list go to the following URL and read the
instructions:  https://lists.samba.org/mailman/options/samba

[Samba] Samba configuration question

2010-04-19 Thread Song, Young

 

Hi,

 

 

I have a top-level directory called /data existing on a Solaris server
that I'd like to make browsable and readonly by anybody at my company.

 

Let's say I have the following in my smb.conf.

 

What if I want to share /data's subdirectories (e.g., /data/01,
/data/02, /data/01/group1, /data/01/group2, etc.) writeable by only
authorized users per subdirectory? Could someone please give me some
examples?

 

 

[global]

   workgroup = Alpha

   netbios name = dataserver01

   security = share

 

[interface]

   path = /data

   available = yes

   browsable = yes

   public = yes

   writeable = yes

   guest ok = yes

   readonly = yes

 

 

Thanks in advance.

 

 

- Young

 

 

-- 
To unsubscribe from this list go to the following URL and read the
instructions:  https://lists.samba.org/mailman/options/samba

Re: [Samba] Samba configuration question

2010-04-19 Thread John Drescher

On Mon, Apr 19, 2010 at 2:19 PM, Song, Young young.s...@novellus.com wrote:


 Hi,





 I have a top-level directory called /data existing on a Solaris server
 that I'd like to make browsable and readonly by anybody at my company.



 Let's say I have the following in my smb.conf.



 What if I want to share /data's subdirectories (e.g., /data/01,
 /data/02, /data/01/group1, /data/01/group2, etc.) writeable by only
 authorized users per subdirectory? Could someone please give me some
 examples?


I would set the appropriate POSIX ACLs in your host filesystem.

John
-- 
To unsubscribe from this list go to the following URL and read the
instructions:  https://lists.samba.org/mailman/options/samba

Re: [Samba] Encryption

2010-04-19 Thread David Magda

On Mon, April 19, 2010 11:13, Jeremy Allison wrote:

 This is RPC encryption, not SMB transport encryption. This can
 be negotiated on the traffic being carried within the SMB
 transport.

Are OpenSSL's routines for all of this? If you have hardware support for
encryption (add-in card, CPU a la UltraSPARC-T2), is it possible to use
OpenSSL's engine support for acceleration?


-- 
To unsubscribe from this list go to the following URL and read the
instructions:  https://lists.samba.org/mailman/options/samba

Re: [Samba] Encryption

2010-04-19 Thread Jeremy Allison

On Mon, Apr 19, 2010 at 02:49:52PM -0400, David Magda wrote:
 On Mon, April 19, 2010 11:13, Jeremy Allison wrote:
 
  This is RPC encryption, not SMB transport encryption. This can
  be negotiated on the traffic being carried within the SMB
  transport.
 
 Are OpenSSL's routines for all of this? If you have hardware support for
 encryption (add-in card, CPU a la UltraSPARC-T2), is it possible to use
 OpenSSL's engine support for acceleration?

Nope. The code either uses the GSSAPI encryption code (for krb5) or
Samba's own arc4 code.

Jeremy.
-- 
To unsubscribe from this list go to the following URL and read the
instructions:  https://lists.samba.org/mailman/options/samba

Re: [Samba] (no subject)

2010-04-19 Thread Jeremy Allison

On Thu, Apr 15, 2010 at 12:07:40PM +0200, yves.coutoll...@erymaservices.com 
wrote:
 Hi,
 
 When I try to save a new execl file to a samba share, I 've got an error
 unable to access to file, but the file is currently well saved.
 No problem with open office nor ms word.
 
 A wireshark trace indicate Query_path_info/ error status_access_denied
 
 thanks for your help
 regards

More details needed please. Log a bug @ bugzilla.samba.org and
attach the relevent files/logs.

Thanks,

Jeremy.
-- 
To unsubscribe from this list go to the following URL and read the
instructions:  https://lists.samba.org/mailman/options/samba

[Samba] [oOT] ploenk....@eplus.blackberry.com please fix your mail forwarding

2010-04-19 Thread Stan Hoeppner

I've received a bunch of these blackberry backscatter messages over the past
week and have been unable to determine which list user is the cause of this.
 Whoever is forwarding your email to the blackberry address below, please
fix the situation.  It's becoming really annoying receiving these
backscatter bounces that give no clue as to what the nature of the problem
is.  Thanks.

Your message:
To: ploenk@eplus.blackberry.com
Subject: Re: [Samba] Ideas for distributed Samba servers
Sent Date: 47:37 +
has not been delivered to the recipient's BlackBerry Handheld.

-- 
Stan
-- 
To unsubscribe from this list go to the following URL and read the
instructions:  https://lists.samba.org/mailman/options/samba

Build status as of Mon Apr 19 06:00:03 2010

2010-04-19 Thread build

URL: http://build.samba.org/

--- /home/build/master/cache/broken_results.txt.old 2010-04-18 
00:00:04.0 -0600
+++ /home/build/master/cache/broken_results.txt 2010-04-19 00:00:13.0 
-0600
@@ -1,4 +1,4 @@
-Build status as of Sun Apr 18 06:00:02 2010
+Build status as of Mon Apr 19 06:00:03 2010
 
 Build counts:
 Tree Total  Broken Panic 
@@ -13,7 +13,7 @@
 samba-docs   0  0  0 
 samba-web0  0  0 
 samba_3_current 28 24 1 
-samba_3_master 28 27 1 
+samba_3_master 28 28 1 
 samba_3_next 28 25 2 
 samba_4_0_test 30 30 0 
 samba_4_0_waf 29 26 2

[SCM] Samba Shared Repository - branch master updated

2010-04-19 Thread Andrew Tridgell

The branch, master has been updated
   via  b6dff75... build: added --cross-answers support
   via  5040e2a... s4-dev: expanded selftest-vars.sh to match current 
testenv
   via  e6cbbd9... s4-python: PyErr_SetString() will crash on NULL strings
   via  93f4f7a... build: fixed a python-3 indent error
   via  4e51bf1... build: expanded testwaf to include cross-compiling and 
python versions
  from  59fa1e1... Final fix for #7331 - Compound async SMB 2 requests 
don't work right.

http://gitweb.samba.org/?p=samba.git;a=shortlog;h=master


- Log -
commit b6dff759f7016bb4820fc8f9d660bf565c7caeee
Author: Andrew Tridgell tri...@samba.org
Date:   Mon Apr 19 15:58:37 2010 +1000

build: added --cross-answers support

This allows you to easily cross-compile even without a --cross-execute
emulator

See http://wiki.samba.org/index.php/Waf#cross-compiling for details

commit 5040e2a6fbe8b240b1d445e1260bb95203618b75
Author: Andrew Tridgell tri...@samba.org
Date:   Mon Apr 19 13:49:00 2010 +1000

s4-dev: expanded selftest-vars.sh to match current testenv

commit e6cbbd9640e0e79653820e6cd5ea7b30c2e0f6bd
Author: Andrew Tridgell tri...@samba.org
Date:   Mon Apr 19 13:43:53 2010 +1000

s4-python: PyErr_SetString() will crash on NULL strings

use nt_errstr() when no error available

commit 93f4f7a0375b95540d7f701c295b88ed9c6322d8
Author: Andrew Tridgell tri...@samba.org
Date:   Mon Apr 19 13:43:12 2010 +1000

build: fixed a python-3 indent error

commit 4e51bf1ffdf55b8292383415bcc23803c8a56bc9
Author: Andrew Tridgell tri...@samba.org
Date:   Mon Apr 19 13:42:53 2010 +1000

build: expanded testwaf to include cross-compiling and python versions

---

Summary of changes:
 buildtools/testwaf.sh|   42 ---
 buildtools/wafsamba/samba_autoconf.py|3 +-
 buildtools/wafsamba/samba_conftests.py   |2 +-
 buildtools/wafsamba/samba_cross.py   |  114 --
 buildtools/wafsamba/samba_utils.py   |2 +-
 buildtools/wafsamba/wscript  |4 +
 source4/auth/credentials/pycredentials.c |2 +-
 source4/libnet/py_net.c  |   15 +++--
 source4/scripting/devel/selftest-vars.sh |   45 +++-
 9 files changed, 197 insertions(+), 32 deletions(-)


Changeset truncated at 500 lines:

diff --git a/buildtools/testwaf.sh b/buildtools/testwaf.sh
index 00e37c6..5f24bdd 100755
--- a/buildtools/testwaf.sh
+++ b/buildtools/testwaf.sh
@@ -1,5 +1,8 @@
 #!/bin/bash
 
+set -e
+set -x
+
 d=$(dirname $0)
 
 cd $d/..
@@ -15,28 +18,45 @@ echo testing in dirs $tests
 
 for d in $tests; do
 echo `date`: testing $d
-pushd $d || exit 1
+pushd $d
 rm -rf bin
 type waf
-waf dist || exit 1
-waf configure -C --enable-developer --prefix=$PREFIX || exit 1
-time waf build || exit 1
-time waf build || exit 1
-waf install || exit 1
-waf distcheck || exit 1
+waf dist
+waf configure -C --enable-developer --prefix=$PREFIX
+time waf build
+time waf build
+waf install
+waf distcheck
 case $d in
source4/lib/ldb)
-   ldd bin/ldbadd || exit 1
+   ldd bin/ldbadd
;;
lib/replace)
-   ldd bin/replace_testsuite || exit 1
+   ldd bin/replace_testsuite
;;
lib/talloc)
-   ldd bin/talloc_testsuite || exit 1
+   ldd bin/talloc_testsuite
;;
lib/tdb)
-   ldd bin/tdbtool || exit 1
+   ldd bin/tdbtool
;;
 esac
 popd
 done
+
+echo testing python portability
+pushd lib/talloc
+#versions=python2.4 python2.5 python2.6 python3.0 python3.1
+versions=python2.4 python2.5 python2.6
+for p in $versions; do
+echo Testing $p
+$p ../../buildtools/bin/waf configure -C --enable-developer 
--prefix=$PREFIX
+$p ../../buildtools/bin/waf build install
+done
+popd
+
+echo testing cross compiling
+pushd lib/talloc
+CC=arm-linux-gnu-gcc ./configure -C --prefix=$PREFIX  --cross-compile 
--cross-execute='qemu-arm-static -L /usr/arm-linux-gnu'
+make  make install
+popd
diff --git a/buildtools/wafsamba/samba_autoconf.py 
b/buildtools/wafsamba/samba_autoconf.py
index dd7abe2..fa58e8f 100644
--- a/buildtools/wafsamba/samba_autoconf.py
+++ b/buildtools/wafsamba/samba_autoconf.py
@@ -372,7 +372,7 @@ def CHECK_CODE(conf, code, define,
 cflags = TO_LIST(cflags)
 cflags.extend(ccflags)
 
-exec_args = conf.SAMBA_CROSS_ARGS()
+exec_args = conf.SAMBA_CROSS_ARGS(msg=msg)
 
 ret = conf.check(fragment=fragment,
  execute=execute,
@@ -567,6 +567,7 @@ def SAMBA_CONFIG_H(conf, path=None):
 conf.write_config_header('config.h', top=True)
 else:
 conf.write_config_header(path)
+conf.SAMBA_CROSS_CHECK_COMPLETE()
 
 
 @conf
diff --git

[SCM] Samba Shared Repository - branch master updated

2010-04-19 Thread Kai Blin

The branch, master has been updated
   via  e56dc83... s3 i18n: Fix up missing newlines in pam_winbind 
translations
  from  b6dff75... build: added --cross-answers support

http://gitweb.samba.org/?p=samba.git;a=shortlog;h=master


- Log -
commit e56dc831622271af81ce5bb90a749c2de80fedb2
Author: Kai Blin kai.b...@biotech.uni-tuebingen.de
Date:   Mon Apr 19 09:03:01 2010 +0200

s3 i18n: Fix up missing newlines in pam_winbind translations

At least in the languages I could read, the newlines were indeed
missing.

---

Summary of changes:
 source3/locale/pam_winbind/ar.po |4 ++--
 source3/locale/pam_winbind/cs.po |4 ++--
 source3/locale/pam_winbind/da.po |4 ++--
 source3/locale/pam_winbind/de.po |4 ++--
 source3/locale/pam_winbind/es.po |4 ++--
 source3/locale/pam_winbind/fi.po |4 ++--
 source3/locale/pam_winbind/fr.po |4 ++--
 source3/locale/pam_winbind/hu.po |4 ++--
 source3/locale/pam_winbind/it.po |4 ++--
 source3/locale/pam_winbind/ja.po |4 ++--
 10 files changed, 20 insertions(+), 20 deletions(-)


Changeset truncated at 500 lines:

diff --git a/source3/locale/pam_winbind/ar.po b/source3/locale/pam_winbind/ar.po
index de56bf7..8bb8897 100644
--- a/source3/locale/pam_winbind/ar.po
+++ b/source3/locale/pam_winbind/ar.po
@@ -85,12 +85,12 @@ msgstr ÙÙØ²Ù ØªØºÙÙØ± ÙÙÙØ© Ø§ÙØ³Ø± Ø§ÙØ¢Ù
 #: ../../../nsswitch/pam_winbind.c:902
 #, fuzzy
 msgid Your password expires today.\n
-msgstr Ø§ÙØªÙØª ØµÙØ§ØÙØ© ÙÙÙØ© Ø§ÙØ³Ø± Ø§ÙØ®Ø§ØµØ© Ø¨Ù Ø§ÙÙÙÙ
+msgstr Ø§ÙØªÙØª ØµÙØ§ØÙØ© ÙÙÙØ© Ø§ÙØ³Ø± Ø§ÙØ®Ø§ØµØ© Ø¨Ù 
Ø§ÙÙÙÙ\n
 
 #: ../../../nsswitch/pam_winbind.c:932
 #, fuzzy, c-format
 msgid Your password will expire in %d %s.\n
-msgstr Ø³ØªÙØªÙÙ ØµÙØ§ØÙØ© ÙÙÙØ© Ø§ÙØ³Ø± Ø§ÙØ®Ø§ØµØ© Ø¨Ù Ø®ÙØ§Ù 
%d %s
+msgstr Ø³ØªÙØªÙÙ ØµÙØ§ØÙØ© ÙÙÙØ© Ø§ÙØ³Ø± Ø§ÙØ®Ø§ØµØ© Ø¨Ù Ø®ÙØ§Ù 
%d %s\n
 
 #: ../../../nsswitch/pam_winbind.c:933
 msgid days
diff --git a/source3/locale/pam_winbind/cs.po b/source3/locale/pam_winbind/cs.po
index a299c1d..8940f59 100644
--- a/source3/locale/pam_winbind/cs.po
+++ b/source3/locale/pam_winbind/cs.po
@@ -85,12 +85,12 @@ msgstr Je potÅeba zmÄnit VaÅ¡e heslo
 #: ../../../nsswitch/pam_winbind.c:902
 #, fuzzy
 msgid Your password expires today.\n
-msgstr VaÅ¡e heslo vyprÅ¡Ã dnes.
+msgstr VaÅ¡e heslo vyprÅ¡Ã dnes.\n
 
 #: ../../../nsswitch/pam_winbind.c:932
 #, fuzzy, c-format
 msgid Your password will expire in %d %s.\n
-msgstr VaÅ¡e heslo vyprÅ¡Ã %d %s
+msgstr VaÅ¡e heslo vyprÅ¡Ã %d %s\n
 
 #: ../../../nsswitch/pam_winbind.c:933
 msgid days
diff --git a/source3/locale/pam_winbind/da.po b/source3/locale/pam_winbind/da.po
index df2d484..79ff743 100644
--- a/source3/locale/pam_winbind/da.po
+++ b/source3/locale/pam_winbind/da.po
@@ -85,12 +85,12 @@ msgstr Du skal Ã¦ndre din adgangskode nu
 #: ../../../nsswitch/pam_winbind.c:902
 #, fuzzy
 msgid Your password expires today.\n
-msgstr Din adgangskode udlÃ¸ber i dag
+msgstr Din adgangskode udlÃ¸ber i dag.\n
 
 #: ../../../nsswitch/pam_winbind.c:932
 #, fuzzy, c-format
 msgid Your password will expire in %d %s.\n
-msgstr Din adgangskode udlÃ¸ber om %d %s
+msgstr Din adgangskode udlÃ¸ber om %d %s.\n
 
 #: ../../../nsswitch/pam_winbind.c:933
 msgid days
diff --git a/source3/locale/pam_winbind/de.po b/source3/locale/pam_winbind/de.po
index af46ef3..8861c8f 100644
--- a/source3/locale/pam_winbind/de.po
+++ b/source3/locale/pam_winbind/de.po
@@ -87,12 +87,12 @@ msgstr Sie mÃ¼ssen Ihr Passwort jetzt Ã¤ndern
 #: ../../../nsswitch/pam_winbind.c:902
 #, fuzzy
 msgid Your password expires today.\n
-msgstr Ihr Passwort lÃ¤uft heute ab
+msgstr Ihr Passwort lÃ¤uft heute ab.\n
 
 #: ../../../nsswitch/pam_winbind.c:932
 #, fuzzy, c-format
 msgid Your password will expire in %d %s.\n
-msgstr Ihr Passwort wird in %d %s ungÃ¼ltig
+msgstr Ihr Passwort wird in %d %s ungÃ¼ltig.\n
 
 #: ../../../nsswitch/pam_winbind.c:933
 msgid days
diff --git a/source3/locale/pam_winbind/es.po b/source3/locale/pam_winbind/es.po
index e0d4147..e139a40 100644
--- a/source3/locale/pam_winbind/es.po
+++ b/source3/locale/pam_winbind/es.po
@@ -85,12 +85,12 @@ msgstr Debe cambiar su contraseÃ±a ahora
 #: ../../../nsswitch/pam_winbind.c:902
 #, fuzzy
 msgid Your password expires today.\n
-msgstr La contraseÃ±a caduca hoy
+msgstr La contraseÃ±a caduca hoy.\n
 
 #: ../../../nsswitch/pam_winbind.c:932
 #, fuzzy, c-format
 msgid Your password will expire in %d %s.\n
-msgstr La contraseÃ±a caducarÃ¡ en %d %s
+msgstr La contraseÃ±a caducarÃ¡ en %d %s.\n
 
 #: ../../../nsswitch/pam_winbind.c:933
 msgid days
diff --git a/source3/locale/pam_winbind/fi.po b/source3/locale/pam_winbind/fi.po
index 984cadc..22f2820 100644
--- a/source3/locale/pam_winbind/fi.po
+++ b/source3/locale/pam_winbind/fi.po
@@ -88,12 +88,12 @@ msgstr Salasana tÃ¤ytyy vaihtaa nyt
 #:

[SCM] Samba Shared Repository - branch master updated

2010-04-19 Thread Kai Blin

The branch, master has been updated
   via  8208f8e... s3 i18n: Fix up missing newlines in more pam_winbind 
translations
  from  e56dc83... s3 i18n: Fix up missing newlines in pam_winbind 
translations

http://gitweb.samba.org/?p=samba.git;a=shortlog;h=master


- Log -
commit 8208f8e5e53f59866949b6169bc107f8f17e7a0e
Author: Kai Blin kai.b...@biotech.uni-tuebingen.de
Date:   Mon Apr 19 09:27:50 2010 +0200

s3 i18n: Fix up missing newlines in more pam_winbind translations

---

Summary of changes:
 source3/locale/pam_winbind/ko.po|4 ++--
 source3/locale/pam_winbind/nb.po|4 ++--
 source3/locale/pam_winbind/nl.po|4 ++--
 source3/locale/pam_winbind/pl.po|4 ++--
 source3/locale/pam_winbind/pt_BR.po |4 ++--
 source3/locale/pam_winbind/ru.po|4 ++--
 source3/locale/pam_winbind/sv.po|4 ++--
 source3/locale/pam_winbind/zh_CN.po |4 ++--
 source3/locale/pam_winbind/zh_TW.po |4 ++--
 9 files changed, 18 insertions(+), 18 deletions(-)


Changeset truncated at 500 lines:

diff --git a/source3/locale/pam_winbind/ko.po b/source3/locale/pam_winbind/ko.po
index bd169f9..733d408 100644
--- a/source3/locale/pam_winbind/ko.po
+++ b/source3/locale/pam_winbind/ko.po
@@ -85,12 +85,12 @@ msgstr ì§ê¸ ë¹ë°ë²í¸ë¥¼ ë³ê²½í´ì¼ í©ëë¤.
 #: ../../../nsswitch/pam_winbind.c:902
 #, fuzzy
 msgid Your password expires today.\n
-msgstr ì¤ë ë¹ë°ë²í¸ê° ë§ë£ë©ëë¤.
+msgstr ì¤ë ë¹ë°ë²í¸ê° ë§ë£ë©ëë¤.\n
 
 #: ../../../nsswitch/pam_winbind.c:932
 #, fuzzy, c-format
 msgid Your password will expire in %d %s.\n
-msgstr ë¹ë°ë²í¸ê° %d %sì¼ íì ë§ë£ë©ëë¤.
+msgstr ë¹ë°ë²í¸ê° %d %sì¼ íì ë§ë£ë©ëë¤.\n
 
 #: ../../../nsswitch/pam_winbind.c:933
 msgid days
diff --git a/source3/locale/pam_winbind/nb.po b/source3/locale/pam_winbind/nb.po
index 3e505d4..9559699 100644
--- a/source3/locale/pam_winbind/nb.po
+++ b/source3/locale/pam_winbind/nb.po
@@ -90,12 +90,12 @@ msgstr Du mÃ¥ endre passordet nÃ¥
 #: ../../../nsswitch/pam_winbind.c:902
 #, fuzzy
 msgid Your password expires today.\n
-msgstr Passordet utlÃ¸per i dag
+msgstr Passordet utlÃ¸per i dag.\n
 
 #: ../../../nsswitch/pam_winbind.c:932
 #, fuzzy, c-format
 msgid Your password will expire in %d %s.\n
-msgstr Passordet vil utlÃ¸pe om %d %s
+msgstr Passordet vil utlÃ¸pe om %d %s.\n
 
 #: ../../../nsswitch/pam_winbind.c:933
 msgid days
diff --git a/source3/locale/pam_winbind/nl.po b/source3/locale/pam_winbind/nl.po
index e7f1157..f0cbfda 100644
--- a/source3/locale/pam_winbind/nl.po
+++ b/source3/locale/pam_winbind/nl.po
@@ -85,12 +85,12 @@ msgstr U moet uw wachtwoord nu wijzigen
 #: ../../../nsswitch/pam_winbind.c:902
 #, fuzzy
 msgid Your password expires today.\n
-msgstr Uw wachtwoord verloopt vandaag
+msgstr Uw wachtwoord verloopt vandaag.\n
 
 #: ../../../nsswitch/pam_winbind.c:932
 #, fuzzy, c-format
 msgid Your password will expire in %d %s.\n
-msgstr Uw wachtwoord verloopt over %d %s
+msgstr Uw wachtwoord verloopt over %d %s.\n
 
 #: ../../../nsswitch/pam_winbind.c:933
 msgid days
diff --git a/source3/locale/pam_winbind/pl.po b/source3/locale/pam_winbind/pl.po
index 0f1dbf6..05d069d 100644
--- a/source3/locale/pam_winbind/pl.po
+++ b/source3/locale/pam_winbind/pl.po
@@ -85,12 +85,12 @@ msgstr Zmiana hasÅa jest wymagana w tej chwili
 #: ../../../nsswitch/pam_winbind.c:902
 #, fuzzy
 msgid Your password expires today.\n
-msgstr HasÅo uÅ¼ytkownika wygasa dzisiaj
+msgstr HasÅo uÅ¼ytkownika wygasa dzisiaj.\n
 
 #: ../../../nsswitch/pam_winbind.c:932
 #, fuzzy, c-format
 msgid Your password will expire in %d %s.\n
-msgstr HasÅo uÅ¼ytkownika wygaÅnie za %d %s.
+msgstr HasÅo uÅ¼ytkownika wygaÅnie za %d %s.\n
 
 #: ../../../nsswitch/pam_winbind.c:933
 msgid days
diff --git a/source3/locale/pam_winbind/pt_BR.po 
b/source3/locale/pam_winbind/pt_BR.po
index 418cc80..6736a22 100644
--- a/source3/locale/pam_winbind/pt_BR.po
+++ b/source3/locale/pam_winbind/pt_BR.po
@@ -85,12 +85,12 @@ msgstr VocÃª precisa alterar sua senha agora
 #: ../../../nsswitch/pam_winbind.c:902
 #, fuzzy
 msgid Your password expires today.\n
-msgstr Sua senha expira hoje
+msgstr Sua senha expira hoje.\n
 
 #: ../../../nsswitch/pam_winbind.c:932
 #, fuzzy, c-format
 msgid Your password will expire in %d %s.\n
-msgstr Sua senha expirarÃ¡ em %d %s.
+msgstr Sua senha expirarÃ¡ em %d %s.\n
 
 #: ../../../nsswitch/pam_winbind.c:933
 msgid days
diff --git a/source3/locale/pam_winbind/ru.po b/source3/locale/pam_winbind/ru.po
index 81078ec..082dcd8 100644
--- a/source3/locale/pam_winbind/ru.po
+++ b/source3/locale/pam_winbind/ru.po
@@ -85,12 +85,12 @@ msgstr ÐÐ°Ð¼ Ð½ÐµÐ¾Ð±ÑÐ¾Ð´Ð¸Ð¼Ð¾ Ð¸Ð·Ð¼ÐµÐ½Ð¸ÑÑ ÐÐ°Ñ 
Ð¿Ð°ÑÐ¾Ð»Ñ ÑÐµÐ¹
 #: ../../../nsswitch/pam_winbind.c:902
 #, fuzzy
 msgid Your password expires today.\n
-msgstr Ð¡ÑÐ¾Ðº Ð´ÐµÐ¹ÑÑÐ²Ð¸Ñ ÐÐ°ÑÐµÐ³Ð¾ Ð¿Ð°ÑÐ¾Ð»Ñ

[SCM] Samba Shared Repository - branch master updated

2010-04-19 Thread Andrew Tridgell

The branch, master has been updated
   via  fdf4d3e... s4-waf: fixed WINBINDD_SOCKET_DIR for wb_common in s4
   via  540d197... s4-test: we don't need -s set for samba_dnsupdate
   via  43ca57d... s4-dns: use neater python for reading lines
   via  162e7bc... s4-param: set SMB_CONF_PATH when we load a smb.conf
   via  dcf35ab... runcmd: use tevent_re_initialise() to close sockets
  from  8208f8e... s3 i18n: Fix up missing newlines in more pam_winbind 
translations

http://gitweb.samba.org/?p=samba.git;a=shortlog;h=master


- Log -
commit fdf4d3eed3e1c461f4b8b67f2a563a86aecc
Author: Andrew Tridgell tri...@samba.org
Date:   Mon Apr 19 18:00:47 2010 +1000

s4-waf: fixed WINBINDD_SOCKET_DIR for wb_common in s4

s4 uses a different path for the socket

commit 540d197e499f1ab6fb27127c18fc9e4fe913393f
Author: Andrew Tridgell tri...@samba.org
Date:   Mon Apr 19 17:18:53 2010 +1000

s4-test: we don't need -s set for samba_dnsupdate

this is now handled by SMB_CONF_PATH

Pair-Programmed-With: Andrew Bartlett abart...@samba.org

commit 43ca57d0887495fdbf2e8dd8c7afb9d521f220f3
Author: Andrew Tridgell tri...@samba.org
Date:   Mon Apr 19 17:18:20 2010 +1000

s4-dns: use neater python for reading lines

files are line iterators

commit 162e7bc5b4679ab9be66730ea6b36ed3d25f0643
Author: Andrew Tridgell tri...@samba.org
Date:   Mon Apr 19 17:17:07 2010 +1000

s4-param: set SMB_CONF_PATH when we load a smb.conf

this is inherited by child python processes, to ensure they get the
right smb.conf if they don't have one specified. Fixes bug 7301

Pair-Programmed-With: Andrew Bartlett abart...@samba.org

commit dcf35ab487f9213d4424493257903971ebe3ebbf
Author: Andrew Tridgell tri...@samba.org
Date:   Mon Apr 19 17:14:33 2010 +1000

runcmd: use tevent_re_initialise() to close sockets

this ensures that all event fds are closed in the child

---

Summary of changes:
 lib/util/util_runcmd.c|4 
 nsswitch/wscript_build|2 +-
 selftest/target/Samba4.pm |2 +-
 source4/param/loadparm.c  |6 ++
 source4/scripting/bin/samba_dnsupdate |9 ++---
 5 files changed, 14 insertions(+), 9 deletions(-)


Changeset truncated at 500 lines:

diff --git a/lib/util/util_runcmd.c b/lib/util/util_runcmd.c
index 54643d3..d81a0ac 100644
--- a/lib/util/util_runcmd.c
+++ b/lib/util/util_runcmd.c
@@ -160,6 +160,10 @@ struct tevent_req *samba_runcmd_send(TALLOC_CTX *mem_ctx,
close(1);
close(2);
 
+   /* we want to ensure that all of the network sockets we had
+  open are closed */
+   tevent_re_initialise(ev);
+
/* setup for logging to go to the parents debug log */
open(/dev/null, O_RDONLY); /* for stdin */
dup2(p1[1], 1);
diff --git a/nsswitch/wscript_build b/nsswitch/wscript_build
index e13b4dc..80f1187 100644
--- a/nsswitch/wscript_build
+++ b/nsswitch/wscript_build
@@ -3,7 +3,7 @@
 bld.SAMBA_SUBSYSTEM('LIBWINBIND-CLIENT',
 source='wb_common.c',
 deps='replace',
-cflags='-DSOCKET_WRAPPER_DISABLE=1'
+cflags='-DSOCKET_WRAPPER_DISABLE=1 
-DWINBINDD_SOCKET_DIR=\%s\' % bld.env.WINBINDD_SOCKET_DIR
 )
 
 
diff --git a/selftest/target/Samba4.pm b/selftest/target/Samba4.pm
index 06a5326..4d6bca9 100644
--- a/selftest/target/Samba4.pm
+++ b/selftest/target/Samba4.pm
@@ -585,7 +585,7 @@ sub provision_raw_step1($$)
log level = $ctx-{server_loglevel}
lanman auth = Yes
rndc command = true
-dns update command = $ENV{SRCDIR_ABS}/scripting/bin/samba_dnsupdate -s 
$ctx-{smb_conf} --all-interfaces --use-file=$ctx-{dns_host_file}
+dns update command = $ENV{SRCDIR_ABS}/scripting/bin/samba_dnsupdate 
--all-interfaces --use-file=$ctx-{dns_host_file}
 resolv:host file = $ctx-{dns_host_file}
 ;
 
diff --git a/source4/param/loadparm.c b/source4/param/loadparm.c
index 2bee0fb..b7dcd9b 100644
--- a/source4/param/loadparm.c
+++ b/source4/param/loadparm.c
@@ -2571,6 +2571,12 @@ bool lp_load(struct loadparm_context *lp_ctx, const char 
*filename)
   for a missing smb.conf */
reload_charcnv(lp_ctx);
 
+   if (bRetval == true) {
+   /* set this up so that any child python tasks will
+  find the right smb.conf */
+   setenv(SMB_CONF_PATH, filename, 1);
+   }
+
return bRetval;
 }
 
diff --git a/source4/scripting/bin/samba_dnsupdate 
b/source4/scripting/bin/samba_dnsupdate
index cebfae2..3fe55e2 100755
--- a/source4/scripting/bin/samba_dnsupdate
+++ b/source4/scripting/bin/samba_dnsupdate
@@ -148,15 +148,12 @@ def check_dns_name(d):
 except IOError:
 return False
 
-

[SCM] Samba Shared Repository - branch master updated

2010-04-19 Thread Günther Deschner

The branch, master has been updated
   via  0277143... s3: re-run make samba3-idl.
   via  5b3c22e... spoolss: make spoolss_SetPrinterInfo0 match changes in 
spoolss_PrinterInfo0.
  from  fdf4d3e... s4-waf: fixed WINBINDD_SOCKET_DIR for wb_common in s4

http://gitweb.samba.org/?p=samba.git;a=shortlog;h=master


- Log -
commit 0277143ca6224e4219d6b95746c02c8ca9a6abf6
Author: GÃ¼nther Deschner g...@samba.org
Date:   Tue Apr 13 23:51:36 2010 +0200

s3: re-run make samba3-idl.

Guenther

commit 5b3c22e96fdc54cb60ac6f4d5e9a76a83fe477af
Author: GÃ¼nther Deschner g...@samba.org
Date:   Tue Apr 13 23:50:58 2010 +0200

spoolss: make spoolss_SetPrinterInfo0 match changes in spoolss_PrinterInfo0.

Guenther

---

Summary of changes:
 librpc/gen_ndr/ndr_spoolss.c |   18 +-
 librpc/gen_ndr/spoolss.h |2 +-
 librpc/idl/spoolss.idl   |6 +++---
 3 files changed, 13 insertions(+), 13 deletions(-)


Changeset truncated at 500 lines:

diff --git a/librpc/gen_ndr/ndr_spoolss.c b/librpc/gen_ndr/ndr_spoolss.c
index 8868ec0..a2355b7 100644
--- a/librpc/gen_ndr/ndr_spoolss.c
+++ b/librpc/gen_ndr/ndr_spoolss.c
@@ -331,7 +331,7 @@ _PUBLIC_ enum ndr_err_code 
ndr_push_spoolss_PrinterInfo0(struct ndr_push *ndr, i
NDR_CHECK(ndr_push_uint32(ndr, NDR_SCALARS, r-global_counter));
NDR_CHECK(ndr_push_uint32(ndr, NDR_SCALARS, r-total_pages));
NDR_CHECK(ndr_push_uint32(ndr, NDR_SCALARS, r-version));
-   NDR_CHECK(ndr_push_uint32(ndr, NDR_SCALARS, r-free_build));
+   NDR_CHECK(ndr_push_spoolss_Build(ndr, NDR_SCALARS, 
r-free_build));
NDR_CHECK(ndr_push_uint32(ndr, NDR_SCALARS, r-spooling));
NDR_CHECK(ndr_push_uint32(ndr, NDR_SCALARS, r-max_spooling));
NDR_CHECK(ndr_push_uint32(ndr, NDR_SCALARS, 
r-session_counter));
@@ -417,7 +417,7 @@ _PUBLIC_ enum ndr_err_code 
ndr_pull_spoolss_PrinterInfo0(struct ndr_pull *ndr, i
NDR_CHECK(ndr_pull_uint32(ndr, NDR_SCALARS, 
r-global_counter));
NDR_CHECK(ndr_pull_uint32(ndr, NDR_SCALARS, r-total_pages));
NDR_CHECK(ndr_pull_uint32(ndr, NDR_SCALARS, r-version));
-   NDR_CHECK(ndr_pull_uint32(ndr, NDR_SCALARS, r-free_build));
+   NDR_CHECK(ndr_pull_spoolss_Build(ndr, NDR_SCALARS, 
r-free_build));
NDR_CHECK(ndr_pull_uint32(ndr, NDR_SCALARS, r-spooling));
NDR_CHECK(ndr_pull_uint32(ndr, NDR_SCALARS, r-max_spooling));
NDR_CHECK(ndr_pull_uint32(ndr, NDR_SCALARS, 
r-session_counter));
@@ -503,7 +503,7 @@ _PUBLIC_ void ndr_print_spoolss_PrinterInfo0(struct 
ndr_print *ndr, const char *
ndr_print_uint32(ndr, global_counter, r-global_counter);
ndr_print_uint32(ndr, total_pages, r-total_pages);
ndr_print_uint32(ndr, version, r-version);
-   ndr_print_uint32(ndr, free_build, r-free_build);
+   ndr_print_spoolss_Build(ndr, free_build, r-free_build);
ndr_print_uint32(ndr, spooling, r-spooling);
ndr_print_uint32(ndr, max_spooling, r-max_spooling);
ndr_print_uint32(ndr, session_counter, r-session_counter);
@@ -6854,13 +6854,13 @@ static enum ndr_err_code 
ndr_push_spoolss_SetPrinterInfo0(struct ndr_push *ndr,
NDR_CHECK(ndr_push_uint32(ndr, NDR_SCALARS, 
r-session_counter));
NDR_CHECK(ndr_push_uint32(ndr, NDR_SCALARS, 
r-num_error_out_of_paper));
NDR_CHECK(ndr_push_uint32(ndr, NDR_SCALARS, 
r-num_error_not_ready));
-   NDR_CHECK(ndr_push_uint32(ndr, NDR_SCALARS, r-job_error));
+   NDR_CHECK(ndr_push_spoolss_JobStatus(ndr, NDR_SCALARS, 
r-job_error));
NDR_CHECK(ndr_push_uint32(ndr, NDR_SCALARS, 
r-number_of_processors));
NDR_CHECK(ndr_push_spoolss_ProcessorType(ndr, NDR_SCALARS, 
r-processor_type));
NDR_CHECK(ndr_push_uint32(ndr, NDR_SCALARS, 
r-high_part_total_bytes));
NDR_CHECK(ndr_push_uint32(ndr, NDR_SCALARS, r-change_id));
NDR_CHECK(ndr_push_WERROR(ndr, NDR_SCALARS, r-last_error));
-   NDR_CHECK(ndr_push_uint32(ndr, NDR_SCALARS, r-status));
+   NDR_CHECK(ndr_push_spoolss_PrinterStatus(ndr, NDR_SCALARS, 
r-status));
NDR_CHECK(ndr_push_uint32(ndr, NDR_SCALARS, 
r-enumerate_network_printers));
NDR_CHECK(ndr_push_uint32(ndr, NDR_SCALARS, r-c_setprinter));
NDR_CHECK(ndr_push_spoolss_ProcessorArchitecture(ndr, 
NDR_SCALARS, r-processor_architecture));
@@ -6920,13 +6920,13 @@ static enum ndr_err_code 
ndr_pull_spoolss_SetPrinterInfo0(struct ndr_pull *ndr,
NDR_CHECK(ndr_pull_uint32(ndr, NDR_SCALARS, 
r-session_counter));
NDR_CHECK(ndr_pull_uint32(ndr, NDR_SCALARS, 
r-num_error_out_of_paper));

[SCM] Samba Shared Repository - branch master updated

2010-04-19 Thread Günther Deschner

The branch, master has been updated
   via  0b2e5de... s3-smb2: fix some c++ warnings.
   via  7b84d36... s3-spoolss: fix samr_ValidatePassword_Change.
   via  7277668... spoolss: move up enum spoolss_Build in the IDL.
   via  2033314... s3-lanman: use spoolss for api_WPrintJobGetInfo().
   via  0c80d12... s3-lanman: use spoolss for api_WPrintJobEnumerate().
  from  0277143... s3: re-run make samba3-idl.

http://gitweb.samba.org/?p=samba.git;a=shortlog;h=master


- Log -
commit 0b2e5debb004ed586e0ec7d926311c32a8b8f9e6
Author: GÃ¼nther Deschner g...@samba.org
Date:   Mon Apr 19 11:53:11 2010 +0200

s3-smb2: fix some c++ warnings.

Guenther

commit 7b84d36f19a29e33735bde08151e540d4c2b86b1
Author: GÃ¼nther Deschner g...@samba.org
Date:   Mon Apr 19 11:46:03 2010 +0200

s3-spoolss: fix samr_ValidatePassword_Change.

Guenther

commit 7277668128e3a8c138e9dc48ce6c2e85d1aac34f
Author: GÃ¼nther Deschner g...@samba.org
Date:   Mon Apr 19 11:45:33 2010 +0200

spoolss: move up enum spoolss_Build in the IDL.

Guenther

commit 2033314a7ca731e9cea76cb3296c3dc85660ae30
Author: GÃ¼nther Deschner g...@samba.org
Date:   Sat Apr 10 01:44:08 2010 +0200

s3-lanman: use spoolss for api_WPrintJobGetInfo().

Guenther

commit 0c80d12656267c4e932f8e22750e827d53997f07
Author: GÃ¼nther Deschner g...@samba.org
Date:   Sat Apr 10 01:33:37 2010 +0200

s3-lanman: use spoolss for api_WPrintJobEnumerate().

Guenther

---

Summary of changes:
 librpc/gen_ndr/ndr_spoolss.c |   50 
 librpc/gen_ndr/ndr_spoolss.h |2 +-
 librpc/gen_ndr/spoolss.h |   26 ++--
 librpc/idl/spoolss.idl   |   10 +-
 source3/rpc_server/srv_samr_nt.c |2 +-
 source3/smbd/lanman.c|  228 --
 source3/smbd/smb2_server.c   |6 +-
 7 files changed, 244 insertions(+), 80 deletions(-)


Changeset truncated at 500 lines:

diff --git a/librpc/gen_ndr/ndr_spoolss.c b/librpc/gen_ndr/ndr_spoolss.c
index a2355b7..552f894 100644
--- a/librpc/gen_ndr/ndr_spoolss.c
+++ b/librpc/gen_ndr/ndr_spoolss.c
@@ -308,6 +308,31 @@ _PUBLIC_ void ndr_print_spoolss_JobStatus(struct ndr_print 
*ndr, const char *nam
ndr-depth--;
 }
 
+static enum ndr_err_code ndr_push_spoolss_Build(struct ndr_push *ndr, int 
ndr_flags, enum spoolss_Build r)
+{
+   NDR_CHECK(ndr_push_enum_uint32(ndr, NDR_SCALARS, r));
+   return NDR_ERR_SUCCESS;
+}
+
+static enum ndr_err_code ndr_pull_spoolss_Build(struct ndr_pull *ndr, int 
ndr_flags, enum spoolss_Build *r)
+{
+   uint32_t v;
+   NDR_CHECK(ndr_pull_enum_uint32(ndr, NDR_SCALARS, v));
+   *r = v;
+   return NDR_ERR_SUCCESS;
+}
+
+_PUBLIC_ void ndr_print_spoolss_Build(struct ndr_print *ndr, const char *name, 
enum spoolss_Build r)
+{
+   const char *val = NULL;
+
+   switch (r) {
+   case SPOOLSS_DEBUGGING_BUILD: val = SPOOLSS_DEBUGGING_BUILD; 
break;
+   case SPOOLSS_RELEASE_BUILD: val = SPOOLSS_RELEASE_BUILD; 
break;
+   }
+   ndr_print_enum(ndr, name, ENUM, val, r);
+}
+
 _PUBLIC_ enum ndr_err_code ndr_push_spoolss_PrinterInfo0(struct ndr_push *ndr, 
int ndr_flags, const struct spoolss_PrinterInfo0 *r)
 {
if (ndr_flags  NDR_SCALARS) {
@@ -6810,31 +6835,6 @@ _PUBLIC_ void ndr_print_spoolss_PrinterControl(struct 
ndr_print *ndr, const char
ndr_print_enum(ndr, name, ENUM, val, r);
 }
 
-static enum ndr_err_code ndr_push_spoolss_Build(struct ndr_push *ndr, int 
ndr_flags, enum spoolss_Build r)
-{
-   NDR_CHECK(ndr_push_enum_uint32(ndr, NDR_SCALARS, r));
-   return NDR_ERR_SUCCESS;
-}
-
-static enum ndr_err_code ndr_pull_spoolss_Build(struct ndr_pull *ndr, int 
ndr_flags, enum spoolss_Build *r)
-{
-   uint32_t v;
-   NDR_CHECK(ndr_pull_enum_uint32(ndr, NDR_SCALARS, v));
-   *r = v;
-   return NDR_ERR_SUCCESS;
-}
-
-_PUBLIC_ void ndr_print_spoolss_Build(struct ndr_print *ndr, const char *name, 
enum spoolss_Build r)
-{
-   const char *val = NULL;
-
-   switch (r) {
-   case SPOOLSS_DEBUGGING_BUILD: val = SPOOLSS_DEBUGGING_BUILD; 
break;
-   case SPOOLSS_RELEASE_BUILD: val = SPOOLSS_RELEASE_BUILD; 
break;
-   }
-   ndr_print_enum(ndr, name, ENUM, val, r);
-}
-
 static enum ndr_err_code ndr_push_spoolss_SetPrinterInfo0(struct ndr_push 
*ndr, int ndr_flags, const struct spoolss_SetPrinterInfo0 *r)
 {
if (ndr_flags  NDR_SCALARS) {
diff --git a/librpc/gen_ndr/ndr_spoolss.h b/librpc/gen_ndr/ndr_spoolss.h
index 2ae3466..2f4411e 100644
--- a/librpc/gen_ndr/ndr_spoolss.h
+++ b/librpc/gen_ndr/ndr_spoolss.h
@@ -243,6 +243,7 @@ enum ndr_err_code ndr_push_spoolss_PrinterStatus(struct 
ndr_push *ndr, int ndr_f
 enum ndr_err_code ndr_pull_spoolss_PrinterStatus(struct ndr_pull *ndr, int 
ndr_flags, uint32_t *r);
 void

[SCM] Samba Shared Repository - branch master updated

2010-04-19 Thread Andrew Tridgell

The branch, master has been updated
   via  d25e1e1... build: update waf from svn
   via  db0eb2f... s4-waf: install some missing empty directories
   via  d2b35c3... build: make compare_install.sh also check for missing 
directories
  from  0b2e5de... s3-smb2: fix some c++ warnings.

http://gitweb.samba.org/?p=samba.git;a=shortlog;h=master


- Log -
commit d25e1e15d387d24fe045fbb162de57963c7b15a6
Author: Andrew Tridgell tri...@samba.org
Date:   Mon Apr 19 21:00:51 2010 +1000

build: update waf from svn

this adds bld.install_dir()

commit db0eb2f239c9bbd3aeff06eee31102830eb42f11
Author: Andrew Tridgell tri...@samba.org
Date:   Mon Apr 19 21:00:36 2010 +1000

s4-waf: install some missing empty directories

commit d2b35c3a24b9bae88b996f8bc70e6a6012fd16f5
Author: Andrew Tridgell tri...@samba.org
Date:   Mon Apr 19 21:00:16 2010 +1000

build: make compare_install.sh also check for missing directories

Thanks to Nadya for pointing this out

---

Summary of changes:
 buildtools/bin/waf-svn  |  Bin 107202 - 107837 bytes
 buildtools/compare_install.sh   |4 ++--
 buildtools/wafsamba/wafsamba.py |7 +++
 source4/wscript_build   |3 +++
 4 files changed, 12 insertions(+), 2 deletions(-)


Changeset truncated at 500 lines:

diff --git a/buildtools/bin/waf-svn b/buildtools/bin/waf-svn
index 3c707e9..774fb71 100755
Binary files a/buildtools/bin/waf-svn and b/buildtools/bin/waf-svn differ
diff --git a/buildtools/compare_install.sh b/buildtools/compare_install.sh
index c3a1c23..5ddbffb 100755
--- a/buildtools/compare_install.sh
+++ b/buildtools/compare_install.sh
@@ -3,6 +3,6 @@
 prefix1=$1
 prefix2=$2
 
-(cd $prefix1  find . -type f) | sort  p1.txt
-(cd $prefix2  find . -type f) | sort  p2.txt
+(cd $prefix1  find . ) | sort  p1.txt
+(cd $prefix2  find . ) | sort  p2.txt
 diff -u p[12].txt
diff --git a/buildtools/wafsamba/wafsamba.py b/buildtools/wafsamba/wafsamba.py
index a750a16..c3dd32c 100644
--- a/buildtools/wafsamba/wafsamba.py
+++ b/buildtools/wafsamba/wafsamba.py
@@ -598,6 +598,13 @@ def INSTALL_WILDCARD(bld, destdir, pattern, chmod=O644, 
flat=False,
 Build.BuildContext.INSTALL_WILDCARD = INSTALL_WILDCARD
 
 
+def INSTALL_DIRS(bld, destdir, dirs):
+'''install a set of directories'''
+for d in TO_LIST(dirs):
+bld.install_dir(os.path.join(destdir, d))
+Build.BuildContext.INSTALL_DIRS = INSTALL_DIRS
+
+
 def PUBLIC_HEADERS(bld, public_headers, header_path=None):
 '''install some headers
 
diff --git a/source4/wscript_build b/source4/wscript_build
index 0fbd059..788fdba 100644
--- a/source4/wscript_build
+++ b/source4/wscript_build
@@ -116,3 +116,6 @@ bld.RECURSE('setup')
 bld.RECURSE('scripting')
 bld.RECURSE('../pidl')
 bld.RECURSE('../lib')
+
+# install some extra empty directories
+bld.INSTALL_DIRS(${PREFIX}, etc var/lib var/locks var/run)


-- 
Samba Shared Repository

[SCM] Samba Shared Repository - branch master updated

2010-04-19 Thread Andrew Tridgell

The branch, master has been updated
   via  456351c... s4-waf: follow the configure directories for the empty 
install dirs
  from  d25e1e1... build: update waf from svn

http://gitweb.samba.org/?p=samba.git;a=shortlog;h=master


- Log -
commit 456351cdb184f59374cecec8d7c44add29b986dd
Author: Andrew Tridgell tri...@samba.org
Date:   Mon Apr 19 21:54:40 2010 +1000

s4-waf: follow the configure directories for the empty install dirs

Thanks to Metze for spotting this

---

Summary of changes:
 buildtools/wafsamba/wafsamba.py |2 ++
 source4/wscript_build   |2 +-
 2 files changed, 3 insertions(+), 1 deletions(-)


Changeset truncated at 500 lines:

diff --git a/buildtools/wafsamba/wafsamba.py b/buildtools/wafsamba/wafsamba.py
index c3dd32c..0f6a4fe 100644
--- a/buildtools/wafsamba/wafsamba.py
+++ b/buildtools/wafsamba/wafsamba.py
@@ -600,6 +600,8 @@ Build.BuildContext.INSTALL_WILDCARD = INSTALL_WILDCARD
 
 def INSTALL_DIRS(bld, destdir, dirs):
 '''install a set of directories'''
+destdir = bld.EXPAND_VARIABLES(destdir)
+dirs = bld.EXPAND_VARIABLES(dirs)
 for d in TO_LIST(dirs):
 bld.install_dir(os.path.join(destdir, d))
 Build.BuildContext.INSTALL_DIRS = INSTALL_DIRS
diff --git a/source4/wscript_build b/source4/wscript_build
index 788fdba..ff83f93 100644
--- a/source4/wscript_build
+++ b/source4/wscript_build
@@ -118,4 +118,4 @@ bld.RECURSE('../pidl')
 bld.RECURSE('../lib')
 
 # install some extra empty directories
-bld.INSTALL_DIRS(${PREFIX}, etc var/lib var/locks var/run)
+bld.INSTALL_DIRS(, ${LOCKDIR} ${SYSCONFDIR} ${LOCKDIR} ${PIDDIR} 
${LOCALSTATEDIR}/lib)


-- 
Samba Shared Repository

[SCM] Samba Shared Repository - branch master updated

2010-04-19 Thread Volker Lendecke

The branch, master has been updated
   via  56b4aa3... s3: Move the in-memory ccache to the parent
   via  c04ce96... nsswitch: Add wbinfo --pam-logon
   via  e0d7a84... s3: Test for wb ccache access by smbclient
   via  5aa8878... libwbclient: remove async libwbclient and talloc from 
libwbclient.so
   via  7697253... libwbclient does not need talloc_free anymore
   via  7072cc0... libwbclient: Make wbcListTrusts not use talloc
   via  d582caa... libwbclient: Make wbc_create_error_info not use talloc
   via  f4c8f51... libwbclient: Make wbcCredentialCache not use talloc
   via  802876a... libwbclient: Make wbcAuthenticateUserEx not use talloc
   via  406e55f... libwbclient: Make wbc_create_logon_info not use talloc
   via  d36829c... libwbclient: Make wbc_create_auth_info not use talloc
   via  1ecdff2... libwbclient: Make wbc_create_password_policy_info not 
use talloc
   via  ac8860d... libwbclient: Test wbcGetGroups
   via  fc2cca5... libwbclient: Make wbcGetGroups not use talloc
   via  f6a34cb... libwbclient: Make wbc_create_domain_controller_info_ex 
not use talloc
   via  d959fec... libwbclient: Make wbcLookupDomainController not use 
talloc
   via  df831df... libwbclient: Make wbcLookupUserSids not use talloc
   via  460e2d5... s3: Change the make test password to testPw
   via  3aaa07a... libwbclient: Test wbcChangeUserPassword
   via  496c459... libwbclient: Abstract out test_wbc_authenticate_user for 
reuse
   via  9d0629d... s3-winbind: Allow changing the password for pdb
   via  45eeed2... s3: Convert WINBINDD_PAM_LOGOFF to the new async API
   via  518a4f5... s3: Convert WINBINDD_PAM_CHAUTHTOK to the new async API
   via  d869e7a... s3: Convert WINBINDD_PAM_AUTH_CRAP to the new async API
   via  61ec0f5... s3: Convert WINBINDD_PAM_AUTH to the new async API
   via  fddef8f... libwbclient: Test wbcLogonUser
   via  8869480... libwbclient: Make wbcAddNamedBlob not use talloc
   via  8ebb999... libwbclient: Make wbcResolveWinsByIP not use talloc
   via  1637be5... libwbclient: Make wbcResolveWinsByName not use talloc
   via  f3e87ec... libwbclient: Make wbcDomainInfo not use talloc
   via  7f454c3... libwbclient: Make wbcInterfaceDetails not use talloc
   via  b62e57c... libwbclient: Test wbcAuthenticateUser[Ex]
   via  77c0b01... libwbclient: Make _SID_COMPOSE a function instead of a 
macro
   via  b828985... libwbclient: Make wbcGetDisplayName not use talloc
   via  ae3edf8... libwbclient: Test wbcGetDisplayName
   via  8f3ab43... libwbclient: Make wbcListGroups not use talloc
   via  1152cba... libwbclient: Make wbcListUsers not use talloc
   via  cafba3d... winbindd: Fill in num_entries where available
   via  e80d0ec... libwbclient: Make wbcGetSidAliases not use talloc
   via  fec712a... s3: Add some debug to GETSIDALIASES
   via  9e353a9... libwbclient: Test wbcGetSidAliases
   via  4f5100b... libwbclient: Simplify test_wbc_domain_info a bit
   via  679e7ef... libwbclient: Fix some pointless macro calls
   via  3d3b84b... libwbclient: Take -21 into account in length guessing
   via  d29a5e6... libwbclient: Fix some pointless macro calls
   via  4f88b70... libwbclient: Make wbcLookupRids not use talloc
   via  ab89238... libwbclient: Add wbcAllocateStringArray
   via  250bea0... libwbclient: Test wbcLookupRids
   via  0a96698... libwbclient: Make wbcLookupSid not use talloc
   via  a016230... libwbclient: Add wbcStrDup
   via  ed1981d... libwbclient: Convert wbcSidToString to not use talloc
   via  b75106b... libwbclient: Make copy_group_entry not use talloc
   via  041be88... libwbclient: Make copy_passwd_entry not use talloc
   via  20011f4... libwbclient: Make wbcGuidToString not use talloc
   via  7699977... libwbclient: Make wbcLibraryDetails not use talloc
   via  f2a04a0... libwbclient: Add wbcAllocateMemory()
  from  456351c... s4-waf: follow the configure directories for the empty 
install dirs

http://gitweb.samba.org/?p=samba.git;a=shortlog;h=master


- Log -
commit 56b4aa326626128c178c838977ef9e3d564b7bc7
Author: Volker Lendecke v...@samba.org
Date:   Sun Apr 18 14:14:43 2010 +0200

s3: Move the in-memory ccache to the parent

None of this blocks, so there is no reason to keep this in
a winbind child process

commit c04ce964e970b6f08fc768e93f5df2c5cbd09746
Author: Volker Lendecke v...@samba.org
Date:   Sun Apr 18 14:10:35 2010 +0200

nsswitch: Add wbinfo --pam-logon

This does a wbcLogonUser with credential caching

commit e0d7a8424264bb9a240409b67d4c363e154097dc
Author: Volker Lendecke v...@samba.org
Date:   Sat Apr 17 21:31:57 2010 +0200

s3: Test for wb ccache access by smbclient

commit 5aa88782ce0615a3d171682fbb13a182e586ec69
Author: Volker Lendecke

[SCM] Samba Shared Repository - branch master updated

2010-04-19 Thread Volker Lendecke

The branch, master has been updated
   via  c293359... s3: Remove a leftover of my lua experiments
  from  56b4aa3... s3: Move the in-memory ccache to the parent

http://gitweb.samba.org/?p=samba.git;a=shortlog;h=master


- Log -
commit c293359daf502543fb682fb0c925514c54dbdaf7
Author: Volker Lendecke v...@samba.org
Date:   Mon Apr 19 15:24:59 2010 +0200

s3: Remove a leftover of my lua experiments

---

Summary of changes:
 source3/exports/liblua.syms |5 -
 1 files changed, 0 insertions(+), 5 deletions(-)
 delete mode 100644 source3/exports/liblua.syms


Changeset truncated at 500 lines:

diff --git a/source3/exports/liblua.syms b/source3/exports/liblua.syms
deleted file mode 100644
index 8f598f1..000
--- a/source3/exports/liblua.syms
+++ /dev/null
@@ -1,5 +0,0 @@
-{
-   global: *;
-
-   local: *;
-};


-- 
Samba Shared Repository

[SCM] Samba Shared Repository - branch master updated

2010-04-19 Thread Stefan Metzmacher

The branch, master has been updated
   via  23fd764... s4:winbind: fill response.data.num_entries for 
WINBINDD_LIST_USERS
   via  629e73e... s4:winbind: fill response.data.num_entries for 
WINBINDD_LIST_GROUPS
   via  da17719... s4:winbind: fill response.data.num_entries for 
WINBINDD_LIST_TRUSTDOM
  from  c293359... s3: Remove a leftover of my lua experiments

http://gitweb.samba.org/?p=samba.git;a=shortlog;h=master


- Log -
commit 23fd76433ab3f1fe4462e39633bc55e26bf050fc
Author: Stefan Metzmacher me...@samba.org
Date:   Mon Apr 19 16:08:59 2010 +0200

s4:winbind: fill response.data.num_entries for WINBINDD_LIST_USERS

metze

commit 629e73eeedb2aea2bda016bbc5559a66e3a86b59
Author: Stefan Metzmacher me...@samba.org
Date:   Mon Apr 19 16:08:41 2010 +0200

s4:winbind: fill response.data.num_entries for WINBINDD_LIST_GROUPS

metze

commit da17719241b33f97ecb7e36104d7e8869f3e71e9
Author: Stefan Metzmacher me...@samba.org
Date:   Mon Apr 19 16:07:28 2010 +0200

s4:winbind: fill response.data.num_entries for WINBINDD_LIST_TRUSTDOM

metze

---

Summary of changes:
 source4/winbind/wb_cmd_list_groups.c |6 +-
 source4/winbind/wb_cmd_list_users.c  |6 +-
 source4/winbind/wb_samba3_cmd.c  |9 +++--
 3 files changed, 17 insertions(+), 4 deletions(-)


Changeset truncated at 500 lines:

diff --git a/source4/winbind/wb_cmd_list_groups.c 
b/source4/winbind/wb_cmd_list_groups.c
index afb96b4..746ce8f 100644
--- a/source4/winbind/wb_cmd_list_groups.c
+++ b/source4/winbind/wb_cmd_list_groups.c
@@ -32,6 +32,7 @@ struct cmd_list_groups_state {
char *domain_name;
uint32_t resume_index;
char *result;
+   uint32_t num_groups;
 };
 
 static void cmd_list_groups_recv_domain(struct composite_context *ctx);
@@ -55,6 +56,7 @@ struct composite_context *wb_cmd_list_groups_send(TALLOC_CTX 
*mem_ctx,
result-private_data = state;
state-service = service;
state-resume_index = 0;
+   state-num_groups = 0;
state-result = talloc_strdup(state, );
if (composite_nomem(state-result, state-ctx)) return result;
 
@@ -144,6 +146,7 @@ static void cmd_list_groups_recv_group_list(struct 
composite_context *ctx)
state-result = talloc_asprintf_append_buffer(state-result,
%s,,
group_list-out.groups[i].groupname);
+   state-num_groups++;
}
 
/* If the status is OK, we're finished, there's no more groups.
@@ -176,7 +179,7 @@ static void cmd_list_groups_recv_group_list(struct 
composite_context *ctx)
 
 NTSTATUS wb_cmd_list_groups_recv(struct composite_context *ctx,
TALLOC_CTX *mem_ctx, uint32_t *extra_data_len,
-   char **extra_data)
+   char **extra_data, uint32_t *num_groups)
 {
NTSTATUS status = composite_wait(ctx);
 
@@ -188,6 +191,7 @@ NTSTATUS wb_cmd_list_groups_recv(struct composite_context 
*ctx,
 
*extra_data_len = strlen(state-result);
*extra_data = talloc_steal(mem_ctx, state-result);
+   *num_groups = state-num_groups;
}
 
talloc_free(ctx);
diff --git a/source4/winbind/wb_cmd_list_users.c 
b/source4/winbind/wb_cmd_list_users.c
index ac44794..4728f3a 100644
--- a/source4/winbind/wb_cmd_list_users.c
+++ b/source4/winbind/wb_cmd_list_users.c
@@ -32,6 +32,7 @@ struct cmd_list_users_state {
char *domain_name;
uint32_t resume_index;
char *result;
+   uint32_t num_users;
 };
 
 static void cmd_list_users_recv_domain(struct composite_context *ctx);
@@ -55,6 +56,7 @@ struct composite_context *wb_cmd_list_users_send(TALLOC_CTX 
*mem_ctx,
result-private_data = state;
state-service = service;
state-resume_index = 0;
+   state-num_users = 0;
state-result = talloc_strdup(state, );
if (composite_nomem(state-result, state-ctx)) return result;
 
@@ -142,6 +144,7 @@ static void cmd_list_users_recv_user_list(struct 
composite_context *ctx)
DEBUG(5, (Appending user '%s'\n, 
user_list-out.users[i].username));
state-result = talloc_asprintf_append_buffer(state-result, 
%s,,
user_list-out.users[i].username);
+   state-num_users++;
}
 
/* If the status is OK, we're finished, there's no more users.
@@ -174,7 +177,7 @@ static void cmd_list_users_recv_user_list(struct 
composite_context *ctx)
 
 NTSTATUS wb_cmd_list_users_recv(struct composite_context *ctx,
TALLOC_CTX *mem_ctx, uint32_t *extra_data_len,
-   char **extra_data)
+   char **extra_data, uint32_t *num_users)
 {
NTSTATUS status = composite_wait(ctx);
 
@@ -186,6 +189,7 @@ NTSTATUS

[SCM] Samba Shared Repository - branch master updated

2010-04-19 Thread Volker Lendecke

The branch, master has been updated
   via  ba53707... libwbclient: wbcFreeMemory deals fine with a NULL pointer
   via  89bbc41... libwbclient: Fix wbcListGroups against too small 
num_entries
   via  6d898b4... libwbclient: Fix wbcListUsers against too small 
num_entries
  from  23fd764... s4:winbind: fill response.data.num_entries for 
WINBINDD_LIST_USERS

http://gitweb.samba.org/?p=samba.git;a=shortlog;h=master


- Log -
commit ba537079cff577237b7df50ab15fabb5b0086166
Author: Volker Lendecke v...@samba.org
Date:   Mon Apr 19 15:56:30 2010 +0200

libwbclient: wbcFreeMemory deals fine with a NULL pointer

commit 89bbc41d029e2327a9b9a3408c7552ce3e75e855
Author: Volker Lendecke v...@samba.org
Date:   Mon Apr 19 15:50:11 2010 +0200

libwbclient: Fix wbcListGroups against too small num_entries

Thanks for the s4 winbind sending 0 here and Tridge to point it out to me 
:-)

commit 6d898b45a381b3a93da4ac2c4e1af0487dd838ef
Author: Volker Lendecke v...@samba.org
Date:   Mon Apr 19 15:50:11 2010 +0200

libwbclient: Fix wbcListUsers against too small num_entries

Thanks for the s4 winbind sending 0 here and Tridge to point it out to me 
:-)

---

Summary of changes:
 nsswitch/libwbclient/wbc_sid.c |   38 +++---
 1 files changed, 23 insertions(+), 15 deletions(-)


Changeset truncated at 500 lines:

diff --git a/nsswitch/libwbclient/wbc_sid.c b/nsswitch/libwbclient/wbc_sid.c
index 2130077..73bd416 100644
--- a/nsswitch/libwbclient/wbc_sid.c
+++ b/nsswitch/libwbclient/wbc_sid.c
@@ -638,8 +638,17 @@ wbcErr wbcListUsers(const char *domain_name,
 
next = (const char *)response.extra_data.data;
while (next) {
-   const char *current = next;
-   char *k = strchr(next, ',');
+   const char *current;
+   char *k;
+
+   if (num_users = response.data.num_entries) {
+   wbc_status = WBC_ERR_INVALID_RESPONSE;
+   goto done;
+   }
+
+   current = next;
+   k = strchr(next, ',');
+
if (k) {
k[0] = '\0';
next = k+1;
@@ -650,10 +659,6 @@ wbcErr wbcListUsers(const char *domain_name,
users[num_users] = strdup(current);
BAIL_ON_PTR_ERROR(users[num_users], wbc_status);
num_users += 1;
-   if (num_users  response.data.num_entries) {
-   wbc_status = WBC_ERR_INVALID_RESPONSE;
-   goto done;
-   }
}
if (num_users != response.data.num_entries) {
wbc_status = WBC_ERR_INVALID_RESPONSE;
@@ -667,9 +672,7 @@ wbcErr wbcListUsers(const char *domain_name,
 
  done:
winbindd_free_response(response);
-   if (users) {
-   wbcFreeMemory(users);
-   }
+   wbcFreeMemory(users);
return wbc_status;
 }
 
@@ -709,8 +712,17 @@ wbcErr wbcListGroups(const char *domain_name,
 
next = (const char *)response.extra_data.data;
while (next) {
-   const char *current = next;
-   char *k = strchr(next, ',');
+   const char *current;
+   char *k;
+
+   if (num_groups = response.data.num_entries) {
+   wbc_status = WBC_ERR_INVALID_RESPONSE;
+   goto done;
+   }
+
+   current = next;
+   k = strchr(next, ',');
+
if (k) {
k[0] = '\0';
next = k+1;
@@ -721,10 +733,6 @@ wbcErr wbcListGroups(const char *domain_name,
groups[num_groups] = strdup(current);
BAIL_ON_PTR_ERROR(groups[num_groups], wbc_status);
num_groups += 1;
-   if (num_groups  response.data.num_entries) {
-   wbc_status = WBC_ERR_INVALID_RESPONSE;
-   goto done;
-   }
}
if (num_groups != response.data.num_entries) {
wbc_status = WBC_ERR_INVALID_RESPONSE;


-- 
Samba Shared Repository

Re: [SCM] Samba Shared Repository - branch master updated

2010-04-19 Thread Matthias Dieter Wallnöfer


Sorry Jelmer,

this wasn't clear (to prevent the use of TALLOC_FREE). But a real 
issue is the fact that we have already approximately 150-200 occourences 
of it under source4 (checked with cscope). And we merge more and 
more with the s3 codebase so we get more and more occourences. Therefore 
I would simply propose to allow it for s4 as well.


Greets,
Matthias

Jelmer Vernooij wrote:

Hi Matthias,

On Sat, 2010-04-17 at 13:12 -0500, Matthias Dieter Wallnöfer wrote:
   

- Log -
commit c678563efec82e84c9c86309cbf9495950a02b8c
Author: Matthias Dieter Wallnöfermwallnoe...@yahoo.de
Date:   Sat Apr 17 20:08:15 2010 +0200

 s4:kdc/db-glue.c - use TALLOC_FREE insteal of talloc_free for the 
priv context

 Also after a free priv could be != NULL and may be freed again.
 This should fix bug #7365.
 

We tend to avoid TALLOC_FREE in Samba 4, opting for explicitly setting
variable to NULL explicitly. This way valgrind will tell us about double
frees.

If you think we should consider using TALLOC_FREE, I think we should
discuss that first - for now, please use talloc_free() and assignments
to NULL.

Cheers,

Jelmer

Re: [SCM] Samba Shared Repository - branch master updated

2010-04-19 Thread Stefan (metze) Metzmacher

Matthias Dieter Wallnöfer schrieb:
 Sorry Jelmer,
 
 this wasn't clear (to prevent the use of TALLOC_FREE). But a real
 issue is the fact that we have already approximately 150-200 occourences
 of it under source4 (checked with cscope). And we merge more and
 more with the s3 codebase so we get more and more occourences. Therefore
 I would simply propose to allow it for s4 as well.

I think it's fine to use it also in source4.

metze



signature.asc
Description: OpenPGP digital signature

Re: [SCM] Samba Shared Repository - branch master updated

2010-04-19 Thread simo

On Mon, 2010-04-19 at 18:17 +0200, Stefan (metze) Metzmacher wrote:
 Matthias Dieter Wallnöfer schrieb:
  Sorry Jelmer,
  
  this wasn't clear (to prevent the use of TALLOC_FREE). But a real
  issue is the fact that we have already approximately 150-200 occourences
  of it under source4 (checked with cscope). And we merge more and
  more with the s3 codebase so we get more and more occourences. Therefore
  I would simply propose to allow it for s4 as well.
 
 I think it's fine to use it also in source4.

Looks fine to me too, trading a warning from valgrind with a segfault
for dereferencing a NULL pointer doesn't seem a big issue.
Actually a segfault has probably more chances to be dealt with earlier.

Simo.

-- 
Simo Sorce
Samba Team GPL Compliance Officer s...@samba.org
Principal Software Engineer at Red Hat, Inc. s...@redhat.com

[SCM] Samba Shared Repository - branch master updated

2010-04-19 Thread Jeremy Allison

The branch, master has been updated
   via  cea24c4... Remove an unused auto variable.
  from  ba53707... libwbclient: wbcFreeMemory deals fine with a NULL pointer

http://gitweb.samba.org/?p=samba.git;a=shortlog;h=master


- Log -
commit cea24c4620a782fec4a5e6da0892c9fa6d712d6a
Author: Jeremy Allison j...@samba.org
Date:   Mon Apr 19 11:38:49 2010 -0700

Remove an unused auto variable.

Jeremy.

---

Summary of changes:
 source3/smbd/smb2_server.c |3 ---
 1 files changed, 0 insertions(+), 3 deletions(-)


Changeset truncated at 500 lines:

diff --git a/source3/smbd/smb2_server.c b/source3/smbd/smb2_server.c
index 55111da..72c2dbd 100644
--- a/source3/smbd/smb2_server.c
+++ b/source3/smbd/smb2_server.c
@@ -1283,7 +1283,6 @@ NTSTATUS smbd_smb2_request_done_ex(struct 
smbd_smb2_request *req,
   const char *location)
 {
uint8_t *outhdr;
-   uint8_t *outdyn;
int i = req-current_idx;
uint32_t next_command_ofs;
 
@@ -1303,8 +1302,6 @@ NTSTATUS smbd_smb2_request_done_ex(struct 
smbd_smb2_request *req,
}
 
outhdr = (uint8_t *)req-out.vector[i].iov_base;
-   /* the fallback dynamic buffer */
-   outdyn = outhdr + SMB2_HDR_BODY + 8;
 
next_command_ofs = IVAL(outhdr, SMB2_HDR_NEXT_COMMAND);
SIVAL(outhdr, SMB2_HDR_STATUS, NT_STATUS_V(status));


-- 
Samba Shared Repository

[SCM] Samba Shared Repository - branch master updated

2010-04-19 Thread Nadezhda Ivanova

The branch, master has been updated
   via  4fc5908... Removed more excess looping and fixed problem with 
incorrect IO flag handling.
  from  cea24c4... Remove an unused auto variable.

http://gitweb.samba.org/?p=samba.git;a=shortlog;h=master


- Log -
commit 4fc59089c81b251b4fab17f170e96bd6dac02490
Author: Nadezhda Ivanova nivan...@samba.org
Date:   Tue Apr 20 00:23:42 2010 +0300

Removed more excess looping and fixed problem with incorrect IO flag 
handling.

---

Summary of changes:
 source4/lib/ldb/tests/python/sec_descriptor.py |   33 
 source4/libcli/security/create_descriptor.c|  207 +--
 2 files changed, 114 insertions(+), 126 deletions(-)


Changeset truncated at 500 lines:

diff --git a/source4/lib/ldb/tests/python/sec_descriptor.py 
b/source4/lib/ldb/tests/python/sec_descriptor.py
index 609fca8..f26df07 100755
--- a/source4/lib/ldb/tests/python/sec_descriptor.py
+++ b/source4/lib/ldb/tests/python/sec_descriptor.py
@@ -1725,6 +1725,39 @@ class DaclDescriptorTests(DescriptorTests):
 desc_sddl = self.get_desc_sddl(group_dn)
 self.assertTrue((D;;WP;;;DA)(D;CIIO;WP;;;CO) in desc_sddl)
 
+def test_212(self):
+ Provide ACE with IO flag, should be ignored
+
+ou_dn = OU=test_inherit_ou, + self.base_dn
+group_dn = CN=test_inherit_group, + ou_dn
+# Create inheritable-free OU
+self.create_clean_ou(ou_dn)
+# Add some custom 'CI' ACE
+mod = D:(D;CIIO;WP;;;CO)
+self.create_domain_group(self.ldb_admin, group_dn, mod)
+# Make sure created group object contains only the above inherited 
ACE(s)
+# that we've added manually
+desc_sddl = self.get_desc_sddl(group_dn)
+print desc_sddl
+self.assertTrue((D;CIIO;WP;;;CO) in desc_sddl)
+self.assertFalse((D;;WP;;;DA) in desc_sddl)
+self.assertFalse((D;CIIO;WP;;;CO)(D;CIIO;WP;;;CO) in desc_sddl)
+
+def test_213(self):
+ Provide ACE with IO flag, should be ignored
+
+ou_dn = OU=test_inherit_ou, + self.base_dn
+group_dn = CN=test_inherit_group, + ou_dn
+# Create inheritable-free OU
+self.create_clean_ou(ou_dn)
+mod = D:(D;IO;WP;;;DA)
+self.create_domain_group(self.ldb_admin, group_dn, mod)
+# Make sure created group object contains only the above inherited 
ACE(s)
+# that we've added manually
+desc_sddl = self.get_desc_sddl(group_dn)
+print desc_sddl
+self.assertFalse((D;IO;WP;;;DA) in desc_sddl)
+
 

 
 
diff --git a/source4/libcli/security/create_descriptor.c 
b/source4/libcli/security/create_descriptor.c
index f4849cf..d64de2f 100644
--- a/source4/libcli/security/create_descriptor.c
+++ b/source4/libcli/security/create_descriptor.c
@@ -53,22 +53,22 @@
 
 uint32_t map_generic_rights_ds(uint32_t access_mask)
 {
-   if (access_mask  SEC_GENERIC_ALL){
+   if (access_mask  SEC_GENERIC_ALL) {
access_mask |= SEC_ADS_GENERIC_ALL;
access_mask = ~SEC_GENERIC_ALL;
}
 
-   if (access_mask  SEC_GENERIC_EXECUTE){
+   if (access_mask  SEC_GENERIC_EXECUTE) {
access_mask |= SEC_ADS_GENERIC_EXECUTE;
access_mask = ~SEC_GENERIC_EXECUTE;
}
 
-   if (access_mask  SEC_GENERIC_WRITE){
+   if (access_mask  SEC_GENERIC_WRITE) {
access_mask |= SEC_ADS_GENERIC_WRITE;
access_mask = ~SEC_GENERIC_WRITE;
}
 
-   if (access_mask  SEC_GENERIC_READ){
+   if (access_mask  SEC_GENERIC_READ) {
access_mask |= SEC_ADS_GENERIC_READ;
access_mask = ~SEC_GENERIC_READ;
}
@@ -83,85 +83,20 @@ static bool object_in_list(struct GUID *object_list, struct 
GUID *object)
return true;
 }
 
- /* remove any ACEs with inherited flag up  - TODO test this! */
-static struct security_acl *clean_user_acl(TALLOC_CTX *mem, struct 
security_acl *acl)
-{
-   int i;
-   struct security_acl *new_acl; 
-   if (!acl) {
-   return NULL;
-   }
-   
-   new_acl = talloc_zero(mem, struct security_acl);
-
-   for (i=0; i  acl-num_aces; i++) {
-   struct security_ace *ace = acl-aces[i];
-   if (!(ace-flags  SEC_ACE_FLAG_INHERITED_ACE)){
-   new_acl-aces = talloc_realloc(new_acl, new_acl-aces, 
struct security_ace,
-  new_acl-num_aces+1);
-   if (new_acl-aces == NULL) {
-   talloc_free(new_acl);
-   return NULL;
-   }
-   new_acl-aces[new_acl-num_aces] = *ace;
-   new_acl-num_aces++;

[SCM] Samba Shared Repository - branch master updated

2010-04-19 Thread Jeremy Allison

The branch, master has been updated
   via  60d3692... Now SMB2 error messages are correctly being returned 
with the 1 byte data area, smbd_smb2_request_error_ex() must call 
smbd_smb2_request_done_ex() in order to do the padding correctly on compound 
replies.
   via  8bf7942... Ensure vectors are always allocated with consistent 
size. Removes one byte alloc on SMB2 error packet. Always use talloc_zero_array 
on out vectors - fixes valgrind errors in tevent writes.
   via  eacf5b2... Fix valgrind error where a strdup of name reads one byte 
beyond the end. Ensure buffer returned from inotify is null terminated.
  from  4fc5908... Removed more excess looping and fixed problem with 
incorrect IO flag handling.

http://gitweb.samba.org/?p=samba.git;a=shortlog;h=master


- Log -
commit 60d36929189eb8c5749431a4d90266b34c26b0c3
Author: Jeremy Allison j...@samba.org
Date:   Mon Apr 19 14:32:08 2010 -0700

Now SMB2 error messages are correctly being returned with the 1 byte data 
area, smbd_smb2_request_error_ex() must call smbd_smb2_request_done_ex() in 
order to do the padding correctly on compound replies.

Jeremy.

commit 8bf7942fa4a5aceda3b01e9d5ad555a444b80faa
Author: Jeremy Allison j...@samba.org
Date:   Mon Apr 19 13:43:42 2010 -0700

Ensure vectors are always allocated with consistent size. Removes one byte 
alloc on SMB2 error packet. Always use talloc_zero_array on out vectors - fixes 
valgrind errors in tevent writes.

Jeremy.

commit eacf5b235dd27ef844ebee80ded37ec7ecdf8ab2
Author: Jeremy Allison j...@samba.org
Date:   Mon Apr 19 13:42:55 2010 -0700

Fix valgrind error where a strdup of name reads one byte beyond the end. 
Ensure buffer returned from inotify is null terminated.

Jeremy.

---

Summary of changes:
 source3/smbd/notify_inotify.c |3 +-
 source3/smbd/smb2_server.c|  166 +
 2 files changed, 104 insertions(+), 65 deletions(-)


Changeset truncated at 500 lines:

diff --git a/source3/smbd/notify_inotify.c b/source3/smbd/notify_inotify.c
index 6159945..b1d424d 100644
--- a/source3/smbd/notify_inotify.c
+++ b/source3/smbd/notify_inotify.c
@@ -246,8 +246,9 @@ static void inotify_handler(struct event_context *ev, 
struct fd_event *fde,
return;
}
 
-   e0 = e = (struct inotify_event *)TALLOC_SIZE(in, bufsize);
+   e0 = e = (struct inotify_event *)TALLOC_SIZE(in, bufsize + 1);
if (e == NULL) return;
+   ((uint8_t *)e)[bufsize] = '\0';
 
status = read_data(in-fd, (char *)e0, bufsize);
if (!NT_STATUS_IS_OK(status)) {
diff --git a/source3/smbd/smb2_server.c b/source3/smbd/smb2_server.c
index 72c2dbd..277a79f 100644
--- a/source3/smbd/smb2_server.c
+++ b/source3/smbd/smb2_server.c
@@ -23,6 +23,8 @@
 #include ../libcli/smb/smb_common.h
 #include ../lib/tsocket/tsocket.h
 
+#define OUTVEC_ALLOC_SIZE (SMB2_HDR_BODY + 9)
+
 static const char *smb2_names[] = {
SMB2_NEGPROT,
SMB2_SESSSETUP,
@@ -377,7 +379,7 @@ static NTSTATUS smbd_smb2_request_setup_out(struct 
smbd_smb2_request *req, uint1
int idx;
 
count = req-in.vector_count;
-   vector = talloc_array(req, struct iovec, count);
+   vector = talloc_zero_array(req, struct iovec, count);
if (vector == NULL) {
return NT_STATUS_NO_MEMORY;
}
@@ -395,15 +397,16 @@ static NTSTATUS smbd_smb2_request_setup_out(struct 
smbd_smb2_request *req, uint1
struct iovec *current = vector[idx];
 
if ((idx + 3)  count) {
-   /* we have a next command */
-   next_command_ofs = SMB2_HDR_BODY + 8;
+   /* we have a next command -
+* setup for the error case. */
+   next_command_ofs = SMB2_HDR_BODY + 9;
}
 
inhdr = (const uint8_t *)req-in.vector[idx].iov_base;
in_flags = IVAL(inhdr, SMB2_HDR_FLAGS);
 
-   outhdr = talloc_array(vector, uint8_t,
- SMB2_HDR_BODY + 8);
+   outhdr = talloc_zero_array(vector, uint8_t,
+ OUTVEC_ALLOC_SIZE);
if (outhdr == NULL) {
return NT_STATUS_NO_MEMORY;
}
@@ -506,7 +509,7 @@ static struct smbd_smb2_request *dup_smb2_req(const struct 
smbd_smb2_request *re
newreq-async = false;
newreq-cancelled = false;
 
-   outvec = talloc_array(newreq, struct iovec, count);
+   outvec = talloc_zero_array(newreq, struct iovec, count);
if (!outvec) {
TALLOC_FREE(newreq);
return NULL;
@@ -518,16 +521,43 @@ static struct smbd_smb2_request *dup_smb2_req(const 
struct smbd_smb2_request *re
outvec[0].iov_base =

[SCM] CTDB repository - branch master updated - ctdb-1.0.114-20-g3044d07

2010-04-19 Thread Ronnie Sahlberg

The branch, master has been updated
   via  3044d07da2a58260fa06bf489890b279bcf3ec39 (commit)
   via  2ea0a9f1a93781a0d036feb9fcc0d120b182922f (commit)
   via  25cfa2aafd653c948430aae8729d293c86a6a68c (commit)
   via  4fb662bba6d96d4c04dadd9f908c4184ef4e969a (commit)
   via  da5cd6d4231d01e6a55090ce737dc44e66916625 (commit)
  from  2a79d976f975ec1ecbd06c210cbb5e6a93068cec (commit)

http://gitweb.samba.org/?p=sahlberg/ctdb.git;a=shortlog;h=master


- Log -
commit 3044d07da2a58260fa06bf489890b279bcf3ec39
Author: Martin Schwenke mar...@meltin.net
Date:   Tue Apr 20 10:52:31 2010 +1000

Fix a thinko in 2ea0a9f1a93781a0d036feb9fcc0d120b182922f.

If the driver is virtio_net then we assume that the link is up rather
than ignoring the check altogether.

Signed-off-by: Martin Schwenke mar...@meltin.net

commit 2ea0a9f1a93781a0d036feb9fcc0d120b182922f
Author: Ralph Wuerthner ralph.wuerth...@de.ibm.com
Date:   Thu Apr 15 16:38:19 2010 +1000

ethtool does not support virtio_net devices.

Skip link test for this type of devices

Signed-off-by: Ralph Wuerthner ralph.wuerth...@de.ibm.com
Signed-off-by: Martin Schwenke mar...@meltin.net

commit 25cfa2aafd653c948430aae8729d293c86a6a68c
Merge: 4fb662bba6d96d4c04dadd9f908c4184ef4e969a 
2a79d976f975ec1ecbd06c210cbb5e6a93068cec
Author: Martin Schwenke mar...@meltin.net
Date:   Thu Apr 15 13:45:50 2010 +1000

Merge branch 'master' of git://git.samba.org/sahlberg/ctdb

commit 4fb662bba6d96d4c04dadd9f908c4184ef4e969a
Merge: da5cd6d4231d01e6a55090ce737dc44e66916625 
5ed7d6788b8f7bf71d7d66c3a620b1aec54dfd81
Author: Martin Schwenke mar...@meltin.net
Date:   Wed Mar 31 17:52:42 2010 +1100

Merge commit 'origin/master'

commit da5cd6d4231d01e6a55090ce737dc44e66916625
Author: Wolfgang Mueller-Friedt wolfm...@de.ibm.com
Date:   Wed Mar 10 10:39:31 2010 +0100

ctdb_setstatus in /etc/ctdb/functions was not working correctly because it 
was called with a wrong parameter list

---

Summary of changes:
 config/events.d/10.interface |3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)


Changeset truncated at 500 lines:

diff --git a/config/events.d/10.interface b/config/events.d/10.interface
index d7abc18..fdb1557 100755
--- a/config/events.d/10.interface
+++ b/config/events.d/10.interface
@@ -80,7 +80,8 @@ monitor_interfaces()
# we dont know how to test ib links
;;
*)
-   [ -z $IFACE ] || {
+   [ -z $IFACE ] {
+   [ $(basename $(readlink 
/sys/class/net/$IFACE/device/driver)) = virtio_net ] ||
ethtool $IFACE | grep -q 'Link detected: yes' || {
# On some systems, this is not successful when a
# cable is plugged but the interface has not been


-- 
CTDB repository

[SCM] CTDB repository - branch 1.0.112 updated - ctdb-1.0.111-60-g9233988

2010-04-19 Thread Ronnie Sahlberg

The branch, 1.0.112 has been updated
   via  92339bb839e22951a8dd21187bf3f343eb3d (commit)
  from  89d31da66ca3f15ed3a87851dea5422be949a2e4 (commit)

http://gitweb.samba.org/?p=sahlberg/ctdb.git;a=shortlog;h=1.0.112


- Log -
commit 92339bb839e22951a8dd21187bf3f343eb3d
Author: Ronnie Sahlberg ronniesahlb...@gmail.com
Date:   Tue Apr 20 12:28:16 2010 +1000

Backport of patch to handle virtio interfaces correctly.
(ethtool does not work on these)

---

Summary of changes:
 config/events.d/10.interface |9 +
 1 files changed, 5 insertions(+), 4 deletions(-)


Changeset truncated at 500 lines:

diff --git a/config/events.d/10.interface b/config/events.d/10.interface
index 88ab2e9..8cbe222 100755
--- a/config/events.d/10.interface
+++ b/config/events.d/10.interface
@@ -193,14 +193,15 @@ case $1 in
# we dont know how to test ib links
;;
*)
-   [ -z $IFACE ] || {
-   /usr/sbin/ethtool $IFACE | grep -q 'Link detected: yes' || {
+   [ -z $IFACE ] {
+   [ $(basename $(readlink 
/sys/class/net/$IFACE/device/driver)) = virtio_net ] ||
+   ethtool $IFACE | grep -q 'Link detected: yes' || {
# On some systems, this is not successful when a
# cable is plugged but the interface has not been
# brought up previously. Bring the interface up and
# try again...
-   /sbin/ip link set $IFACE up
-   /usr/sbin/ethtool $IFACE | grep -q 'Link detected: yes' 
|| {
+   ip link set $IFACE up
+   ethtool $IFACE | grep -q 'Link detected: yes' || {
echo ERROR: No link on the public network 
interface $IFACE
exit 1
}


-- 
CTDB repository

[SCM] Samba Shared Repository - branch master updated

2010-04-19 Thread Andrew Bartlett

The branch, master has been updated
   via  ea5cf7c... s4:provision Pass in the invoication ID and NTDS 
Settings DN to Schema()
  from  60d3692... Now SMB2 error messages are correctly being returned 
with the 1 byte data area, smbd_smb2_request_error_ex() must call 
smbd_smb2_request_done_ex() in order to do the padding correctly on compound 
replies.

http://gitweb.samba.org/?p=samba.git;a=shortlog;h=master


- Log -
commit ea5cf7ce05f295c34d0fca194ed7d8691f1e04ab
Author: Andrew Bartlett abart...@samba.org
Date:   Tue Apr 20 11:48:51 2010 +1000

s4:provision Pass in the invoication ID and NTDS Settings DN to Schema()

By putting these values into the cache on the LDB, this reduces some
of the noise in provision, particularly with the LDAP backend.

Andrew Bartlett

---

Summary of changes:
 source4/dsdb/common/util.c  |   39 ++-
 source4/dsdb/pydsdb.c   |   36 
 source4/dsdb/samdb/ldb_modules/samba_dsdb.c |2 +-
 source4/scripting/python/samba/provision.py |   10 +++---
 source4/scripting/python/samba/samdb.py |   20 +++--
 source4/scripting/python/samba/schema.py|   12 ++--
 6 files changed, 106 insertions(+), 13 deletions(-)


Changeset truncated at 500 lines:

diff --git a/source4/dsdb/common/util.c b/source4/dsdb/common/util.c
index 66a0b0f..30cb5c5 100644
--- a/source4/dsdb/common/util.c
+++ b/source4/dsdb/common/util.c
@@ -1173,6 +1173,43 @@ failed:
return false;
 }
 
+bool samdb_set_ntds_settings_dn(struct ldb_context *ldb, struct ldb_dn 
*ntds_settings_dn_in)
+{
+   TALLOC_CTX *tmp_ctx;
+   struct ldb_dn *ntds_settings_dn_new;
+   struct ldb_dn *ntds_settings_dn_old;
+
+   /* see if we have a cached copy */
+   ntds_settings_dn_old = talloc_get_type(ldb_get_opaque(ldb, 
+ 
cache.ntds_settings_dn), struct ldb_dn);
+
+   tmp_ctx = talloc_new(ldb);
+   if (tmp_ctx == NULL) {
+   goto failed;
+   }
+
+   ntds_settings_dn_new = ldb_dn_copy(tmp_ctx, ntds_settings_dn_in);
+   if (!ntds_settings_dn_new) {
+   goto failed;
+   }
+
+   /* cache the domain_sid in the ldb */
+   if (ldb_set_opaque(ldb, cache.ntds_settings_dn, ntds_settings_dn_new) 
!= LDB_SUCCESS) {
+   goto failed;
+   }
+
+   talloc_steal(ldb, ntds_settings_dn_new);
+   talloc_free(tmp_ctx);
+   talloc_free(ntds_settings_dn_old);
+
+   return true;
+
+failed:
+   DEBUG(1,(Failed to set our NTDS Settings DN in the ldb!\n));
+   talloc_free(tmp_ctx);
+   return false;
+}
+
 /* Obtain the short name of the flexible single master operator
  * (FSMO), such as the PDC Emulator */
 const char *samdb_result_fsmo_name(struct ldb_context *ldb, TALLOC_CTX 
*mem_ctx, const struct ldb_message *msg, 
@@ -1207,7 +1244,7 @@ struct ldb_dn *samdb_ntds_settings_dn(struct ldb_context 
*ldb)
struct ldb_dn *settings_dn;
 
/* see if we have a cached copy */
-   settings_dn = (struct ldb_dn *)ldb_get_opaque(ldb, cache.settings_dn);
+   settings_dn = (struct ldb_dn *)ldb_get_opaque(ldb, 
cache.ntds_settings_dn);
if (settings_dn) {
return settings_dn;
}
diff --git a/source4/dsdb/pydsdb.c b/source4/dsdb/pydsdb.c
index 88c6208..45f8b6e 100644
--- a/source4/dsdb/pydsdb.c
+++ b/source4/dsdb/pydsdb.c
@@ -127,6 +127,38 @@ static PyObject *py_samdb_set_domain_sid(PyLdbObject 
*self, PyObject *args)
Py_RETURN_NONE;
 }
 
+static PyObject *py_samdb_set_ntds_settings_dn(PyLdbObject *self, PyObject 
*args)
+{ 
+   PyObject *py_ldb, *py_ntds_settings_dn;
+   struct ldb_context *ldb;
+   struct ldb_dn *ntds_settings_dn;
+   TALLOC_CTX *tmp_ctx;
+   bool ret;
+
+   if (!PyArg_ParseTuple(args, OO, py_ldb, py_ntds_settings_dn))
+   return NULL;
+   
+   PyErr_LDB_OR_RAISE(py_ldb, ldb);
+
+   tmp_ctx = talloc_new(NULL);
+   if (tmp_ctx == NULL) {
+   PyErr_NoMemory();
+   return NULL;
+   }
+
+   if (!PyObject_AsDn(tmp_ctx, py_ntds_settings_dn, ldb, 
ntds_settings_dn)) {
+   return NULL;
+   }
+
+   ret = samdb_set_ntds_settings_dn(ldb, ntds_settings_dn);
+   talloc_free(tmp_ctx);
+   if (!ret) {
+   PyErr_SetString(PyExc_RuntimeError, set_ntds_settings_dn 
failed);
+   return NULL;
+   } 
+   Py_RETURN_NONE;
+}
+
 static PyObject *py_samdb_get_domain_sid(PyLdbObject *self, PyObject *args)
 { 
PyObject *py_ldb;
@@ -356,6 +388,10 @@ static PyMethodDef py_dsdb_methods[] = {
Get SID of domain in use. },
{ samdb_ntds_invocation_id, (PyCFunction)py_samdb_ntds_invocation_id,

[SCM] Samba Shared Repository - branch master updated

2010-04-19 Thread Andrew Bartlett

The branch, master has been updated
   via  538a07a... s4:provisionbackend Print the command we failed to start 
slapd with
  from  ea5cf7c... s4:provision Pass in the invoication ID and NTDS 
Settings DN to Schema()

http://gitweb.samba.org/?p=samba.git;a=shortlog;h=master


- Log -
commit 538a07a80aae72b57e5c23133158c7f214d0c27a
Author: Andrew Bartlett abart...@samba.org
Date:   Tue Apr 20 14:24:22 2010 +1000

s4:provisionbackend Print the command we failed to start slapd with

This makes it easier to put failed startups into a debugger.

Andrew Bartlett

---

Summary of changes:
 source4/scripting/python/samba/provisionbackend.py |3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)


Changeset truncated at 500 lines:

diff --git a/source4/scripting/python/samba/provisionbackend.py 
b/source4/scripting/python/samba/provisionbackend.py
index 08deb4a..25e416c 100644
--- a/source4/scripting/python/samba/provisionbackend.py
+++ b/source4/scripting/python/samba/provisionbackend.py
@@ -232,7 +232,8 @@ class LDAPBackend(ProvisionBackend):
 return
 except LdbError:
 time.sleep(1)
-
+
+self.message(Could not start slapd with: %s %  \' + \' 
\'.join(self.slapd_provision_command) + \')
 raise ProvisioningError(slapd died before we could make a connection 
to it)
 
 def shutdown(self):


-- 
Samba Shared Repository

[SCM] Samba Shared Repository - branch v3-5-test updated

2010-04-19 Thread Karolin Seeger

The branch, v3-5-test has been updated
   via  db51127... s3 torture: Prevent smbcli segfault when running 
smbtorture3 against an smbd with security=share
  from  fb1b090... s3-docs: Improve winbind nss info section in man 
smb.conf.

http://gitweb.samba.org/?p=samba.git;a=shortlog;h=v3-5-test


- Log -
commit db511272f3393a35a1e596740b88487333ebeb24
Author: Tim Prouty tpro...@samba.org
Date:   Mon Jan 4 12:57:34 2010 -0800

s3 torture: Prevent smbcli segfault when running smbtorture3 against an 
smbd with security=share

Fix bug #7370 (3.5.2 smbclient segfaults when used against old samba
security = share).

---

Summary of changes:
 source3/libsmb/cliconnect.c |5 +
 1 files changed, 5 insertions(+), 0 deletions(-)


Changeset truncated at 500 lines:

diff --git a/source3/libsmb/cliconnect.c b/source3/libsmb/cliconnect.c
index 7aa8901..22be999 100644
--- a/source3/libsmb/cliconnect.c
+++ b/source3/libsmb/cliconnect.c
@@ -1320,6 +1320,8 @@ struct tevent_req *cli_tcon_andx_create(TALLOC_CTX 
*mem_ctx,
char *tmp = NULL;
uint8_t *bytes;
 
+   *psmbreq = NULL;
+
req = tevent_req_create(mem_ctx, state, struct cli_tcon_andx_state);
if (req == NULL) {
return NULL;
@@ -1455,6 +1457,9 @@ struct tevent_req *cli_tcon_andx_send(TALLOC_CTX *mem_ctx,
if (req == NULL) {
return NULL;
}
+   if (subreq == NULL) {
+   return req;
+   }
status = cli_smb_req_send(subreq);
if (!NT_STATUS_IS_OK(status)) {
tevent_req_nterror(req, status);


-- 
Samba Shared Repository

43 matches

Mail list logo