Re: [Samba] winbind is not taking default domain
Quoting Marco Huang (marco.hu...@auckland.ac.nz): Hi, We have been running samba file server about 2 years without this problem. The problem appeared at the same time on our debian and centos servers. Not sure if it's related to any updates on our windows AD servers. This seems to be Debian bug #617449, which I forwarded upstream as #7999. I write seems as the bug submitter in Debian was using winbind separator and you aren't. -- To unsubscribe from this list go to the following URL and read the instructions: https://lists.samba.org/mailman/options/samba
Re: [Samba] new created files belong to root instead samba user
Thanks for your reply. Yes, anyone with the proper file and share permissions can do so. You really want to use the advanced settings dialog. Luckily working with the advanced settings dialogs seems to be working now. I wonder why the advanced settings dialog works, but permissions are not properly displayed on the security settings tab - is this normal? regards, Werner -- GMX DSL Doppel-Flat ab 19,99 Euro/mtl.! Jetzt mit gratis Handy-Flat! http://portal.gmx.net/de/go/dsl -- To unsubscribe from this list go to the following URL and read the instructions: https://lists.samba.org/mailman/options/samba
Re: [Samba] samba howto: sticky bit on directories
Werner Durgarten wrote: The Samba Howto Collection http://www.samba.org/samba/docs/man/Samba- HOWTO-Collection/AccessControls.html#id2611229 says: When the set user or group ID bit (s) is set on a directory, then all files created within it will be owned by the user and/or group whose `set user or group' bit is set. while i cannot repoduce this behavior the wikipedia says: http://en.wikipedia.org/wiki/Setuid#setuid_and_setgid_on_directories The setuid permission set on a directory is ignored on UNIX and Linux systems either there is an error in the howto, or maybe its just time for me to start the weekend ;-) On CentOS 5.4, the section 26.1 Structure of File Permissions in info chmod states that the setuid bit has no effect on directories, but that the setgid bit does, on some systems, set the gid of files created in the directory. The setgid bit certainly works for Samba group directories; we've never tried setuid. I guess it may have worked in the past, but doesn't any more. Try it from the command line: if it doesn't work there, it won't from Samba. Moray. “To err is human; to purr, feline.” -- To unsubscribe from this list go to the following URL and read the instructions: https://lists.samba.org/mailman/options/samba
Re: [Samba] samba howto: sticky bit on directories
This is working with samba sernet newest release: This is setting the bit for the group even with msoffice-files correctly directory mask=2770 force directory mode=2770 create mask = 2770 force create mode=2770 force security mode=2770 force directory security mode=2770 On Fri, 25 Mar 2011 15:23:01 +0100, Werner Durgarten wernerdurgar...@gmx.de wrote: Hi List, The Samba Howto Collection http://www.samba.org/samba/docs/man/Samba-HOWTO-Collection/AccessControls.html#id2611229 says: When the set user or group ID bit (s) is set on a directory, then all files created within it will be owned by the user and/or group whose `set user or group' bit is set. while i cannot repoduce this behavior the wikipedia says: http://en.wikipedia.org/wiki/Setuid#setuid_and_setgid_on_directories The setuid permission set on a directory is ignored on UNIX and Linux systems either there is an error in the howto, or maybe its just time for me to start the weekend ;-) regards Werner -- GMX DSL Doppel-Flat ab 19,99 Euro/mtl.! Jetzt mit gratis Handy-Flat! http://portal.gmx.net/de/go/dsl -- To unsubscribe from this list go to the following URL and read the instructions: https://lists.samba.org/mailman/options/samba
Re: [Samba] Is it possible to use Samba as a proxy and cache for a slow CIFS drive ?
Hi guys, what will the proxy be able to do without a caching function ? Can I mitigate the slow performance of the share with Samba as a proxy or is there a way to attach a cache to it ? How could a custom VFS module be setup ? Do you know someone who could do this for me ? thx kind regards, martin. Original-Nachricht Betreff: Re: [Samba] Is it possible to use Samba as a proxy and cache for a slow CIFS drive ? Datum: Sat, 26 Mar 2011 13:19:51 +0900 (JST) Von: TAKAHASHI Motonobu mo...@monyo.com An: esiot...@gmail.com, m...@metamagix.net CC: samba@lists.samba.org, mo...@monyo.com From: Michael Wood esiot...@gmail.com Date: Sat, 26 Mar 2011 01:20:06 +0200 On 25 March 2011 15:11, Martin Gilly m...@metamagix.net wrote: Hi all, we have special scenario with a slow file share where Samba (maybe combined with other tools) could help by acting like as a CIFS proxy and caching system: (snip) Maybe anybody can think of a way that Samba - maybe in combination with some other tools - can create a solution for this problem ? Maybe you could do this with a custom VFS module. To set msdfs proxy parameter, Samba can act as a simple CIFS proxy (with no cache function). --- TAKAHASHI Motonobu mo...@samba.gr.jp -- To unsubscribe from this list go to the following URL and read the instructions: https://lists.samba.org/mailman/options/samba
[Samba] Windows cannot sync Roaming Profiles
Hello all, I am have a Samba4 server configured with as a Domain Controller with a profiles share, and permissions are set to 0777 for experimental purposes. Currently, the Windows machines will refuse to write changes to the roaming profile on the server, and the returned error is the request is not supported. It only seems to have this problem when dealing with files, not directories. Mac OS X (so presumably any unix based client) has no problem writing changes to the share, so I am trying to figure out how to allow Windows to write changes during logout. Thanks for any help! -- To unsubscribe from this list go to the following URL and read the instructions: https://lists.samba.org/mailman/options/samba
Re: [Samba] samba winbind ignores local unix groups.
Hi, Original-Nachricht Why does samba+winbind ignore the local unix groups ? I have joined my samba server to Windows AD. I have configured a share with the values: [public_share] #Perms are 777 path= /home/pub_share comment = Public_Share writable= yes create mask = 775 directory mask = 775 browsable = yes valid users = @adgroup If I use a group from Windows AD, there is no problem accessing the share, but we do not want to add / change groups in AD, we need to add users to our local /etc/groups as access to Windows AD is very limited and we would rather control things on the linux side, and use the single sign on from AD for the users. i am not the best expert the mailing list has to offer, but i think when you are using ad and winbind you need group information locally and in ad + mapping between ad and local groups - otherwise you will step into various problems. alternatives are (1) switching off winbind (then samba falls back to local group information only) or (2) administer your local groups via ad rfc2307 schema extension + winbind + nsswitch. hth werner -- NEU: FreePhone - kostenlos mobil telefonieren und surfen! Jetzt informieren: http://www.gmx.net/de/go/freephone -- To unsubscribe from this list go to the following URL and read the instructions: https://lists.samba.org/mailman/options/samba
Re: [Samba] new created files belong to root instead samba user
On Mon, Mar 28, 2011 at 4:28 AM, Werner Durgarten wernerdurgar...@gmx.de wrote: I wonder why the advanced settings dialog works, but permissions are not properly displayed on the security settings tab - is this normal? Yes. I think so. Pretty sure it's mentioned in the official docs as well. Chris -- To unsubscribe from this list go to the following URL and read the instructions: https://lists.samba.org/mailman/options/samba
[Samba] Samba 3.2.15 : DOS charset problem on powerpc big endian architecture
Hello, With a default CP850 dos charset, I cant connect and receive a protocol negotiation failed error message # testparm -v |grep charset Load smb config files from /etc/samba/smb.conf Module '/usr/lib/charset/CP850.so' loaded Server role: ROLE_STANDALONE dos charset = CP850 unix charset = UTF-8 display charset = LOCALE # smbclient -L MYSERVER -Uadmin protocol negotiation failed The samba log file gives me [2011/01/11 13:22:53, 10] lib/util.c:dump_data(2230) [000] 02 50 43 20 4E 45 54 57 4F 52 4B 20 50 52 4F 47 .PC NETW ORK PROG [010] 52 41 4D 20 31 2E 30 00 02 4D 49 43 52 4F 53 4F RAM 1.0. .MICROSO [020] 46 54 20 4E 45 54 57 4F 52 4B 53 20 31 2E 30 33 FT NETWO RKS 1.03 [030] 00 02 4D 49 43 52 4F 53 4F 46 54 20 4E 45 54 57 ..MICROS OFT NETW [040] 4F 52 4B 53 20 33 2E 30 00 02 4C 41 4E 4D 41 4E ORKS 3.0 ..LANMAN [050] 31 2E 30 00 02 4C 4D 31 2E 32 58 30 30 32 00 02 1.0..LM1 .2X002.. [060] 44 4F 53 20 4C 41 4E 4D 41 4E 32 2E 31 00 02 4C DOS LANM AN2.1..L [070] 41 4E 4D 41 4E 32 2E 31 00 02 53 61 6D 62 61 00 ANMAN2.1 ..Samba. [080] 02 4E 54 20 4C 41 4E 4D 41 4E 20 31 2E 30 00 02 .NT LANM AN 1.0.. [090] 4E 54 20 4C 4D 20 30 2E 31 32 00 NT LM 0. 12. [2011/01/11 13:22:53, 10] lib/util.c:set_remote_arch(2205) set_remote_arch: Client arch is 'UNKNOWN' [2011/01/11 13:22:53, 0] smbd/negprot.c:reply_negprot(675) No protocol supported ! [2011/01/11 13:22:53, 5] smbd/negprot.c:reply_negprot(680) negprot index=-1 With an ASCII dos charset, it works fine. # testparm -v |grep charset Load smb config files from /etc/samba/smb.conf Server role: ROLE_STANDALONE dos charset = ASCII unix charset = UTF-8 display charset = LOCALE # smbclient -L MYSERVER -Uadmin Enter admin's password: Domain=[MYGROUP] OS=[Unix] Server=[Samba 3.2.15] I have some other samba servers on Intel architecture which runs with CP850 dos charset. What I miss with my powerpc architecture ? Thanks for all tips. Gérard -- To unsubscribe from this list go to the following URL and read the instructions: https://lists.samba.org/mailman/options/samba
[Samba] Build error with Samba 3.5.6
I'm trying to build Samba 3.5.6 with winbind enabled on a Solaris 10 machine and I've hit the following errors: Error without -lintl in the Makefile: Undefined first referenced symbol in file libintl_gettext utils/net.o (symbol belongs to implicit dependency /usr/local/lib/libintl.so.8) libintl_textdomain utils/net.o (symbol belongs to implicit dependency /usr/local/lib/libintl.so.8) libintl_bindtextdomain utils/net.o (symbol belongs to implicit dependency /usr/local/lib/libintl.so.8) ld: fatal: Symbol referencing errors. No output written to bin/net Error with -lintl in the Makefile: Linking shared library bin/pam_winbind.so Undefined first referenced symbol in file libintl_bindtextdomain ../nsswitch/pam_winbind.o libintl_dgettext../nsswitch/pam_winbind.o ld: fatal: Symbol referencing errors. No output written to bin/pam_winbind.so I did find some posts (archived email to the Samba list) with this error, and I've tried the suggested solutions, but it still fails. Any suggestions? Thanks. Stan -- To unsubscribe from this list go to the following URL and read the instructions: https://lists.samba.org/mailman/options/samba
Re: [Samba] winbind is not taking default domain
We are using sernet-samba-3.5.8-27, but I've tried samba/winbind packages from debian squeeze, same result, and the problem appears on centos5.5 as well. We've been running these file servers for quite a long time, not sure if there's any recent update on windows AD related which requires some additional changes on smb.conf. On 28/03/2011, at 6:07 PM, Christian PERRIER wrote: Quoting Marco Huang (marco.hu...@auckland.ac.nz): Hi, We have been running samba file server about 2 years without this problem. The problem appeared at the same time on our debian and centos servers. Not sure if it's related to any updates on our windows AD servers. This seems to be Debian bug #617449, which I forwarded upstream as #7999. I write seems as the bug submitter in Debian was using winbind separator and you aren't. -- To unsubscribe from this list go to the following URL and read the instructions: https://lists.samba.org/mailman/options/samba -- To unsubscribe from this list go to the following URL and read the instructions: https://lists.samba.org/mailman/options/samba
Re: [Samba] Roaming Profiles Configuration
Now, I cannot access the share at all, I'd imagine because my samba4 users are not local users, but are stored in the Samba4 Active Directory database. Is there anyway I can have Samba4 let each Samba user have his own files not viewable by others on a share? Thus On Sun, Mar 27, 2011 at 2:55 PM, Mark Shields laebsh...@gmail.com wrote: On Sun, Mar 27, 2011 at 12:21 PM, Ryan Leimenstoll ryanl1...@gmail.comwrote: Hello all! I am new to the mailing lists, as well as Samba. I was looking for an Active Directory alternative for linux, and finally landed on Samba4. My installation is alpha12, installed via apt on Ubuntu 10.10. I am trying to create roaming profiles, however, if path = /UserData then the profiles are viewable from every user account by simple accessing example.samdom.com/profiles My next thought (given research I saw on Samba3) was to set it to path = /UserData/%U, however then clients cannot connect to the profiles share at all. I am trying to have the user's data only available through his account without creating a new share for every single user manually. Any help with this would be greatly appreciated! Ryan -- To unsubscribe from this list go to the following URL and read the instructions: https://lists.samba.org/mailman/options/samba Like Windows Sharing, Samba sharing also requires appropriate local permissions; in other words, if you make each user's profile directory owned to that local user, and remove group/everyone access (chmod 700), you should get exactly what you want. - Mark Shields -- To unsubscribe from this list go to the following URL and read the instructions: https://lists.samba.org/mailman/options/samba
Re: [Samba] Is it possible to use Samba as a proxy and cache for a slow CIFS drive ?
On Mon, Mar 28, 2011 at 02:38:17PM +0200, Martin Gilly wrote: what will the proxy be able to do without a caching function ? Can I mitigate the slow performance of the share with Samba as a proxy or is there a way to attach a cache to it ? How could a custom VFS module be setup ? Do you know someone who could do this for me ? In general, I think what you're trying to achieve is very, very difficult to do correctly. You can spend big bucks on the WAN accellerators around, they serve a very similar purpose. It would probably be better to approach Alfresco to speed up their implementation to fit your expectations. Or maybe just re-architect your system so that the bulk traffic can be sort-of precomputed and put on a different server? With best regards, Volker -- SerNet GmbH, Bahnhofsallee 1b, 37081 Göttingen phone: +49-551-37-0, fax: +49-551-37-9 AG Göttingen, HRB 2816, GF: Dr. Johannes Loxen -- To unsubscribe from this list go to the following URL and read the instructions: https://lists.samba.org/mailman/options/samba
Re: [Samba] samba winbind ignores local unix groups.
Hi, thanks very much for your feeback. I now have it working in my Virtualbox lab and will make the changes in production shortly. The trick was to rely on kerberos only thanks for the winbind tip, it was confusing me horribly. I disabled winbind and did more testing, now anyone who has authenticated to AD, and is in a local linux group for the share can connect. Thanks again, Steve. On , Werner Durgarten wernerdurgar...@gmx.de wrote: Hi, Original-Nachricht Why does samba+winbind ignore the local unix groups ? I have joined my samba server to Windows AD. I have configured a share with the values: [public_share] #Perms are 777 path = /home/pub_share comment = Public_Share writable = yes create mask = 775 directory mask = 775 browsable = yes valid users = @adgroup If I use a group from Windows AD, there is no problem accessing the share, but we do not want to add / change groups in AD, we need to add users to our local /etc/groups as access to Windows AD is very limited and we would rather control things on the linux side, and use the single sign on from AD for the users. i am not the best expert the mailing list has to offer, but i think when you are using ad and winbind you need group information locally and in ad + mapping between ad and local groups - otherwise you will step into various problems. alternatives are (1) switching off winbind (then samba falls back to local group information only) or (2) administer your local groups via ad rfc2307 schema extension + winbind + nsswitch. hth werner -- NEU: FreePhone - kostenlos mobil telefonieren und surfen! Jetzt informieren: http://www.gmx.net/de/go/freephone -- To unsubscribe from this list go to the following URL and read the instructions: https://lists.samba.org/mailman/options/samba
Re: [Samba] samba howto: sticky bit on directories
Daniel MCller wrote: This is working with samba sernet newest release: This is setting the bit for the group even with msoffice-files correctly directory mask=2770 force directory mode=2770 create mask = 2770 force create mode=2770 force security mode=2770 force directory security mode=2770 Unfortunately, I don't think the 'local linux' version allows the setUID functionality to work on directories. SetGID and allowing the propagation of the GID _does_ work. I'd guess on the reasoning: on any linux I've run on, users can't give away files to other users. Allowing this 'bit' to work would effectively do the same thing. -- To unsubscribe from this list go to the following URL and read the instructions: https://lists.samba.org/mailman/options/samba
[SCM] Samba Shared Repository - branch master updated
The branch, master has been updated
via dc36d75 Revert Change strict allocate to default to true.
from a414356 s3: Fix Coverity ID 2188: MISSING_BREAK
http://gitweb.samba.org/?p=samba.git;a=shortlog;h=master
- Log -
commit dc36d75d5fddaa351025e8eb8140f401b66aeb9d
Author: Stefan Metzmacher me...@samba.org
Date: Mon Mar 28 08:11:01 2011 +0200
Revert Change strict allocate to default to true.
This reverts commit ecf48af135e4c1ebc5aafe4b3dad785162f5949a.
This makes Samba unusable on systems without Linux and
a modern Filesystem.
This was discussed with Jeremy on IRC:
http://irclog.samba.org/2011/01/20110126-Wed.log
metze
Autobuild-User: Stefan Metzmacher me...@samba.org
Autobuild-Date: Mon Mar 28 09:00:09 CEST 2011 on sn-devel-104
---
Summary of changes:
docs-xml/smbdotconf/tuning/strictallocate.xml | 11 +--
source3/param/loadparm.c |2 +-
2 files changed, 6 insertions(+), 7 deletions(-)
Changeset truncated at 500 lines:
diff --git a/docs-xml/smbdotconf/tuning/strictallocate.xml
b/docs-xml/smbdotconf/tuning/strictallocate.xml
index 9311eb6..1855574 100644
--- a/docs-xml/smbdotconf/tuning/strictallocate.xml
+++ b/docs-xml/smbdotconf/tuning/strictallocate.xml
@@ -10,10 +10,9 @@
of actually forcing the disk system to allocate real storage blocks
when a file is created or extended to be a given size. In UNIX
terminology this means that Samba will stop creating sparse files.
-Modern UNIX filesystems now support extents and so in Samba 3.6.0 we
-have changed this parameter to default to yes. On older filesystems
-without extents you might want to turn this parameter to no.
-/para
+This can be slow on some systems. When you work with large files like
+100MB or so you may even run into problems with clients running into
+timeouts./para
paraWhen you have an extent based filesystem it's likely that we can make
use of unwritten extents which allows Samba to allocate even large amounts
@@ -29,9 +28,9 @@
preallocation is probably an expensive operation where you will see reduced
performance and risk to let clients run into timeouts when creating large
files. Examples are ext3, ZFS, HFS+ and most others, so be aware if you
-leave the default setting on those filesystems./para
+activate this setting on those filesystems./para
/description
-value type=defaultyes/value
+value type=defaultno/value
/samba:parameter
diff --git a/source3/param/loadparm.c b/source3/param/loadparm.c
index ba3cd3c..49b9248 100644
--- a/source3/param/loadparm.c
+++ b/source3/param/loadparm.c
@@ -636,7 +636,7 @@ static struct service sDefault = {
false, /* bWidelinks */
True, /* bSymlinks */
False, /* bSyncAlways */
- True, /* bStrictAllocate */
+ False, /* bStrictAllocate */
False, /* bStrictSync */
'~',/* magic char */
NULL, /* copymap */
--
Samba Shared Repository
[SCM] Samba Shared Repository - branch v3-6-test updated
The branch, v3-6-test has been updated
via a611b8c Revert Change strict allocate to default to true.
from e111206 s3: Fix Coverity ID 2188: MISSING_BREAK
http://gitweb.samba.org/?p=samba.git;a=shortlog;h=v3-6-test
- Log -
commit a611b8c1ce8f96677ed2e74a233570b24f485b6c
Author: Stefan Metzmacher me...@samba.org
Date: Mon Mar 28 08:11:01 2011 +0200
Revert Change strict allocate to default to true.
This reverts commit ecf48af135e4c1ebc5aafe4b3dad785162f5949a.
This makes Samba unusable on systems without Linux and
a modern Filesystem.
This was discussed with Jeremy on IRC:
http://irclog.samba.org/2011/01/20110126-Wed.log
metze
Autobuild-User: Stefan Metzmacher me...@samba.org
Autobuild-Date: Mon Mar 28 09:00:09 CEST 2011 on sn-devel-104
(cherry picked from commit dc36d75d5fddaa351025e8eb8140f401b66aeb9d)
---
Summary of changes:
docs-xml/smbdotconf/tuning/strictallocate.xml | 11 +--
source3/param/loadparm.c |2 +-
2 files changed, 6 insertions(+), 7 deletions(-)
Changeset truncated at 500 lines:
diff --git a/docs-xml/smbdotconf/tuning/strictallocate.xml
b/docs-xml/smbdotconf/tuning/strictallocate.xml
index 9311eb6..1855574 100644
--- a/docs-xml/smbdotconf/tuning/strictallocate.xml
+++ b/docs-xml/smbdotconf/tuning/strictallocate.xml
@@ -10,10 +10,9 @@
of actually forcing the disk system to allocate real storage blocks
when a file is created or extended to be a given size. In UNIX
terminology this means that Samba will stop creating sparse files.
-Modern UNIX filesystems now support extents and so in Samba 3.6.0 we
-have changed this parameter to default to yes. On older filesystems
-without extents you might want to turn this parameter to no.
-/para
+This can be slow on some systems. When you work with large files like
+100MB or so you may even run into problems with clients running into
+timeouts./para
paraWhen you have an extent based filesystem it's likely that we can make
use of unwritten extents which allows Samba to allocate even large amounts
@@ -29,9 +28,9 @@
preallocation is probably an expensive operation where you will see reduced
performance and risk to let clients run into timeouts when creating large
files. Examples are ext3, ZFS, HFS+ and most others, so be aware if you
-leave the default setting on those filesystems./para
+activate this setting on those filesystems./para
/description
-value type=defaultyes/value
+value type=defaultno/value
/samba:parameter
diff --git a/source3/param/loadparm.c b/source3/param/loadparm.c
index a82d21c..09f8458 100644
--- a/source3/param/loadparm.c
+++ b/source3/param/loadparm.c
@@ -636,7 +636,7 @@ static struct service sDefault = {
false, /* bWidelinks */
True, /* bSymlinks */
False, /* bSyncAlways */
- True, /* bStrictAllocate */
+ False, /* bStrictAllocate */
False, /* bStrictSync */
'~',/* magic char */
NULL, /* copymap */
--
Samba Shared Repository
[SCM] Samba Shared Repository - branch master updated
The branch, master has been updated
via fbe19ba s3: Fix Coverity ID 2143: DEADCODE
via 05dac2b s3: Fix Coverity ID 2143: DEADCODE
via 6e9b69f s3: Fix Coverity ID 2173: FORWARD_NULL
from dc36d75 Revert Change strict allocate to default to true.
http://gitweb.samba.org/?p=samba.git;a=shortlog;h=master
- Log -
commit fbe19ba39843d0c70758fc8d775b085a67224a94
Author: Volker Lendecke v...@samba.org
Date: Mon Mar 28 11:12:32 2011 +0200
s3: Fix Coverity ID 2143: DEADCODE
Autobuild-User: Volker Lendecke vlen...@samba.org
Autobuild-Date: Mon Mar 28 12:06:19 CEST 2011 on sn-devel-104
commit 05dac2b7e68c53babf316ac42b2811f03db364a2
Author: Volker Lendecke v...@samba.org
Date: Mon Mar 28 11:12:32 2011 +0200
s3: Fix Coverity ID 2143: DEADCODE
commit 6e9b69fb0783188444d71fc3b3292cdc2efd6087
Author: Volker Lendecke v...@samba.org
Date: Mon Mar 28 10:52:51 2011 +0200
s3: Fix Coverity ID 2173: FORWARD_NULL
---
Summary of changes:
source3/winbindd/winbindd_cm.c |2 +-
source3/winbindd/winbindd_samr.c |8
2 files changed, 1 insertions(+), 9 deletions(-)
Changeset truncated at 500 lines:
diff --git a/source3/winbindd/winbindd_cm.c b/source3/winbindd/winbindd_cm.c
index cfd60aa..302df1e 100644
--- a/source3/winbindd/winbindd_cm.c
+++ b/source3/winbindd/winbindd_cm.c
@@ -1667,7 +1667,7 @@ void invalidate_cm_connection(struct winbindd_cm_conn
*conn)
if (conn-lsa_pipe_tcp != NULL) {
if (is_valid_policy_hnd(conn-lsa_policy)) {
- dcerpc_lsa_Close(conn-lsa_pipe-binding_handle,
+ dcerpc_lsa_Close(conn-lsa_pipe_tcp-binding_handle,
talloc_tos(),
conn-lsa_policy,
result);
diff --git a/source3/winbindd/winbindd_samr.c b/source3/winbindd/winbindd_samr.c
index 0bcfc30..d775cd7 100644
--- a/source3/winbindd/winbindd_samr.c
+++ b/source3/winbindd/winbindd_samr.c
@@ -46,10 +46,6 @@ static NTSTATUS open_internal_samr_pipe(TALLOC_CTX *mem_ctx,
struct auth_serversupplied_info *session_info = NULL;
NTSTATUS status;
- if (cli != NULL) {
- goto done;
- }
-
if (session_info == NULL) {
status = make_session_info_system(mem_ctx, session_info);
if (!NT_STATUS_IS_OK(status)) {
@@ -128,10 +124,6 @@ static NTSTATUS open_internal_lsa_pipe(TALLOC_CTX *mem_ctx,
struct auth_serversupplied_info *session_info = NULL;
NTSTATUS status;
- if (cli != NULL) {
- goto done;
- }
-
if (session_info == NULL) {
status = make_session_info_system(mem_ctx, session_info);
if (!NT_STATUS_IS_OK(status)) {
--
Samba Shared Repository
[SCM] Samba Shared Repository - branch v3-6-test updated
The branch, v3-6-test has been updated
via 6521e17 s3: Fix Coverity ID 2143: DEADCODE
via bc54a78 s3: Fix Coverity ID 2143: DEADCODE (cherry picked from
commit 05dac2b7e68c53babf316ac42b2811f03db364a2)
via 5fb174a s3: Fix Coverity ID 2173: FORWARD_NULL (cherry picked from
commit 6e9b69fb0783188444d71fc3b3292cdc2efd6087)
from a611b8c Revert Change strict allocate to default to true.
http://gitweb.samba.org/?p=samba.git;a=shortlog;h=v3-6-test
- Log -
commit 6521e178fcc69b7c92c1db1bd66898cc31f1345b
Author: Volker Lendecke v...@samba.org
Date: Mon Mar 28 11:12:32 2011 +0200
s3: Fix Coverity ID 2143: DEADCODE
Autobuild-User: Volker Lendecke vlen...@samba.org
Autobuild-Date: Mon Mar 28 12:06:19 CEST 2011 on sn-devel-104
(cherry picked from commit fbe19ba39843d0c70758fc8d775b085a67224a94)
commit bc54a78213cc7674cf6c761589c0a2eb020c83c2
Author: Volker Lendecke v...@samba.org
Date: Mon Mar 28 11:12:32 2011 +0200
s3: Fix Coverity ID 2143: DEADCODE
(cherry picked from commit 05dac2b7e68c53babf316ac42b2811f03db364a2)
commit 5fb174ace5b91e4c6e516887ea165038675a1a61
Author: Volker Lendecke v...@samba.org
Date: Mon Mar 28 10:52:51 2011 +0200
s3: Fix Coverity ID 2173: FORWARD_NULL
(cherry picked from commit 6e9b69fb0783188444d71fc3b3292cdc2efd6087)
---
Summary of changes:
source3/winbindd/winbindd_cm.c |2 +-
source3/winbindd/winbindd_samr.c |8
2 files changed, 1 insertions(+), 9 deletions(-)
Changeset truncated at 500 lines:
diff --git a/source3/winbindd/winbindd_cm.c b/source3/winbindd/winbindd_cm.c
index cfd60aa..302df1e 100644
--- a/source3/winbindd/winbindd_cm.c
+++ b/source3/winbindd/winbindd_cm.c
@@ -1667,7 +1667,7 @@ void invalidate_cm_connection(struct winbindd_cm_conn
*conn)
if (conn-lsa_pipe_tcp != NULL) {
if (is_valid_policy_hnd(conn-lsa_policy)) {
- dcerpc_lsa_Close(conn-lsa_pipe-binding_handle,
+ dcerpc_lsa_Close(conn-lsa_pipe_tcp-binding_handle,
talloc_tos(),
conn-lsa_policy,
result);
diff --git a/source3/winbindd/winbindd_samr.c b/source3/winbindd/winbindd_samr.c
index 40c0bb6..d7411f1 100644
--- a/source3/winbindd/winbindd_samr.c
+++ b/source3/winbindd/winbindd_samr.c
@@ -46,10 +46,6 @@ static NTSTATUS open_internal_samr_pipe(TALLOC_CTX *mem_ctx,
struct auth_serversupplied_info *session_info = NULL;
NTSTATUS status;
- if (cli != NULL) {
- goto done;
- }
-
if (session_info == NULL) {
status = make_session_info_system(mem_ctx, session_info);
if (!NT_STATUS_IS_OK(status)) {
@@ -128,10 +124,6 @@ static NTSTATUS open_internal_lsa_pipe(TALLOC_CTX *mem_ctx,
struct auth_serversupplied_info *session_info = NULL;
NTSTATUS status;
- if (cli != NULL) {
- goto done;
- }
-
if (session_info == NULL) {
status = make_session_info_system(mem_ctx, session_info);
if (!NT_STATUS_IS_OK(status)) {
--
Samba Shared Repository
[SCM] Samba Shared Repository - branch master updated
The branch, master has been updated
via 67aa53a Be a little clearer about when and when not to set this
option.
via 52602e4 Fix inspired by work done by David Disseldorp for bug #8040
- smbclient segfaults when a Cyrillic netbios name or workgroup is configured.
from fbe19ba s3: Fix Coverity ID 2143: DEADCODE
http://gitweb.samba.org/?p=samba.git;a=shortlog;h=master
- Log -
commit 67aa53a1e17e7d94ccbc244476fa6ce7b6b968d2
Author: Jeremy Allison j...@samba.org
Date: Mon Mar 28 14:12:36 2011 -0700
Be a little clearer about when and when not to set this option.
Autobuild-User: Jeremy Allison j...@samba.org
Autobuild-Date: Mon Mar 28 23:59:47 CEST 2011 on sn-devel-104
commit 52602e4f5ad0f7c3cdb4a50dfe32d0b8ad49b6e4
Author: Jeremy Allison j...@samba.org
Date: Mon Mar 28 13:26:27 2011 -0700
Fix inspired by work done by David Disseldorp for bug #8040 - smbclient
segfaults when a Cyrillic netbios name or workgroup is configured.
Change msrpc_gen to return NTSTATUS and ensure everywhere this is
used it is correctly checked to return that status.
Jeremy.
---
Summary of changes:
docs-xml/smbdotconf/tuning/strictallocate.xml | 12 ++---
libcli/auth/msrpc_parse.c | 34
libcli/auth/msrpc_parse.h |2 +-
libcli/auth/ntlmssp_server.c | 13 -
libcli/auth/ntlmssp_sign.c| 16 ++--
libcli/auth/smbencrypt.c |6 +++-
source3/libsmb/ntlmssp.c | 14 --
source4/auth/ntlmssp/ntlmssp_client.c | 14 +++---
8 files changed, 81 insertions(+), 30 deletions(-)
Changeset truncated at 500 lines:
diff --git a/docs-xml/smbdotconf/tuning/strictallocate.xml
b/docs-xml/smbdotconf/tuning/strictallocate.xml
index 1855574..900c90f 100644
--- a/docs-xml/smbdotconf/tuning/strictallocate.xml
+++ b/docs-xml/smbdotconf/tuning/strictallocate.xml
@@ -9,10 +9,14 @@
disk storage blocks when a file is extended to the Windows behaviour
of actually forcing the disk system to allocate real storage blocks
when a file is created or extended to be a given size. In UNIX
-terminology this means that Samba will stop creating sparse files.
-This can be slow on some systems. When you work with large files like
-100MB or so you may even run into problems with clients running into
-timeouts./para
+terminology this means that Samba will stop creating sparse files./para
+
+paraThis option is really desgined for file systems that support
+fast allocation of large numbers of blocks such as extent-based file
systems.
+On file systems that don't support extents (most notably ext3) this can
+make Samba slower. When you work with large files over 100MB on file
+systems without extents you may even run into problems with clients
+running into timeouts./para
paraWhen you have an extent based filesystem it's likely that we can make
use of unwritten extents which allows Samba to allocate even large amounts
diff --git a/libcli/auth/msrpc_parse.c b/libcli/auth/msrpc_parse.c
index 1351dfa..bdbba3d 100644
--- a/libcli/auth/msrpc_parse.c
+++ b/libcli/auth/msrpc_parse.c
@@ -40,7 +40,7 @@
d = word (4 bytes)
C = constant ascii string
*/
-bool msrpc_gen(TALLOC_CTX *mem_ctx,
+NTSTATUS msrpc_gen(TALLOC_CTX *mem_ctx,
DATA_BLOB *blob,
const char *format, ...)
{
@@ -57,7 +57,13 @@ bool msrpc_gen(TALLOC_CTX *mem_ctx,
DATA_BLOB *pointers;
pointers = talloc_array(mem_ctx, DATA_BLOB, strlen(format));
+ if (!pointers) {
+ return NT_STATUS_NO_MEMORY;
+ }
intargs = talloc_array(pointers, int, strlen(format));
+ if (!intargs) {
+ return NT_STATUS_NO_MEMORY;
+ }
/* first scan the format to work out the header and body size */
va_start(ap, format);
@@ -72,7 +78,7 @@ bool msrpc_gen(TALLOC_CTX *mem_ctx,
s, n);
if (!ret) {
va_end(ap);
- return false;
+ return map_nt_error_from_unix(errno);
}
pointers[i].length = n;
pointers[i].length -= 2;
@@ -86,7 +92,7 @@ bool msrpc_gen(TALLOC_CTX *mem_ctx,
s, n);
if (!ret) {
va_end(ap);
- return false;
+ return map_nt_error_from_unix(errno);
}
pointers[i].length = n;
pointers[i].length -= 1;
@@ -102,7 +108,7 @@ bool
[SCM] Samba Shared Repository - branch v3-6-test updated
The branch, v3-6-test has been updated
via 26b26d9 Be a little clearer about when and when not to set this
option.
via 1cc80a1 Fix inspired by work done by David Disseldorp for bug #8040
- smbclient segfaults when a Cyrillic netbios name or workgroup is configured.
from 6521e17 s3: Fix Coverity ID 2143: DEADCODE
http://gitweb.samba.org/?p=samba.git;a=shortlog;h=v3-6-test
- Log -
commit 26b26d975bebe81c47e243b4b0e186ccd5174deb
Author: Jeremy Allison j...@samba.org
Date: Mon Mar 28 14:12:36 2011 -0700
Be a little clearer about when and when not to set this option.
Autobuild-User: Jeremy Allison j...@samba.org
Autobuild-Date: Mon Mar 28 23:59:47 CEST 2011 on sn-devel-104
(cherry picked from commit 67aa53a1e17e7d94ccbc244476fa6ce7b6b968d2)
commit 1cc80a126bbaed381df59a038835ee5ef7ef7dcc
Author: Jeremy Allison j...@samba.org
Date: Mon Mar 28 13:26:27 2011 -0700
Fix inspired by work done by David Disseldorp for bug #8040 - smbclient
segfaults when a Cyrillic netbios name or workgroup is configured.
Change msrpc_gen to return NTSTATUS and ensure everywhere this is
used it is correctly checked to return that status.
Jeremy.
(cherry picked from commit 52602e4f5ad0f7c3cdb4a50dfe32d0b8ad49b6e4)
---
Summary of changes:
docs-xml/smbdotconf/tuning/strictallocate.xml | 12 ++---
libcli/auth/msrpc_parse.c | 34
libcli/auth/msrpc_parse.h |2 +-
libcli/auth/ntlmssp_server.c | 13 -
libcli/auth/ntlmssp_sign.c| 16 ++--
libcli/auth/smbencrypt.c |6 +++-
source3/libsmb/ntlmssp.c | 14 --
source4/auth/ntlmssp/ntlmssp_client.c | 14 +++---
8 files changed, 81 insertions(+), 30 deletions(-)
Changeset truncated at 500 lines:
diff --git a/docs-xml/smbdotconf/tuning/strictallocate.xml
b/docs-xml/smbdotconf/tuning/strictallocate.xml
index 1855574..900c90f 100644
--- a/docs-xml/smbdotconf/tuning/strictallocate.xml
+++ b/docs-xml/smbdotconf/tuning/strictallocate.xml
@@ -9,10 +9,14 @@
disk storage blocks when a file is extended to the Windows behaviour
of actually forcing the disk system to allocate real storage blocks
when a file is created or extended to be a given size. In UNIX
-terminology this means that Samba will stop creating sparse files.
-This can be slow on some systems. When you work with large files like
-100MB or so you may even run into problems with clients running into
-timeouts./para
+terminology this means that Samba will stop creating sparse files./para
+
+paraThis option is really desgined for file systems that support
+fast allocation of large numbers of blocks such as extent-based file
systems.
+On file systems that don't support extents (most notably ext3) this can
+make Samba slower. When you work with large files over 100MB on file
+systems without extents you may even run into problems with clients
+running into timeouts./para
paraWhen you have an extent based filesystem it's likely that we can make
use of unwritten extents which allows Samba to allocate even large amounts
diff --git a/libcli/auth/msrpc_parse.c b/libcli/auth/msrpc_parse.c
index 7ac6fb5..a676f8e 100644
--- a/libcli/auth/msrpc_parse.c
+++ b/libcli/auth/msrpc_parse.c
@@ -40,7 +40,7 @@
d = word (4 bytes)
C = constant ascii string
*/
-bool msrpc_gen(TALLOC_CTX *mem_ctx,
+NTSTATUS msrpc_gen(TALLOC_CTX *mem_ctx,
DATA_BLOB *blob,
const char *format, ...)
{
@@ -57,7 +57,13 @@ bool msrpc_gen(TALLOC_CTX *mem_ctx,
DATA_BLOB *pointers;
pointers = talloc_array(mem_ctx, DATA_BLOB, strlen(format));
+ if (!pointers) {
+ return NT_STATUS_NO_MEMORY;
+ }
intargs = talloc_array(pointers, int, strlen(format));
+ if (!intargs) {
+ return NT_STATUS_NO_MEMORY;
+ }
/* first scan the format to work out the header and body size */
va_start(ap, format);
@@ -72,7 +78,7 @@ bool msrpc_gen(TALLOC_CTX *mem_ctx,
s, n);
if (!ret) {
va_end(ap);
- return false;
+ return map_nt_error_from_unix(errno);
}
pointers[i].length = n;
pointers[i].length -= 2;
@@ -86,7 +92,7 @@ bool msrpc_gen(TALLOC_CTX *mem_ctx,
s, n);
if (!ret) {
va_end(ap);
- return false;
+ return map_nt_error_from_unix(errno);
[SCM] Samba Shared Repository - branch v3-6-test updated
The branch, v3-6-test has been updated
via 6e5bfb7 s3:dbwrap_ctdb: fix non-locked fetch on persistent db's
causing corruption
from 26b26d9 Be a little clearer about when and when not to set this
option.
http://gitweb.samba.org/?p=samba.git;a=shortlog;h=v3-6-test
- Log -
commit 6e5bfb7816e6d83920c9c6a12ecae18bdcbd448f
Author: Michael Adam ob...@samba.org
Date: Fri Mar 25 00:29:42 2011 +0100
s3:dbwrap_ctdb: fix non-locked fetch on persistent db's causing corruption
When doing a non-locking fetch on a record of a persistent db when no
transaction is running, the old behaviour was to fetch locally and
do a ctdb call when the record was not found in the local db.
The call is useless for persistent dbs anyway since they are only
written to using transactions and hence kept in sync, but it is
also harmful, because a ctdb call will bump the record RSN when it
does actually migrate the record from one node to another.
Recently, ctdb has been changed to make all calls do a migration.
This uncovered the client misbehaviour for persistent dbs, because
now _each_ non-locking fetch will render the persistent db inconsistent:
A subsequent transaction which touches the record in question will
fail because the RSNs are out of sync.
This patch fixes this old bug.
Autobuild-User: Michael Adam ob...@samba.org
Autobuild-Date: Fri Mar 25 01:26:32 CET 2011 on sn-devel-104
---
Summary of changes:
source3/lib/dbwrap_ctdb.c | 36 ++--
1 files changed, 34 insertions(+), 2 deletions(-)
Changeset truncated at 500 lines:
diff --git a/source3/lib/dbwrap_ctdb.c b/source3/lib/dbwrap_ctdb.c
index 67425dc..46ec6de 100644
--- a/source3/lib/dbwrap_ctdb.c
+++ b/source3/lib/dbwrap_ctdb.c
@@ -474,6 +474,34 @@ static int db_ctdb_transaction_fetch(struct db_ctdb_ctx
*db,
return 0;
}
+/**
+ * Fetch a record from a persistent database
+ * without record locking and without an active transaction.
+ *
+ * This just fetches from the local database copy.
+ * Since the databases are kept in syc cluster-wide,
+ * there is no point in doing a ctdb call to fetch the
+ * record from the lmaster. It does even harm since migration
+ * of records bump their RSN and hence render the persistent
+ * database inconsistent.
+ */
+static int db_ctdb_fetch_persistent(struct db_ctdb_ctx *db,
+ TALLOC_CTX *mem_ctx,
+ TDB_DATA key, TDB_DATA *data)
+{
+ NTSTATUS status;
+ bool found;
+
+ status = db_ctdb_ltdb_fetch(db, key, NULL, mem_ctx, data);
+
+ if (NT_STATUS_EQUAL(status, NT_STATUS_NOT_FOUND)) {
+ *data = tdb_null;
+ } else if (!NT_STATUS_IS_OK(status)) {
+ return -1;
+ }
+
+ return 0;
+}
static NTSTATUS db_ctdb_store_transaction(struct db_record *rec, TDB_DATA
data, int flag);
static NTSTATUS db_ctdb_delete_transaction(struct db_record *rec);
@@ -1075,6 +1103,10 @@ static int db_ctdb_fetch(struct db_context *db,
TALLOC_CTX *mem_ctx,
return db_ctdb_transaction_fetch(ctx, mem_ctx, key, data);
}
+ if (db-persistent) {
+ return db_ctdb_fetch_persistent(ctx, mem_ctx, key, data);
+ }
+
/* try a direct fetch */
ctdb_data = tdb_fetch(ctx-wtdb-tdb, key);
@@ -1085,8 +1117,8 @@ static int db_ctdb_fetch(struct db_context *db,
TALLOC_CTX *mem_ctx,
*/
if ((ctdb_data.dptr != NULL)
(ctdb_data.dsize = sizeof(struct ctdb_ltdb_header))
- (db-persistent ||
-((struct ctdb_ltdb_header *)ctdb_data.dptr)-dmaster ==
get_my_vnn())) {
+ ((struct ctdb_ltdb_header *)ctdb_data.dptr)-dmaster ==
get_my_vnn())
+ {
/* we are the dmaster - avoid the ctdb protocol op */
data-dsize = ctdb_data.dsize - sizeof(struct ctdb_ltdb_header);
--
Samba Shared Repository
[SCM] Samba Shared Repository - branch master updated
The branch, master has been updated via 2c0d802 s3-selftest Fix test_smbclient_auth.sh via 29fabfd s3-selftest Allow LM passwords and turn of NTLMv2 for security=share test via c8bc708 s3-selftest Add tests for security=server via 2839391 s3-selftest unconditionaly include subunit.sh via 53ddac3 wintest New snapshot for my wintest VMs via ef44794 s4-fsmo: say which role is being transferred via 3600f2e s4-fsmo: samba-tool fsmo transfer now gets full error code via b32f155 s4-dsdb: perform FSMO transfers asynchronously via 358892e s4-fsmo: make rootDSE modify for FSMO transfer async via f4e3ccf s4-fsmo: nicer error messages on failed FSMO transfers via 07b6f75 s4-drs: default hostname in samba-tool drs command via fdd9540 s4-dsdb: only allow administrators to trigger FSMO role transfers via f4d5814 s4-fsmo: samba-tool fsmo takes a URL, not a hostname via 9eb9b11 wintest: added a ipconfig /flushdns via 22cbd04 wintest: fixed syntax highlighting with emacs via b85bb3e wintest: ensure we startup the w2k3 DC VM from 67aa53a Be a little clearer about when and when not to set this option. http://gitweb.samba.org/?p=samba.git;a=shortlog;h=master - Log - commit 2c0d80259ad695160b5711db9439c68b5f7ce2d9 Author: Andrew Bartlett abart...@samba.org Date: Mon Mar 28 22:06:40 2011 +1100 s3-selftest Fix test_smbclient_auth.sh The -N in the command line meant that all the logins were as the guest, not as the user specified. Andrew Bartlett Autobuild-User: Andrew Bartlett abart...@samba.org Autobuild-Date: Tue Mar 29 00:47:50 CEST 2011 on sn-devel-104 commit 29fabfd3eabcb2abcebfa4788e734bac4f25b8c8 Author: Andrew Bartlett abart...@samba.org Date: Mon Mar 28 22:20:23 2011 +1100 s3-selftest Allow LM passwords and turn of NTLMv2 for security=share test commit c8bc7089f589e33a624183ae63c1cb1b3d652c7c Author: Andrew Bartlett abart...@samba.org Date: Mon Mar 28 20:42:55 2011 +1100 s3-selftest Add tests for security=server Andrew Bartlett commit 2839391c7deac3436046807e4238bb9e5802530b Author: Andrew Bartlett abart...@samba.org Date: Mon Mar 28 22:05:27 2011 +1100 s3-selftest unconditionaly include subunit.sh we no longer . this file into other shell scripts, so we don't need this check any more. Andrew Bartlett commit 53ddac3f27e85f8a605785145a9c9584a85673b2 Author: Andrew Bartlett abart...@samba.org Date: Mon Mar 28 20:44:10 2011 +1100 wintest New snapshot for my wintest VMs commit ef44794097ea7e3eaf4e93d6dca0a9706bd2ae97 Author: Andrew Tridgell tri...@samba.org Date: Mon Mar 28 16:48:46 2011 +1100 s4-fsmo: say which role is being transferred this is particularly useful for samba-tool fsmo transfer --role=all commit 3600f2e250b7e7605155402a4390066ea7b08fdd Author: Andrew Tridgell tri...@samba.org Date: Mon Mar 28 16:45:22 2011 +1100 s4-fsmo: samba-tool fsmo transfer now gets full error code We now wait for the transfer to succeed or fail Pair-Programmed-With: Andrew Bartlett abart...@samba.org commit b32f155bae384bd3ae1d9ba9f246a0eca18a2511 Author: Andrew Tridgell tri...@samba.org Date: Mon Mar 28 16:44:32 2011 +1100 s4-dsdb: perform FSMO transfers asynchronously this gives the administrator a proper error message on the command line Pair-Programmed-With: Andrew Bartlett abart...@samba.org commit 358892e8365d052d7b9300737a4c1dc92b26cc0c Author: Andrew Tridgell tri...@samba.org Date: Mon Mar 28 16:20:47 2011 +1100 s4-fsmo: make rootDSE modify for FSMO transfer async this gives the ldap client the error code from the transfer Pair-Programmed-With: Andrew Bartlett abart...@samba.org commit f4e3ccfe9e09904e548fe715dd784ad5d7f68b0d Author: Andrew Tridgell tri...@samba.org Date: Mon Mar 28 15:32:41 2011 +1100 s4-fsmo: nicer error messages on failed FSMO transfers Pair-Programmed-With: Andrew Bartlett abart...@samba.org commit 07b6f75bc1eb6d4554b29f41ed1fd623bd4f4bea Author: Andrew Tridgell tri...@samba.org Date: Mon Mar 28 15:32:15 2011 +1100 s4-drs: default hostname in samba-tool drs command default to our hostname Pair-Programmed-With: Andrew Bartlett abart...@samba.org commit fdd9540187f019df0560eefe0805700df7d91138 Author: Andrew Tridgell tri...@samba.org Date: Mon Mar 28 14:41:36 2011 +1100 s4-dsdb: only allow administrators to trigger FSMO role transfers Pair-Programmed-With: Andrew Bartlett abart...@samba.org commit f4d581468c467135553bba657a40ca1eb6ccc11c Author: Andrew Tridgell tri...@samba.org Date: Mon Mar 28 14:17:45 2011 +1100 s4-fsmo: samba-tool fsmo takes a URL, not a hostname better to call the option --url Pair-Programmed-With:
[SCM] Samba Shared Repository - branch master updated
The branch, master has been updated via e068144 s3:rpc_client: fix argument order of call to lsa_open_policy2 in rpccli_lsa_open_policy2 from 2c0d802 s3-selftest Fix test_smbclient_auth.sh http://gitweb.samba.org/?p=samba.git;a=shortlog;h=master - Log - commit e0681441afff8876b651d754eefb1d84470e8640 Author: Michael Adam ob...@samba.org Date: Tue Mar 29 00:01:40 2011 +0200 s3:rpc_client: fix argument order of call to lsa_open_policy2 in rpccli_lsa_open_policy2 Autobuild-User: Michael Adam ob...@samba.org Autobuild-Date: Tue Mar 29 01:34:28 CEST 2011 on sn-devel-104 --- Summary of changes: source3/rpc_client/cli_lsarpc.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) Changeset truncated at 500 lines: diff --git a/source3/rpc_client/cli_lsarpc.c b/source3/rpc_client/cli_lsarpc.c index 88534e6..be49923 100644 --- a/source3/rpc_client/cli_lsarpc.c +++ b/source3/rpc_client/cli_lsarpc.c @@ -145,8 +145,8 @@ NTSTATUS rpccli_lsa_open_policy2(struct rpc_pipe_client *cli, NTSTATUS result = NT_STATUS_UNSUCCESSFUL; status = dcerpc_lsa_open_policy2(cli-binding_handle, -cli-srv_name_slash, mem_ctx, +cli-srv_name_slash, sec_qos, des_access, pol, -- Samba Shared Repository
[SCM] Samba Shared Repository - branch v3-6-test updated
The branch, v3-6-test has been updated
via 1aaf83a s3-selftest Fix test_smbclient_auth.sh
via b444bbc s3-selftest Allow LM passwords and turn of NTLMv2 for
security=share test (cherry picked from commit
29fabfd3eabcb2abcebfa4788e734bac4f25b8c8)
via 13a7077 s3-selftest Add tests for security=server
from 6e5bfb7 s3:dbwrap_ctdb: fix non-locked fetch on persistent db's
causing corruption
http://gitweb.samba.org/?p=samba.git;a=shortlog;h=v3-6-test
- Log -
commit 1aaf83a48d6a4116c6c6e93af4dd5f505b469985
Author: Andrew Bartlett abart...@samba.org
Date: Mon Mar 28 22:06:40 2011 +1100
s3-selftest Fix test_smbclient_auth.sh
The -N in the command line meant that all the logins were as the
guest, not as the user specified.
Andrew Bartlett
Autobuild-User: Andrew Bartlett abart...@samba.org
Autobuild-Date: Tue Mar 29 00:47:50 CEST 2011 on sn-devel-104
(cherry picked from commit 2c0d80259ad695160b5711db9439c68b5f7ce2d9)
commit b444bbcdbfd0b01ab0ca1f18cc8e93783e6cde5b
Author: Andrew Bartlett abart...@samba.org
Date: Mon Mar 28 22:20:23 2011 +1100
s3-selftest Allow LM passwords and turn of NTLMv2 for security=share test
(cherry picked from commit 29fabfd3eabcb2abcebfa4788e734bac4f25b8c8)
commit 13a7077dbfa5669ca90268326c0b4b8ea82b3eae
Author: Andrew Bartlett abart...@samba.org
Date: Mon Mar 28 20:42:55 2011 +1100
s3-selftest Add tests for security=server
Andrew Bartlett
(cherry picked from commit c8bc7089f589e33a624183ae63c1cb1b3d652c7c)
---
Summary of changes:
selftest/target/Samba3.pm | 39 +++
source3/script/tests/test_smbclient_auth.sh | 20 +
source3/selftest/tests.py |7 +++-
3 files changed, 52 insertions(+), 14 deletions(-)
Changeset truncated at 500 lines:
diff --git a/selftest/target/Samba3.pm b/selftest/target/Samba3.pm
index 6a18f27..38148eb 100644
--- a/selftest/target/Samba3.pm
+++ b/selftest/target/Samba3.pm
@@ -102,6 +102,11 @@ sub setup_env($$$)
return $self-setup_dc($path/dc);
} elsif ($envname eq secshare) {
return $self-setup_secshare($path/secshare);
+ } elsif ($envname eq secserver) {
+ if (not defined($self-{vars}-{dc})) {
+ $self-setup_dc($path/dc);
+ }
+ return $self-setup_secserver($path/secserver,
$self-{vars}-{dc});
} elsif ($envname eq member) {
if (not defined($self-{vars}-{dc})) {
$self-setup_dc($path/dc);
@@ -216,6 +221,40 @@ sub setup_secshare($$)
return $vars;
}
+sub setup_secserver($$$)
+{
+ my ($self, $prefix, $dcvars) = @_;
+
+ print PROVISIONING server with security=server...;
+
+ my $secserver_options =
+ security = server
+password server = $dcvars-{SERVER_IP}
+;
+
+ my $ret = $self-provision($prefix,
+ LOCALSERVER5,
+ 5,
+ localserver5pass,
+ $secserver_options);
+
+ $ret or die(Unable to provision);
+
+ $self-check_or_start($ret,
+ ($ENV{SMBD_MAXTIME} or 2700),
+ yes, no, yes);
+
+ $self-wait_for_start($ret);
+
+ $ret-{DC_SERVER} = $dcvars-{SERVER};
+ $ret-{DC_SERVER_IP} = $dcvars-{SERVER_IP};
+ $ret-{DC_NETBIOSNAME} = $dcvars-{NETBIOSNAME};
+ $ret-{DC_USERNAME} = $dcvars-{USERNAME};
+ $ret-{DC_PASSWORD} = $dcvars-{PASSWORD};
+
+ return $ret;
+}
+
sub stop_sig_term($$) {
my ($self, $pid) = @_;
kill(USR1, $pid) or kill(ALRM, $pid) or warn(Unable to kill $pid:
$!);
diff --git a/source3/script/tests/test_smbclient_auth.sh
b/source3/script/tests/test_smbclient_auth.sh
index 7ee60b0..fb1212f 100755
--- a/source3/script/tests/test_smbclient_auth.sh
+++ b/source3/script/tests/test_smbclient_auth.sh
@@ -22,15 +22,11 @@ incdir=`dirname $0`/../../../testprogs/blackbox
. $incdir/subunit.sh
}
-failed=0
-
-testit smbclient //$SERVER/guestonly $SMBCLIENT //$SERVER/guestonly
$CONFIGURATION -U$USERNAME%$PASSWORD -I $SERVER_IP -N -p 139 -c quit $ADDARGS||
failed=`expr $failed + 1`
-testit smbclient //$SERVER/guestonly as anon $SMBCLIENT //$SERVER/guestonly
$CONFIGURATION -U% -I $SERVER_IP -N -p 139 -c quit $ADDARGS|| failed=`expr
$failed + 1`
-testit smbclient //$SERVER/tmpguest $SMBCLIENT //$SERVER/tmpguest
$CONFIGURATION -U$USERNAME%$PASSWORD -I $SERVER_IP -N -p 139 -c quit $ADDARGS||
failed=`expr $failed + 1`
-testit smbclient //$SERVER/tmpguest as anon $SMBCLIENT //$SERVER/tmpguest
$CONFIGURATION -U% -I $SERVER_IP -N -p 139 -c quit $ADDARGS|| failed=`expr
$failed + 1`
-testit smbclient
[SCM] Samba Shared Repository - branch master updated
The branch, master has been updated
via bae14fb Remove two unused labels.
via db966ef
=?UTF-8?q?alpha=5Fstrcpy()=20is=20a=20utility=20function=20which=20reportedly:
from e068144 s3:rpc_client: fix argument order of call to
lsa_open_policy2 in rpccli_lsa_open_policy2
http://gitweb.samba.org/?p=samba.git;a=shortlog;h=master
- Log -
commit bae14fba520e6c89b162cc42b26f22144821b0a4
Author: Jeremy Allison j...@samba.org
Date: Mon Mar 28 16:07:13 2011 -0700
Remove two unused labels.
Autobuild-User: Jeremy Allison j...@samba.org
Autobuild-Date: Tue Mar 29 02:23:02 CEST 2011 on sn-devel-104
commit db966efe8a4cc065f4e998bbed8a9d2c0ec2c976
Author: David Disseldorp dd...@suse.de
Date: Mon Mar 28 15:59:32 2011 -0700
=?UTF-8?q?alpha=5Fstrcpy()=20is=20a=20utility=20function=20which=20reportedly:
=20Strips=20out=20all=20but=20'a-Z0-9'=20and=20the=20character=20in=20other=5Fsafe=5Fchars=20and
=20replaces=20with=20'=5F'.
=20This=20statement=20does=20not=20currently=20hold=20true=20in=20all=20cases=20(e.g.=20src=20=3D
=20=D0=A2=D0=90=D0=9D=D0=A6=D0=95=D0=92=D0=90=D0=A2=D0=AC).?=
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
---
Summary of changes:
source3/lib/util_str.c | 12 +---
source3/winbindd/winbindd_samr.c |2 --
2 files changed, 9 insertions(+), 5 deletions(-)
Changeset truncated at 500 lines:
diff --git a/source3/lib/util_str.c b/source3/lib/util_str.c
index 1996174..7b50717 100644
--- a/source3/lib/util_str.c
+++ b/source3/lib/util_str.c
@@ -506,7 +506,9 @@ char *safe_strcat_fn(char *dest,
Paranoid strcpy into a buffer of given length (includes terminating
zero. Strips out all but 'a-Z0-9' and the character in other_safe_chars
and replaces with '_'. Deliberately does *NOT* check for multibyte
- characters. Don't change it !
+ characters. Treats src as an array of bytes, not as a multibyte
+ string. Any byte 0x7f is automatically converted to '_'.
+ other_safe_chars must also contain an ascii string (bytes0x7f).
**/
char *alpha_strcpy(char *dest,
@@ -534,8 +536,12 @@ char *alpha_strcpy(char *dest,
for(i = 0; i len; i++) {
int val = (src[i] 0xff);
- if (isupper_ascii(val) || islower_ascii(val) ||
- isdigit(val) || strchr_m(other_safe_chars, val))
+ if (val 0x7f) {
+ dest[i] = '_';
+ continue;
+ }
+ if (isupper(val) || islower(val) ||
+ isdigit(val) || strchr(other_safe_chars, val))
dest[i] = src[i];
else
dest[i] = '_';
diff --git a/source3/winbindd/winbindd_samr.c b/source3/winbindd/winbindd_samr.c
index d775cd7..40f0100 100644
--- a/source3/winbindd/winbindd_samr.c
+++ b/source3/winbindd/winbindd_samr.c
@@ -68,7 +68,6 @@ static NTSTATUS open_internal_samr_pipe(TALLOC_CTX *mem_ctx,
return status;
}
-done:
if (samr_pipe) {
*samr_pipe = cli;
}
@@ -146,7 +145,6 @@ static NTSTATUS open_internal_lsa_pipe(TALLOC_CTX *mem_ctx,
return status;
}
-done:
if (lsa_pipe) {
*lsa_pipe = cli;
}
--
Samba Shared Repository
[SCM] Samba Shared Repository - branch v3-6-test updated
The branch, v3-6-test has been updated
via 0847421 Remove two unused labels.
via e37a5de
=?UTF-8?q?alpha=5Fstrcpy()=20is=20a=20utility=20function=20which=20reportedly:
from 1aaf83a s3-selftest Fix test_smbclient_auth.sh
http://gitweb.samba.org/?p=samba.git;a=shortlog;h=v3-6-test
- Log -
commit 08474212abe5aa761ad8c1f90635275586aad16b
Author: Jeremy Allison j...@samba.org
Date: Mon Mar 28 16:07:13 2011 -0700
Remove two unused labels.
Autobuild-User: Jeremy Allison j...@samba.org
Autobuild-Date: Tue Mar 29 02:23:02 CEST 2011 on sn-devel-104
(cherry picked from commit bae14fba520e6c89b162cc42b26f22144821b0a4)
commit e37a5de40098ebe1006a75daab64e9a820e726f4
Author: David Disseldorp dd...@suse.de
Date: Mon Mar 28 15:59:32 2011 -0700
=?UTF-8?q?alpha=5Fstrcpy()=20is=20a=20utility=20function=20which=20reportedly:
=20Strips=20out=20all=20but=20'a-Z0-9'=20and=20the=20character=20in=20other=5Fsafe=5Fchars=20and
=20replaces=20with=20'=5F'.
=20This=20statement=20does=20not=20currently=20hold=20true=20in=20all=20cases=20(e.g.=20src=20=3D
=20=D0=A2=D0=90=D0=9D=D0=A6=D0=95=D0=92=D0=90=D0=A2=D0=AC).?=
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
(cherry picked from commit db966efe8a4cc065f4e998bbed8a9d2c0ec2c976)
---
Summary of changes:
source3/lib/util_str.c | 12 +---
source3/winbindd/winbindd_samr.c |2 --
2 files changed, 9 insertions(+), 5 deletions(-)
Changeset truncated at 500 lines:
diff --git a/source3/lib/util_str.c b/source3/lib/util_str.c
index 6a17297..cabdf9e 100644
--- a/source3/lib/util_str.c
+++ b/source3/lib/util_str.c
@@ -586,7 +586,9 @@ char *safe_strcat_fn(const char *fn,
Paranoid strcpy into a buffer of given length (includes terminating
zero. Strips out all but 'a-Z0-9' and the character in other_safe_chars
and replaces with '_'. Deliberately does *NOT* check for multibyte
- characters. Don't change it !
+ characters. Treats src as an array of bytes, not as a multibyte
+ string. Any byte 0x7f is automatically converted to '_'.
+ other_safe_chars must also contain an ascii string (bytes0x7f).
**/
char *alpha_strcpy_fn(const char *fn,
@@ -622,8 +624,12 @@ char *alpha_strcpy_fn(const char *fn,
for(i = 0; i len; i++) {
int val = (src[i] 0xff);
- if (isupper_ascii(val) || islower_ascii(val) ||
- isdigit(val) || strchr_m(other_safe_chars, val))
+ if (val 0x7f) {
+ dest[i] = '_';
+ continue;
+ }
+ if (isupper(val) || islower(val) ||
+ isdigit(val) || strchr(other_safe_chars, val))
dest[i] = src[i];
else
dest[i] = '_';
diff --git a/source3/winbindd/winbindd_samr.c b/source3/winbindd/winbindd_samr.c
index d7411f1..3bc07a9 100644
--- a/source3/winbindd/winbindd_samr.c
+++ b/source3/winbindd/winbindd_samr.c
@@ -68,7 +68,6 @@ static NTSTATUS open_internal_samr_pipe(TALLOC_CTX *mem_ctx,
return status;
}
-done:
if (samr_pipe) {
*samr_pipe = cli;
}
@@ -146,7 +145,6 @@ static NTSTATUS open_internal_lsa_pipe(TALLOC_CTX *mem_ctx,
return status;
}
-done:
if (lsa_pipe) {
*lsa_pipe = cli;
}
--
Samba Shared Repository
autobuild: intermittent test failure detected
The autobuild test system has detected an intermittent failing test in the current master tree. The autobuild log of the failure is available here: http://git.samba.org/autobuild.flakey/2011-03-29-0615/flakey.log The samba3 build logs are available here: http://git.samba.org/autobuild.flakey/2011-03-29-0615/samba3.stderr http://git.samba.org/autobuild.flakey/2011-03-29-0615/samba3.stdout The source4 build logs are available here: http://git.samba.org/autobuild.flakey/2011-03-29-0615/samba4.stderr http://git.samba.org/autobuild.flakey/2011-03-29-0615/samba4.stdout The top commit at the time of the failure was: commit bae14fba520e6c89b162cc42b26f22144821b0a4 Author: Jeremy Allison j...@samba.org Date: Mon Mar 28 16:07:13 2011 -0700 Remove two unused labels. Autobuild-User: Jeremy Allison j...@samba.org Autobuild-Date: Tue Mar 29 02:23:02 CEST 2011 on sn-devel-104
[SCM] Samba Shared Repository - branch master updated
The branch, master has been updated
via af31bf6 debug: ignore debug_set_logfile() with a blank string
via 3351897 s4-cmdline: moved loadparm init after fault setup
via 77cc161 s4-param: set a default logfile
via 8d2d0ef lib: removed a spurios declaration of 'logfile'
from bae14fb Remove two unused labels.
http://gitweb.samba.org/?p=samba.git;a=shortlog;h=master
- Log -
commit af31bf6bf5ef3af6eaf87ebe2f9f5903698c22db
Author: Andrew Tridgell tri...@samba.org
Date: Tue Mar 29 14:41:58 2011 +1100
debug: ignore debug_set_logfile() with a blank string
Pair-Programmed-With: Andrew Bartlett abart...@samba.org
Autobuild-User: Andrew Tridgell tri...@samba.org
Autobuild-Date: Tue Mar 29 07:03:58 CEST 2011 on sn-devel-104
commit 335189792448a209f1f654c6173f359f17ae7fb1
Author: Andrew Tridgell tri...@samba.org
Date: Tue Mar 29 14:30:24 2011 +1100
s4-cmdline: moved loadparm init after fault setup
Pair-Programmed-With: Andrew Bartlett abart...@samba.org
commit 77cc1610e0b03e013ac478e8b9b874e73ac2e09a
Author: Andrew Tridgell tri...@samba.org
Date: Tue Mar 29 14:29:54 2011 +1100
s4-param: set a default logfile
setup a logfile for when one is not specified in smb.conf
Pair-Programmed-With: Andrew Bartlett abart...@samba.org
commit 8d2d0ef0eb506f2be960f4b3abcbc4ae2a3730e7
Author: Andrew Tridgell tri...@samba.org
Date: Tue Mar 29 14:29:22 2011 +1100
lib: removed a spurios declaration of 'logfile'
we don't have a global logfile variable any more
Pair-Programmed-With: Andrew Bartlett abart...@samba.org
---
Summary of changes:
lib/util/debug.c |6 +-
lib/util/util.h |1 -
source4/lib/cmdline/popt_common.c |3 +--
source4/param/loadparm.c |5 +
4 files changed, 11 insertions(+), 4 deletions(-)
Changeset truncated at 500 lines:
diff --git a/lib/util/debug.c b/lib/util/debug.c
index c7ba19e..2ff7cb2 100644
--- a/lib/util/debug.c
+++ b/lib/util/debug.c
@@ -493,6 +493,10 @@ void setup_logging(const char *prog_name, enum
debug_logtype new_logtype)
void debug_set_logfile(const char *name)
{
+ if (name == NULL || *name == 0) {
+ /* this copes with calls when smb.conf is not loaded yet */
+ return;
+ }
TALLOC_FREE(state.debugf);
state.debugf = talloc_strdup(NULL, name);
}
@@ -564,7 +568,7 @@ bool reopen_logs_internal(void)
if (new_fd == -1) {
log_overflow = true;
- DEBUG(0, (Unable to open new log file %s: %s\n, state.debugf,
strerror(errno)));
+ DEBUG(0, (Unable to open new log file '%s': %s\n,
state.debugf, strerror(errno)));
log_overflow = false;
ret = false;
} else {
diff --git a/lib/util/util.h b/lib/util/util.h
index 58e6ffd..48d6566 100644
--- a/lib/util/util.h
+++ b/lib/util/util.h
@@ -34,7 +34,6 @@
struct smbsrv_tcon;
-extern const char *logfile;
extern const char *panic_action;
#include lib/util/time.h
diff --git a/source4/lib/cmdline/popt_common.c
b/source4/lib/cmdline/popt_common.c
index afc8742..16c6a1b 100644
--- a/source4/lib/cmdline/popt_common.c
+++ b/source4/lib/cmdline/popt_common.c
@@ -83,8 +83,6 @@ static void popt_samba_callback(poptContext con,
pname++;
if (reason == POPT_CALLBACK_REASON_PRE) {
- cmdline_lp_ctx = loadparm_init_global(false);
-
/* Hook for 'almost the first thing to do in a samba program'
here */
/* setup for panics */
fault_setup();
@@ -94,6 +92,7 @@ static void popt_samba_callback(poptContext con,
talloc_set_log_fn(popt_s4_talloc_log_fn);
talloc_set_abort_fn(smb_panic);
+ cmdline_lp_ctx = loadparm_init_global(false);
return;
}
diff --git a/source4/param/loadparm.c b/source4/param/loadparm.c
index f69dfd1..93158f2 100644
--- a/source4/param/loadparm.c
+++ b/source4/param/loadparm.c
@@ -650,6 +650,7 @@ FN_GLOBAL_INTEGER(krb5_port, krb5_port)
FN_GLOBAL_INTEGER(kpasswd_port, kpasswd_port)
FN_GLOBAL_INTEGER(web_port, web_port)
FN_GLOBAL_BOOL(tls_enabled, tls_enabled)
+FN_GLOBAL_STRING(logfile, logfile)
FN_GLOBAL_STRING(share_backend, szShareBackend)
FN_GLOBAL_STRING(sam_url, szSAM_URL)
FN_GLOBAL_STRING(idmap_url, szIDMAP_URL)
@@ -2326,6 +2327,7 @@ struct loadparm_context *loadparm_init(TALLOC_CTX
*mem_ctx)
char *myname;
struct loadparm_context *lp_ctx;
struct parmlist_entry *parm;
+ char *logfile;
lp_ctx = talloc_zero(mem_ctx, struct loadparm_context);
if (lp_ctx == NULL)
@@ -2365,6 +2367,9 @@ struct loadparm_context *loadparm_init(TALLOC_CTX
*mem_ctx)
}
}
[SCM] Samba Shared Repository - branch v3-6-test updated
The branch, v3-6-test has been updated via 0be5b24 s3:rpc_client: fix argument order of call to lsa_open_policy2 in rpccli_lsa_open_policy2 from 0847421 Remove two unused labels. http://gitweb.samba.org/?p=samba.git;a=shortlog;h=v3-6-test - Log - commit 0be5b24c7445c0786d38a9583e48e5765d5da829 Author: Michael Adam ob...@samba.org Date: Tue Mar 29 00:01:40 2011 +0200 s3:rpc_client: fix argument order of call to lsa_open_policy2 in rpccli_lsa_open_policy2 Autobuild-User: Michael Adam ob...@samba.org Autobuild-Date: Tue Mar 29 01:34:28 CEST 2011 on sn-devel-104 --- Summary of changes: source3/rpc_client/cli_lsarpc.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) Changeset truncated at 500 lines: diff --git a/source3/rpc_client/cli_lsarpc.c b/source3/rpc_client/cli_lsarpc.c index 88534e6..be49923 100644 --- a/source3/rpc_client/cli_lsarpc.c +++ b/source3/rpc_client/cli_lsarpc.c @@ -145,8 +145,8 @@ NTSTATUS rpccli_lsa_open_policy2(struct rpc_pipe_client *cli, NTSTATUS result = NT_STATUS_UNSUCCESSFUL; status = dcerpc_lsa_open_policy2(cli-binding_handle, -cli-srv_name_slash, mem_ctx, +cli-srv_name_slash, sec_qos, des_access, pol, -- Samba Shared Repository
[SCM] CTDB repository - branch 1.2.27 created - ctdb-1.9.1-406-g811f4fa
The branch, 1.2.27 has been created at 811f4fa44a790f741699126a6bd88fd3dc23393a (commit) - Log - commit 811f4fa44a790f741699126a6bd88fd3dc23393a Author: Ronnie Sahlberg sahlberg@lenovo-laptop.(none) Date: Mon Mar 21 14:28:22 2011 +1100 This needs more testing first Revert ctdbd: call tdb_reopen_all() in freeze child. This reverts commit 1e30004f0c63572d721a2c2f53d8a6bccdb5ec45. commit 8b78587848acb685a7a15e52b79c186597ea8852 Author: Ronnie Sahlberg ronniesahlb...@gmail.com Date: Mon Mar 21 13:02:31 2011 +1100 New version 1.2.27 commit 1e30004f0c63572d721a2c2f53d8a6bccdb5ec45 Author: Rusty Russell ru...@rustcorp.com.au Date: Mon Mar 21 13:07:17 2011 +1030 ctdbd: call tdb_reopen_all() in freeze child. In theory, the ctdbd parent shouldn't be holding any locks, but it's a good idea to always call tdb_reopen_all() after a fork(). --- -- CTDB repository
[SCM] CTDB repository - branch foo created - ctdb-1.9.1-403-g24d7910
The branch, foo has been created at 24d7910be90df164255b7181ee2e2a086b04f396 (commit) - Log - --- -- CTDB repository
