[Samba] Connecting to domain authenticated share from non-domain machine

2011-07-07 Thread Robert Horton
Hi,

I've got a domain controller and two file servers (A  B) connected to a
domain using the ldapsam backend. The domain controller and fileserver A
are running Samba 3.5.4 (from RHEL6) and fileserver B is running Samba
3.0.33 (from RHEL5).

Other machines are able to join the domain as expected and between
machines in the domain I am able to connect to shares as expected. The
problem is with connecting to shares from a machine which is not part of
the domain - this works with the Samba 3.0.33 fileserver but not with
the Samba 3.5.4 one. Any ideas why this might be?

I also notice that things like net rpc user produce no output on
machines other than the domain controller - does this indicate a problem
or is it normal?

Thanks,
Rob

-- 
To unsubscribe from this list go to the following URL and read the
instructions:  https://lists.samba.org/mailman/options/samba


Re: [Samba] Problem using smbusers with samba 3.5.8.1 on AIX 5.2 TL11SP1 system

2011-07-07 Thread GALVAN, Jean-Pierre
Hello.
Yes I did.
Here's my smb.conf file (I removed the shared objetcs) :

# Global parameters
[global]
workgroup = Removed
netbios name = AYDAIX05
server string = AYDAIX05 Samba Server %v
security = DOMAIN
encrypt passwords = Yes
password server = Removed
username map = /etc/smbusers
smb passwd file = /etc/smbpasswd
log file = /opt/freeware/log/log.%m
max log size = 50
name resolve order = wins lmhosts bcast
socket options = TCP_NODELAY SO_RCVBUF=8192 SO_SNDBUF=8192
preferred master = No
local master = No
domain master = No
dns proxy = No
wins server = Removed


And here's my smbusers file :

root = jpgalvan


So I'd like to see root home directory for my Windows user jpgalvan

All I see in Windows explorer is jpgalvan home directory

...


-Message d'origine-
De : youngjohn04 [mailto:youngjoh...@163.com] 
Envoyé : mercredi 6 juillet 2011 23:11
À : GALVAN, Jean-Pierre; samba@lists.samba.org
Objet : RE: [Samba] Problem using smbusers with samba 3.5.8.1 on AIX 5.2 
TL11SP1 system

Did you specify username map = option in your smb.conf file?


-Original Message-
From: samba-boun...@lists.samba.org [mailto:samba-boun...@lists.samba.org]
On Behalf Of GALVAN, Jean-Pierre
Sent: Wednesday, July 06, 2011 10:22 PM
To: samba@lists.samba.org
Subject: [Samba] Problem using smbusers with samba 3.5.8.1 on AIX 5.2
TL11SP1 system

Hello.
I don't know if you're the person who can help me.
I've got a problem with Samba 3.5.8.1 on a AIX 5.3 TL11SP1 machine.

I installed and configured Samba. It worked fine. I use a DOMAIN member 
security mode.
The join into our domain worked well.

Any users from a Windows computer is able to access to the AIX machine.

But the only problem I have is this one :

-  The use of smbusers file is not working : when I try to specify
an other unix account for a windows user, the Windows computer sees the 
original account.

-  = It is just as if smbusers file was not  used ...

Can you help me on this ?
Thank you in advance.
Best regards.
Jean-Pierre GALVAN.

--
To unsubscribe from this list go to the following URL and read the
instructions:  https://lists.samba.org/mailman/options/samba


-- 
To unsubscribe from this list go to the following URL and read the
instructions:  https://lists.samba.org/mailman/options/samba


[SCM] Samba Shared Repository - branch master updated

2011-07-07 Thread Volker Lendecke
The branch, master has been updated
   via  cd83c1d s3:testparm: avoid spurious warnings about dos mode mapping 
and create mask if store dos attributes is set
  from  749d022 s4 provision: Add some of the AD-specific DNS records to 
the directory

http://gitweb.samba.org/?p=samba.git;a=shortlog;h=master


- Log -
commit cd83c1d9582e3252b2c964d77aebf1d241d371a6
Author: Gregor Beck gb...@sernet.de
Date:   Wed Jul 6 15:10:27 2011 +0200

s3:testparm: avoid spurious warnings about dos mode mapping and create mask 
if store dos attributes is set

Autobuild-User: Volker Lendecke vlen...@samba.org
Autobuild-Date: Thu Jul  7 12:49:01 CEST 2011 on sn-devel-104

---

Summary of changes:
 source3/utils/testparm.c |   40 
 1 files changed, 24 insertions(+), 16 deletions(-)


Changeset truncated at 500 lines:

diff --git a/source3/utils/testparm.c b/source3/utils/testparm.c
index 966b61e..9b224d4 100644
--- a/source3/utils/testparm.c
+++ b/source3/utils/testparm.c
@@ -307,25 +307,33 @@ static void do_per_share_checks(int s)
   lp_servicename(s) );
}
 
-   if (lp_map_hidden(s)  !(lp_create_mask(s)  S_IXOTH)) {
-   fprintf(stderr,Invalid combination of parameters for service 
%s. \
-  Map hidden can only work if create mask includes 
octal 01 (S_IXOTH).\n,
-  lp_servicename(s) );
-   }
-   if (lp_map_hidden(s)  (lp_force_create_mode(s)  S_IXOTH)) {
-   fprintf(stderr,Invalid combination of parameters for service 
%s. \
-  Map hidden can only work if force create mode 
excludes octal 01 (S_IXOTH).\n,
-  lp_servicename(s) );
-   }
-   if (lp_map_system(s)  !(lp_create_mask(s)  S_IXGRP)) {
-   fprintf(stderr,Invalid combination of parameters for service 
%s. \
-  Map system can only work if create mask includes 
octal 010 (S_IXGRP).\n,
-  lp_servicename(s) );
-   }
-   if (lp_map_system(s)  (lp_force_create_mode(s)  S_IXGRP)) {
-   fprintf(stderr,Invalid combination of parameters for service 
%s. \
-  Map system can only work if force create mode 
excludes octal 010 (S_IXGRP).\n,
-  lp_servicename(s) );
+   if (!lp_store_dos_attributes(s)  lp_map_hidden(s)
+!(lp_create_mask(s)  S_IXOTH))
+   {
+   fprintf(stderr,Invalid combination of parameters for service 
+   %s. Map hidden can only work if create mask includes 
+   octal 01 (S_IXOTH).\n, lp_servicename(s));
+   }
+   if (!lp_store_dos_attributes(s)  lp_map_hidden(s)
+(lp_force_create_mode(s)  S_IXOTH))
+   {
+   fprintf(stderr,Invalid combination of parameters for service 
+   %s. Map hidden can only work if force create mode 
+   excludes octal 01 (S_IXOTH).\n, lp_servicename(s));
+   }
+   if (!lp_store_dos_attributes(s)  lp_map_system(s)
+!(lp_create_mask(s)  S_IXGRP))
+   {
+   fprintf(stderr,Invalid combination of parameters for service 
+   %s. Map system can only work if create mask includes 
+   octal 010 (S_IXGRP).\n, lp_servicename(s));
+   }
+   if (!lp_store_dos_attributes(s)  lp_map_system(s)
+(lp_force_create_mode(s)  S_IXGRP))
+   {
+   fprintf(stderr,Invalid combination of parameters for service 
+   %s. Map system can only work if force create mode 
+   excludes octal 010 (S_IXGRP).\n, lp_servicename(s));
}
 #ifdef HAVE_CUPS
if (lp_printing(s) == PRINT_CUPS  *(lp_printcommand(s)) != '\0') {


-- 
Samba Shared Repository


[SCM] Samba Shared Repository - branch master updated

2011-07-07 Thread Andreas Schneider
The branch, master has been updated
   via  1caa7a8 s3-waf: Fix linking bugs causing segfaults.
  from  cd83c1d s3:testparm: avoid spurious warnings about dos mode mapping 
and create mask if store dos attributes is set

http://gitweb.samba.org/?p=samba.git;a=shortlog;h=master


- Log -
commit 1caa7a852c972f1e6a88538f6d10baec17842449
Author: Andreas Schneider a...@samba.org
Date:   Thu Jul 7 14:59:51 2011 +0200

s3-waf: Fix linking bugs causing segfaults.

As auth_util.c is linked several times the static variables have
different address on different calls. This leads to segfaults.

Autobuild-User: Andreas Schneider a...@cryptomilk.org
Autobuild-Date: Thu Jul  7 16:50:05 CEST 2011 on sn-devel-104

---

Summary of changes:
 source3/rpc_server/wscript_build |2 +-
 source3/wscript_build|2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)


Changeset truncated at 500 lines:

diff --git a/source3/rpc_server/wscript_build b/source3/rpc_server/wscript_build
index f0ee2d9..c3cf2f9 100644
--- a/source3/rpc_server/wscript_build
+++ b/source3/rpc_server/wscript_build
@@ -27,7 +27,7 @@ bld.SAMBA3_SUBSYSTEM('rpc',
 
 bld.SAMBA3_SUBSYSTEM('RPC_NCACN_NP',
 source='rpc_ncacn_np.c rpc_handles.c rpc_contexts.c',
-deps='auth_sam_reply RPC_PIPE_REGISTER AUTH_COMMON 
npa_tstream')
+deps='auth auth_sam_reply RPC_PIPE_REGISTER npa_tstream')
 
 bld.SAMBA3_SUBSYSTEM('RPC_SERVICE',
 source='rpc_server.c',
diff --git a/source3/wscript_build b/source3/wscript_build
index 5972196..020eaaf 100755
--- a/source3/wscript_build
+++ b/source3/wscript_build
@@ -1129,7 +1129,7 @@ bld.SAMBA3_BINARY('winbindd/winbindd',
  LIBCLI_SAMR libcli_lsa3 LIBRPCCLI_NETLOGON
  RPC_NDR_DSSETUP npa_tstream INIT_NETLOGON
  RPC_NCACN_NP RPC_PIPE_REGISTER RPC_SAMR RPC_LSARPC
- PAM_ERRORS WB_REQTRANS AUTH_COMMON
+ PAM_ERRORS WB_REQTRANS auth
  ''',
  enabled=bld.env.build_winbind,
  install_path='${SBINDIR}',


-- 
Samba Shared Repository


[SCM] Samba Shared Repository - branch master updated

2011-07-07 Thread Volker Lendecke
The branch, master has been updated
   via  eba5d0b s3: Remove a use of cli_errstr
  from  1caa7a8 s3-waf: Fix linking bugs causing segfaults.

http://gitweb.samba.org/?p=samba.git;a=shortlog;h=master


- Log -
commit eba5d0b64162c7250ad4869c3393d0d00aff868c
Author: Volker Lendecke v...@samba.org
Date:   Thu Jul 7 15:42:33 2011 +0200

s3: Remove a use of cli_errstr

Autobuild-User: Volker Lendecke vlen...@samba.org
Autobuild-Date: Thu Jul  7 18:04:26 CEST 2011 on sn-devel-104

---

Summary of changes:
 source3/torture/torture.c |8 ++--
 1 files changed, 6 insertions(+), 2 deletions(-)


Changeset truncated at 500 lines:

diff --git a/source3/torture/torture.c b/source3/torture/torture.c
index 7e2a5e7..64f8bf7 100644
--- a/source3/torture/torture.c
+++ b/source3/torture/torture.c
@@ -642,8 +642,12 @@ static bool rw_torture3(struct cli_state *c, char 
*lockfname)
 
if (procnum == 0)
{
-   if (!NT_STATUS_IS_OK(cli_unlink(c, lockfname, 
FILE_ATTRIBUTE_SYSTEM | FILE_ATTRIBUTE_HIDDEN))) {
-   printf(unlink failed (%s) (normal, this file should 
not exist)\n, cli_errstr(c));
+   status = cli_unlink(
+   c, lockfname,
+   FILE_ATTRIBUTE_SYSTEM | FILE_ATTRIBUTE_HIDDEN);
+   if (!NT_STATUS_IS_OK(status)) {
+   printf(unlink failed (%s) (normal, this file should 
+  not exist)\n, nt_errstr(status));
}
 
status = cli_open(c, lockfname, O_RDWR | O_CREAT | O_EXCL,


-- 
Samba Shared Repository


[SCM] Samba Shared Repository - branch master updated

2011-07-07 Thread Günther Deschner
The branch, master has been updated
   via  e595590 s3-printing: remove tdb migration invalid printer name 
checks
   via  cfc3b6e s3-printing: make sure to first migrate the printers then 
the security descriptor.
   via  5dd8185 s3-printing: fill info2_mask in printer migration
   via  57bbb32 s3-printing: remove spoolss pipe from migration library, 
only using winreg finally.
   via  8f3d5f5 s3-printing: use winreg interface for migration, instead of 
spoolss.
   via  72b1f8b s3-printing: safe a ton of roundtrips by reusing existing 
winreg binding_handles.
   via  0a1ec73 s3-printing: use winreg_internal functions.
   via  ada5380 s3-printing: add winreg_internal functions.
   via  a762eda s3-printing: add winreg_printer_binding_handle and remove 
most of srv_spoolss_util.c.
   via  f2be837 s3-printing: add rpc_client/cli_winreg_spoolss.c
   via  a0fc64a s3-waf: make LIBCLI_SPOOLSS a shared library
   via  43cf3a2 s3-printing: move spoolss_create_default_devmode/secdesc to 
init_spoolss.h
   via  74e4160 s3-printing: move driver_info_ctr_to_info8 to init_spoolss.h
   via  dd5375b s3-printing: move os2 related functions to 
printing/nt_printing_os2.c.
  from  eba5d0b s3: Remove a use of cli_errstr

http://gitweb.samba.org/?p=samba.git;a=shortlog;h=master


- Log -
commit e5955903fdc5ed6f8660b72db0716d4da25c711c
Author: David Disseldorp dd...@suse.de
Date:   Tue Jul 5 15:04:02 2011 +0200

s3-printing: remove tdb migration invalid printer name checks

WERR_INVALID_PRINTER_NAME only needed to be handled when printing tdb
migration used spoolss, with winreg such errors are no longer possible.

Signed-off-by: Günther Deschner g...@samba.org

Autobuild-User: Günther Deschner g...@samba.org
Autobuild-Date: Thu Jul  7 19:15:34 CEST 2011 on sn-devel-104

commit cfc3b6e5f79f253e83dfbd13d47b671deb5801b3
Author: Günther Deschner g...@samba.org
Date:   Tue Jul 5 14:01:40 2011 +0200

s3-printing: make sure to first migrate the printers then the security 
descriptor.

Guenther

Pair-Programmed-With: David Disseldorp dd...@suse.de

commit 5dd8185d852afc3843253c9471326677f8816a77
Author: David Disseldorp dd...@suse.de
Date:   Tue Jul 5 11:34:47 2011 +0200

s3-printing: fill info2_mask in printer migration

Also fix possibly uninitialised status return from
printing_tdb_migrate_printer().

commit 57bbb32c64db1027e2b9ae1aef7f5f3b33ae3882
Author: Günther Deschner g...@samba.org
Date:   Tue Jul 5 02:33:23 2011 +0200

s3-printing: remove spoolss pipe from migration library, only using winreg 
finally.

Guenther

Pair-Programmed-With: David Disseldorp dd...@suse.de

commit 8f3d5f5333a61922c4ea7ff1e1d244978958e857
Author: Günther Deschner g...@samba.org
Date:   Mon Jul 4 19:47:07 2011 +0200

s3-printing: use winreg interface for migration, instead of spoolss.

Guenther

Pair-Programmed-With: David Disseldorp dd...@suse.de

commit 72b1f8be5619ed778c4aa0b967f6a4f34d7e9de8
Author: Günther Deschner g...@samba.org
Date:   Tue Jul 5 00:55:35 2011 +0200

s3-printing: safe a ton of roundtrips by reusing existing winreg 
binding_handles.

Guenther

Pair-Programmed-With: David Disseldorp dd...@suse.de

commit 0a1ec73b965f66977a90fb7febb3b56b52ebab20
Author: Günther Deschner g...@samba.org
Date:   Tue Jul 5 00:16:03 2011 +0200

s3-printing: use winreg_internal functions.

Guenther

Pair-Programmed-With: David Disseldorp dd...@suse.de

commit ada5380d2090179fc57eee66e2b46788f4944db0
Author: Günther Deschner g...@samba.org
Date:   Tue Jul 5 00:16:47 2011 +0200

s3-printing: add winreg_internal functions.

Guenther

Pair-Programmed-With: David Disseldorp dd...@suse.de

commit a762eda519c995214c041170e2615c5c51b2a2b1
Author: Günther Deschner g...@samba.org
Date:   Mon Jul 4 20:09:54 2011 +0200

s3-printing: add winreg_printer_binding_handle and remove most of 
srv_spoolss_util.c.

Guenther

Pair-Programmed-With: David Disseldorp dd...@suse.de

commit f2be8378b92669092f8444df038f769fc9312ff4
Author: Günther Deschner g...@samba.org
Date:   Mon Jul 4 19:47:29 2011 +0200

s3-printing: add rpc_client/cli_winreg_spoolss.c

Guenther

Pair-Programmed-With: David Disseldorp dd...@suse.de

commit a0fc64a88ee6f1f45d4c2b95d6773eccab50ebb4
Author: Günther Deschner g...@samba.org
Date:   Tue Jul 5 11:29:37 2011 +0200

s3-waf: make LIBCLI_SPOOLSS a shared library

Guenther

Pair-Programmed-With: David Disseldorp dd...@suse.de

commit 43cf3a28dc539351da8a316e0e52a8292ec40cc7
Author: Günther Deschner g...@samba.org
Date:   Tue Jul 5 02:15:35 2011 +0200

s3-printing: move spoolss_create_default_devmode/secdesc to init_spoolss.h

Guenther

Pair-Programmed-With: David Disseldorp 

[SCM] Samba Shared Repository - branch master updated

2011-07-07 Thread Stefan Metzmacher
The branch, master has been updated
   via  6db705d libcli: remove duplicate of #define NT_STATUS_NO_SUCH_JOB
   via  80c6541 s3-client: Remove use of cli_errstr()
   via  1142675 s3-libsmb: Remove use of cli_errstr()
   via  98e0f9d s3-torture: run_shortname_test: Remove uses of cli_errstr()
   via  684095b s3-torture: run_simple_posix_open_test: Remove uses of 
cli_errstr()
   via  840a1c7 s3-torture: use nt_errstr() for cli_unlink() error handling
   via  60873a9 s3-torture: introduce check_both_error()
   via  3cdf962 s3:libsmb: finally remove unused cli_state-outbuf
   via  0f00675 s3:libsmb: remove unused clistr_push_fn()
   via  30574a7 s3:libsmb: remove unused clistr_pull_fn()
   via  fc992e7 s3:torture/scanner: use trans2_bytes_push_str() in 
scan_nttrans()
   via  02171ee s3:torture/scanner: use trans2_bytes_push_str() in 
scan_trans2()
   via  072a27f s3:libsmb: use trans2_bytes_push_str() in 
cli_tcon_andx_create() for the plaintext password
   via  5b1ac1b s3:libsmb: use trans2_bytes_push_str() in cli_set_ea_path()
   via  cea9245 s3:libsmb: use trans2_bytes_push_str() in 
cli_dfs_get_referral()
   via  2453164 s3:libsmb: use a talloc_stackframe in cli_dfs_get_referral()
   via  b77becd s3:libsmb: use trans2_bytes_push_str/bytes() in 
cli_list_trans_*()
   via  d921200 s3:libsmb: use clistr_pull_talloc() for short_name in 
interpret_long_filename()
   via  af66c64 s3:libsmb: interpret_long_filename() short_name is always 
UNICODE
   via  eaeeb5c s3:libsmb: add trans2_bytes_push_bytes()
   via  ed99cad s3:libsmb: make trans2_bytes_push_str() non-static
   via  9a350ca s3:utils: avoid cli_nt_error()/cli_errstr() if we already 
have the status
  from  e595590 s3-printing: remove tdb migration invalid printer name 
checks

http://gitweb.samba.org/?p=samba.git;a=shortlog;h=master


- Log -
commit 6db705d6fcc5b58b205afed2a9140716c6323fae
Author: Björn Baumbach b...@sernet.de
Date:   Thu Jul 7 17:43:46 2011 +0200

libcli: remove duplicate of #define NT_STATUS_NO_SUCH_JOB

Signed-off-by: Stefan Metzmacher me...@samba.org

Autobuild-User: Stefan Metzmacher me...@samba.org
Autobuild-Date: Thu Jul  7 20:29:13 CEST 2011 on sn-devel-104

commit 80c65416c17169e487ce17314bdc9975679ec331
Author: Björn Baumbach b...@sernet.de
Date:   Thu Jul 7 17:36:22 2011 +0200

s3-client: Remove use of cli_errstr()

Signed-off-by: Stefan Metzmacher me...@samba.org

commit 11426758d71e59ffe9804d2ebb2f145b4ed398e1
Author: Björn Baumbach b...@sernet.de
Date:   Thu Jul 7 17:18:40 2011 +0200

s3-libsmb: Remove use of cli_errstr()

Signed-off-by: Stefan Metzmacher me...@samba.org

commit 98e0f9d1edb77f07f2f733478e91d0410c020b2e
Author: Björn Baumbach b...@sernet.de
Date:   Thu Jul 7 16:56:05 2011 +0200

s3-torture: run_shortname_test: Remove uses of cli_errstr()

Signed-off-by: Stefan Metzmacher me...@samba.org

commit 684095b0a2e24869b684cc12b92ed7847caf0021
Author: Björn Baumbach b...@sernet.de
Date:   Thu Jul 7 16:49:12 2011 +0200

s3-torture: run_simple_posix_open_test: Remove uses of cli_errstr()

Signed-off-by: Stefan Metzmacher me...@samba.org

commit 840a1c7445377c24bfff04ffa619ea6b4aa83029
Author: Stefan Metzmacher me...@samba.org
Date:   Thu Jul 7 17:56:19 2011 +0200

s3-torture: use nt_errstr() for cli_unlink() error handling

Use nt_errstr() instead of cli_errstr() for error handling on
cli_unlink() calls.

Signed-off-by: Stefan Metzmacher me...@samba.org

commit 60873a9e48115e5bfb3c58cccd078c49d43c56bc
Author: Björn Baumbach b...@sernet.de
Date:   Thu Jul 7 16:27:39 2011 +0200

s3-torture: introduce check_both_error()

Check if the server produced the expected dos or nt error code like
check_error(), but without a cli_state struct.

Signed-off-by: Stefan Metzmacher me...@samba.org

commit 3cdf962d1ea2823e2a5200533685b3a627a00237
Author: Stefan Metzmacher me...@samba.org
Date:   Thu Jul 7 18:16:56 2011 +0200

s3:libsmb: finally remove unused cli_state-outbuf

metze

commit 0f006751ec22a13de898fbafcb6de5a8b8d5ec15
Author: Stefan Metzmacher me...@samba.org
Date:   Thu Jul 7 17:24:32 2011 +0200

s3:libsmb: remove unused clistr_push_fn()

metze

commit 30574a73d8073e1bb0a552fdf8444f17eeebec74
Author: Stefan Metzmacher me...@samba.org
Date:   Wed Jul 6 17:57:45 2011 +0200

s3:libsmb: remove unused clistr_pull_fn()

metze

commit fc992e7029a8cec00b91b50e79f90dea09efcab2
Author: Stefan Metzmacher me...@samba.org
Date:   Thu Jul 7 15:38:02 2011 +0200

s3:torture/scanner: use trans2_bytes_push_str() in scan_nttrans()

metze

commit 02171ee0f06c2558adee82e929e8926123e0a13c
Author: Stefan Metzmacher me...@samba.org
Date:   Thu Jul 7 15:38:02 2011 +0200

s3:torture/scanner: use trans2_bytes_push_str() in 

[SCM] Samba Shared Repository - branch master updated

2011-07-07 Thread Jeremy Allison
The branch, master has been updated
   via  8dc7029 Fix bug #8293 - SMB2 doesn't rotate the log files often 
enough.
   via  eea210e s3:smb2_server: call change_to_root_user() or 
smbd_smb2_request_check_tcon()
  from  6db705d libcli: remove duplicate of #define NT_STATUS_NO_SUCH_JOB

http://gitweb.samba.org/?p=samba.git;a=shortlog;h=master


- Log -
commit 8dc7029561b4d2e02b1f12583b7b871fd4d2ba14
Author: Jeremy Allison j...@samba.org
Date:   Thu Jul 7 14:59:41 2011 -0700

Fix bug #8293 - SMB2 doesn't rotate the log files often enough.

Move the num_requests field out of the smb1 struct into the generic
struct smbd_server_connection struct. Use it to count SMB2 requests
as well as SMB1 and ensure that check_log_size() is called every 50
SMB2 requests.

Autobuild-User: Jeremy Allison j...@samba.org
Autobuild-Date: Fri Jul  8 01:14:53 CEST 2011 on sn-devel-104

commit eea210eba7c20e6d04b13cf8ccd3011ee7c99157
Author: Stefan Metzmacher me...@samba.org
Date:   Thu Jul 7 16:38:33 2011 +0200

s3:smb2_server: call change_to_root_user() or smbd_smb2_request_check_tcon()

For all requests which don't operate on a tcon, we should call
change_to_root_user(), to match the SMB1 behavior.

For SMB1 we do the following operations without AS_USER:

/* 0x70 */ { SMBtcon,reply_tcon,0},
/* 0x71 */ { SMBtdis,reply_tdis,DO_CHDIR},
/* 0x72 */ { SMBnegprot,reply_negprot,0},
/* 0x73 */ { SMBsesssetupX,reply_sesssetup_and_X,0},
/* 0x74 */ { SMBulogoffX,reply_ulogoffX, 0}, /* ulogoff doesn't give a 
valid TID */
/* 0x75 */ { SMBtconX,reply_tcon_and_X,0},
...
/* 0x2b */ { SMBecho,reply_echo,0},
...
/* 0xa4 */ { SMBntcancel,reply_ntcancel, 0 },

For SMB2tdis we still call smbd_smb2_request_check_tcon()
as close_cnum() calls change_to_root_user() when needed.

metze

Signed-off-by: Jeremy Allison j...@samba.org

---

Summary of changes:
 source3/smbd/globals.h |3 +-
 source3/smbd/process.c |4 +-
 source3/smbd/smb2_server.c |   46 +--
 3 files changed, 47 insertions(+), 6 deletions(-)


Changeset truncated at 500 lines:

diff --git a/source3/smbd/globals.h b/source3/smbd/globals.h
index 51ea367..a98936a 100644
--- a/source3/smbd/globals.h
+++ b/source3/smbd/globals.h
@@ -483,6 +483,8 @@ struct smbd_server_connection {
int dirhandles_open;
} searches;
 
+   uint64_t num_requests;
+
struct {
struct fd_event *fde;
 
@@ -510,7 +512,6 @@ struct smbd_server_connection {
int ref_count;
} echo_handler;
 
-   uint64_t num_requests;
struct {
bool encrypted_passwords;
bool spnego;
diff --git a/source3/smbd/process.c b/source3/smbd/process.c
index ca52626..339d005 100644
--- a/source3/smbd/process.c
+++ b/source3/smbd/process.c
@@ -1621,7 +1621,7 @@ static void process_smb(struct smbd_server_connection 
*sconn,
sconn-trans_num++;
 
 done:
-   sconn-smb1.num_requests++;
+   sconn-num_requests++;
 
/* The timeout_processing function isn't run nearly
   often enough to implement 'max log size' without
@@ -1630,7 +1630,7 @@ done:
   level 10.  Checking every 50 SMBs is a nice
   tradeoff of performance vs log file size overrun. */
 
-   if ((sconn-smb1.num_requests % 50) == 0 
+   if ((sconn-num_requests % 50) == 0 
need_to_check_log_size()) {
change_to_root_user();
check_log_size();
diff --git a/source3/smbd/smb2_server.c b/source3/smbd/smb2_server.c
index 1bbb108..5882572 100644
--- a/source3/smbd/smb2_server.c
+++ b/source3/smbd/smb2_server.c
@@ -1139,6 +1139,9 @@ NTSTATUS smbd_smb2_request_dispatch(struct 
smbd_smb2_request *req)
 
switch (opcode) {
case SMB2_OP_NEGPROT:
+   /* This call needs to be run as root */
+   change_to_root_user();
+
{
START_PROFILE(smb2_negprot);
return_value = smbd_smb2_request_process_negprot(req);
@@ -1147,6 +1150,9 @@ NTSTATUS smbd_smb2_request_dispatch(struct 
smbd_smb2_request *req)
break;
 
case SMB2_OP_SESSSETUP:
+   /* This call needs to be run as root */
+   change_to_root_user();
+
{
START_PROFILE(smb2_sesssetup);
return_value = smbd_smb2_request_process_sesssetup(req);
@@ -1160,6 +1166,9 @@ NTSTATUS smbd_smb2_request_dispatch(struct 
smbd_smb2_request *req)
break;
}
 
+   /* This call needs to be run as root */
+   change_to_root_user();
+
   

[SCM] Samba Shared Repository - branch master updated

2011-07-07 Thread Stefan Metzmacher
The branch, master has been updated
   via  ef64048 s3:wscript_build: remove unused variable
   via  960310b s3:selftest: run SMB2-BASIC
   via  67ac266 s3:torture: add SMB2-BASIC
   via  fdd6c4e s3:libsmb: add smb2cli_query_directory*()
   via  548f7d3 s3:libsmb: add smb2cli_write*()
   via  22859b0 s3:libsmb: add smb2cli_read*()
   via  d82be95 s3:libsmb: add smb2cli_flush*()
   via  40ecdeb s3:libsmb: add smb2cli_close*()
   via  2abc34c s3:libsmb: add smb2cli_create*()
   via  f217207 s3:libsmb: add smb2cli_tcon*() and smb2cli_tdis*()
   via  4efc85c s3:libsmb: add smb2cli_sesssetup*() and smb2cli_logoff*()
   via  ab913d1 s3:libsmb: add smb2cli_negprot*()
   via  a0cf7ba s3:libsmb: add basic smb2 client infrastructure
  from  8dc7029 Fix bug #8293 - SMB2 doesn't rotate the log files often 
enough.

http://gitweb.samba.org/?p=samba.git;a=shortlog;h=master


- Log -
commit ef64048038cf6aa706bcbc5d6a17ec86ee6247e9
Author: Stefan Metzmacher me...@samba.org
Date:   Thu Jul 7 19:48:43 2011 +0200

s3:wscript_build: remove unused variable

metze

Autobuild-User: Stefan Metzmacher me...@samba.org
Autobuild-Date: Fri Jul  8 02:43:22 CEST 2011 on sn-devel-104

commit 960310b68d1e57e89ec8ddd0a35ba99c0f2e2aeb
Author: Stefan Metzmacher me...@samba.org
Date:   Fri Jul 8 01:03:49 2011 +0200

s3:selftest: run SMB2-BASIC

metze

commit 67ac266ae85b57c5580a4f4dc1f49396d5ffc707
Author: Stefan Metzmacher me...@samba.org
Date:   Thu May 5 18:12:07 2011 +0200

s3:torture: add SMB2-BASIC

Based on the initial patch from Volker Lendecke v...@samba.org.

metze

commit fdd6c4e673daa21cbf59bce023cfbd753974f48a
Author: Stefan Metzmacher me...@samba.org
Date:   Thu May 5 18:12:07 2011 +0200

s3:libsmb: add smb2cli_query_directory*()

Based on the initial patch from Volker Lendecke v...@samba.org.

metze

commit 548f7d3f36583421c095051290753ed04bebe3c2
Author: Stefan Metzmacher me...@samba.org
Date:   Thu May 5 18:12:07 2011 +0200

s3:libsmb: add smb2cli_write*()

Based on the initial patch from Volker Lendecke v...@samba.org.

metze

commit 22859b0e89e78de92bbf8f0c517475e0fefae623
Author: Stefan Metzmacher me...@samba.org
Date:   Thu May 5 18:12:07 2011 +0200

s3:libsmb: add smb2cli_read*()

Based on the initial patch from Volker Lendecke v...@samba.org.

metze

commit d82be9588add6d80012ffde7aaf38f8b0a6930c6
Author: Stefan Metzmacher me...@samba.org
Date:   Thu May 5 18:12:07 2011 +0200

s3:libsmb: add smb2cli_flush*()

Based on the initial patch from Volker Lendecke v...@samba.org.

metze

commit 40ecdeb3fb1abad44d0a42edc651edbcceeebbc9
Author: Stefan Metzmacher me...@samba.org
Date:   Thu May 5 18:12:07 2011 +0200

s3:libsmb: add smb2cli_close*()

Based on the initial patch from Volker Lendecke v...@samba.org.

metze

commit 2abc34cb4a45d83bfee49a0fb881ba9cbe271249
Author: Stefan Metzmacher me...@samba.org
Date:   Thu May 5 18:12:07 2011 +0200

s3:libsmb: add smb2cli_create*()

Based on the initial patch from Volker Lendecke v...@samba.org.

metze

commit f21720773fc24424921b6731d0b07df38d00d3e0
Author: Stefan Metzmacher me...@samba.org
Date:   Thu May 5 18:12:07 2011 +0200

s3:libsmb: add smb2cli_tcon*() and smb2cli_tdis*()

Based on the initial patch from Volker Lendecke v...@samba.org.

metze

commit 4efc85c6f152ef8cf93e76389659fd8eb019a0ee
Author: Stefan Metzmacher me...@samba.org
Date:   Thu May 5 18:12:07 2011 +0200

s3:libsmb: add smb2cli_sesssetup*() and smb2cli_logoff*()

Based on the initial patch from Volker Lendecke v...@samba.org.

metze

commit ab913d17681183d57f21faf7871ba30b5ae41239
Author: Stefan Metzmacher me...@samba.org
Date:   Thu May 5 18:12:07 2011 +0200

s3:libsmb: add smb2cli_negprot*()

Based on the initial patch from Volker Lendecke v...@samba.org.

metze

commit a0cf7bae60fed5a30a16a99697f74b431456029e
Author: Stefan Metzmacher me...@samba.org
Date:   Thu May 5 18:12:07 2011 +0200

s3:libsmb: add basic smb2 client infrastructure

Based on the initial patch from Volker Lendecke v...@samba.org.

metze

---

Summary of changes:
 source3/Makefile.in  |   15 +-
 source3/include/client.h |   23 ++
 source3/libsmb/smb2cli.h |  175 ++
 source3/libsmb/smb2cli_base.c|  531 ++
 source3/libsmb/smb2cli_base.h|   47 +++
 source3/libsmb/smb2cli_close.c   |  117 +++
 source3/libsmb/smb2cli_create.c  |  253 ++
 source3/libsmb/smb2cli_flush.c   |  116 +++
 source3/libsmb/smb2cli_negprot.c |  163 +