[Samba] Windows7 stalling access to mdb files
Hi, sys: RHEL5 32bit with samba3x packages or latest Sernet rpms (same problems) small domain with XP and w7 (64bit) workstations The main use is an old MS Access based app which shares its mdb file on the server. It works flawlessly with the XP clients though I have not disabled OPLOCKs at all, never had any problem with it neither performance nor any file corruption. The problem is with Win7; the app stalls when opening some tables/views. I have a testcase when copying all tables from the main db to a new file. The copying slows down at around 85mb nearly to a standstill. On the XP clients the whole 400mb file is copied w/o problem. Please give me any advice how to debug this or what logfiles I should send. I don't have smb.conf atm, will reply to this mail as soon as I have. Thx Rainer -- To unsubscribe from this list go to the following URL and read the instructions: https://lists.samba.org/mailman/options/samba
[Samba] Anyone can create empty files (v 3.5.11)
I've mounted my cifs partition with a username and password and to test whether I had my permissions right, I did: $ sudo su testuser $ touch asdf touch: cannot touch `asdf': Permission denied $ It says permission denied, but the `asdf' file is still created. I can't write any data to it, but I can create empty files. This is because in smbd/open.c if the file doesn't exist and O_CREAT flag is set then it lets you open the file without checking smbd_check_open_rights(). Or am I doing something wrong? I'm using Debian testing (wheezy). regards, dan carpenter -- To unsubscribe from this list go to the following URL and read the instructions: https://lists.samba.org/mailman/options/samba
Re: [Samba] LDAP: Mixing local and LDAP-Users
Hi Felipe, thanks for you reply. Once LDAP reports the user is present in the group, the system should do the rest. :) I'll try that. If this isn't possible, is there a way to map more than one group to the rid=512 (ntgroup=Domain Admins)? That's also possible, you should use 'net groupmap' I tried that already, but he keeps telling me that the ntgroup is already mapped (to another group). At the moment, as a workaround, I created an LDAP-User and add him to the local Administrator group on every Win7 machine. So at least I can use LDAP to change the password, etc. Regards, Denis -- To unsubscribe from this list go to the following URL and read the instructions: https://lists.samba.org/mailman/options/samba
Re: [Samba] reseting password and policy; /etc/passwd; /var/lib/samba/
in the past, I've used a wrapper script round smbldap-passwd to enforce policy for complexity. I'd be interested to know if there's another way these days. -- To unsubscribe from this list go to the following URL and read the instructions: https://lists.samba.org/mailman/options/samba
[Samba] Add another site samba4
/Hello Samba4 Alfa17 is up and running Can I add another site from AD sites and services console ? ( Let say second DC in another location ) Or should I keep current structure and use configured Default/-/First/-/Site/-/Name and add second Samba4 server to it ? / -- To unsubscribe from this list go to the following URL and read the instructions: https://lists.samba.org/mailman/options/samba
Re: [Samba] windows 7 64 bit xerox print drivers
On 9/22/2011 6:03 AM, Bruno CAPELETO wrote: Dear Greg, At last I saw your post : I confirm it still does not work and I am glad I am not the only one to say it! I recently reported a bug there : https://bugzilla.samba.org/show_bug.cgi?id=8438 No answer at all so far, as if printing support for 7 was not that important for samba... Coming from the linux world I am not really familiar with the solution you gave : would it be possible for you to write an extensive tutorial for non Windows users ? Bruno Just to add my 2 cents... I went through all kinds of trouble to get HP win7 64 bit drivers to work through samba. I found that they would load using this method... https://bugzilla.samba.org/show_bug.cgi?id=6888 ...but this forces you have a identically named 32 bit driver loaded. In this case the driver was called Universal Print Driver and this caused our 32 bit drivers to be replaced with the 32bit version of Universal Print Driver which was terrible. We had so many printing problems that I had to finally erase the printer tdb's and start over. We are now going to skip samba for printing and print directly to the printers. It's just not worth the trouble. -- To unsubscribe from this list go to the following URL and read the instructions: https://lists.samba.org/mailman/options/samba
Re: [Samba] Slow Directory Access after upgrade to 3.5.6
I am now using log level 3 in samba and the nmbd process shows the following just about every 15 minutes: [2011/09/23 12:09:35.535017, 0] nmbd/nmbd_browsesync.c:350(find_domain_master_name_query_fail) find_domain_master_name_query_fail: Unable to find the Domain Master Browser name MW1b for the workgroup MW. Unable to sync browse lists in this workgroup. [2011/09/23 12:24:42.934861, 0] nmbd/nmbd_browsesync.c:350(find_domain_master_name_query_fail) find_domain_master_name_query_fail: Unable to find the Domain Master Browser name MW1b for the workgroup MW. Unable to sync browse lists in this workgroup. [2011/09/23 12:39:50.847643, 0] nmbd/nmbd_browsesync.c:350(find_domain_master_name_query_fail) find_domain_master_name_query_fail: Unable to find the Domain Master Browser name MW1b for the workgroup MW. Unable to sync browse lists in this workgroup. [2011/09/23 12:55:00.264436, 0] nmbd/nmbd_browsesync.c:350(find_domain_master_name_query_fail) find_domain_master_name_query_fail: Unable to find the Domain Master Browser name MW1b for the workgroup MW. Unable to sync browse lists in this workgroup. smbd process shows the following: [2011/09/23 12:35:40.645624, 0] lib/util_sock.c:1432(get_peer_addr_internal) getpeername failed. Error was Transport endpoint is not connected [2011/09/23 12:42:15.882985, 0] lib/util_sock.c:1432(get_peer_addr_internal) getpeername failed. Error was Transport endpoint is not connected -- To unsubscribe from this list go to the following URL and read the instructions: https://lists.samba.org/mailman/options/samba
Re: [Samba] Slow Directory Access after upgrade to 3.5.6
On Fri, Sep 23, 2011 at 1:01 PM, Mike 1100...@gmail.com wrote: I am now using log level 3 in samba and the nmbd process shows the following just about every 15 minutes: [2011/09/23 12:09:35.535017, 0] nmbd/nmbd_browsesync.c:350(find_domain_master_name_query_fail) find_domain_master_name_query_fail: Unable to find the Domain Master Browser name MW1b for the workgroup MW. Unable to sync browse lists in this workgroup. [2011/09/23 12:24:42.934861, 0] nmbd/nmbd_browsesync.c:350(find_domain_master_name_query_fail) find_domain_master_name_query_fail: Unable to find the Domain Master Browser name MW1b for the workgroup MW. Unable to sync browse lists in this workgroup. [2011/09/23 12:39:50.847643, 0] nmbd/nmbd_browsesync.c:350(find_domain_master_name_query_fail) find_domain_master_name_query_fail: Unable to find the Domain Master Browser name MW1b for the workgroup MW. Unable to sync browse lists in this workgroup. [2011/09/23 12:55:00.264436, 0] nmbd/nmbd_browsesync.c:350(find_domain_master_name_query_fail) find_domain_master_name_query_fail: Unable to find the Domain Master Browser name MW1b for the workgroup MW. Unable to sync browse lists in this workgroup. smbd process shows the following: [2011/09/23 12:35:40.645624, 0] lib/util_sock.c:1432(get_peer_addr_internal) getpeername failed. Error was Transport endpoint is not connected [2011/09/23 12:42:15.882985, 0] lib/util_sock.c:1432(get_peer_addr_internal) getpeername failed. Error was Transport endpoint is not connected Has anyone seen these kinds of log messages before and provide guidance on how to follow-up? Thank you for your help. -- To unsubscribe from this list go to the following URL and read the instructions: https://lists.samba.org/mailman/options/samba
[Samba] ANNOUNCE: cifs-utils release 5.1 available for download
We've had a number of changes since the last release, and we have some other upcoming kernel changes that might require corresponding cifs-utils changes. So it's probably as good a time as any for a new release. Highlights: + fix for a minor security issue that can corrupt the mtab + new getcifsacl/setcifsacl tools that allow you to fetch and set raw Windows ACLs via an xattr. + a lot of manpage patches webpage:http://linux-cifs.samba.org/cifs-utils/ tarball:ftp://ftp.samba.org/pub/linux-cifs/cifs-utils/ git:git://git.samba.org/cifs-utils.git gitweb: http://git.samba.org/?p=cifs-utils.git;a=summary Detailed list of changes since 5.0: commit 2c9e666011c352605a019ee82f39eefb53cc6ad8 Author: Jeff Layton jlay...@samba.org Date: Fri Jul 8 09:59:26 2011 -0400 autoconf: bump release number to 5.0.1 for interim builds Signed-off-by: Jeff Layton jlay...@samba.org commit 775610358cb4cff8a6f322d0e8d5fade078f6f54 Author: Jeff Layton jlay...@samba.org Date: Tue Jul 12 07:30:57 2011 -0400 manpage: add some missing options to mount.cifs.8 Clarify servernetbiosname parameter name, add mention of ignorecase, and add a section on noposixpaths. Signed-off-by: Jeff Layton jlay...@samba.org commit f6eae44a3d05b6515a59651e6bed8b6dde689aec Author: Jeff Layton jlay...@samba.org Date: Tue Jul 12 08:19:33 2011 -0400 mtab: handle ENOSPC/EFBIG condition properly when altering mtab It's possible that when mount.cifs goes to append the mtab that there won't be enough space to do so, and the mntent won't be appended to the file in its entirety. Add a my_endmntent routine that will fflush and then fsync the FILE if that succeeds. If either fails then it will truncate the file back to its provided size. It will then call endmntent unconditionally. Have add_mtab call fstat on the opened mtab file in order to get the size of the file before it has been appended. Assuming that that succeeds, use my_endmntent to ensure that the file is not corrupted before closing it. It's possible that we'll have a small race window where the mtab is incorrect, but it should be quickly corrected. This was reported some time ago as CVE-2011-1678: http://openwall.com/lists/oss-security/2011/03/04/9 ...and it seems to fix the reproducer that I was able to come up with. Signed-off-by: Jeff Layton jlay...@samba.org Reviewed-by: Suresh Jayaraman sjayara...@suse.de commit aa442e80e754f2952b0d90dbdbf2cb2807816ed2 Author: Shirish Pargaonkar shirishpargaon...@gmail.com Date: Mon Jul 18 12:06:03 2011 -0400 manpages: add contents for mount option cifsacl (try #3) Manpage contents for cifs mount option cifsacl Signed-off-by: Shirish Pargaonkar shirishpargaon...@gmail.com commit d791892d901adde0dfb9e8d1099488f078704c73 Author: Jeff Layton jlay...@samba.org Date: Tue Jul 19 08:12:13 2011 -0400 manpage: corrections and cleanups to the cifsacl option sections ..also update the part that describes what kernel version this manpage is accurate against. Signed-off-by: Jeff Layton jlay...@samba.org commit 861824f588a870da7c110b6f199eb5ce7d4dc476 Author: Jeff Layton jlay...@samba.org Date: Tue Jul 19 14:53:47 2011 -0400 cifs-utils: add a note about inclusion of keys.dns_resolver program in keyutils As of version 1.5, the keyutils package is shipping a generic dns_resolver upcall. Add a note to the cifs.upcall manpage that mentions this and recommends the use of that program over cifs.upcall. Eventually, we may want to be able to conditionally compile out the dns_resolver part of the upcall, but it's already pretty small and wouldn't save us very much. Signed-off-by: Jeff Layton jlay...@samba.org commit 1e7a32924b22d1f786b6f490ce8590656f578f91 Author: Jeff Layton jlay...@samba.org Date: Fri Jul 29 07:12:48 2011 -0400 mount.cifs: check_newline returns EX_USAGE on error, not -1 Reported-by: Jan Lieskovsky jlies...@redhat.com Signed-off-by: Jeff Layton jlay...@samba.org commit e0bb4418f79cb8670d06170fcd33c286839d258e Author: Jeff Layton jlay...@samba.org Date: Tue Aug 23 09:02:11 2011 -0400 autoconf: fix help message for --enable-cifsidmap It currently says no is the default, but it should be yes. Reported-by: Elias Pipping pipp...@lavabit.com Signed-off-by: Jeff Layton jlay...@samba.org commit 86ec330e309af06459f8e64aad7899fd3fb7a9bf Author: Shirish Pargaonkar shirishpargaon...@gmail.com Date: Thu Aug 25 14:16:23 2011 -0400 cifsacl: Add file cifsacl.h (try #2) Add defines and structures related to security descriptor, ACL, ACE, various fields within an ACE, and SID. Also define various file permissions and acess types. Signed-off-by: Shirish Pargaonkar shirishpargaon...@gmail.com commit
Re: [Samba] Add another site samba4
Hi Konstantin, On 23/09/2011 07:37, Konstantin Pobudzey wrote: /Hello Samba4 Alfa17 is up and running Can I add another site from AD sites and services console ? ( Let say second DC in another location ) Or should I keep current structure and use configured Default/-/First/-/Site/-/Name and add second Samba4 server to it ? You should be able since a while to create new sites in samba4 but among the new things in alpha17 there is the option to move samba domain controller from 1 site to another without corrupting the database ! Let us know if it didn't work ! -- Matthieu Patou Samba Team http://samba.org -- To unsubscribe from this list go to the following URL and read the instructions: https://lists.samba.org/mailman/options/samba
[SCM] Samba Shared Repository - branch master updated
The branch, master has been updated
via 4383665 python-s4: use PyErr_SetNTSTATUS instead of
PyErr_NTSTATUS_IS_ERR_RAISE as it use NT_STATUS_IS_ERROR which is not
completely the same as NT_STATUS_IS_OK
from 766d43e pys4: really return an exception if the status if not
correct
http://gitweb.samba.org/?p=samba.git;a=shortlog;h=master
- Log -
commit 4383665101db5c2ddb37d5c90ee9304e468b0310
Author: Matthieu Patou m...@matws.net
Date: Thu Sep 22 22:36:36 2011 -0700
python-s4: use PyErr_SetNTSTATUS instead of PyErr_NTSTATUS_IS_ERR_RAISE as
it use NT_STATUS_IS_ERROR which is not completely the same as NT_STATUS_IS_OK
Autobuild-User: Matthieu Patou m...@samba.org
Autobuild-Date: Fri Sep 23 09:22:56 CEST 2011 on sn-devel-104
---
Summary of changes:
source4/ntvfs/posix/python/pyxattr_tdb.c |6 --
1 files changed, 4 insertions(+), 2 deletions(-)
Changeset truncated at 500 lines:
diff --git a/source4/ntvfs/posix/python/pyxattr_tdb.c
b/source4/ntvfs/posix/python/pyxattr_tdb.c
index a08557e..768dcbc 100644
--- a/source4/ntvfs/posix/python/pyxattr_tdb.c
+++ b/source4/ntvfs/posix/python/pyxattr_tdb.c
@@ -60,8 +60,9 @@ static PyObject *py_wrap_setxattr(PyObject *self, PyObject
*args)
status = push_xattr_blob_tdb_raw(eadb, mem_ctx, attribute, filename, -1,
blob);
if (!NT_STATUS_IS_OK(status)) {
+ PyErr_SetNTSTATUS(status);
talloc_free(mem_ctx);
- PyErr_NTSTATUS_IS_ERR_RAISE(status);
+ return NULL;
}
talloc_free(mem_ctx);
Py_RETURN_NONE;
@@ -90,8 +91,9 @@ static PyObject *py_wrap_getxattr(PyObject *self, PyObject
*args)
status = pull_xattr_blob_tdb_raw(eadb, mem_ctx, attribute, filename,
-1,
100, blob);
if (!NT_STATUS_IS_OK(status) || blob.length 0) {
+ PyErr_SetNTSTATUS(status);
talloc_free(mem_ctx);
- PyErr_NTSTATUS_IS_ERR_RAISE(status);
+ return NULL;
}
ret = PyString_FromStringAndSize((char *)blob.data, blob.length);
talloc_free(mem_ctx);
--
Samba Shared Repository
[SCM] Samba Shared Repository - branch master updated
The branch, master has been updated
via 2a789c8 build: Fix waf build on MacOS X
via d40fe50 build: avoid util.h as a public header name due to conflict
with MacOS
from 4383665 python-s4: use PyErr_SetNTSTATUS instead of
PyErr_NTSTATUS_IS_ERR_RAISE as it use NT_STATUS_IS_ERROR which is not
completely the same as NT_STATUS_IS_OK
http://gitweb.samba.org/?p=samba.git;a=shortlog;h=master
- Log -
commit 2a789c8442ce730cac112eeb89c7eb497bb5cc15
Author: Andrew Bartlett abart...@samba.org
Date: Tue Sep 20 18:19:58 2011 -0700
build: Fix waf build on MacOS X
The -framework CoreFoundation is required by the charset_macosxfs module
The system/time.h header is required to access the replacement
clock_gettime()
Andrew Bartlett
Autobuild-User: Andrew Bartlett abart...@samba.org
Autobuild-Date: Fri Sep 23 10:58:02 CEST 2011 on sn-devel-104
commit d40fe50a6755ab701f2fe8a434f1d3331769a4c0
Author: Andrew Bartlett abart...@samba.org
Date: Tue Sep 20 14:26:36 2011 -0700
build: avoid util.h as a public header name due to conflict with MacOS
---
Summary of changes:
lib/async_req/async_sock.c |2 +-
lib/crypto/hmacmd5test.c |2 +-
lib/crypto/md4test.c |2 +-
lib/crypto/md5test.c |2 +-
lib/util/charset/charset_macosxfs.c |2 +-
lib/util/rfc1738.c |2 +-
lib/util/{util.h = samba_util.h}|0
lib/util/wscript_build |4 ++--
librpc/ndr/libndr.h |2 +-
nsswitch/libwbclient/tests/wbclient.c|2 +-
source3/include/includes.h |2 +-
source3/lib/pthreadpool/pthreadpool.c|3 ++-
source3/lib/server_prefork.c |2 +-
source4/dsdb/samdb/ldb_modules/descriptor.c |2 +-
source4/dsdb/samdb/ldb_modules/dirsync.c |2 +-
source4/dsdb/samdb/ldb_modules/extended_dn_in.c |2 +-
source4/dsdb/samdb/ldb_modules/extended_dn_out.c |2 +-
source4/dsdb/samdb/ldb_modules/objectclass.c |2 +-
source4/dsdb/samdb/ldb_modules/schema.c |2 +-
source4/dsdb/samdb/ldb_modules/update_keytab.c |2 +-
source4/dsdb/samdb/ldb_modules/util.c|2 +-
source4/include/includes.h |2 +-
source4/lib/policy/gp_ini.c |2 +-
wscript |4
24 files changed, 28 insertions(+), 23 deletions(-)
rename lib/util/{util.h = samba_util.h} (100%)
Changeset truncated at 500 lines:
diff --git a/lib/async_req/async_sock.c b/lib/async_req/async_sock.c
index 3c68a1c..545d213 100644
--- a/lib/async_req/async_sock.c
+++ b/lib/async_req/async_sock.c
@@ -30,7 +30,7 @@
/* Note: lib/util/ is currently GPL */
#include lib/util/tevent_unix.h
-#include lib/util/util.h
+#include lib/util/samba_util.h
#ifndef TALLOC_FREE
#define TALLOC_FREE(ctx) do { talloc_free(ctx); ctx=NULL; } while(0)
diff --git a/lib/crypto/hmacmd5test.c b/lib/crypto/hmacmd5test.c
index a6621a6..a951409 100644
--- a/lib/crypto/hmacmd5test.c
+++ b/lib/crypto/hmacmd5test.c
@@ -17,7 +17,7 @@
along with this program. If not, see http://www.gnu.org/licenses/.
*/
#include replace.h
-#include ../lib/util/util.h
+#include ../lib/util/samba_util.h
#include ../lib/crypto/crypto.h
struct torture_context;
diff --git a/lib/crypto/md4test.c b/lib/crypto/md4test.c
index 7516e82..4ee05c1 100644
--- a/lib/crypto/md4test.c
+++ b/lib/crypto/md4test.c
@@ -18,7 +18,7 @@
*/
#include replace.h
-#include ../lib/util/util.h
+#include ../lib/util/samba_util.h
#include ../lib/crypto/crypto.h
struct torture_context;
diff --git a/lib/crypto/md5test.c b/lib/crypto/md5test.c
index 0457d4d..38e6531 100644
--- a/lib/crypto/md5test.c
+++ b/lib/crypto/md5test.c
@@ -18,7 +18,7 @@
*/
#include replace.h
-#include ../lib/util/util.h
+#include ../lib/util/samba_util.h
#include ../lib/crypto/crypto.h
struct torture_context;
diff --git a/lib/util/charset/charset_macosxfs.c
b/lib/util/charset/charset_macosxfs.c
index dfd142a..b32aa2b 100644
--- a/lib/util/charset/charset_macosxfs.c
+++ b/lib/util/charset/charset_macosxfs.c
@@ -33,7 +33,7 @@
#include charset_proto.h
#undef realloc
-#ifdef DARWIN
+#ifdef DARWINOS
/*
* Include OS frameworks. These are only needed in this module.
diff --git a/lib/util/rfc1738.c b/lib/util/rfc1738.c
index b45310a..c8f0472 100644
--- a/lib/util/rfc1738.c
+++ b/lib/util/rfc1738.c
@@ -50,7 +50,7 @@
#include includes.h
-#include util.h
+#include lib/util/samba_util.h
/*
* RFC 1738 defines that these characters should be escaped, as well
diff --git a/lib/util/util.h
[SCM] Samba Shared Repository - branch master updated
The branch, master has been updated
via 5494856 s3:smbd: disconnect the socket if we got an unexpected
request
via 02d83d8 s3:smbd: don't call smbd_terminate_connection in
smb2_validate_message_id() (bug #8476)
from 2a789c8 build: Fix waf build on MacOS X
http://gitweb.samba.org/?p=samba.git;a=shortlog;h=master
- Log -
commit 5494856294384df4360d85e68abc03c43dc16e06
Author: Stefan Metzmacher me...@samba.org
Date: Fri Sep 23 06:37:35 2011 +0200
s3:smbd: disconnect the socket if we got an unexpected request
If we got a SMB2_OP_NEGPROT after the protocol is already negotiated
or if we got a non SMB2_OP_NEGPROT before the protocol was negotiated
we should close the connection (as windows does).
metze
Autobuild-User: Stefan Metzmacher me...@samba.org
Autobuild-Date: Fri Sep 23 12:30:50 CEST 2011 on sn-devel-104
commit 02d83d8fd4d21825110fd7da1ccb570a26e66ca6
Author: Stefan Metzmacher me...@samba.org
Date: Fri Sep 23 06:08:51 2011 +0200
s3:smbd: don't call smbd_terminate_connection in smb2_validate_message_id()
(bug #8476)
Only return false and the caller will terminate the connection.
metze
---
Summary of changes:
source3/smbd/smb2_negprot.c |1 -
source3/smbd/smb2_server.c | 25 +++--
2 files changed, 23 insertions(+), 3 deletions(-)
Changeset truncated at 500 lines:
diff --git a/source3/smbd/smb2_negprot.c b/source3/smbd/smb2_negprot.c
index 15bff82..c5ac2d5 100644
--- a/source3/smbd/smb2_negprot.c
+++ b/source3/smbd/smb2_negprot.c
@@ -101,7 +101,6 @@ NTSTATUS smbd_smb2_request_process_negprot(struct
smbd_smb2_request *req)
uint32_t max_read = lp_smb2_max_read();
uint32_t max_write = lp_smb2_max_write();
-/* TODO: drop the connection with INVALID_PARAMETER */
status = smbd_smb2_request_verify_sizes(req, 0x24);
if (!NT_STATUS_IS_OK(status)) {
diff --git a/source3/smbd/smb2_server.c b/source3/smbd/smb2_server.c
index 0ffeb48..35da2af 100644
--- a/source3/smbd/smb2_server.c
+++ b/source3/smbd/smb2_server.c
@@ -323,8 +323,9 @@ static bool smb2_validate_message_id(struct
smbd_server_connection *sconn,
}
if (sconn-smb2.credits_granted == 0) {
- smbd_server_connection_terminate(sconn,
smb2_validate_message_id:
- terminating connection: client used more credits than
granted\n);
+ DEBUG(0,(smb2_validate_message_id: client used more
+credits than granted message_id (%llu)\n,
+(unsigned long long)message_id));
return false;
}
@@ -1332,6 +1333,26 @@ NTSTATUS smbd_smb2_request_dispatch(struct
smbd_smb2_request *req)
smb2_opcode_name(opcode),
(unsigned long long)mid));
+ if (get_Protocol() = PROTOCOL_SMB2_02) {
+ /*
+* once the protocol is negotiated
+* SMB2_OP_NEGPROT is not allowed anymore
+*/
+ if (opcode == SMB2_OP_NEGPROT) {
+ /* drop the connection */
+ return NT_STATUS_INVALID_PARAMETER;
+ }
+ } else {
+ /*
+* if the protocol is not negotiated yet
+* only SMB2_OP_NEGPROT is allowed.
+*/
+ if (opcode != SMB2_OP_NEGPROT) {
+ /* drop the connection */
+ return NT_STATUS_INVALID_PARAMETER;
+ }
+ }
+
allowed_flags = SMB2_HDR_FLAG_CHAINED |
SMB2_HDR_FLAG_SIGNED |
SMB2_HDR_FLAG_DFS;
--
Samba Shared Repository
autobuild: intermittent test failure detected
The autobuild test system has detected an intermittent failing test in the current master tree. The autobuild log of the failure is available here: http://git.samba.org/autobuild.flakey/2011-09-23-1420/flakey.log The samba3 build logs are available here: http://git.samba.org/autobuild.flakey/2011-09-23-1420/samba3.stderr http://git.samba.org/autobuild.flakey/2011-09-23-1420/samba3.stdout The source4 build logs are available here: http://git.samba.org/autobuild.flakey/2011-09-23-1420/samba4.stderr http://git.samba.org/autobuild.flakey/2011-09-23-1420/samba4.stdout The top commit at the time of the failure was: commit 5494856294384df4360d85e68abc03c43dc16e06 Author: Stefan Metzmacher me...@samba.org Date: Fri Sep 23 06:37:35 2011 +0200 s3:smbd: disconnect the socket if we got an unexpected request If we got a SMB2_OP_NEGPROT after the protocol is already negotiated or if we got a non SMB2_OP_NEGPROT before the protocol was negotiated we should close the connection (as windows does). metze Autobuild-User: Stefan Metzmacher me...@samba.org Autobuild-Date: Fri Sep 23 12:30:50 CEST 2011 on sn-devel-104
[SCM] Samba Shared Repository - branch master updated
The branch, master has been updated
via ca8c25a Fix bug 8480 - acl_xattr can free an invalid pointer if no
blob is loaded.
via 8119926 Revert Add a missing include file to two VFS modules
from 5494856 s3:smbd: disconnect the socket if we got an unexpected
request
http://gitweb.samba.org/?p=samba.git;a=shortlog;h=master
- Log -
commit ca8c25abebb8715176f68be9916217db9a8400dd
Author: David Disseldorp dd...@suse.de
Date: Fri Sep 23 11:46:06 2011 -0700
Fix bug 8480 - acl_xattr can free an invalid pointer if no blob is loaded.
Autobuild-User: Jeremy Allison j...@samba.org
Autobuild-Date: Fri Sep 23 22:20:55 CEST 2011 on sn-devel-104
commit 8119926b3a13e261018a3f7b09cae5baf3abd30a
Author: Jeremy Allison j...@samba.org
Date: Thu Sep 15 15:55:30 2011 -0700
Revert Add a missing include file to two VFS modules
My mistake - should have been 3.6.x only.
This reverts commit 2e4d0641950ce6e38724ca71b46cf925f51ac7be.
---
Summary of changes:
source3/modules/gpfs.c |1 -
source3/modules/vfs_acl_common.c |2 +-
source3/modules/vfs_prealloc.c |1 -
3 files changed, 1 insertions(+), 3 deletions(-)
Changeset truncated at 500 lines:
diff --git a/source3/modules/gpfs.c b/source3/modules/gpfs.c
index 52a9331..5b0d7d0 100644
--- a/source3/modules/gpfs.c
+++ b/source3/modules/gpfs.c
@@ -20,7 +20,6 @@
#include includes.h
#include system/filesys.h
#include smbd/smbd.h
-#include system/filesys.h
#ifdef HAVE_GPFS
diff --git a/source3/modules/vfs_acl_common.c b/source3/modules/vfs_acl_common.c
index 9a1d13b..2ed3cac 100644
--- a/source3/modules/vfs_acl_common.c
+++ b/source3/modules/vfs_acl_common.c
@@ -253,7 +253,7 @@ static NTSTATUS get_nt_acl_internal(vfs_handle_struct
*handle,
uint32_t security_info,
struct security_descriptor **ppdesc)
{
- DATA_BLOB blob;
+ DATA_BLOB blob = data_blob_null;
NTSTATUS status;
uint16_t hash_type = XATTR_SD_HASH_TYPE_NONE;
uint8_t hash[XATTR_SD_HASH_SIZE];
diff --git a/source3/modules/vfs_prealloc.c b/source3/modules/vfs_prealloc.c
index 73f1a93..fb2e46e 100644
--- a/source3/modules/vfs_prealloc.c
+++ b/source3/modules/vfs_prealloc.c
@@ -20,7 +20,6 @@
#include includes.h
#include system/filesys.h
#include smbd/smbd.h
-#include system/filesys.h
/* Extent preallocation module.
*
--
Samba Shared Repository
